Request for review (XS): 8006563: Remove unused ProfileVM_lock

Aleksey Shipilev aleksey.shipilev at
Fri Jan 18 05:12:44 PST 2013

On 01/18/2013 04:58 PM, Rickard Bäckman wrote:

Looks good to me (not a Reviewer), modulo:
 a) Are we sure this thing is not acquired in some weird way, i.e.
through JVMTI, SA, or whatnot?
 b) The formatting of the predicate does not follow it's structure, I
think it should be:
     this != Interrupt_lock &&
     !(this == Safepoint_lock &&
       contains(locks, Terminator_lock) &&
       SafepointSynchronize::is_synchronizing())) {

This way it is more obvious SafepointSynchronize::is_synchronizing()) is
the !(...) group.


More information about the hotspot-runtime-dev mailing list