Request for review: 7197627: There are issues with shared data on windows
Daniel D. Daugherty
daniel.daugherty at oracle.com
Wed Jan 30 06:20:11 PST 2013
On 1/30/13 6:39 AM, harold seigel wrote:
> Please review the following change to fix bug 7197627.
> The original fix for this bug created the CDS classes.jsa file with
> read/write protection. This change creates the file with read-only
> protection and only changes the file/s protection to read/write when
> deleting the file. This is a safer implementation.
> This was tested on Windows 7 and Windows XP and sanity tested on Linux.
> Open webrev at http://cr.openjdk.java.net/~hseigel/bug_7197672/
> Bug link at http://bugs.sun.com/view_bug.do?bug_id=7197672
> Thanks! Harold
Thumbs up on the safer change.
217 // Remove the existing file in case another process has it open.
bothers me. On Windows, if another process has the classes.jsa file
open, then you won't be able to remove it (or move it or...) so the
comment is misleading. Or I'm wrong about Windows which could easily
More information about the hotspot-runtime-dev