RFR: 8000973: SA on windows thread inspection is broken
yumin.qi at oracle.com
Thu Jan 31 11:12:33 PST 2013
On 1/31/2013 11:10 AM, serguei.spitsyn at oracle.com wrote:
> Hi Yumin,
> Looks good.
> A couple of minor comments.
> 1. All the copyright comments are outdated.
> 37 //The address argument must be the address of the OSThread::_thread_id
> Space is missed at the beginning of comment.
> 39 this.debugger = debugger;
> * 40 this.sysId = (long)addr.getCIntegerAt(0, 4, true);*
> The '=' is not aligned properly and extra space after '='.
> On 1/30/13 11:16 PM, Yumin Qi wrote:
>> Please have your comments on:
>> This only affected Windows platform.
>> Summary: After bug 7161732, On Windows SA could not find correct
>> address of thread_id of OSThread since _thread_id moved to end of the
>> class . The presupposition of the address is following thread handle
>> no longer stands. Fix by adding thread_id field to OSThread and
>> getting the address directly from OSThread.
>> Contributed-by: yumin.qi at oracle.com
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-runtime-dev