RFR(xxs): 8202303: LogStream should autoflush on destruction

David Holmes david.holmes at oracle.com
Wed May 2 07:19:27 UTC 2018

Hi Thomas,

On 2/05/2018 3:26 PM, Thomas Stüfe wrote:
> Ping...
> this is a really simple one :) Please review. Thanks!

Was hoping our logging experts would chime in here.

This looks okay to me. My main concern would be that everything is torn 
down in the correct order for this to work reliably.


> On Thu, Apr 26, 2018 at 8:34 AM, Thomas Stüfe <thomas.stuefe at gmail.com> wrote:
>> Hi all,
>> please review this tiny change:
>> https://bugs.openjdk.java.net/browse/JDK-8202303
>> http://cr.openjdk.java.net/~stuefe/webrevs/8202303-logstream-autoflush/webrev.00/webrev/
>> Basically, LogStream should not assert upon desctruction when having
>> buffered unfinished lines; instead, it should autoflush.
>> (Note: the changes to the TestLineBufferAllocation test are just to
>> keep this test in line with the rest of the tests in regards to how
>> the fake log file is handled).
>> More details in my earlier mail to hs-runtime:
>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2018-April/027592.html
>> Thanks, Thomas

More information about the hotspot-runtime-dev mailing list