RFR(M): 8199252: [TESTBUG] Open source VM testbase system dictionary tests

Gerard Ziemski gerard.ziemski at oracle.com
Tue May 15 18:24:25 UTC 2018

hi Misha,

Looks fine.

Just to be sure: did you have to make any functional changes to the test source code, or was it pretty much a straightforward case of moving the files?

Thanks for doing this.


> On May 11, 2018, at 4:10 PM, Mikhailo Seledtsov <mikhailo.seledtsov at oracle.com> wrote:
> Please review this change open sourcing VM system dictionary tests. These tests have been used internally for a while, and are now being open sourced.
> Since this is not an creation of new tests, simply open sourcing existing tests, we would like to keep the changes during this review to an absolute required minimum. If you have any feedback on improvements of these tests, please file RFE(s) that will be addressed later in order of priority.
> Here is what was done for this change:
>  1. Moved the tests to OpenJDK repository preserving relative directory location and structure.
>  3. Updated Copyright statements accordingly.
>  4. Updated "@library" statements accordingly.
>  5. Updated TEST.groups
>  JBS:    https://bugs.openjdk.java.net/browse/JDK-8199252
>  Webrev: http://cr.openjdk.java.net/~mseledtsov/8199252.01.open/
>  Testing:
>      1. Ran the following tests on open-only repository and build, using "make run-test"
>         (Linux-x64)
>         vmTestbase_nsk_sysdict
>         All PASS
>      2. Automated multip-platform test system (usual 4 platforms):
>         - vmTestbase_nsk_sysdict
>         - hs-tier{1,2}
>         In progress
> Thank you,
> Misha

More information about the hotspot-runtime-dev mailing list