RFR (S) 8134537: Much nearly duplicated code for sun.misc.Signal support

Thomas Stüfe thomas.stuefe at gmail.com
Fri May 18 05:49:14 UTC 2018

Hi Coleen,

fix looks good. You are right, there are many more similarities, but
too different to do it within limited time.

Thanks, Thomas

On Thu, May 17, 2018 at 10:26 PM,  <coleen.phillimore at oracle.com> wrote:
> Summary: merged jvm_<os>.cpp into jvm_posix.cpp mostly
> See bug for more info.  The os_<os>.cpp code is sort of duplicated but
> different enough to not be worth refactoring, for this feature.  I was in
> the area, so merged this one part.
> Tested with hs-tier1,2 runtime/signal tests and
> sun/misc/SunMiscSignalTest.java.
> open webrev at http://cr.openjdk.java.net/~coleenp/8134537.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8134537
> Thanks,
> Coleen

More information about the hotspot-runtime-dev mailing list