RFR (S) 8202669: Intermittent crash in ClassLoadingService::compute_class_size()
lois.foltan at oracle.com
Tue May 22 13:59:15 UTC 2018
On 5/21/2018 7:01 PM, coleen.phillimore at oracle.com wrote:
> Summary: Don't report classes that failed to load when reporting class
> unloading. Remove the classes first.
> Also add a NULL check for transitive_interfaces for safety, but the
> new tests pass without it and fail without the fix.
> open webrev at http://cr.openjdk.java.net/~coleenp/8202669.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8202669
> Tested with hs-tier1-5.
Looks good. A couple of review comments:
- classLoaderData.cpp, line #590 "erroreous" or should that be "erroneous"?
- can the 2 tests be combined into 1?
- use "throw new RuntimeException" instead of "throw new Exception", see
line #61 in TestLoadObject.java
More information about the hotspot-runtime-dev