RFR (S) 8202669: Intermittent crash in ClassLoadingService::compute_class_size()
calvin.cheung at oracle.com
Tue May 22 16:14:06 UTC 2018
The changes look good. Thank you for fixing it.
On 5/22/18, 9:02 AM, coleen.phillimore at oracle.com wrote:
> Thank you for the code review!
> On 5/22/18 9:59 AM, Lois Foltan wrote:
>> On 5/21/2018 7:01 PM, coleen.phillimore at oracle.com wrote:
>>> Summary: Don't report classes that failed to load when reporting
>>> class unloading. Remove the classes first.
>>> Also add a NULL check for transitive_interfaces for safety, but the
>>> new tests pass without it and fail without the fix.
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8202669.01/webrev
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8202669
>>> Tested with hs-tier1-5.
>> Looks good. A couple of review comments:
>> - classLoaderData.cpp, line #590 "erroreous" or should that be
>> - can the 2 tests be combined into 1?
> Yes, I combined them in TestUnloadClassError.java. Thank you for your
>> - use "throw new RuntimeException" instead of "throw new Exception",
>> see line #61 in TestLoadObject.java
> TestUnloadClassError.java throws RuntimeException so that's fixed too.
> FTR: http://cr.openjdk.java.net/~coleenp/8202669.02/webrev
> Thank you!
More information about the hotspot-runtime-dev