RFR(xxxs, trivial): 8203865: Metaspace cleanup: Remove unused MemRegion in VirtualSpaceNode

David Holmes david.holmes at oracle.com
Mon May 28 06:47:07 UTC 2018

Hi Thomas,

On 28/05/2018 4:28 PM, Thomas Stüfe wrote:
> Hi all,
> very tiny cleanup.
> May I get a review (I consider this trivial):

I'd like someone to confirm that the deleted asserts are still logically 
being checked elsewhere.

Otherwise this cleanup seems ok.


> Bug: https://bugs.openjdk.java.net/browse/JDK-8203865
> Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8203865-Remove-unused-MemRegion-in-VirtualSpaceNode/webrev.00/webrev/
> VirtualSpaceNode contains: MemRegion _reserved;
> This member is not used and serves no purpose. It keeps track of the
> reserved memory location, but that is redundant since the underlying
> ReservedSpace does the same. It is also nowhere used. So it should be
> removed.
> Best Regards, Thomas

More information about the hotspot-runtime-dev mailing list