RFR (M): 8203881: Print errornous size in NegativeArraySizeException
thomas.stuefe at gmail.com
Mon May 28 12:16:09 UTC 2018
On Mon, May 28, 2018 at 2:10 PM, Lindenmaier, Goetz
<goetz.lindenmaier at sap.com> wrote:
> Hi David,
> thanks for having a look!
>> First I have corrected the typo in the synopsis: errornous -> erroneous
>> Second, can you not use the err_msg function instead of the explicit
>> ResourceMark + stringStream code?
> Yes, that's much better. New webrev:
> Best regards,
looks good, but I would probably use a smaller Format Buffer. Default
(e.g. err_msg) uses 256 bytes of stack space, seems a bit much for a
Leave it up to you if you take the suggestion.
p.s. that's not M :-)
>> On 28/05/2018 8:40 PM, Lindenmaier, Goetz wrote:
>> > Hi,
>> > This change adds printing the array size in case of negative array size
>> > Please review.
>> > http://cr.openjdk.java.net/~goetz/wr18/8203881-exMsg-
>> > Thanks,
>> > Goetz.
More information about the hotspot-runtime-dev