RFR (M): 8203881: Print errornous size in NegativeArraySizeException

David Holmes david.holmes at oracle.com
Mon May 28 13:17:44 UTC 2018

Hi Goetz,

On 28/05/2018 10:10 PM, Lindenmaier, Goetz wrote:
> Hi David,
> thanks for having a look!
>> First I have corrected the typo in the synopsis: errornous -> erroneous
> Thanks!
>> Second, can you not use the err_msg function instead of the explicit
>> ResourceMark + stringStream code?
> Yes, that's much better. New webrev:
> http://cr.openjdk.java.net/~goetz/wr18/8203881-exMsg-NegativeArraySize/02

The functional change seems fine.

For the test have you checked that all 7 changes are hit by the 
testcase? I'm curious as to what kinds of array allocations hit the 
different bits of code. I confess I'm not sure what a typeArray is 
versus an objArray. I only expected to see 4 cases here: reference or 
primitive plus single-dim or multi. Plus the two reflection cases. That 
leaves one I can't account for. :)

Possibly overkill to test (implicit) interpreter plus C1 plus C2, given 
there is no JIT specific code involved - at least I can't see any.


> Best regards,
>    Goetz.
>> Thanks,
>> David
>> On 28/05/2018 8:40 PM, Lindenmaier, Goetz wrote:
>>> Hi,
>>> This change adds printing the array size in case of negative array size
>> exception.
>>> Please review.
>>> http://cr.openjdk.java.net/~goetz/wr18/8203881-exMsg-
>> NegativeArraySize/01/
>>> Thanks,
>>>     Goetz.

More information about the hotspot-runtime-dev mailing list