RFR 8210300: runtime/MemberName/MemberNameLeak.java fails with RuntimeException

David Holmes david.holmes at oracle.com
Tue Sep 11 01:31:49 UTC 2018

Hi Patricio,

On 10/09/2018 11:57 PM, Patricio Chilano wrote:
> Hi all,
> Could you review this small fix to tests CleanProtectionDomain.java and 
> MemberNameLeak.java?
> It adds flag UnlockDiagnosticVMOptions needed in product builds. It also 
> calls System.gc() periodically to avoid relaying on a single call, and 
> adds a short sleep between polls.

Functionally looks fine. Any particular reason for the 3 second GC delay?

Style-wise other than what Dan pointed out, it's preferred to always use 
braces with if-statements and use multiple lines ie:

if (x) {

rather than:

if (x) f();

No need for updated webrev if you change.


> Bug URL: https://bugs.openjdk.java.net/browse/JDK-8210300
> Webrev URL: http://cr.openjdk.java.net/~pchilanomate/8210300.01/webrev
> Thanks,
> Patricio

More information about the hotspot-runtime-dev mailing list