RFR 8209645: Split ClassLoaderData and ClassLoaderDataGraph into separate files

Thomas Stüfe thomas.stuefe at gmail.com
Thu Sep 27 20:31:39 UTC 2018

Hi Coleen,

this looks good (not an easy patch to review, but I think all that
code just moved without changing).

Are all includes in the new classLoaderDataGraph.cpp really needed ? I
found e.g. no reference to SymbolTable, so I am not sure
symbolTable.hpp is needed. I may be off though.

Does ClassLoaderDataGraphMetaspaceIterator have to be implemented
fully in a header (classLoaderDataGraph.hpp)? But this preceedes your

Thanks for making classLoaderData.cpp smaller :)

Cheers, Thomas

On Thu, Sep 27, 2018 at 7:51 PM,  <coleen.phillimore at oracle.com> wrote:
> I think this might be as good of a time as any to split these files.  This
> should help with too much coupling between the graph and the class loader
> data itself.  The only function changed and not moved is added an API in
> ClassLoaderDataGraph.
>  110   static void adjust_saved_class(ClassLoaderData* cld);
>  111   static void adjust_saved_class(Klass* klass);
> open webrev at http://cr.openjdk.java.net/~coleenp/8209645.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8209645
> Tested for mach5 hs-tier1-3
> Thanks,
> Coleen

More information about the hotspot-runtime-dev mailing list