<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix"><br>
      Looks good!<br>
      Coleen<br>
      <br>
      On 1/17/2013 10:04 PM, Jon Masamitsu wrote:<br>
    </div>
    <blockquote cite="mid:50F8BBB2.70003@oracle.com" type="cite">
      <meta http-equiv="content-type" content="text/html;
        charset=ISO-8859-1">
      <br>
      <br>
      -------- Original Message --------
      <table class="moz-email-headers-table" border="0" cellpadding="0"
        cellspacing="0">
        <tbody>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">Subject:
            </th>
            <td>Re: Request for review 8006537: Assert when dumping
              archive with default methods</td>
          </tr>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">Date: </th>
            <td>Thu, 17 Jan 2013 18:44:04 -0800</td>
          </tr>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">From: </th>
            <td>Jon Masamitsu <a moz-do-not-send="true"
                class="moz-txt-link-rfc2396E"
                href="mailto:jon.masamitsu@oracle.com">&lt;jon.masamitsu@oracle.com&gt;</a></td>
          </tr>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">Organization:

            </th>
            <td>Oracle</td>
          </tr>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">To: </th>
            <td><a moz-do-not-send="true"
                class="moz-txt-link-abbreviated"
                href="mailto:hotspot-gc-dev@openjdk.java.net">hotspot-gc-dev@openjdk.java.net</a></td>
          </tr>
        </tbody>
      </table>
      <br>
      <br>
      <pre>New summary but same bug - 8006537

New fix from Coleen that is a fix and not a workaround.

<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Ejmasa/8006537/webrev.00/">http://cr.openjdk.java.net/~jmasa/8006537/webrev.00/</a>

Sorry about wasting people's time with the previous
attempt.

Thanks.

Jon

On 01/17/13 16:00, Jon Masamitsu wrote:
&gt; JohnC,
&gt;
&gt; Thanks for you prompt review.
&gt;
&gt; All,
&gt;
&gt; These bugs have broken the hotspot build so I'm
&gt; eager to get them back so will try pushing them
&gt; soon.  Other comments are always welcome.
&gt;
&gt; Jon
&gt;
&gt; On 01/17/13 15:15, Jon Masamitsu wrote:
&gt;&gt;  8006537: Missing initialization of Metaspace variables with 
&gt;&gt; -Xshare:dump
&gt;&gt;
&gt;&gt; Always initialize _first_chunk_word_size and 
&gt;&gt; _first_class_chunk_word_size.
&gt;&gt; Prior to b73 these variables were not being used extensively (if at all)
&gt;&gt; when DumpSharedSpace was on.  With b73 they need to be used.
&gt;&gt;
&gt;&gt; When DumpSharedSpace was on previous to b73 there was not a second
&gt;&gt; call to the constructor for VirtualSpaceNode so the initialization 
&gt;&gt; done for
&gt;&gt; DumpSharedSpace was not called a second time and did not cause a 
&gt;&gt; problem.
&gt;&gt; With b73 and DumpSharedSpace it is called a second time so the 
&gt;&gt; initialization
&gt;&gt; for DumpSharedSpace had to be short circuited. This is a workaround. A
&gt;&gt; better fix would be to move the DumpSharedSpace initialization code 
&gt;&gt; to an
&gt;&gt; appropriate place.
&gt;&gt;
&gt;&gt; <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Ejmasa/8006537/webrev.00/">http://cr.openjdk.java.net/~jmasa/8006537/webrev.00/</a>
&gt;&gt;
&gt;&gt; Thanks.
</pre>
    </blockquote>
    <br>
  </body>
</html>