<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">Hi Coleen,<br>
      <br>
      I've reviewed the_2 version.<br>
      It looks good.<br>
      <br>
      One nit.<br>
      <br>
      <meta http-equiv="content-type" content="text/html;
        charset=ISO-8859-1">
      <code></code>
      <b>src/share/vm/oops/constantPool.hpp</b><br>
      <meta http-equiv="content-type" content="text/html;
        charset=ISO-8859-1">
      <pre><span class="changed">  98   enum {</span>
<span class="changed">  99     _has_invokedynamic = 1,           // Flags</span>
<span class="changed"> 100     _has_pseudo_string = 2,</span>
<span class="changed"> 101     _has_preresolution = 4,</span>
<span class="changed"> 102     _on_stack          = 8</span>
<span class="changed"> 103   };

As the above are constants then would it make sense to use capital letters?


Thanks,
Serguei
</span></pre>
      <br>
      <br>
      On 1/18/13 8:41 AM, Coleen Phillimore wrote:<br>
    </div>
    <blockquote cite="mid:50F97B3C.5050206@oracle.com" type="cite">
      <br>
      This is relatively easy, anyone?&nbsp;&nbsp; Also, it doesn't affect the
      SA.&nbsp; I checked.
      <br>
      Thanks,
      <br>
      Coleen
      <br>
      <br>
      On 1/16/2013 4:23 PM, Coleen Phillimore wrote:
      <br>
      <blockquote type="cite">Summary: Added on_stack bit to _flags.&nbsp;
        Also MetadataMarkOnStack is used for more than JVMTI so had to
        be moved.
        <br>
        <br>
        Confirmed with John and Chris that setting invokedynamic bits
        doesn't require atomic operations so I can add on_stack to the
        flags.
        <br>
        <br>
        open webrev at <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~coleenp/8006040/">http://cr.openjdk.java.net/~coleenp/8006040/</a>
        <br>
        bug link at <a class="moz-txt-link-freetext" href="http://bugs.sun.com/view_bug.do?bug_id=8006040">http://bugs.sun.com/view_bug.do?bug_id=8006040</a>
        <br>
        <br>
        Tested NSK quick.testlist and runThese.
        <br>
        <br>
        Thanks,
        <br>
        Coleen
        <br>
      </blockquote>
      <br>
    </blockquote>
    <br>
  </body>
</html>