<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
    <title></title>
  </head>
  <body bgcolor="#ffffff" text="#000000">
    <br>
    Mikael,<br>
    This looks good to me too.&nbsp; Thank you for finding these.<br>
    Coleen<br>
    <br>
    On 1/31/2013 7:08 PM, Vitaly Davidovich wrote:
    <blockquote
cite="mid:CAHjP37EsJ+vWJGPi+4_+YYSceYE5sfHiWkVX1BFwxGPBLZpwUA@mail.gmail.com"
      type="cite">
      <p dir="ltr">Looks good to me (I'm not an official reviewer
        though).</p>
      <p dir="ltr">Thanks</p>
      <p dir="ltr">Sent from my phone</p>
      <div class="gmail_quote">On Jan 31, 2013 12:11 PM, "Mikael
        Vidstedt" &lt;<a moz-do-not-send="true"
          href="mailto:mikael.vidstedt@oracle.com">mikael.vidstedt@oracle.com</a>&gt;
        wrote:<br type="attribution">
        <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
          0.8ex; border-left: 1px solid rgb(204, 204, 204);
          padding-left: 1ex;">
          <div text="#000000" bgcolor="#FFFFFF">
            <div><br>
              Vitaly,<br>
              <br>
              Thanks for the review, and good catch! An updated webrev
              can be found here:<br>
              <br>
              <a moz-do-not-send="true"
                href="http://cr.openjdk.java.net/%7Emikael/8007257/webrev.01/webrev"
                target="_blank">http://cr.openjdk.java.net/~mikael/8007257/webrev.01/webrev</a><br>
              <br>
              Cheers,<br>
              Mikael<br>
              <br>
              On 2013-01-30 19:18, Vitaly Davidovich wrote:<br>
            </div>
            <blockquote type="cite">
              <p dir="ltr">Hi Mikael,</p>
              <p dir="ltr">Shouldn't this assert:</p>
              <p dir="ltr">assert(chunk_word_size != 0 &amp;&amp;
                class_chunk_word_size != 0,<br>
                1741&nbsp;&nbsp;&nbsp;&nbsp; err_msg("Initial chunks sizes bad: data&nbsp; "
                SIZE_FORMAT<br>
                1742&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; " class " SIZE_FORMAT,<br>
                1743&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; *chunk_word_size,
                *class_chunk_word_size));</p>
              <p dir="ltr">be (deref the values in the pointers):</p>
              <p dir="ltr">assert(*chunk_word_size != 0 &amp;&amp;
                *class_chunk_word_size != 0,<br>
                1741&nbsp;&nbsp;&nbsp;&nbsp; err_msg("Initial chunks sizes bad: data&nbsp; "
                SIZE_FORMAT<br>
                1742&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; " class " SIZE_FORMAT,<br>
                1743&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; *chunk_word_size,
                *class_chunk_word_size));</p>
              <p dir="ltr">Otherwise it's testing something other than
                what I think it's trying to test.</p>
              <p dir="ltr">Thanks</p>
              <p dir="ltr">Sent from my phone</p>
              <div class="gmail_quote">On Jan 30, 2013 7:53 PM, "Mikael
                Vidstedt" &lt;<a moz-do-not-send="true"
                  href="mailto:mikael.vidstedt@oracle.com"
                  target="_blank">mikael.vidstedt@oracle.com</a>&gt;
                wrote:<br type="attribution">
                <blockquote class="gmail_quote" style="margin: 0pt 0pt
                  0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204);
                  padding-left: 1ex;"> <br>
                  Please review the following webrev:<br>
                  <br>
                  <a moz-do-not-send="true"
                    href="http://cr.openjdk.java.net/%7Emikael/8007257/webrev.00/"
                    target="_blank">http://cr.openjdk.java.net/~mikael/8007257/webrev.00/</a><br>
                  <br>
                  <br>
                  The key part of the fix is the change in
                  SpaceManager::get_initial_chunk_sizes(), where the
                  intention is to print out the actual sizes, but
                  accidentally the arguments to err_msg are pointers to
                  the values.<br>
                  <br>
                  I also found three other mismatching format/arguments
                  which I fixed while at it:<br>
                  <br>
                  HumongousChunkGranularity is an enum, which is an int,
                  and therefore should be printed using %d. The others
                  fixes are for size_t and uintx variables and should be
                  printed using those respective formats.<br>
                  <br>
                  Cheers,<br>
                  Mikael<br>
                  <br>
                </blockquote>
              </div>
            </blockquote>
            <br>
          </div>
        </blockquote>
      </div>
    </blockquote>
  </body>
</html>