From aph at redhat.com Sat Dec 1 10:43:13 2018 From: aph at redhat.com (Andrew Haley) Date: Sat, 1 Dec 2018 10:43:13 +0000 Subject: Yocto Sumo [Was: OpenJDK 8 Segfault on Startup] In-Reply-To: References: Message-ID: <2d6f2351-6296-6c7a-0f5e-3208b3f6e185@redhat.com> On 11/26/18 2:22 PM, Attie Grande wrote: > I've been trying to get OpenJDK 8 running on Linux on an ARM platform, > using the Yocto Sumo recipes from meta-java [1]. I've never seen this Yocto stuff before. This is the support matrix: +--------+-----------------+-----------------+-----------------+ | | OpenJDK-7/glibc | OpenJDK-8/glibc | OpenJDK-8/musl | +--------+-----------------+-----------------+-----------------+ | arm | O K | int. mode | int. mode | +--------+-----------------+-----------------+-----------------+ | armv7 | O K | O K | O K | +--------+-----------------+-----------------+-----------------+ | arm64 | int. mode | O K | O K | +--------+-----------------+-----------------+-----------------+ | x86 | int. mode | O K | build failure | +--------+-----------------+-----------------+-----------------+ | x86-64 | int. mode | O K | O K | +--------+-----------------+-----------------+-----------------+ | ppc | int. mode | build failure | build failure | +--------+-----------------+-----------------+-----------------+ It's a shame only to have the interpreter on AArch64/jdk7. I guess they may be building from "official" OpenJDK 7 trees with no AArch64 support. Interpreter only on x86 is even weirder! Still, I guess jdk 7 is mostly irrelevant to new deployments. -- Andrew Haley Java Platform Lead Engineer Red Hat UK Ltd. EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From manojnp.java at gmail.com Sat Dec 1 12:19:04 2018 From: manojnp.java at gmail.com (Manoj Palat) Date: Sat, 1 Dec 2018 17:49:04 +0530 Subject: [JEP 325 Switch Expression] switch labeled block completion issue? In-Reply-To: <5C010211.6000709@oracle.com> References: <5C010211.6000709@oracle.com> Message-ID: Hi Jan, Thanks for the reply. I downloaded ea22 just now and checked and indeed the issue is fixed and I see the error message " error: switch rule completes without providing a value } ^ (switch rules in switch expressions must either provide a value or throw)" as expected. Regards, Manoj On Fri, Nov 30, 2018 at 2:55 PM Jan Lahoda wrote: > Hi Manoj, > > Please see: > https://bugs.openjdk.java.net/browse/JDK-8212982 > > Which is marked as fixed in build 21. > > Jan > > On 28.11.2018 05:19, Manoj Palat wrote: > > Hi Joe, all, > > The following program compiles without errors. > > > > package se2; > > > > import java.io.IOException; > > public class X { > > public static int twice(int i) throws IOException { > > int k = switch (i) { > > case 1 -> { > > System.out.println("hello"); > > // break 1; > > } > > case 2 -> { > > System.out.println("world"); > > // break 2; > > } > > default -> 10; > > }; > > return k; > > } > > public static void main(String[] args) { > > try { > > System.out.println(X.twice(1)); > > } catch (IOException e) { > > //do nothing; > > } > > } > > } > > > > $ javac12 --enable-preview -source 12 se2/X.java > > Note: se2\X.java uses preview language features. > > Note: Recompile with -Xlint:preview for details. > > > > $ java12 --enable-preview se2/X > > hello > > world > > 10 > > > > Other details: > > $ uname -a > > CYGWIN_NT-6.1 XXXXX 2.9.0(0.318/5/3) 2017-09-12 10:18 x86_64 Cygwin > > > > The output of the program is given above ? essentially a fall-through > akin > > to a switch statement?s expected behavior. > > However, From JLS 12 15.29.1,* ?Given a switch expression, if the switch > > block consists of switch labeled rules, then it is a compile-time error > if > > any switch labeled block can complete normally. If, on the other hand, > the > > switch block consists of switch labeled statement groups, then it is a > > compile-time error if either the last statement in the switch block can > > complete normally, or the switch block includes one or more switch labels > > at the end.? * > > > > From the above I expected a compilation error to be shown since the > case 1 > > and case 2 arms can complete normally without a break expression. > > > > Is this an error in Javac or is it a wrong interpretation of "complete > > normally" in the spec on my part? > > (Once the break expressions are uncommented, the switch expression > returns > > the appropriate values which is of course the correct behavior.) I am > > using ea 20 for this. > > > > Regards, > > Manoj Palat > > Eclipse Java Dev, > > IBM. > > > > PS: I had sent this mail yesterday from my IBM official id, but I don;t > see > > that mail in the mailing list yet - hence resending from personal id. > > > > From: "Joseph D. Darcy" > > To: jdk-dev > > Date: 11/27/2018 06:29 AM > > Subject: Reminder: submit CSRs for JDK 12 with sufficient time ahead of > > rampdown 1 milestone > > Sent by: "jdk-dev" > > > > > > > > Hello, > > > > As a reminder, per the JDK 12 schedule > > ( > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__openjdk.java.net_projects_jdk_12_&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=A51zLdywEjS50U7u2UMWvsDIrUGEJ5IDXskL5MxIEjA&m=NBCxwvEUF_6bxl1FYxFdnHSL7MKL5Ya8ynDOXXPMdM4&s=nQVLCHjGW7vanaEOQjwFI3s_yk30KByjLdaV09RMXlA&e= > ) > > rampdown phase 1 of the > > release is coming up in a few weeks on Dec. 13, 2018. > > > > If you are planning to get a change into JDK 12 before the rampdown 1 > > milestone and the change requires a CSR, the CSR needs to be an the > > Approved state before the change is pushed. The nominal review time of > > the CSR is one week. Note this is the time to review, not necessarily > > the time to approve. As with code reviews, the CSR process can provide > > feedback which has to be acted upon before a request is approved. > > > > Please plan accordingly; cheers, > > > > -Joe > > CSR Lead > > > From doko at ubuntu.com Tue Dec 4 13:21:52 2018 From: doko at ubuntu.com (Matthias Klose) Date: Tue, 4 Dec 2018 14:21:52 +0100 Subject: [zero] zero VM fails to build on arm64 and ppc64el Message-ID: <3181d297-adec-a3f7-bfec-c323530329a5@ubuntu.com> jdk-12+22 zero fails to build at least on arm64 and ppc64el (it succeeds on i386, and64, armhf, s390x). Both builds fail with /usr/bin/ld: /<>/build-zero/hotspot/variant-zero/libjvm/objs/stack_zero.o: in function `ZeroStack::handle_overflow(Thread*)': ./make/hotspot/./src/hotspot/cpu/zero/stack_zero.cpp:75: undefined reference to `JavaThread::thread_state() const' collect2: error: ld returned 1 exit status make[4]: *** [lib/CompileJvm.gmk:179: /<>/build-zero/support/modules_libs/java.base/server/libjvm.so] Error 1 make[4]: *** Waiting for unfinished jobs.... /usr/bin/ld: /<>/build-zero/hotspot/variant-zero/libjvm/objs/stack_zero.o: in function `ZeroStack::handle_overflow(Thread*)': ./make/hotspot/./src/hotspot/cpu/zero/stack_zero.cpp:75: undefined reference to `JavaThread::thread_state() const' collect2: error: ld returned 1 exit status make[4]: *** [lib/CompileGtest.gmk:60: /<>/build-zero/hotspot/variant-zero/libjvm/gtest/libjvm.so] Error 1 make[4]: Leaving directory '/<>/make/hotspot' make[3]: *** [make/Main.gmk:257: hotspot-zero-libs] Error 2 Didn't check other zero-only architectures yet. Matthias From ashipile at redhat.com Tue Dec 4 13:33:23 2018 From: ashipile at redhat.com (Aleksey Shipilev) Date: Tue, 4 Dec 2018 14:33:23 +0100 Subject: [zero] zero VM fails to build on arm64 and ppc64el In-Reply-To: <3181d297-adec-a3f7-bfec-c323530329a5@ubuntu.com> References: <3181d297-adec-a3f7-bfec-c323530329a5@ubuntu.com> Message-ID: On 12/4/18 2:21 PM, Matthias Klose wrote: > jdk-12+22 zero fails to build at least on arm64 and ppc64el (it succeeds on > i386, and64, armhf, s390x). Both builds fail with > > /usr/bin/ld: > /<>/build-zero/hotspot/variant-zero/libjvm/objs/stack_zero.o: in > function `ZeroStack::handle_overflow(Thread*)': > ./make/hotspot/./src/hotspot/cpu/zero/stack_zero.cpp:75: undefined reference to > `JavaThread::thread_state() const' > collect2: error: ld returned 1 exit status > make[4]: *** [lib/CompileJvm.gmk:179: > /<>/build-zero/support/modules_libs/java.base/server/libjvm.so] Error 1 > make[4]: *** Waiting for unfinished jobs.... > /usr/bin/ld: > /<>/build-zero/hotspot/variant-zero/libjvm/objs/stack_zero.o: in > function `ZeroStack::handle_overflow(Thread*)': > ./make/hotspot/./src/hotspot/cpu/zero/stack_zero.cpp:75: undefined reference to > `JavaThread::thread_state() const' > collect2: error: ld returned 1 exit status > make[4]: *** [lib/CompileGtest.gmk:60: > /<>/build-zero/hotspot/variant-zero/libjvm/gtest/libjvm.so] Error 1 > make[4]: Leaving directory '/<>/make/hotspot' > make[3]: *** [make/Main.gmk:257: hotspot-zero-libs] Error 2 Okay, this deserves a fix. But why build aarch64-zero and ppc64el-zero to begin with? Those platforms are fully supported by Red Hat's AArch64 port and SAP's PPC64 port, and are cleanly buildable: https://builds.shipilev.net/openjdk-jdk/ This must be why it went unnoticed: Zero is usually built for platforms without full-fledged ports. -Aleksey From doko at ubuntu.com Tue Dec 4 13:54:19 2018 From: doko at ubuntu.com (Matthias Klose) Date: Tue, 4 Dec 2018 14:54:19 +0100 Subject: [zero] zero VM fails to build on arm64 and ppc64el In-Reply-To: References: <3181d297-adec-a3f7-bfec-c323530329a5@ubuntu.com> Message-ID: On 04.12.18 14:33, Aleksey Shipilev wrote: > On 12/4/18 2:21 PM, Matthias Klose wrote: >> jdk-12+22 zero fails to build at least on arm64 and ppc64el (it succeeds on >> i386, and64, armhf, s390x). Both builds fail with >> >> /usr/bin/ld: >> /<>/build-zero/hotspot/variant-zero/libjvm/objs/stack_zero.o: in >> function `ZeroStack::handle_overflow(Thread*)': >> ./make/hotspot/./src/hotspot/cpu/zero/stack_zero.cpp:75: undefined reference to >> `JavaThread::thread_state() const' >> collect2: error: ld returned 1 exit status >> make[4]: *** [lib/CompileJvm.gmk:179: >> /<>/build-zero/support/modules_libs/java.base/server/libjvm.so] Error 1 >> make[4]: *** Waiting for unfinished jobs.... >> /usr/bin/ld: >> /<>/build-zero/hotspot/variant-zero/libjvm/objs/stack_zero.o: in >> function `ZeroStack::handle_overflow(Thread*)': >> ./make/hotspot/./src/hotspot/cpu/zero/stack_zero.cpp:75: undefined reference to >> `JavaThread::thread_state() const' >> collect2: error: ld returned 1 exit status >> make[4]: *** [lib/CompileGtest.gmk:60: >> /<>/build-zero/hotspot/variant-zero/libjvm/gtest/libjvm.so] Error 1 >> make[4]: Leaving directory '/<>/make/hotspot' >> make[3]: *** [make/Main.gmk:257: hotspot-zero-libs] Error 2 > > Okay, this deserves a fix. > > But why build aarch64-zero and ppc64el-zero to begin with? Those platforms are fully supported by > Red Hat's AArch64 port and SAP's PPC64 port, and are cleanly buildable: > https://builds.shipilev.net/openjdk-jdk/ > > This must be why it went unnoticed: Zero is usually built for platforms without full-fledged ports. usually the hotspot platforms are faster to build, and before starting to debug zero-only platforms it might be easier to build and look at hotspot platforms where zero still builds. As I said, I didn't build zero-only platforms yet. From shade at redhat.com Tue Dec 4 14:24:53 2018 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 4 Dec 2018 15:24:53 +0100 Subject: [zero] zero VM fails to build on arm64 and ppc64el In-Reply-To: References: <3181d297-adec-a3f7-bfec-c323530329a5@ubuntu.com> Message-ID: On 12/4/18 2:54 PM, Matthias Klose wrote: >> But why build aarch64-zero and ppc64el-zero to begin with? Those platforms are fully supported by >> Red Hat's AArch64 port and SAP's PPC64 port, and are cleanly buildable: >> https://builds.shipilev.net/openjdk-jdk/ >> >> This must be why it went unnoticed: Zero is usually built for platforms without full-fledged ports. > > usually the hotspot platforms are faster to build, and before starting to debug > zero-only platforms it might be easier to build and look at hotspot platforms > where zero still builds. As I said, I didn't build zero-only platforms yet. Sorry, I am confused, what is "hotspot platforms"? You mean jvm-variant=server? My point is, I don't think there are lots of people who care (read: maintain) about Zero variant for platforms that are supported by their corresponding ports. Anyhow, aarch64-zero and ppc64le-zero seem to build with this fix: https://bugs.openjdk.java.net/browse/JDK-8214787 -Aleksey P.S. I think it also falls victim to resurfaced cross-compilation issue: https://bugs.openjdk.java.net/browse/JDK-8203828 ...but that is workaroundable with specifying the --with-build-jdk. From alexandre.iline at oracle.com Wed Dec 5 01:13:46 2018 From: alexandre.iline at oracle.com (Alexandre (Shura) Iline) Date: Tue, 4 Dec 2018 17:13:46 -0800 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu Message-ID: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Hi. I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. Votes are due by 5 p.m. PT on December 16th 2018 Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Alexander (Shura) Ilin [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote From david.holmes at oracle.com Wed Dec 5 01:25:08 2018 From: david.holmes at oracle.com (David Holmes) Date: Wed, 5 Dec 2018 11:25:08 +1000 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: Vote: yes David On 5/12/2018 11:13 am, Alexandre (Shura) Iline wrote: > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > > From vladimir.x.ivanov at oracle.com Wed Dec 5 01:30:48 2018 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Tue, 4 Dec 2018 17:30:48 -0800 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <2282097c-0a99-2977-1b0b-273431b6e6d1@oracle.com> Vote: yes Best regards, Vladimir Ivanov On 04/12/2018 17:13, Alexandre (Shura) Iline wrote: > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. From jamsheed.c.m at oracle.com Wed Dec 5 05:41:36 2018 From: jamsheed.c.m at oracle.com (Jamsheed) Date: Wed, 5 Dec 2018 11:11:36 +0530 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <160d1ef1-3919-96bc-42ce-4bd65cc5b8b6@oracle.com> Vote: Yes Best regards, Jamsheed On 05/12/18 6:43 AM, Alexandre (Shura) Iline wrote: > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. From jini.george at oracle.com Wed Dec 5 06:41:08 2018 From: jini.george at oracle.com (Jini George) Date: Wed, 5 Dec 2018 12:11:08 +0530 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <8b9e9616-62fe-b1d6-ccb4-886dc3891341@oracle.com> Vote: Yes - Jini. On 12/5/2018 6:43 AM, Alexandre (Shura) Iline wrote: > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > > From volker.simonis at gmail.com Wed Dec 5 07:16:41 2018 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 5 Dec 2018 08:16:41 +0100 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: Vote: yes On Wed, Dec 5, 2018 at 2:16 AM Alexandre (Shura) Iline wrote: > > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From rahul.v.raghavan at oracle.com Wed Dec 5 07:21:03 2018 From: rahul.v.raghavan at oracle.com (Rahul Raghavan) Date: Wed, 5 Dec 2018 12:51:03 +0530 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <64f500c1-f932-bae9-a763-afc05ab96f5c@oracle.com> Vote: yes On 05/12/18 6:43 AM, Alexandre (Shura) Iline wrote: > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > > From bhanu.prakash.gopularam at oracle.com Wed Dec 5 07:47:26 2018 From: bhanu.prakash.gopularam at oracle.com (Bhanu Gopularam) Date: Wed, 5 Dec 2018 13:17:26 +0530 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <47F05C13-6BB7-4564-865E-0C81C2D45364@oracle.com> Vote: Yes Thanks, Bhanu > On 05-Dec-2018, at 6:43 AM, Alexandre (Shura) Iline wrote: > > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From tobias.hartmann at oracle.com Wed Dec 5 07:58:23 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Wed, 5 Dec 2018 08:58:23 +0100 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: Vote: yes Best regards, Tobias On 05.12.18 02:13, Alexandre (Shura) Iline wrote: > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > > From nadeeshtv at gmail.com Wed Dec 5 08:21:36 2018 From: nadeeshtv at gmail.com (nadeesh t v) Date: Wed, 5 Dec 2018 09:21:36 +0100 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: Yes. Regards, Nadeesh On Wed, Dec 5, 2018 at 2:16 AM Alexandre (Shura) Iline < alexandre.iline at oracle.com> wrote: > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He > has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] > http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > -- Thanks and Regards, Nadeesh TV From ramanand.patil at oracle.com Wed Dec 5 08:56:08 2018 From: ramanand.patil at oracle.com (Ramanand Patil) Date: Wed, 5 Dec 2018 00:56:08 -0800 (PST) Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <2703e97b-d5db-4412-bb16-87d4a0f2e6ba@default> Vote: yes Regards, Ramanand. > -----Original Message----- > From: Alexandre (Shura) Iline > Sent: Wednesday, December 05, 2018 6:44 AM > To: jdk-dev at openjdk.java.net > Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu > > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK > Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He > has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] > http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolark > unnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge > () > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From prem.balakrishnan at oracle.com Wed Dec 5 09:49:10 2018 From: prem.balakrishnan at oracle.com (Prem Balakrishnan) Date: Wed, 5 Dec 2018 01:49:10 -0800 (PST) Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <4d9aa7af-ab6a-4924-bd7f-9a11e10aba01@default> Yes. Regards, Prem -----Original Message----- From: Alexandre (Shura) Iline Sent: Wednesday, December 05, 2018 6:44 AM To: jdk-dev at openjdk.java.net Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu Hi. I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. Votes are due by 5 p.m. PT on December 16th 2018 Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Alexander (Shura) Ilin [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote From sean.coffey at oracle.com Wed Dec 5 09:48:59 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 5 Dec 2018 09:48:59 +0000 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: Vote: yes Regards, Sean. On 05/12/18 01:13, Alexandre (Shura) Iline wrote: > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From dmitry.markov at oracle.com Wed Dec 5 10:47:45 2018 From: dmitry.markov at oracle.com (Dmitry Markov) Date: Wed, 5 Dec 2018 10:47:45 +0000 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <1D6D5990-9258-44B4-8D76-B30F88E2BEAF@oracle.com> Vote: Yes Thanks, Dmitry > On 5 Dec 2018, at 01:13, Alexandre (Shura) Iline wrote: > > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From adinn at redhat.com Wed Dec 5 11:40:16 2018 From: adinn at redhat.com (Andrew Dinn) Date: Wed, 5 Dec 2018 11:40:16 +0000 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: Vote: yes On 05/12/2018 01:13, Alexandre (Shura) Iline wrote: > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > > -- regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander From krishna.addepalli at oracle.com Wed Dec 5 12:27:57 2018 From: krishna.addepalli at oracle.com (Krishna Addepalli) Date: Wed, 5 Dec 2018 04:27:57 -0800 (PST) Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu Message-ID: <78a9c294-500d-4f54-9ccc-2846e8d3d5cc@default> Yes Thanks, Krishna -----Original Message----- From: Alexandre (Shura) Iline Sent: Wednesday, December 05, 2018 6:44 AM To: jdk-dev at openjdk.java.net Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu Hi. I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. Votes are due by 5 p.m. PT on December 16th 2018 Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Alexander (Shura) Ilin [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote From jayathirth.d.v at oracle.com Wed Dec 5 12:32:21 2018 From: jayathirth.d.v at oracle.com (Jayathirth D V) Date: Wed, 5 Dec 2018 12:32:21 +0000 (UTC) Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <0110fc2f-95c9-4868-beca-c7e95dbde034@default> Vote : Yes. Thanks, Jay -----Original Message----- From: Alexandre (Shura) Iline Sent: Wednesday, December 05, 2018 6:44 AM To: jdk-dev at openjdk.java.net Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu Hi. I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. Votes are due by 5 p.m. PT on December 16th 2018 Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Alexander (Shura) Ilin [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote From nishit.jain at oracle.com Wed Dec 5 13:29:37 2018 From: nishit.jain at oracle.com (Nishit Jain) Date: Wed, 5 Dec 2018 18:59:37 +0530 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: Vote: Yes. Regards, Nishit Jain On 05-12-2018 06:43, Alexandre (Shura) Iline wrote: > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From dalibor.topic at oracle.com Wed Dec 5 13:34:11 2018 From: dalibor.topic at oracle.com (dalibor topic) Date: Wed, 5 Dec 2018 14:34:11 +0100 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <25747c11-5bdd-9a0f-e406-75befa945a6e@oracle.com> Vote: Yes. -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher Oracle is committed to developing practices and products that help protect the environment From neugens at redhat.com Wed Dec 5 13:38:51 2018 From: neugens at redhat.com (Mario Torre) Date: Wed, 5 Dec 2018 14:38:51 +0100 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: Vote: Yes, Cheers, Mario On Wed, Dec 5, 2018 at 2:16 AM Alexandre (Shura) Iline wrote: > > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From shashidhara.veerabhadraiah at oracle.com Wed Dec 5 14:43:49 2018 From: shashidhara.veerabhadraiah at oracle.com (Shashidhara Veerabhadraiah) Date: Wed, 5 Dec 2018 06:43:49 -0800 (PST) Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: Vote: Yes. Thanks and regards, Shashi -----Original Message----- From: Mario Torre [mailto:neugens at redhat.com] Sent: Wednesday, December 5, 2018 7:09 PM To: Aleksandre Iline Cc: jdk-dev Subject: Re: CFV: New JDK Committer: Abdul Muneer Kolarkunnu Vote: Yes, Cheers, Mario On Wed, Dec 5, 2018 at 2:16 AM Alexandre (Shura) Iline wrote: > > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] > http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolar > kunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From Roger.Riggs at oracle.com Wed Dec 5 18:13:02 2018 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Wed, 5 Dec 2018 13:13:02 -0500 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <5b5b0dee-8435-8ae3-1c42-1f08c6c3d8f2@oracle.com> Vote: Yes On 12/04/2018 08:13 PM, Alexandre (Shura) Iline wrote: > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. From Roger.Riggs at oracle.com Wed Dec 5 20:34:47 2018 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Wed, 5 Dec 2018 15:34:47 -0500 Subject: CFV: New JDK Committer: Chris Yin Message-ID: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> I hereby nominate Chris Yin (xyin) to JDK Committer. Chris Yin (xyin) has worked in the Oracle Corelibs SQE team since last year. Over the past year, he has contributed 22 changes [3]?primarily?on test development for JNDI adding new tests or rewriting/refactoring old tests. And he has contributed bug fixes and new tests for other components such as in package, net, jshell, etc. Some?significant change sets can be found at [4] Votes are due by 12.00 pm CET, December 20th, 2018. Only current JDK Committers [1] are eligible to vote on this nomination.? Votes must be cast in the open by replying? to this mailing list. For Lazy Consensus voting instructions, see [2]. Thank you, Roger [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote [3] http://hg.openjdk.java.net/jdk/jdk/search/?rev=(keyword(%22chris.yin at oracle.com%22)%20or%20(author(xyin)))%20&revcount=2000 [4] 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/ http://hg.openjdk.java.net/jdk/jdk/rev/bca2b63dd839 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/ http://hg.openjdk.java.net/jdk/jdk/rev/2e495bbdc2b7 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ http://hg.openjdk.java.net/jdk/jdk/rev/a562c65c3c74 8210695: Create test to cover JDK-8205330 InitialDirContext ctor sometimes throws NPE if the server has sent a disconnection http://hg.openjdk.java.net/jdk/jdk/rev/caac55d48dc3 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ http://hg.openjdk.java.net/jdk/jdk/rev/4737d92d752f 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ http://hg.openjdk.java.net/jdk/jdk/rev/7939b3c4e408 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ http://hg.openjdk.java.net/jdk/jdk/rev/499b873761d8 8201528: Add new test to check for package versioning information in OpenJDK http://hg.openjdk.java.net/jdk/jdk/rev/2a94ab65b026 8202690: jdk/jshell/ToolBasicTest.java failed in testOpenFileOverHttp() and testOpenLocalFileUrl() http://hg.openjdk.java.net/jdk/jdk/rev/2d1952d4d067 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java http://hg.openjdk.java.net/jdk/jdk/rev/478e198da84b 8195976: Add JNDI test com/sun/jndi/dns/AttributeTests/GetAny.java http://hg.openjdk.java.net/jdk/jdk/rev/1d8f882f2b2f From david.holmes at oracle.com Wed Dec 5 22:46:26 2018 From: david.holmes at oracle.com (David Holmes) Date: Thu, 6 Dec 2018 08:46:26 +1000 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: Vote: yes David On 6/12/2018 6:34 am, Roger Riggs wrote: > I hereby nominate Chris Yin (xyin) to JDK Committer. > > Chris Yin (xyin) has worked in the Oracle Corelibs SQE team since last > year. > Over the past year, he has contributed 22 changes [3]?primarily?on test > development > for JNDI adding new tests or rewriting/refactoring old tests. And he has > contributed > bug fixes and new tests for other components such as in package, net, > jshell, etc. > Some?significant change sets can be found at [4] > > Votes are due by 12.00 pm CET, December 20th, 2018. > > Only current JDK Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying? to this > mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Roger > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] > http://hg.openjdk.java.net/jdk/jdk/search/?rev=(keyword(%22chris.yin at oracle.com%22)%20or%20(author(xyin)))%20&revcount=2000 > > > [4] > 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/bca2b63dd839 > 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/2e495bbdc2b7 > 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/a562c65c3c74 > 8210695: Create test to cover JDK-8205330 InitialDirContext ctor > sometimes throws NPE if the server has sent a disconnection > http://hg.openjdk.java.net/jdk/jdk/rev/caac55d48dc3 > 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/4737d92d752f > 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/7939b3c4e408 > 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/499b873761d8 > 8201528: Add new test to check for package versioning information in > OpenJDK > http://hg.openjdk.java.net/jdk/jdk/rev/2a94ab65b026 > 8202690: jdk/jshell/ToolBasicTest.java failed in testOpenFileOverHttp() > and testOpenLocalFileUrl() > http://hg.openjdk.java.net/jdk/jdk/rev/2d1952d4d067 > 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java > http://hg.openjdk.java.net/jdk/jdk/rev/478e198da84b > 8195976: Add JNDI test com/sun/jndi/dns/AttributeTests/GetAny.java > http://hg.openjdk.java.net/jdk/jdk/rev/1d8f882f2b2f > > From sha.jiang at oracle.com Wed Dec 5 23:23:09 2018 From: sha.jiang at oracle.com (sha.jiang at oracle.com) Date: Thu, 6 Dec 2018 07:23:09 +0800 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: Vote: yes John Jiang On 2018/12/6 04:34, Roger Riggs wrote: > I hereby nominate Chris Yin (xyin) to JDK Committer. > > Chris Yin (xyin) has worked in the Oracle Corelibs SQE team since last > year. > Over the past year, he has contributed 22 changes [3]?primarily?on > test development > for JNDI adding new tests or rewriting/refactoring old tests. And he > has contributed > bug fixes and new tests for other components such as in package, net, > jshell, etc. > Some?significant change sets can be found at [4] > > Votes are due by 12.00 pm CET, December 20th, 2018. > > Only current JDK Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying to > this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Roger > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] > http://hg.openjdk.java.net/jdk/jdk/search/?rev=(keyword(%22chris.yin at oracle.com%22)%20or%20(author(xyin)))%20&revcount=2000 > > > [4] > 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/bca2b63dd839 > 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/2e495bbdc2b7 > 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/a562c65c3c74 > 8210695: Create test to cover JDK-8205330 InitialDirContext ctor > sometimes throws NPE if the server has sent a disconnection > http://hg.openjdk.java.net/jdk/jdk/rev/caac55d48dc3 > 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/4737d92d752f > 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/7939b3c4e408 > 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/499b873761d8 > 8201528: Add new test to check for package versioning information in > OpenJDK > http://hg.openjdk.java.net/jdk/jdk/rev/2a94ab65b026 > 8202690: jdk/jshell/ToolBasicTest.java failed in > testOpenFileOverHttp() and testOpenLocalFileUrl() > http://hg.openjdk.java.net/jdk/jdk/rev/2d1952d4d067 > 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java > http://hg.openjdk.java.net/jdk/jdk/rev/478e198da84b > 8195976: Add JNDI test com/sun/jndi/dns/AttributeTests/GetAny.java > http://hg.openjdk.java.net/jdk/jdk/rev/1d8f882f2b2f > > > From weijun.wang at oracle.com Wed Dec 5 23:42:10 2018 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 6 Dec 2018 07:42:10 +0800 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: Vote: yes --weijun > On Dec 6, 2018, at 4:34 AM, Roger Riggs wrote: > > I hereby nominate Chris Yin (xyin) to JDK Committer. From xuelei.fan at oracle.com Thu Dec 6 00:02:15 2018 From: xuelei.fan at oracle.com (Xue-Lei Fan) Date: Wed, 5 Dec 2018 16:02:15 -0800 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: <63696be7-29a4-7bf0-53a1-8c960c3794a9@oracle.com> Vote: Yes. Xuelei On 12/5/2018 12:34 PM, Roger Riggs wrote: > I hereby nominate Chris Yin (xyin) to JDK Committer. > > Chris Yin (xyin) has worked in the Oracle Corelibs SQE team since last > year. > Over the past year, he has contributed 22 changes [3]?primarily?on test > development > for JNDI adding new tests or rewriting/refactoring old tests. And he has > contributed > bug fixes and new tests for other components such as in package, net, > jshell, etc. > Some?significant change sets can be found at [4] > > Votes are due by 12.00 pm CET, December 20th, 2018. > > Only current JDK Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying? to this > mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Roger > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] > http://hg.openjdk.java.net/jdk/jdk/search/?rev=(keyword(%22chris.yin at oracle.com%22)%20or%20(author(xyin)))%20&revcount=2000 > > > [4] > 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/bca2b63dd839 > 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/2e495bbdc2b7 > 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/a562c65c3c74 > 8210695: Create test to cover JDK-8205330 InitialDirContext ctor > sometimes throws NPE if the server has sent a disconnection > http://hg.openjdk.java.net/jdk/jdk/rev/caac55d48dc3 > 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/4737d92d752f > 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/7939b3c4e408 > 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/499b873761d8 > 8201528: Add new test to check for package versioning information in > OpenJDK > http://hg.openjdk.java.net/jdk/jdk/rev/2a94ab65b026 > 8202690: jdk/jshell/ToolBasicTest.java failed in testOpenFileOverHttp() > and testOpenLocalFileUrl() > http://hg.openjdk.java.net/jdk/jdk/rev/2d1952d4d067 > 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java > http://hg.openjdk.java.net/jdk/jdk/rev/478e198da84b > 8195976: Add JNDI test com/sun/jndi/dns/AttributeTests/GetAny.java > http://hg.openjdk.java.net/jdk/jdk/rev/1d8f882f2b2f > > From brent.christian at oracle.com Thu Dec 6 00:08:51 2018 From: brent.christian at oracle.com (Brent Christian) Date: Wed, 5 Dec 2018 16:08:51 -0800 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: <299a1255-3cd9-9805-f268-438666efc347@oracle.com> Vote: Yes On 12/5/18 12:34 PM, Roger Riggs wrote: > I hereby nominate Chris Yin (xyin) to JDK Committer. > From stanislav.smirnov at oracle.com Thu Dec 6 00:13:06 2018 From: stanislav.smirnov at oracle.com (Stanislav Smirnov) Date: Wed, 5 Dec 2018 19:13:06 -0500 Subject: Submit repo status Message-ID: Hello, The submit repo was not working as expected last couple of days. The main reason is that the "hg pull" operation was not able to complete succesfully because of the number of heads in the repository. The submit repo hasn't been "cleaned" since it opened a year ago. There are currently 406 (closed + normal) branches in the repo and most of them are ?dead? (not active, but have not been closed). It was decided to start "resetting" the jdk/submit repository regularly. A new repository was created today http://hg.openjdk.java.net/jdk/submit/ With no branches except from the default one. In order to continue using the submit repo please make a fresh clone. Also an archive of the old jdk/submit was created http://hg.openjdk.java.net/jdk/submit-archive-2018-12-05/ Please continue using the system and report any issues/ask questions related to the submit repo using ops at openjdk.java.net. Best regards, Stanislav Smirnov From Sergey.Bylokhov at oracle.com Thu Dec 6 00:13:52 2018 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 5 Dec 2018 16:13:52 -0800 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <913f4b05-11f2-ab4d-4048-203e757715b5@oracle.com> Vote: Yes From amy.lu at oracle.com Thu Dec 6 00:23:46 2018 From: amy.lu at oracle.com (Amy Lu) Date: Thu, 6 Dec 2018 08:23:46 +0800 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: <839a13dc-65ae-12e5-fc75-a5ef5f4f8297@oracle.com> Vote: Yes /Amy On 2018/12/6 4:34 AM, Roger Riggs wrote: > I hereby nominate Chris Yin (xyin) to JDK Committer. From frank.yuan at oracle.com Thu Dec 6 03:19:50 2018 From: frank.yuan at oracle.com (Frank Yuan) Date: Thu, 6 Dec 2018 11:19:50 +0800 Subject: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: <24c501d48d12$8e01aff0$aa050fd0$@oracle.com> Vote: yes Frank > -----Original Message----- > From: jdk-dev [mailto:jdk-dev-bounces at openjdk.java.net] On Behalf Of Roger Riggs > Sent: Thursday, December 06, 2018 4:35 AM > To: jdk-dev > Subject: CFV: New JDK Committer: Chris Yin > > I hereby nominate Chris Yin (xyin) to JDK Committer. > > Chris Yin (xyin) has worked in the Oracle Corelibs SQE team since last > year. > Over the past year, he has contributed 22 changes [3] primarily on test > development > for JNDI adding new tests or rewriting/refactoring old tests. And he has > contributed > bug fixes and new tests for other components such as in package, net, > jshell, etc. > Some significant change sets can be found at [4] > > Votes are due by 12.00 pm CET, December 20th, 2018. > > Only current JDK Committers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Roger > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] > http://hg.openjdk.java.net/jdk/jdk/search/?rev=(keyword(%22chris.yin at oracle.com%22)%20or%20(author(xyin)))%20&revcount=2000 > > > [4] > 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/bca2b63dd839 > 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/2e495bbdc2b7 > 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/a562c65c3c74 > 8210695: Create test to cover JDK-8205330 InitialDirContext ctor > sometimes throws NPE if the server has sent a disconnection > http://hg.openjdk.java.net/jdk/jdk/rev/caac55d48dc3 > 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/4737d92d752f > 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/7939b3c4e408 > 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/499b873761d8 > 8201528: Add new test to check for package versioning information in OpenJDK > http://hg.openjdk.java.net/jdk/jdk/rev/2a94ab65b026 > 8202690: jdk/jshell/ToolBasicTest.java failed in testOpenFileOverHttp() > and testOpenLocalFileUrl() > http://hg.openjdk.java.net/jdk/jdk/rev/2d1952d4d067 > 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java > http://hg.openjdk.java.net/jdk/jdk/rev/478e198da84b > 8195976: Add JNDI test com/sun/jndi/dns/AttributeTests/GetAny.java > http://hg.openjdk.java.net/jdk/jdk/rev/1d8f882f2b2f > From sibabrata.sahoo at oracle.com Thu Dec 6 05:57:28 2018 From: sibabrata.sahoo at oracle.com (Sibabrata Sahoo) Date: Wed, 5 Dec 2018 21:57:28 -0800 (PST) Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: Vote: yes -----Original Message----- From: Roger Riggs Sent: Thursday, December 06, 2018 2:05 AM To: jdk-dev Subject: CFV: New JDK Committer: Chris Yin I hereby nominate Chris Yin (xyin) to JDK Committer. Chris Yin (xyin) has worked in the Oracle Corelibs SQE team since last year. Over the past year, he has contributed 22 changes [3]?primarily?on test development for JNDI adding new tests or rewriting/refactoring old tests. And he has contributed bug fixes and new tests for other components such as in package, net, jshell, etc. Some?significant change sets can be found at [4] Votes are due by 12.00 pm CET, December 20th, 2018. Only current JDK Committers [1] are eligible to vote on this nomination.? Votes must be cast in the open by replying? to this mailing list. For Lazy Consensus voting instructions, see [2]. Thank you, Roger [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote [3] http://hg.openjdk.java.net/jdk/jdk/search/?rev=(keyword(%22chris.yin at oracle.com%22)%20or%20(author(xyin)))%20&revcount=2000 [4] 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/ http://hg.openjdk.java.net/jdk/jdk/rev/bca2b63dd839 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/ http://hg.openjdk.java.net/jdk/jdk/rev/2e495bbdc2b7 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ http://hg.openjdk.java.net/jdk/jdk/rev/a562c65c3c74 8210695: Create test to cover JDK-8205330 InitialDirContext ctor sometimes throws NPE if the server has sent a disconnection http://hg.openjdk.java.net/jdk/jdk/rev/caac55d48dc3 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ http://hg.openjdk.java.net/jdk/jdk/rev/4737d92d752f 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ http://hg.openjdk.java.net/jdk/jdk/rev/7939b3c4e408 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ http://hg.openjdk.java.net/jdk/jdk/rev/499b873761d8 8201528: Add new test to check for package versioning information in OpenJDK http://hg.openjdk.java.net/jdk/jdk/rev/2a94ab65b026 8202690: jdk/jshell/ToolBasicTest.java failed in testOpenFileOverHttp() and testOpenLocalFileUrl() http://hg.openjdk.java.net/jdk/jdk/rev/2d1952d4d067 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java http://hg.openjdk.java.net/jdk/jdk/rev/478e198da84b 8195976: Add JNDI test com/sun/jndi/dns/AttributeTests/GetAny.java http://hg.openjdk.java.net/jdk/jdk/rev/1d8f882f2b2f From sibabrata.sahoo at oracle.com Thu Dec 6 05:57:17 2018 From: sibabrata.sahoo at oracle.com (Sibabrata Sahoo) Date: Wed, 5 Dec 2018 21:57:17 -0800 (PST) Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <958857c5-c32e-4e83-bb96-a5025b843a9a@default> Vote: yes -----Original Message----- From: Alexandre (Shura) Iline Sent: Wednesday, December 05, 2018 6:44 AM To: jdk-dev at openjdk.java.net Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu Hi. I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. Votes are due by 5 p.m. PT on December 16th 2018 Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Alexander (Shura) Ilin [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote From ajit.ghaisas at oracle.com Thu Dec 6 06:13:27 2018 From: ajit.ghaisas at oracle.com (Ajit Ghaisas) Date: Thu, 6 Dec 2018 11:43:27 +0530 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <3006ADB9-3132-4350-9666-86C174D5DF86@oracle.com> Vote : Yes Regards, Ajit > On 05-Dec-2018, at 6:43 AM, Alexandre (Shura) Iline wrote: > > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From huaming.li at oracle.com Thu Dec 6 06:31:44 2018 From: huaming.li at oracle.com (Hamlin Li) Date: Thu, 6 Dec 2018 14:31:44 +0800 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: <0fdb38f5-2c72-8b85-7536-f9bde4bdb24b@oracle.com> Vote: yes -Hamlin On 2018/12/6 4:34 AM, Roger Riggs wrote: > I hereby nominate Chris Yin (xyin) to JDK Committer. > > Chris Yin (xyin) has worked in the Oracle Corelibs SQE team since last > year. > Over the past year, he has contributed 22 changes [3]?primarily?on > test development > for JNDI adding new tests or rewriting/refactoring old tests. And he > has contributed > bug fixes and new tests for other components such as in package, net, > jshell, etc. > Some?significant change sets can be found at [4] > > Votes are due by 12.00 pm CET, December 20th, 2018. > > Only current JDK Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying to > this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Roger > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] > http://hg.openjdk.java.net/jdk/jdk/search/?rev=(keyword(%22chris.yin at oracle.com%22)%20or%20(author(xyin)))%20&revcount=2000 > > > [4] > 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/bca2b63dd839 > 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/2e495bbdc2b7 > 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/a562c65c3c74 > 8210695: Create test to cover JDK-8205330 InitialDirContext ctor > sometimes throws NPE if the server has sent a disconnection > http://hg.openjdk.java.net/jdk/jdk/rev/caac55d48dc3 > 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/4737d92d752f > 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/7939b3c4e408 > 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/499b873761d8 > 8201528: Add new test to check for package versioning information in > OpenJDK > http://hg.openjdk.java.net/jdk/jdk/rev/2a94ab65b026 > 8202690: jdk/jshell/ToolBasicTest.java failed in > testOpenFileOverHttp() and testOpenLocalFileUrl() > http://hg.openjdk.java.net/jdk/jdk/rev/2d1952d4d067 > 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java > http://hg.openjdk.java.net/jdk/jdk/rev/478e198da84b > 8195976: Add JNDI test com/sun/jndi/dns/AttributeTests/GetAny.java > http://hg.openjdk.java.net/jdk/jdk/rev/1d8f882f2b2f > > From vyom.tewari at oracle.com Thu Dec 6 06:46:21 2018 From: vyom.tewari at oracle.com (vyom tewari) Date: Thu, 6 Dec 2018 12:16:21 +0530 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <214c2d78-82a5-bfed-83a4-85b271412b7f@oracle.com> Vote: yes Vyom On 05/12/18 6:43 AM, Alexandre (Shura) Iline wrote: > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From vyom.tewari at oracle.com Thu Dec 6 06:46:48 2018 From: vyom.tewari at oracle.com (vyom tewari) Date: Thu, 6 Dec 2018 12:16:48 +0530 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: <7a4c5abe-ef3b-d52b-4f16-c86dbdb05984@oracle.com> Vote: yes Vyom On 06/12/18 2:04 AM, Roger Riggs wrote: > I hereby nominate Chris Yin (xyin) to JDK Committer. > > Chris Yin (xyin) has worked in the Oracle Corelibs SQE team since last > year. > Over the past year, he has contributed 22 changes [3]?primarily?on > test development > for JNDI adding new tests or rewriting/refactoring old tests. And he > has contributed > bug fixes and new tests for other components such as in package, net, > jshell, etc. > Some?significant change sets can be found at [4] > > Votes are due by 12.00 pm CET, December 20th, 2018. > > Only current JDK Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying to > this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Roger > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] > http://hg.openjdk.java.net/jdk/jdk/search/?rev=(keyword(%22chris.yin at oracle.com%22)%20or%20(author(xyin)))%20&revcount=2000 > > > [4] > 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/bca2b63dd839 > 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/2e495bbdc2b7 > 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/a562c65c3c74 > 8210695: Create test to cover JDK-8205330 InitialDirContext ctor > sometimes throws NPE if the server has sent a disconnection > http://hg.openjdk.java.net/jdk/jdk/rev/caac55d48dc3 > 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/4737d92d752f > 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/7939b3c4e408 > 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/499b873761d8 > 8201528: Add new test to check for package versioning information in > OpenJDK > http://hg.openjdk.java.net/jdk/jdk/rev/2a94ab65b026 > 8202690: jdk/jshell/ToolBasicTest.java failed in > testOpenFileOverHttp() and testOpenLocalFileUrl() > http://hg.openjdk.java.net/jdk/jdk/rev/2d1952d4d067 > 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java > http://hg.openjdk.java.net/jdk/jdk/rev/478e198da84b > 8195976: Add JNDI test com/sun/jndi/dns/AttributeTests/GetAny.java > http://hg.openjdk.java.net/jdk/jdk/rev/1d8f882f2b2f > > From manajit.halder at oracle.com Thu Dec 6 06:57:01 2018 From: manajit.halder at oracle.com (Manajit Halder) Date: Thu, 6 Dec 2018 12:27:01 +0530 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <83AAB2A5-2812-4BB6-9E9B-8D0D11621363@oracle.com> Vote: Yes > On 05-Dec-2018, at 6:43 AM, Alexandre (Shura) Iline wrote: > > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From thomas.stuefe at gmail.com Thu Dec 6 08:07:01 2018 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Thu, 6 Dec 2018 09:07:01 +0100 Subject: Submit repo status In-Reply-To: References: Message-ID: Hi Stanislav, thanks for fixing this. I think resetting the repo makes sense. In which intervals will you be resetting it? Thanks, Thomas On Thu, Dec 6, 2018 at 1:15 AM Stanislav Smirnov wrote: > > Hello, > > The submit repo was not working as expected last couple of days. > The main reason is that the "hg pull" operation was not able to complete succesfully because of the number of heads in the repository. > The submit repo hasn't been "cleaned" since it opened a year ago. > There are currently 406 (closed + normal) branches in the repo and most of them are ?dead? (not active, but have not been closed). > > It was decided to start "resetting" the jdk/submit repository regularly. > A new repository was created today > > http://hg.openjdk.java.net/jdk/submit/ > > With no branches except from the default one. > In order to continue using the submit repo please make a fresh clone. > > Also an archive of the old jdk/submit was created > > http://hg.openjdk.java.net/jdk/submit-archive-2018-12-05/ > > Please continue using the system and report any issues/ask questions related to the submit repo using ops at openjdk.java.net. > > Best regards, > Stanislav Smirnov From volker.simonis at gmail.com Thu Dec 6 08:30:07 2018 From: volker.simonis at gmail.com (Volker Simonis) Date: Thu, 6 Dec 2018 09:30:07 +0100 Subject: Submit repo status In-Reply-To: References: Message-ID: On Thu, Dec 6, 2018 at 1:15 AM Stanislav Smirnov wrote: > > Hello, > > The submit repo was not working as expected last couple of days. > The main reason is that the "hg pull" operation was not able to complete succesfully because of the number of heads in the repository. > The submit repo hasn't been "cleaned" since it opened a year ago. > There are currently 406 (closed + normal) branches in the repo and most of them are ?dead? (not active, but have not been closed). > > It was decided to start "resetting" the jdk/submit repository regularly. Another possibility would be to automatically close branches which match a JBS ID once the corresponding change has been pushed to jdk/jdk (the same way JBS issues get "Resloved" automatically once the corresponding change gets pushed). > A new repository was created today > > http://hg.openjdk.java.net/jdk/submit/ > > With no branches except from the default one. > In order to continue using the submit repo please make a fresh clone. > > Also an archive of the old jdk/submit was created > > http://hg.openjdk.java.net/jdk/submit-archive-2018-12-05/ > > Please continue using the system and report any issues/ask questions related to the submit repo using ops at openjdk.java.net. > > Best regards, > Stanislav Smirnov From volker.simonis at gmail.com Thu Dec 6 08:32:57 2018 From: volker.simonis at gmail.com (Volker Simonis) Date: Thu, 6 Dec 2018 09:32:57 +0100 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: Vote: yes On Wed, Dec 5, 2018 at 9:37 PM Roger Riggs wrote: > > I hereby nominate Chris Yin (xyin) to JDK Committer. > > Chris Yin (xyin) has worked in the Oracle Corelibs SQE team since last > year. > Over the past year, he has contributed 22 changes [3] primarily on test > development > for JNDI adding new tests or rewriting/refactoring old tests. And he has > contributed > bug fixes and new tests for other components such as in package, net, > jshell, etc. > Some significant change sets can be found at [4] > > Votes are due by 12.00 pm CET, December 20th, 2018. > > Only current JDK Committers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Roger > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] > http://hg.openjdk.java.net/jdk/jdk/search/?rev=(keyword(%22chris.yin at oracle.com%22)%20or%20(author(xyin)))%20&revcount=2000 > > > [4] > 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/bca2b63dd839 > 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/2e495bbdc2b7 > 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/a562c65c3c74 > 8210695: Create test to cover JDK-8205330 InitialDirContext ctor > sometimes throws NPE if the server has sent a disconnection > http://hg.openjdk.java.net/jdk/jdk/rev/caac55d48dc3 > 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/4737d92d752f > 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/7939b3c4e408 > 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/499b873761d8 > 8201528: Add new test to check for package versioning information in OpenJDK > http://hg.openjdk.java.net/jdk/jdk/rev/2a94ab65b026 > 8202690: jdk/jshell/ToolBasicTest.java failed in testOpenFileOverHttp() > and testOpenLocalFileUrl() > http://hg.openjdk.java.net/jdk/jdk/rev/2d1952d4d067 > 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java > http://hg.openjdk.java.net/jdk/jdk/rev/478e198da84b > 8195976: Add JNDI test com/sun/jndi/dns/AttributeTests/GetAny.java > http://hg.openjdk.java.net/jdk/jdk/rev/1d8f882f2b2f > > From sean.coffey at oracle.com Thu Dec 6 09:15:10 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 6 Dec 2018 09:15:10 +0000 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: <1335738b-9cc8-2404-d1a5-a827b2c3c8af@oracle.com> Vote: yes regards, Sean. On 05/12/2018 20:34, Roger Riggs wrote: > I hereby nominate Chris Yin (xyin) to JDK Committer. > > Chris Yin (xyin) has worked in the Oracle Corelibs SQE team since last > year. > Over the past year, he has contributed 22 changes [3]?primarily?on > test development > for JNDI adding new tests or rewriting/refactoring old tests. And he > has contributed > bug fixes and new tests for other components such as in package, net, > jshell, etc. > Some?significant change sets can be found at [4] > > Votes are due by 12.00 pm CET, December 20th, 2018. > > Only current JDK Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying to > this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Roger > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] > http://hg.openjdk.java.net/jdk/jdk/search/?rev=(keyword(%22chris.yin at oracle.com%22)%20or%20(author(xyin)))%20&revcount=2000 > > > [4] > 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/bca2b63dd839 > 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/2e495bbdc2b7 > 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/a562c65c3c74 > 8210695: Create test to cover JDK-8205330 InitialDirContext ctor > sometimes throws NPE if the server has sent a disconnection > http://hg.openjdk.java.net/jdk/jdk/rev/caac55d48dc3 > 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/4737d92d752f > 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/7939b3c4e408 > 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/499b873761d8 > 8201528: Add new test to check for package versioning information in > OpenJDK > http://hg.openjdk.java.net/jdk/jdk/rev/2a94ab65b026 > 8202690: jdk/jshell/ToolBasicTest.java failed in > testOpenFileOverHttp() and testOpenLocalFileUrl() > http://hg.openjdk.java.net/jdk/jdk/rev/2d1952d4d067 > 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java > http://hg.openjdk.java.net/jdk/jdk/rev/478e198da84b > 8195976: Add JNDI test com/sun/jndi/dns/AttributeTests/GetAny.java > http://hg.openjdk.java.net/jdk/jdk/rev/1d8f882f2b2f > > From dmitry.markov at oracle.com Thu Dec 6 09:16:34 2018 From: dmitry.markov at oracle.com (Dmitry Markov) Date: Thu, 6 Dec 2018 09:16:34 +0000 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: Vote: Yes Thanks, Dmitry > On 5 Dec 2018, at 20:34, Roger Riggs wrote: > > I hereby nominate Chris Yin (xyin) to JDK Committer. > > Chris Yin (xyin) has worked in the Oracle Corelibs SQE team since last year. > Over the past year, he has contributed 22 changes [3] primarily on test development > for JNDI adding new tests or rewriting/refactoring old tests. And he has contributed > bug fixes and new tests for other components such as in package, net, jshell, etc. > Some significant change sets can be found at [4] > > Votes are due by 12.00 pm CET, December 20th, 2018. > > Only current JDK Committers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Roger > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] http://hg.openjdk.java.net/jdk/jdk/search/?rev=(keyword(%22chris.yin at oracle.com%22)%20or%20(author(xyin)))%20&revcount=2000 > > [4] > 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/bca2b63dd839 > 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/2e495bbdc2b7 > 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/a562c65c3c74 > 8210695: Create test to cover JDK-8205330 InitialDirContext ctor sometimes throws NPE if the server has sent a disconnection > http://hg.openjdk.java.net/jdk/jdk/rev/caac55d48dc3 > 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/4737d92d752f > 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/7939b3c4e408 > 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/499b873761d8 > 8201528: Add new test to check for package versioning information in OpenJDK > http://hg.openjdk.java.net/jdk/jdk/rev/2a94ab65b026 > 8202690: jdk/jshell/ToolBasicTest.java failed in testOpenFileOverHttp() and testOpenLocalFileUrl() > http://hg.openjdk.java.net/jdk/jdk/rev/2d1952d4d067 > 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java > http://hg.openjdk.java.net/jdk/jdk/rev/478e198da84b > 8195976: Add JNDI test com/sun/jndi/dns/AttributeTests/GetAny.java > http://hg.openjdk.java.net/jdk/jdk/rev/1d8f882f2b2f > > From adinn at redhat.com Thu Dec 6 09:22:20 2018 From: adinn at redhat.com (Andrew Dinn) Date: Thu, 6 Dec 2018 09:22:20 +0000 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: <592e2e41-1f44-c3ad-7cf9-7f62e24814f0@redhat.com> Vote: yes On 05/12/2018 20:34, Roger Riggs wrote: > I hereby nominate Chris Yin (xyin) to JDK Committer. > > Chris Yin (xyin) has worked in the Oracle Corelibs SQE team since last > year. > Over the past year, he has contributed 22 changes [3]?primarily?on test > development > for JNDI adding new tests or rewriting/refactoring old tests. And he has > contributed > bug fixes and new tests for other components such as in package, net, > jshell, etc. > Some?significant change sets can be found at [4] > > Votes are due by 12.00 pm CET, December 20th, 2018. > > Only current JDK Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying? to this > mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Roger > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] > http://hg.openjdk.java.net/jdk/jdk/search/?rev=(keyword(%22chris.yin at oracle.com%22)%20or%20(author(xyin)))%20&revcount=2000 > > > [4] > 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/bca2b63dd839 > 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/2e495bbdc2b7 > 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/a562c65c3c74 > 8210695: Create test to cover JDK-8205330 InitialDirContext ctor > sometimes throws NPE if the server has sent a disconnection > http://hg.openjdk.java.net/jdk/jdk/rev/caac55d48dc3 > 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/4737d92d752f > 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/7939b3c4e408 > 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/499b873761d8 > 8201528: Add new test to check for package versioning information in > OpenJDK > http://hg.openjdk.java.net/jdk/jdk/rev/2a94ab65b026 > 8202690: jdk/jshell/ToolBasicTest.java failed in testOpenFileOverHttp() > and testOpenLocalFileUrl() > http://hg.openjdk.java.net/jdk/jdk/rev/2d1952d4d067 > 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java > http://hg.openjdk.java.net/jdk/jdk/rev/478e198da84b > 8195976: Add JNDI test com/sun/jndi/dns/AttributeTests/GetAny.java > http://hg.openjdk.java.net/jdk/jdk/rev/1d8f882f2b2f > > > -- regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander From tobias.hartmann at oracle.com Thu Dec 6 09:44:43 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Thu, 6 Dec 2018 10:44:43 +0100 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: <72dfe1c8-da57-65e4-09e5-2eb975b3dc0c@oracle.com> Vote: yes Best regards, Tobias On 05.12.18 21:34, Roger Riggs wrote: > I hereby nominate Chris Yin (xyin) to JDK Committer. > > Chris Yin (xyin) has worked in the Oracle Corelibs SQE team since last year. > Over the past year, he has contributed 22 changes [3]?primarily?on test development > for JNDI adding new tests or rewriting/refactoring old tests. And he has contributed > bug fixes and new tests for other components such as in package, net, jshell, etc. > Some?significant change sets can be found at [4] > > Votes are due by 12.00 pm CET, December 20th, 2018. > > Only current JDK Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying? to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Roger > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] > http://hg.openjdk.java.net/jdk/jdk/search/?rev=(keyword(%22chris.yin at oracle.com%22)%20or%20(author(xyin)))%20&revcount=2000 > > > [4] > 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/bca2b63dd839 > 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/2e495bbdc2b7 > 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/a562c65c3c74 > 8210695: Create test to cover JDK-8205330 InitialDirContext ctor sometimes throws NPE if the server > has sent a disconnection > http://hg.openjdk.java.net/jdk/jdk/rev/caac55d48dc3 > 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/4737d92d752f > 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/7939b3c4e408 > 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/499b873761d8 > 8201528: Add new test to check for package versioning information in OpenJDK > http://hg.openjdk.java.net/jdk/jdk/rev/2a94ab65b026 > 8202690: jdk/jshell/ToolBasicTest.java failed in testOpenFileOverHttp() and testOpenLocalFileUrl() > http://hg.openjdk.java.net/jdk/jdk/rev/2d1952d4d067 > 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java > http://hg.openjdk.java.net/jdk/jdk/rev/478e198da84b > 8195976: Add JNDI test com/sun/jndi/dns/AttributeTests/GetAny.java > http://hg.openjdk.java.net/jdk/jdk/rev/1d8f882f2b2f > > From roman at kennke.org Thu Dec 6 12:48:07 2018 From: roman at kennke.org (Roman Kennke) Date: Thu, 6 Dec 2018 13:48:07 +0100 Subject: Submit repo status In-Reply-To: References: Message-ID: <1e1832a2-ddfb-d223-7677-2887bd0e7e36@kennke.org> >> The submit repo was not working as expected last couple of days. >> The main reason is that the "hg pull" operation was not able to complete succesfully because of the number of heads in the repository. >> The submit repo hasn't been "cleaned" since it opened a year ago. >> There are currently 406 (closed + normal) branches in the repo and most of them are ?dead? (not active, but have not been closed). >> >> It was decided to start "resetting" the jdk/submit repository regularly. > > Another possibility would be to automatically close branches which > match a JBS ID once the corresponding change has been pushed to > jdk/jdk (the same way JBS issues get "Resloved" automatically once the > corresponding change gets pushed). Yeah, *that* would seem most useful. I tried hard to exercise hygiene on this, but it's easy to forget. A cron-job (or so) that queries all heads and checks JBS ID, and closes branches for closed issues seems most useful. Is that what is meant by resetting? I just hope it doesn't mean we have to clone a fresh new jdk/submit every week/month or so.. Roman From karen.kinnear at oracle.com Thu Dec 6 14:08:41 2018 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Thu, 6 Dec 2018 09:08:41 -0500 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <579A5100-6097-49B2-B22D-4EFE60BB0F7D@oracle.com> Vote: yes thanks, Karen > On Dec 4, 2018, at 8:13 PM, Alexandre (Shura) Iline wrote: > > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From karen.kinnear at oracle.com Thu Dec 6 14:06:57 2018 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Thu, 6 Dec 2018 09:06:57 -0500 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: <09DCDE18-3B4B-4BCA-A30A-6D3BD5A8383A@oracle.com> Vote: yes thanks, Karen > On Dec 5, 2018, at 3:34 PM, Roger Riggs wrote: > > I hereby nominate Chris Yin (xyin) to JDK Committer. > > Chris Yin (xyin) has worked in the Oracle Corelibs SQE team since last year. > Over the past year, he has contributed 22 changes [3] primarily on test development > for JNDI adding new tests or rewriting/refactoring old tests. And he has contributed > bug fixes and new tests for other components such as in package, net, jshell, etc. > Some significant change sets can be found at [4] > > Votes are due by 12.00 pm CET, December 20th, 2018. > > Only current JDK Committers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Roger > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] http://hg.openjdk.java.net/jdk/jdk/search/?rev=(keyword(%22chris.yin at oracle.com%22)%20or%20(author(xyin)))%20&revcount=2000 > > [4] > 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/bca2b63dd839 > 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/2e495bbdc2b7 > 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/a562c65c3c74 > 8210695: Create test to cover JDK-8205330 InitialDirContext ctor sometimes throws NPE if the server has sent a disconnection > http://hg.openjdk.java.net/jdk/jdk/rev/caac55d48dc3 > 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/4737d92d752f > 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/7939b3c4e408 > 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/499b873761d8 > 8201528: Add new test to check for package versioning information in OpenJDK > http://hg.openjdk.java.net/jdk/jdk/rev/2a94ab65b026 > 8202690: jdk/jshell/ToolBasicTest.java failed in testOpenFileOverHttp() and testOpenLocalFileUrl() > http://hg.openjdk.java.net/jdk/jdk/rev/2d1952d4d067 > 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java > http://hg.openjdk.java.net/jdk/jdk/rev/478e198da84b > 8195976: Add JNDI test com/sun/jndi/dns/AttributeTests/GetAny.java > http://hg.openjdk.java.net/jdk/jdk/rev/1d8f882f2b2f > > From gromero at linux.vnet.ibm.com Thu Dec 6 14:21:46 2018 From: gromero at linux.vnet.ibm.com (Gustavo Romero) Date: Thu, 6 Dec 2018 12:21:46 -0200 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <272e29ec-826e-3193-947b-c806cdf97297@linux.vnet.ibm.com> Vote: yes On 12/04/2018 11:13 PM, Alexandre (Shura) Iline wrote: > Hi. > > I hereby nominate Abdul Muneer Kolarkunnu (akolarkunnu) to JDK Committer. > > Muneer has been working in the Quality team at Oracle for last 3 years. He has contributed more than 20 changes to the JDK Project by now [0]. > > Votes are due by 5 p.m. PT on December 16th 2018 > > Only current JDK Project Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Alexander (Shura) Ilin > > [0] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(akolarkunnu)+or+desc(%22abdul.kolarkunnu%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > > From gromero at linux.vnet.ibm.com Thu Dec 6 14:22:29 2018 From: gromero at linux.vnet.ibm.com (Gustavo Romero) Date: Thu, 6 Dec 2018 12:22:29 -0200 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: <29cd1f26-a963-6d74-7ff6-73d8ae5de944@linux.vnet.ibm.com> Vote: yes On 12/05/2018 06:34 PM, Roger Riggs wrote: > I hereby nominate Chris Yin (xyin) to JDK Committer. > > Chris Yin (xyin) has worked in the Oracle Corelibs SQE team since last year. > Over the past year, he has contributed 22 changes [3]?primarily?on test development > for JNDI adding new tests or rewriting/refactoring old tests. And he has contributed > bug fixes and new tests for other components such as in package, net, jshell, etc. > Some?significant change sets can be found at [4] > > Votes are due by 12.00 pm CET, December 20th, 2018. > > Only current JDK Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying? to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Roger > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] http://hg.openjdk.java.net/jdk/jdk/search/?rev=(keyword(%22chris.yin at oracle.com%22)%20or%20(author(xyin)))%20&revcount=2000 > > [4] > 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/bca2b63dd839 > 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/2e495bbdc2b7 > 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/a562c65c3c74 > 8210695: Create test to cover JDK-8205330 InitialDirContext ctor sometimes throws NPE if the server has sent a disconnection > http://hg.openjdk.java.net/jdk/jdk/rev/caac55d48dc3 > 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/4737d92d752f > 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/7939b3c4e408 > 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/499b873761d8 > 8201528: Add new test to check for package versioning information in OpenJDK > http://hg.openjdk.java.net/jdk/jdk/rev/2a94ab65b026 > 8202690: jdk/jshell/ToolBasicTest.java failed in testOpenFileOverHttp() and testOpenLocalFileUrl() > http://hg.openjdk.java.net/jdk/jdk/rev/2d1952d4d067 > 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java > http://hg.openjdk.java.net/jdk/jdk/rev/478e198da84b > 8195976: Add JNDI test com/sun/jndi/dns/AttributeTests/GetAny.java > http://hg.openjdk.java.net/jdk/jdk/rev/1d8f882f2b2f > > From mandy.chung at oracle.com Thu Dec 6 15:51:14 2018 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 6 Dec 2018 07:51:14 -0800 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: <83f6ed5a-6030-645d-f958-29af237a753b@oracle.com> Vote: yes Mandy On 12/5/18 12:34 PM, Roger Riggs wrote: > I hereby nominate Chris Yin (xyin) to JDK Committer. > > Chris Yin (xyin) has worked in the Oracle Corelibs SQE team since last > year. > Over the past year, he has contributed 22 changes [3]?primarily?on > test development > for JNDI adding new tests or rewriting/refactoring old tests. And he > has contributed > bug fixes and new tests for other components such as in package, net, > jshell, etc. > Some?significant change sets can be found at [4] > > Votes are due by 12.00 pm CET, December 20th, 2018. > > Only current JDK Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying to > this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Roger > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] > http://hg.openjdk.java.net/jdk/jdk/search/?rev=(keyword(%22chris.yin at oracle.com%22)%20or%20(author(xyin)))%20&revcount=2000 > > > [4] > 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/bca2b63dd839 > 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/2e495bbdc2b7 > 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/a562c65c3c74 > 8210695: Create test to cover JDK-8205330 InitialDirContext ctor > sometimes throws NPE if the server has sent a disconnection > http://hg.openjdk.java.net/jdk/jdk/rev/caac55d48dc3 > 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/4737d92d752f > 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/7939b3c4e408 > 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/499b873761d8 > 8201528: Add new test to check for package versioning information in > OpenJDK > http://hg.openjdk.java.net/jdk/jdk/rev/2a94ab65b026 > 8202690: jdk/jshell/ToolBasicTest.java failed in > testOpenFileOverHttp() and testOpenLocalFileUrl() > http://hg.openjdk.java.net/jdk/jdk/rev/2d1952d4d067 > 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java > http://hg.openjdk.java.net/jdk/jdk/rev/478e198da84b > 8195976: Add JNDI test com/sun/jndi/dns/AttributeTests/GetAny.java > http://hg.openjdk.java.net/jdk/jdk/rev/1d8f882f2b2f > > From vladimir.x.ivanov at oracle.com Thu Dec 6 17:48:44 2018 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Thu, 6 Dec 2018 09:48:44 -0800 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: <1733a3f8-ac11-de82-805a-1ecb59d836c7@oracle.com> Vote: yes Best regards, Vladimir Ivanov On 05/12/2018 12:34, Roger Riggs wrote: > I hereby nominate Chris Yin (xyin) to JDK Committer. From stuart.marks at oracle.com Thu Dec 6 19:36:56 2018 From: stuart.marks at oracle.com (Stuart Marks) Date: Thu, 6 Dec 2018 11:36:56 -0800 Subject: CFV: New JDK Committer: Tagir Valeev Message-ID: I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. Tagir has contributed 18 fixes to the JDK, including several notable API enhancements, mostly in Stream and Collections areas. His contributions are listed below. Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. Only current JDK Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. [1] - http://openjdk.java.net/census [2] - http://openjdk.java.net/projects/#committer-vote Thanks, s'marks ========== Tagir's JDK contributions: $ hg log --template "{node|short} {desc|firstline}\n" -r 'sort(user(tvaleev) or keyword(amaembo), -date)' de9486d74a74 8211693: Convert C-style array declarations in client demos and jdk.accessibility 2e330da7cbf4 8211300: Convert C-style array declarations in JDK client code 490d9001eba9 8205461: Create Collector which merges results of two other collectors 256109602af0 8164189: Collectors.toSet() parallel performance improvement d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to collect 128 elements even if limit is less 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for boxed() and asLongStream() operations 6045bfdd65a5 8155600: Performance optimization of Arrays.asList().iterator() acc9c4072c89 8148748: ArrayList.subList().spliterator() is not late-binding c48e75478177 8151123: Collectors.summingDouble/averagingDouble unnecessarily call mapper twice 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow registering new handlers after stream is consumed de2976b3614c 8072727: add variation of Stream.iterate() that's finite 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot properly split after tryAdvance() f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization db033bd15d41 8148250: Stream.limit() parallel tasks with ordered non-SUBSIZED source should short-circuit 08655b6caa22 8146218: Add LocalDate.datesUntil method producing Stream References: Message-ID: Vote: yes On 12/6/18 8:36 PM, Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. From Roger.Riggs at oracle.com Thu Dec 6 19:42:00 2018 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Thu, 6 Dec 2018 14:42:00 -0500 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <6f11f4a3-156c-6e6c-44b2-2116f4289089@oracle.com> Vote: Yes On 12/06/2018 02:36 PM, Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. From vladimir.x.ivanov at oracle.com Thu Dec 6 19:40:32 2018 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Thu, 6 Dec 2018 11:40:32 -0800 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <7ce8c52a-f0ce-0c6b-f26f-7904ac06ba10@oracle.com> Vote: yes Best regards, Vladimir Ivanov On 06/12/2018 11:36, Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. From stuart.marks at oracle.com Thu Dec 6 19:41:38 2018 From: stuart.marks at oracle.com (Stuart Marks) Date: Thu, 6 Dec 2018 11:41:38 -0800 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: Vote: yes On 12/6/18 11:36 AM, Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > > Tagir has contributed 18 fixes to the JDK, including several notable API > enhancements, mostly in Stream and Collections areas. His contributions are > listed below. > > Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. > > Only current JDK Committers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > [1] - http://openjdk.java.net/census > [2] - http://openjdk.java.net/projects/#committer-vote > > Thanks, > > s'marks > > ========== > > Tagir's JDK contributions: > > $ hg log --template "{node|short} {desc|firstline}\n" -r 'sort(user(tvaleev) or > keyword(amaembo), -date)' > > de9486d74a74 8211693: Convert C-style array declarations in client demos and > jdk.accessibility > 2e330da7cbf4 8211300: Convert C-style array declarations in JDK client code > 490d9001eba9 8205461: Create Collector which merges results of two other collectors > 256109602af0 8164189: Collectors.toSet() parallel performance improvement > d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to collect 128 > elements even if limit is less > 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for boxed() > and asLongStream() operations > 6045bfdd65a5 8155600: Performance optimization of Arrays.asList().iterator() > acc9c4072c89 8148748: ArrayList.subList().spliterator() is not late-binding > c48e75478177 8151123: Collectors.summingDouble/averagingDouble unnecessarily > call mapper twice > 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow registering new > handlers after stream is consumed > de2976b3614c 8072727: add variation of Stream.iterate() that's finite > 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot properly split > after tryAdvance() > f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization > db033bd15d41 8148250: Stream.limit() parallel tasks with ordered non-SUBSIZED > source should short-circuit > 08655b6caa22 8146218: Add LocalDate.datesUntil method producing Stream b721350c05c0 8145007: Pattern splitAsStream is not late binding as required by > the specification > c60dc808ff5a 8141630: Specification of Collections.synchronized* need to state > traversal constraints > 6e8998981fbd 8136686: Collectors.counting can use Collectors.summingLong to > reduce boxing From joe.darcy at oracle.com Thu Dec 6 19:46:42 2018 From: joe.darcy at oracle.com (joe darcy) Date: Thu, 6 Dec 2018 11:46:42 -0800 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: Vote: yes -Joe On 12/6/2018 11:36 AM, Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > > Tagir has contributed 18 fixes to the JDK, including several notable > API enhancements, mostly in Stream and Collections areas. His > contributions are listed below. > > Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. > > Only current JDK Committers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > [1] - http://openjdk.java.net/census > [2] - http://openjdk.java.net/projects/#committer-vote > > Thanks, > > s'marks > > ========== > > Tagir's JDK contributions: > > $ hg log --template "{node|short} {desc|firstline}\n" -r > 'sort(user(tvaleev) or keyword(amaembo), -date)' > > de9486d74a74 8211693: Convert C-style array declarations in client > demos and jdk.accessibility > 2e330da7cbf4 8211300: Convert C-style array declarations in JDK client > code > 490d9001eba9 8205461: Create Collector which merges results of two > other collectors > 256109602af0 8164189: Collectors.toSet() parallel performance improvement > d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to > collect 128 elements even if limit is less > 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for > boxed() and asLongStream() operations > 6045bfdd65a5 8155600: Performance optimization of > Arrays.asList().iterator() > acc9c4072c89 8148748: ArrayList.subList().spliterator() is not > late-binding > c48e75478177 8151123: Collectors.summingDouble/averagingDouble > unnecessarily call mapper twice > 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow > registering new handlers after stream is consumed > de2976b3614c 8072727: add variation of Stream.iterate() that's finite > 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot > properly split after tryAdvance() > f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization > db033bd15d41 8148250: Stream.limit() parallel tasks with ordered > non-SUBSIZED source should short-circuit > 08655b6caa22 8146218: Add LocalDate.datesUntil method producing > Stream b721350c05c0 8145007: Pattern splitAsStream is not late binding as > required by the specification > c60dc808ff5a 8141630: Specification of Collections.synchronized* need > to state traversal constraints > 6e8998981fbd 8136686: Collectors.counting can use > Collectors.summingLong to reduce boxing From lance.andersen at oracle.com Thu Dec 6 19:47:38 2018 From: lance.andersen at oracle.com (Lance Andersen) Date: Thu, 6 Dec 2018 14:47:38 -0500 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: Vote: yes > On Dec 6, 2018, at 2:36 PM, Stuart Marks wrote: > > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > > Tagir has contributed 18 fixes to the JDK, including several notable API enhancements, mostly in Stream and Collections areas. His contributions are listed below. > > Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. > > Only current JDK Committers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > [1] - http://openjdk.java.net/census > [2] - http://openjdk.java.net/projects/#committer-vote > > Thanks, > > s'marks > > ========== > > Tagir's JDK contributions: > > $ hg log --template "{node|short} {desc|firstline}\n" -r 'sort(user(tvaleev) or keyword(amaembo), -date)' > > de9486d74a74 8211693: Convert C-style array declarations in client demos and jdk.accessibility > 2e330da7cbf4 8211300: Convert C-style array declarations in JDK client code > 490d9001eba9 8205461: Create Collector which merges results of two other collectors > 256109602af0 8164189: Collectors.toSet() parallel performance improvement > d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to collect 128 elements even if limit is less > 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for boxed() and asLongStream() operations > 6045bfdd65a5 8155600: Performance optimization of Arrays.asList().iterator() > acc9c4072c89 8148748: ArrayList.subList().spliterator() is not late-binding > c48e75478177 8151123: Collectors.summingDouble/averagingDouble unnecessarily call mapper twice > 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow registering new handlers after stream is consumed > de2976b3614c 8072727: add variation of Stream.iterate() that's finite > 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot properly split after tryAdvance() > f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization > db033bd15d41 8148250: Stream.limit() parallel tasks with ordered non-SUBSIZED source should short-circuit > 08655b6caa22 8146218: Add LocalDate.datesUntil method producing Stream b721350c05c0 8145007: Pattern splitAsStream is not late binding as required by the specification > c60dc808ff5a 8141630: Specification of Collections.synchronized* need to state traversal constraints > 6e8998981fbd 8136686: Collectors.counting can use Collectors.summingLong to reduce boxing Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com From james.laskey at oracle.com Thu Dec 6 19:48:33 2018 From: james.laskey at oracle.com (Jim Laskey) Date: Thu, 6 Dec 2018 15:48:33 -0400 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <6F1F0A27-9CE6-4AFF-B273-75B20D62AD05@oracle.com> Vote: yes > On Dec 6, 2018, at 3:36 PM, Stuart Marks wrote: > > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > > Tagir has contributed 18 fixes to the JDK, including several notable API enhancements, mostly in Stream and Collections areas. His contributions are listed below. > > Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. > > Only current JDK Committers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > [1] - http://openjdk.java.net/census > [2] - http://openjdk.java.net/projects/#committer-vote > > Thanks, > > s'marks > > ========== > > Tagir's JDK contributions: > > $ hg log --template "{node|short} {desc|firstline}\n" -r 'sort(user(tvaleev) or keyword(amaembo), -date)' > > de9486d74a74 8211693: Convert C-style array declarations in client demos and jdk.accessibility > 2e330da7cbf4 8211300: Convert C-style array declarations in JDK client code > 490d9001eba9 8205461: Create Collector which merges results of two other collectors > 256109602af0 8164189: Collectors.toSet() parallel performance improvement > d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to collect 128 elements even if limit is less > 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for boxed() and asLongStream() operations > 6045bfdd65a5 8155600: Performance optimization of Arrays.asList().iterator() > acc9c4072c89 8148748: ArrayList.subList().spliterator() is not late-binding > c48e75478177 8151123: Collectors.summingDouble/averagingDouble unnecessarily call mapper twice > 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow registering new handlers after stream is consumed > de2976b3614c 8072727: add variation of Stream.iterate() that's finite > 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot properly split after tryAdvance() > f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization > db033bd15d41 8148250: Stream.limit() parallel tasks with ordered non-SUBSIZED source should short-circuit > 08655b6caa22 8146218: Add LocalDate.datesUntil method producing Stream b721350c05c0 8145007: Pattern splitAsStream is not late binding as required by the specification > c60dc808ff5a 8141630: Specification of Collections.synchronized* need to state traversal constraints > 6e8998981fbd 8136686: Collectors.counting can use Collectors.summingLong to reduce boxing From dmitry.chuyko at bell-sw.com Thu Dec 6 20:10:43 2018 From: dmitry.chuyko at bell-sw.com (Dmitry Chuyko) Date: Thu, 6 Dec 2018 23:10:43 +0300 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <2c4c0a0b-51f3-13d2-f6cd-399c3363466e@bell-sw.com> Vote: yes On 12/6/18 10:36 PM, Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > From brian.goetz at oracle.com Thu Dec 6 20:16:29 2018 From: brian.goetz at oracle.com (Brian Goetz) Date: Thu, 6 Dec 2018 15:16:29 -0500 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <1bcfc3d7-1709-aacc-5d2a-316bbf376dba@oracle.com> Vote: Yes On 12/6/2018 2:36 PM, Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > > Tagir has contributed 18 fixes to the JDK, including several notable > API enhancements, mostly in Stream and Collections areas. His > contributions are listed below. > > Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. > > Only current JDK Committers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > [1] - http://openjdk.java.net/census > [2] - http://openjdk.java.net/projects/#committer-vote > > Thanks, > > s'marks > > ========== > > Tagir's JDK contributions: > > $ hg log --template "{node|short} {desc|firstline}\n" -r > 'sort(user(tvaleev) or keyword(amaembo), -date)' > > de9486d74a74 8211693: Convert C-style array declarations in client > demos and jdk.accessibility > 2e330da7cbf4 8211300: Convert C-style array declarations in JDK client > code > 490d9001eba9 8205461: Create Collector which merges results of two > other collectors > 256109602af0 8164189: Collectors.toSet() parallel performance improvement > d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to > collect 128 elements even if limit is less > 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for > boxed() and asLongStream() operations > 6045bfdd65a5 8155600: Performance optimization of > Arrays.asList().iterator() > acc9c4072c89 8148748: ArrayList.subList().spliterator() is not > late-binding > c48e75478177 8151123: Collectors.summingDouble/averagingDouble > unnecessarily call mapper twice > 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow > registering new handlers after stream is consumed > de2976b3614c 8072727: add variation of Stream.iterate() that's finite > 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot > properly split after tryAdvance() > f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization > db033bd15d41 8148250: Stream.limit() parallel tasks with ordered > non-SUBSIZED source should short-circuit > 08655b6caa22 8146218: Add LocalDate.datesUntil method producing > Stream b721350c05c0 8145007: Pattern splitAsStream is not late binding as > required by the specification > c60dc808ff5a 8141630: Specification of Collections.synchronized* need > to state traversal constraints > 6e8998981fbd 8136686: Collectors.counting can use > Collectors.summingLong to reduce boxing From vicente.romero at oracle.com Thu Dec 6 21:04:48 2018 From: vicente.romero at oracle.com (Vicente Romero) Date: Thu, 6 Dec 2018 16:04:48 -0500 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: vote: yes On 12/6/18 2:36 PM, Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > > Tagir has contributed 18 fixes to the JDK, including several notable > API enhancements, mostly in Stream and Collections areas. His > contributions are listed below. > > Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. > > Only current JDK Committers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > [1] - http://openjdk.java.net/census > [2] - http://openjdk.java.net/projects/#committer-vote > > Thanks, > > s'marks > > ========== > > Tagir's JDK contributions: > > $ hg log --template "{node|short} {desc|firstline}\n" -r > 'sort(user(tvaleev) or keyword(amaembo), -date)' > > de9486d74a74 8211693: Convert C-style array declarations in client > demos and jdk.accessibility > 2e330da7cbf4 8211300: Convert C-style array declarations in JDK client > code > 490d9001eba9 8205461: Create Collector which merges results of two > other collectors > 256109602af0 8164189: Collectors.toSet() parallel performance improvement > d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to > collect 128 elements even if limit is less > 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for > boxed() and asLongStream() operations > 6045bfdd65a5 8155600: Performance optimization of > Arrays.asList().iterator() > acc9c4072c89 8148748: ArrayList.subList().spliterator() is not > late-binding > c48e75478177 8151123: Collectors.summingDouble/averagingDouble > unnecessarily call mapper twice > 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow > registering new handlers after stream is consumed > de2976b3614c 8072727: add variation of Stream.iterate() that's finite > 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot > properly split after tryAdvance() > f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization > db033bd15d41 8148250: Stream.limit() parallel tasks with ordered > non-SUBSIZED source should short-circuit > 08655b6caa22 8146218: Add LocalDate.datesUntil method producing > Stream b721350c05c0 8145007: Pattern splitAsStream is not late binding as > required by the specification > c60dc808ff5a 8141630: Specification of Collections.synchronized* need > to state traversal constraints > 6e8998981fbd 8136686: Collectors.counting can use > Collectors.summingLong to reduce boxing From brent.christian at oracle.com Thu Dec 6 22:57:08 2018 From: brent.christian at oracle.com (Brent Christian) Date: Thu, 6 Dec 2018 14:57:08 -0800 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <9c11a785-1d3f-c6f4-93b3-55a9cd5686ad@oracle.com> Vote: Yes On 12/6/18 11:36 AM, Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > From mark.reinhold at oracle.com Thu Dec 6 23:18:40 2018 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Thu, 06 Dec 2018 15:18:40 -0800 Subject: JEP proposed to target JDK 12: 189: Shenandoah: A Low-Pause-Time Garbage Collector (Experimental) In-Reply-To: <20181129225354.4496B231A25@eggemoggin.niobe.net> References: <20181129225354.4496B231A25@eggemoggin.niobe.net> Message-ID: <20181206151840.40736570@eggemoggin.niobe.net> 2018/11/29 14:53:54 -0800, mark.reinhold at oracle.com: > The following JEP is proposed to target JDK 12: > > 189: Shenandoah: A Low-Pause-Time Garbage Collector (Experimental) > https://openjdk.java.net/jeps/189 > > Feedback on this proposal from JDK Project Committers and Reviewers [1] > is more than welcome, as are reasoned objections. If no such objections > are raised by 23:00 UTC on Thursday, 6 December, or if they?re raised > and then satisfactorily answered, then per the JEP 2.0 process proposal > [2] I?ll target this JEP to JDK 12. Hearing no objections, I?ve targeted this JEP to JDK 12. - Mark From mark.reinhold at oracle.com Thu Dec 6 23:18:49 2018 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Thu, 06 Dec 2018 15:18:49 -0800 Subject: JEP proposed to target JDK 12: 334: JVM Constants API In-Reply-To: <20181129225355.680D3231A27@eggemoggin.niobe.net> References: <20181129225355.680D3231A27@eggemoggin.niobe.net> Message-ID: <20181206151849.354583370@eggemoggin.niobe.net> 2018/11/29 14:53:55 -0800, mark.reinhold at oracle.com: > The following JEP is proposed to target JDK 12: > > 334: JVM Constants API > https://openjdk.java.net/jeps/334 > > Feedback on this proposal from JDK Project Committers and Reviewers [1] > is more than welcome, as are reasoned objections. If no such objections > are raised by 23:00 UTC on Thursday, 6 December, or if they?re raised > and then satisfactorily answered, then per the JEP 2.0 process proposal > [2] I?ll target this JEP to JDK 12. Hearing no objections, I?ve targeted this JEP to JDK 12. - Mark From mark.reinhold at oracle.com Thu Dec 6 23:19:07 2018 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Thu, 06 Dec 2018 15:19:07 -0800 Subject: JEP proposed to target JDK 12: 346: Promptly Return Unused Committed Memory from G1 In-Reply-To: <20181129225357.81199231A2B@eggemoggin.niobe.net> References: <20181129225357.81199231A2B@eggemoggin.niobe.net> Message-ID: <20181206151907.399073767@eggemoggin.niobe.net> 2018/11/29 14:53:57 -0800, mark.reinhold at oracle.com: > The following JEP is proposed to target JDK 12: > > 346: Promptly Return Unused Committed Memory from G1 > https://openjdk.java.net/jeps/346 > > Feedback on this proposal from JDK Project Committers and Reviewers [1] > is more than welcome, as are reasoned objections. If no such objections > are raised by 23:00 UTC on Thursday, 6 December, or if they?re raised > and then satisfactorily answered, then per the JEP 2.0 process proposal > [2] I?ll target this JEP to JDK 12. Hearing no objections, I?ve targeted this JEP to JDK 12. - Mark From mark.reinhold at oracle.com Thu Dec 6 23:18:58 2018 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Thu, 06 Dec 2018 15:18:58 -0800 Subject: JEP proposed to target JDK 12: 344: Abortable Mixed Collections for G1 In-Reply-To: <20181129225356.7130A231A29@eggemoggin.niobe.net> References: <20181129225356.7130A231A29@eggemoggin.niobe.net> Message-ID: <20181206151858.294080123@eggemoggin.niobe.net> 2018/11/29 14:53:56 -0800, mark.reinhold at oracle.com: > The following JEP is proposed to target JDK 12: > > 344: Abortable Mixed Collections for G1 > https://openjdk.java.net/jeps/344 > > Feedback on this proposal from JDK Project Committers and Reviewers [1] > is more than welcome, as are reasoned objections. If no such objections > are raised by 23:00 UTC on Thursday, 6 December, or if they?re raised > and then satisfactorily answered, then per the JEP 2.0 process proposal > [2] I?ll target this JEP to JDK 12. Hearing no objections, I?ve targeted this JEP to JDK 12. - Mark From ivan.gerasimov at oracle.com Thu Dec 6 23:21:43 2018 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Thu, 6 Dec 2018 15:21:43 -0800 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <69c9cd72-98ca-0e87-6bec-7e233dc5e5c1@oracle.com> Vote: Yes -- With kind regards, Ivan Gerasimov From martinrb at google.com Fri Dec 7 03:38:32 2018 From: martinrb at google.com (Martin Buchholz) Date: Thu, 6 Dec 2018 19:38:32 -0800 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: Vote: yes On Thu, Dec 6, 2018 at 11:39 AM Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > > Tagir has contributed 18 fixes to the JDK, including several notable API > enhancements, mostly in Stream and Collections areas. His contributions > are > listed below. > > Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. > > Only current JDK Committers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > [1] - http://openjdk.java.net/census > [2] - http://openjdk.java.net/projects/#committer-vote > > Thanks, > > s'marks > > ========== > > Tagir's JDK contributions: > > $ hg log --template "{node|short} {desc|firstline}\n" -r > 'sort(user(tvaleev) or > keyword(amaembo), -date)' > > de9486d74a74 8211693: Convert C-style array declarations in client demos > and > jdk.accessibility > 2e330da7cbf4 8211300: Convert C-style array declarations in JDK client code > 490d9001eba9 8205461: Create Collector which merges results of two other > collectors > 256109602af0 8164189: Collectors.toSet() parallel performance improvement > d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to collect > 128 > elements even if limit is less > 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for > boxed() > and asLongStream() operations > 6045bfdd65a5 8155600: Performance optimization of > Arrays.asList().iterator() > acc9c4072c89 8148748: ArrayList.subList().spliterator() is not late-binding > c48e75478177 8151123: Collectors.summingDouble/averagingDouble > unnecessarily > call mapper twice > 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow registering > new > handlers after stream is consumed > de2976b3614c 8072727: add variation of Stream.iterate() that's finite > 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot properly > split > after tryAdvance() > f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization > db033bd15d41 8148250: Stream.limit() parallel tasks with ordered > non-SUBSIZED > source should short-circuit > 08655b6caa22 8146218: Add LocalDate.datesUntil method producing > Stream b721350c05c0 8145007: Pattern splitAsStream is not late binding as > required by > the specification > c60dc808ff5a 8141630: Specification of Collections.synchronized* need to > state > traversal constraints > 6e8998981fbd 8136686: Collectors.counting can use Collectors.summingLong > to > reduce boxing > From tobias.hartmann at oracle.com Fri Dec 7 07:28:51 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Fri, 7 Dec 2018 08:28:51 +0100 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <90af43e0-8a0a-c7df-6635-a4d9d9644dfa@oracle.com> Vote: yes Best regards, Tobias On 06.12.18 20:36, Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > > Tagir has contributed 18 fixes to the JDK, including several notable API enhancements, mostly in > Stream and Collections areas. His contributions are listed below. > > Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. > > Only current JDK Committers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > [1] - http://openjdk.java.net/census > [2] - http://openjdk.java.net/projects/#committer-vote > > Thanks, > > s'marks > > ========== > > Tagir's JDK contributions: > > $ hg log --template "{node|short} {desc|firstline}\n" -r 'sort(user(tvaleev) or keyword(amaembo), > -date)' > > de9486d74a74 8211693: Convert C-style array declarations in client demos and jdk.accessibility > 2e330da7cbf4 8211300: Convert C-style array declarations in JDK client code > 490d9001eba9 8205461: Create Collector which merges results of two other collectors > 256109602af0 8164189: Collectors.toSet() parallel performance improvement > d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to collect 128 elements even if limit > is less > 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for boxed() and asLongStream() > operations > 6045bfdd65a5 8155600: Performance optimization of Arrays.asList().iterator() > acc9c4072c89 8148748: ArrayList.subList().spliterator() is not late-binding > c48e75478177 8151123: Collectors.summingDouble/averagingDouble unnecessarily call mapper twice > 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow registering new handlers after stream is > consumed > de2976b3614c 8072727: add variation of Stream.iterate() that's finite > 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot properly split after tryAdvance() > f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization > db033bd15d41 8148250: Stream.limit() parallel tasks with ordered non-SUBSIZED source should > short-circuit > 08655b6caa22 8146218: Add LocalDate.datesUntil method producing Stream b721350c05c0 8145007: Pattern splitAsStream is not late binding as required by the specification > c60dc808ff5a 8141630: Specification of Collections.synchronized* need to state traversal constraints > 6e8998981fbd 8136686: Collectors.counting can use Collectors.summingLong to reduce boxing From Alan.Bateman at oracle.com Fri Dec 7 07:30:52 2018 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 7 Dec 2018 07:30:52 +0000 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: Vote: yes From sean.coffey at oracle.com Fri Dec 7 07:36:37 2018 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Fri, 07 Dec 2018 07:36:37 +0000 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <8F4CBD47-A631-481B-991B-45F81015B902@oracle.com> Vote: yes Regards, Sean. On 6 December 2018 19:36:56 GMT, Stuart Marks wrote: >I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > >Tagir has contributed 18 fixes to the JDK, including several notable >API >enhancements, mostly in Stream and Collections areas. His contributions >are >listed below. > >Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. > >Only current JDK Committers [1] are eligible to vote on this >nomination. >Votes must be cast in the open by replying to this mailing list. > >For Lazy Consensus voting instructions, see [2]. > >[1] - http://openjdk.java.net/census >[2] - http://openjdk.java.net/projects/#committer-vote > >Thanks, > >s'marks > >========== > >Tagir's JDK contributions: > >$ hg log --template "{node|short} {desc|firstline}\n" -r >'sort(user(tvaleev) or >keyword(amaembo), -date)' > >de9486d74a74 8211693: Convert C-style array declarations in client >demos and >jdk.accessibility >2e330da7cbf4 8211300: Convert C-style array declarations in JDK client >code >490d9001eba9 8205461: Create Collector which merges results of two >other collectors >256109602af0 8164189: Collectors.toSet() parallel performance >improvement >d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to >collect 128 >elements even if limit is less >1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for >boxed() >and asLongStream() operations >6045bfdd65a5 8155600: Performance optimization of >Arrays.asList().iterator() >acc9c4072c89 8148748: ArrayList.subList().spliterator() is not >late-binding >c48e75478177 8151123: Collectors.summingDouble/averagingDouble >unnecessarily >call mapper twice >6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow registering >new >handlers after stream is consumed >de2976b3614c 8072727: add variation of Stream.iterate() that's finite >05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot properly >split >after tryAdvance() >f61cb8475e5a 8148115: Stream.findFirst for unordered source >optimization >db033bd15d41 8148250: Stream.limit() parallel tasks with ordered >non-SUBSIZED >source should short-circuit >08655b6caa22 8146218: Add LocalDate.datesUntil method producing >Streamb721350c05c0 8145007: Pattern splitAsStream is not late binding as >required by >the specification >c60dc808ff5a 8141630: Specification of Collections.synchronized* need >to state >traversal constraints >6e8998981fbd 8136686: Collectors.counting can use >Collectors.summingLong to >reduce boxing From adinn at redhat.com Fri Dec 7 08:45:59 2018 From: adinn at redhat.com (Andrew Dinn) Date: Fri, 7 Dec 2018 08:45:59 +0000 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: Vote: yes On 06/12/2018 19:36, Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > > Tagir has contributed 18 fixes to the JDK, including several notable API > enhancements, mostly in Stream and Collections areas. His contributions > are listed below. > > Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. > > Only current JDK Committers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > [1] - http://openjdk.java.net/census > [2] - http://openjdk.java.net/projects/#committer-vote > > Thanks, > > s'marks > > ========== > > Tagir's JDK contributions: > > $ hg log --template "{node|short} {desc|firstline}\n" -r > 'sort(user(tvaleev) or keyword(amaembo), -date)' > > de9486d74a74 8211693: Convert C-style array declarations in client demos > and jdk.accessibility > 2e330da7cbf4 8211300: Convert C-style array declarations in JDK client code > 490d9001eba9 8205461: Create Collector which merges results of two other > collectors > 256109602af0 8164189: Collectors.toSet() parallel performance improvement > d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to collect > 128 elements even if limit is less > 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for > boxed() and asLongStream() operations > 6045bfdd65a5 8155600: Performance optimization of > Arrays.asList().iterator() > acc9c4072c89 8148748: ArrayList.subList().spliterator() is not late-binding > c48e75478177 8151123: Collectors.summingDouble/averagingDouble > unnecessarily call mapper twice > 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow registering > new handlers after stream is consumed > de2976b3614c 8072727: add variation of Stream.iterate() that's finite > 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot properly > split after tryAdvance() > f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization > db033bd15d41 8148250: Stream.limit() parallel tasks with ordered > non-SUBSIZED source should short-circuit > 08655b6caa22 8146218: Add LocalDate.datesUntil method producing > Stream b721350c05c0 8145007: Pattern splitAsStream is not late binding as > required by the specification > c60dc808ff5a 8141630: Specification of Collections.synchronized* need to > state traversal constraints > 6e8998981fbd 8136686: Collectors.counting can use Collectors.summingLong > to reduce boxing > -- regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander From volker.simonis at gmail.com Fri Dec 7 08:55:51 2018 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 7 Dec 2018 09:55:51 +0100 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: Vote: yes [Resending, because my first vote was blocked with "550 Denied by policy"] On Thu, Dec 6, 2018 at 8:39 PM Stuart Marks wrote: > > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > > Tagir has contributed 18 fixes to the JDK, including several notable API > enhancements, mostly in Stream and Collections areas. His contributions are > listed below. > > Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. > > Only current JDK Committers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > [1] - http://openjdk.java.net/census > [2] - http://openjdk.java.net/projects/#committer-vote > > Thanks, > > s'marks > > ========== > > Tagir's JDK contributions: > > $ hg log --template "{node|short} {desc|firstline}\n" -r 'sort(user(tvaleev) or > keyword(amaembo), -date)' > > de9486d74a74 8211693: Convert C-style array declarations in client demos and > jdk.accessibility > 2e330da7cbf4 8211300: Convert C-style array declarations in JDK client code > 490d9001eba9 8205461: Create Collector which merges results of two other collectors > 256109602af0 8164189: Collectors.toSet() parallel performance improvement > d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to collect 128 > elements even if limit is less > 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for boxed() > and asLongStream() operations > 6045bfdd65a5 8155600: Performance optimization of Arrays.asList().iterator() > acc9c4072c89 8148748: ArrayList.subList().spliterator() is not late-binding > c48e75478177 8151123: Collectors.summingDouble/averagingDouble unnecessarily > call mapper twice > 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow registering new > handlers after stream is consumed > de2976b3614c 8072727: add variation of Stream.iterate() that's finite > 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot properly split > after tryAdvance() > f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization > db033bd15d41 8148250: Stream.limit() parallel tasks with ordered non-SUBSIZED > source should short-circuit > 08655b6caa22 8146218: Add LocalDate.datesUntil method producing Stream b721350c05c0 8145007: Pattern splitAsStream is not late binding as required by > the specification > c60dc808ff5a 8141630: Specification of Collections.synchronized* need to state > traversal constraints > 6e8998981fbd 8136686: Collectors.counting can use Collectors.summingLong to > reduce boxing From dalibor.topic at oracle.com Fri Dec 7 10:02:51 2018 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Fri, 7 Dec 2018 11:02:51 +0100 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <050a13f0-e731-362c-ed64-2bbae31ad789@oracle.com> Vote: Yes. -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | D-22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From john.r.rose at oracle.com Fri Dec 7 11:22:47 2018 From: john.r.rose at oracle.com (John Rose) Date: Fri, 7 Dec 2018 03:22:47 -0800 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <3E6F46B6-6B61-481B-92C5-FD042F198D6E@oracle.com> Vote: yes From dmitrij.pochepko at bell-sw.com Fri Dec 7 11:58:21 2018 From: dmitrij.pochepko at bell-sw.com (Dmitrij Pochepko) Date: Fri, 7 Dec 2018 14:58:21 +0300 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: Vote: yes On 06/12/2018 10:36 PM, Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > > Tagir has contributed 18 fixes to the JDK, including several notable > API enhancements, mostly in Stream and Collections areas. His > contributions are listed below. > > Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. > > Only current JDK Committers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > [1] - http://openjdk.java.net/census > [2] - http://openjdk.java.net/projects/#committer-vote > > Thanks, > > s'marks > > ========== > > Tagir's JDK contributions: > > $ hg log --template "{node|short} {desc|firstline}\n" -r > 'sort(user(tvaleev) or keyword(amaembo), -date)' > > de9486d74a74 8211693: Convert C-style array declarations in client > demos and jdk.accessibility > 2e330da7cbf4 8211300: Convert C-style array declarations in JDK client > code > 490d9001eba9 8205461: Create Collector which merges results of two > other collectors > 256109602af0 8164189: Collectors.toSet() parallel performance improvement > d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to > collect 128 elements even if limit is less > 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for > boxed() and asLongStream() operations > 6045bfdd65a5 8155600: Performance optimization of > Arrays.asList().iterator() > acc9c4072c89 8148748: ArrayList.subList().spliterator() is not > late-binding > c48e75478177 8151123: Collectors.summingDouble/averagingDouble > unnecessarily call mapper twice > 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow > registering new handlers after stream is consumed > de2976b3614c 8072727: add variation of Stream.iterate() that's finite > 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot > properly split after tryAdvance() > f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization > db033bd15d41 8148250: Stream.limit() parallel tasks with ordered > non-SUBSIZED source should short-circuit > 08655b6caa22 8146218: Add LocalDate.datesUntil method producing > Stream b721350c05c0 8145007: Pattern splitAsStream is not late binding as > required by the specification > c60dc808ff5a 8141630: Specification of Collections.synchronized* need > to state traversal constraints > 6e8998981fbd 8136686: Collectors.counting can use > Collectors.summingLong to reduce boxing From alexey.ivanov at oracle.com Fri Dec 7 15:02:51 2018 From: alexey.ivanov at oracle.com (Alexey Ivanov) Date: Fri, 7 Dec 2018 15:02:51 +0000 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: <808379f1-87e3-ab1f-6b2f-c4a1434a53ad@oracle.com> Vote: yes Regards, Alexey On 05/12/2018 20:34, Roger Riggs wrote: > I hereby nominate Chris Yin (xyin) to JDK Committer. > > Chris Yin (xyin) has worked in the Oracle Corelibs SQE team since last > year. > Over the past year, he has contributed 22 changes [3]?primarily?on > test development > for JNDI adding new tests or rewriting/refactoring old tests. And he > has contributed > bug fixes and new tests for other components such as in package, net, > jshell, etc. > Some?significant change sets can be found at [4] > > Votes are due by 12.00 pm CET, December 20th, 2018. > > Only current JDK Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying to > this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Roger > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] > http://hg.openjdk.java.net/jdk/jdk/search/?rev=(keyword(%22chris.yin at oracle.com%22)%20or%20(author(xyin)))%20&revcount=2000 > > > [4] > 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/bca2b63dd839 > 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/2e495bbdc2b7 > 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/a562c65c3c74 > 8210695: Create test to cover JDK-8205330 InitialDirContext ctor > sometimes throws NPE if the server has sent a disconnection > http://hg.openjdk.java.net/jdk/jdk/rev/caac55d48dc3 > 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/4737d92d752f > 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/7939b3c4e408 > 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ > http://hg.openjdk.java.net/jdk/jdk/rev/499b873761d8 > 8201528: Add new test to check for package versioning information in > OpenJDK > http://hg.openjdk.java.net/jdk/jdk/rev/2a94ab65b026 > 8202690: jdk/jshell/ToolBasicTest.java failed in > testOpenFileOverHttp() and testOpenLocalFileUrl() > http://hg.openjdk.java.net/jdk/jdk/rev/2d1952d4d067 > 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java > http://hg.openjdk.java.net/jdk/jdk/rev/478e198da84b > 8195976: Add JNDI test com/sun/jndi/dns/AttributeTests/GetAny.java > http://hg.openjdk.java.net/jdk/jdk/rev/1d8f882f2b2f > > From daniel.fuchs at oracle.com Fri Dec 7 15:14:04 2018 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Fri, 7 Dec 2018 15:14:04 +0000 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <804cd5ef-5f81-4bff-51fc-afdee25c43e5@oracle.com> Vote: yes best regards, -- daniel On 06/12/2018 19:36, Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. From daniel.fuchs at oracle.com Fri Dec 7 15:15:39 2018 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Fri, 7 Dec 2018 15:15:39 +0000 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: <7b3d8ddf-bb98-9b38-1c32-7e9f04e48ae2@oracle.com> Vote: yes best regards, -- daniel On 05/12/2018 20:34, Roger Riggs wrote: > I hereby nominate Chris Yin (xyin) to JDK Committer. > From jan.lahoda at oracle.com Fri Dec 7 15:19:04 2018 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Fri, 7 Dec 2018 16:19:04 +0100 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <5C0A8F68.1090200@oracle.com> Vote: yes Jan On 6.12.2018 20:36, Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > > Tagir has contributed 18 fixes to the JDK, including several notable API > enhancements, mostly in Stream and Collections areas. His contributions > are listed below. > > Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. > > Only current JDK Committers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > [1] - http://openjdk.java.net/census > [2] - http://openjdk.java.net/projects/#committer-vote > > Thanks, > > s'marks > > ========== > > Tagir's JDK contributions: > > $ hg log --template "{node|short} {desc|firstline}\n" -r > 'sort(user(tvaleev) or keyword(amaembo), -date)' > > de9486d74a74 8211693: Convert C-style array declarations in client demos > and jdk.accessibility > 2e330da7cbf4 8211300: Convert C-style array declarations in JDK client code > 490d9001eba9 8205461: Create Collector which merges results of two other > collectors > 256109602af0 8164189: Collectors.toSet() parallel performance improvement > d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to collect > 128 elements even if limit is less > 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for > boxed() and asLongStream() operations > 6045bfdd65a5 8155600: Performance optimization of > Arrays.asList().iterator() > acc9c4072c89 8148748: ArrayList.subList().spliterator() is not late-binding > c48e75478177 8151123: Collectors.summingDouble/averagingDouble > unnecessarily call mapper twice > 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow registering > new handlers after stream is consumed > de2976b3614c 8072727: add variation of Stream.iterate() that's finite > 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot properly > split after tryAdvance() > f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization > db033bd15d41 8148250: Stream.limit() parallel tasks with ordered > non-SUBSIZED source should short-circuit > 08655b6caa22 8146218: Add LocalDate.datesUntil method producing > Stream b721350c05c0 8145007: Pattern splitAsStream is not late binding as > required by the specification > c60dc808ff5a 8141630: Specification of Collections.synchronized* need to > state traversal constraints > 6e8998981fbd 8136686: Collectors.counting can use Collectors.summingLong > to reduce boxing From bsrbnd at gmail.com Fri Dec 7 15:52:39 2018 From: bsrbnd at gmail.com (B. Blaser) Date: Fri, 7 Dec 2018 16:52:39 +0100 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: Vote: yes Regards, Bernard On Thu, 6 Dec 2018 at 20:40, Stuart Marks wrote: > > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. [...] From mandy.chung at oracle.com Fri Dec 7 16:10:51 2018 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 7 Dec 2018 08:10:51 -0800 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: Vote: yes Mandy On 12/6/18 11:36 AM, Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > > Tagir has contributed 18 fixes to the JDK, including several notable > API enhancements, mostly in Stream and Collections areas. His > contributions are listed below. > > Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. > > Only current JDK Committers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > [1] - http://openjdk.java.net/census > [2] - http://openjdk.java.net/projects/#committer-vote > > Thanks, > > s'marks > > ========== > > Tagir's JDK contributions: > > $ hg log --template "{node|short} {desc|firstline}\n" -r > 'sort(user(tvaleev) or keyword(amaembo), -date)' > > de9486d74a74 8211693: Convert C-style array declarations in client > demos and jdk.accessibility > 2e330da7cbf4 8211300: Convert C-style array declarations in JDK client > code > 490d9001eba9 8205461: Create Collector which merges results of two > other collectors > 256109602af0 8164189: Collectors.toSet() parallel performance improvement > d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to > collect 128 elements even if limit is less > 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for > boxed() and asLongStream() operations > 6045bfdd65a5 8155600: Performance optimization of > Arrays.asList().iterator() > acc9c4072c89 8148748: ArrayList.subList().spliterator() is not > late-binding > c48e75478177 8151123: Collectors.summingDouble/averagingDouble > unnecessarily call mapper twice > 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow > registering new handlers after stream is consumed > de2976b3614c 8072727: add variation of Stream.iterate() that's finite > 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot > properly split after tryAdvance() > f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization > db033bd15d41 8148250: Stream.limit() parallel tasks with ordered > non-SUBSIZED source should short-circuit > 08655b6caa22 8146218: Add LocalDate.datesUntil method producing > Stream b721350c05c0 8145007: Pattern splitAsStream is not late binding as > required by the specification > c60dc808ff5a 8141630: Specification of Collections.synchronized* need > to state traversal constraints > 6e8998981fbd 8136686: Collectors.counting can use > Collectors.summingLong to reduce boxing From mark.reinhold at oracle.com Fri Dec 7 17:25:03 2018 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Fri, 7 Dec 2018 09:25:03 -0800 (PST) Subject: JDK 12 enters Rampdown Phase One next week Message-ID: <20181207172503.4F73E232896@eggemoggin.niobe.net> JDK 12 enters Rampdown Phase One next week, on Thursday, 13 December. Changes intended for JDK 12 should be in the main-line repository (https://hg.openjdk.java.net/jdk/jdk) or the client repository (jdk/client), by 16:00 UTC on that day [1]. At that time we?ll fork jdk/jdk to the JDK 12 stabilization repository, jdk/jdk12, and promote next week?s build (jdk-12+24) and all remaining JDK 12 builds from there. We'll semi-automatically merge changes pushed to jdk/jdk12 into the main-line jdk/jdk repository, as we have in previous feature-release transitions. This means that: - If you make a change in JDK 12 then you needn't do any extra work to get it into the main line, though if a merge conflict arises then you might be asked to help resolve it. - If you need to make a change in both JDK 12 and the main line then just push it to JDK 12, and wait for the automatic merge to complete. Changes pushed into the jdk/jdk or jdk/client repositories after 16:00 UTC next Thursday will be destined for JDK 13 unless they're back-ported. The jdk/submit repo will continue to be for main-line (jdk/jdk) work. We?ll set up a jdk/submit12 repo for jdk/jdk12 work. The Rampdown Phase One process is defined in JEP 3 [2]. - Mark [1] https://time.is/1600_13_Dec_2018_in_UTC?JDK_12_Rampdown_Phase_One [2] https://openjdk.java.net/jeps/3 From jiangli.zhou at oracle.com Fri Dec 7 18:14:21 2018 From: jiangli.zhou at oracle.com (Jiangli Zhou) Date: Fri, 7 Dec 2018 10:14:21 -0800 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <3b7bb4ac-f175-916e-493f-e68d314241d1@oracle.com> Vote: yes Thanks, Jiangli > On 12/6/18 11:36 AM, Stuart Marks wrote: >> I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. >> >> Tagir has contributed 18 fixes to the JDK, including several notable >> API enhancements, mostly in Stream and Collections areas. His >> contributions are listed below. >> >> Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. >> >> Only current JDK Committers [1] are eligible to vote on this nomination. >> Votes must be cast in the open by replying to this mailing list. >> >> For Lazy Consensus voting instructions, see [2]. >> >> [1] - http://openjdk.java.net/census >> [2] - http://openjdk.java.net/projects/#committer-vote >> >> Thanks, >> >> s'marks >> >> ========== >> >> Tagir's JDK contributions: >> >> $ hg log --template "{node|short} {desc|firstline}\n" -r >> 'sort(user(tvaleev) or keyword(amaembo), -date)' >> >> de9486d74a74 8211693: Convert C-style array declarations in client >> demos and jdk.accessibility >> 2e330da7cbf4 8211300: Convert C-style array declarations in JDK >> client code >> 490d9001eba9 8205461: Create Collector which merges results of two >> other collectors >> 256109602af0 8164189: Collectors.toSet() parallel performance >> improvement >> d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to >> collect 128 elements even if limit is less >> 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics >> for boxed() and asLongStream() operations >> 6045bfdd65a5 8155600: Performance optimization of >> Arrays.asList().iterator() >> acc9c4072c89 8148748: ArrayList.subList().spliterator() is not >> late-binding >> c48e75478177 8151123: Collectors.summingDouble/averagingDouble >> unnecessarily call mapper twice >> 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow >> registering new handlers after stream is consumed >> de2976b3614c 8072727: add variation of Stream.iterate() that's finite >> 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot >> properly split after tryAdvance() >> f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization >> db033bd15d41 8148250: Stream.limit() parallel tasks with ordered >> non-SUBSIZED source should short-circuit >> 08655b6caa22 8146218: Add LocalDate.datesUntil method producing >> Stream> b721350c05c0 8145007: Pattern splitAsStream is not late binding as >> required by the specification >> c60dc808ff5a 8141630: Specification of Collections.synchronized* need >> to state traversal constraints >> 6e8998981fbd 8136686: Collectors.counting can use >> Collectors.summingLong to reduce boxing From stanislav.smirnov at oracle.com Fri Dec 7 22:14:46 2018 From: stanislav.smirnov at oracle.com (Stanislav Smirnov) Date: Fri, 7 Dec 2018 17:14:46 -0500 Subject: Submit repo status In-Reply-To: References: Message-ID: Hi Thomas, the current plan is to rest when we fork, we?ll skip the upcoming fork because we have already did the reset. Best regards, Stanislav Smirnov > On Dec 6, 2018, at 3:07 AM, Thomas St?fe wrote: > > Hi Stanislav, > > thanks for fixing this. I think resetting the repo makes sense. > > In which intervals will you be resetting it? > > Thanks, Thomas > > On Thu, Dec 6, 2018 at 1:15 AM Stanislav Smirnov > wrote: >> >> Hello, >> >> The submit repo was not working as expected last couple of days. >> The main reason is that the "hg pull" operation was not able to complete succesfully because of the number of heads in the repository. >> The submit repo hasn't been "cleaned" since it opened a year ago. >> There are currently 406 (closed + normal) branches in the repo and most of them are ?dead? (not active, but have not been closed). >> >> It was decided to start "resetting" the jdk/submit repository regularly. >> A new repository was created today >> >> http://hg.openjdk.java.net/jdk/submit/ >> >> With no branches except from the default one. >> In order to continue using the submit repo please make a fresh clone. >> >> Also an archive of the old jdk/submit was created >> >> http://hg.openjdk.java.net/jdk/submit-archive-2018-12-05/ >> >> Please continue using the system and report any issues/ask questions related to the submit repo using ops at openjdk.java.net. >> >> Best regards, >> Stanislav Smirnov From stanislav.smirnov at oracle.com Fri Dec 7 22:17:18 2018 From: stanislav.smirnov at oracle.com (Stanislav Smirnov) Date: Fri, 7 Dec 2018 17:17:18 -0500 Subject: Submit repo status In-Reply-To: <1e1832a2-ddfb-d223-7677-2887bd0e7e36@kennke.org> References: <1e1832a2-ddfb-d223-7677-2887bd0e7e36@kennke.org> Message-ID: Thank you for your suggestions! Talking about the branches, as always we ask users to be respectful and try not to forget to close them after they are no longer needed. From our side we will consider different options to make sure the repo is in a good shape. Best regards, Stanislav Smirnov > On Dec 6, 2018, at 7:48 AM, Roman Kennke wrote: > >>> The submit repo was not working as expected last couple of days. >>> The main reason is that the "hg pull" operation was not able to complete succesfully because of the number of heads in the repository. >>> The submit repo hasn't been "cleaned" since it opened a year ago. >>> There are currently 406 (closed + normal) branches in the repo and most of them are ?dead? (not active, but have not been closed). >>> >>> It was decided to start "resetting" the jdk/submit repository regularly. >> >> Another possibility would be to automatically close branches which >> match a JBS ID once the corresponding change has been pushed to >> jdk/jdk (the same way JBS issues get "Resloved" automatically once the >> corresponding change gets pushed). > > Yeah, *that* would seem most useful. I tried hard to exercise hygiene on > this, but it's easy to forget. A cron-job (or so) that queries all heads > and checks JBS ID, and closes branches for closed issues seems most > useful. Is that what is meant by resetting? I just hope it doesn't mean > we have to clone a fresh new jdk/submit every week/month or so.. > > Roman > > From aleksej.efimov at oracle.com Sat Dec 8 18:59:43 2018 From: aleksej.efimov at oracle.com (Aleks Efimov) Date: Sat, 8 Dec 2018 18:59:43 +0000 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <127698cd-14fc-6a09-ad66-70ceea70b5da@oracle.com> Vote: yes On 06/12/2018 19:36, Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > > Tagir has contributed 18 fixes to the JDK, including several notable > API enhancements, mostly in Stream and Collections areas. His > contributions are listed below. > > Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. > > Only current JDK Committers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > [1] - http://openjdk.java.net/census > [2] - http://openjdk.java.net/projects/#committer-vote > > Thanks, > > s'marks > > ========== > > Tagir's JDK contributions: > > $ hg log --template "{node|short} {desc|firstline}\n" -r > 'sort(user(tvaleev) or keyword(amaembo), -date)' > > de9486d74a74 8211693: Convert C-style array declarations in client > demos and jdk.accessibility > 2e330da7cbf4 8211300: Convert C-style array declarations in JDK client > code > 490d9001eba9 8205461: Create Collector which merges results of two > other collectors > 256109602af0 8164189: Collectors.toSet() parallel performance improvement > d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to > collect 128 elements even if limit is less > 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for > boxed() and asLongStream() operations > 6045bfdd65a5 8155600: Performance optimization of > Arrays.asList().iterator() > acc9c4072c89 8148748: ArrayList.subList().spliterator() is not > late-binding > c48e75478177 8151123: Collectors.summingDouble/averagingDouble > unnecessarily call mapper twice > 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow > registering new handlers after stream is consumed > de2976b3614c 8072727: add variation of Stream.iterate() that's finite > 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot > properly split after tryAdvance() > f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization > db033bd15d41 8148250: Stream.limit() parallel tasks with ordered > non-SUBSIZED source should short-circuit > 08655b6caa22 8146218: Add LocalDate.datesUntil method producing > Stream b721350c05c0 8145007: Pattern splitAsStream is not late binding as > required by the specification > c60dc808ff5a 8141630: Specification of Collections.synchronized* need > to state traversal constraints > 6e8998981fbd 8136686: Collectors.counting can use > Collectors.summingLong to reduce boxing From dmitry.markov at oracle.com Sat Dec 8 21:13:45 2018 From: dmitry.markov at oracle.com (Dmitry Markov) Date: Sat, 8 Dec 2018 21:13:45 +0000 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <80E7099C-706A-483C-8D02-966135382FAE@oracle.com> Vote: Yes Thanks, Dmitry > On 6 Dec 2018, at 19:36, Stuart Marks wrote: > > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > > Tagir has contributed 18 fixes to the JDK, including several notable API enhancements, mostly in Stream and Collections areas. His contributions are listed below. > > Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. > > Only current JDK Committers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > [1] - http://openjdk.java.net/census > [2] - http://openjdk.java.net/projects/#committer-vote > > Thanks, > > s'marks > > ========== > > Tagir's JDK contributions: > > $ hg log --template "{node|short} {desc|firstline}\n" -r 'sort(user(tvaleev) or keyword(amaembo), -date)' > > de9486d74a74 8211693: Convert C-style array declarations in client demos and jdk.accessibility > 2e330da7cbf4 8211300: Convert C-style array declarations in JDK client code > 490d9001eba9 8205461: Create Collector which merges results of two other collectors > 256109602af0 8164189: Collectors.toSet() parallel performance improvement > d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to collect 128 elements even if limit is less > 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for boxed() and asLongStream() operations > 6045bfdd65a5 8155600: Performance optimization of Arrays.asList().iterator() > acc9c4072c89 8148748: ArrayList.subList().spliterator() is not late-binding > c48e75478177 8151123: Collectors.summingDouble/averagingDouble unnecessarily call mapper twice > 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow registering new handlers after stream is consumed > de2976b3614c 8072727: add variation of Stream.iterate() that's finite > 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot properly split after tryAdvance() > f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization > db033bd15d41 8148250: Stream.limit() parallel tasks with ordered non-SUBSIZED source should short-circuit > 08655b6caa22 8146218: Add LocalDate.datesUntil method producing Stream b721350c05c0 8145007: Pattern splitAsStream is not late binding as required by the specification > c60dc808ff5a 8141630: Specification of Collections.synchronized* need to state traversal constraints > 6e8998981fbd 8136686: Collectors.counting can use Collectors.summingLong to reduce boxing From jay.a at outlook.in Mon Dec 10 05:24:15 2018 From: jay.a at outlook.in (Jayaprakash Artanareeswaran) Date: Mon, 10 Dec 2018 05:24:15 +0000 Subject: Changes to ct.sym in JDK 12 Message-ID: Hello experts, I see that the ct.sym has been restructured in JDK 12. Specifically, I am curious about the fact that even for non modular releases such as 7 and 8, I see the classes being placed inside their respective modules. Is it just about consistency? Are the modules always ignored or is there a scenario where the modular structure will be useful? Sorry if this was discussed already, but I couldn't find much about this particular change. Regards, Jay From jonathan.gibbons at oracle.com Mon Dec 10 05:41:09 2018 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Sun, 9 Dec 2018 21:41:09 -0800 Subject: Changes to ct.sym in JDK 12 In-Reply-To: References: Message-ID: Jay, This is better discussed on compiler-dev. It's about consistency, and better supporting the historical modular releases. -- Jon On 12/9/18 9:24 PM, Jayaprakash Artanareeswaran wrote: > Hello experts, > > I see that the ct.sym has been restructured in JDK 12. Specifically, I am curious about the fact that even for non modular releases such as 7 and 8, I see the classes being placed inside their respective modules. > > Is it just about consistency? Are the modules always ignored or is there a scenario where the modular structure will be useful? > > Sorry if this was discussed already, but I couldn't find much about this particular change. > > Regards, > Jay From volker.simonis at gmail.com Mon Dec 10 08:49:40 2018 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 10 Dec 2018 09:49:40 +0100 Subject: Submit repo status In-Reply-To: References: <1e1832a2-ddfb-d223-7677-2887bd0e7e36@kennke.org> Message-ID: The problem you'll run into when you create new clones from time to time is that a single push from somebody who didn't realize that you have created a new clone (and didn't recreate its local version of submit) can unintentionally push ALL the old branches from his local clone when he only wants to push his single, new branch. I actually wonder that this hasn't happened already ... On Fri, Dec 7, 2018 at 11:17 PM Stanislav Smirnov wrote: > > Thank you for your suggestions! > > Talking about the branches, as always we ask users to be respectful and try not to forget to close them after they are no longer needed. > From our side we will consider different options to make sure the repo is in a good shape. > > Best regards, > Stanislav Smirnov > > On Dec 6, 2018, at 7:48 AM, Roman Kennke wrote: > > The submit repo was not working as expected last couple of days. > The main reason is that the "hg pull" operation was not able to complete succesfully because of the number of heads in the repository. > The submit repo hasn't been "cleaned" since it opened a year ago. > There are currently 406 (closed + normal) branches in the repo and most of them are ?dead? (not active, but have not been closed). > > It was decided to start "resetting" the jdk/submit repository regularly. > > > Another possibility would be to automatically close branches which > match a JBS ID once the corresponding change has been pushed to > jdk/jdk (the same way JBS issues get "Resloved" automatically once the > corresponding change gets pushed). > > > Yeah, *that* would seem most useful. I tried hard to exercise hygiene on > this, but it's easy to forget. A cron-job (or so) that queries all heads > and checks JBS ID, and closes branches for closed issues seems most > useful. Is that what is meant by resetting? I just hope it doesn't mean > we have to clone a fresh new jdk/submit every week/month or so.. > > Roman > > > From alexey.ivanov at oracle.com Mon Dec 10 10:16:49 2018 From: alexey.ivanov at oracle.com (Alexey Ivanov) Date: Mon, 10 Dec 2018 10:16:49 +0000 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <4419f945-9b97-c6b8-8090-53f28f24b0ff@oracle.com> Vote: yes Regards, Alexey On 06/12/2018 19:36, Stuart Marks wrote: > I hereby nominate Tagir Valeev (tvaleev) to JDK Committer. > > Tagir has contributed 18 fixes to the JDK, including several notable > API enhancements, mostly in Stream and Collections areas. His > contributions are listed below. > > Votes are due before 17:00 PST (GMT-0800) on 2018-12-20. > > Only current JDK Committers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > [1] - http://openjdk.java.net/census > [2] - http://openjdk.java.net/projects/#committer-vote > > Thanks, > > s'marks > > ========== > > Tagir's JDK contributions: > > $ hg log --template "{node|short} {desc|firstline}\n" -r > 'sort(user(tvaleev) or keyword(amaembo), -date)' > > de9486d74a74 8211693: Convert C-style array declarations in client > demos and jdk.accessibility > 2e330da7cbf4 8211300: Convert C-style array declarations in JDK client > code > 490d9001eba9 8205461: Create Collector which merges results of two > other collectors > 256109602af0 8164189: Collectors.toSet() parallel performance improvement > d8cbae550f3b 8154387: Parallel unordered Stream.limit() tries to > collect 128 elements even if limit is less > 1258d14cf2cc 8153293: Preserve SORTED and DISTINCT characteristics for > boxed() and asLongStream() operations > 6045bfdd65a5 8155600: Performance optimization of > Arrays.asList().iterator() > acc9c4072c89 8148748: ArrayList.subList().spliterator() is not > late-binding > c48e75478177 8151123: Collectors.summingDouble/averagingDouble > unnecessarily call mapper twice > 6a0a5bdfe79f 8147505: BaseStream.onClose() should not allow > registering new handlers after stream is consumed > de2976b3614c 8072727: add variation of Stream.iterate() that's finite > 05eadb5e7022 8148838: Stream.flatMap(...).spliterator() cannot > properly split after tryAdvance() > f61cb8475e5a 8148115: Stream.findFirst for unordered source optimization > db033bd15d41 8148250: Stream.limit() parallel tasks with ordered > non-SUBSIZED source should short-circuit > 08655b6caa22 8146218: Add LocalDate.datesUntil method producing > Stream b721350c05c0 8145007: Pattern splitAsStream is not late binding as > required by the specification > c60dc808ff5a 8141630: Specification of Collections.synchronized* need > to state traversal constraints > 6e8998981fbd 8136686: Collectors.counting can use > Collectors.summingLong to reduce boxing From karen.kinnear at oracle.com Mon Dec 10 15:54:34 2018 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Mon, 10 Dec 2018 10:54:34 -0500 Subject: review comments for JEP 12: Preview Language and VM Features JDK-8195734 Message-ID: 1. As discussed in https://bugs.openjdk.java.net/browse/JDK-8198908 the following paragraph is not-implementable: If a class file's use of a preview VM feature of Java SE $N causes an exception during loading, linking, or execution, then the JVM implementation must indicate that the exception is due to an preview VM feature of Java SE $N. As discussed in the bug, we have added off-by-default logging when loading a class that supports a preview version. I don?t believe we want to mandate the details of diagnostic information. In particular, the JVM does not have always have the information to detect that the root cause of an exception lies in using a preview VM feature. So I would recommend removing this. 2. Relationship to Java SE APIs 2nd paragraph: A preview language or VM feature must not rely on an incubating API, since the API is not part of the Java SE Platform. 4th paragraph: The implementation of a preview language or VM feature may rely on incubating APIs. (and similarly 5th paragraph). Unless I misread this, this is inconsistent, unless there is a subtle distinction between the feature and a specific implementation. thanks, Karen From eric.caspole at oracle.com Mon Dec 10 18:18:57 2018 From: eric.caspole at oracle.com (Eric Caspole) Date: Mon, 10 Dec 2018 13:18:57 -0500 Subject: RFR(S): 8215140: Port missing crypto JMH micros from jmh-jdk-microbenchmarks Message-ID: <13920cbb-84a8-4c1a-d84c-08e5561be861@oracle.com> Hi everyone, Could I have reviews on this webrev to bring more crypto micros from the OpenJDK jmh-jdk-microbenchmarks project? It was just a glitch that they were not included in the original micros commit. Thanks, Eric webrev: http://cr.openjdk.java.net/~ecaspole/JDK-8215140/webrev/ JBS: https://bugs.openjdk.java.net/browse/JDK-8215140 From claes.redestad at oracle.com Mon Dec 10 18:32:57 2018 From: claes.redestad at oracle.com (Claes Redestad) Date: Mon, 10 Dec 2018 19:32:57 +0100 Subject: RFR(S): 8215140: Port missing crypto JMH micros from jmh-jdk-microbenchmarks In-Reply-To: <13920cbb-84a8-4c1a-d84c-08e5561be861@oracle.com> References: <13920cbb-84a8-4c1a-d84c-08e5561be861@oracle.com> Message-ID: <447897f1-d50d-530d-fc96-fda1e48649dc@oracle.com> Hi Eric, looks good to me! /Claes On 2018-12-10 19:18, Eric Caspole wrote: > Hi everyone, > Could I have reviews on this webrev to bring more crypto micros from the > OpenJDK jmh-jdk-microbenchmarks project? It was just a glitch that they > were not included in the original micros commit. > Thanks, > Eric > > > webrev: > http://cr.openjdk.java.net/~ecaspole/JDK-8215140/webrev/ > > JBS: > https://bugs.openjdk.java.net/browse/JDK-8215140 From eric.caspole at oracle.com Mon Dec 10 19:09:09 2018 From: eric.caspole at oracle.com (Eric Caspole) Date: Mon, 10 Dec 2018 14:09:09 -0500 Subject: RFR(S): 8215140: Port missing crypto JMH micros from jmh-jdk-microbenchmarks In-Reply-To: <447897f1-d50d-530d-fc96-fda1e48649dc@oracle.com> References: <13920cbb-84a8-4c1a-d84c-08e5561be861@oracle.com> <447897f1-d50d-530d-fc96-fda1e48649dc@oracle.com> Message-ID: Thanks Claes! On 12/10/18 13:32, Claes Redestad wrote: > Hi Eric, > > looks good to me! > > /Claes > > On 2018-12-10 19:18, Eric Caspole wrote: >> Hi everyone, >> Could I have reviews on this webrev to bring more crypto micros from >> the OpenJDK jmh-jdk-microbenchmarks project? It was just a glitch that >> they were not included in the original micros commit. >> Thanks, >> Eric >> >> >> webrev: >> http://cr.openjdk.java.net/~ecaspole/JDK-8215140/webrev/ >> >> JBS: >> https://bugs.openjdk.java.net/browse/JDK-8215140 From alex.buckley at oracle.com Mon Dec 10 20:00:51 2018 From: alex.buckley at oracle.com (Alex Buckley) Date: Mon, 10 Dec 2018 12:00:51 -0800 Subject: review comments for JEP 12: Preview Language and VM Features JDK-8195734 In-Reply-To: References: Message-ID: <5C0EC5F3.2020407@oracle.com> On 12/10/2018 7:54 AM, Karen Kinnear wrote: > 1. As discussed in https://bugs.openjdk.java.net/browse/JDK-8198908 > the following > paragraph is not-implementable: "If a class file's use of a preview VM > feature of Java SE $N causes an exception during loading, linking, or > execution, then the JVM implementation must indicate that the > exception is due to an preview VM feature of Java SE $N." > > As discussed in the bug, we have added off-by-default logging when > loading a class that supports a preview version. I don?t believe we > want to mandate the details of diagnostic information. In particular, > the JVM does not have always have the information to detect that the > root cause of an exception lies in using a preview VM feature. So I > would recommend removing this. Fair comment. The paragraph quoted above was intended to align with this earlier paragraph in JEP 12: "If a compile-time error occurs due to the incorrect use of a preview language feature of Java SE $N, then javac may indicate that the error is associated specifically with a preview language feature." The intent was to be noisy anywhere and everywhere that a preview feature was used or misused. That said, if javac gets a "may indicate", then HotSpot should not get a "must indicate". For consistency, and to clarify that an implementation is welcome to provide preview-related diagnostics, I will say: "If a class file's use of a preview VM feature of Java SE $N causes an exception during loading, linking, or execution, then the JVM implementation ***may*** indicate that the exception is due to an preview VM feature of Java SE $N." Few things: 1. I see in JDK-8198908 that `-Xlog:class+preview` is supported so I will add the following: "The JVM implementation in JDK $N has an off-by-default ability to show which loaded classes depend on the preview features of Java SE $N. To enable the ability, pass `-Xlog:class+preview` to the `java` launcher." 2. Is the [class,preview] output predicated on --enable-preview being given in addition to -Xlog:class+preview ? 3. The wording of the logging output is "Loading preview feature type $NAME". That sounds like the type is part of the preview feature, i.e., involved in supporting the preview feature, e.g., the java.lang.AutoCloseable type if the try-with-resources statement had been a preview feature. The word "type" also seems unusually abstract for logging output. Recommend "Loading class file that depends on preview features: $NAME", or, if it's redundant to say "Loading class file" in a log about class loading, then "$NAME depends on preview features of Java SE $RELEASE_THAT_CORRESPONDS_TO_MAJOR_VERSION" > 2. Relationship to Java SE APIs 2nd paragraph: A preview language or > VM feature must not rely on an incubating API, since the API is not > part of the Java SE Platform. > > 4th paragraph: The implementation of a preview language or VM feature > may rely on incubating APIs. (and similarly 5th paragraph). > > Unless I misread this, this is inconsistent, unless there is a subtle > distinction between the feature and a specific implementation. This is in "Relationship to Incubating APIs", not "Relationship to Java SE APIs". The intent was to distinguish the design of a preview feature from its implementation. Most times when the JEP speaks of a preview feature, it means the design. That said, the JEP is usefully careful to say "Java compiler" or "JVM implementation" when speaking of the implementation, and I will clarify the fourth paragraph to be careful. Alex From karen.kinnear at oracle.com Mon Dec 10 20:22:03 2018 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Mon, 10 Dec 2018 15:22:03 -0500 Subject: review comments for JEP 12: Preview Language and VM Features JDK-8195734 In-Reply-To: <5C0EC5F3.2020407@oracle.com> References: <5C0EC5F3.2020407@oracle.com> Message-ID: > On Dec 10, 2018, at 3:00 PM, Alex Buckley wrote: > > On 12/10/2018 7:54 AM, Karen Kinnear wrote: >> 1. As discussed in https://bugs.openjdk.java.net/browse/JDK-8198908 >> the following >> paragraph is not-implementable: "If a class file's use of a preview VM >> feature of Java SE $N causes an exception during loading, linking, or >> execution, then the JVM implementation must indicate that the >> exception is due to an preview VM feature of Java SE $N." >> >> As discussed in the bug, we have added off-by-default logging when >> loading a class that supports a preview version. I don?t believe we >> want to mandate the details of diagnostic information. In particular, >> the JVM does not have always have the information to detect that the >> root cause of an exception lies in using a preview VM feature. So I >> would recommend removing this. > > Fair comment. The paragraph quoted above was intended to align with this earlier paragraph in JEP 12: > > "If a compile-time error occurs due to the incorrect use of a preview language feature of Java SE $N, then javac may indicate that the error is associated specifically with a preview language feature." > > The intent was to be noisy anywhere and everywhere that a preview feature was used or misused. That said, if javac gets a "may indicate", then HotSpot should not get a "must indicate". For consistency, and to clarify that an implementation is welcome to provide preview-related diagnostics, I will say: > > "If a class file's use of a preview VM feature of Java SE $N causes an exception during loading, linking, or execution, then the JVM implementation ***may*** indicate that the exception is due to an preview VM feature of Java SE $N.? Thank you. > > Few things: > > 1. I see in JDK-8198908 that `-Xlog:class+preview` is supported so I will add the following: > > "The JVM implementation in JDK $N has an off-by-default ability to show which loaded classes depend on the preview features of Java SE $N. To enable the ability, pass `-Xlog:class+preview` to the `java` launcher.? Your call what you want in the JEP. A note - this is hotspot-specific JVM flag, not a launcher flag, so other implementations are unlikely to choose this approach. > > 2. Is the [class,preview] output predicated on --enable-preview being given in addition to -Xlog:class+preview ? Yes. Otherwise the class would fail to load and you would get an UnsupportedClassVersionError and in hotspot an error message mentioned Preview features are not enabled, ... > > 3. The wording of the logging output is "Loading preview feature type $NAME". That sounds like the type is part of the preview feature, i.e., involved in supporting the preview feature, e.g., the java.lang.AutoCloseable type if the try-with-resources statement had been a preview feature. The word "type" also seems unusually abstract for logging output. Recommend "Loading class file that depends on preview features: $NAME", or, if it's redundant to say "Loading class file" in a log about class loading, then "$NAME depends on preview features of Java SE $RELEASE_THAT_CORRESPONDS_TO_MAJOR_VERSION? Agree with the need for improvement - Harold will respond with a specific textual proposal. You do not always have a context of already knowing you are loading a class file. > >> 2. Relationship to Java SE APIs 2nd paragraph: A preview language or >> VM feature must not rely on an incubating API, since the API is not >> part of the Java SE Platform. >> >> 4th paragraph: The implementation of a preview language or VM feature >> may rely on incubating APIs. (and similarly 5th paragraph). >> >> Unless I misread this, this is inconsistent, unless there is a subtle >> distinction between the feature and a specific implementation. > > This is in "Relationship to Incubating APIs", not "Relationship to Java SE APIs". The intent was to distinguish the design of a preview feature from its implementation. Most times when the JEP speaks of a preview feature, it means the design. That said, the JEP is usefully careful to say "Java compiler" or "JVM implementation" when speaking of the implementation, and I will clarify the fourth paragraph to be careful. Thank you both for the correction to my note and the clarification. That is a valuable distinction. thanks, Karen > > Alex From harold.seigel at oracle.com Mon Dec 10 20:26:19 2018 From: harold.seigel at oracle.com (Harold David Seigel) Date: Mon, 10 Dec 2018 15:26:19 -0500 Subject: review comments for JEP 12: Preview Language and VM Features JDK-8195734 In-Reply-To: <5C0EC5F3.2020407@oracle.com> References: <5C0EC5F3.2020407@oracle.com> Message-ID: <658b8701-2ee2-ecbc-a065-240c72d55063@oracle.com> Hi Alex, On 12/10/2018 3:00 PM, Alex Buckley wrote: > 3. The wording of the logging output is "Loading preview feature type > $NAME". That sounds like the type is part of the preview feature, > i.e., involved in supporting the preview feature, e.g., the > java.lang.AutoCloseable type if the try-with-resources statement had > been a preview feature. The word "type" also seems unusually abstract > for logging output. Recommend "Loading class file that depends on > preview features: $NAME", or, if it's redundant to say "Loading class > file" in a log about class loading, then "$NAME depends on preview > features of Java SE $RELEASE_THAT_CORRESPONDS_TO_MAJOR_VERSION" We don't know if the class file actually depends on the preview features, just that it was compiled with 65535.? So, how about: "Loading class file that is enabled for preview features: $NAME" ? Thanks, Harold From alex.buckley at oracle.com Mon Dec 10 20:41:44 2018 From: alex.buckley at oracle.com (Alex Buckley) Date: Mon, 10 Dec 2018 12:41:44 -0800 Subject: review comments for JEP 12: Preview Language and VM Features JDK-8195734 In-Reply-To: <658b8701-2ee2-ecbc-a065-240c72d55063@oracle.com> References: <5C0EC5F3.2020407@oracle.com> <658b8701-2ee2-ecbc-a065-240c72d55063@oracle.com> Message-ID: <5C0ECF88.2060401@oracle.com> On 12/10/2018 12:26 PM, Harold David Seigel wrote: > On 12/10/2018 3:00 PM, Alex Buckley wrote: >> 3. The wording of the logging output is "Loading preview feature type >> $NAME". That sounds like the type is part of the preview feature, >> i.e., involved in supporting the preview feature, e.g., the >> java.lang.AutoCloseable type if the try-with-resources statement had >> been a preview feature. The word "type" also seems unusually abstract >> for logging output. Recommend "Loading class file that depends on >> preview features: $NAME", or, if it's redundant to say "Loading class >> file" in a log about class loading, then "$NAME depends on preview >> features of Java SE $RELEASE_THAT_CORRESPONDS_TO_MAJOR_VERSION" > > We don't know if the class file actually depends on the preview > features, just that it was compiled with 65535. So, how about: > > "Loading class file that is enabled for preview features: $NAME" ? Per JEP 12, "A class file denotes that it depends on the preview VM features of Java SE $N by having a major_version item that corresponds to Java SE $N and a minor_version item that has all 16 bits set." What's actually in the code array is immaterial. We already speak of enabling preview features in the Java compiler / JVM implementation, so it would be confusing to have an individual class file that "enabled" anything. (Would the file auto-enable the preview features of the compiler/runtime even if --enable-preview hadn't been passed?) That said, it would be useful to draw attention to the class file version: "Class $NAME depends on preview features (class file version $MAJOR_VERSION.65535)" Alex From harold.seigel at oracle.com Mon Dec 10 21:05:52 2018 From: harold.seigel at oracle.com (Harold David Seigel) Date: Mon, 10 Dec 2018 16:05:52 -0500 Subject: review comments for JEP 12: Preview Language and VM Features JDK-8195734 In-Reply-To: <5C0ECF88.2060401@oracle.com> References: <5C0EC5F3.2020407@oracle.com> <658b8701-2ee2-ecbc-a065-240c72d55063@oracle.com> <5C0ECF88.2060401@oracle.com> Message-ID: <30b2e922-9802-dba5-534d-7b337f1dc35d@oracle.com> Thanks Alex. I decided to go with: "Loading class %s that depends on preview features (class file version %d.65535)" Harold On 12/10/2018 3:41 PM, Alex Buckley wrote: > On 12/10/2018 12:26 PM, Harold David Seigel wrote: >> On 12/10/2018 3:00 PM, Alex Buckley wrote: >>> 3. The wording of the logging output is "Loading preview feature type >>> $NAME". That sounds like the type is part of the preview feature, >>> i.e., involved in supporting the preview feature, e.g., the >>> java.lang.AutoCloseable type if the try-with-resources statement had >>> been a preview feature. The word "type" also seems unusually abstract >>> for logging output. Recommend "Loading class file that depends on >>> preview features: $NAME", or, if it's redundant to say "Loading class >>> file" in a log about class loading, then "$NAME depends on preview >>> features of Java SE $RELEASE_THAT_CORRESPONDS_TO_MAJOR_VERSION" >> >> We don't know if the class file actually depends on the preview >> features, just that it was compiled with 65535.? So, how about: >> >> ??? "Loading class file that is enabled for preview features: $NAME" ? > > Per JEP 12, "A class file denotes that it depends on the preview VM > features of Java SE $N by having a major_version item that corresponds > to Java SE $N and a minor_version item that has all 16 bits set." > What's actually in the code array is immaterial. > > We already speak of enabling preview features in the Java compiler / > JVM implementation, so it would be confusing to have an individual > class file that "enabled" anything. (Would the file auto-enable the > preview features of the compiler/runtime even if --enable-preview > hadn't been passed?) > > That said, it would be useful to draw attention to the class file > version: "Class $NAME depends on preview features (class file version > $MAJOR_VERSION.65535)" > > Alex From alex.buckley at oracle.com Mon Dec 10 21:25:14 2018 From: alex.buckley at oracle.com (Alex Buckley) Date: Mon, 10 Dec 2018 13:25:14 -0800 Subject: review comments for JEP 12: Preview Language and VM Features JDK-8195734 In-Reply-To: <30b2e922-9802-dba5-534d-7b337f1dc35d@oracle.com> References: <5C0EC5F3.2020407@oracle.com> <658b8701-2ee2-ecbc-a065-240c72d55063@oracle.com> <5C0ECF88.2060401@oracle.com> <30b2e922-9802-dba5-534d-7b337f1dc35d@oracle.com> Message-ID: <5C0ED9BA.8030104@oracle.com> Looks good. On 12/10/2018 1:05 PM, Harold David Seigel wrote: > Thanks Alex. > > I decided to go with: > > "Loading class %s that depends on preview features (class file > version %d.65535)" > > Harold From karen.kinnear at oracle.com Mon Dec 10 21:30:06 2018 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Mon, 10 Dec 2018 16:30:06 -0500 Subject: review comments for JEP 12: Preview Language and VM Features JDK-8195734 In-Reply-To: <5C0ED9BA.8030104@oracle.com> References: <5C0EC5F3.2020407@oracle.com> <658b8701-2ee2-ecbc-a065-240c72d55063@oracle.com> <5C0ECF88.2060401@oracle.com> <30b2e922-9802-dba5-534d-7b337f1dc35d@oracle.com> <5C0ED9BA.8030104@oracle.com> Message-ID: <6D6FBB96-8178-4152-8C65-9FF9DBF15BCA@oracle.com> Thank you both. This is clearer. thanks, Karen > On Dec 10, 2018, at 4:25 PM, Alex Buckley wrote: > > Looks good. > > On 12/10/2018 1:05 PM, Harold David Seigel wrote: >> Thanks Alex. >> >> I decided to go with: >> >> "Loading class %s that depends on preview features (class file >> version %d.65535)" >> >> Harold From serguei.spitsyn at oracle.com Mon Dec 10 22:37:48 2018 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 10 Dec 2018 14:37:48 -0800 Subject: CFV: New JDK Committer: Tagir Valeev In-Reply-To: References: Message-ID: <7046f93a-9179-2ef5-0b06-602bb850d02a@oracle.com> Vote: yes From serguei.spitsyn at oracle.com Mon Dec 10 22:38:24 2018 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 10 Dec 2018 14:38:24 -0800 Subject: CFV: New JDK Committer: Abdul Muneer Kolarkunnu In-Reply-To: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> References: <159FA002-571E-4DE2-9E69-0FA0890F1403@oracle.com> Message-ID: <17732e8d-e2cc-d221-8ff2-ca45cee66674@oracle.com> Vote: yes From serguei.spitsyn at oracle.com Mon Dec 10 22:37:25 2018 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 10 Dec 2018 14:37:25 -0800 Subject: CFV: New JDK Committer: Chris Yin In-Reply-To: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> References: <5ab930d0-ffed-3577-59b1-00fbedd86fd1@oracle.com> Message-ID: Vote: yes From shade at redhat.com Tue Dec 11 13:05:34 2018 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 11 Dec 2018 14:05:34 +0100 Subject: Submit repo status In-Reply-To: References: <1e1832a2-ddfb-d223-7677-2887bd0e7e36@kennke.org> Message-ID: <5067e934-02df-b016-d6f7-19d2e69d3c89@redhat.com> On 12/10/18 9:49 AM, Volker Simonis wrote: > The problem you'll run into when you create new clones from time to > time is that a single push from somebody who didn't realize that you > have created a new clone (and didn't recreate its local version of > submit) can unintentionally push ALL the old branches from his local > clone when he only wants to push his single, new > branch. I actually wonder that this hasn't happened already ... +1. I was staring blankly at my current "hg out" for jdk-submit trying to understand why does it want to push thousands of changesets out. Only to realize something is "wrong" with the remote repository. Then I discovered this thread. I could have easily not check it and push. I have three suggestions for the future: a) Please say "jdk-submit is reset, please re-clone" as the message synopsis, not the innocuous "Submit repo status" -- this important message was easy to miss; b) Test if pushing old changesets accidentally is caught by some checker. I wonder if current single-branch checkers would still allow to push all old changesets; c) Support clonebundles [1]! It took me five (!) re-tries to clone new jdk-submit for my workspace cache [2]. It would be very unfortunate to go through this exercise regularly. Thanks, -Aleksey [1] https://bugs.openjdk.java.net/browse/JDK-8211383 [2] https://builds.shipilev.net/workspaces/ From mark.reinhold at oracle.com Tue Dec 11 17:13:23 2018 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Tue, 11 Dec 2018 09:13:23 -0800 Subject: JEP proposed to drop from JDK 12: 326: Raw String Literals (Preview) Message-ID: <20181211091323.596696203@eggemoggin.niobe.net> The owner of this JEP has proposed to drop it from JDK 12: 326: Raw String Literals (Preview) http://openjdk.java.net/jeps/326 The rationale for this proposal will follow in a moment. Feedback on this proposal from JDK Project Committers and Reviewers [1] is more than welcome, as are reasoned objections. If no such objections are raised by 23:00 UTC on Tuesday, 18 December, or if they?re raised and then satisfactorily answered, then per the JEP 2.0 process proposal [2] I?ll drop this JEP from JDK 12. - Mark [1] https://openjdk.java.net/census#jdk [2] https://cr.openjdk.java.net/~mr/jep/jep-2.0-02.html From brian.goetz at oracle.com Tue Dec 11 17:20:38 2018 From: brian.goetz at oracle.com (Brian Goetz) Date: Tue, 11 Dec 2018 12:20:38 -0500 Subject: JEP proposed to drop from JDK 12: 326: Raw String Literals (Preview) In-Reply-To: <20181211091323.596696203@eggemoggin.niobe.net> References: <20181211091323.596696203@eggemoggin.niobe.net> Message-ID: Some background rationale on this. The Preview Feature mechanism is intended for features for which there is a high confidence that the feature is "done", and the likelihood that significant changes would be made before making the feature permanent is low.? At this time, and after extensive consideration, Jim and I no longer believe this to be the case, and we think letting it preview in its current state would be to the detriment of the language.? We're of course disappointed that this means it will take slightly longer for this feature to make it into the language, but we think that's the best choice. While we can expect that for any language feature, there will be a nontrivial volume of "I would have preferred it differently" feedback, in reviewing the feedback we have received, I am no longer convinced that we've yet got to the right set of tradeoffs between complexity and expressiveness, or that we've explored enough of the design space to be confident that the current design is the best we can do.? By withdrawing, we can continue to refine the design, explore more options, and aim for a preview that actually meets the requirements of the Preview Feature process (JEP 12). For the record, here is some of the feedback we've received on the design.? These are incomplete and in no particular order (and some of them are likely not fixable but may be worth exploring further anyway). ?- The two-backquote sequence `` could be confused for an empty string, but in fact is an opening delimiter. ?- There is no directway to start or end a raw string literal with a backquote. ?- Raw string literals can be multi-line, but traditional string literals cannot. (Alternately, multi-line string literals MUST also be raw, which isn't always what the user wants.) This is an unnecessary asymmetry, given that these properties are logically independent, and such asymmetries generally increase the cognitive load on the user. ?- We have relatively few unused punctuation characters left, and using backquote for RSLs may be excessively profligate.? Further, using another quote character for raw string literals (rather than a prefix, modifier, embedded sequence, or similar mechanism) leaves us in a tight spot if we discover the need for a third kind of string literal.? We've not sufficiently explored alternatives that would let us avoid burning one of the few remaining characters we have. ?- The backquote character is somewhat typographically lightweight; it is easy to miss, and could therefore cause confusion over where a large string ends and the containing code resumes. ?- The "any number of quotes" rule can confuse IDEs over whether a sequence of quotes is open-contents-close, or a large opening delimiter, limiting their ability to help by filling in closing delimiters and placing the caret in the right place.? We want Java to remain one of the most tool-friendly languages. ?- While it's cool that we can embed a seventeen-quote run in an eighteen-quoted string, such strings can also get pretty hard to read. We think we can do better on some or many of these fronts.? One of the benefits of the newer more rapid cadence is that the cost of missing a train (even one that you have already boarded, but which has not yet left the station) is much lower.? And, assuming that it is unlikely that we'd exit Preview unchanged, withdrawing now does not change the likely date at which this feature becomes permanent, as we'd likely want to re-Preview a modified version anyway. Discussion on the technical details of this feature can continue to take place on the amber-* lists. On 12/11/2018 12:13 PM, mark.reinhold at oracle.com wrote: > The owner of this JEP has proposed to drop it from JDK 12: > > 326: Raw String Literals (Preview) > http://openjdk.java.net/jeps/326 > > The rationale for this proposal will follow in a moment. > > Feedback on this proposal from JDK Project Committers and Reviewers [1] > is more than welcome, as are reasoned objections. If no such objections > are raised by 23:00 UTC on Tuesday, 18 December, or if they?re raised > and then satisfactorily answered, then per the JEP 2.0 process proposal > [2] I?ll drop this JEP from JDK 12. > > - Mark > > > [1] https://openjdk.java.net/census#jdk > [2] https://cr.openjdk.java.net/~mr/jep/jep-2.0-02.html From scolebourne at joda.org Tue Dec 11 20:00:07 2018 From: scolebourne at joda.org (Stephen Colebourne) Date: Tue, 11 Dec 2018 20:00:07 +0000 Subject: JEP proposed to drop from JDK 12: 326: Raw String Literals (Preview) In-Reply-To: References: <20181211091323.596696203@eggemoggin.niobe.net> Message-ID: Thank you for reconsidering. I strongly support the delay. Stephen On Tue, 11 Dec 2018 at 17:21, Brian Goetz wrote: > Some background rationale on this. > > The Preview Feature mechanism is intended for features for which there > is a high confidence that the feature is "done", and the likelihood that > significant changes would be made before making the feature permanent is > low. At this time, and after extensive consideration, Jim and I no > longer believe this to be the case, and we think letting it preview in > its current state would be to the detriment of the language. We're of > course disappointed that this means it will take slightly longer for > this feature to make it into the language, but we think that's the best > choice. > > While we can expect that for any language feature, there will be a > nontrivial volume of "I would have preferred it differently" feedback, > in reviewing the feedback we have received, I am no longer convinced > that we've yet got to the right set of tradeoffs between complexity and > expressiveness, or that we've explored enough of the design space to be > confident that the current design is the best we can do. By > withdrawing, we can continue to refine the design, explore more options, > and aim for a preview that actually meets the requirements of the > Preview Feature process (JEP 12). > > For the record, here is some of the feedback we've received on the > design. These are incomplete and in no particular order (and some of > them are likely not fixable but may be worth exploring further anyway). > > - The two-backquote sequence `` could be confused for an empty string, > but in fact is an opening delimiter. > > - There is no directway to start or end a raw string literal with a > backquote. > > - Raw string literals can be multi-line, but traditional string > literals cannot. (Alternately, multi-line string literals MUST also be > raw, which isn't always what the user wants.) This is an unnecessary > asymmetry, given that these properties are logically independent, and > such asymmetries generally increase the cognitive load on the user. > > - We have relatively few unused punctuation characters left, and using > backquote for RSLs may be excessively profligate. Further, using > another quote character for raw string literals (rather than a prefix, > modifier, embedded sequence, or similar mechanism) leaves us in a tight > spot if we discover the need for a third kind of string literal. We've > not sufficiently explored alternatives that would let us avoid burning > one of the few remaining characters we have. > > - The backquote character is somewhat typographically lightweight; it > is easy to miss, and could therefore cause confusion over where a large > string ends and the containing code resumes. > > - The "any number of quotes" rule can confuse IDEs over whether a > sequence of quotes is open-contents-close, or a large opening delimiter, > limiting their ability to help by filling in closing delimiters and > placing the caret in the right place. We want Java to remain one of the > most tool-friendly languages. > > - While it's cool that we can embed a seventeen-quote run in an > eighteen-quoted string, such strings can also get pretty hard to read. > > > We think we can do better on some or many of these fronts. One of the > benefits of the newer more rapid cadence is that the cost of missing a > train (even one that you have already boarded, but which has not yet > left the station) is much lower. And, assuming that it is unlikely that > we'd exit Preview unchanged, withdrawing now does not change the likely > date at which this feature becomes permanent, as we'd likely want to > re-Preview a modified version anyway. > > > Discussion on the technical details of this feature can continue to take > place on the amber-* lists. > > > > > > On 12/11/2018 12:13 PM, mark.reinhold at oracle.com wrote: > > The owner of this JEP has proposed to drop it from JDK 12: > > > > 326: Raw String Literals (Preview) > > http://openjdk.java.net/jeps/326 > > > > The rationale for this proposal will follow in a moment. > > > > Feedback on this proposal from JDK Project Committers and Reviewers [1] > > is more than welcome, as are reasoned objections. If no such objections > > are raised by 23:00 UTC on Tuesday, 18 December, or if they?re raised > > and then satisfactorily answered, then per the JEP 2.0 process proposal > > [2] I?ll drop this JEP from JDK 12. > > > > - Mark > > > > > > [1] https://openjdk.java.net/census#jdk > > [2] https://cr.openjdk.java.net/~mr/jep/jep-2.0-02.html > > From stanislav.smirnov at oracle.com Thu Dec 13 16:15:22 2018 From: stanislav.smirnov at oracle.com (Stanislav Smirnov) Date: Thu, 13 Dec 2018 11:15:22 -0500 Subject: jdk-submit is reset, please re-clone and "hg out" before push Message-ID: <610C771B-5814-4E92-ABD3-0A13BA3089D6@oracle.com> Hello, yesterday, as some of you predicted, all the old branches were unintentionally pushed from a local clone. Mistakes in this area affect everyone, unfortunately. Please be careful and pay attention. It did not break the system, but to play safe the jdk-submit repository was reset. With no branches except from the default one. http://hg.openjdk.java.net/jdk/submit/ In order to continue using the submit repo please make a fresh clone and run ?hg out? before pushing to the origin. Also an archive of the old jdk/submit was created http://hg.openjdk.java.net/jdk/submit-archive-2018-12-12 Best regards, Stanislav Smirnov From mark.reinhold at oracle.com Thu Dec 13 17:58:06 2018 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Thu, 13 Dec 2018 09:58:06 -0800 (PST) Subject: JDK 12 is now in Rampdown Phase One Message-ID: <20181213175806.6F742233469@eggemoggin.niobe.net> Per the JDK 12 schedule [1], we are now in Rampdown Phase One. The overall feature set is frozen. No further JEPs will be targeted to this release. We?ve forked the main-line source repository, jdk/jdk, to the jdk/jdk12 stabilization repository. Any changes pushed to jdk/jdk or jdk/client are now bound for JDK 13, as noted previously [2]. The stabilization repository is open for select bug fixes and, with approval, late enhancements per JEP 3, the JDK Release Process [3]. If you?re responsible for any of the bugs on the RDP 1 candidate-bug list [3] then please see JEP 3 for guidance on how to handle them. - Mark [1] http://openjdk.java.net/projects/jdk/12/#Schedule [2] https://mail.openjdk.java.net/pipermail/jdk-dev/2018-December/002376.html [3] http://openjdk.java.net/jeps/3 [4] http://j.mp/jdk-rdp-1 From vladimir.kozlov at oracle.com Thu Dec 13 19:02:16 2018 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Thu, 13 Dec 2018 11:02:16 -0800 Subject: JDK 12 is now in Rampdown Phase One In-Reply-To: <20181213175806.6F742233469@eggemoggin.niobe.net> References: <20181213175806.6F742233469@eggemoggin.niobe.net> Message-ID: Hi Mark, JBS bugs filters on release page [3] use fix version 11 instead of 12. As result lists are not complete. The same issue for RDP 1 candidate bugs filter on page [1]. Regards, Vladimir On 12/13/18 9:58 AM, mark.reinhold at oracle.com wrote: > Per the JDK 12 schedule [1], we are now in Rampdown Phase One. > > The overall feature set is frozen. No further JEPs will be targeted to > this release. > > We?ve forked the main-line source repository, jdk/jdk, to the jdk/jdk12 > stabilization repository. Any changes pushed to jdk/jdk or jdk/client > are now bound for JDK 13, as noted previously [2]. > > The stabilization repository is open for select bug fixes and, with > approval, late enhancements per JEP 3, the JDK Release Process [3]. > If you?re responsible for any of the bugs on the RDP 1 candidate-bug > list [3] then please see JEP 3 for guidance on how to handle them. > > - Mark > > > [1] http://openjdk.java.net/projects/jdk/12/#Schedule > [2] https://mail.openjdk.java.net/pipermail/jdk-dev/2018-December/002376.html > [3] http://openjdk.java.net/jeps/3 > [4] http://j.mp/jdk-rdp-1 > From mark.reinhold at oracle.com Thu Dec 13 19:07:22 2018 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Thu, 13 Dec 2018 11:07:22 -0800 Subject: JDK 12 is now in Rampdown Phase One In-Reply-To: References: <20181213175806.6F742233469@eggemoggin.niobe.net> Message-ID: <20181213110722.156126306@eggemoggin.niobe.net> 2018/12/13 11:02:16 -0800, vladimir.kozlov at oracle.com: > JBS bugs filters on release page [3] use fix version 11 instead of > 12. As result lists are not complete. The same issue for RDP 1 > candidate bugs filter on page [1]. Oops -- looks like I missed one. Fixed. Thanks for pointing it out. - Mark From shade at redhat.com Thu Dec 13 19:30:42 2018 From: shade at redhat.com (Aleksey Shipilev) Date: Thu, 13 Dec 2018 20:30:42 +0100 Subject: jdk-submit is reset, please re-clone and "hg out" before push In-Reply-To: <610C771B-5814-4E92-ABD3-0A13BA3089D6@oracle.com> References: <610C771B-5814-4E92-ABD3-0A13BA3089D6@oracle.com> Message-ID: <04e25979-3631-0e53-b426-c00939b7d8e8@redhat.com> On 12/13/18 5:15 PM, Stanislav Smirnov wrote: > yesterday, as some of you predicted, all the old branches were unintentionally pushed from a local clone. > Mistakes in this area affect everyone, unfortunately. Please be careful and pay attention. This would happen again, until automated checks prevent it. For example, reject the push of more than a single branch? It is a mild inconvenience for most users who do the feature-by-feature pushes. > It did not break the system, but to play safe the jdk-submit repository was reset. With no branches except from the default one. > > http://hg.openjdk.java.net/jdk/submit/ > > In order to continue using the submit repo please make a fresh clone and run ?hg out? before pushing to the origin. Tarball regenerated here: https://builds.shipilev.net/workspaces/jdk-sandbox.tar.xz -Aleksey From shade at redhat.com Thu Dec 13 21:29:28 2018 From: shade at redhat.com (Aleksey Shipilev) Date: Thu, 13 Dec 2018 22:29:28 +0100 Subject: JDK 12 is now in Rampdown Phase One In-Reply-To: <20181213175806.6F742233469@eggemoggin.niobe.net> References: <20181213175806.6F742233469@eggemoggin.niobe.net> Message-ID: <60c0ae5f-6066-8628-6b1a-ceed1294f167@redhat.com> On 12/13/18 6:58 PM, mark.reinhold at oracle.com wrote: > Per the JDK 12 schedule [1], we are now in Rampdown Phase One. > > The overall feature set is frozen. No further JEPs will be targeted to > this release. > > We?ve forked the main-line source repository, jdk/jdk, to the jdk/jdk12 > stabilization repository. Any changes pushed to jdk/jdk or jdk/client > are now bound for JDK 13, as noted previously [2]. If you are struggling (like me) with cloning a fresh jdk/jdk12, here is the tarball with it: https://builds.shipilev.net/workspaces/jdk-jdk12.tar.xz (submit12 should also appear there, with any luck, during next hour) -Aleksey From shade at redhat.com Thu Dec 13 21:40:45 2018 From: shade at redhat.com (Aleksey Shipilev) Date: Thu, 13 Dec 2018 22:40:45 +0100 Subject: jdk-submit is reset, please re-clone and "hg out" before push In-Reply-To: <04e25979-3631-0e53-b426-c00939b7d8e8@redhat.com> References: <610C771B-5814-4E92-ABD3-0A13BA3089D6@oracle.com> <04e25979-3631-0e53-b426-c00939b7d8e8@redhat.com> Message-ID: <7eb06d42-ffa6-8a95-d213-dd3fd16f6ae0@redhat.com> On 12/13/18 8:30 PM, Aleksey Shipilev wrote: > On 12/13/18 5:15 PM, Stanislav Smirnov wrote: >> yesterday, as some of you predicted, all the old branches were unintentionally pushed from a local clone. >> Mistakes in this area affect everyone, unfortunately. Please be careful and pay attention. > > This would happen again, until automated checks prevent it. For example, reject the push of more > than a single branch? It is a mild inconvenience for most users who do the feature-by-feature pushes. > >> It did not break the system, but to play safe the jdk-submit repository was reset. With no branches except from the default one. >> >> http://hg.openjdk.java.net/jdk/submit/ >> >> In order to continue using the submit repo please make a fresh clone and run ?hg out? before pushing to the origin. > > Tarball regenerated here: > https://builds.shipilev.net/workspaces/jdk-sandbox.tar.xz Oops, wrong link! Here: https://builds.shipilev.net/workspaces/jdk-submit.tar.xz -Aleksey From stanislav.smirnov at oracle.com Fri Dec 14 14:09:29 2018 From: stanislav.smirnov at oracle.com (Stanislav Smirnov) Date: Fri, 14 Dec 2018 09:09:29 -0500 Subject: Submit repo status In-Reply-To: <5067e934-02df-b016-d6f7-19d2e69d3c89@redhat.com> References: <1e1832a2-ddfb-d223-7677-2887bd0e7e36@kennke.org> <5067e934-02df-b016-d6f7-19d2e69d3c89@redhat.com> Message-ID: <107397F4-F2E6-4F66-A3FE-C01A2BBD1474@oracle.com> Thank you Aleksey for your feedback. Talking about clonebundles, the problem is that the version of Mercurial on the server does not support it. I am not aware of any plans to upgrading it. Best regards, Stanislav Smirnov > On Dec 11, 2018, at 8:05 AM, Aleksey Shipilev wrote: > > On 12/10/18 9:49 AM, Volker Simonis wrote: >> The problem you'll run into when you create new clones from time to >> time is that a single push from somebody who didn't realize that you >> have created a new clone (and didn't recreate its local version of >> submit) can unintentionally push ALL the old branches from his local >> clone when he only wants to push his single, new >> branch. I actually wonder that this hasn't happened already ... > > +1. > > I was staring blankly at my current "hg out" for jdk-submit trying to understand why does it want to > push thousands of changesets out. Only to realize something is "wrong" with the remote repository. > Then I discovered this thread. I could have easily not check it and push. > > I have three suggestions for the future: > a) Please say "jdk-submit is reset, please re-clone" as the message synopsis, not the innocuous > "Submit repo status" -- this important message was easy to miss; > b) Test if pushing old changesets accidentally is caught by some checker. I wonder if current > single-branch checkers would still allow to push all old changesets; > c) Support clonebundles [1]! It took me five (!) re-tries to clone new jdk-submit for my workspace > cache [2]. It would be very unfortunate to go through this exercise regularly. > > Thanks, > -Aleksey > > [1] https://bugs.openjdk.java.net/browse/JDK-8211383 > [2] https://builds.shipilev.net/workspaces/ > From webczat_200 at poczta.onet.pl Sat Dec 15 22:09:16 2018 From: webczat_200 at poczta.onet.pl (=?UTF-8?Q?Micha=c5=82_Zegan?=) Date: Sat, 15 Dec 2018 23:09:16 +0100 Subject: java access bridge Message-ID: <16504d9e-ea85-51d4-da4a-7a6f9816a3b4@poczta.onet.pl> Hello, Not sure where to direct this question, but in any case: On windows, java (jdk11) has java access bridge inside, the bridge allowing screenreaders to be used on java swing apps. There exists only a 64 bit version of java 11, and java access bridge can be enabled there. Screenreader communicates with a dll probably called c:\windows\system32\WindowsAccessBridge64.dll. There is however a problem: at least one of the popular screenreaders is 32 bit screenreader *only*. That means java access bridge becomes unusable with it because of the missing 32 bit version of the above dll. However it is proven that if that dll was installed, accessibility would work. Is it possible to add to jdk11 or later the 32 bit dll too? From andrewluotechnologies at outlook.com Sat Dec 15 22:16:03 2018 From: andrewluotechnologies at outlook.com (Andrew Luo) Date: Sat, 15 Dec 2018 22:16:03 +0000 Subject: java access bridge In-Reply-To: <16504d9e-ea85-51d4-da4a-7a6f9816a3b4@poczta.onet.pl> References: <16504d9e-ea85-51d4-da4a-7a6f9816a3b4@poczta.onet.pl> Message-ID: Hi Michal, Why can't you install both 32-bit and 64-bit JREs on those machines - doesn't that solve the problem without having to change the OpenJDK? Thanks Andrew -----Original Message----- From: jdk-dev On Behalf Of Michal Zegan Sent: Saturday, December 15, 2018 2:09 PM To: jdk-dev at openjdk.java.net Subject: java access bridge Hello, Not sure where to direct this question, but in any case: On windows, java (jdk11) has java access bridge inside, the bridge allowing screenreaders to be used on java swing apps. There exists only a 64 bit version of java 11, and java access bridge can be enabled there. Screenreader communicates with a dll probably called c:\windows\system32\WindowsAccessBridge64.dll. There is however a problem: at least one of the popular screenreaders is 32 bit screenreader *only*. That means java access bridge becomes unusable with it because of the missing 32 bit version of the above dll. However it is proven that if that dll was installed, accessibility would work. Is it possible to add to jdk11 or later the 32 bit dll too? From webczat_200 at poczta.onet.pl Sat Dec 15 22:37:54 2018 From: webczat_200 at poczta.onet.pl (=?UTF-8?Q?Micha=c5=82_Zegan?=) Date: Sat, 15 Dec 2018 23:37:54 +0100 Subject: java access bridge In-Reply-To: References: <16504d9e-ea85-51d4-da4a-7a6f9816a3b4@poczta.onet.pl> Message-ID: <2ec3a559-d72e-18e4-5c85-455326343f5b@poczta.onet.pl> Maybe because such a version doesn't exist? I cannot find 32 bit jdk anymore at least for jdk11, and I know it is not officially supported. W dniu 15.12.2018 o?23:16, Andrew Luo pisze: > Hi Michal, > > Why can't you install both 32-bit and 64-bit JREs on those machines - doesn't that solve the problem without having to change the OpenJDK? > > Thanks > Andrew > > -----Original Message----- > From: jdk-dev On Behalf Of Michal Zegan > Sent: Saturday, December 15, 2018 2:09 PM > To: jdk-dev at openjdk.java.net > Subject: java access bridge > > Hello, > Not sure where to direct this question, but in any case: > On windows, java (jdk11) has java access bridge inside, the bridge allowing screenreaders to be used on java swing apps. > There exists only a 64 bit version of java 11, and java access bridge can be enabled there. Screenreader communicates with a dll probably called c:\windows\system32\WindowsAccessBridge64.dll. > There is however a problem: at least one of the popular screenreaders is > 32 bit screenreader *only*. That means java access bridge becomes unusable with it because of the missing 32 bit version of the above dll. > However it is proven that if that dll was installed, accessibility would work. Is it possible to add to jdk11 or later the 32 bit dll too? > From andrewluotechnologies at outlook.com Sat Dec 15 22:44:57 2018 From: andrewluotechnologies at outlook.com (Andrew Luo) Date: Sat, 15 Dec 2018 22:44:57 +0000 Subject: java access bridge In-Reply-To: <2ec3a559-d72e-18e4-5c85-455326343f5b@poczta.onet.pl> References: <16504d9e-ea85-51d4-da4a-7a6f9816a3b4@poczta.onet.pl> <2ec3a559-d72e-18e4-5c85-455326343f5b@poczta.onet.pl> Message-ID: The official OpenJDK builds don't have 32-bit builds, but there are other vendors out there that supply 32-bit builds: https://adoptopenjdk.net/releases.html?variant=openjdk11&jvmVariant=hotspot Thanks, -Andrew -----Original Message----- From: Micha? Zegan Sent: Saturday, December 15, 2018 2:38 PM To: Andrew Luo ; jdk-dev at openjdk.java.net Subject: Re: java access bridge Maybe because such a version doesn't exist? I cannot find 32 bit jdk anymore at least for jdk11, and I know it is not officially supported. W dniu 15.12.2018 o?23:16, Andrew Luo pisze: > Hi Michal, > > Why can't you install both 32-bit and 64-bit JREs on those machines - doesn't that solve the problem without having to change the OpenJDK? > > Thanks > Andrew > > -----Original Message----- > From: jdk-dev On Behalf Of Michal > Zegan > Sent: Saturday, December 15, 2018 2:09 PM > To: jdk-dev at openjdk.java.net > Subject: java access bridge > > Hello, > Not sure where to direct this question, but in any case: > On windows, java (jdk11) has java access bridge inside, the bridge allowing screenreaders to be used on java swing apps. > There exists only a 64 bit version of java 11, and java access bridge can be enabled there. Screenreader communicates with a dll probably called c:\windows\system32\WindowsAccessBridge64.dll. > There is however a problem: at least one of the popular screenreaders > is > 32 bit screenreader *only*. That means java access bridge becomes unusable with it because of the missing 32 bit version of the above dll. > However it is proven that if that dll was installed, accessibility would work. Is it possible to add to jdk11 or later the 32 bit dll too? > From webczat_200 at poczta.onet.pl Sat Dec 15 22:57:51 2018 From: webczat_200 at poczta.onet.pl (=?UTF-8?Q?Micha=c5=82_Zegan?=) Date: Sat, 15 Dec 2018 23:57:51 +0100 Subject: java access bridge In-Reply-To: References: <16504d9e-ea85-51d4-da4a-7a6f9816a3b4@poczta.onet.pl> <2ec3a559-d72e-18e4-5c85-455326343f5b@poczta.onet.pl> Message-ID: <9dad9d94-b637-2329-075e-cde1f1013fe3@poczta.onet.pl> Ok, maybe there are. however because the 32 bit dll is applicable for both, and there is no other reason to install this 32 bit jre than to have this dll in place, I believe it is actually reasonable to include it in 64 bit version too. I mean ideally both 64 and 32 bit dlls would be installed in this case. W dniu 15.12.2018 o?23:44, Andrew Luo pisze: > The official OpenJDK builds don't have 32-bit builds, but there are other vendors out there that supply 32-bit builds: > > https://adoptopenjdk.net/releases.html?variant=openjdk11&jvmVariant=hotspot > > Thanks, > > -Andrew > > -----Original Message----- > From: Micha? Zegan > Sent: Saturday, December 15, 2018 2:38 PM > To: Andrew Luo ; jdk-dev at openjdk.java.net > Subject: Re: java access bridge > > Maybe because such a version doesn't exist? I cannot find 32 bit jdk anymore at least for jdk11, and I know it is not officially supported. > > W dniu 15.12.2018 o?23:16, Andrew Luo pisze: >> Hi Michal, >> >> Why can't you install both 32-bit and 64-bit JREs on those machines - doesn't that solve the problem without having to change the OpenJDK? >> >> Thanks >> Andrew >> >> -----Original Message----- >> From: jdk-dev On Behalf Of Michal >> Zegan >> Sent: Saturday, December 15, 2018 2:09 PM >> To: jdk-dev at openjdk.java.net >> Subject: java access bridge >> >> Hello, >> Not sure where to direct this question, but in any case: >> On windows, java (jdk11) has java access bridge inside, the bridge allowing screenreaders to be used on java swing apps. >> There exists only a 64 bit version of java 11, and java access bridge can be enabled there. Screenreader communicates with a dll probably called c:\windows\system32\WindowsAccessBridge64.dll. >> There is however a problem: at least one of the popular screenreaders >> is >> 32 bit screenreader *only*. That means java access bridge becomes unusable with it because of the missing 32 bit version of the above dll. >> However it is proven that if that dll was installed, accessibility would work. Is it possible to add to jdk11 or later the 32 bit dll too? >> > From andrewluotechnologies at outlook.com Sun Dec 16 00:30:33 2018 From: andrewluotechnologies at outlook.com (Andrew Luo) Date: Sun, 16 Dec 2018 00:30:33 +0000 Subject: java access bridge In-Reply-To: <9dad9d94-b637-2329-075e-cde1f1013fe3@poczta.onet.pl> References: <16504d9e-ea85-51d4-da4a-7a6f9816a3b4@poczta.onet.pl> <2ec3a559-d72e-18e4-5c85-455326343f5b@poczta.onet.pl> <9dad9d94-b637-2329-075e-cde1f1013fe3@poczta.onet.pl> Message-ID: By "applicable to both", right, it is possible that you might have WoW64 programs on Windows x64 that need 32-bit JRE DLLs. But it has always been the case that 32-bit applications (even on x64) will need a 32-bit JRE (for example Java web start, which is now deprecated - but previously, if you had a 32-bit browser you needed a 32-bit JRE, x64 browser = x64 JRE). I don't find this particularly unreasonable, as it is pretty common for 32-bit and x64 software to be packaged and distributed separately. Then users can have a choice (32-bit only, 64-bit only, or both). Many people (me included) don't have any need for a 32-bit JRE since 64-bit has been around for a long time and the majority of apps come in both flavors (or even x64 only), so I personally don't want to "bloat" the 64-bit distro with 32-bit binaries that the majority of users won't need. But anyways this is only my individual perspective. If there's other people who want to chime in, perhaps with reasons in support of this change, I'm happy to hear them. Thanks, -Andrew -----Original Message----- From: Micha? Zegan Sent: Saturday, December 15, 2018 2:58 PM To: Andrew Luo ; jdk-dev at openjdk.java.net Subject: Re: java access bridge Ok, maybe there are. however because the 32 bit dll is applicable for both, and there is no other reason to install this 32 bit jre than to have this dll in place, I believe it is actually reasonable to include it in 64 bit version too. I mean ideally both 64 and 32 bit dlls would be installed in this case. W dniu 15.12.2018 o?23:44, Andrew Luo pisze: > The official OpenJDK builds don't have 32-bit builds, but there are other vendors out there that supply 32-bit builds: > > https://adoptopenjdk.net/releases.html?variant=openjdk11&jvmVariant=ho > tspot > > Thanks, > > -Andrew > > -----Original Message----- > From: Micha? Zegan > Sent: Saturday, December 15, 2018 2:38 PM > To: Andrew Luo ; > jdk-dev at openjdk.java.net > Subject: Re: java access bridge > > Maybe because such a version doesn't exist? I cannot find 32 bit jdk anymore at least for jdk11, and I know it is not officially supported. > > W dniu 15.12.2018 o?23:16, Andrew Luo pisze: >> Hi Michal, >> >> Why can't you install both 32-bit and 64-bit JREs on those machines - doesn't that solve the problem without having to change the OpenJDK? >> >> Thanks >> Andrew >> >> -----Original Message----- >> From: jdk-dev On Behalf Of Michal >> Zegan >> Sent: Saturday, December 15, 2018 2:09 PM >> To: jdk-dev at openjdk.java.net >> Subject: java access bridge >> >> Hello, >> Not sure where to direct this question, but in any case: >> On windows, java (jdk11) has java access bridge inside, the bridge allowing screenreaders to be used on java swing apps. >> There exists only a 64 bit version of java 11, and java access bridge can be enabled there. Screenreader communicates with a dll probably called c:\windows\system32\WindowsAccessBridge64.dll. >> There is however a problem: at least one of the popular screenreaders >> is >> 32 bit screenreader *only*. That means java access bridge becomes unusable with it because of the missing 32 bit version of the above dll. >> However it is proven that if that dll was installed, accessibility would work. Is it possible to add to jdk11 or later the 32 bit dll too? >> > From webczat_200 at poczta.onet.pl Sun Dec 16 00:44:52 2018 From: webczat_200 at poczta.onet.pl (=?UTF-8?Q?Micha=c5=82_Zegan?=) Date: Sun, 16 Dec 2018 01:44:52 +0100 Subject: java access bridge In-Reply-To: References: <16504d9e-ea85-51d4-da4a-7a6f9816a3b4@poczta.onet.pl> <2ec3a559-d72e-18e4-5c85-455326343f5b@poczta.onet.pl> <9dad9d94-b637-2329-075e-cde1f1013fe3@poczta.onet.pl> Message-ID: But here it is the screenreader that is 32 bit and requires 32 bit dll. But this 32 bit dll is applicable for a 64 bit jre. If I would remove the 32 bit jre and install only that dll, then accessibility would be working on every java app even running a 64 bit jre. So it is a specific case. Othervise I do not need a full 32 bit jre. Also this specific file is to be put in c:\windows\syswow64... Also it is not so easy to find those 32 bit builds, I've tried and didn't find the link you gave me before. And the screenreader intentionally does not have a 64 bit version and probably never will. W dniu 16.12.2018 o?01:30, Andrew Luo pisze: > By "applicable to both", right, it is possible that you might have WoW64 programs on Windows x64 that need 32-bit JRE DLLs. But it has always been the case that 32-bit applications (even on x64) will need a 32-bit JRE (for example Java web start, which is now deprecated - but previously, if you had a 32-bit browser you needed a 32-bit JRE, x64 browser = x64 JRE). I don't find this particularly unreasonable, as it is pretty common for 32-bit and x64 software to be packaged and distributed separately. Then users can have a choice (32-bit only, 64-bit only, or both). Many people (me included) don't have any need for a 32-bit JRE since 64-bit has been around for a long time and the majority of apps come in both flavors (or even x64 only), so I personally don't want to "bloat" the 64-bit distro with 32-bit binaries that the majority of users won't need. > > But anyways this is only my individual perspective. If there's other people who want to chime in, perhaps with reasons in support of this change, I'm happy to hear them. > > Thanks, > > -Andrew > > -----Original Message----- > From: Micha? Zegan > Sent: Saturday, December 15, 2018 2:58 PM > To: Andrew Luo ; jdk-dev at openjdk.java.net > Subject: Re: java access bridge > > Ok, maybe there are. however because the 32 bit dll is applicable for both, and there is no other reason to install this 32 bit jre than to have this dll in place, I believe it is actually reasonable to include it in 64 bit version too. I mean ideally both 64 and 32 bit dlls would be installed in this case. > > W dniu 15.12.2018 o?23:44, Andrew Luo pisze: >> The official OpenJDK builds don't have 32-bit builds, but there are other vendors out there that supply 32-bit builds: >> >> https://adoptopenjdk.net/releases.html?variant=openjdk11&jvmVariant=ho >> tspot >> >> Thanks, >> >> -Andrew >> >> -----Original Message----- >> From: Micha? Zegan >> Sent: Saturday, December 15, 2018 2:38 PM >> To: Andrew Luo ; >> jdk-dev at openjdk.java.net >> Subject: Re: java access bridge >> >> Maybe because such a version doesn't exist? I cannot find 32 bit jdk anymore at least for jdk11, and I know it is not officially supported. >> >> W dniu 15.12.2018 o?23:16, Andrew Luo pisze: >>> Hi Michal, >>> >>> Why can't you install both 32-bit and 64-bit JREs on those machines - doesn't that solve the problem without having to change the OpenJDK? >>> >>> Thanks >>> Andrew >>> >>> -----Original Message----- >>> From: jdk-dev On Behalf Of Michal >>> Zegan >>> Sent: Saturday, December 15, 2018 2:09 PM >>> To: jdk-dev at openjdk.java.net >>> Subject: java access bridge >>> >>> Hello, >>> Not sure where to direct this question, but in any case: >>> On windows, java (jdk11) has java access bridge inside, the bridge allowing screenreaders to be used on java swing apps. >>> There exists only a 64 bit version of java 11, and java access bridge can be enabled there. Screenreader communicates with a dll probably called c:\windows\system32\WindowsAccessBridge64.dll. >>> There is however a problem: at least one of the popular screenreaders >>> is >>> 32 bit screenreader *only*. That means java access bridge becomes unusable with it because of the missing 32 bit version of the above dll. >>> However it is proven that if that dll was installed, accessibility would work. Is it possible to add to jdk11 or later the 32 bit dll too? >>> >> > From philip.race at oracle.com Sun Dec 16 01:27:50 2018 From: philip.race at oracle.com (Philip Race) Date: Sat, 15 Dec 2018 17:27:50 -0800 Subject: java access bridge In-Reply-To: References: <16504d9e-ea85-51d4-da4a-7a6f9816a3b4@poczta.onet.pl> <2ec3a559-d72e-18e4-5c85-455326343f5b@poczta.onet.pl> <9dad9d94-b637-2329-075e-cde1f1013fe3@poczta.onet.pl> Message-ID: <5C15AA16.90103@oracle.com> 1) I am not sure if this should be discussed on these lists, since it seems to be about what binaries Oracle provides for JDK 11 .. which is a question best directed to Oracle support. 2) Aside from that, accessbridge should be discussed on swing-dev. So this is probably my one + only email to this list about it. Any reply to this should go there. 3) SFAIK JAWS + NVDA are the screen readers that support access bridge and they both have 64 bit versions 4) The protocol is unchanged, so I think a 32 bit JDK 8 originated dll would work for communicating over COM with Java Access Bridge in JDK 11 5) There was actually a JDK 11 bug that windowsaccessbridge.dll - the 64 bit version - was not being copied into \windows\system32. I think that was fixed in the 11.01 release, but is an issue in 11 GA. 6) I don't think it likely we'd want to ship a 32 bit DLL with the 64 bit JDK ... although I won't rule it out. -phil. On 12/15/18, 4:44 PM, Micha? Zegan wrote: > But here it is the screenreader that is 32 bit and requires 32 bit dll. > But this 32 bit dll is applicable for a 64 bit jre. If I would remove > the 32 bit jre and install only that dll, then accessibility would be > working on every java app even running a 64 bit jre. So it is a specific > case. Othervise I do not need a full 32 bit jre. Also this specific file > is to be put in c:\windows\syswow64... Also it is not so easy to find > those 32 bit builds, I've tried and didn't find the link you gave me > before. And the screenreader intentionally does not have a 64 bit > version and probably never will. > > > W dniu 16.12.2018 o 01:30, Andrew Luo pisze: >> By "applicable to both", right, it is possible that you might have WoW64 programs on Windows x64 that need 32-bit JRE DLLs. But it has always been the case that 32-bit applications (even on x64) will need a 32-bit JRE (for example Java web start, which is now deprecated - but previously, if you had a 32-bit browser you needed a 32-bit JRE, x64 browser = x64 JRE). I don't find this particularly unreasonable, as it is pretty common for 32-bit and x64 software to be packaged and distributed separately. Then users can have a choice (32-bit only, 64-bit only, or both). Many people (me included) don't have any need for a 32-bit JRE since 64-bit has been around for a long time and the majority of apps come in both flavors (or even x64 only), so I personally don't want to "bloat" the 64-bit distro with 32-bit binaries that the majority of users won't need. >> >> But anyways this is only my individual perspective. If there's other people who want to chime in, perhaps with reasons in support of this change, I'm happy to hear them. >> >> Thanks, >> >> -Andrew >> >> -----Original Message----- >> From: Micha? Zegan >> Sent: Saturday, December 15, 2018 2:58 PM >> To: Andrew Luo; jdk-dev at openjdk.java.net >> Subject: Re: java access bridge >> >> Ok, maybe there are. however because the 32 bit dll is applicable for both, and there is no other reason to install this 32 bit jre than to have this dll in place, I believe it is actually reasonable to include it in 64 bit version too. I mean ideally both 64 and 32 bit dlls would be installed in this case. >> >> W dniu 15.12.2018 o 23:44, Andrew Luo pisze: >>> The official OpenJDK builds don't have 32-bit builds, but there are other vendors out there that supply 32-bit builds: >>> >>> https://adoptopenjdk.net/releases.html?variant=openjdk11&jvmVariant=ho >>> tspot >>> >>> Thanks, >>> >>> -Andrew >>> >>> -----Original Message----- >>> From: Micha? Zegan >>> Sent: Saturday, December 15, 2018 2:38 PM >>> To: Andrew Luo; >>> jdk-dev at openjdk.java.net >>> Subject: Re: java access bridge >>> >>> Maybe because such a version doesn't exist? I cannot find 32 bit jdk anymore at least for jdk11, and I know it is not officially supported. >>> >>> W dniu 15.12.2018 o 23:16, Andrew Luo pisze: >>>> Hi Michal, >>>> >>>> Why can't you install both 32-bit and 64-bit JREs on those machines - doesn't that solve the problem without having to change the OpenJDK? >>>> >>>> Thanks >>>> Andrew >>>> >>>> -----Original Message----- >>>> From: jdk-dev On Behalf Of Michal >>>> Zegan >>>> Sent: Saturday, December 15, 2018 2:09 PM >>>> To: jdk-dev at openjdk.java.net >>>> Subject: java access bridge >>>> >>>> Hello, >>>> Not sure where to direct this question, but in any case: >>>> On windows, java (jdk11) has java access bridge inside, the bridge allowing screenreaders to be used on java swing apps. >>>> There exists only a 64 bit version of java 11, and java access bridge can be enabled there. Screenreader communicates with a dll probably called c:\windows\system32\WindowsAccessBridge64.dll. >>>> There is however a problem: at least one of the popular screenreaders >>>> is >>>> 32 bit screenreader *only*. That means java access bridge becomes unusable with it because of the missing 32 bit version of the above dll. >>>> However it is proven that if that dll was installed, accessibility would work. Is it possible to add to jdk11 or later the 32 bit dll too? >>>> From webczat_200 at poczta.onet.pl Sun Dec 16 01:39:42 2018 From: webczat_200 at poczta.onet.pl (=?UTF-8?Q?Micha=c5=82_Zegan?=) Date: Sun, 16 Dec 2018 02:39:42 +0100 Subject: java access bridge In-Reply-To: <5C15AA16.90103@oracle.com> References: <16504d9e-ea85-51d4-da4a-7a6f9816a3b4@poczta.onet.pl> <2ec3a559-d72e-18e4-5c85-455326343f5b@poczta.onet.pl> <9dad9d94-b637-2329-075e-cde1f1013fe3@poczta.onet.pl> <5C15AA16.90103@oracle.com> Message-ID: <9999360e-0ac1-6cfc-95a7-ddaa2b94cde2@poczta.onet.pl> W dniu 16.12.2018 o?02:27, Philip Race pisze: > 1) I am not sure if this should be discussed on these lists, since it > seems to be > about what binaries Oracle provides for JDK 11 .. which is a question > best directed to Oracle support. > > 2) Aside from that, accessbridge should be discussed on swing-dev. So this > is probably my one + only email to this list about it. Any reply to this > should go there. ok > > 3) SFAIK JAWS + NVDA are the screen readers that support access bridge > and they both have 64 bit versions No, NVDA does not have a 64 bit version, and this is intentional. NVDA is always 32 bit and works on a 64 bit windows. > > 4) The protocol is unchanged, so I think a 32 bit JDK 8 originated dll > would work for communicating over > COM with Java Access Bridge in JDK 11 > > 5) There was actually a JDK 11 bug that windowsaccessbridge.dll - the 64 > bit version - was not being copied > into \windows\system32. I think that was fixed in the 11.01 release, but > is an issue in 11 GA. > > 6) I don't think it likely we'd want to ship a 32 bit DLL with the 64 > bit JDK ... although I won't rule it out. > > -phil. > > On 12/15/18, 4:44 PM, Micha? Zegan wrote: >> But here it is the screenreader that is 32 bit and requires 32 bit dll. >> But this 32 bit dll is applicable for a 64 bit jre. If I would remove >> the 32 bit jre and install only that dll, then accessibility would be >> working on every java app even running a 64 bit jre. So it is a specific >> case. Othervise I do not need a full 32 bit jre. Also this specific file >> is to be put in c:\windows\syswow64... Also it is not so easy to find >> those 32 bit builds, I've tried and didn't find the link you gave me >> before. And the screenreader intentionally does not have a 64 bit >> version and probably never will. >> >> >> W dniu 16.12.2018 o 01:30, Andrew Luo pisze: >>> By "applicable to both", right, it is possible that you might have >>> WoW64 programs on Windows x64 that need 32-bit JRE DLLs.? But it has >>> always been the case that 32-bit applications (even on x64) will need >>> a 32-bit JRE (for example Java web start, which is now deprecated - >>> but previously, if you had a 32-bit browser you needed a 32-bit JRE, >>> x64 browser = x64 JRE).? I don't find this particularly unreasonable, >>> as it is pretty common for 32-bit and x64 software to be packaged and >>> distributed separately.? Then users can have a choice (32-bit only, >>> 64-bit only, or both).? Many people (me included) don't have any need >>> for a 32-bit JRE since 64-bit has been around for a long time and the >>> majority of apps come in both flavors (or even x64 only), so I >>> personally don't want to "bloat" the 64-bit distro with 32-bit >>> binaries that the majority of users won't need. >>> >>> But anyways this is only my individual perspective.? If there's other >>> people who want to chime in, perhaps with reasons in support of this >>> change, I'm happy to hear them. >>> >>> Thanks, >>> >>> -Andrew >>> >>> -----Original Message----- >>> From: Micha? Zegan >>> Sent: Saturday, December 15, 2018 2:58 PM >>> To: Andrew Luo; >>> jdk-dev at openjdk.java.net >>> Subject: Re: java access bridge >>> >>> Ok, maybe there are. however because the 32 bit dll is applicable for >>> both, and there is no other reason to install this 32 bit jre than to >>> have this dll in place, I believe it is actually reasonable to >>> include it in 64 bit version too. I mean ideally both 64 and 32 bit >>> dlls would be installed in this case. >>> >>> W dniu 15.12.2018 o 23:44, Andrew Luo pisze: >>>> The official OpenJDK builds don't have 32-bit builds, but there are >>>> other vendors out there that supply 32-bit builds: >>>> >>>> https://adoptopenjdk.net/releases.html?variant=openjdk11&jvmVariant=ho >>>> tspot >>>> >>>> Thanks, >>>> >>>> -Andrew >>>> >>>> -----Original Message----- >>>> From: Micha? Zegan >>>> Sent: Saturday, December 15, 2018 2:38 PM >>>> To: Andrew Luo; >>>> jdk-dev at openjdk.java.net >>>> Subject: Re: java access bridge >>>> >>>> Maybe because such a version doesn't exist? I cannot find 32 bit jdk >>>> anymore at least for jdk11, and I know it is not officially supported. >>>> >>>> W dniu 15.12.2018 o 23:16, Andrew Luo pisze: >>>>> Hi Michal, >>>>> >>>>> Why can't you install both 32-bit and 64-bit JREs on those machines >>>>> - doesn't that solve the problem without having to change the OpenJDK? >>>>> >>>>> Thanks >>>>> Andrew >>>>> >>>>> -----Original Message----- >>>>> From: jdk-dev? On Behalf Of Michal >>>>> Zegan >>>>> Sent: Saturday, December 15, 2018 2:09 PM >>>>> To: jdk-dev at openjdk.java.net >>>>> Subject: java access bridge >>>>> >>>>> Hello, >>>>> Not sure where to direct this question, but in any case: >>>>> On windows, java (jdk11) has java access bridge inside, the bridge >>>>> allowing screenreaders to be used on java swing apps. >>>>> There exists only a 64 bit version of java 11, and java access >>>>> bridge can be enabled there. Screenreader communicates with a dll >>>>> probably called c:\windows\system32\WindowsAccessBridge64.dll. >>>>> There is however a problem: at least one of the popular screenreaders >>>>> is >>>>> 32 bit screenreader *only*. That means java access bridge becomes >>>>> unusable with it because of the missing 32 bit version of the above >>>>> dll. >>>>> However it is proven that if that dll was installed, accessibility >>>>> would work. Is it possible to add to jdk11 or later the 32 bit dll >>>>> too? >>>>> From adinn at redhat.com Mon Dec 17 09:40:45 2018 From: adinn at redhat.com (Andrew Dinn) Date: Mon, 17 Dec 2018 09:40:45 +0000 Subject: Missing submit notifications? Message-ID: <07cb5153-fa84-5951-1e6f-85bbf608ef69@redhat.com> I have not received an email response for the following submit changeset: http://hg.openjdk.java.net/jdk/submit/rev/d411345f961f Likewise Nick Gasson is missing an email response for this one http://hg.openjdk.java.net/jdk/submit/rev/39892a80d64a Is there a problem with processing of submit checkins? regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander From tobias.hartmann at oracle.com Mon Dec 17 10:32:34 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 17 Dec 2018 11:32:34 +0100 Subject: Missing submit notifications? In-Reply-To: <07cb5153-fa84-5951-1e6f-85bbf608ef69@redhat.com> References: <07cb5153-fa84-5951-1e6f-85bbf608ef69@redhat.com> Message-ID: <87e94894-e7ad-2c1e-c529-47de0b6afae1@oracle.com> Hi Andrew, it seems like your job for 8212043 failed to build on multiple platforms [1]. The job for 8215100 failed while cloning the sources (probably an infra issue). Not sure why you haven't received a notification. I'll leave that to the maintainers of the submit repo and would suggest trying a re-submit. Best regards, Tobias [1] Build failures: Mac: jib > /scratch/mesos/slaves/2dd962d0-8988-479b-a804-57ab764ada59-S40349/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/4ba1e23f-1fbd-42ad-bcd8-c7d0636b427f/runs/1c7d1a3b-c860-44c7-935c-1bb97e520095/workspace/open/src/hotspot/share/opto/type.cpp:453:35: error: invalid suffix 'd' on floating constant jib > TypeD::POS_INF = TypeD::make(1.0d/0.0d); // Double positive infinity jib > ^ jib > /scratch/mesos/slaves/2dd962d0-8988-479b-a804-57ab764ada59-S40349/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/4ba1e23f-1fbd-42ad-bcd8-c7d0636b427f/runs/1c7d1a3b-c860-44c7-935c-1bb97e520095/workspace/open/src/hotspot/share/opto/type.cpp:453:40: error: invalid suffix 'd' on floating constant jib > TypeD::POS_INF = TypeD::make(1.0d/0.0d); // Double positive infinity jib > ^ jib > /scratch/mesos/slaves/2dd962d0-8988-479b-a804-57ab764ada59-S40349/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/4ba1e23f-1fbd-42ad-bcd8-c7d0636b427f/runs/1c7d1a3b-c860-44c7-935c-1bb97e520095/workspace/open/src/hotspot/share/opto/type.cpp:454:36: error: invalid suffix 'd' on floating constant jib > TypeD::NEG_INF = TypeD::make(-1.0d/0.0d); // Double negative infinity jib > ^ jib > /scratch/mesos/slaves/2dd962d0-8988-479b-a804-57ab764ada59-S40349/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/4ba1e23f-1fbd-42ad-bcd8-c7d0636b427f/runs/1c7d1a3b-c860-44c7-935c-1bb97e520095/workspace/open/src/hotspot/share/opto/type.cpp:454:41: error: invalid suffix 'd' on floating constant jib > TypeD::NEG_INF = TypeD::make(-1.0d/0.0d); // Double negative infinity Windows: jib > t:/workspace/open/src/hotspot/share/opto/type.cpp(453): error C3688: invalid literal suffix 'd'; literal operator or literal operator template 'operator ""d' not found jib > t:/workspace/open/src/hotspot/share/opto/type.cpp(454): error C3688: invalid literal suffix 'd'; literal operator or literal operator template 'operator ""d' not found Sparc: jib > "/scratch/opt/mach5/mesos/work_dir/5eb40829-b194-4927-b024-db222ae8e8cc/workspace/open/src/hotspot/share/opto/type.cpp", line 453: Error: The floating constant "1.0d" is invalid. jib > "/scratch/opt/mach5/mesos/work_dir/5eb40829-b194-4927-b024-db222ae8e8cc/workspace/open/src/hotspot/share/opto/type.cpp", line 453: Error: The floating constant "0.0d" is invalid. jib > "/scratch/opt/mach5/mesos/work_dir/5eb40829-b194-4927-b024-db222ae8e8cc/workspace/open/src/hotspot/share/opto/type.cpp", line 454: Error: The floating constant "1.0d" is invalid. jib > "/scratch/opt/mach5/mesos/work_dir/5eb40829-b194-4927-b024-db222ae8e8cc/workspace/open/src/hotspot/share/opto/type.cpp", line 454: Error: The floating constant "0.0d" is invalid. From adinn at redhat.com Mon Dec 17 10:54:43 2018 From: adinn at redhat.com (Andrew Dinn) Date: Mon, 17 Dec 2018 10:54:43 +0000 Subject: Missing submit notifications? In-Reply-To: <87e94894-e7ad-2c1e-c529-47de0b6afae1@oracle.com> References: <07cb5153-fa84-5951-1e6f-85bbf608ef69@redhat.com> <87e94894-e7ad-2c1e-c529-47de0b6afae1@oracle.com> Message-ID: <1d07df07-cfbf-bbe6-f761-a114c7385d6a@redhat.com> Hi Tobias, On 17/12/2018 10:32, Tobias Hartmann wrote: > it seems like your job for 8212043 failed to build on multiple platforms [1]. The job for 8215100 > failed while cloning the sources (probably an infra issue). I think the errors you included were for the changes posted in branch JDK-8212043-2. The notification I am missing is for a revised version in branch JDK-8212043-3 which attempted to rectify those errors. > Not sure why you haven't received a notification. I'll leave that to the maintainers of the submit > repo and would suggest trying a re-submit. I suspect the notification "is gone where the woodbine twineth" (as Jubilee Jim Fisk once said of a lot of missing money) and life is too short to worry about the details. I'll try re-submitting as branch JDK-8212043-4 and advise the same for 8215100. Thanks very much for checking! regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander From Pengfei.Li at arm.com Mon Dec 17 10:58:42 2018 From: Pengfei.Li at arm.com (Pengfei Li (Arm Technology China)) Date: Mon, 17 Dec 2018 10:58:42 +0000 Subject: Missing submit notifications? In-Reply-To: <87e94894-e7ad-2c1e-c529-47de0b6afae1@oracle.com> References: <07cb5153-fa84-5951-1e6f-85bbf608ef69@redhat.com> <87e94894-e7ad-2c1e-c529-47de0b6afae1@oracle.com> Message-ID: Hi Tobias, Thanks for your notification. 8212043 is the patch Andrew Dinn helped me to submit. Last Friday, I've found the root cause of the failure and posted a new patch. Please see http://mail.openjdk.java.net/pipermail/aarch64-port-dev/2018-December/006603.html I think Andrew has already submitted my new patch to test, probably at JDK-8212043-3: http://hg.openjdk.java.net/jdk/submit/rev/d411345f961f -- Thanks, Pengfei > -----Original Message----- > From: jdk-dev On Behalf Of Tobias > Hartmann > Sent: Monday, December 17, 2018 18:33 > To: Andrew Dinn ; jdk-dev > Subject: Re: Missing submit notifications? > > Hi Andrew, > > it seems like your job for 8212043 failed to build on multiple platforms [1]. > The job for 8215100 failed while cloning the sources (probably an infra issue). > > Not sure why you haven't received a notification. I'll leave that to the > maintainers of the submit repo and would suggest trying a re-submit. > > Best regards, > Tobias > > > [1] Build failures: > Mac: > jib > > /scratch/mesos/slaves/2dd962d0-8988-479b-a804-57ab764ada59- > S40349/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd- > 0196/executors/4ba1e23f-1fbd-42ad-bcd8-c7d0636b427f/runs/1c7d1a3b- > c860-44c7-935c- > 1bb97e520095/workspace/open/src/hotspot/share/opto/type.cpp:453:35: > error: invalid suffix 'd' on floating constant > jib > TypeD::POS_INF = TypeD::make(1.0d/0.0d); // Double positive infinity > jib > ^ > jib > > /scratch/mesos/slaves/2dd962d0-8988-479b-a804-57ab764ada59- > S40349/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd- > 0196/executors/4ba1e23f-1fbd-42ad-bcd8-c7d0636b427f/runs/1c7d1a3b- > c860-44c7-935c- > 1bb97e520095/workspace/open/src/hotspot/share/opto/type.cpp:453:40: > error: invalid suffix 'd' on floating constant > jib > TypeD::POS_INF = TypeD::make(1.0d/0.0d); // Double positive infinity > jib > ^ > jib > > /scratch/mesos/slaves/2dd962d0-8988-479b-a804-57ab764ada59- > S40349/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd- > 0196/executors/4ba1e23f-1fbd-42ad-bcd8-c7d0636b427f/runs/1c7d1a3b- > c860-44c7-935c- > 1bb97e520095/workspace/open/src/hotspot/share/opto/type.cpp:454:36: > error: invalid suffix 'd' on floating constant > jib > TypeD::NEG_INF = TypeD::make(-1.0d/0.0d); // Double negative > infinity > jib > ^ > jib > > /scratch/mesos/slaves/2dd962d0-8988-479b-a804-57ab764ada59- > S40349/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd- > 0196/executors/4ba1e23f-1fbd-42ad-bcd8-c7d0636b427f/runs/1c7d1a3b- > c860-44c7-935c- > 1bb97e520095/workspace/open/src/hotspot/share/opto/type.cpp:454:41: > error: invalid suffix 'd' on floating constant > jib > TypeD::NEG_INF = TypeD::make(-1.0d/0.0d); // Double negative > infinity > > Windows: > jib > t:/workspace/open/src/hotspot/share/opto/type.cpp(453): error C3688: > invalid literal suffix 'd'; literal operator or literal operator template 'operator > ""d' not found jib > > t:/workspace/open/src/hotspot/share/opto/type.cpp(454): error C3688: > invalid literal suffix 'd'; literal operator or literal operator template 'operator > ""d' not found > > Sparc: > jib > > "/scratch/opt/mach5/mesos/work_dir/5eb40829-b194-4927-b024- > db222ae8e8cc/workspace/open/src/hotspot/share/opto/type.cpp", > line 453: Error: The floating constant "1.0d" is invalid. > jib > > "/scratch/opt/mach5/mesos/work_dir/5eb40829-b194-4927-b024- > db222ae8e8cc/workspace/open/src/hotspot/share/opto/type.cpp", > line 453: Error: The floating constant "0.0d" is invalid. > jib > > "/scratch/opt/mach5/mesos/work_dir/5eb40829-b194-4927-b024- > db222ae8e8cc/workspace/open/src/hotspot/share/opto/type.cpp", > line 454: Error: The floating constant "1.0d" is invalid. > jib > > "/scratch/opt/mach5/mesos/work_dir/5eb40829-b194-4927-b024- > db222ae8e8cc/workspace/open/src/hotspot/share/opto/type.cpp", > line 454: Error: The floating constant "0.0d" is invalid. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. From tobias.hartmann at oracle.com Mon Dec 17 11:10:53 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 17 Dec 2018 12:10:53 +0100 Subject: Missing submit notifications? In-Reply-To: <1d07df07-cfbf-bbe6-f761-a114c7385d6a@redhat.com> References: <07cb5153-fa84-5951-1e6f-85bbf608ef69@redhat.com> <87e94894-e7ad-2c1e-c529-47de0b6afae1@oracle.com> <1d07df07-cfbf-bbe6-f761-a114c7385d6a@redhat.com> Message-ID: On 17.12.18 11:54, Andrew Dinn wrote: > I think the errors you included were for the changes posted in branch > JDK-8212043-2. The notification I am missing is for a revised version in > branch JDK-8212043-3 which attempted to rectify those errors. Yes, you are right. As far as I can tell, the system did not even create a job for the JDK-8212043-3 branch (probably it failed very early). > I suspect the notification "is gone where the woodbine twineth" (as > Jubilee Jim Fisk once said of a lot of missing money) and life is too > short to worry about the details. I'll try re-submitting as branch > JDK-8212043-4 and advise the same for 8215100. Sounds good. I can see JDK-8212043-4 in the system (it's busy cloning the sources). Best regards, Tobias From adinn at redhat.com Mon Dec 17 11:29:58 2018 From: adinn at redhat.com (Andrew Dinn) Date: Mon, 17 Dec 2018 11:29:58 +0000 Subject: Missing submit notifications? In-Reply-To: References: <07cb5153-fa84-5951-1e6f-85bbf608ef69@redhat.com> <87e94894-e7ad-2c1e-c529-47de0b6afae1@oracle.com> <1d07df07-cfbf-bbe6-f761-a114c7385d6a@redhat.com> Message-ID: <34f6c080-6d98-2613-d64d-ef9b3324c293@redhat.com> On 17/12/2018 11:10, Tobias Hartmann wrote: >> I suspect the notification "is gone where the woodbine twineth" (as >> Jubilee Jim Fisk once said of a lot of missing money) and life is too >> short to worry about the details. I'll try re-submitting as branch >> JDK-8212043-4 and advise the same for 8215100. > > Sounds good. I can see JDK-8212043-4 in the system (it's busy cloning the sources). Thanks for confirming! regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander From stanislav.smirnov at oracle.com Mon Dec 17 13:53:52 2018 From: stanislav.smirnov at oracle.com (Stanislav Smirnov) Date: Mon, 17 Dec 2018 08:53:52 -0500 Subject: Missing submit notifications? In-Reply-To: <34f6c080-6d98-2613-d64d-ef9b3324c293@redhat.com> References: <07cb5153-fa84-5951-1e6f-85bbf608ef69@redhat.com> <87e94894-e7ad-2c1e-c529-47de0b6afae1@oracle.com> <1d07df07-cfbf-bbe6-f761-a114c7385d6a@redhat.com> <34f6c080-6d98-2613-d64d-ef9b3324c293@redhat.com> Message-ID: <274A62A1-007E-46D7-BCD8-2EABC6E00E55@oracle.com> Hi Andrew, yes, I do not see the *-3 branch in the system. You should have received a notification for *-4, in the failed build tasks I can see "open/src/hotspot/share/opto/type.cpp(448): error C2124: divide or mod by zero?. Talking about notifications, I am planning to enhance the communication between users and the system to make it more transparent, so user can know at what step a branch is. For the jdk-submit related issues, please also send a message to the ops at openjdk.java.net . Best regards, Stanislav Smirnov > On Dec 17, 2018, at 6:29 AM, Andrew Dinn wrote: > > On 17/12/2018 11:10, Tobias Hartmann wrote: >>> I suspect the notification "is gone where the woodbine twineth" (as >>> Jubilee Jim Fisk once said of a lot of missing money) and life is too >>> short to worry about the details. I'll try re-submitting as branch >>> JDK-8212043-4 and advise the same for 8215100. >> >> Sounds good. I can see JDK-8212043-4 in the system (it's busy cloning the sources). > Thanks for confirming! > > regards, > > > Andrew Dinn > ----------- > Senior Principal Software Engineer > Red Hat UK Ltd > Registered in England and Wales under Company Registration No. 03798903 > Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander From adinn at redhat.com Mon Dec 17 14:57:57 2018 From: adinn at redhat.com (Andrew Dinn) Date: Mon, 17 Dec 2018 14:57:57 +0000 Subject: Missing submit notifications? In-Reply-To: <274A62A1-007E-46D7-BCD8-2EABC6E00E55@oracle.com> References: <07cb5153-fa84-5951-1e6f-85bbf608ef69@redhat.com> <87e94894-e7ad-2c1e-c529-47de0b6afae1@oracle.com> <1d07df07-cfbf-bbe6-f761-a114c7385d6a@redhat.com> <34f6c080-6d98-2613-d64d-ef9b3324c293@redhat.com> <274A62A1-007E-46D7-BCD8-2EABC6E00E55@oracle.com> Message-ID: <1554829e-9b92-eea0-a865-2638097d314b@redhat.com> Hi Stanislav, On 17/12/2018 13:53, Stanislav Smirnov wrote: > yes, I do not see the *-3 branch in the system.? > You should have received a notification for *-4, in the failed build > tasks I can see "open/src/hotspot/share/opto/type.cpp(448): error C2124: > divide or mod by zero?. Yes, I got that about half an hour ago. Thanks for forwarding the error notification. > Talking about notifications, I am planning to enhance the communication > between users and the system to make it more transparent, so user can > know at what step a branch is. It would really help if user of the submit repo could see the build log without having to rely on bothering someone at Oracle to check up and forward details of any error. Oracle staff have always responded very kindly to such requests (for which I am very grateful) but I always feel bad about continually having to ask them for assistance. If we could simply have the last 100 lines of the build log emailed to the submitter that would be a big help. Would that be a problem to implement because it might reveal details of the build process that are Oracle are not at liberty to disclose? > For the jdk-submit related issues, please also send a message to > the?ops at openjdk.java.net . Thanks. I will do in future. To be honest I always thought ops at openjdk.java.net was just an opaque way to post mail to the machine under MR's desk (which he then sometimes forwarded to Iris). I'm very glad to see Mark now has a full support team (not half as glad as he is? :-). regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander From Pengfei.Li at arm.com Mon Dec 17 15:18:21 2018 From: Pengfei.Li at arm.com (Pengfei Li (Arm Technology China)) Date: Mon, 17 Dec 2018 15:18:21 +0000 Subject: Missing submit notifications? In-Reply-To: <274A62A1-007E-46D7-BCD8-2EABC6E00E55@oracle.com> References: <07cb5153-fa84-5951-1e6f-85bbf608ef69@redhat.com> <87e94894-e7ad-2c1e-c529-47de0b6afae1@oracle.com> <1d07df07-cfbf-bbe6-f761-a114c7385d6a@redhat.com> <34f6c080-6d98-2613-d64d-ef9b3324c293@redhat.com>, <274A62A1-007E-46D7-BCD8-2EABC6E00E55@oracle.com> Message-ID: Hi Stanislav, > You should have received a notification for *-4, in the failed build tasks I can see "open/src/hotspot/share/opto/type.cpp(448): error C2124: divide or mod by zero?. Could you help me check if "open/src/hotspot/share/opto/type.cpp(448): error C2124: divide or mod by zero" is the only build error in 8212043-4? I just fixed the build issues on sparc and macOS in *-1 and *-2 respectively. And it's time for windows now. (Google tells me error C2124 is reported by Visual Studio) -- Thanks, Pengfei IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. From stanislav.smirnov at oracle.com Mon Dec 17 15:54:48 2018 From: stanislav.smirnov at oracle.com (Stanislav Smirnov) Date: Mon, 17 Dec 2018 10:54:48 -0500 Subject: Missing submit notifications? In-Reply-To: <1554829e-9b92-eea0-a865-2638097d314b@redhat.com> References: <07cb5153-fa84-5951-1e6f-85bbf608ef69@redhat.com> <87e94894-e7ad-2c1e-c529-47de0b6afae1@oracle.com> <1d07df07-cfbf-bbe6-f761-a114c7385d6a@redhat.com> <34f6c080-6d98-2613-d64d-ef9b3324c293@redhat.com> <274A62A1-007E-46D7-BCD8-2EABC6E00E55@oracle.com> <1554829e-9b92-eea0-a865-2638097d314b@redhat.com> Message-ID: Andrew, > Would that be a problem to implement because > it might reveal details of the build process that are Oracle are not at > liberty to disclose? Yes, this is the main reason. Though, we may enhance it in the future. Talking about ?ops?, it was decided that it is a good place to provide the jdk-submit support. Best regards, Stanislav Smirnov > On Dec 17, 2018, at 9:57 AM, Andrew Dinn wrote: > > Hi Stanislav, > > On 17/12/2018 13:53, Stanislav Smirnov wrote: >> yes, I do not see the *-3 branch in the system. >> You should have received a notification for *-4, in the failed build >> tasks I can see "open/src/hotspot/share/opto/type.cpp(448): error C2124: >> divide or mod by zero?. > > Yes, I got that about half an hour ago. Thanks for forwarding the error > notification. > >> Talking about notifications, I am planning to enhance the communication >> between users and the system to make it more transparent, so user can >> know at what step a branch is. > > It would really help if user of the submit repo could see the build log > without having to rely on bothering someone at Oracle to check up and > forward details of any error. Oracle staff have always responded very > kindly to such requests (for which I am very grateful) but I always feel > bad about continually having to ask them for assistance. If we could > simply have the last 100 lines of the build log emailed to the submitter > that would be a big help. Would that be a problem to implement because > it might reveal details of the build process that are Oracle are not at > liberty to disclose? > >> For the jdk-submit related issues, please also send a message to >> the ops at openjdk.java.net . > Thanks. I will do in future. > > To be honest I always thought ops at openjdk.java.net was just an opaque > way to post mail to the machine under MR's desk (which he then sometimes > forwarded to Iris). I'm very glad to see Mark now has a full support > team (not half as glad as he is? :-). > > regards, > > > Andrew Dinn > ----------- > Senior Principal Software Engineer > Red Hat UK Ltd > Registered in England and Wales under Company Registration No. 03798903 > Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander From stanislav.smirnov at oracle.com Mon Dec 17 15:56:49 2018 From: stanislav.smirnov at oracle.com (Stanislav Smirnov) Date: Mon, 17 Dec 2018 10:56:49 -0500 Subject: Missing submit notifications? In-Reply-To: References: <07cb5153-fa84-5951-1e6f-85bbf608ef69@redhat.com> <87e94894-e7ad-2c1e-c529-47de0b6afae1@oracle.com> <1d07df07-cfbf-bbe6-f761-a114c7385d6a@redhat.com> <34f6c080-6d98-2613-d64d-ef9b3324c293@redhat.com> <274A62A1-007E-46D7-BCD8-2EABC6E00E55@oracle.com> Message-ID: <2EFB7C71-3BD0-41C9-947B-5E5B808215A7@oracle.com> Pengfei, as far as I can see yes, the ?divide or mod by zero? is the only build error in *-4. And btw, those 4 failures are all on Windows. Best regards, Stanislav Smirnov > On Dec 17, 2018, at 10:18 AM, Pengfei Li (Arm Technology China) wrote: > > Hi Stanislav, > > > You should have received a notification for *-4, in the failed build tasks I can see "open/src/hotspot/share/opto/type.cpp(448): error C2124: divide or mod by zero?. > > Could you help me check if "open/src/hotspot/share/opto/type.cpp(448): error C2124: divide or mod by zero" is the only build error in 8212043-4? > > I just fixed the build issues on sparc and macOS in *-1 and *-2 respectively. And it's time for windows now. (Google tells me error C2124 is reported by Visual Studio) > > -- > Thanks, > Pengfei > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. From Sergey.Bylokhov at oracle.com Mon Dec 17 19:09:29 2018 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Mon, 17 Dec 2018 11:09:29 -0800 Subject: java access bridge In-Reply-To: <16504d9e-ea85-51d4-da4a-7a6f9816a3b4@poczta.onet.pl> References: <16504d9e-ea85-51d4-da4a-7a6f9816a3b4@poczta.onet.pl> Message-ID: <1d3e899b-4798-d42a-a768-edb64bcc5683@oracle.com> Hi, Micha?. This dll should be available at "java_home/bin" folder, there is a bug that it does not copied to the "windows/system32" by the installer, it will be fixed in some of updates of 11u. On 15/12/2018 14:09, Micha? Zegan wrote: > However it is proven that if that dll was installed, accessibility would > work. Is it possible to add to jdk11 or later the 32 bit dll too? -- Best regards, Sergey. From webczat_200 at poczta.onet.pl Mon Dec 17 19:21:49 2018 From: webczat_200 at poczta.onet.pl (=?UTF-8?Q?Micha=c5=82_Zegan?=) Date: Mon, 17 Dec 2018 20:21:49 +0100 Subject: java access bridge In-Reply-To: <1d3e899b-4798-d42a-a768-edb64bcc5683@oracle.com> References: <16504d9e-ea85-51d4-da4a-7a6f9816a3b4@poczta.onet.pl> <1d3e899b-4798-d42a-a768-edb64bcc5683@oracle.com> Message-ID: <2f8ec835-9ba4-2818-9e98-d7bca3933fff@poczta.onet.pl> Hello, It is not really what the topic was about. It was about the fact that a 32 bit dll is needed to interface with 32 bit screenreaders like nvda, but is not present in a 64 bit jdk, even though it works with it. And there is no 64 bit nvda. W dniu 17.12.2018 o?20:09, Sergey Bylokhov pisze: > Hi, Micha?. > > This dll should be available at "java_home/bin" folder, there is a bug > that it does not copied to the "windows/system32" by the installer, it will > be fixed in some of updates of 11u. > > On 15/12/2018 14:09, Micha? Zegan wrote: >> However it is proven that if that dll was installed, accessibility would >> work. Is it possible to add to jdk11 or later the 32 bit dll too? > > From aph at redhat.com Tue Dec 18 11:22:31 2018 From: aph at redhat.com (Andrew Haley) Date: Tue, 18 Dec 2018 11:22:31 +0000 Subject: Missing submit notifications? In-Reply-To: <1d07df07-cfbf-bbe6-f761-a114c7385d6a@redhat.com> References: <07cb5153-fa84-5951-1e6f-85bbf608ef69@redhat.com> <87e94894-e7ad-2c1e-c529-47de0b6afae1@oracle.com> <1d07df07-cfbf-bbe6-f761-a114c7385d6a@redhat.com> Message-ID: <13ca1b09-fe5c-9b6e-637a-40b4a9b53c75@redhat.com> On 12/17/18 10:54 AM, Andrew Dinn wrote: > I suspect the notification "is gone where the woodbine twineth" (as > Jubilee Jim Fisk once said of a lot of missing money) and life is too > short to worry about the details. I'll try re-submitting as branch > JDK-8212043-4 and advise the same for 8215100. I'm still missing a reply to a submission I made yesterday. -- Andrew Haley Java Platform Lead Engineer Red Hat UK Ltd. EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From tobias.hartmann at oracle.com Tue Dec 18 12:00:08 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 18 Dec 2018 13:00:08 +0100 Subject: Missing submit notifications? In-Reply-To: <13ca1b09-fe5c-9b6e-637a-40b4a9b53c75@redhat.com> References: <07cb5153-fa84-5951-1e6f-85bbf608ef69@redhat.com> <87e94894-e7ad-2c1e-c529-47de0b6afae1@oracle.com> <1d07df07-cfbf-bbe6-f761-a114c7385d6a@redhat.com> <13ca1b09-fe5c-9b6e-637a-40b4a9b53c75@redhat.com> Message-ID: <146668ae-4175-464b-c63e-4107b136966c@oracle.com> On 18.12.18 12:22, Andrew Haley wrote: > I'm still missing a reply to a submission I made yesterday. I can see JDK-8212043-4 which failed to build on Windows with: jib > t:/workspace/open/src/hotspot/share/opto/type.cpp(448): error C2124: divide or mod by zero And JDK-8212043-5, which also failed to build on Windows: jib > t:/workspace/open/src/hotspot/share/opto/type.cpp(419): error C2220: warning treated as error - no 'object' file generated jib > t:/workspace/open/src/hotspot/share/opto/type.cpp(419): warning C4305: 'initializing': truncation from '__int64' to 'long' jib > t:/workspace/open/src/hotspot/share/opto/type.cpp(419): warning C4309: 'initializing': truncation of constant value Is that the one? Best regards, Tobias From markus.gronlund at oracle.com Tue Dec 18 13:11:38 2018 From: markus.gronlund at oracle.com (Markus Gronlund) Date: Tue, 18 Dec 2018 05:11:38 -0800 (PST) Subject: CFV: New JDK Reviewer: Erik Gahlin Message-ID: I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1].? Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. Votes are due by January 8, 2019 (extending voting period over holiday season). Only current JDK Reviewers [3] are eligible to vote on this nomination.??Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [4]. Markus [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() [2] http://openjdk.java.net/jeps/328 [3] http://openjdk.java.net/census [4] http://openjdk.java.net/projects/#reviewer-vote From paul.hohensee at gmail.com Tue Dec 18 13:16:48 2018 From: paul.hohensee at gmail.com (Paul Hohensee) Date: Tue, 18 Dec 2018 08:16:48 -0500 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: Vote:yes Paul On Tue, Dec 18, 2018 at 8:14 AM Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 > changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped > deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday > season). > > Only current JDK Reviewers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] > http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > > From harold.seigel at oracle.com Tue Dec 18 13:37:39 2018 From: harold.seigel at oracle.com (Harold David Seigel) Date: Tue, 18 Dec 2018 08:37:39 -0500 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <1e40d026-55d4-09b4-86af-13d93cc39ead@oracle.com> Vote: yes Harold On 12/18/2018 8:11 AM, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination.??Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From erik.osterlund at oracle.com Tue Dec 18 13:44:09 2018 From: erik.osterlund at oracle.com (=?UTF-8?Q?Erik_=c3=96sterlund?=) Date: Tue, 18 Dec 2018 14:44:09 +0100 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <0c2aea94-af33-d495-1d5d-ec32ee936655@oracle.com> Vote: yes /Erik On 2018-12-18 14:11, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination.??Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From andy.herrick at oracle.com Tue Dec 18 13:48:37 2018 From: andy.herrick at oracle.com (Andy Herrick) Date: Tue, 18 Dec 2018 08:48:37 -0500 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: Vote: yes /Andy On 12/18/2018 8:11 AM, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination.??Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From Roger.Riggs at oracle.com Tue Dec 18 14:01:18 2018 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Tue, 18 Dec 2018 09:01:18 -0500 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: Vote: yes On 12/18/2018 08:11 AM, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. From james.laskey at oracle.com Tue Dec 18 14:06:51 2018 From: james.laskey at oracle.com (Jim Laskey) Date: Tue, 18 Dec 2018 10:06:51 -0400 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <74642BDA-F45B-478D-BA8D-E961ED431781@oracle.com> Vote: yes > On Dec 18, 2018, at 9:11 AM, Markus Gronlund wrote: > > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From tobias.hartmann at oracle.com Tue Dec 18 14:22:57 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 18 Dec 2018 15:22:57 +0100 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <65936d96-1262-0542-74b3-93b023640020@oracle.com> Vote: yes On 18.12.18 14:11, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1].? > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination.??Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From stanislav.smirnov at oracle.com Tue Dec 18 14:27:35 2018 From: stanislav.smirnov at oracle.com (Stanislav Smirnov) Date: Tue, 18 Dec 2018 09:27:35 -0500 Subject: Missing submit notifications? In-Reply-To: <146668ae-4175-464b-c63e-4107b136966c@oracle.com> References: <07cb5153-fa84-5951-1e6f-85bbf608ef69@redhat.com> <87e94894-e7ad-2c1e-c529-47de0b6afae1@oracle.com> <1d07df07-cfbf-bbe6-f761-a114c7385d6a@redhat.com> <13ca1b09-fe5c-9b6e-637a-40b4a9b53c75@redhat.com> <146668ae-4175-464b-c63e-4107b136966c@oracle.com> Message-ID: <0F5A3D9D-6C22-4288-B6AF-E81259963669@oracle.com> Andrew, what branch are you talking about? Best regards, Stanislav Smirnov > On Dec 18, 2018, at 7:00 AM, Tobias Hartmann wrote: > > > On 18.12.18 12:22, Andrew Haley wrote: >> I'm still missing a reply to a submission I made yesterday. > > I can see JDK-8212043-4 which failed to build on Windows with: > jib > t:/workspace/open/src/hotspot/share/opto/type.cpp(448): error C2124: divide or mod by zero > > And JDK-8212043-5, which also failed to build on Windows: > jib > t:/workspace/open/src/hotspot/share/opto/type.cpp(419): error C2220: warning treated as error > - no 'object' file generated > jib > t:/workspace/open/src/hotspot/share/opto/type.cpp(419): warning C4305: 'initializing': > truncation from '__int64' to 'long' > jib > t:/workspace/open/src/hotspot/share/opto/type.cpp(419): warning C4309: 'initializing': > truncation of constant value > > Is that the one? > > Best regards, > Tobias From stanislav.smirnov at oracle.com Tue Dec 18 14:33:52 2018 From: stanislav.smirnov at oracle.com (Stanislav Smirnov) Date: Tue, 18 Dec 2018 09:33:52 -0500 Subject: Missing submit notifications? In-Reply-To: <0F5A3D9D-6C22-4288-B6AF-E81259963669@oracle.com> References: <07cb5153-fa84-5951-1e6f-85bbf608ef69@redhat.com> <87e94894-e7ad-2c1e-c529-47de0b6afae1@oracle.com> <1d07df07-cfbf-bbe6-f761-a114c7385d6a@redhat.com> <13ca1b09-fe5c-9b6e-637a-40b4a9b53c75@redhat.com> <146668ae-4175-464b-c63e-4107b136966c@oracle.com> <0F5A3D9D-6C22-4288-B6AF-E81259963669@oracle.com> Message-ID: <98642BED-3586-4BF4-92CA-05EC8565D594@oracle.com> Andrew, I think I found it, JDK-8215100. It failed to submit because of the ?author? value you specified, ?Andrew Haley ?. Can you please either use your email or just your user name, like you did in the previous changeset where you backed out a changeset? Best regards, Stanislav Smirnov > On Dec 18, 2018, at 9:27 AM, Stanislav Smirnov wrote: > > Andrew, what branch are you talking about? > > Best regards, > Stanislav Smirnov > >> On Dec 18, 2018, at 7:00 AM, Tobias Hartmann wrote: >> >> >> On 18.12.18 12:22, Andrew Haley wrote: >>> I'm still missing a reply to a submission I made yesterday. >> >> I can see JDK-8212043-4 which failed to build on Windows with: >> jib > t:/workspace/open/src/hotspot/share/opto/type.cpp(448): error C2124: divide or mod by zero >> >> And JDK-8212043-5, which also failed to build on Windows: >> jib > t:/workspace/open/src/hotspot/share/opto/type.cpp(419): error C2220: warning treated as error >> - no 'object' file generated >> jib > t:/workspace/open/src/hotspot/share/opto/type.cpp(419): warning C4305: 'initializing': >> truncation from '__int64' to 'long' >> jib > t:/workspace/open/src/hotspot/share/opto/type.cpp(419): warning C4309: 'initializing': >> truncation of constant value >> >> Is that the one? >> >> Best regards, >> Tobias > From daniel.daugherty at oracle.com Tue Dec 18 14:56:21 2018 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 18 Dec 2018 09:56:21 -0500 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <7254bd26-3b33-9166-affd-a128fd15d093@oracle.com> Vote: yes Dan On 12/18/18 8:11 AM, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination.??Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > > From lois.foltan at oracle.com Tue Dec 18 15:06:24 2018 From: lois.foltan at oracle.com (Lois Foltan) Date: Tue, 18 Dec 2018 10:06:24 -0500 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <3f889477-a236-ce14-770d-0e3f58dd54ca@oracle.com> Vote: yes Lois On 12/18/2018 8:11 AM, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination.??Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From jini.george at oracle.com Tue Dec 18 15:14:24 2018 From: jini.george at oracle.com (Jini George) Date: Tue, 18 Dec 2018 20:44:24 +0530 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <2415519a-12d9-57ab-4ed2-698cbf9185d0@oracle.com> Vote: yes - Jini. On 12/18/2018 6:41 PM, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination.??Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From coleen.phillimore at oracle.com Tue Dec 18 15:22:10 2018 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Tue, 18 Dec 2018 10:22:10 -0500 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <7a56cac9-354f-0f65-20f0-e8387cfbbe41@oracle.com> Vote: yes On 12/18/18 8:11 AM, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination.??Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From shade at redhat.com Tue Dec 18 15:18:31 2018 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 18 Dec 2018 16:18:31 +0100 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <13287821-b34e-d993-e30c-ce152f03cbf8@redhat.com> Vote: yes On 12/18/18 2:11 PM, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. From zgu at redhat.com Tue Dec 18 15:31:26 2018 From: zgu at redhat.com (zgu at redhat.com) Date: Tue, 18 Dec 2018 10:31:26 -0500 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <1545147086.4592.126.camel@redhat.com> Vote: yes. -Zhengyu On Tue, 2018-12-18 at 05:11 -0800, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed > over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he > helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over > holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this > mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(e > gahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328? > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From sean.coffey at oracle.com Tue Dec 18 15:45:45 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Tue, 18 Dec 2018 15:45:45 +0000 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <017071e8-c39e-38a3-efbd-71d2c3dd196d@oracle.com> Vote: yes regards, Sean. On 18/12/2018 13:11, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination.??Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From vladimir.kozlov at oracle.com Tue Dec 18 16:00:52 2018 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Tue, 18 Dec 2018 08:00:52 -0800 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: Vote: yes On 12/18/18 5:11 AM, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination.??Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From mandy.chung at oracle.com Tue Dec 18 16:06:41 2018 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 18 Dec 2018 08:06:41 -0800 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <3a8f1c34-2452-360d-0f1d-677e53c3b8db@oracle.com> Vote: yes Mandy From volker.simonis at gmail.com Tue Dec 18 16:22:36 2018 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 18 Dec 2018 17:22:36 +0100 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: Vote: yes On Tue, Dec 18, 2018 at 2:13 PM Markus Gronlund wrote: > > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From calvin.cheung at oracle.com Tue Dec 18 17:02:22 2018 From: calvin.cheung at oracle.com (Calvin Cheung) Date: Tue, 18 Dec 2018 09:02:22 -0800 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <5C19281E.3030807@oracle.com> Vote: yes On 12/18/18, 5:11 AM, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From jiangli.zhou at oracle.com Tue Dec 18 18:15:20 2018 From: jiangli.zhou at oracle.com (Jiangli Zhou) Date: Tue, 18 Dec 2018 10:15:20 -0800 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <275b3980-b195-a3e3-2404-241da12458ee@oracle.com> Vote:yes Thanks, Jiangli On 12/18/18 5:11 AM, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination.??Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From vladimir.x.ivanov at oracle.com Tue Dec 18 18:17:56 2018 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Tue, 18 Dec 2018 10:17:56 -0800 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <4c8170f4-f9d3-0545-990a-57bd1c578847@oracle.com> Vote: yes Best regards, Vladimir Ivanov On 18/12/2018 05:11, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. From daniel.fuchs at oracle.com Tue Dec 18 18:16:45 2018 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Tue, 18 Dec 2018 19:16:45 +0100 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <37f87641-73b2-69a8-4ab9-3dc03e644431@oracle.com> Vote: yes best regards, -- daniel On 18/12/2018 14:11, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. From jessica at geneious.com Tue Dec 18 20:49:53 2018 From: jessica at geneious.com (Jessica Leigh) Date: Wed, 19 Dec 2018 09:49:53 +1300 Subject: Apple Notarization Message-ID: I'm investigating the process of getting an application "notarized" for Mac OS. This is a process that Apple has introduced with Mac OS 10.14 Mojave, and they've indicated that it will be required for developer-signed applications in the near future. The process differs from code signing (applications are uploaded to Apple, where they're scanned and either notarized or rejected). More information is available from Apple: https://developer.apple.com/documentation/security/notarizing_your_app_before_distribution Our software is bundled with Java 11, and my attempts to find information on notarizing Java applications led me to some Stack Overflow questions that suggest there may be problems with JAR files, e.g., https://stackoverflow.com/questions/53439639/notarize-java-app-for-distribution-on-mac-app-store , where dynamic libraries inside JARs aren't signed, which causes notarization to fail. Has any thought been put into preparing/signing Java for the purpose of notarization? It seems like Java might not be ready for this yet. *Dr. Jessica Leigh*Software Developer GENEIOUS From david.holmes at oracle.com Tue Dec 18 22:22:14 2018 From: david.holmes at oracle.com (David Holmes) Date: Wed, 19 Dec 2018 08:22:14 +1000 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: Vote: yes David On 18/12/2018 11:11 pm, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination.??Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From jesper.wilhelmsson at oracle.com Tue Dec 18 22:47:56 2018 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Tue, 18 Dec 2018 23:47:56 +0100 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <36EED953-B64C-4BE7-9616-B9E0D098B7F7@oracle.com> Vote: yes /Jesper > 18 dec. 2018 kl. 14:11 skrev Markus Gronlund : > > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From hs at tagtraum.com Wed Dec 19 06:19:51 2018 From: hs at tagtraum.com (Hendrik Schreiber) Date: Wed, 19 Dec 2018 07:19:51 +0100 Subject: Apple Notarization In-Reply-To: References: Message-ID: <2A7D882A-3179-40D0-BE54-9F92992C35EF@tagtraum.com> Thanks, Jessica for asking this. I was wondering about the same thing, but unfortunately do not have an answer. -hendrik > On Dec 18, 2018, at 21:49, Jessica Leigh wrote: > > I'm investigating the process of getting an application "notarized" for Mac > OS. This is a process that Apple has introduced with Mac OS 10.14 Mojave, > and they've indicated that it will be required for developer-signed > applications in the near future. The process differs from code signing > (applications are uploaded to Apple, where they're scanned and either > notarized or rejected). More information is available from Apple: > https://developer.apple.com/documentation/security/notarizing_your_app_before_distribution > > Our software is bundled with Java 11, and my attempts to find information > on notarizing Java applications led me to some Stack Overflow questions > that suggest there may be problems with JAR files, e.g., > https://stackoverflow.com/questions/53439639/notarize-java-app-for-distribution-on-mac-app-store > , where dynamic libraries inside JARs aren't signed, which causes > notarization to fail. > > Has any thought been put into preparing/signing Java for the purpose of > notarization? It seems like Java might not be ready for this yet. > > > > *Dr. Jessica Leigh*Software Developer > GENEIOUS From per.liden at oracle.com Wed Dec 19 08:23:06 2018 From: per.liden at oracle.com (Per Liden) Date: Wed, 19 Dec 2018 09:23:06 +0100 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <9295589d-4362-1320-bb6e-1e185d3270fc@oracle.com> Vote: yes /Per On 12/18/18 2:11 PM, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination.??Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From aph at redhat.com Wed Dec 19 10:04:36 2018 From: aph at redhat.com (Andrew Haley) Date: Wed, 19 Dec 2018 10:04:36 +0000 Subject: Missing submit notifications? In-Reply-To: <98642BED-3586-4BF4-92CA-05EC8565D594@oracle.com> References: <07cb5153-fa84-5951-1e6f-85bbf608ef69@redhat.com> <87e94894-e7ad-2c1e-c529-47de0b6afae1@oracle.com> <1d07df07-cfbf-bbe6-f761-a114c7385d6a@redhat.com> <13ca1b09-fe5c-9b6e-637a-40b4a9b53c75@redhat.com> <146668ae-4175-464b-c63e-4107b136966c@oracle.com> <0F5A3D9D-6C22-4288-B6AF-E81259963669@oracle.com> <98642BED-3586-4BF4-92CA-05EC8565D594@oracle.com> Message-ID: <36fa29f4-adad-89ed-eb70-47836ff4e576@redhat.com> On 12/18/18 2:33 PM, Stanislav Smirnov wrote: > Andrew, I think I found it, JDK-8215100. > It failed to submit because of the ?author? value you specified, ?Andrew Haley ?. Oh! Silly me. Sorry. > Can you please either use your email or just your user name, like you did in the previous changeset where you backed out a changeset? Will do. -- Andrew Haley Java Platform Lead Engineer Red Hat UK Ltd. EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From stefan.johansson at oracle.com Wed Dec 19 13:12:11 2018 From: stefan.johansson at oracle.com (Stefan Johansson) Date: Wed, 19 Dec 2018 14:12:11 +0100 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: Vote: yes On 2018-12-18 14:11, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination.??Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From robbin.ehn at oracle.com Wed Dec 19 13:29:11 2018 From: robbin.ehn at oracle.com (Robbin Ehn) Date: Wed, 19 Dec 2018 14:29:11 +0100 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <6491ee14-c08f-4ac6-1105-1225c96a1e43@oracle.com> Vote: yes /Robbin On 2018-12-18 14:11, Markus Gronlund wrote: > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. > > Erik is a member of the Hotspot Runtime group and has contributed over 60 changesets [1]. > > Erik has primarily been working on JDK Flight Recorder, which he helped deliver as part of JEP 328 [2]. > > Votes are due by January 8, 2019 (extending voting period over holiday season). > > Only current JDK Reviewers [3] are eligible to vote on this nomination.??Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Markus > > [1] http://hg.openjdk.java.net/jdk/jdk/log?revcount=200&rev=(author(egahlin)+or+desc(%22erik.gahlin%40oracle.com%22))+and+not+merge() > [2] http://openjdk.java.net/jeps/328 > [3] http://openjdk.java.net/census > [4] http://openjdk.java.net/projects/#reviewer-vote > From adam.petcher at oracle.com Wed Dec 19 18:43:20 2018 From: adam.petcher at oracle.com (Adam Petcher) Date: Wed, 19 Dec 2018 13:43:20 -0500 Subject: RFR 8215643: Microbenchmarks for KeyAgreement and Cipher Message-ID: <1cf22fe3-3c8b-7a24-6551-5b48c728d509@oracle.com> Webrev: http://cr.openjdk.java.net/~apetcher/8215643/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8215643 Please review this enhancement that adds two new crypto microbenchmarks. See the JBS ticket for the motivation behind these new benchmarks. The Cipher benchmark nearly duplicates some existing AES benchmarks, though the measurement is done differently in order to also address JDK-8214800[1]. I didn't want to upset anything by removing the existing AES benchmarks, but I'm interested in advice on how we should handle this duplication. [1] https://bugs.openjdk.java.net/browse/JDK-8214800 From mark.reinhold at oracle.com Wed Dec 19 18:52:40 2018 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Wed, 19 Dec 2018 10:52:40 -0800 Subject: JEP proposed to drop from JDK 12: 326: Raw String Literals (Preview) In-Reply-To: <20181211091323.596696203@eggemoggin.niobe.net> References: <20181211091323.596696203@eggemoggin.niobe.net> Message-ID: <20181219105240.868003102@eggemoggin.niobe.net> 2018/12/11 9:13:23 -0800, mark.reinhold at oracle.com: > The owner of this JEP has proposed to drop it from JDK 12: > > 326: Raw String Literals (Preview) > http://openjdk.java.net/jeps/326 > > The rationale for this proposal will follow in a moment. > > Feedback on this proposal from JDK Project Committers and Reviewers [1] > is more than welcome, as are reasoned objections. If no such objections > are raised by 23:00 UTC on Tuesday, 18 December, or if they?re raised > and then satisfactorily answered, then per the JEP 2.0 process proposal > [2] I?ll drop this JEP from JDK 12. Hearing no objections, I?ve dropped this JEP from JDK 12. - Mark From alexandre.iline at oracle.com Wed Dec 19 19:44:02 2018 From: alexandre.iline at oracle.com (Alexandre (Shura) Iline) Date: Wed, 19 Dec 2018 11:44:02 -0800 Subject: Results: CFV: New JDK Committer: Abdul Muneer Kolarkunnu Message-ID: <69A94A0C-14E1-46A1-AB39-96E040E95299@oracle.com> Voting for Abdul Muneer Kolarkunnu [1] is now closed. Yes: 29 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Thanks, Alexander (Shura) Ilin [1] http://mail.openjdk.java.net/pipermail/jdk-dev/2018-December/002291.html From tres.finocchiaro at gmail.com Wed Dec 19 17:38:55 2018 From: tres.finocchiaro at gmail.com (Tres Finocchiaro) Date: Wed, 19 Dec 2018 12:38:55 -0500 Subject: Apple Notarization Message-ID: I was linked to this conversation from a stackoverflow comment and wanted to offer my experiences. I hope this message is well received. I have a project with bundled 3rd party DYLIBs and has passed Apple notarization. I'm doing it by extracting the JAR's files, signing them and then JARing them back up. I would assume JavaFX would work just the same. I have my steps outlined in detail here including how to review the rejection from Apple during the trial-and-error phases of notarization: https://stackoverflow.com/a/53528020/3196753 > "Has any thought been put into preparing/signing Java for the purpose of notarization? It seems like Java might not be ready for this yet." Apple doesn't mention whether or not they allow mixed signatures in the bundles. If they do, the OpenJDK team can tackle this. My guess is they're already signing their distributions. You can find out by extracting any offending .dylibs in a bundle. Here's a StackOverflow question which mentions being rejected in JRE11 due to JavaFX libraries: https://stackoverflow.com/q/53439639/3196753 If someone can chime in on whether or not using 3rd party signed DYLIB and JNILIB files is supported, please do. It could make this task much easier (and help move ownness to the 3rd parties) for software developers. To see if its already signed: code sign -dv --verbose=4 /path/to/extracted/libfxplugins.dylib Note, there's a bit of an order-of-operations if a programmer is signing the JAR itself too. You would need to extract the JAR, sign the native code, bundle the JAR, sign the JAR. A build system that relies on signed JARs would break the signature once it's modified. This is increasingly frustrating with 3rd party libraries. Apple may eventually allow traversing into these JARs with the --deep signing option (it's smart enough to do it while validating for notarization) but it wouldn't be smart enough to resign the JAR itself. From serguei.spitsyn at oracle.com Wed Dec 19 23:38:15 2018 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 19 Dec 2018 15:38:15 -0800 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <33d8b90a-27a1-337b-b0c5-4b9d5169eea8@oracle.com> Void: yes From serguei.spitsyn at oracle.com Wed Dec 19 23:43:13 2018 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 19 Dec 2018 15:43:13 -0800 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: <33d8b90a-27a1-337b-b0c5-4b9d5169eea8@oracle.com> References: <33d8b90a-27a1-337b-b0c5-4b9d5169eea8@oracle.com> Message-ID: <1e1c6987-68c2-3ce2-c2fb-ed5f31ec7254@oracle.com> It was a typo below - sorry! Of course, I wanted to say: Vote: yes Thanks, Serguei On 12/19/18 15:38, serguei.spitsyn at oracle.com wrote: > Void: yes From igor.ignatyev at oracle.com Thu Dec 20 00:03:02 2018 From: igor.ignatyev at oracle.com (Igor Ignatyev) Date: Wed, 19 Dec 2018 16:03:02 -0800 Subject: CFV: New JDK Reviewer: Erik Gahlin In-Reply-To: References: Message-ID: <6C041080-9905-4525-A06A-110D611914EA@oracle.com> Vote: yes -- Igor > On Dec 18, 2018, at 5:11 AM, Markus Gronlund wrote: > > I hearby nominate Erik Gahlin (egahlin) to JDK Project Reviewer. From Roger.Riggs at oracle.com Fri Dec 21 15:33:08 2018 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Fri, 21 Dec 2018 10:33:08 -0500 Subject: Results: New JDK Committer: Chris Yin Message-ID: <3320b5f7-a411-dd78-cedd-6ef2a2cc4e3f@oracle.com> Voting for Chris Yin [1] is now closed. Yes: 22 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Happy Holidays, Roger Riggs [1] http://mail.openjdk.java.net/pipermail/jdk-dev/2018-December/002313.html From stuart.marks at oracle.com Fri Dec 21 19:30:27 2018 From: stuart.marks at oracle.com (Stuart Marks) Date: Fri, 21 Dec 2018 11:30:27 -0800 Subject: Result: New JDK Committer: Tagir Valeev Message-ID: Voting for Tagir Valeev (tvaleev) [1] is now closed. Yes: 30 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Congratulations, Tagir! s'marks [1] http://mail.openjdk.java.net/pipermail/jdk-dev/2018-December/002344.html From fujie at loongson.cn Thu Dec 27 12:56:22 2018 From: fujie at loongson.cn (Fu Jie) Date: Thu, 27 Dec 2018 20:56:22 +0800 Subject: NetBeans pre-build failed due to the incorrect configuration Message-ID: <18503e19-f0b7-19f4-9e7e-6ae8f57b2c52@loongson.cn> Hi all, OpenJDK build with NetBeans failed during the pre-build process. The reason is that configuration in make/nb_native/nbproject/configurations.xml is wrong. The setting that leads to the failure is: ?????? sh ../configure --with-debug-level=slowdebug --disable-zip-debug-info Two pionts were wrong here: ?1) the path of configure script specified was incorrect which should just be "sh configure" instead of "sh ../configure". ?2) deprecated --disable-zip-debug-info was used which is now an unrecognized option. The pre-build succeeded with the following configuration. For more info., see [1]. ?????? sh configure --with-debug-level=slowdebug Further more, there are too many invalid items in make/nb_native/nbproject/configurations.xml. For example This item is invalid since advancedThresholdPolicy.cpp had been removed from the project. ---------------------------------------------------------------------------- ??????? ??????? ---------------------------------------------------------------------------- For more invalid items, see [2]. To fix the issues, make/nb_native/nbproject/configurations.xml needs to be updated. And I made a patch[3] for this. Could anyone help to review it? Thank you! [1] https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-prebuild-failed.md [2] https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-invalid-config-items.md [3] https://github.com/DamonFool/MyWorkspace/blob/master/others/nb-config.diff Best regards, Fu Jie From david.holmes at oracle.com Thu Dec 27 13:01:20 2018 From: david.holmes at oracle.com (David Holmes) Date: Thu, 27 Dec 2018 23:01:20 +1000 Subject: NetBeans pre-build failed due to the incorrect configuration In-Reply-To: <18503e19-f0b7-19f4-9e7e-6ae8f57b2c52@loongson.cn> References: <18503e19-f0b7-19f4-9e7e-6ae8f57b2c52@loongson.cn> Message-ID: <4ce48279-7e62-9f84-b5b7-848ced19fe73@oracle.com> Hi, All patches to OpenJDK must be submitted on OpenJDK infrastructure. This means either hosted on cr.openjdk.java.net or else included inline, or as attachments, to emails to the OpenJDK mailing lists. Patches hosted on github are not acceptable. Thanks, David On 27/12/2018 10:56 pm, Fu Jie wrote: > Hi all, > > > OpenJDK build with NetBeans failed during the pre-build process. > The reason is that configuration in > make/nb_native/nbproject/configurations.xml is wrong. > > The setting that leads to the failure is: > ?????? sh ../configure --with-debug-level=slowdebug > --disable-zip-debug-info > > Two pionts were wrong here: > ?1) the path of configure script specified was incorrect which should > just be "sh configure" instead of "sh ../configure". > ?2) deprecated --disable-zip-debug-info was used which is now an > unrecognized option. > > The pre-build succeeded with the following configuration. For more > info., see [1]. > ?????? sh configure > --with-debug-level=slowdebug > > > Further more, there are too many invalid items in > make/nb_native/nbproject/configurations.xml. For example > This item is invalid since advancedThresholdPolicy.cpp had been removed > from the project. > ---------------------------------------------------------------------------- > > ??????? path="../../src/hotspot/share/runtime/advancedThresholdPolicy.cpp" > ????????????? ex="false" > ????????????? tool="1" > ????????????? flavor2="0"> > ??????? > ---------------------------------------------------------------------------- > > For more invalid items, see [2]. > > > To fix the issues, make/nb_native/nbproject/configurations.xml needs to > be updated. And I made a patch[3] for this. > Could anyone help to review it? Thank you! > > [1] > https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-prebuild-failed.md > [2] > https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-invalid-config-items.md > > [3] > https://github.com/DamonFool/MyWorkspace/blob/master/others/nb-config.diff > > Best regards, > Fu Jie > > From fujie at loongson.cn Fri Dec 28 03:36:31 2018 From: fujie at loongson.cn (Fu Jie) Date: Fri, 28 Dec 2018 11:36:31 +0800 Subject: NetBeans pre-build failed due to the incorrect configuration In-Reply-To: <4ce48279-7e62-9f84-b5b7-848ced19fe73@oracle.com> References: <18503e19-f0b7-19f4-9e7e-6ae8f57b2c52@loongson.cn> <4ce48279-7e62-9f84-b5b7-848ced19fe73@oracle.com> Message-ID: <19393a27-2b69-fc5f-3e7d-fba9866f0442@loongson.cn> Hi David, Thanks for your reply. I had tried to send the patch as an attachment last night, but the mailing lists reminded me that the size of my email with such an attachment was too big. I'm very appreciative of your help. And I'd like to follow your advice to submit the patch again later. Best regards, Jie On 2018/12/27 ??9:01, David Holmes wrote: > Hi, > > All patches to OpenJDK must be submitted on OpenJDK infrastructure. > This means either hosted on cr.openjdk.java.net or else included > inline, or as attachments, to emails to the OpenJDK mailing lists. > Patches hosted on github are not acceptable. > > Thanks, > David > > On 27/12/2018 10:56 pm, Fu Jie wrote: >> Hi all, >> >> >> OpenJDK build with NetBeans failed during the pre-build process. >> The reason is that configuration in >> make/nb_native/nbproject/configurations.xml is wrong. >> >> The setting that leads to the failure is: >> ??????? sh ../configure --with-debug-level=slowdebug >> --disable-zip-debug-info >> >> Two pionts were wrong here: >> ??1) the path of configure script specified was incorrect which >> should just be "sh configure" instead of "sh ../configure". >> ??2) deprecated --disable-zip-debug-info was used which is now an >> unrecognized option. >> >> The pre-build succeeded with the following configuration. For more >> info., see [1]. >> ??????? sh configure >> --with-debug-level=slowdebug >> >> >> Further more, there are too many invalid items in >> make/nb_native/nbproject/configurations.xml. For example >> This item is invalid since advancedThresholdPolicy.cpp had been >> removed from the project. >> ---------------------------------------------------------------------------- >> >> ???????? > path="../../src/hotspot/share/runtime/advancedThresholdPolicy.cpp" >> ?????????????? ex="false" >> ?????????????? tool="1" >> ?????????????? flavor2="0"> >> ???????? >> ---------------------------------------------------------------------------- >> >> For more invalid items, see [2]. >> >> >> To fix the issues, make/nb_native/nbproject/configurations.xml needs >> to be updated. And I made a patch[3] for this. >> Could anyone help to review it? Thank you! >> >> [1] >> https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-prebuild-failed.md >> [2] >> https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-invalid-config-items.md >> >> [3] >> https://github.com/DamonFool/MyWorkspace/blob/master/others/nb-config.diff >> >> Best regards, >> Fu Jie >> >> From david.holmes at oracle.com Fri Dec 28 03:47:15 2018 From: david.holmes at oracle.com (David Holmes) Date: Fri, 28 Dec 2018 13:47:15 +1000 Subject: NetBeans pre-build failed due to the incorrect configuration In-Reply-To: <19393a27-2b69-fc5f-3e7d-fba9866f0442@loongson.cn> References: <18503e19-f0b7-19f4-9e7e-6ae8f57b2c52@loongson.cn> <4ce48279-7e62-9f84-b5b7-848ced19fe73@oracle.com> <19393a27-2b69-fc5f-3e7d-fba9866f0442@loongson.cn> Message-ID: <92179780-9c07-71e7-29e7-3699dfb601c6@oracle.com> On 28/12/2018 1:36 pm, Fu Jie wrote: > Hi David, > > Thanks for your reply. > > I had tried to send the patch as an attachment last night, but the > mailing lists reminded me that the size of my email with such an > attachment was too big. > > I'm very appreciative of your help. And I'd like to follow your advice > to submit the patch again later. Ao Qi has author status now and so can post a webrev on cr.openjdk.java.net. Perhaps they could help you with this patch. They can also file a bug for this issue on https://bugs.openjdk.java.net Thanks, David > Best regards, > > Jie > > > > On 2018/12/27 ??9:01, David Holmes wrote: >> Hi, >> >> All patches to OpenJDK must be submitted on OpenJDK infrastructure. >> This means either hosted on cr.openjdk.java.net or else included >> inline, or as attachments, to emails to the OpenJDK mailing lists. >> Patches hosted on github are not acceptable. >> >> Thanks, >> David >> >> On 27/12/2018 10:56 pm, Fu Jie wrote: >>> Hi all, >>> >>> >>> OpenJDK build with NetBeans failed during the pre-build process. >>> The reason is that configuration in >>> make/nb_native/nbproject/configurations.xml is wrong. >>> >>> The setting that leads to the failure is: >>> ??????? sh ../configure --with-debug-level=slowdebug >>> --disable-zip-debug-info >>> >>> Two pionts were wrong here: >>> ??1) the path of configure script specified was incorrect which >>> should just be "sh configure" instead of "sh ../configure". >>> ??2) deprecated --disable-zip-debug-info was used which is now an >>> unrecognized option. >>> >>> The pre-build succeeded with the following configuration. For more >>> info., see [1]. >>> ??????? sh configure >>> --with-debug-level=slowdebug >>> >>> >>> Further more, there are too many invalid items in >>> make/nb_native/nbproject/configurations.xml. For example >>> This item is invalid since advancedThresholdPolicy.cpp had been >>> removed from the project. >>> ---------------------------------------------------------------------------- >>> >>> ???????? >> path="../../src/hotspot/share/runtime/advancedThresholdPolicy.cpp" >>> ?????????????? ex="false" >>> ?????????????? tool="1" >>> ?????????????? flavor2="0"> >>> ???????? >>> ---------------------------------------------------------------------------- >>> >>> For more invalid items, see [2]. >>> >>> >>> To fix the issues, make/nb_native/nbproject/configurations.xml needs >>> to be updated. And I made a patch[3] for this. >>> Could anyone help to review it? Thank you! >>> >>> [1] >>> https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-prebuild-failed.md >>> >>> [2] >>> https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-invalid-config-items.md >>> >>> [3] >>> https://github.com/DamonFool/MyWorkspace/blob/master/others/nb-config.diff >>> >>> >>> Best regards, >>> Fu Jie >>> >>> > From fujie at loongson.cn Fri Dec 28 04:42:55 2018 From: fujie at loongson.cn (Fu Jie) Date: Fri, 28 Dec 2018 12:42:55 +0800 Subject: NetBeans pre-build failed due to the incorrect configuration In-Reply-To: <92179780-9c07-71e7-29e7-3699dfb601c6@oracle.com> References: <18503e19-f0b7-19f4-9e7e-6ae8f57b2c52@loongson.cn> <4ce48279-7e62-9f84-b5b7-848ced19fe73@oracle.com> <19393a27-2b69-fc5f-3e7d-fba9866f0442@loongson.cn> <92179780-9c07-71e7-29e7-3699dfb601c6@oracle.com> Message-ID: <94950d65-f717-5dd4-9178-9e3981463fac@loongson.cn> Nice. Many thanks to you David. Best regards, Jie On 2018/12/28 ??11:47, David Holmes wrote: > On 28/12/2018 1:36 pm, Fu Jie wrote: >> Hi David, >> >> Thanks for your reply. >> >> I had tried to send the patch as an attachment last night, but the >> mailing lists reminded me that the size of my email with such an >> attachment was too big. >> >> I'm very appreciative of your help. And I'd like to follow your >> advice to submit the patch again later. > > Ao Qi has author status now and so can post a webrev on > cr.openjdk.java.net. Perhaps they could help you with this patch. They > can also file a bug for this issue on https://bugs.openjdk.java.net > > Thanks, > David > >> Best regards, >> >> Jie >> >> >> >> On 2018/12/27 ??9:01, David Holmes wrote: >>> Hi, >>> >>> All patches to OpenJDK must be submitted on OpenJDK infrastructure. >>> This means either hosted on cr.openjdk.java.net or else included >>> inline, or as attachments, to emails to the OpenJDK mailing lists. >>> Patches hosted on github are not acceptable. >>> >>> Thanks, >>> David >>> >>> On 27/12/2018 10:56 pm, Fu Jie wrote: >>>> Hi all, >>>> >>>> >>>> OpenJDK build with NetBeans failed during the pre-build process. >>>> The reason is that configuration in >>>> make/nb_native/nbproject/configurations.xml is wrong. >>>> >>>> The setting that leads to the failure is: >>>> ??????? sh ../configure >>>> --with-debug-level=slowdebug >>>> --disable-zip-debug-info >>>> >>>> Two pionts were wrong here: >>>> ??1) the path of configure script specified was incorrect which >>>> should just be "sh configure" instead of "sh ../configure". >>>> ??2) deprecated --disable-zip-debug-info was used which is now an >>>> unrecognized option. >>>> >>>> The pre-build succeeded with the following configuration. For more >>>> info., see [1]. >>>> ??????? sh configure >>>> --with-debug-level=slowdebug >>>> >>>> >>>> Further more, there are too many invalid items in >>>> make/nb_native/nbproject/configurations.xml. For example >>>> This item is invalid since advancedThresholdPolicy.cpp had been >>>> removed from the project. >>>> ---------------------------------------------------------------------------- >>>> >>>> ???????? >>> path="../../src/hotspot/share/runtime/advancedThresholdPolicy.cpp" >>>> ?????????????? ex="false" >>>> ?????????????? tool="1" >>>> ?????????????? flavor2="0"> >>>> ???????? >>>> ---------------------------------------------------------------------------- >>>> >>>> For more invalid items, see [2]. >>>> >>>> >>>> To fix the issues, make/nb_native/nbproject/configurations.xml >>>> needs to be updated. And I made a patch[3] for this. >>>> Could anyone help to review it? Thank you! >>>> >>>> [1] >>>> https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-prebuild-failed.md >>>> >>>> [2] >>>> https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-invalid-config-items.md >>>> >>>> [3] >>>> https://github.com/DamonFool/MyWorkspace/blob/master/others/nb-config.diff >>>> >>>> >>>> Best regards, >>>> Fu Jie >>>> >>>> >> From aoqi at loongson.cn Fri Dec 28 05:44:42 2018 From: aoqi at loongson.cn (Ao Qi) Date: Fri, 28 Dec 2018 13:44:42 +0800 Subject: NetBeans pre-build failed due to the incorrect configuration In-Reply-To: <94950d65-f717-5dd4-9178-9e3981463fac@loongson.cn> References: <18503e19-f0b7-19f4-9e7e-6ae8f57b2c52@loongson.cn> <4ce48279-7e62-9f84-b5b7-848ced19fe73@oracle.com> <19393a27-2b69-fc5f-3e7d-fba9866f0442@loongson.cn> <92179780-9c07-71e7-29e7-3699dfb601c6@oracle.com> <94950d65-f717-5dd4-9178-9e3981463fac@loongson.cn> Message-ID: Hi, I have filed a bug and posted the patch. Bug: https://bugs.openjdk.java.net/browse/JDK-8215952 Webrev: http://cr.openjdk.java.net/~aoqi/8215952/webrev.00/ This is my first time to do this. If there is something wrong, suggestion and correction are welcome:) Cheers, Ao Qi On Fri, Dec 28, 2018 at 12:42 PM Fu Jie wrote: > > Nice. > > Many thanks to you David. > > > Best regards, > Jie > > On 2018/12/28 ??11:47, David Holmes wrote: > > On 28/12/2018 1:36 pm, Fu Jie wrote: > >> Hi David, > >> > >> Thanks for your reply. > >> > >> I had tried to send the patch as an attachment last night, but the > >> mailing lists reminded me that the size of my email with such an > >> attachment was too big. > >> > >> I'm very appreciative of your help. And I'd like to follow your > >> advice to submit the patch again later. > > > > Ao Qi has author status now and so can post a webrev on > > cr.openjdk.java.net. Perhaps they could help you with this patch. They > > can also file a bug for this issue on https://bugs.openjdk.java.net > > > > Thanks, > > David > > > >> Best regards, > >> > >> Jie > >> > >> > >> > >> On 2018/12/27 ??9:01, David Holmes wrote: > >>> Hi, > >>> > >>> All patches to OpenJDK must be submitted on OpenJDK infrastructure. > >>> This means either hosted on cr.openjdk.java.net or else included > >>> inline, or as attachments, to emails to the OpenJDK mailing lists. > >>> Patches hosted on github are not acceptable. > >>> > >>> Thanks, > >>> David > >>> > >>> On 27/12/2018 10:56 pm, Fu Jie wrote: > >>>> Hi all, > >>>> > >>>> > >>>> OpenJDK build with NetBeans failed during the pre-build process. > >>>> The reason is that configuration in > >>>> make/nb_native/nbproject/configurations.xml is wrong. > >>>> > >>>> The setting that leads to the failure is: > >>>> sh ../configure > >>>> --with-debug-level=slowdebug > >>>> --disable-zip-debug-info > >>>> > >>>> Two pionts were wrong here: > >>>> 1) the path of configure script specified was incorrect which > >>>> should just be "sh configure" instead of "sh ../configure". > >>>> 2) deprecated --disable-zip-debug-info was used which is now an > >>>> unrecognized option. > >>>> > >>>> The pre-build succeeded with the following configuration. For more > >>>> info., see [1]. > >>>> sh configure > >>>> --with-debug-level=slowdebug > >>>> > >>>> > >>>> Further more, there are too many invalid items in > >>>> make/nb_native/nbproject/configurations.xml. For example > >>>> This item is invalid since advancedThresholdPolicy.cpp had been > >>>> removed from the project. > >>>> ---------------------------------------------------------------------------- > >>>> > >>>> >>>> path="../../src/hotspot/share/runtime/advancedThresholdPolicy.cpp" > >>>> ex="false" > >>>> tool="1" > >>>> flavor2="0"> > >>>> > >>>> ---------------------------------------------------------------------------- > >>>> > >>>> For more invalid items, see [2]. > >>>> > >>>> > >>>> To fix the issues, make/nb_native/nbproject/configurations.xml > >>>> needs to be updated. And I made a patch[3] for this. > >>>> Could anyone help to review it? Thank you! > >>>> > >>>> [1] > >>>> https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-prebuild-failed.md > >>>> > >>>> [2] > >>>> https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-invalid-config-items.md > >>>> > >>>> [3] > >>>> https://github.com/DamonFool/MyWorkspace/blob/master/others/nb-config.diff > >>>> > >>>> > >>>> Best regards, > >>>> Fu Jie > >>>> > >>>> > >> > From fujie at loongson.cn Fri Dec 28 06:34:04 2018 From: fujie at loongson.cn (Fu Jie) Date: Fri, 28 Dec 2018 14:34:04 +0800 Subject: RFR: JDK-8215952: NetBeans pre-build failed due to the incorrect configuration In-Reply-To: References: <18503e19-f0b7-19f4-9e7e-6ae8f57b2c52@loongson.cn> <4ce48279-7e62-9f84-b5b7-848ced19fe73@oracle.com> <19393a27-2b69-fc5f-3e7d-fba9866f0442@loongson.cn> <92179780-9c07-71e7-29e7-3699dfb601c6@oracle.com> <94950d65-f717-5dd4-9178-9e3981463fac@loongson.cn> Message-ID: <29e9153a-0bcd-ee27-9e22-9496809a72a9@loongson.cn> Hi, Please review this patch for a build failure with NetBeans: Bug: https://bugs.openjdk.java.net/browse/JDK-8215952 Webrev: http://cr.openjdk.java.net/~aoqi/8215952/webrev.00/ Summary The build failure is caused by an incorrect setting of preBuildCommand in make/nb_native/nbproject/configurations.xml. And all invalid source code items in configurations.xml have been removed. Testing OpenJDK build with NetBeans now pass. Many thanks to David and Ao Qi. Best regards, Jie On 2018/12/28 ??1:44, Ao Qi wrote: > Hi, > > I have filed a bug and posted the patch. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8215952 > > Webrev: http://cr.openjdk.java.net/~aoqi/8215952/webrev.00/ > > This is my first time to do this. If there is something wrong, > suggestion and correction are welcome:) > > Cheers, > Ao Qi > > On Fri, Dec 28, 2018 at 12:42 PM Fu Jie wrote: >> Nice. >> >> Many thanks to you David. >> >> >> Best regards, >> Jie >> >> On 2018/12/28 ??11:47, David Holmes wrote: >>> On 28/12/2018 1:36 pm, Fu Jie wrote: >>>> Hi David, >>>> >>>> Thanks for your reply. >>>> >>>> I had tried to send the patch as an attachment last night, but the >>>> mailing lists reminded me that the size of my email with such an >>>> attachment was too big. >>>> >>>> I'm very appreciative of your help. And I'd like to follow your >>>> advice to submit the patch again later. >>> Ao Qi has author status now and so can post a webrev on >>> cr.openjdk.java.net. Perhaps they could help you with this patch. They >>> can also file a bug for this issue on https://bugs.openjdk.java.net >>> >>> Thanks, >>> David >>> >>>> Best regards, >>>> >>>> Jie >>>> >>>> >>>> >>>> On 2018/12/27 ??9:01, David Holmes wrote: >>>>> Hi, >>>>> >>>>> All patches to OpenJDK must be submitted on OpenJDK infrastructure. >>>>> This means either hosted on cr.openjdk.java.net or else included >>>>> inline, or as attachments, to emails to the OpenJDK mailing lists. >>>>> Patches hosted on github are not acceptable. >>>>> >>>>> Thanks, >>>>> David >>>>> >>>>> On 27/12/2018 10:56 pm, Fu Jie wrote: >>>>>> Hi all, >>>>>> >>>>>> >>>>>> OpenJDK build with NetBeans failed during the pre-build process. >>>>>> The reason is that configuration in >>>>>> make/nb_native/nbproject/configurations.xml is wrong. >>>>>> >>>>>> The setting that leads to the failure is: >>>>>> sh ../configure >>>>>> --with-debug-level=slowdebug >>>>>> --disable-zip-debug-info >>>>>> >>>>>> Two pionts were wrong here: >>>>>> 1) the path of configure script specified was incorrect which >>>>>> should just be "sh configure" instead of "sh ../configure". >>>>>> 2) deprecated --disable-zip-debug-info was used which is now an >>>>>> unrecognized option. >>>>>> >>>>>> The pre-build succeeded with the following configuration. For more >>>>>> info., see [1]. >>>>>> sh configure >>>>>> --with-debug-level=slowdebug >>>>>> >>>>>> >>>>>> Further more, there are too many invalid items in >>>>>> make/nb_native/nbproject/configurations.xml. For example >>>>>> This item is invalid since advancedThresholdPolicy.cpp had been >>>>>> removed from the project. >>>>>> ---------------------------------------------------------------------------- >>>>>> >>>>>> >>>>> path="../../src/hotspot/share/runtime/advancedThresholdPolicy.cpp" >>>>>> ex="false" >>>>>> tool="1" >>>>>> flavor2="0"> >>>>>> >>>>>> ---------------------------------------------------------------------------- >>>>>> >>>>>> For more invalid items, see [2]. >>>>>> >>>>>> >>>>>> To fix the issues, make/nb_native/nbproject/configurations.xml >>>>>> needs to be updated. And I made a patch[3] for this. >>>>>> Could anyone help to review it? Thank you! >>>>>> >>>>>> [1] >>>>>> https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-prebuild-failed.md >>>>>> >>>>>> [2] >>>>>> https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-invalid-config-items.md >>>>>> >>>>>> [3] >>>>>> https://github.com/DamonFool/MyWorkspace/blob/master/others/nb-config.diff >>>>>> >>>>>> >>>>>> Best regards, >>>>>> Fu Jie >>>>>> >>>>>> From magnus.ihse.bursie at oracle.com Sat Dec 29 20:12:46 2018 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Sat, 29 Dec 2018 21:12:46 +0100 Subject: RFR: JDK-8215952: NetBeans pre-build failed due to the incorrect configuration In-Reply-To: <29e9153a-0bcd-ee27-9e22-9496809a72a9@loongson.cn> References: <18503e19-f0b7-19f4-9e7e-6ae8f57b2c52@loongson.cn> <4ce48279-7e62-9f84-b5b7-848ced19fe73@oracle.com> <19393a27-2b69-fc5f-3e7d-fba9866f0442@loongson.cn> <92179780-9c07-71e7-29e7-3699dfb601c6@oracle.com> <94950d65-f717-5dd4-9178-9e3981463fac@loongson.cn> <29e9153a-0bcd-ee27-9e22-9496809a72a9@loongson.cn> Message-ID: It's difficult to really review such a patch, but I skimmed through it and it looks reasonable. If it makes netbeans work for you, I'm ok with it. /Magnus > 28 dec. 2018 kl. 07:34 skrev Fu Jie : > > Hi, > > Please review this patch for a build failure with NetBeans: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8215952 > Webrev: http://cr.openjdk.java.net/~aoqi/8215952/webrev.00/ > > Summary > The build failure is caused by an incorrect setting of preBuildCommand in make/nb_native/nbproject/configurations.xml. > And all invalid source code items in configurations.xml have been removed. > > Testing > OpenJDK build with NetBeans now pass. > > > Many thanks to David and Ao Qi. > > Best regards, > Jie > > >> On 2018/12/28 ??1:44, Ao Qi wrote: >> Hi, >> >> I have filed a bug and posted the patch. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8215952 >> >> Webrev: http://cr.openjdk.java.net/~aoqi/8215952/webrev.00/ >> >> This is my first time to do this. If there is something wrong, >> suggestion and correction are welcome:) >> >> Cheers, >> Ao Qi >> >>> On Fri, Dec 28, 2018 at 12:42 PM Fu Jie wrote: >>> Nice. >>> >>> Many thanks to you David. >>> >>> >>> Best regards, >>> Jie >>> >>>> On 2018/12/28 ??11:47, David Holmes wrote: >>>>> On 28/12/2018 1:36 pm, Fu Jie wrote: >>>>> Hi David, >>>>> >>>>> Thanks for your reply. >>>>> >>>>> I had tried to send the patch as an attachment last night, but the >>>>> mailing lists reminded me that the size of my email with such an >>>>> attachment was too big. >>>>> >>>>> I'm very appreciative of your help. And I'd like to follow your >>>>> advice to submit the patch again later. >>>> Ao Qi has author status now and so can post a webrev on >>>> cr.openjdk.java.net. Perhaps they could help you with this patch. They >>>> can also file a bug for this issue on https://bugs.openjdk.java.net >>>> >>>> Thanks, >>>> David >>>> >>>>> Best regards, >>>>> >>>>> Jie >>>>> >>>>> >>>>> >>>>>> On 2018/12/27 ??9:01, David Holmes wrote: >>>>>> Hi, >>>>>> >>>>>> All patches to OpenJDK must be submitted on OpenJDK infrastructure. >>>>>> This means either hosted on cr.openjdk.java.net or else included >>>>>> inline, or as attachments, to emails to the OpenJDK mailing lists. >>>>>> Patches hosted on github are not acceptable. >>>>>> >>>>>> Thanks, >>>>>> David >>>>>> >>>>>>> On 27/12/2018 10:56 pm, Fu Jie wrote: >>>>>>> Hi all, >>>>>>> >>>>>>> >>>>>>> OpenJDK build with NetBeans failed during the pre-build process. >>>>>>> The reason is that configuration in >>>>>>> make/nb_native/nbproject/configurations.xml is wrong. >>>>>>> >>>>>>> The setting that leads to the failure is: >>>>>>> sh ../configure >>>>>>> --with-debug-level=slowdebug >>>>>>> --disable-zip-debug-info >>>>>>> >>>>>>> Two pionts were wrong here: >>>>>>> 1) the path of configure script specified was incorrect which >>>>>>> should just be "sh configure" instead of "sh ../configure". >>>>>>> 2) deprecated --disable-zip-debug-info was used which is now an >>>>>>> unrecognized option. >>>>>>> >>>>>>> The pre-build succeeded with the following configuration. For more >>>>>>> info., see [1]. >>>>>>> sh configure >>>>>>> --with-debug-level=slowdebug >>>>>>> >>>>>>> >>>>>>> Further more, there are too many invalid items in >>>>>>> make/nb_native/nbproject/configurations.xml. For example >>>>>>> This item is invalid since advancedThresholdPolicy.cpp had been >>>>>>> removed from the project. >>>>>>> ---------------------------------------------------------------------------- >>>>>>> >>>>>>> >>>>>> path="../../src/hotspot/share/runtime/advancedThresholdPolicy.cpp" >>>>>>> ex="false" >>>>>>> tool="1" >>>>>>> flavor2="0"> >>>>>>> >>>>>>> ---------------------------------------------------------------------------- >>>>>>> >>>>>>> For more invalid items, see [2]. >>>>>>> >>>>>>> >>>>>>> To fix the issues, make/nb_native/nbproject/configurations.xml >>>>>>> needs to be updated. And I made a patch[3] for this. >>>>>>> Could anyone help to review it? Thank you! >>>>>>> >>>>>>> [1] >>>>>>> https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-prebuild-failed.md >>>>>>> >>>>>>> [2] >>>>>>> https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-invalid-config-items.md >>>>>>> >>>>>>> [3] >>>>>>> https://github.com/DamonFool/MyWorkspace/blob/master/others/nb-config.diff >>>>>>> >>>>>>> >>>>>>> Best regards, >>>>>>> Fu Jie > From fujie at loongson.cn Sun Dec 30 00:36:52 2018 From: fujie at loongson.cn (Fu Jie) Date: Sun, 30 Dec 2018 08:36:52 +0800 Subject: RFR: JDK-8215952: NetBeans pre-build failed due to the incorrect configuration In-Reply-To: References: <18503e19-f0b7-19f4-9e7e-6ae8f57b2c52@loongson.cn> <4ce48279-7e62-9f84-b5b7-848ced19fe73@oracle.com> <19393a27-2b69-fc5f-3e7d-fba9866f0442@loongson.cn> <92179780-9c07-71e7-29e7-3699dfb601c6@oracle.com> <94950d65-f717-5dd4-9178-9e3981463fac@loongson.cn> <29e9153a-0bcd-ee27-9e22-9496809a72a9@loongson.cn> Message-ID: <44162c66-9dea-053c-750c-767a90836329@loongson.cn> Thanks Magnus. Best regards, Jie On 2018?12?30? 04:12, Magnus Ihse Bursie wrote: > It's difficult to really review such a patch, but I skimmed through it and it looks reasonable. If it makes netbeans work for you, I'm ok with it. > > /Magnus > >> 28 dec. 2018 kl. 07:34 skrev Fu Jie : >> >> Hi, >> >> Please review this patch for a build failure with NetBeans: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8215952 >> Webrev: http://cr.openjdk.java.net/~aoqi/8215952/webrev.00/ >> >> Summary >> The build failure is caused by an incorrect setting of preBuildCommand in make/nb_native/nbproject/configurations.xml. >> And all invalid source code items in configurations.xml have been removed. >> >> Testing >> OpenJDK build with NetBeans now pass. >> >> >> Many thanks to David and Ao Qi. >> >> Best regards, >> Jie >> >> >>> On 2018/12/28 ??1:44, Ao Qi wrote: >>> Hi, >>> >>> I have filed a bug and posted the patch. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8215952 >>> >>> Webrev: http://cr.openjdk.java.net/~aoqi/8215952/webrev.00/ >>> >>> This is my first time to do this. If there is something wrong, >>> suggestion and correction are welcome:) >>> >>> Cheers, >>> Ao Qi >>> >>>> On Fri, Dec 28, 2018 at 12:42 PM Fu Jie wrote: >>>> Nice. >>>> >>>> Many thanks to you David. >>>> >>>> >>>> Best regards, >>>> Jie >>>> >>>>> On 2018/12/28 ??11:47, David Holmes wrote: >>>>>> On 28/12/2018 1:36 pm, Fu Jie wrote: >>>>>> Hi David, >>>>>> >>>>>> Thanks for your reply. >>>>>> >>>>>> I had tried to send the patch as an attachment last night, but the >>>>>> mailing lists reminded me that the size of my email with such an >>>>>> attachment was too big. >>>>>> >>>>>> I'm very appreciative of your help. And I'd like to follow your >>>>>> advice to submit the patch again later. >>>>> Ao Qi has author status now and so can post a webrev on >>>>> cr.openjdk.java.net. Perhaps they could help you with this patch. They >>>>> can also file a bug for this issue on https://bugs.openjdk.java.net >>>>> >>>>> Thanks, >>>>> David >>>>> >>>>>> Best regards, >>>>>> >>>>>> Jie >>>>>> >>>>>> >>>>>> >>>>>>> On 2018/12/27 ??9:01, David Holmes wrote: >>>>>>> Hi, >>>>>>> >>>>>>> All patches to OpenJDK must be submitted on OpenJDK infrastructure. >>>>>>> This means either hosted on cr.openjdk.java.net or else included >>>>>>> inline, or as attachments, to emails to the OpenJDK mailing lists. >>>>>>> Patches hosted on github are not acceptable. >>>>>>> >>>>>>> Thanks, >>>>>>> David >>>>>>> >>>>>>>> On 27/12/2018 10:56 pm, Fu Jie wrote: >>>>>>>> Hi all, >>>>>>>> >>>>>>>> >>>>>>>> OpenJDK build with NetBeans failed during the pre-build process. >>>>>>>> The reason is that configuration in >>>>>>>> make/nb_native/nbproject/configurations.xml is wrong. >>>>>>>> >>>>>>>> The setting that leads to the failure is: >>>>>>>> sh ../configure >>>>>>>> --with-debug-level=slowdebug >>>>>>>> --disable-zip-debug-info >>>>>>>> >>>>>>>> Two pionts were wrong here: >>>>>>>> 1) the path of configure script specified was incorrect which >>>>>>>> should just be "sh configure" instead of "sh ../configure". >>>>>>>> 2) deprecated --disable-zip-debug-info was used which is now an >>>>>>>> unrecognized option. >>>>>>>> >>>>>>>> The pre-build succeeded with the following configuration. For more >>>>>>>> info., see [1]. >>>>>>>> sh configure >>>>>>>> --with-debug-level=slowdebug >>>>>>>> >>>>>>>> >>>>>>>> Further more, there are too many invalid items in >>>>>>>> make/nb_native/nbproject/configurations.xml. For example >>>>>>>> This item is invalid since advancedThresholdPolicy.cpp had been >>>>>>>> removed from the project. >>>>>>>> ---------------------------------------------------------------------------- >>>>>>>> >>>>>>>> >>>>>>> path="../../src/hotspot/share/runtime/advancedThresholdPolicy.cpp" >>>>>>>> ex="false" >>>>>>>> tool="1" >>>>>>>> flavor2="0"> >>>>>>>> >>>>>>>> ---------------------------------------------------------------------------- >>>>>>>> >>>>>>>> For more invalid items, see [2]. >>>>>>>> >>>>>>>> >>>>>>>> To fix the issues, make/nb_native/nbproject/configurations.xml >>>>>>>> needs to be updated. And I made a patch[3] for this. >>>>>>>> Could anyone help to review it? Thank you! >>>>>>>> >>>>>>>> [1] >>>>>>>> https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-prebuild-failed.md >>>>>>>> >>>>>>>> [2] >>>>>>>> https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-invalid-config-items.md >>>>>>>> >>>>>>>> [3] >>>>>>>> https://github.com/DamonFool/MyWorkspace/blob/master/others/nb-config.diff >>>>>>>> >>>>>>>> >>>>>>>> Best regards, >>>>>>>> Fu Jie From krichter at posteo.de Mon Dec 31 19:50:59 2018 From: krichter at posteo.de (Karl-Philipp Richter) Date: Mon, 31 Dec 2018 20:50:59 +0100 Subject: =?UTF-8?Q?Build_failure_=22/mnt/data/home/software/openjdk/src/hots?= =?UTF-8?Q?pot/share/gc/parallel/objectStartArray=2ecpp=3a106=3a56=3a_error?= =?UTF-8?B?OiDigJh2b2lkKiBtZW1zZXQodm9pZCosIGludCwgc2l6ZV90KeKAmSB3cml0aW5n?= =?UTF-8?Q?_to_an_object_of_type_=e2=80=98class_HeapWord=e2=80=99_with_?= =?UTF-8?B?4oCYcHJpdmF0ZeKAmSBtZW1iZXIg4oCYSGVhcFdvcmQ6OmnigJkgWy1XZXJyb3I9?= =?UTF-8?Q?class-memaccess=5d=22?= Message-ID: <1a182b3a-9b3c-6cf9-3cf7-be8d1e7caf01@posteo.de> Hi, Building jdk/jdk on Ubuntu 18.10 fails due to ``` /builds/krichter/openjdk/src/hotspot/share/gc/parallel/objectStartArray.cpp: In member function 'void ObjectStartArray::set_covered_region(MemRegion)': /builds/krichter/openjdk/src/hotspot/share/gc/parallel/objectStartArray.cpp:106:56: error: 'void* memset(void*, int, size_t)' writing to an object of type 'class HeapWord' with 'private' member 'HeapWord::i' [-Werror=class-memaccess] memset(_blocks_region.end(), clean_block, expand_by); ^ In file included from /builds/krichter/openjdk/src/hotspot/share/utilities/align.hpp:28, from /builds/krichter/openjdk/src/hotspot/share/runtime/globals.hpp:29, from /builds/krichter/openjdk/src/hotspot/share/memory/allocation.hpp:28, from /builds/krichter/openjdk/src/hotspot/share/classfile/classLoaderData.hpp:28, from /builds/krichter/openjdk/src/hotspot/share/precompiled/precompiled.hpp:34: /builds/krichter/openjdk/src/hotspot/share/utilities/globalDefinitions.hpp:175:7: note: 'class HeapWord' declared here class HeapWord { ^~~~~~~~ /builds/krichter/openjdk/src/hotspot/share/gc/parallel/objectStartArray.cpp: In member function 'void ObjectStartArray::reset()': /builds/krichter/openjdk/src/hotspot/share/gc/parallel/objectStartArray.cpp:124:73: error: 'void* memset(void*, int, size_t)' writing to an object of type 'class HeapWord' with 'private' member 'HeapWord::i' [-Werror=class-memaccess] memset(_blocks_region.start(), clean_block, _blocks_region.byte_size()); ^ In file included from /builds/krichter/openjdk/src/hotspot/share/utilities/align.hpp:28, from /builds/krichter/openjdk/src/hotspot/share/runtime/globals.hpp:29, from /builds/krichter/openjdk/src/hotspot/share/memory/allocation.hpp:28, from /builds/krichter/openjdk/src/hotspot/share/classfile/classLoaderData.hpp:28, from /builds/krichter/openjdk/src/hotspot/share/precompiled/precompiled.hpp:34: /builds/krichter/openjdk/src/hotspot/share/utilities/globalDefinitions.hpp:175:7: note: 'class HeapWord' declared here class HeapWord { ^~~~~~~~ cc1plus: all warnings being treated as errors make[3]: *** [lib/CompileJvm.gmk:174: /builds/krichter/openjdk/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/objectStartArray.o] Error 1 make[2]: *** [make/Main.gmk:257: hotspot-server-libs] Error 2 ERROR: Build failed for target 'default (exploded-image)' in configuration 'linux-x86_64-server-release' (exit code 2) ``` A detailed build log can be found at https://gitlab.com/krichter/openjdk/-/jobs/140219987. The setup shows the failure for Ubuntu 19.04-daily as well. I can produce the failure on Ubuntu 18.10 locally as well. experienced with jdk-13+1-59-g2472bccc3c7 -Kalle From andrewluotechnologies at outlook.com Mon Dec 31 20:08:48 2018 From: andrewluotechnologies at outlook.com (Andrew Luo) Date: Mon, 31 Dec 2018 20:08:48 +0000 Subject: =?utf-8?B?UkU6IEJ1aWxkIGZhaWx1cmUgIi9tbnQvZGF0YS9ob21lL3NvZnR3YXJlL29w?= =?utf-8?B?ZW5qZGsvc3JjL2hvdHNwb3Qvc2hhcmUvZ2MvcGFyYWxsZWwvb2JqZWN0U3Rh?= =?utf-8?B?cnRBcnJheS5jcHA6MTA2OjU2OiBlcnJvcjog4oCYdm9pZCogbWVtc2V0KHZv?= =?utf-8?B?aWQqLCBpbnQsIHNpemVfdCnigJkgd3JpdGluZyB0byBhbiBvYmplY3Qgb2Yg?= =?utf-8?B?dHlwZSDigJhjbGFzcyBIZWFwV29yZOKAmSB3aXRoIOKAmHByaXZhdGXigJkg?= =?utf-8?B?bWVtYmVyIOKAmEhlYXBXb3JkOjpp4oCZIFstV2Vycm9yPWNsYXNzLW1lbWFj?= =?utf-8?Q?c?= Message-ID: Hi Karl, Can you run gcc --version and tell us the version of GCC that you are using? I'm guessing this was added in a newer version of GCC (class-memaccess was added in GCC 8), and can probably be worked around using -Wno-error=class-memaccess. That's not saying I don't think we should fix this, just suggesting a workaround for now if you want to compile on GCC 8 before this is fixed. Although I believe that per the C++ standard you are allowed to memcpy/memset trivial classes (clang only warns on non-trivial classes: https://reviews.llvm.org/D45310) so GCC's warning seems to be a bit too broad. Are you interested in contributing a fix to this as well - if not I can work on this later this week as well. (By the way, your link https://gitlab.com/krichter/openjdk/-/jobs/140219987 requires signing in). Thanks, -Andrew -----Original Message----- From: jdk-dev On Behalf Of Karl-Philipp Richter Sent: Monday, December 31, 2018 11:51 AM To: jdk-dev at openjdk.java.net Subject: Build failure "/mnt/data/home/software/openjdk/src/hotspot/share/gc/parallel/objectStartArray.cpp:106:56: error: ?void* memset(void*, int, size_t)? writing to an object of type ?class HeapWord? with ?private? member ?HeapWord::i? [-Werror=class-memacce... Hi, Building jdk/jdk on Ubuntu 18.10 fails due to ``` /builds/krichter/openjdk/src/hotspot/share/gc/parallel/objectStartArray.cpp: In member function 'void ObjectStartArray::set_covered_region(MemRegion)': /builds/krichter/openjdk/src/hotspot/share/gc/parallel/objectStartArray.cpp:106:56: error: 'void* memset(void*, int, size_t)' writing to an object of type 'class HeapWord' with 'private' member 'HeapWord::i' [-Werror=class-memaccess] memset(_blocks_region.end(), clean_block, expand_by); ^ In file included from /builds/krichter/openjdk/src/hotspot/share/utilities/align.hpp:28, from /builds/krichter/openjdk/src/hotspot/share/runtime/globals.hpp:29, from /builds/krichter/openjdk/src/hotspot/share/memory/allocation.hpp:28, from /builds/krichter/openjdk/src/hotspot/share/classfile/classLoaderData.hpp:28, from /builds/krichter/openjdk/src/hotspot/share/precompiled/precompiled.hpp:34: /builds/krichter/openjdk/src/hotspot/share/utilities/globalDefinitions.hpp:175:7: note: 'class HeapWord' declared here class HeapWord { ^~~~~~~~ /builds/krichter/openjdk/src/hotspot/share/gc/parallel/objectStartArray.cpp: In member function 'void ObjectStartArray::reset()': /builds/krichter/openjdk/src/hotspot/share/gc/parallel/objectStartArray.cpp:124:73: error: 'void* memset(void*, int, size_t)' writing to an object of type 'class HeapWord' with 'private' member 'HeapWord::i' [-Werror=class-memaccess] memset(_blocks_region.start(), clean_block, _blocks_region.byte_size()); ^ In file included from /builds/krichter/openjdk/src/hotspot/share/utilities/align.hpp:28, from /builds/krichter/openjdk/src/hotspot/share/runtime/globals.hpp:29, from /builds/krichter/openjdk/src/hotspot/share/memory/allocation.hpp:28, from /builds/krichter/openjdk/src/hotspot/share/classfile/classLoaderData.hpp:28, from /builds/krichter/openjdk/src/hotspot/share/precompiled/precompiled.hpp:34: /builds/krichter/openjdk/src/hotspot/share/utilities/globalDefinitions.hpp:175:7: note: 'class HeapWord' declared here class HeapWord { ^~~~~~~~ cc1plus: all warnings being treated as errors make[3]: *** [lib/CompileJvm.gmk:174: /builds/krichter/openjdk/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/objectStartArray.o] Error 1 make[2]: *** [make/Main.gmk:257: hotspot-server-libs] Error 2 ERROR: Build failed for target 'default (exploded-image)' in configuration 'linux-x86_64-server-release' (exit code 2) ``` A detailed build log can be found at https://gitlab.com/krichter/openjdk/-/jobs/140219987. The setup shows the failure for Ubuntu 19.04-daily as well. I can produce the failure on Ubuntu 18.10 locally as well. experienced with jdk-13+1-59-g2472bccc3c7 -Kalle From krichter at posteo.de Mon Dec 31 22:15:59 2018 From: krichter at posteo.de (Karl-Philipp Richter) Date: Mon, 31 Dec 2018 23:15:59 +0100 Subject: =?UTF-8?Q?Re=3a_Build_failure_=22/mnt/data/home/software/openjdk/sr?= =?UTF-8?Q?c/hotspot/share/gc/parallel/objectStartArray=2ecpp=3a106=3a56=3a_?= =?UTF-8?B?ZXJyb3I6IOKAmHZvaWQqIG1lbXNldCh2b2lkKiwgaW50LCBzaXplX3Qp4oCZIHdy?= =?UTF-8?Q?iting_to_an_object_of_type_=e2=80=98class_HeapWord=e2=80=99_with_?= =?UTF-8?B?4oCYcHJpdmF0ZeKAmSBtZW1iZXIg4oCYSGVhcFdvcmQ6OmnigJkgWy1XZXJyb3I9?= =?UTF-8?Q?class-memacc?= In-Reply-To: References: Message-ID: Hi Andrew, Thanks for your quick reply. Am 31.12.18 um 21:08 schrieb Andrew Luo: > Can you run gcc --version and tell us the version of GCC that you are using? My version is gcc (Ubuntu 8.2.0-7ubuntu1) 8.2.0. > I'm guessing this was added in a newer version of GCC (class-memaccess was added in GCC 8), and can probably be worked around using -Wno-error=class-memaccess. That's not saying I don't think we should fix this, just suggesting a workaround for now if you want to compile on GCC 8 before this is fixed. Although I believe that per the C++ standard you are allowed to memcpy/memset trivial classes (clang only warns on non-trivial classes: https://reviews.llvm.org/D45310) so GCC's warning seems to be a bit too broad. `env MAKEFLAGS= bash ./configure --with-extra-cflags=-Wno-error=class-memaccess --with-extra-cxxflags=-Wno-error=class-memaccess && make` avoid the build failure, however the build now fails because of ``` /mnt/data/home/software/openjdk/src/java.base/unix/native/libjli/java_md_solinux.c: In function ?ContinueInNewThread0?: /mnt/data/home/software/openjdk/src/java.base/unix/native/libjli/java_md_solinux.c:747:37: error: cast between incompatible function types from ?int (*)(void *)? to ?void * (*)(void *)? [-Werror=cast-function-type] if (pthread_create(&tid, &attr, (void *(*)(void*))continuation, (void*)args) == 0) { ^ cc1: all warnings being treated as errors make[3]: *** [CoreLibraries.gmk:212: /mnt/data/home/software/openjdk/build/linux-x86_64-server-release/support/native/java.base/libjli/java_md_solinux.o] Fehler 1 make[3]: *** Auf noch nicht beendete Prozesse wird gewartet ? make[2]: *** [make/Main.gmk:215: java.base-libs] Fehler 2 ERROR: Build failed for target 'default (exploded-image)' in configuration 'linux-x86_64-server-release' (exit code 2) ``` I agree that the issue should be fixed. Since Ubuntu is not among the least popular Linux distributions, I recommend a review of your continuous integration system which might need to include more systems. The setup on GitLab is an example to perform these tests easily, but you probably already have already a CI set up which you can extend. Since I don't need to build OpenJDK urgently, I'd rather see these build issues detected and fixed by CI coverage of the build process than stumbling from one to another - it's probably only these two, but afaik that's a lot of a widely use operating system. > Are you interested in contributing a fix to this as well - if not I can work on this later this week as well. I have not enough knowledge to provide a good fix. > (By the way, your link https://gitlab.com/krichter/openjdk/-/jobs/140219987 requires signing in). My bad, fixed. -Kalle From david.holmes at oracle.com Mon Dec 31 23:00:28 2018 From: david.holmes at oracle.com (David Holmes) Date: Tue, 1 Jan 2019 09:00:28 +1000 Subject: =?UTF-8?Q?Re=3a_Build_failure_=22/mnt/data/home/software/openjdk/sr?= =?UTF-8?Q?c/hotspot/share/gc/parallel/objectStartArray=2ecpp=3a106=3a56=3a_?= =?UTF-8?B?ZXJyb3I6IOKAmHZvaWQqIG1lbXNldCh2b2lkKiwgaW50LCBzaXplX3Qp4oCZIHdy?= =?UTF-8?Q?iting_to_an_object_of_type_=e2=80=98class_HeapWord=e2=80=99_with_?= =?UTF-8?B?4oCYcHJpdmF0ZeKAmSBtZW1iZXIg4oCYSGVhcFdvcmQ6OmnigJkgWy1XZXJyb3I9?= =?UTF-8?Q?class-memacc?= In-Reply-To: References: Message-ID: <646893fa-8dfb-152f-48d1-20a0c8903ac8@oracle.com> On 1/01/2019 8:15 am, Karl-Philipp Richter wrote: > Hi Andrew, > Thanks for your quick reply. > > Am 31.12.18 um 21:08 schrieb Andrew Luo: >> Can you run gcc --version and tell us the version of GCC that you are using? > My version is gcc (Ubuntu 8.2.0-7ubuntu1) 8.2.0. > >> I'm guessing this was added in a newer version of GCC (class-memaccess was added in GCC 8), and can probably be worked around using -Wno-error=class-memaccess. That's not saying I don't think we should fix this, just suggesting a workaround for now if you want to compile on GCC 8 before this is fixed. Although I believe that per the C++ standard you are allowed to memcpy/memset trivial classes (clang only warns on non-trivial classes: https://reviews.llvm.org/D45310) so GCC's warning seems to be a bit too broad. > `env MAKEFLAGS= bash ./configure > --with-extra-cflags=-Wno-error=class-memaccess > --with-extra-cxxflags=-Wno-error=class-memaccess && make` avoid the > build failure, however the build now fails because of > > ``` > /mnt/data/home/software/openjdk/src/java.base/unix/native/libjli/java_md_solinux.c: > In function ?ContinueInNewThread0?: > /mnt/data/home/software/openjdk/src/java.base/unix/native/libjli/java_md_solinux.c:747:37: > error: cast between incompatible function types from ?int (*)(void *)? > to ?void * (*)(void *)? [-Werror=cast-function-type] > if (pthread_create(&tid, &attr, (void *(*)(void*))continuation, > (void*)args) == 0) { > ^ This is a known issue already being handled under: https://bugs.openjdk.java.net/browse/JDK-8215009 > cc1: all warnings being treated as errors > make[3]: *** [CoreLibraries.gmk:212: > /mnt/data/home/software/openjdk/build/linux-x86_64-server-release/support/native/java.base/libjli/java_md_solinux.o] > Fehler 1 > make[3]: *** Auf noch nicht beendete Prozesse wird gewartet ? > make[2]: *** [make/Main.gmk:215: java.base-libs] Fehler 2 > > ERROR: Build failed for target 'default (exploded-image)' in > configuration 'linux-x86_64-server-release' (exit code 2) > ``` > > I agree that the issue should be fixed. > > Since Ubuntu is not among the least popular Linux distributions, I > recommend a review of your continuous integration system which might > need to include more systems. OpenJDK has a set of supported compiler versions for building it. While we continually strive to make it build with more recent versions, it's up to the people wanting to build with those compilers to contribute the quick fixes. gcc continually adds new default warnings which lead to build failures; and every new compiler version potentially adds new compiler bugs. Cheers, David ----- > The setup on GitLab is an example to > perform these tests easily, but you probably already have already a CI > set up which you can extend. > > Since I don't need to build OpenJDK urgently, I'd rather see these build > issues detected and fixed by CI coverage of the build process than > stumbling from one to another - it's probably only these two, but afaik > that's a lot of a widely use operating system. > >> Are you interested in contributing a fix to this as well - if not I can work on this later this week as well. > I have not enough knowledge to provide a good fix. > >> (By the way, your link https://gitlab.com/krichter/openjdk/-/jobs/140219987 requires signing in). > My bad, fixed. > > -Kalle > From andrewluotechnologies at outlook.com Mon Dec 31 23:33:59 2018 From: andrewluotechnologies at outlook.com (Andrew Luo) Date: Mon, 31 Dec 2018 23:33:59 +0000 Subject: =?utf-8?B?UkU6IEJ1aWxkIGZhaWx1cmUgIi9tbnQvZGF0YS9ob21lL3NvZnR3YXJlL29w?= =?utf-8?B?ZW5qZGsvc3JjL2hvdHNwb3Qvc2hhcmUvZ2MvcGFyYWxsZWwvb2JqZWN0U3Rh?= =?utf-8?B?cnRBcnJheS5jcHA6MTA2OjU2OiBlcnJvcjog4oCYdm9pZCogbWVtc2V0KHZv?= =?utf-8?B?aWQqLCBpbnQsIHNpemVfdCnigJkgd3JpdGluZyB0byBhbiBvYmplY3Qgb2Yg?= =?utf-8?B?dHlwZSDigJhjbGFzcyBIZWFwV29yZOKAmSB3aXRoIOKAmHByaXZhdGXigJkg?= =?utf-8?B?bWVtYmVyIOKAmEhlYXBXb3JkOjpp4oCZIFstV2Vycm9yPWNsYXNzLW1lbWFj?= =?utf-8?Q?c?= In-Reply-To: <646893fa-8dfb-152f-48d1-20a0c8903ac8@oracle.com> References: <646893fa-8dfb-152f-48d1-20a0c8903ac8@oracle.com> Message-ID: Actually, it seems both these errors are being tracked by a parent bug: https://bugs.openjdk.java.net/browse/JDK-8213153 Thanks, -Andrew -----Original Message----- From: David Holmes Sent: Monday, December 31, 2018 3:00 PM To: Karl-Philipp Richter ; Andrew Luo ; jdk-dev at openjdk.java.net Subject: Re: Build failure "/mnt/data/home/software/openjdk/src/hotspot/share/gc/parallel/objectStartArray.cpp:106:56: error: ?void* memset(void*, int, size_t)? writing to an object of type ?class HeapWord? with ?private? member ?HeapWord::i? [-Werror=class-memacc On 1/01/2019 8:15 am, Karl-Philipp Richter wrote: > Hi Andrew, > Thanks for your quick reply. > > Am 31.12.18 um 21:08 schrieb Andrew Luo: >> Can you run gcc --version and tell us the version of GCC that you are using? > My version is gcc (Ubuntu 8.2.0-7ubuntu1) 8.2.0. > >> I'm guessing this was added in a newer version of GCC (class-memaccess was added in GCC 8), and can probably be worked around using -Wno-error=class-memaccess. That's not saying I don't think we should fix this, just suggesting a workaround for now if you want to compile on GCC 8 before this is fixed. Although I believe that per the C++ standard you are allowed to memcpy/memset trivial classes (clang only warns on non-trivial classes: https://reviews.llvm.org/D45310) so GCC's warning seems to be a bit too broad. > `env MAKEFLAGS= bash ./configure > --with-extra-cflags=-Wno-error=class-memaccess > --with-extra-cxxflags=-Wno-error=class-memaccess && make` avoid the > build failure, however the build now fails because of > > ``` > /mnt/data/home/software/openjdk/src/java.base/unix/native/libjli/java_md_solinux.c: > In function ?ContinueInNewThread0?: > /mnt/data/home/software/openjdk/src/java.base/unix/native/libjli/java_md_solinux.c:747:37: > error: cast between incompatible function types from ?int (*)(void *)? > to ?void * (*)(void *)? [-Werror=cast-function-type] > if (pthread_create(&tid, &attr, (void *(*)(void*))continuation, > (void*)args) == 0) { > ^ This is a known issue already being handled under: https://bugs.openjdk.java.net/browse/JDK-8215009 > cc1: all warnings being treated as errors > make[3]: *** [CoreLibraries.gmk:212: > /mnt/data/home/software/openjdk/build/linux-x86_64-server-release/supp > ort/native/java.base/libjli/java_md_solinux.o] > Fehler 1 > make[3]: *** Auf noch nicht beendete Prozesse wird gewartet ? > make[2]: *** [make/Main.gmk:215: java.base-libs] Fehler 2 > > ERROR: Build failed for target 'default (exploded-image)' in > configuration 'linux-x86_64-server-release' (exit code 2) ``` > > I agree that the issue should be fixed. > > Since Ubuntu is not among the least popular Linux distributions, I > recommend a review of your continuous integration system which might > need to include more systems. OpenJDK has a set of supported compiler versions for building it. While we continually strive to make it build with more recent versions, it's up to the people wanting to build with those compilers to contribute the quick fixes. gcc continually adds new default warnings which lead to build failures; and every new compiler version potentially adds new compiler bugs. Cheers, David ----- > The setup on GitLab is an example to > perform these tests easily, but you probably already have already a CI > set up which you can extend. > > Since I don't need to build OpenJDK urgently, I'd rather see these > build issues detected and fixed by CI coverage of the build process > than stumbling from one to another - it's probably only these two, but > afaik that's a lot of a widely use operating system. > >> Are you interested in contributing a fix to this as well - if not I can work on this later this week as well. > I have not enough knowledge to provide a good fix. > >> (By the way, your link https://gitlab.com/krichter/openjdk/-/jobs/140219987 requires signing in). > My bad, fixed. > > -Kalle >