[Fwd: code review round 0 for JVM/TI version fix (6849968) and phase assertion (6648438)]
Joseph D. Darcy
Joe.Darcy at Sun.COM
Mon Dec 14 15:07:00 PST 2009
Assuming this has been reviewed and approved by the serviceability team,
you're free to push this into the OpenJDK 6 repo. The current build
number to use is b18.
Daniel D. Daugherty wrote:
> These fixes are ready to be pushed in OpenJDK6. I've already
> done the pushed into HSX-16.1 and HSX-17 (RT_Baseline).
> Please let me know if I can push these...
> -------- Original Message --------
> Subject: code review round 0 for JVM/TI version fix (6849968) and
> phase assertion (6648438)
> Date: Fri, 11 Dec 2009 15:52:38 -0700
> From: Daniel D. Daugherty <Daniel.Daugherty at Sun.COM>
> Reply-To: Daniel.Daugherty at Sun.COM
> To: serviceability-dev at openjdk.java.net
> <serviceability-dev at openjdk.java.net>,
> serviceability-dev-confidential at sun.com
> I have fixes for the following two JVM/TI bugs ready to go:
> 6648438 4/4 src/share/vm/prims/jvmtiEnv.cpp:457
> assert(phase == JVMTI_PHASE_LIVE,"sanity check")
> 6849968 3/3 JVMTI tests fails on jdk5.0 with hs14
> 6849968 fixes a problem where JVM/TI version 1.0 semantics
> were not being used when that version was explicitly
> requested. I fixed 6648438 because it happened to be in the
> same place that I already had to tweak for 6849968. It also
> gets rid of an annoying intermittent fastdebug failure.
> Here is the webrev URL:
> This webrev is relative to the OpenJDK6 version of the code.
> Once approved, these fixes will be pushed to:
> - OpenJDK6 (HSX-14-??)
> - JDK6-Update train (HSX-16-??)
> - OpenJDK7 (HSX-17-??)
> Comments, questions and suggestions are always welcome!
More information about the jdk6-dev