Setting public TestEnv defaults for net/nio tests needing hosts
mark at klomp.org
Thu Jun 4 10:27:50 PDT 2009
On Thu, 2009-06-04 at 17:58 +0100, Alan Bateman wrote:
> It's been on my list to forward-port the TestEnv and test updates to
> jdk7 (just haven't got to it yet).
> The idea with that was that jtreg
> would be run with a properties file that listed the hosts that the tests
> depend on (eg: jtreg -e JTREG_TESTENV=openjdk-hosts.properties). We
> (meaning Joe and I) kinda hoped that would be preferable to patching
> TestEnv but maybe this isn't the case.
That is preferable. That is actually why I made the change. So that no
editing or setting or properties was needed by default, unless you
needed a set different from the public defaults.
> Changing these tests to not
> depend on the telnet port is a good idea as it is hard to find systems
> with that legacy service enabled. Changing the defaults to hosts outside
> of Sun is reasonable in principle but this is going to cause disruption
> for our test teams when running on test systems that will not be able to
> connect to these systems. I need to check into this and also to see if
> openjdk.java.net systems could be used, or maybe just re-visit these
> tests to not depend on other hosts.
Yes, making this as easy as possible for anybody running the tests, so
in principle you don't have to changed or edited anything was the goal.
So the real changes are just to use one standard (echo) port to make it
easier to switch hosts. Make cname.sh not use a hardcoded host. And then
set the defaults so that they work for everybody out of the box against
a set of publicly available machines. Then only people needing to do
tests against non-public machines have to change any settings.
More information about the jdk6-dev