From aph at redhat.com Mon Mar 2 07:36:06 2009 From: aph at redhat.com (Andrew Haley) Date: Mon, 02 Mar 2009 15:36:06 +0000 Subject: Updates: OpenJDK Forum: Contributing into OpenJDK 6 In-Reply-To: <49A80AD5.9080803@sun.com> References: <49A471C9.2010101@sun.com> <49A80AD5.9080803@sun.com> Message-ID: <49ABFCE6.3010100@redhat.com> Hi there, is a recording of the call available? Andrew. From Dalibor.Topic at Sun.COM Mon Mar 2 09:34:08 2009 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Mon, 02 Mar 2009 18:34:08 +0100 Subject: Updates: OpenJDK Forum: Contributing into OpenJDK 6 In-Reply-To: <49ABFCE6.3010100@redhat.com> References: <49A471C9.2010101@sun.com> <49A80AD5.9080803@sun.com> <49ABFCE6.3010100@redhat.com> Message-ID: <49AC1890.8060406@sun.com> Andrew Haley wrote: > Hi there, > > is a recording of the call available? Not yet - it should become available later today. cheers, dalibor topic -- ******************************************************************* Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55 http://openjdk.java.net D-20097 Hamburg mailto:Dalibor.Topic at sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht M?nchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Dr. Roland B?mer Vorsitzender des Aufsichtsrates: Martin H?ring From mr at sun.com Mon Mar 2 15:01:06 2009 From: mr at sun.com (Mark Reinhold) Date: Mon, 02 Mar 2009 15:01:06 -0800 Subject: Updates: OpenJDK Forum: Contributing into OpenJDK 6 In-Reply-To: dalibor.topic@sun.com; Mon, 02 Mar 2009 18:34:08 +0100; <49AC1890.8060406@sun.com> Message-ID: <20090302230106.B254828E0EE@eggemoggin.niobe.net> > Date: Mon, 02 Mar 2009 18:34:08 +0100 > From: dalibor.topic at sun.com > Andrew Haley wrote: >> Hi there, >> >> is a recording of the call available? > > Not yet - it should become available later today. Here you go: http://mediacast.sun.com/users/mreinholds/media/openjdk-forum-2009-02-27.ogg - Mark From Dalibor.Topic at Sun.COM Thu Mar 5 08:05:16 2009 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Thu, 05 Mar 2009 17:05:16 +0100 Subject: [Fwd: mailing list for test results] Message-ID: <49AFF83C.4000106@sun.com> Hi everyone, it doesn't seem that anyone is at home in the Quality Group this week, so I figured I'll forward the mail over here. In brief: could we create a mailing list for OpenJDK 6 test results, please? cheers, dalibor topic -- ******************************************************************* Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55 http://openjdk.java.net D-20097 Hamburg mailto:Dalibor.Topic at sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht M?nchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Dr. Roland B?mer Vorsitzender des Aufsichtsrates: Martin H?ring -------------- next part -------------- An embedded message was scrubbed... From: Dalibor Topic Subject: mailing list for test results Date: Fri, 27 Feb 2009 13:52:34 +0100 Size: 7187 Url: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20090305/b3b42929/attachment.mht From Dalibor.Topic at Sun.COM Thu Mar 5 11:21:39 2009 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Thu, 05 Mar 2009 20:21:39 +0100 Subject: [Fwd: mailing list for test results] In-Reply-To: <49AFF83C.4000106@sun.com> References: <49AFF83C.4000106@sun.com> Message-ID: <49B02643.6040600@sun.com> Dalibor Topic wrote: > Hi everyone, > > it doesn't seem that anyone is at home in the Quality Group this week, > so I figured I'll forward the mail over here. On a second reading, this sentence sounds mean and frustrated, rather then entertainingly light and funny - apologies for that. > In brief: could we > create a mailing list for OpenJDK 6 test results, please? On a second reading, a question to consider comes up: would we need a second list for OpenJDK7 test results? Would one list and meaningful subject choices do? cheers, dalibor topic > cheers, > dalibor topic > > > ------------------------------------------------------------------------ > > Subject: > mailing list for test results > From: > Dalibor Topic > Date: > Fri, 27 Feb 2009 13:52:34 +0100 > To: > quality-discuss at openjdk.java.net > > To: > quality-discuss at openjdk.java.net > > > Hi everyone, > > as the uptake of OpenJDK in GNU/Linux distributions, and in other > exciting places grows, there is an increasing need to have a > central place to post test results from jtreg and other test suite > runs, and have them archived for later mining, comparison, etc. > > Other similarly scoped free software projects like the GNU compiler > collection use mailing lists for that purpose, in gcc's case that's > 'gcc-regression' - a moderate volume list where regression results > for the GCC compilers are posted. > > It would be great if the Quality Group could provide a similar > regression test results mailing list, where people (automatically) > building OpenJDK 6/7 and running jtreg could post their results to. > > For the background of this request, please see the thread at the > distro-pkg-dev mailing list, starting at > http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2009-February/004925.html > > cheers, > dalibor topic -- ******************************************************************* Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55 http://openjdk.java.net D-20097 Hamburg mailto:Dalibor.Topic at sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht M?nchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Dr. Roland B?mer Vorsitzender des Aufsichtsrates: Martin H?ring From langel at redhat.com Thu Mar 5 11:26:56 2009 From: langel at redhat.com (Lillian Angel) Date: Thu, 05 Mar 2009 14:26:56 -0500 Subject: [Fwd: mailing list for test results] In-Reply-To: <49B02643.6040600@sun.com> References: <49AFF83C.4000106@sun.com> <49B02643.6040600@sun.com> Message-ID: <49B02780.10804@redhat.com> Dalibor Topic wrote: > Dalibor Topic wrote: > >> Hi everyone, >> >> it doesn't seem that anyone is at home in the Quality Group this week, >> so I figured I'll forward the mail over here. >> > > On a second reading, this sentence sounds mean and frustrated, > rather then entertainingly light and funny - apologies for that. > > >> In brief: could we >> create a mailing list for OpenJDK 6 test results, please? >> > > On a second reading, a question to consider comes up: would we need a > second list for OpenJDK7 test results? Would one list and meaningful > subject choices do? > Having one would cut down on the amount of lists I subscribe to, but in reality it doesn't matter. It would be nice to see OpenJDK6 and OpenJDK7 results at the same time for direct comparison. Cheers! Lillian > > cheers, > dalibor topic > > >> cheers, >> dalibor topic >> >> >> ------------------------------------------------------------------------ >> >> Subject: >> mailing list for test results >> From: >> Dalibor Topic >> Date: >> Fri, 27 Feb 2009 13:52:34 +0100 >> To: >> quality-discuss at openjdk.java.net >> >> To: >> quality-discuss at openjdk.java.net >> >> >> Hi everyone, >> >> as the uptake of OpenJDK in GNU/Linux distributions, and in other >> exciting places grows, there is an increasing need to have a >> central place to post test results from jtreg and other test suite >> runs, and have them archived for later mining, comparison, etc. >> >> Other similarly scoped free software projects like the GNU compiler >> collection use mailing lists for that purpose, in gcc's case that's >> 'gcc-regression' - a moderate volume list where regression results >> for the GCC compilers are posted. >> >> It would be great if the Quality Group could provide a similar >> regression test results mailing list, where people (automatically) >> building OpenJDK 6/7 and running jtreg could post their results to. >> >> For the background of this request, please see the thread at the >> distro-pkg-dev mailing list, starting at >> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2009-February/004925.html >> >> cheers, >> dalibor topic >> > > > From gnu_andrew at member.fsf.org Thu Mar 5 11:47:25 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 5 Mar 2009 19:47:25 +0000 Subject: [Fwd: mailing list for test results] In-Reply-To: <49B02643.6040600@sun.com> References: <49AFF83C.4000106@sun.com> <49B02643.6040600@sun.com> Message-ID: <17c6771e0903051147x74b0bf73x12f7081fb914fed5@mail.gmail.com> 2009/3/5 Dalibor Topic : > Dalibor Topic wrote: >> Hi everyone, >> >> it doesn't seem that anyone is at home in the Quality Group this week, >> so I figured I'll forward the mail over here. > > On a second reading, this sentence sounds mean and frustrated, > rather then entertainingly light and funny - apologies for that. > It sounded light and funny from here at least :) >> In brief: could we >> create a mailing list for OpenJDK 6 test results, please? > > On a second reading, a question to consider comes up: would we need a > second list for OpenJDK7 test results? Would one list and meaningful > subject choices do? > One list is fine. We can always split it into two if the amount of mail becomes a problem for its readership. I'm still concerned that I'm missing important mails on one of the many OpenJDK lists, while being subscribed to several that don't see a single post. > cheers, > dalibor topic > >> cheers, >> dalibor topic >> >> >> ------------------------------------------------------------------------ >> >> Subject: >> mailing list for test results >> From: >> Dalibor Topic >> Date: >> Fri, 27 Feb 2009 13:52:34 +0100 >> To: >> quality-discuss at openjdk.java.net >> >> To: >> quality-discuss at openjdk.java.net >> >> >> Hi everyone, >> >> as the uptake of OpenJDK in GNU/Linux distributions, and in other >> exciting places grows, there is an increasing need to have a >> central place to post test results from jtreg and other test suite >> runs, and have them archived for later mining, comparison, etc. >> >> Other similarly scoped free software projects like the GNU compiler >> collection use mailing lists for that purpose, in gcc's case that's >> 'gcc-regression' ?- a moderate volume list where regression results >> for the GCC compilers are posted. >> >> It would be great if the Quality Group could provide a similar >> regression test results mailing list, where people (automatically) >> building OpenJDK 6/7 and running jtreg could post their results to. >> >> For the background of this request, please see the thread at the >> distro-pkg-dev mailing list, starting at >> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2009-February/004925.html >> >> cheers, >> dalibor topic > > > -- > ******************************************************************* > Dalibor Topic ? ? ? ? ? ? ? ? ? Tel: (+49 40) 23 646 738 > Java F/OSS Ambassador ? ? ? ? ? AIM: robiladonaim > Sun Microsystems GmbH ? ? ? ? ? Mobile: (+49 177) 2664 192 > Nagelsweg 55 ? ? ? ? ? ? ? ? ? ?http://openjdk.java.net > D-20097 Hamburg ? ? ? ? ? ? ? ? mailto:Dalibor.Topic at sun.com > Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten > Amtsgericht M?nchen: HRB 161028 > Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Dr. Roland B?mer > Vorsitzender des Aufsichtsrates: Martin H?ring > > > Cheers, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From david at davidherron.com Thu Mar 5 12:20:57 2009 From: david at davidherron.com (David Herron) Date: Thu, 5 Mar 2009 12:20:57 -0800 Subject: [Fwd: mailing list for test results] In-Reply-To: <49B02643.6040600@sun.com> References: <49AFF83C.4000106@sun.com> <49B02643.6040600@sun.com> Message-ID: <44ca3ad70903051220j2a102510t41b985ed0d8826a7@mail.gmail.com> Well, even I read it as being light and funny. In any case here's a few thoughts.. The quality group email alias is already under-utilized. Test results make sense to post to the quality group. However the existing group alias has the token "-discuss" in it and test results aren't exactly discussion. Given the number of aliases it wouldn't hurt to add another and quality-results is a good choice for a name. Is a mailing list the best place to post quality results? Back when my job was to ponder how to conduct a QA group for the OpenJDK project the idea I had in mind as the first step was 1) set up qa.openjdk.java.net as a simple data repository w/ very little you would normally think of as a web server 2) give rights to a set of people to poke files into that repository through some means 3) do up some scripting to process results with the community writing tools for results 4) keep it light weight with several ways for people to contribute ways to tabulate results in ways the community finds useful 5) focus on: unit/regression test results, mauve test results, findbugs & other static analysis results - David Herron On Thu, Mar 5, 2009 at 11:21 AM, Dalibor Topic wrote: > Dalibor Topic wrote: > > Hi everyone, > > > > it doesn't seem that anyone is at home in the Quality Group this week, > > so I figured I'll forward the mail over here. > > On a second reading, this sentence sounds mean and frustrated, > rather then entertainingly light and funny - apologies for that. > > > In brief: could we > > create a mailing list for OpenJDK 6 test results, please? > > On a second reading, a question to consider comes up: would we need a > second list for OpenJDK7 test results? Would one list and meaningful > subject choices do? > > cheers, > dalibor topic > > > cheers, > > dalibor topic > > > > > > ------------------------------------------------------------------------ > > > > Subject: > > mailing list for test results > > From: > > Dalibor Topic > > Date: > > Fri, 27 Feb 2009 13:52:34 +0100 > > To: > > quality-discuss at openjdk.java.net > > > > To: > > quality-discuss at openjdk.java.net > > > > > > Hi everyone, > > > > as the uptake of OpenJDK in GNU/Linux distributions, and in other > > exciting places grows, there is an increasing need to have a > > central place to post test results from jtreg and other test suite > > runs, and have them archived for later mining, comparison, etc. > > > > Other similarly scoped free software projects like the GNU compiler > > collection use mailing lists for that purpose, in gcc's case that's > > 'gcc-regression' - a moderate volume list where regression results > > for the GCC compilers are posted. > > > > It would be great if the Quality Group could provide a similar > > regression test results mailing list, where people (automatically) > > building OpenJDK 6/7 and running jtreg could post their results to. > > > > For the background of this request, please see the thread at the > > distro-pkg-dev mailing list, starting at > > > http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2009-February/004925.html > > > > cheers, > > dalibor topic > > > -- > ******************************************************************* > Dalibor Topic Tel: (+49 40) 23 646 738 > Java F/OSS Ambassador AIM: robiladonaim > Sun Microsystems GmbH Mobile: (+49 177) 2664 192 > Nagelsweg 55 http://openjdk.java.net > D-20097 Hamburg mailto:Dalibor.Topic at sun.com > Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten > Amtsgericht M?nchen: HRB 161028 > Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Dr. Roland B?mer > Vorsitzender des Aufsichtsrates: Martin H?ring > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20090305/6954bf2d/attachment.html From Dalibor.Topic at Sun.COM Fri Mar 6 09:03:40 2009 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Fri, 06 Mar 2009 18:03:40 +0100 Subject: Updates: OpenJDK Forum: Contributing into OpenJDK 6 In-Reply-To: <20090302230106.B254828E0EE@eggemoggin.niobe.net> References: <20090302230106.B254828E0EE@eggemoggin.niobe.net> Message-ID: <49B1576C.7040900@sun.com> Mark Reinhold wrote: >> Date: Mon, 02 Mar 2009 18:34:08 +0100 >> From: dalibor.topic at sun.com > >> Andrew Haley wrote: >>> Hi there, >>> >>> is a recording of the call available? >> Not yet - it should become available later today. > > Here you go: > > http://mediacast.sun.com/users/mreinholds/media/openjdk-forum-2009-02-27.ogg > > - Mark And here are the rough meeting notes: OpenJDK Forum - Contributing into OpenJDK 6 Date: 2009-02-27 Participants: 22 Speakers (in order of first appearance): Dalibor Topic Mark Reinhold Joe Darcy Andrew Haley Dmitri Trembovetski Lillian Angel Martin Buchholz Phil Rice Volker Simonis Discussed items (in slightly adapted order): * OpenJDK 6 & writable repositories We have the OpenJDK 6 writable repositories. Marting Buchholz made some pushes, and we'd like to see more people do it. Potential patches to include in OpenJDK 6 would be IcedTea pacthes, security fixes, backports of fixes from OpenJDK 7. Ports like Zero or Shark are larger then simple backports, so they should go upstream. In order to make that happen, there is a desire to understand processes, and get up to speed as quickly as possible. * How do we go about merging in larger changes like Zero? - A large change like that should go into 7/6 simultaneously, or into 7 first. - Bugzilla entry for Zero - Create webrev - upload it on cr.openjdk.java.net server - Send it to HotSpot team for review - have someone mentor the external developers on the first merging steps - have them spread around different areas of expertise * Bugzilla We have a bugzilla up now, at the moment its purpose is to collect patches from developers without push rights. Simple process for contributions, and a draft of sponsorship process - mainly of interest to Sun engineers right now. Dalibor and Mark are poking Sun engineers to look at them. * What's the procedure for committers for a simple patch from IcedTea into OpenJDK 6? - generate webrev of the change for large change, diff is fine for small ones - post the patch on jdk6-dev and ask for review on jdk6-dev alias - approval from technology expert in the area (Joe and potentially others) - backport from OpenJDK 7 will usualy be appropriate - push the change into OpenJDK 6 * What's the process to get push rights into OpenJDK 6 ? - start with a few patches with some assistance - figure out the process with the mentors - get push rights * What's the merging activity planned for OpenJDK 6? - not much - some of the JDK 7 bug fixes planned for backporting and merge by Joe. - Martin expects 10 changes from him/Google he'd like to see in OpenJDK 6 * Can the backporting activity be delegated on more shoulders? - Joe would be happy for other people to do the backports and pushes - it's more of an issue to identify desirable fixes - once a fix is in 7 it's not very hard to backport into 6 The client team started a big push to forward port changes from 6uN into 7. * Should we use bugzilla to track merging activity? - gcc uses bugzilla for merging larger patches * Should we have small changes go through the list, and large changes through bugzilla? - Joe, Lillian are OK with that approach. * what areas to work on OpenJDK7 without duplicating effort ? - a good first batch of stuff is the small patches from IcedTea - and then have the conversation again - probably about Zero & the plugin * How about the IcedTea plugin? - it can likely be contributed under the SCA - it may make more sense for OpenJDK 6, then for OpenJDK 7, where Ken's plugin will appear - it can be replaced later if the new plugin is better - Sun isn't necessarily going to build & test it, but that's OK * what else do people want to work on? - porting - client-side speedups and size improvements - C++ interpreter (and tiered compilation) * Cultural differences in bringing out the review process into the open - A struggle we expect to continue to have for a while, but Sun engineers are coming to understand that it's a good thing * How to go about encouraging reviews to happen and to happen in the open? - hard to get past the known sub-group trust relationship regardless of sub-project - should we use reviewboard - we need to review it and put up an instance for experimental use by early summer - webrev robot from some sun teams, but reinforces sub-group trust relationships, and not hardened for life on the internet. - open source review tools usage not common in practice, but experience shows reviews are useful * Relationship and patch flow between OpenJDK 7 and various internal releases? - The vast majority on hg.openjdk.java.net - Small bit of left over encumbrancies for 7 internal at Sun - No internal 7 tree with a different code tree - The release engineering pulls every night from the hg to get the open code, and from the closed bits to turn them both into 7 builds - pushes to OpenJDK 7 will appear in the next 7 builds - a few build variables decide for some encumbered bits of code which one to use * Can SCSL licensees push directly without signing the SCA? No. There is a process to take SCSL-covered code and turn it into something that can be pushed into OpenJDK. The forum was successful, so we'll have another one in a few weeks time. cheers, dalibor topic -- ******************************************************************* Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55 http://openjdk.java.net D-20097 Hamburg mailto:Dalibor.Topic at sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht M?nchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Dr. Roland B?mer Vorsitzender des Aufsichtsrates: Martin H?ring From Dalibor.Topic at Sun.COM Thu Mar 19 09:03:02 2009 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Thu, 19 Mar 2009 09:03:02 -0700 Subject: [Fwd: mailing list for test results] In-Reply-To: <17c6771e0903051147x74b0bf73x12f7081fb914fed5@mail.gmail.com> References: <49AFF83C.4000106@sun.com> <49B02643.6040600@sun.com> <17c6771e0903051147x74b0bf73x12f7081fb914fed5@mail.gmail.com> Message-ID: <49C26CB6.3040605@sun.com> Andrew John Hughes wrote: >>> In brief: could we >>> create a mailing list for OpenJDK 6 test results, please? >> On a second reading, a question to consider comes up: would we need a >> second list for OpenJDK7 test results? Would one list and meaningful >> subject choices do? >> > > One list is fine. We can always split it into two if the amount of > mail becomes a problem for its readership. I'm still concerned that > I'm missing important mails on one of the many OpenJDK lists, while > being subscribed to several that don't see a single post. OK, then one list it is - Mark created http://mail.openjdk.java.net/mailman/listinfo/icedtea-test for the purpose. If the need arises to split out more lists for separate projects, we can do it later, as you said. cheers, dalibor topic -- ******************************************************************* Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55 http://openjdk.java.net D-20097 Hamburg mailto:Dalibor.Topic at sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht M?nchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Dr. Roland B?mer Vorsitzender des Aufsichtsrates: Martin H?ring From sergey.malenkov at sun.com Fri Mar 20 10:39:38 2009 From: sergey.malenkov at sun.com (sergey.malenkov at sun.com) Date: Fri, 20 Mar 2009 17:39:38 +0000 Subject: hg: jdk6/jdk6/jdk: 6736248: EnumEditor bug. Class check incorrect Message-ID: <20090320173951.86CE1E603@hg.openjdk.java.net> Changeset: 99eb68d7cf4d Author: malenkov Date: 2009-03-20 20:36 +0300 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/99eb68d7cf4d 6736248: EnumEditor bug. Class check incorrect Reviewed-by: alexp ! src/share/classes/sun/beans/editors/EnumEditor.java + test/java/beans/PropertyEditor/TestEnumSubclass.java + test/java/beans/PropertyEditor/TestEnumSubclassJava.java + test/java/beans/PropertyEditor/TestEnumSubclassNull.java + test/java/beans/PropertyEditor/TestEnumSubclassValue.java From Dalibor.Topic at Sun.COM Sat Mar 21 12:54:00 2009 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Sat, 21 Mar 2009 20:54:00 +0100 Subject: Request for review: 6781572 Default to IMPORT_BINARY_PLUGS=false for OpenJDK 6 builds Message-ID: <49C545D8.20703@sun.com> Hi Joe, hi Kelly, the webrev is at http://cr.openjdk.java.net/~robilad/6781572/webrev.00/ cheers, dalibor topic From gnu_andrew at member.fsf.org Sat Mar 21 21:13:12 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Sun, 22 Mar 2009 04:13:12 +0000 Subject: Request for review: 6781572 Default to IMPORT_BINARY_PLUGS=false for OpenJDK 6 builds In-Reply-To: <49C545D8.20703@sun.com> References: <49C545D8.20703@sun.com> Message-ID: <17c6771e0903212113s4086308cwc99161d7c0e40eb3@mail.gmail.com> 2009/3/21 Dalibor Topic : > Hi Joe, hi Kelly, > > the webrev is at > > http://cr.openjdk.java.net/~robilad/6781572/webrev.00/ > > cheers, > dalibor topic > +1 :) -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Joe.Darcy at Sun.COM Sun Mar 22 14:13:45 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Sun, 22 Mar 2009 14:13:45 -0700 Subject: Request for review: 6781572 Default to IMPORT_BINARY_PLUGS=false for OpenJDK 6 builds -- approved In-Reply-To: <49C545D8.20703@sun.com> References: <49C545D8.20703@sun.com> Message-ID: <49C6AA09.6000300@sun.com> Looks fine; approved! Thanks, -Joe Dalibor Topic wrote: > Hi Joe, hi Kelly, > > the webrev is at > > http://cr.openjdk.java.net/~robilad/6781572/webrev.00/ > > cheers, > dalibor topic From Dalibor.Topic at Sun.COM Mon Mar 23 11:29:48 2009 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Mon, 23 Mar 2009 11:29:48 -0700 Subject: Request for review: 6781572 Default to IMPORT_BINARY_PLUGS=false for OpenJDK 6 builds -- approved In-Reply-To: <49C6AA09.6000300@sun.com> References: <49C545D8.20703@sun.com> <49C6AA09.6000300@sun.com> Message-ID: <49C7D51C.6000209@sun.com> Joseph D. Darcy wrote: > Looks fine; approved! Thanks, Joe! Kelly, could you take a quick look, too? cheers, dalibor topic > > Thanks, > > -Joe > > Dalibor Topic wrote: >> Hi Joe, hi Kelly, >> >> the webrev is at >> >> http://cr.openjdk.java.net/~robilad/6781572/webrev.00/ >> >> cheers, >> dalibor topic > -- ******************************************************************* Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55 http://openjdk.java.net D-20097 Hamburg mailto:Dalibor.Topic at sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht M?nchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Dr. Roland B?mer Vorsitzender des Aufsichtsrates: Martin H?ring From Kelly.Ohair at Sun.COM Mon Mar 23 11:31:56 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Mon, 23 Mar 2009 11:31:56 -0700 Subject: Request for review: 6781572 Default to IMPORT_BINARY_PLUGS=false for OpenJDK 6 builds -- approved In-Reply-To: <49C7D51C.6000209@sun.com> References: <49C545D8.20703@sun.com> <49C6AA09.6000300@sun.com> <49C7D51C.6000209@sun.com> Message-ID: <49C7D59C.1050502@sun.com> Perfect. -kto Dalibor Topic wrote: > Joseph D. Darcy wrote: >> Looks fine; approved! > > Thanks, Joe! > > Kelly, could you take a quick look, too? > > cheers, > dalibor topic > >> Thanks, >> >> -Joe >> >> Dalibor Topic wrote: >>> Hi Joe, hi Kelly, >>> >>> the webrev is at >>> >>> http://cr.openjdk.java.net/~robilad/6781572/webrev.00/ >>> >>> cheers, >>> dalibor topic > > From Joe.Darcy at Sun.COM Tue Mar 24 14:02:44 2009 From: Joe.Darcy at Sun.COM (Joe Darcy) Date: Tue, 24 Mar 2009 14:02:44 -0700 Subject: Security fixes on the way... Message-ID: <49C94A74.8050900@sun.com> Hello. A set of security fixes will be hitting the OpenJDK 6 Mercurial repository soon. The next build, b16, including those security fixes will be tagged a few days later. -Joe From phil.race at sun.com Tue Mar 24 14:34:40 2009 From: phil.race at sun.com (phil.race at sun.com) Date: Tue, 24 Mar 2009 14:34:40 -0700 Subject: hg: jdk6/jdk6/jdk: 6821031: Upgrade OpenJDK's LittleCMS version to 1.18 Message-ID: <20090324213453.87592E887@hg.openjdk.java.net> Changeset: 2bdeec6199b7 Author: prr Date: 2009-03-24 11:06 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/2bdeec6199b7 6821031: Upgrade OpenJDK's LittleCMS version to 1.18 Reviewed-by: bae, igor ! src/share/native/sun/java2d/cmm/lcms/LCMS.c ! src/share/native/sun/java2d/cmm/lcms/cmscam02.c ! src/share/native/sun/java2d/cmm/lcms/cmscam97.c ! src/share/native/sun/java2d/cmm/lcms/cmscgats.c ! src/share/native/sun/java2d/cmm/lcms/cmscnvrt.c ! src/share/native/sun/java2d/cmm/lcms/cmserr.c ! src/share/native/sun/java2d/cmm/lcms/cmsgamma.c ! src/share/native/sun/java2d/cmm/lcms/cmsgmt.c ! src/share/native/sun/java2d/cmm/lcms/cmsintrp.c ! src/share/native/sun/java2d/cmm/lcms/cmsio0.c ! src/share/native/sun/java2d/cmm/lcms/cmsio1.c ! src/share/native/sun/java2d/cmm/lcms/cmslut.c ! src/share/native/sun/java2d/cmm/lcms/cmsmatsh.c ! src/share/native/sun/java2d/cmm/lcms/cmsmtrx.c ! src/share/native/sun/java2d/cmm/lcms/cmsnamed.c ! src/share/native/sun/java2d/cmm/lcms/cmspack.c ! src/share/native/sun/java2d/cmm/lcms/cmspcs.c ! src/share/native/sun/java2d/cmm/lcms/cmsps2.c ! src/share/native/sun/java2d/cmm/lcms/cmssamp.c ! src/share/native/sun/java2d/cmm/lcms/cmsvirt.c ! src/share/native/sun/java2d/cmm/lcms/cmswtpnt.c ! src/share/native/sun/java2d/cmm/lcms/cmsxform.c ! src/share/native/sun/java2d/cmm/lcms/icc34.h ! src/share/native/sun/java2d/cmm/lcms/lcms.h From dalibor.topic at sun.com Tue Mar 24 15:55:01 2009 From: dalibor.topic at sun.com (dalibor.topic at sun.com) Date: Tue, 24 Mar 2009 22:55:01 +0000 Subject: hg: jdk6/jdk6/jdk: 6781572: Default to IMPORT_BINARY_PLUGS=false for OpenJDK 6 builds Message-ID: <20090324225519.54B1EE8D7@hg.openjdk.java.net> Changeset: a6cd87f2e15e Author: robilad Date: 2009-03-23 18:46 +0100 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/a6cd87f2e15e 6781572: Default to IMPORT_BINARY_PLUGS=false for OpenJDK 6 builds Summary: Set IMPORT_BINARY_PLUGS to false when building OPENJDK Reviewed-by: darcy, ohair ! make/common/Defs.gmk From abhijit.saha at sun.com Tue Mar 24 17:39:18 2009 From: abhijit.saha at sun.com (abhijit.saha at sun.com) Date: Wed, 25 Mar 2009 00:39:18 +0000 Subject: hg: jdk6/jdk6/hotspot: 2 new changesets Message-ID: <20090325003923.68FA3E933@hg.openjdk.java.net> Changeset: cb5acf92f8c5 Author: never Date: 2009-03-08 19:02 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/cb5acf92f8c5 6636360: compiler/6595044/Main.java test fails with 64bit java on solaris-sparcv9 with SIGSEGV Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/vtableStubs_sparc.cpp Changeset: 2e1fb22869c0 Author: asaha Date: 2009-03-19 14:18 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/2e1fb22869c0 Merge From kalli at midverk.is Tue Mar 24 23:13:30 2009 From: kalli at midverk.is (kalli at midverk.is) Date: Wed, 25 Mar 2009 06:13:30 +0000 Subject: hg: jdk6/jdk6/jdk: 6821030: Merge OpenJDK Gervill with upstream sources, Q1CY2009 Message-ID: <20090325061346.CEF24E9A7@hg.openjdk.java.net> Changeset: d92657851cfd Author: kalli Date: 2009-03-25 06:08 +0000 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/d92657851cfd 6821030: Merge OpenJDK Gervill with upstream sources, Q1CY2009 Reviewed-by: darcy, amenkov ! src/share/classes/com/sun/media/sound/SoftAudioPusher.java ! src/share/classes/com/sun/media/sound/SoftChannel.java ! src/share/classes/com/sun/media/sound/SoftChorus.java ! src/share/classes/com/sun/media/sound/SoftFilter.java ! src/share/classes/com/sun/media/sound/SoftJitterCorrector.java ! src/share/classes/com/sun/media/sound/SoftMainMixer.java ! src/share/classes/com/sun/media/sound/SoftVoice.java + test/javax/sound/midi/Gervill/SoftChannel/NoteOverFlowTest.java + test/javax/sound/midi/Gervill/SoftFilter/TestProcessAudio.java From Dalibor.Topic at Sun.COM Tue Mar 24 23:33:43 2009 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Tue, 24 Mar 2009 23:33:43 -0700 Subject: hg: jdk6/jdk6/jdk: 6821030: Merge OpenJDK Gervill with upstream sources, Q1CY2009 In-Reply-To: <20090325061346.CEF24E9A7@hg.openjdk.java.net> References: <20090325061346.CEF24E9A7@hg.openjdk.java.net> Message-ID: <49C9D047.6080700@sun.com> kalli at midverk.is wrote: > Changeset: d92657851cfd > Author: kalli > Date: 2009-03-25 06:08 +0000 > URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/d92657851cfd > > 6821030: Merge OpenJDK Gervill with upstream sources, Q1CY2009 > Reviewed-by: darcy, amenkov > > ! src/share/classes/com/sun/media/sound/SoftAudioPusher.java > ! src/share/classes/com/sun/media/sound/SoftChannel.java > ! src/share/classes/com/sun/media/sound/SoftChorus.java > ! src/share/classes/com/sun/media/sound/SoftFilter.java > ! src/share/classes/com/sun/media/sound/SoftJitterCorrector.java > ! src/share/classes/com/sun/media/sound/SoftMainMixer.java > ! src/share/classes/com/sun/media/sound/SoftVoice.java > + test/javax/sound/midi/Gervill/SoftChannel/NoteOverFlowTest.java > + test/javax/sound/midi/Gervill/SoftFilter/TestProcessAudio.java > Congrats on the first push, Karl, and welcome to OpenJDK! cheers, dalibor topic -- ******************************************************************* Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55 http://openjdk.java.net D-20097 Hamburg mailto:Dalibor.Topic at sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht M?nchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Dr. Roland B?mer Vorsitzender des Aufsichtsrates: Martin H?ring From martinrb at google.com Wed Mar 25 01:26:03 2009 From: martinrb at google.com (martinrb at google.com) Date: Wed, 25 Mar 2009 08:26:03 +0000 Subject: hg: jdk6/jdk6/jdk: 6800572: Removing elements from views of NavigableMap implementations does not always work correctly. Message-ID: <20090325082621.D44E1E9BA@hg.openjdk.java.net> Changeset: 4828c62e43f4 Author: dl Date: 2009-03-25 01:20 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/4828c62e43f4 6800572: Removing elements from views of NavigableMap implementations does not always work correctly. Summary: Replace use of new TreeSet with new KeySet Reviewed-by: martin ! src/share/classes/java/util/TreeMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! test/java/util/Collection/MOAT.java From martinrb at google.com Thu Mar 26 13:41:57 2009 From: martinrb at google.com (martinrb at google.com) Date: Thu, 26 Mar 2009 20:41:57 +0000 Subject: hg: jdk6/jdk6/jdk: 6801020: Concurrent Semaphore release may cause some require thread not signaled Message-ID: <20090326204204.EDAD2EA8F@hg.openjdk.java.net> Changeset: a4322dae3141 Author: dl Date: 2009-03-26 12:18 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/a4322dae3141 6801020: Concurrent Semaphore release may cause some require thread not signaled Summary: Introduce PROPAGATE waitStatus Reviewed-by: martin ! src/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java ! src/share/classes/java/util/concurrent/locks/AbstractQueuedSynchronizer.java + test/java/util/concurrent/Semaphore/RacingReleases.java From sagar.shivam2005 at gmail.com Thu Mar 26 23:25:04 2009 From: sagar.shivam2005 at gmail.com (sagar priyadarshi) Date: Fri, 27 Mar 2009 11:55:04 +0530 Subject: problem in util.Scanner class Message-ID: <8ee1fa060903262325x237c857j5e6f77fbe894a614@mail.gmail.com> Hello! I hope this is the right place to ask this question. Please take note of the following scenario and suggest if its a known bug or am I doing something wrong! What exactly I am trying to do is that i am creating a Scanner object and passing a line of text as an argument to the Scanner class constructor. I am using the method findInLine("import") so that it returns true if the line contains import. But when I use the same method findInLine() with an argument "." ie findInLine(".") the output which I get is the whole line itself even when the line of text does not contain a dot (.) Thanks in advance for your time. Regards, Sagar -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20090327/6c134be2/attachment.html From fw at deneb.enyo.de Thu Mar 26 23:40:32 2009 From: fw at deneb.enyo.de (Florian Weimer) Date: Fri, 27 Mar 2009 07:40:32 +0100 Subject: problem in util.Scanner class In-Reply-To: <8ee1fa060903262325x237c857j5e6f77fbe894a614@mail.gmail.com> (sagar priyadarshi's message of "Fri, 27 Mar 2009 11:55:04 +0530") References: <8ee1fa060903262325x237c857j5e6f77fbe894a614@mail.gmail.com> Message-ID: <87iqlvbh9b.fsf@mid.deneb.enyo.de> * sagar priyadarshi: > But when I use the same method findInLine() with an argument "." ie > findInLine(".") the output which I get is the whole line itself even when > the line of text does not contain a dot (.) The findInline(String) methods takes a regular expression argument, not a string argument. You have to write findInLine("\\."), or use Pattern.quote(String). The jdk6-dev mailing list is about development of OpenJDK itself, and not intended for questions about using the JDK to write software. However, to my knowledge, Sun does not host any general-purpose mailing lists for Java programming. From Joe.Darcy at Sun.COM Fri Mar 27 11:33:12 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Fri, 27 Mar 2009 11:33:12 -0700 Subject: problem in util.Scanner class In-Reply-To: <87iqlvbh9b.fsf@mid.deneb.enyo.de> References: <8ee1fa060903262325x237c857j5e6f77fbe894a614@mail.gmail.com> <87iqlvbh9b.fsf@mid.deneb.enyo.de> Message-ID: <49CD1BE8.2010609@sun.com> Florian Weimer wrote: > * sagar priyadarshi: > > >> But when I use the same method findInLine() with an argument "." ie >> findInLine(".") the output which I get is the whole line itself even when >> the line of text does not contain a dot (.) >> > > The findInline(String) methods takes a regular expression argument, > not a string argument. You have to write findInLine("\\."), or use > Pattern.quote(String). > > The jdk6-dev mailing list is about development of OpenJDK itself, and > not intended for questions about using the JDK to write software. > However, to my knowledge, Sun does not host any general-purpose > mailing lists for Java programming. > There are many fine forums for this kind of question: http://forums.sun.com/index.jspa -Joe From kalli at midverk.is Fri Mar 27 14:21:39 2009 From: kalli at midverk.is (Karl Helgason) Date: Fri, 27 Mar 2009 21:21:39 +0000 Subject: [New Bug]: Gervill SoftLowFrequencyOscillator fails when freq is set to 0 cent or 8.1758 Hz. Message-ID: <36EC82E93EB0AD40A4301DAD65432386F597F47EDC@mail.midverk.is> Hi, I need both code reviewer and a bug number for this fix. regards, Karl # HG changeset patch # User kalli # Date 1238188061 0 # Node ID d48eeb51f952a0a3fce147e3d809c9543de6a50e # Parent 4828c62e43f40c67c858f74f4fa349211ad38042 [New Bug]: Gervill SoftLowFrequencyOscillator fails when freq is set to 0 cent or 8.1758 Hz. diff -r 4828c62e43f4 -r d48eeb51f952 src/share/classes/com/sun/media/sound/SoftLowFrequencyOscillator.java --- a/src/share/classes/com/sun/media/sound/SoftLowFrequencyOscillator.java Wed Mar 25 01:20:12 2009 -0700 +++ b/src/share/classes/com/sun/media/sound/SoftLowFrequencyOscillator.java Fri Mar 27 21:07:41 2009 +0000 @@ -45,6 +45,13 @@ private double sin_factor = 0; private static double PI2 = 2.0 * Math.PI; + public SoftLowFrequencyOscillator() { + // If sin_step is 0 then sin_stepfreq must be -INF + for (int i = 0; i < sin_stepfreq.length; i++) { + sin_stepfreq[i] = Double.NEGATIVE_INFINITY; + } + } + public void reset() { for (int i = 0; i < used_count; i++) { out[i][0] = 0; @@ -53,7 +60,8 @@ freq[i][0] = 0; delay_counter[i] = 0; sin_phase[i] = 0; - sin_stepfreq[i] = 0; + // If sin_step is 0 then sin_stepfreq must be -INF + sin_stepfreq[i] = Double.NEGATIVE_INFINITY; sin_step[i] = 0; } used_count = 0; diff -r 4828c62e43f4 -r d48eeb51f952 test/javax/sound/midi/Gervill/SoftLowFrequencyOscillator/TestProcessControlLogic.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/javax/sound/midi/Gervill/SoftLowFrequencyOscillator/TestProcessControlLogic.java Fri Mar 27 21:07:41 2009 +0000 @@ -0,0 +1,106 @@ +/* + * Copyright 2009 Sun Microsystems, Inc. All Rights Reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. Sun designates this + * particular file as subject to the "Classpath" exception as provided + * by Sun in the LICENSE file that accompanied this code. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, + * CA 95054 USA or visit www.sun.com if you need additional information or + * have any questions. + */ + +/* @test + @summary Test SoftLowFrequencyOscillator processControlLogic method */ + +import com.sun.media.sound.AudioSynthesizerPropertyInfo; +import com.sun.media.sound.SoftLowFrequencyOscillator; +import com.sun.media.sound.SoftSynthesizer; + +public class TestProcessControlLogic { + + private static float control_rate = 147f; + private static SoftSynthesizer synth = new SoftSynthesizer(); + private static SoftLowFrequencyOscillator lfo = new SoftLowFrequencyOscillator(); + + private static void testLFO(boolean shared, int instance, float freq, float delay, + float delay2) throws Exception { + SoftLowFrequencyOscillator lfo = + shared?TestProcessControlLogic.lfo:new SoftLowFrequencyOscillator(); + lfo.reset(); + double[] lfo_freq = lfo.get(instance, "freq"); + double[] lfo_delay = lfo.get(instance, "delay"); + double[] lfo_delay2 = lfo.get(instance, "delay2"); + double[] lfo_output = lfo.get(instance, null); + lfo_freq[0] = freq; + lfo_delay[0] = delay; + lfo_delay2[0] = delay2; + lfo.init(synth); + + // For delayCount amount time, the output LFO should be 0.5 + int delayCount = (int) ((Math.pow(2, delay / 1200.0) * control_rate)); + delayCount += (int) ((delay2 * control_rate) / 1000.0); + for (int i = 0; i < delayCount; i++) { + if (Math.abs(0.5 - lfo_output[0]) > 0.000001) + throw new Exception("Incorrect LFO output (" + +"0.5 != "+lfo_output[0]+")!"); + lfo.processControlLogic(); + } + + // After the delay the LFO should start oscillate + // Let make sure output is accurate enough + double p_step = (440.0 / control_rate) + * Math.exp((freq - 6900.0) * (Math.log(2) / 1200.0)); + double p = 0; + for (int i = 0; i < 30; i++) { + p += p_step; + double predicted_output = 0.5 + Math.sin(p * 2 * Math.PI) * 0.5; + if (Math.abs(predicted_output - lfo_output[0]) > 0.001) + throw new Exception("Incorrect LFO output (" + +predicted_output+" != "+lfo_output[0]+")!"); + lfo.processControlLogic(); + } + + } + + public static void main(String[] args) throws Exception { + + // Get default control rate from synthesizer + AudioSynthesizerPropertyInfo[] p = synth.getPropertyInfo(null); + for (int i = 0; i < p.length; i++) { + if (p[i].name.equals("control rate")) { + control_rate = ((Float) p[i].value).floatValue(); + break; + } + } + + // Test LFO under various configurations + for (int instance = 0; instance < 3; instance++) + for (int d1 = -3000; d1 < 0; d1 += 1000) + for (int d2 = 0; d2 < 5000; d2 += 1000) + for (int fr = -1000; fr < 1000; fr += 100) { + testLFO(true, instance, + (fr == -1000) ? Float.NEGATIVE_INFINITY : fr, + (d1 == -3000) ? Float.NEGATIVE_INFINITY : d1, + d2); + testLFO(false, instance, + (fr == -1000) ? Float.NEGATIVE_INFINITY : fr, + (d1 == -3000) ? Float.NEGATIVE_INFINITY : d1, + d2); + } + + } +} From kalli at midverk.is Fri Mar 27 14:21:42 2009 From: kalli at midverk.is (Karl Helgason) Date: Fri, 27 Mar 2009 21:21:42 +0000 Subject: [New Bug]: Gervill SoftChannel/ResetAllControllers jtreg test fails after portamento fix from last merge. Message-ID: <36EC82E93EB0AD40A4301DAD65432386F597F47EDD@mail.midverk.is> Hi, I need both code reviewer and a bug number for this fix. regards, Karl # HG changeset patch # User kalli # Date 1238188182 0 # Node ID 87b4aa98cc2724434d164e152707c34a51729440 # Parent d48eeb51f952a0a3fce147e3d809c9543de6a50e [New Bug]: Gervill SoftChannel/ResetAllControllers jtreg test fails after portamento fix from last merge. diff -r d48eeb51f952 -r 87b4aa98cc27 src/share/classes/com/sun/media/sound/SoftChannel.java --- a/src/share/classes/com/sun/media/sound/SoftChannel.java Fri Mar 27 21:07:41 2009 +0000 +++ b/src/share/classes/com/sun/media/sound/SoftChannel.java Fri Mar 27 21:09:42 2009 +0000 @@ -67,7 +67,6 @@ dontResetControls[77] = true; // Sound Controller 8 (GM2 default: Vibrato Depth) dontResetControls[78] = true; // Sound Controller 9 (GM2 default: Vibrato Delay) dontResetControls[79] = true; // Sound Controller 10 (GM2 default: Undefined) - dontResetControls[84] = true; // Portamento Controller dontResetControls[120] = true; // All Sound Off dontResetControls[121] = true; // Reset All Controllers dontResetControls[122] = true; // Local Control On/Off @@ -94,7 +93,6 @@ protected double portamento_time = 1; // keyschanges per control buffer time protected int[] portamento_lastnote = new int[128]; protected int portamento_lastnote_ix = 0; - private int portamento_control_note = -1; private boolean portamento = false; private boolean mono = false; private boolean mute = false; @@ -370,12 +368,12 @@ voice.setSoloMute(solomute); if (releaseTriggered) return; - if (portamento_control_note != -1) { + if (controller[84] != 0) { voice.co_noteon_keynumber[0] - = (tuning.getTuning(portamento_control_note) / 100.0) + = (tuning.getTuning(controller[84]) / 100.0) * (1f / 128f); voice.portamento = true; - portamento_control_note = -1; + controlChange(84, 0); } else if (portamento) { if (mono) { if (portamento_lastnote[0] != -1) { @@ -383,7 +381,7 @@ = (tuning.getTuning(portamento_lastnote[0]) / 100.0) * (1f / 128f); voice.portamento = true; - portamento_control_note = -1; + controlChange(84, 0); } portamento_lastnote[0] = noteNumber; } else { @@ -450,19 +448,19 @@ } } - if (portamento_control_note != -1) { + if (controller[84] != 0) { boolean n_found = false; for (int i = 0; i < voices.length; i++) { if (voices[i].on && voices[i].channel == channel && voices[i].active - && voices[i].note == portamento_control_note + && voices[i].note == controller[84] && voices[i].releaseTriggered == false) { voices[i].portamento = true; voices[i].setNote(noteNumber); n_found = true; } } - portamento_control_note = -1; + controlChange(84, 0); if (n_found) return; } @@ -1154,9 +1152,6 @@ } } break; - case 84: - portamento_control_note = value; - break; case 98: nrpn_control = (nrpn_control & (127 << 7)) + value; rpn_control = RPN_NULL_VALUE; @@ -1398,10 +1393,6 @@ controlChange(i, 0); } - // Portamento Controller (0x54) has to reset - // to -1 which mean that Portamento Controller is off - portamento_control_note = -1; - controlChange(71, 64); // Filter Resonance controlChange(72, 64); // Release Time controlChange(73, 64); // Attack Time From Joe.Darcy at Sun.COM Sat Mar 28 20:44:04 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Sat, 28 Mar 2009 20:44:04 -0700 Subject: [New Bug]: Gervill SoftChannel/ResetAllControllers jtreg test fails after portamento fix from last merge. In-Reply-To: <36EC82E93EB0AD40A4301DAD65432386F597F47EDD@mail.midverk.is> References: <36EC82E93EB0AD40A4301DAD65432386F597F47EDD@mail.midverk.is> Message-ID: <49CEEE84.8000708@sun.com> Hello. Karl Helgason wrote: > Hi, > I need both code reviewer and a bug number for this fix. > > regards, > Karl > > For the bug you can use 6823445 Gervill SoftChannel/ResetAllControllers jtreg test fails after portamento fix from last merge -Joe From Joe.Darcy at Sun.COM Sat Mar 28 20:45:59 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Sat, 28 Mar 2009 20:45:59 -0700 Subject: [New Bug]: Gervill SoftLowFrequencyOscillator fails when freq is set to 0 cent or 8.1758 Hz. In-Reply-To: <36EC82E93EB0AD40A4301DAD65432386F597F47EDC@mail.midverk.is> References: <36EC82E93EB0AD40A4301DAD65432386F597F47EDC@mail.midverk.is> Message-ID: <49CEEEF7.5020404@sun.com> Karl Helgason wrote: > Hi, > I need both code reviewer and a bug number for this fix. > > Hello. You can use 6823446 Gervill SoftLowFrequencyOscillator fails when freq is set to 0 cent or 8.1758 Hz. -Joe From alex.menkov at sun.com Mon Mar 30 03:09:01 2009 From: alex.menkov at sun.com (Alex Menkov) Date: Mon, 30 Mar 2009 14:09:01 +0400 Subject: [6823446]: Gervill SoftLowFrequencyOscillator fails when freq is set to 0 cent or 8.1758 Hz. - APPROVED In-Reply-To: <36EC82E93EB0AD40A4301DAD65432386F597F47EDC@mail.midverk.is> References: <36EC82E93EB0AD40A4301DAD65432386F597F47EDC@mail.midverk.is> Message-ID: <49D09A3D.5030501@sun.com> Looks good. Approved. Regards Alex Karl Helgason wrote: > Hi, > I need both code reviewer and a bug number for this fix. > > regards, > Karl > > # HG changeset patch > # User kalli > # Date 1238188061 0 > # Node ID d48eeb51f952a0a3fce147e3d809c9543de6a50e > # Parent 4828c62e43f40c67c858f74f4fa349211ad38042 > [New Bug]: Gervill SoftLowFrequencyOscillator fails when freq is set to 0 cent or 8.1758 Hz. > > diff -r 4828c62e43f4 -r d48eeb51f952 src/share/classes/com/sun/media/sound/SoftLowFrequencyOscillator.java > --- a/src/share/classes/com/sun/media/sound/SoftLowFrequencyOscillator.java Wed Mar 25 01:20:12 2009 -0700 > +++ b/src/share/classes/com/sun/media/sound/SoftLowFrequencyOscillator.java Fri Mar 27 21:07:41 2009 +0000 > @@ -45,6 +45,13 @@ > private double sin_factor = 0; > private static double PI2 = 2.0 * Math.PI; > > + public SoftLowFrequencyOscillator() { > + // If sin_step is 0 then sin_stepfreq must be -INF > + for (int i = 0; i < sin_stepfreq.length; i++) { > + sin_stepfreq[i] = Double.NEGATIVE_INFINITY; > + } > + } > + > public void reset() { > for (int i = 0; i < used_count; i++) { > out[i][0] = 0; > @@ -53,7 +60,8 @@ > freq[i][0] = 0; > delay_counter[i] = 0; > sin_phase[i] = 0; > - sin_stepfreq[i] = 0; > + // If sin_step is 0 then sin_stepfreq must be -INF > + sin_stepfreq[i] = Double.NEGATIVE_INFINITY; > sin_step[i] = 0; > } > used_count = 0; > diff -r 4828c62e43f4 -r d48eeb51f952 test/javax/sound/midi/Gervill/SoftLowFrequencyOscillator/TestProcessControlLogic.java > --- /dev/null Thu Jan 01 00:00:00 1970 +0000 > +++ b/test/javax/sound/midi/Gervill/SoftLowFrequencyOscillator/TestProcessControlLogic.java Fri Mar 27 21:07:41 2009 +0000 > @@ -0,0 +1,106 @@ > +/* > + * Copyright 2009 Sun Microsystems, Inc. All Rights Reserved. > + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > + * > + * This code is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License version 2 only, as > + * published by the Free Software Foundation. Sun designates this > + * particular file as subject to the "Classpath" exception as provided > + * by Sun in the LICENSE file that accompanied this code. > + * > + * This code is distributed in the hope that it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License > + * version 2 for more details (a copy is included in the LICENSE file that > + * accompanied this code). > + * > + * You should have received a copy of the GNU General Public License version > + * 2 along with this work; if not, write to the Free Software Foundation, > + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. > + * > + * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, > + * CA 95054 USA or visit www.sun.com if you need additional information or > + * have any questions. > + */ > + > +/* @test > + @summary Test SoftLowFrequencyOscillator processControlLogic method */ > + > +import com.sun.media.sound.AudioSynthesizerPropertyInfo; > +import com.sun.media.sound.SoftLowFrequencyOscillator; > +import com.sun.media.sound.SoftSynthesizer; > + > +public class TestProcessControlLogic { > + > + private static float control_rate = 147f; > + private static SoftSynthesizer synth = new SoftSynthesizer(); > + private static SoftLowFrequencyOscillator lfo = new SoftLowFrequencyOscillator(); > + > + private static void testLFO(boolean shared, int instance, float freq, float delay, > + float delay2) throws Exception { > + SoftLowFrequencyOscillator lfo = > + shared?TestProcessControlLogic.lfo:new SoftLowFrequencyOscillator(); > + lfo.reset(); > + double[] lfo_freq = lfo.get(instance, "freq"); > + double[] lfo_delay = lfo.get(instance, "delay"); > + double[] lfo_delay2 = lfo.get(instance, "delay2"); > + double[] lfo_output = lfo.get(instance, null); > + lfo_freq[0] = freq; > + lfo_delay[0] = delay; > + lfo_delay2[0] = delay2; > + lfo.init(synth); > + > + // For delayCount amount time, the output LFO should be 0.5 > + int delayCount = (int) ((Math.pow(2, delay / 1200.0) * control_rate)); > + delayCount += (int) ((delay2 * control_rate) / 1000.0); > + for (int i = 0; i < delayCount; i++) { > + if (Math.abs(0.5 - lfo_output[0]) > 0.000001) > + throw new Exception("Incorrect LFO output (" > + +"0.5 != "+lfo_output[0]+")!"); > + lfo.processControlLogic(); > + } > + > + // After the delay the LFO should start oscillate > + // Let make sure output is accurate enough > + double p_step = (440.0 / control_rate) > + * Math.exp((freq - 6900.0) * (Math.log(2) / 1200.0)); > + double p = 0; > + for (int i = 0; i < 30; i++) { > + p += p_step; > + double predicted_output = 0.5 + Math.sin(p * 2 * Math.PI) * 0.5; > + if (Math.abs(predicted_output - lfo_output[0]) > 0.001) > + throw new Exception("Incorrect LFO output (" > + +predicted_output+" != "+lfo_output[0]+")!"); > + lfo.processControlLogic(); > + } > + > + } > + > + public static void main(String[] args) throws Exception { > + > + // Get default control rate from synthesizer > + AudioSynthesizerPropertyInfo[] p = synth.getPropertyInfo(null); > + for (int i = 0; i < p.length; i++) { > + if (p[i].name.equals("control rate")) { > + control_rate = ((Float) p[i].value).floatValue(); > + break; > + } > + } > + > + // Test LFO under various configurations > + for (int instance = 0; instance < 3; instance++) > + for (int d1 = -3000; d1 < 0; d1 += 1000) > + for (int d2 = 0; d2 < 5000; d2 += 1000) > + for (int fr = -1000; fr < 1000; fr += 100) { > + testLFO(true, instance, > + (fr == -1000) ? Float.NEGATIVE_INFINITY : fr, > + (d1 == -3000) ? Float.NEGATIVE_INFINITY : d1, > + d2); > + testLFO(false, instance, > + (fr == -1000) ? Float.NEGATIVE_INFINITY : fr, > + (d1 == -3000) ? Float.NEGATIVE_INFINITY : d1, > + d2); > + } > + > + } > +} > From alex.menkov at sun.com Mon Mar 30 10:06:06 2009 From: alex.menkov at sun.com (Alex Menkov) Date: Mon, 30 Mar 2009 21:06:06 +0400 Subject: [6823445]: Gervill SoftChannel/ResetAllControllers jtreg test fails after portamento fix from last merge. - APPROVED In-Reply-To: <36EC82E93EB0AD40A4301DAD65432386F597F47EDD@mail.midverk.is> References: <36EC82E93EB0AD40A4301DAD65432386F597F47EDD@mail.midverk.is> Message-ID: <49D0FBFE.4090505@sun.com> approved. Regards Alex Karl Helgason wrote: > Hi, > I need both code reviewer and a bug number for this fix. > > regards, > Karl > > # HG changeset patch > # User kalli > # Date 1238188182 0 > # Node ID 87b4aa98cc2724434d164e152707c34a51729440 > # Parent d48eeb51f952a0a3fce147e3d809c9543de6a50e > [New Bug]: Gervill SoftChannel/ResetAllControllers jtreg test fails after portamento fix from last merge. > > diff -r d48eeb51f952 -r 87b4aa98cc27 src/share/classes/com/sun/media/sound/SoftChannel.java > --- a/src/share/classes/com/sun/media/sound/SoftChannel.java Fri Mar 27 21:07:41 2009 +0000 > +++ b/src/share/classes/com/sun/media/sound/SoftChannel.java Fri Mar 27 21:09:42 2009 +0000 > @@ -67,7 +67,6 @@ > dontResetControls[77] = true; // Sound Controller 8 (GM2 default: Vibrato Depth) > dontResetControls[78] = true; // Sound Controller 9 (GM2 default: Vibrato Delay) > dontResetControls[79] = true; // Sound Controller 10 (GM2 default: Undefined) > - dontResetControls[84] = true; // Portamento Controller > dontResetControls[120] = true; // All Sound Off > dontResetControls[121] = true; // Reset All Controllers > dontResetControls[122] = true; // Local Control On/Off > @@ -94,7 +93,6 @@ > protected double portamento_time = 1; // keyschanges per control buffer time > protected int[] portamento_lastnote = new int[128]; > protected int portamento_lastnote_ix = 0; > - private int portamento_control_note = -1; > private boolean portamento = false; > private boolean mono = false; > private boolean mute = false; > @@ -370,12 +368,12 @@ > voice.setSoloMute(solomute); > if (releaseTriggered) > return; > - if (portamento_control_note != -1) { > + if (controller[84] != 0) { > voice.co_noteon_keynumber[0] > - = (tuning.getTuning(portamento_control_note) / 100.0) > + = (tuning.getTuning(controller[84]) / 100.0) > * (1f / 128f); > voice.portamento = true; > - portamento_control_note = -1; > + controlChange(84, 0); > } else if (portamento) { > if (mono) { > if (portamento_lastnote[0] != -1) { > @@ -383,7 +381,7 @@ > = (tuning.getTuning(portamento_lastnote[0]) / 100.0) > * (1f / 128f); > voice.portamento = true; > - portamento_control_note = -1; > + controlChange(84, 0); > } > portamento_lastnote[0] = noteNumber; > } else { > @@ -450,19 +448,19 @@ > } > } > > - if (portamento_control_note != -1) { > + if (controller[84] != 0) { > boolean n_found = false; > for (int i = 0; i < voices.length; i++) { > if (voices[i].on && voices[i].channel == channel > && voices[i].active > - && voices[i].note == portamento_control_note > + && voices[i].note == controller[84] > && voices[i].releaseTriggered == false) { > voices[i].portamento = true; > voices[i].setNote(noteNumber); > n_found = true; > } > } > - portamento_control_note = -1; > + controlChange(84, 0); > if (n_found) > return; > } > @@ -1154,9 +1152,6 @@ > } > } > break; > - case 84: > - portamento_control_note = value; > - break; > case 98: > nrpn_control = (nrpn_control & (127 << 7)) + value; > rpn_control = RPN_NULL_VALUE; > @@ -1398,10 +1393,6 @@ > controlChange(i, 0); > } > > - // Portamento Controller (0x54) has to reset > - // to -1 which mean that Portamento Controller is off > - portamento_control_note = -1; > - > controlChange(71, 64); // Filter Resonance > controlChange(72, 64); // Release Time > controlChange(73, 64); // Attack Time > From kalli at midverk.is Mon Mar 30 23:40:01 2009 From: kalli at midverk.is (kalli at midverk.is) Date: Tue, 31 Mar 2009 06:40:01 +0000 Subject: hg: jdk6/jdk6/jdk: 2 new changesets Message-ID: <20090331064019.E4070ECF6@hg.openjdk.java.net> Changeset: 4810e811c95f Author: kalli Date: 2009-03-31 06:33 +0000 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/4810e811c95f 6823445: Gervill SoftChannel/ResetAllControllers jtreg test fails after portamento fix from last merge. Reviewed-by: amenkov ! src/share/classes/com/sun/media/sound/SoftChannel.java Changeset: 44712e5d9b40 Author: kalli Date: 2009-03-31 06:35 +0000 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/44712e5d9b40 6823446: Gervill SoftLowFrequencyOscillator fails when freq is set to 0 cent or 8.1758 Hz. Reviewed-by: amenkov ! src/share/classes/com/sun/media/sound/SoftLowFrequencyOscillator.java + test/javax/sound/midi/Gervill/SoftLowFrequencyOscillator/TestProcessControlLogic.java From Joe.Darcy at Sun.COM Tue Mar 31 01:16:58 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Tue, 31 Mar 2009 01:16:58 -0700 Subject: hg: jdk6/jdk6/jdk: 2 new changesets In-Reply-To: <20090331064019.E4070ECF6@hg.openjdk.java.net> References: <20090331064019.E4070ECF6@hg.openjdk.java.net> Message-ID: <49D1D17A.30201@sun.com> Hello. I've marked these as fixed in b17 in Sun's bug database. Thanks, -Joe kalli at midverk.is wrote: > Changeset: 4810e811c95f > Author: kalli > Date: 2009-03-31 06:33 +0000 > URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/4810e811c95f > > 6823445: Gervill SoftChannel/ResetAllControllers jtreg test fails after portamento fix from last merge. > Reviewed-by: amenkov > > ! src/share/classes/com/sun/media/sound/SoftChannel.java > > Changeset: 44712e5d9b40 > Author: kalli > Date: 2009-03-31 06:35 +0000 > URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/44712e5d9b40 > > 6823446: Gervill SoftLowFrequencyOscillator fails when freq is set to 0 cent or 8.1758 Hz. > Reviewed-by: amenkov > > ! src/share/classes/com/sun/media/sound/SoftLowFrequencyOscillator.java > + test/javax/sound/midi/Gervill/SoftLowFrequencyOscillator/TestProcessControlLogic.java > >