Need reviewers for changes in java/net regression tests
ptisnovs at redhat.com
Tue Aug 17 06:23:37 PDT 2010
Joe Darcy wrote:
> Hello Pavel.
> In principle, I approve this sort of change, but I'd like some
> clarifications before granting final approval
> Pavel Tisnovsky wrote:
>> I tried to backport more regression tests from OpenJDK7 to OpenJDK6.
>> Webrev with changes is available at:
> It would be helpful to know what JDK 7 changesets these fixes came from
> and what the differences from the JDK 7 changes are in OpenJDK 6.
many of these fixes came from
which was made by Chris to fixe bug
Is it possible to push the fixes with this bug ID in case I didn't
included all changes because of differences between JDK6 and JDK7?
>> Can anyone please review the changes?
>> There are still minor differences between OpenJDK6 and OpenJDK7 tests,
>> mainly due to syntax enhancements in OpenJDK7.
>> Please note that new test case (deserialization an Inet6 address with
>> a named interface) is included in
>> Inet6Address/serialize/Serialize.java regression test:
>> This issue which was fixed in OpenJDK7 but not in OpenJDK6 yet. Btw -
>> do anyone know, if this issue will be fixed in OpenJDK6?
> Generally, the @bug list in the test should indicate what bugs the test
> addresses. Is there a changeset for bug 6656849? If so, you could
> request approval to backport it.
>> The changes made in these test are really minor and they are based
>> (but not equal) on changes done by Christopher Hegarthy in OpenJDK7:
>> (these changes are reviewed by Alan Bateman)
>> Pavel Tisnovsky
More information about the jdk6-dev