Security fixes are back; other fixes can go in. Time for build 18?
Joseph D. Darcy
Joe.Darcy at Sun.COM
Wed Jan 6 19:27:11 PST 2010
Andrew John Hughes wrote:
> 2009/12/25 Andrew John Hughes <gnu_andrew at member.fsf.org>:
>> 2009/12/24 Joseph D. Darcy <Joe.Darcy at sun.com>:
>>> Andrew John Hughes wrote:
>>> The com.sun.java.swing package in OpenJDK should have the same effective
>>> compile-time visibility as in Sun JDK.
>> I don't know what that is; does this mean
>> com.sun.java.swing.plaf.nimbus is hidden in the proprietary JDK6? I
>> don't mind either way, it just seems that the other plaf packages are
>>> I'm going to start taking my vacation in earnest now so we can finish
>>> working through this issue early in 2010.
>>> Happy holidays,
> Happy new year! Any more thoughts on the above?
Yes, easing back from vacation and donning my fedora and bullwhip, I've
dug into what is going on here.
In brief, make/common/Release.gmk has a list of packages to exclude from
the ct.sym warning (6476749: "Exclude Swing plaf classes from Sun
Proprietary warning"); from
# The compiler should not issue a "Sun Propietary" warning when compiling
# classes in the com.sun.java.swing.plaf packages, since we've always
# allowed, and even advocated, extending them (see bug 6476749).
# This approach is NOT to be used as a general purpose way to avoid such
# compiler warnings for non-core packages. The correct way is to document
# the packages in NON_CORE_PKGS.gmk, and include them in the NON_CORE_PKGS
# Swing has taken this approach only as a temporary measure to avoid
# the compiler warnings until we can properly document these packages.
# This is covered under 6491853.
EXCLUDE_PROPWARN_PKGS = com.sun.java.swing.plaf \
In Sun's 6 update train, com.sun.java.swing.plaf.nimbus is included on
that package list. Therefore, the test file in question compiles
without warning using Sun's 6 update release. The corresponding
addition to this list has *not* been made in JDK 7, which is probably
just an oversight.
I'd support com.sun.java.swing.plaf.nimbus being included in this list
in OpenJDK 6 as long as
* The API of the package is the same as in Sun's 6 update release
* Kelly reviews the situation for any other build implications
In the 6 update train, the nimbus package was added to the list under
bug id 6616742, but for OpenJDK 6 I think we should use a fresh bug id
if this goes back.
Happy new year,
More information about the jdk6-dev