Need reviewers - another set of network regression sets patches
chris.hegarty at oracle.com
Thu Jul 29 07:10:06 PDT 2010
Pavel Tisnovsky wrote:
> Chris Hegarty wrote:
>> I see that there are 33 tests touched by this change. They seem to be
>> in different areas, CookieHandler, DatagramSocket, InetAddress,
>> Inet6Address, etc. Have you sync'ed all the tests in these areas or
>> are there more? I'm just trying to understand your methodology for
>> test selection.
> Yes, the tests are from different areas and AFAIK it is all changes
> between OpenJDK6 and OpenJDK7 network tests which could by synced
> without changing test behaviours. Other differences between O6 and O7
> network tests are more difficult and I think it is not possible to
> simply backport them.
OK great, thanks Pavel. I'll review the changes and get back to you.
>> I guess what I'm trying to avoid is a constant stream of CR's,
>> "backport random net tests", "backport more net tests", etc.
>> Pavel Tisnovsky wrote:
>>> Hi all,
>>> I've made another set of changes in network regression tests for
>>> OpenJDK6 and prepared them for review here:
>>> These changes only improve the test themselves (no new functionality
>>> were added), mainly in these areas:
>>> 1) the tests are properly closing opened ports, sockets, input
>>> streams etc.
>>> 2) some tests started in their own JVM (so they don't change
>>> environment for other tests)
>>> 3) some shellscripts are updated to work in Cygwin environment
>>> All changes are based on OpenJDK7 versions of regression tests.
>>> Can anyone please review the changes?
>>> Thank you in advance,
More information about the jdk6-dev