6-open putback request: 6948909 and 6948803
Weijun.Wang at Sun.COM
Mon May 24 15:58:34 PDT 2010
>>> For test/sun/security/tools/jarsigner/diffend.sh, I strongly encourage this to be rewritten as a Java program.
>> The test calls zip, unzip and jarsigner commands. It might be possible to convert all calls into Java methods but the result will be quite complicated and not easy to read. Almost all security tools tests are written as shell scripts.
> In langtools, we've taken to writing such code in Java using Runtime.exec; I recommend considering this approach for other shell tests too.
I'll consider it later.
> 6954621: small error in 6948909
> also needed in OpenJDK 6? If so, I approve all three bugs going back.
I've merged the code change in 6954621 into 6948909 for both 6u21 and 6-open. 6948909 is the main bug id anyway.
More information about the jdk6-dev