From gbenson at redhat.com Tue Nov 2 02:36:37 2010 From: gbenson at redhat.com (Gary Benson) Date: Tue, 2 Nov 2010 09:36:37 +0000 Subject: About time for b21? In-Reply-To: <4CCB6438.3040108@oracle.com> References: <4CB7A882.3080008@oracle.com> <20101027084357.GA3450@redhat.com> <4CCB6438.3040108@oracle.com> Message-ID: <20101102093637.GA3675@redhat.com> Joe Darcy wrote: > Gary Benson wrote: > > Joe Darcy wrote: > > > With Andrew's sync of HS19 into OpenJDK 6 and the recent batch > > > of security fixes coming real soon now, I think it is about time > > > to have b21. I'd hold b21 for the remaining bug fixes pushed to > > > HS19 that are not quite promoted yet. > > > > > > Are there any other changes that should be in b21? > > > > Building HS19 with Zero on PowerPC requires a fix (6994130). > > There's a webrev (for JDK7, but it's the same) here: > > > > http://cr.openjdk.java.net/~gbenson/zero-ppc-fix/ > > > > Would it be possible to backport this? > > Once 6994130 is approved and integrated into JDK 7, I approve it > being backported to OpenJDK 6. Thanks Joe. Cheers, Gary -- http://gbenson.net/ From alex.menkov at sun.com Tue Nov 2 05:36:32 2010 From: alex.menkov at sun.com (alex.menkov at sun.com) Date: Tue, 02 Nov 2010 12:36:32 +0000 Subject: hg: jdk6/jdk6/jdk: 6950553: Applet: IE process crash in OLE32.DLL when playing a sound Message-ID: <20101102123649.C92AF4764B@hg.openjdk.java.net> Changeset: 8433a117784f Author: amenkov Date: 2010-11-02 15:19 +0300 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/8433a117784f 6950553: Applet: IE process crash in OLE32.DLL when playing a sound Reviewed-by: poonam ! make/javax/sound/jsoundds/Makefile ! src/windows/native/com/sun/media/sound/PLATFORM_API_WinOS_DirectSound.cpp From jvanek at redhat.com Tue Nov 2 09:11:50 2010 From: jvanek at redhat.com (Jiri Vanek) Date: Tue, 02 Nov 2010 17:11:50 +0100 Subject: patch for Asian fonts for fedora, changing paths to fonts files. Dependencies are necessary to be added to rpms. Message-ID: <4CD03846.5060103@redhat.com> *** fontconfig.Fedora.properties.src 2010-11-02 15:47:08.042037406 +0100 --- fontconfig.Fedora.properties.src 2010-11-02 15:42:43.000000000 +0100 *************** *** 356,367 **** filename.DejaVu_Serif_Oblique=/usr/share/fonts/dejavu/DejaVuSerif-Oblique.ttf filename.DejaVu_Serif_Bold_Oblique=/usr/share/fonts/dejavu/DejaVuSerif-BoldOblique.ttf ! filename.Sazanami_Gothic=/usr/share/fonts/sazanami-fonts-gothic/sazanami-gothic.ttf ! filename.Sazanami_Mincho=/usr/share/fonts/sazanami-fonts-mincho/sazanami-mincho.ttf ! filename.AR_PL_ShanHeiSun_Uni=/usr/share/fonts/cjkunifonts-uming/uming.ttc ! filename.AR_PL_ZenKai_Uni=/usr/share/fonts/cjkunifonts-ukai/ukai.ttc ! filename.Baekmuk_Gulim=/usr/share/fonts/baekmuk-ttf-gulim/gulim.ttf ! filename.Baekmuk_Batang=/usr/share/fonts/baekmuk-ttf-batang/batang.ttf filename.Lohit_Bengali=/usr/share/fonts/lohit-bengali/lohit_bn.ttf filename.Lohit_Gujarati=/usr/share/fonts/lohit-gujarati/lohit_gu.ttf --- 356,367 ---- filename.DejaVu_Serif_Oblique=/usr/share/fonts/dejavu/DejaVuSerif-Oblique.ttf filename.DejaVu_Serif_Bold_Oblique=/usr/share/fonts/dejavu/DejaVuSerif-BoldOblique.ttf ! filename.Sazanami_Gothic=/usr/share/fonts/sazanami/gothic/sazanami-gothic.ttf ! filename.Sazanami_Mincho=/usr/share/fonts/sazanami/mincho/sazanami-mincho.ttf ! filename.AR_PL_ShanHeiSun_Uni=/usr/share/fonts/cjkuni-uming/uming.ttc ! filename.AR_PL_ZenKai_Uni=/usr/share/fonts/cjkuni-ukai/ukai.ttc ! filename.Baekmuk_Gulim=/usr/share/fonts/baekmuk-ttf/gulim.ttf ! filename.Baekmuk_Batang=/usr/share/fonts/baekmuk-ttf/batang.ttf filename.Lohit_Bengali=/usr/share/fonts/lohit-bengali/lohit_bn.ttf filename.Lohit_Gujarati=/usr/share/fonts/lohit-gujarati/lohit_gu.ttf From joe.darcy at oracle.com Tue Nov 2 10:44:17 2010 From: joe.darcy at oracle.com (Joe Darcy) Date: Tue, 02 Nov 2010 10:44:17 -0700 Subject: hg: jdk6/jdk6/jdk: 6950553: Applet: IE process crash in OLE32.DLL when playing a sound In-Reply-To: <20101102123649.C92AF4764B@hg.openjdk.java.net> References: <20101102123649.C92AF4764B@hg.openjdk.java.net> Message-ID: <4CD04DF1.5060300@oracle.com> alex.menkov at sun.com wrote: > Changeset: 8433a117784f > Author: amenkov > Date: 2010-11-02 15:19 +0300 > URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/8433a117784f > > 6950553: Applet: IE process crash in OLE32.DLL when playing a sound > Reviewed-by: poonam > > ! make/javax/sound/jsoundds/Makefile > ! src/windows/native/com/sun/media/sound/PLATFORM_API_WinOS_DirectSound.cpp > > Hello Alex. Per the OpenJDK 6 processes, http://openjdk.java.net/projects/jdk6/, "With the exception of security fixes, all OpenJDK 6 code review traffic should be sent to jdk6-dev at openjdk.java.net for consideration before a commit occurs." This was not done for this fix. I've looked at the changes and the bug and the change is appropriate for OpenJDK 6 so I grant retroactive approval for the fix going in. -Joe From joe.darcy at oracle.com Tue Nov 2 11:02:46 2010 From: joe.darcy at oracle.com (Joe Darcy) Date: Tue, 02 Nov 2010 11:02:46 -0700 Subject: patch for Asian fonts for fedora, changing paths to fonts files. Dependencies are necessary to be added to rpms. In-Reply-To: <4CD03846.5060103@redhat.com> References: <4CD03846.5060103@redhat.com> Message-ID: <4CD05246.7000405@oracle.com> Hello. Can you provide some context around this patch? Cheers, -Joe Jiri Vanek wrote: > *** fontconfig.Fedora.properties.src 2010-11-02 15:47:08.042037406 > +0100 > --- fontconfig.Fedora.properties.src 2010-11-02 15:42:43.000000000 > +0100 > *************** > *** 356,367 **** > > filename.DejaVu_Serif_Oblique=/usr/share/fonts/dejavu/DejaVuSerif-Oblique.ttf > > > filename.DejaVu_Serif_Bold_Oblique=/usr/share/fonts/dejavu/DejaVuSerif-BoldOblique.ttf > > > ! > filename.Sazanami_Gothic=/usr/share/fonts/sazanami-fonts-gothic/sazanami-gothic.ttf > > ! > filename.Sazanami_Mincho=/usr/share/fonts/sazanami-fonts-mincho/sazanami-mincho.ttf > > ! > filename.AR_PL_ShanHeiSun_Uni=/usr/share/fonts/cjkunifonts-uming/uming.ttc > > ! filename.AR_PL_ZenKai_Uni=/usr/share/fonts/cjkunifonts-ukai/ukai.ttc > ! filename.Baekmuk_Gulim=/usr/share/fonts/baekmuk-ttf-gulim/gulim.ttf > ! filename.Baekmuk_Batang=/usr/share/fonts/baekmuk-ttf-batang/batang.ttf > > filename.Lohit_Bengali=/usr/share/fonts/lohit-bengali/lohit_bn.ttf > filename.Lohit_Gujarati=/usr/share/fonts/lohit-gujarati/lohit_gu.ttf > --- 356,367 ---- > > filename.DejaVu_Serif_Oblique=/usr/share/fonts/dejavu/DejaVuSerif-Oblique.ttf > > > filename.DejaVu_Serif_Bold_Oblique=/usr/share/fonts/dejavu/DejaVuSerif-BoldOblique.ttf > > > ! > filename.Sazanami_Gothic=/usr/share/fonts/sazanami/gothic/sazanami-gothic.ttf > > ! > filename.Sazanami_Mincho=/usr/share/fonts/sazanami/mincho/sazanami-mincho.ttf > > ! filename.AR_PL_ShanHeiSun_Uni=/usr/share/fonts/cjkuni-uming/uming.ttc > ! filename.AR_PL_ZenKai_Uni=/usr/share/fonts/cjkuni-ukai/ukai.ttc > ! filename.Baekmuk_Gulim=/usr/share/fonts/baekmuk-ttf/gulim.ttf > ! filename.Baekmuk_Batang=/usr/share/fonts/baekmuk-ttf/batang.ttf > > filename.Lohit_Bengali=/usr/share/fonts/lohit-bengali/lohit_bn.ttf > filename.Lohit_Gujarati=/usr/share/fonts/lohit-gujarati/lohit_gu.ttf From philip.race at oracle.com Tue Nov 2 11:38:37 2010 From: philip.race at oracle.com (Phil Race) Date: Tue, 02 Nov 2010 11:38:37 -0700 Subject: patch for Asian fonts for fedora, changing paths to fonts files. Dependencies are necessary to be added to rpms. In-Reply-To: <4CD03846.5060103@redhat.com> References: <4CD03846.5060103@redhat.com> Message-ID: <4CD05AAD.4080106@oracle.com> Is this because some new version of Fedora moved the fonts ? If you fix these then any one running on the old version of Fedora will be broken by this. What needs to happen is that you first copy the existing fontconfig.Fedora.properties.src to match the old version, eg : % cp fontconfig.Fedora.properties.src fontconfig.Fedora.9.properties.src Then that will get picked up on the old version. You'd need to to this for all older versions you think are worthy of support, eg if your proposed change is for v. 11 and the old file is applicable to v.10 as well then you'd also need to do % cp fontconfig.Fedora.9.properties.src fontconfig.Fedora.10.properties.src For more information read http://download.oracle.com/javase/6/docs/technotes/guides/intl/fontconfig.html -phil. On 11/2/2010 9:11 AM, Jiri Vanek wrote: > *** fontconfig.Fedora.properties.src 2010-11-02 15:47:08.042037406 > +0100 > --- fontconfig.Fedora.properties.src 2010-11-02 15:42:43.000000000 > +0100 > *************** > *** 356,367 **** > > filename.DejaVu_Serif_Oblique=/usr/share/fonts/dejavu/DejaVuSerif-Oblique.ttf > > > filename.DejaVu_Serif_Bold_Oblique=/usr/share/fonts/dejavu/DejaVuSerif-BoldOblique.ttf > > > ! > filename.Sazanami_Gothic=/usr/share/fonts/sazanami-fonts-gothic/sazanami-gothic.ttf > ! > filename.Sazanami_Mincho=/usr/share/fonts/sazanami-fonts-mincho/sazanami-mincho.ttf > ! > filename.AR_PL_ShanHeiSun_Uni=/usr/share/fonts/cjkunifonts-uming/uming.ttc > ! filename.AR_PL_ZenKai_Uni=/usr/share/fonts/cjkunifonts-ukai/ukai.ttc > ! filename.Baekmuk_Gulim=/usr/share/fonts/baekmuk-ttf-gulim/gulim.ttf > ! filename.Baekmuk_Batang=/usr/share/fonts/baekmuk-ttf-batang/batang.ttf > > filename.Lohit_Bengali=/usr/share/fonts/lohit-bengali/lohit_bn.ttf > filename.Lohit_Gujarati=/usr/share/fonts/lohit-gujarati/lohit_gu.ttf > --- 356,367 ---- > > filename.DejaVu_Serif_Oblique=/usr/share/fonts/dejavu/DejaVuSerif-Oblique.ttf > > > filename.DejaVu_Serif_Bold_Oblique=/usr/share/fonts/dejavu/DejaVuSerif-BoldOblique.ttf > > > ! > filename.Sazanami_Gothic=/usr/share/fonts/sazanami/gothic/sazanami-gothic.ttf > ! > filename.Sazanami_Mincho=/usr/share/fonts/sazanami/mincho/sazanami-mincho.ttf > ! filename.AR_PL_ShanHeiSun_Uni=/usr/share/fonts/cjkuni-uming/uming.ttc > ! filename.AR_PL_ZenKai_Uni=/usr/share/fonts/cjkuni-ukai/ukai.ttc > ! filename.Baekmuk_Gulim=/usr/share/fonts/baekmuk-ttf/gulim.ttf > ! filename.Baekmuk_Batang=/usr/share/fonts/baekmuk-ttf/batang.ttf > > filename.Lohit_Bengali=/usr/share/fonts/lohit-bengali/lohit_bn.ttf > filename.Lohit_Gujarati=/usr/share/fonts/lohit-gujarati/lohit_gu.ttf From mark at klomp.org Tue Nov 2 13:02:21 2010 From: mark at klomp.org (Mark Wielaard) Date: Tue, 02 Nov 2010 21:02:21 +0100 Subject: hs19 import In-Reply-To: <4CB5F174.6030405@oracle.com> References: <4C982CD6.2050405@oracle.com> <4C98D489.4080009@oracle.com> <20100921224624.GA9599@rivendell.middle-earth.co.uk> <4C9B8466.8040304@oracle.com> <20101008140837.GB1907@rivendell.middle-earth.co.uk> <4CAF6E74.3010306@oracle.com> <20101012123723.GD6208@rivendell.middle-earth.co.uk> <4CB4D8CE.9060105@oracle.com> <20101013122712.GA24733@rivendell.middle-earth.co.uk> <4CB5A7B2.8000806@oracle.com> <20101013165852.GH24733@rivendell.middle-earth.co.uk> <4CB5F174.6030405@oracle.com> Message-ID: <1288728141.4246.346.camel@springer.wildebeest.org> Hi Erik, On Wed, 2010-10-13 at 10:50 -0700, Erik Trimble wrote: > On 10/13/2010 9:58 AM, Dr Andrew John Hughes wrote: > > On 14:36 Wed 13 Oct , Dalibor Topic wrote: > >> On 10/13/10 2:27 PM, Dr Andrew John Hughes wrote: > >> > >>> I don't see anything new: > >>> > >>> $ hg in http://hg.openjdk.java.net/hsx/hsx19/master > >>> comparing with http://hg.openjdk.java.net/hsx/hsx19/master > >>> searching for changes > >>> no changes found > >> I think they went into baseline rather then master. :/ > >> > > Then, AIUI, we don't want them yet; we wait until they are promoted. > > They should be promoted shortly - I just finished testing, and > everything went fine,but SQE's testing tool isn't producing the proper > test certification (that big thing that lists all the CRs and status) > properly. I'm waiting to get that fixed and have a cert in-hand before > I promote baseline to master. I see these changes on baseline (hs19-b09) are still not promoted to master (hs19-b06). Does that mean you found issues, feel it needs more testing, or still just stuck on the testing tool? Do you think the changes between b06 and b09 should go into the openjdk6 hotspot (for openjdk6-b21) or would it be better not to for now? Thanks, Mark From dlila at redhat.com Tue Nov 2 13:55:18 2010 From: dlila at redhat.com (Denis Lila) Date: Tue, 2 Nov 2010 16:55:18 -0400 (EDT) Subject: Request to backport: 4285edea9ddb and d47bd9d94ba4 In-Reply-To: <489937029.2111921288727350014.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Message-ID: <395455341.2119891288731318073.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Hello. I'd like to backport these two changesets. They're improvements to the rendering engine: performance, implementing STROKE_CONTROL, fixing overflow issues (so, to various extents, pretty much everything in here http://openjdk.java.net/projects/graphics-rasterizer/), and a few other rendering bugs. Thanks, Denis. From erik.trimble at oracle.com Tue Nov 2 14:04:25 2010 From: erik.trimble at oracle.com (Erik Trimble) Date: Tue, 02 Nov 2010 14:04:25 -0700 Subject: hs19 import In-Reply-To: <1288728141.4246.346.camel@springer.wildebeest.org> References: <4C982CD6.2050405@oracle.com> <4C98D489.4080009@oracle.com> <20100921224624.GA9599@rivendell.middle-earth.co.uk> <4C9B8466.8040304@oracle.com> <20101008140837.GB1907@rivendell.middle-earth.co.uk> <4CAF6E74.3010306@oracle.com> <20101012123723.GD6208@rivendell.middle-earth.co.uk> <4CB4D8CE.9060105@oracle.com> <20101013122712.GA24733@rivendell.middle-earth.co.uk> <4CB5A7B2.8000806@oracle.com> <20101013165852.GH24733@rivendell.middle-earth.co.uk> <4CB5F174.6030405@oracle.com> <1288728141.4246.346.camel@springer.wildebeest.org> Message-ID: <4CD07CD9.9030404@oracle.com> On 11/2/2010 1:02 PM, Mark Wielaard wrote: > Hi Erik, > > On Wed, 2010-10-13 at 10:50 -0700, Erik Trimble wrote: >> On 10/13/2010 9:58 AM, Dr Andrew John Hughes wrote: >>> On 14:36 Wed 13 Oct , Dalibor Topic wrote: >>>> On 10/13/10 2:27 PM, Dr Andrew John Hughes wrote: >>>> >>>>> I don't see anything new: >>>>> >>>>> $ hg in http://hg.openjdk.java.net/hsx/hsx19/master >>>>> comparing with http://hg.openjdk.java.net/hsx/hsx19/master >>>>> searching for changes >>>>> no changes found >>>> I think they went into baseline rather then master. :/ >>>> >>> Then, AIUI, we don't want them yet; we wait until they are promoted. >> They should be promoted shortly - I just finished testing, and >> everything went fine,but SQE's testing tool isn't producing the proper >> test certification (that big thing that lists all the CRs and status) >> properly. I'm waiting to get that fixed and have a cert in-hand before >> I promote baseline to master. > I see these changes on baseline (hs19-b09) are still not promoted to > master (hs19-b06). Does that mean you found issues, feel it needs more > testing, or still just stuck on the testing tool? > > Do you think the changes between b06 and b09 should go into the openjdk6 > hotspot (for openjdk6-b21) or would it be better not to for now? > > Thanks, > > Mark I'll re-check, but I think it may have been a simple oversight on my part, not anything insidious. :-) -- Erik Trimble Java System Support Mailstop: usca22-123 Phone: x17195 Santa Clara, CA From joe.darcy at oracle.com Tue Nov 2 14:27:22 2010 From: joe.darcy at oracle.com (Joe Darcy) Date: Tue, 02 Nov 2010 14:27:22 -0700 Subject: Request to backport: 4285edea9ddb and d47bd9d94ba4 In-Reply-To: <395455341.2119891288731318073.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> References: <395455341.2119891288731318073.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Message-ID: <4CD0823A.9050107@oracle.com> Denis Lila wrote: > Hello. > > I'd like to backport these two changesets. > They're improvements to the rendering engine: > performance, implementing STROKE_CONTROL, fixing > overflow issues (so, to various extents, pretty much everything in > here http://openjdk.java.net/projects/graphics-rasterizer/), > and a few other rendering bugs. > > Thanks, > Denis. > Those are bugs 6976265 OpenJDK: STROKE_CONTROL not supported 6967436: lines longer than 2^15 can fill window. 6967433: dashed lines broken when using scaling transforms. They seem fine for OpenJDK 6, but unless there is an urgent need for the fixes, I'd prefer them going into the next build, b22, rather than the current one, b21. Cheers, -Joe From dlila at redhat.com Tue Nov 2 15:50:36 2010 From: dlila at redhat.com (Denis Lila) Date: Tue, 2 Nov 2010 18:50:36 -0400 (EDT) Subject: Request to backport: 4285edea9ddb and d47bd9d94ba4 In-Reply-To: <4CD0823A.9050107@oracle.com> Message-ID: <2119575927.2128361288738236105.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> > They seem fine for OpenJDK 6, but unless there is an urgent need for > the fixes, I'd prefer them going into the next build, b22, rather than the > current one, b21. Not a problem - they can I can wait until b22. Regards, Denis. ----- "Joe Darcy" wrote: > Denis Lila wrote: > > Hello. > > > > I'd like to backport these two changesets. > > They're improvements to the rendering engine: > > performance, implementing STROKE_CONTROL, fixing > > overflow issues (so, to various extents, pretty much everything in > > here http://openjdk.java.net/projects/graphics-rasterizer/), > > and a few other rendering bugs. > > > > Thanks, > > Denis. > > > > Those are bugs > > 6976265 OpenJDK: STROKE_CONTROL not supported > > 6967436: lines longer than 2^15 can fill window. > 6967433: dashed lines broken when using scaling transforms. > > Cheers, > > -Joe From ahughes at redhat.com Wed Nov 3 10:41:09 2010 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Wed, 3 Nov 2010 17:41:09 +0000 Subject: hs19 import In-Reply-To: <4CD07CD9.9030404@oracle.com> References: <20101008140837.GB1907@rivendell.middle-earth.co.uk> <4CAF6E74.3010306@oracle.com> <20101012123723.GD6208@rivendell.middle-earth.co.uk> <4CB4D8CE.9060105@oracle.com> <20101013122712.GA24733@rivendell.middle-earth.co.uk> <4CB5A7B2.8000806@oracle.com> <20101013165852.GH24733@rivendell.middle-earth.co.uk> <4CB5F174.6030405@oracle.com> <1288728141.4246.346.camel@springer.wildebeest.org> <4CD07CD9.9030404@oracle.com> Message-ID: <20101103174109.GD4256@rivendell.middle-earth.co.uk> On 14:04 Tue 02 Nov , Erik Trimble wrote: > On 11/2/2010 1:02 PM, Mark Wielaard wrote: > > Hi Erik, > > > > On Wed, 2010-10-13 at 10:50 -0700, Erik Trimble wrote: > >> On 10/13/2010 9:58 AM, Dr Andrew John Hughes wrote: > >>> On 14:36 Wed 13 Oct , Dalibor Topic wrote: > >>>> On 10/13/10 2:27 PM, Dr Andrew John Hughes wrote: > >>>> > >>>>> I don't see anything new: > >>>>> > >>>>> $ hg in http://hg.openjdk.java.net/hsx/hsx19/master > >>>>> comparing with http://hg.openjdk.java.net/hsx/hsx19/master > >>>>> searching for changes > >>>>> no changes found > >>>> I think they went into baseline rather then master. :/ > >>>> > >>> Then, AIUI, we don't want them yet; we wait until they are promoted. > >> They should be promoted shortly - I just finished testing, and > >> everything went fine,but SQE's testing tool isn't producing the proper > >> test certification (that big thing that lists all the CRs and status) > >> properly. I'm waiting to get that fixed and have a cert in-hand before > >> I promote baseline to master. > > I see these changes on baseline (hs19-b09) are still not promoted to > > master (hs19-b06). Does that mean you found issues, feel it needs more > > testing, or still just stuck on the testing tool? > > > > Do you think the changes between b06 and b09 should go into the openjdk6 > > hotspot (for openjdk6-b21) or would it be better not to for now? > > > > Thanks, > > > > Mark > > I'll re-check, but I think it may have been a simple oversight on my > part, not anything insidious. :-) > > -- > Erik Trimble > Java System Support > Mailstop: usca22-123 > Phone: x17195 > Santa Clara, CA > With both the master and baseline versions of hs19, we are hitting this bug: https://bugzilla.redhat.com/show_bug.cgi?id=647737 This really needs to be fixed before we can release OpenJDK6 b21 with HotSpot 19. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From aph at redhat.com Thu Nov 4 06:15:59 2010 From: aph at redhat.com (Andrew Haley) Date: Thu, 04 Nov 2010 13:15:59 +0000 Subject: Backport BigDecimal performance patches Message-ID: <4CD2B20F.3000503@redhat.com> This is a backport of the BigDecimal performance rewrite. http://cr.openjdk.java.net/~aph/6622432-openjdk6-webrev/ rev 397 : 6622432: RFE: Performance improvements to java.math.BigDecimal Reviewed-by: darcy rev 398 : 6850606: Regression from JDK 1.6.0_12 Summary: The returned result from multiply should be constructed by using valueOf to take care of the INFLATED case. Reviewed-by: darcy rev 399 : 6876282: BigDecimal's divide(BigDecimal bd, RoundingFormat r) produces incorrect result Reviewed-by: darcy The patches didn't quite apply cleanly, but once I fixed them up by hand there were no regressions of either the JCK or JTreg. Given that 2000 lines of patch is rather hard to read, I have attached a diff between the patched jdk6 and the current jdk7 tree. OK for jdk6? Thanks, Andrew. -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: pp Url: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20101104/09f53003/attachment.ksh From joe.darcy at oracle.com Thu Nov 4 12:34:28 2010 From: joe.darcy at oracle.com (Joe Darcy) Date: Thu, 04 Nov 2010 12:34:28 -0700 Subject: Backport BigDecimal performance patches In-Reply-To: <4CD2B20F.3000503@redhat.com> References: <4CD2B20F.3000503@redhat.com> Message-ID: <4CD30AC4.9080705@oracle.com> Andrew Haley wrote: > This is a backport of the BigDecimal performance rewrite. > http://cr.openjdk.java.net/~aph/6622432-openjdk6-webrev/ > > rev 397 : 6622432: RFE: Performance improvements to java.math.BigDecimal > Reviewed-by: darcy > rev 398 : 6850606: Regression from JDK 1.6.0_12 > Summary: The returned result from multiply should be constructed by using valueOf to take care of the INFLATED case. > Reviewed-by: darcy > rev 399 : 6876282: BigDecimal's divide(BigDecimal bd, RoundingFormat r) produces incorrect result > Reviewed-by: darcy > > The patches didn't quite apply cleanly, but once I fixed them up by hand > there were no regressions of either the JCK or JTreg. > > Given that 2000 lines of patch is rather hard to read, I have attached > a diff between the patched jdk6 and the current jdk7 tree. > > OK for jdk6? > > Hi Andrew. I approve this backport in principle, but need to look over the diffs more closely before giving the final okay. There were some spec changes in BigInteger/BigDecimal in JDK 7; you seem to have correctly adjusted the patches for OpenJDK 6, but I just want to verify that. Thanks for including the diff against JDK 7; that is a big aid in reviewing :-) -Joe From erik.trimble at oracle.com Thu Nov 4 16:31:45 2010 From: erik.trimble at oracle.com (Erik Trimble) Date: Thu, 04 Nov 2010 16:31:45 -0700 Subject: hs19 b09 has been officially promoted... Message-ID: <1288913505.13635.13.camel@ghostbox> Build 09 of Hotspot 19 for OpenJDK has been promoted. The tip for the source to this build is here: http://hg.openjdk.java.net/hsx/hsx19/master/rev/a299307a934e --------- Component : VM Status : 0 major failures, 0 minor failures Date : 10/22/2010 at 02:41 Tested By : VM SQE & Leonid.Mesnik at oracle.com Cost(total man-days): 1 Workspace : /java/jdk/ws/hotspot/ws/master Bundles : /net/jprt-web/jprt/archive/2010/10/2010-10-08-203303.et151817.hs19b09 Platforms : Solaris Sparc 11(32), -client Solaris Sparc 11(32), -server Solaris Sparc 10(32), -client Solaris Sparc 10(32), -server Windows Vista 32 bit, -client Windows Vista 32 bit, -server Windows Vista 64 bit, -client Windows Vista 64 bit, -server RH AS4.0 (32), -client RH AS4.0 (32), -server SuSE SLES 8(32), -client SuSE SLES 8(32), -server Tests : /net/sqenfs-1.sfbay/export1/comp/vm/testbase Browsers : NA Patches : NA Logs : http://sqeweb.sfbay.sun.com/nfs/results/vm/gtee/HSX/PIT/VM/19/b09/jdk6u23b02/product Number of Tests Executed : 126436 product tests, 0 unit tests, 0 tck tests Bug verification status: ====================================== Tested, Pass: 6942771: SEGV in ParScanThreadState::take_from_overflow_stack 6966589: hs16-b08 causes java.lang.StackOverflowError 6980792: Crash "exception happened outside interpreter, nmethods and vtable stubs (1)" 6986028: assert(_base == Int) failed: Not an Int in CmpINode::sub 6988018: dtrace/hotspot/MethodInvocation/MethodInvocation002 crashes with client compiler Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: Setup is not available: 6423256: GC stacks should use a better data structure 6916062: assert(_inserts <= _insert_limit,"hash table overflow") in NodeHash::hash_insert with debug build 6965815: OptimizeStringConcat: assert(!q->is_MergeMem()) failed with specjbb2000 6982537: Crash in Node*step_through_mergemem 6987149: Fix incorrect Oracle copyright header in make/templates files 6988678: fatal error deadlock handling was unintentionally disabled 6990124: supplemental fix for 6361589 Build change only: 6990756: Bump the HS19 build number to 09 New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: Number of PIT requested: 1 Integration target J2SE build number: 6u23-b02 Issues and Notes: This is HS 19 b09 PIT for JDK 6u23 b02. ------------------------------- >From VM SQE & Leonid.Mesnik at oracle.com -- Erik Trimble Java System Support Mailstop: usca22-317 Phone: x67195 Santa Clara, CA Timezone: US/Pacific (GMT-0800) From ahughes at redhat.com Fri Nov 5 06:24:32 2010 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Fri, 5 Nov 2010 13:24:32 +0000 Subject: Backport BigDecimal performance patches In-Reply-To: <4CD30AC4.9080705@oracle.com> References: <4CD2B20F.3000503@redhat.com> <4CD30AC4.9080705@oracle.com> Message-ID: <20101105132432.GA9718@rivendell.middle-earth.co.uk> On 12:34 Thu 04 Nov , Joe Darcy wrote: > Andrew Haley wrote: > > This is a backport of the BigDecimal performance rewrite. > > http://cr.openjdk.java.net/~aph/6622432-openjdk6-webrev/ > > > > rev 397 : 6622432: RFE: Performance improvements to java.math.BigDecimal > > Reviewed-by: darcy > > rev 398 : 6850606: Regression from JDK 1.6.0_12 > > Summary: The returned result from multiply should be constructed by using valueOf to take care of the INFLATED case. > > Reviewed-by: darcy > > rev 399 : 6876282: BigDecimal's divide(BigDecimal bd, RoundingFormat r) produces incorrect result > > Reviewed-by: darcy > > > > The patches didn't quite apply cleanly, but once I fixed them up by hand > > there were no regressions of either the JCK or JTreg. > > > > Given that 2000 lines of patch is rather hard to read, I have attached > > a diff between the patched jdk6 and the current jdk7 tree. > > > > OK for jdk6? > > > > > > Hi Andrew. > > I approve this backport in principle, but need to look over the diffs > more closely before giving the final okay. There were some spec changes > in BigInteger/BigDecimal in JDK 7; you seem to have correctly adjusted > the patches for OpenJDK 6, but I just want to verify that. > > Thanks for including the diff against JDK 7; that is a big aid in > reviewing :-) > > -Joe FWIW, the changes Andrew has backported: changeset: 1794:98558a60c555 user: darcy date: Wed Oct 21 09:53:23 2009 -0700 summary: 6560935: BigInteger.modPow() throws ArithmeticException for negative exponent changeset: 1785:0dd3d16e8183 user: darcy date: Tue Oct 20 09:51:28 2009 -0700 summary: 6371401: java.math.BigInteger.shift(Integer.MIN_VALUE) throws StackOverflowError changeset: 1246:8d2efec31d78 user: xlu date: Sun May 24 16:29:57 2009 -0700 summary: 6622432: RFE: Performance improvements to java.math.BigDecimal don't include the spec. changes, which do appear in the jdk7 diff he supplied. They seem to have occurred prior to OpenJDK entering Mercurial with b24. See: http://hg.openjdk.java.net/jdk7/jdk7/jdk/file/0/src/share/classes/java/math/BigInteger.java and were then reverted in OpenJDK6: changeset: 2:39e8fe7a0af1 tag: jdk6-b00 user: ohair date: Fri Jan 30 16:05:57 2009 -0800 summary: 6755277: All initial changes to jdk7 to create openjdk 6 build 0 http://hg.openjdk.java.net/jdk6/jdk6/jdk/diff/39e8fe7a0af1/src/share/classes/java/math/BigInteger.java -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From joe.darcy at oracle.com Fri Nov 5 11:05:45 2010 From: joe.darcy at oracle.com (Joe Darcy) Date: Fri, 05 Nov 2010 11:05:45 -0700 Subject: Backport BigDecimal performance patches In-Reply-To: <20101105132432.GA9718@rivendell.middle-earth.co.uk> References: <4CD2B20F.3000503@redhat.com> <4CD30AC4.9080705@oracle.com> <20101105132432.GA9718@rivendell.middle-earth.co.uk> Message-ID: <4CD44779.6020800@oracle.com> Dr Andrew John Hughes wrote: > On 12:34 Thu 04 Nov , Joe Darcy wrote: > >> Andrew Haley wrote: >> >>> This is a backport of the BigDecimal performance rewrite. >>> http://cr.openjdk.java.net/~aph/6622432-openjdk6-webrev/ >>> >>> rev 397 : 6622432: RFE: Performance improvements to java.math.BigDecimal >>> Reviewed-by: darcy >>> rev 398 : 6850606: Regression from JDK 1.6.0_12 >>> Summary: The returned result from multiply should be constructed by using valueOf to take care of the INFLATED case. >>> Reviewed-by: darcy >>> rev 399 : 6876282: BigDecimal's divide(BigDecimal bd, RoundingFormat r) produces incorrect result >>> Reviewed-by: darcy >>> >>> The patches didn't quite apply cleanly, but once I fixed them up by hand >>> there were no regressions of either the JCK or JTreg. >>> >>> Given that 2000 lines of patch is rather hard to read, I have attached >>> a diff between the patched jdk6 and the current jdk7 tree. >>> >>> OK for jdk6? >>> >>> >>> >> Hi Andrew. >> >> I approve this backport in principle, but need to look over the diffs >> more closely before giving the final okay. There were some spec changes >> in BigInteger/BigDecimal in JDK 7; you seem to have correctly adjusted >> the patches for OpenJDK 6, but I just want to verify that. >> >> Thanks for including the diff against JDK 7; that is a big aid in >> reviewing :-) >> >> -Joe >> > > FWIW, the changes Andrew has backported: > > changeset: 1794:98558a60c555 > user: darcy > date: Wed Oct 21 09:53:23 2009 -0700 > summary: 6560935: BigInteger.modPow() throws ArithmeticException for negative exponent > > changeset: 1785:0dd3d16e8183 > user: darcy > date: Tue Oct 20 09:51:28 2009 -0700 > summary: 6371401: java.math.BigInteger.shift(Integer.MIN_VALUE) throws StackOverflowError > > changeset: 1246:8d2efec31d78 > user: xlu > date: Sun May 24 16:29:57 2009 -0700 > summary: 6622432: RFE: Performance improvements to java.math.BigDecimal > > don't include the spec. changes, which do appear in the jdk7 diff he supplied. They seem to > have occurred prior to OpenJDK entering Mercurial with b24. See: > > http://hg.openjdk.java.net/jdk7/jdk7/jdk/file/0/src/share/classes/java/math/BigInteger.java > > and were then reverted in OpenJDK6: > > changeset: 2:39e8fe7a0af1 > tag: jdk6-b00 > user: ohair > date: Fri Jan 30 16:05:57 2009 -0800 > summary: 6755277: All initial changes to jdk7 to create openjdk 6 build 0 > > http://hg.openjdk.java.net/jdk6/jdk6/jdk/diff/39e8fe7a0af1/src/share/classes/java/math/BigInteger.java > > Thanks for the assistance with the bug archeology. The pre-Hg JDK 7 bug for the change in the string constructor is 5017980 Allow signed positive integer to be parsed instead of a NumerFormatException fixed way back in JDK 7 build 3. This bug stands out for me in the early history of OpenJDK 6. In JDK 7, because of the delegations among the String -> number methods the specifications of 26 methods were modified by changing the code for about 5 methods. The JCK team had dutifully written tests included in JCK 6 to verify "+" was not accepted as a leading character of those 26 methods so this change was the cause of many, many JCK failures against JCK 6 in the initial backwards branch of OpenJDK 6 from JDK 7 build 20 or so. In any case, the patch is good and I approve the changes being backported. Cheers, -Joe From mark at klomp.org Tue Nov 9 01:50:15 2010 From: mark at klomp.org (Mark Wielaard) Date: Tue, 09 Nov 2010 10:50:15 +0100 Subject: hs19 import In-Reply-To: <20101103174109.GD4256@rivendell.middle-earth.co.uk> References: <20101008140837.GB1907@rivendell.middle-earth.co.uk> <4CAF6E74.3010306@oracle.com> <20101012123723.GD6208@rivendell.middle-earth.co.uk> <4CB4D8CE.9060105@oracle.com> <20101013122712.GA24733@rivendell.middle-earth.co.uk> <4CB5A7B2.8000806@oracle.com> <20101013165852.GH24733@rivendell.middle-earth.co.uk> <4CB5F174.6030405@oracle.com> <1288728141.4246.346.camel@springer.wildebeest.org> <4CD07CD9.9030404@oracle.com> <20101103174109.GD4256@rivendell.middle-earth.co.uk> Message-ID: <1289296215.2775.93.camel@springer.wildebeest.org> On Wed, 2010-11-03 at 17:41 +0000, Dr Andrew John Hughes wrote: > On 14:04 Tue 02 Nov , Erik Trimble wrote: > > On 11/2/2010 1:02 PM, Mark Wielaard wrote: > > > Do you think the changes between b06 and b09 should go into the openjdk6 > > > hotspot (for openjdk6-b21) or would it be better not to for now? > > > > > I'll re-check, but I think it may have been a simple oversight on my > > With both the master and baseline versions of hs19, we are hitting this bug: > > https://bugzilla.redhat.com/show_bug.cgi?id=647737 > > This really needs to be fixed before we can release OpenJDK6 b21 with HotSpot 19. So for those not having tracked that bug report, it turned out to have been caused by compressed oops being on by default now. The easiest workaround is something like this patch: --- openjdk/hotspot/src/share/vm/runtime/arguments.cpp.sav 2010-11-08 23:50:59.000000000 -0500 +++ openjdk/hotspot/src/share/vm/runtime/arguments.cpp 2010-11-08 23:52:53.000000000 -0500 @@ -1301,7 +1301,8 @@ void Arguments::set_ergonomics_flags() { if (MaxHeapSize <= max_heap_for_compressed_oops()) { #ifndef COMPILER1 if (FLAG_IS_DEFAULT(UseCompressedOops) && !UseG1GC) { - FLAG_SET_ERGO(bool, UseCompressedOops, true); + // Temporarily fix rhbz#647737 -- disable compressed oops by default + //FLAG_SET_ERGO(bool, UseCompressedOops, true); From mark at klomp.org Tue Nov 9 02:15:23 2010 From: mark at klomp.org (Mark Wielaard) Date: Tue, 09 Nov 2010 11:15:23 +0100 Subject: hs19 import In-Reply-To: <1289296215.2775.93.camel@springer.wildebeest.org> References: <20101008140837.GB1907@rivendell.middle-earth.co.uk> <4CAF6E74.3010306@oracle.com> <20101012123723.GD6208@rivendell.middle-earth.co.uk> <4CB4D8CE.9060105@oracle.com> <20101013122712.GA24733@rivendell.middle-earth.co.uk> <4CB5A7B2.8000806@oracle.com> <20101013165852.GH24733@rivendell.middle-earth.co.uk> <4CB5F174.6030405@oracle.com> <1288728141.4246.346.camel@springer.wildebeest.org> <4CD07CD9.9030404@oracle.com> <20101103174109.GD4256@rivendell.middle-earth.co.uk> <1289296215.2775.93.camel@springer.wildebeest.org> Message-ID: <1289297723.2775.122.camel@springer.wildebeest.org> On Tue, 2010-11-09 at 10:50 +0100, Mark Wielaard wrote: > On Wed, 2010-11-03 at 17:41 +0000, Dr Andrew John Hughes wrote: > > On 14:04 Tue 02 Nov , Erik Trimble wrote: > > > On 11/2/2010 1:02 PM, Mark Wielaard wrote: > > > > Do you think the changes between b06 and b09 should go into the openjdk6 > > > > hotspot (for openjdk6-b21) or would it be better not to for now? > > > > > > > I'll re-check, but I think it may have been a simple oversight on my > > > > With both the master and baseline versions of hs19, we are hitting this bug: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=647737 > > > > This really needs to be fixed before we can release OpenJDK6 b21 with HotSpot 19. > > So for those not having tracked that bug report, it turned out to have > been caused by compressed oops being on by default now. The easiest > workaround is something like this patch: > > --- openjdk/hotspot/src/share/vm/runtime/arguments.cpp.sav 2010-11-08 23:50:59.000000000 -0500 > +++ openjdk/hotspot/src/share/vm/runtime/arguments.cpp 2010-11-08 23:52:53.000000000 -0500 > @@ -1301,7 +1301,8 @@ void Arguments::set_ergonomics_flags() { > if (MaxHeapSize <= max_heap_for_compressed_oops()) { > #ifndef COMPILER1 > if (FLAG_IS_DEFAULT(UseCompressedOops) && !UseG1GC) { > - FLAG_SET_ERGO(bool, UseCompressedOops, true); > + // Temporarily fix rhbz#647737 -- disable compressed oops by default > + //FLAG_SET_ERGO(bool, UseCompressedOops, true); Ismael Juma pointed out on irc that the way it was disabled for hsx17 was with the following commit: http://hg.openjdk.java.net/hsx/hsx17/master/rev/8e02b8f703b2 From aph at redhat.com Tue Nov 9 02:40:06 2010 From: aph at redhat.com (Andrew Haley) Date: Tue, 09 Nov 2010 10:40:06 +0000 Subject: hs19 import In-Reply-To: <1289297723.2775.122.camel@springer.wildebeest.org> References: <20101008140837.GB1907@rivendell.middle-earth.co.uk> <4CAF6E74.3010306@oracle.com> <20101012123723.GD6208@rivendell.middle-earth.co.uk> <4CB4D8CE.9060105@oracle.com> <20101013122712.GA24733@rivendell.middle-earth.co.uk> <4CB5A7B2.8000806@oracle.com> <20101013165852.GH24733@rivendell.middle-earth.co.uk> <4CB5F174.6030405@oracle.com> <1288728141.4246.346.camel@springer.wildebeest.org> <4CD07CD9.9030404@oracle.com> <20101103174109.GD4256@rivendell.middle-earth.co.uk> <1289296215.2775.93.camel@springer.wildebeest.org> <1289297723.2775.122.camel@springer.wildebeest.org> Message-ID: <4CD92506.1060000@redhat.com> On 11/09/2010 10:15 AM, Mark Wielaard wrote: > On Tue, 2010-11-09 at 10:50 +0100, Mark Wielaard wrote: >> On Wed, 2010-11-03 at 17:41 +0000, Dr Andrew John Hughes wrote: >>> On 14:04 Tue 02 Nov , Erik Trimble wrote: >>>> On 11/2/2010 1:02 PM, Mark Wielaard wrote: >>>>> Do you think the changes between b06 and b09 should go into the openjdk6 >>>>> hotspot (for openjdk6-b21) or would it be better not to for now? >>>>> >>>> I'll re-check, but I think it may have been a simple oversight on my >>> >>> With both the master and baseline versions of hs19, we are hitting this bug: >>> >>> https://bugzilla.redhat.com/show_bug.cgi?id=647737 >>> >>> This really needs to be fixed before we can release OpenJDK6 b21 with HotSpot 19. >> >> So for those not having tracked that bug report, it turned out to have >> been caused by compressed oops being on by default now. The easiest >> workaround is something like this patch: >> >> --- openjdk/hotspot/src/share/vm/runtime/arguments.cpp.sav 2010-11-08 23:50:59.000000000 -0500 >> +++ openjdk/hotspot/src/share/vm/runtime/arguments.cpp 2010-11-08 23:52:53.000000000 -0500 >> @@ -1301,7 +1301,8 @@ void Arguments::set_ergonomics_flags() { >> if (MaxHeapSize <= max_heap_for_compressed_oops()) { >> #ifndef COMPILER1 >> if (FLAG_IS_DEFAULT(UseCompressedOops) && !UseG1GC) { >> - FLAG_SET_ERGO(bool, UseCompressedOops, true); >> + // Temporarily fix rhbz#647737 -- disable compressed oops by default >> + //FLAG_SET_ERGO(bool, UseCompressedOops, true); > > Ismael Juma pointed out on irc that the way it was disabled for hsx17 > was with the following commit: > http://hg.openjdk.java.net/hsx/hsx17/master/rev/8e02b8f703b2 > That looks better. Andrew. From ptisnovs at redhat.com Tue Nov 9 05:01:07 2010 From: ptisnovs at redhat.com (Pavel Tisnovsky) Date: Tue, 09 Nov 2010 14:01:07 +0100 Subject: Please review correction of regression test gc/6581734/Test6581734.java Message-ID: <4CD94613.9080809@redhat.com> Hi, can anybody please review very simple correction of regression test gc/6581734/Test6581734.java? This correction is based on changeset 1659 of OpenJDK7 as can be seen here: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/21c29458b334 Webrev for this change is available here: http://cr.openjdk.java.net/~ptisnovs/Test6581734/ Thank you in advance Pavel T. From ptisnovs at redhat.com Tue Nov 9 07:40:20 2010 From: ptisnovs at redhat.com (Pavel Tisnovsky) Date: Tue, 09 Nov 2010 16:40:20 +0100 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction Message-ID: <4CD96B64.8090708@redhat.com> Hi all, could anybody please review correction of awt/FontClass/CreateFont/DeleteFont regression test? This test check, if the temporary file containing font is properly deleted when JVM finishes. The check is based on counting of files in temporary dir - if temporary font file is not deleted, the number of files before and after running the test differs. BUT JVM also creates hsperfdata_* subdirectory so the check described above always fails (presence of this subdirectory add +1 to number of files). I've added simple filter to resolve this issue. Another option is to disable the hsperfdata_* creation at all. Webrev is available at: http://cr.openjdk.java.net/~ptisnovs/DeleteFont_correction/ PS: I'd also like to backport this correction to JDK6 if it is possible. Thank you in advance Pavel T. From aph at redhat.com Tue Nov 9 09:31:26 2010 From: aph at redhat.com (aph at redhat.com) Date: Tue, 09 Nov 2010 17:31:26 +0000 Subject: hg: jdk6/jdk6/jdk: 4 new changesets Message-ID: <20101109173200.BC10F47825@hg.openjdk.java.net> Changeset: cadc64fc2282 Author: aph Date: 2010-11-03 12:43 +0000 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/cadc64fc2282 6622432: RFE: Performance improvements to java.math.BigDecimal Reviewed-by: darcy ! src/share/classes/java/math/BigDecimal.java ! src/share/classes/java/math/BigInteger.java ! src/share/classes/java/math/BitSieve.java ! src/share/classes/java/math/MathContext.java ! src/share/classes/java/math/MutableBigInteger.java ! src/share/classes/java/math/SignedMutableBigInteger.java ! test/java/math/BigDecimal/AddTests.java ! test/java/math/BigDecimal/DivideTests.java Changeset: 3857c2791784 Author: aph Date: 2010-11-03 13:21 +0000 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/3857c2791784 6850606: Regression from JDK 1.6.0_12 Summary: The returned result from multiply should be constructed by using valueOf to take care of the INFLATED case. Reviewed-by: darcy ! src/share/classes/java/math/BigDecimal.java + test/java/math/BigDecimal/MultiplyTests.java Changeset: c2b73679ba94 Author: xlu Date: 2009-08-27 18:00 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c2b73679ba94 6876282: BigDecimal's divide(BigDecimal bd, RoundingFormat r) produces incorrect result Reviewed-by: darcy ! src/share/classes/java/math/BigDecimal.java ! test/java/math/BigDecimal/DivideTests.java Changeset: 5672a2be515a Author: aph Date: 2010-11-09 17:29 +0000 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/5672a2be515a Merge From anthony.petrov at oracle.com Tue Nov 9 09:08:24 2010 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 09 Nov 2010 20:08:24 +0300 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction In-Reply-To: <4CD96B64.8090708@redhat.com> References: <4CD96B64.8090708@redhat.com> Message-ID: <4CD98008.3000109@oracle.com> Hi Pavel, On 11/9/2010 6:40 PM, Pavel Tisnovsky wrote: > BUT JVM also creates hsperfdata_* subdirectory so the check described > above always fails (presence of this subdirectory add +1 to number of > files). I've added simple filter to resolve this issue. Another option > is to disable the hsperfdata_* creation at all. Since this test actually verifies the temp directory behavior, I would vote for disabling of creation of any temporary files other than those we're interested in. Otherwise a font temporary file may happen to get a name that matches the inverse-grep pattern (which is very unlikely but not impossible), and the test could pass mistakenly. Is that possible to prevent creation of the hsperf* directories? -- best regards, Anthony From philip.race at oracle.com Tue Nov 9 11:20:28 2010 From: philip.race at oracle.com (Phil Race) Date: Tue, 09 Nov 2010 11:20:28 -0800 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction In-Reply-To: <4CD96B64.8090708@redhat.com> References: <4CD96B64.8090708@redhat.com> Message-ID: <4CD99EFC.3080808@oracle.com> Pavel, The font implementation and tests are 2D. Not AWT. Don't get thrown by package names. I was a bit curious about the real reason for this failure. I wrote this test a couple of years ago and its never failed before. I don't see it failing on any 6-open build. I see it failing only in JDK 7 from b90. That seems to be due to HS18b03 fix 6938627: Make temporary directory use property java.io.tmpdir when specified I suppose the VM doesn't delete the directory on exit even if empty because it could interfere with other VM instances. I'm not sure what more the test can do than try to deal with any artifacts created by some other part of the JRE. As it is, its making sure that the tmp dir is private to its own private JRE invocation. But that doesn't mean the test and the functionality its testing get exclusive rights to this directory. So I don't think its worth trying to suppress the VM behaviour either. If the VM or something else changes the name of this file or adds another one, then that's going to require fix up such as this one. Just have to hope its not a regular occurrence. So I'm OK with the fix. -phil. On 11/9/2010 7:40 AM, Pavel Tisnovsky wrote: > Hi all, > > could anybody please review correction of > awt/FontClass/CreateFont/DeleteFont regression test? > > This test check, if the temporary file containing font is properly > deleted when JVM finishes. The check is based on counting of files in > temporary dir - if temporary font file is not deleted, the number of > files before and after running the test differs. > > BUT JVM also creates hsperfdata_* subdirectory so the check described > above always fails (presence of this subdirectory add +1 to number of > files). I've added simple filter to resolve this issue. Another option > is to disable the hsperfdata_* creation at all. > > Webrev is available at: > http://cr.openjdk.java.net/~ptisnovs/DeleteFont_correction/ > > PS: I'd also like to backport this correction to JDK6 if it is possible. > > Thank you in advance > Pavel T. From coleen.phillimore at oracle.com Tue Nov 9 14:07:37 2010 From: coleen.phillimore at oracle.com (coleen phillimore) Date: Tue, 09 Nov 2010 17:07:37 -0500 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction In-Reply-To: <4CD99EFC.3080808@oracle.com> References: <4CD96B64.8090708@redhat.com> <4CD99EFC.3080808@oracle.com> Message-ID: <4CD9C629.8020702@oracle.com> Hi, I fixed the bug 6938627 but I'm not sure if it should have been fixed, or rather it causes other problems with the jps and other tools which expect /tmp, so I have to go back and see if it was correct and/or fix the jps/jstat tools. I wouldn't expect the VM to delete the directory as you said in either case. I'm currently tracking this as bugs: 6447220: HotSpot and JDK don't agree on /tmp location on Solaris 6447182: temp dir locations should not be hardcoded for hsperfdata_ dirctories Thanks, Coleen On 11/09/10 14:20, Phil Race wrote: > Pavel, > > The font implementation and tests are 2D. Not AWT. Don't get thrown by > package names. > > I was a bit curious about the real reason for this failure. > I wrote this test a couple of years ago and its never failed before. > I don't see it failing on any 6-open build. > I see it failing only in JDK 7 from b90. That seems to be due to > HS18b03 fix > 6938627: Make temporary directory use property java.io.tmpdir when > specified > > I suppose the VM doesn't delete the directory on exit even if empty > because it > could interfere with other VM instances. > > I'm not sure what more the test can do than try to deal with any > artifacts > created by some other part of the JRE. As it is, its making sure that > the tmp > dir is private to its own private JRE invocation. But that doesn't > mean the > test and the functionality its testing get exclusive rights to this > directory. > So I don't think its worth trying to suppress the VM behaviour either. > If the VM or something else changes the name of this file or adds > another one, > then that's going to require fix up such as this one. Just have to > hope its > not a regular occurrence. > > So I'm OK with the fix. > > -phil. > > > On 11/9/2010 7:40 AM, Pavel Tisnovsky wrote: >> Hi all, >> >> could anybody please review correction of >> awt/FontClass/CreateFont/DeleteFont regression test? >> >> This test check, if the temporary file containing font is properly >> deleted when JVM finishes. The check is based on counting of files in >> temporary dir - if temporary font file is not deleted, the number of >> files before and after running the test differs. >> >> BUT JVM also creates hsperfdata_* subdirectory so the check described >> above always fails (presence of this subdirectory add +1 to number of >> files). I've added simple filter to resolve this issue. Another option >> is to disable the hsperfdata_* creation at all. >> >> Webrev is available at: >> http://cr.openjdk.java.net/~ptisnovs/DeleteFont_correction/ >> >> PS: I'd also like to backport this correction to JDK6 if it is possible. >> >> Thank you in advance >> Pavel T. > From ahughes at redhat.com Wed Nov 10 07:27:24 2010 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Wed, 10 Nov 2010 15:27:24 +0000 Subject: hs19 import In-Reply-To: <4CB4D8CE.9060105@oracle.com> References: <4C919F27.6090607@oracle.com> <20100920183906.GM16943@rivendell.middle-earth.co.uk> <4C982CD6.2050405@oracle.com> <4C98D489.4080009@oracle.com> <20100921224624.GA9599@rivendell.middle-earth.co.uk> <4C9B8466.8040304@oracle.com> <20101008140837.GB1907@rivendell.middle-earth.co.uk> <4CAF6E74.3010306@oracle.com> <20101012123723.GD6208@rivendell.middle-earth.co.uk> <4CB4D8CE.9060105@oracle.com> Message-ID: <20101110152723.GE30517@rivendell.middle-earth.co.uk> On 14:53 Tue 12 Oct , Joe Darcy wrote: > > Note that you may have noticed some more recent bug fixing activity > going on in hs19. In principle those changes can go back too, but I'd > prefer they be done after the current work is merged in. > > Thanks, > > -Joe Here's the webrev for that update to the newest master: http://cr.openjdk.java.net/~andrew/jdk6-hs19-merge/webrev.02/ This moves us to b09. It does not fixed the bug caused by compressed oops previously discussed. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From joe.darcy at oracle.com Wed Nov 10 16:52:37 2010 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 10 Nov 2010 16:52:37 -0800 Subject: hs19 import In-Reply-To: <20101110152723.GE30517@rivendell.middle-earth.co.uk> References: <4C919F27.6090607@oracle.com> <20100920183906.GM16943@rivendell.middle-earth.co.uk> <4C982CD6.2050405@oracle.com> <4C98D489.4080009@oracle.com> <20100921224624.GA9599@rivendell.middle-earth.co.uk> <4C9B8466.8040304@oracle.com> <20101008140837.GB1907@rivendell.middle-earth.co.uk> <4CAF6E74.3010306@oracle.com> <20101012123723.GD6208@rivendell.middle-earth.co.uk> <4CB4D8CE.9060105@oracle.com> <20101110152723.GE30517@rivendell.middle-earth.co.uk> Message-ID: <4CDB3E55.8020205@oracle.com> Dr Andrew John Hughes wrote: > On 14:53 Tue 12 Oct , Joe Darcy wrote: > >> Note that you may have noticed some more recent bug fixing activity >> going on in hs19. In principle those changes can go back too, but I'd >> prefer they be done after the current work is merged in. >> >> Thanks, >> >> -Joe >> > > Here's the webrev for that update to the newest master: > > http://cr.openjdk.java.net/~andrew/jdk6-hs19-merge/webrev.02/ > Approved to go back. > This moves us to b09. It does not fixed the bug caused by compressed > oops previously discussed. > Acknowledged. Thanks, -Joe From ptisnovs at redhat.com Thu Nov 11 04:01:48 2010 From: ptisnovs at redhat.com (Pavel Tisnovsky) Date: Thu, 11 Nov 2010 13:01:48 +0100 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction In-Reply-To: <4CD99EFC.3080808@oracle.com> References: <4CD96B64.8090708@redhat.com> <4CD99EFC.3080808@oracle.com> Message-ID: <4CDBDB2C.1030600@redhat.com> Phil Race wrote: > Pavel, > > The font implementation and tests are 2D. Not AWT. Don't get thrown by > package names. Ah sorry, you are right, of course. > > I was a bit curious about the real reason for this failure. > I wrote this test a couple of years ago and its never failed before. > I don't see it failing on any 6-open build. > I see it failing only in JDK 7 from b90. That seems to be due to HS18b03 > fix > 6938627: Make temporary directory use property java.io.tmpdir when > specified It's failing on my side in OpenJDK 7 and in IcedTea6, because IT6 uses some backports from OpenJDK 7 (from the log files I can only infer that this bug first appeared in IcedTea6 when the hs19 were set as default HotSpot on 2010-10-19). Is it still possible to push the test correction to OpenJDK 6 too, or only to OpenJDK 7? Also I'll need a bug id please. > > I suppose the VM doesn't delete the directory on exit even if empty > because it > could interfere with other VM instances. > > I'm not sure what more the test can do than try to deal with any artifacts > created by some other part of the JRE. As it is, its making sure that > the tmp > dir is private to its own private JRE invocation. But that doesn't mean the > test and the functionality its testing get exclusive rights to this > directory. > So I don't think its worth trying to suppress the VM behaviour either. > If the VM or something else changes the name of this file or adds > another one, > then that's going to require fix up such as this one. Just have to hope its > not a regular occurrence. > > So I'm OK with the fix. > > -phil. > > > On 11/9/2010 7:40 AM, Pavel Tisnovsky wrote: >> Hi all, >> >> could anybody please review correction of >> awt/FontClass/CreateFont/DeleteFont regression test? >> >> This test check, if the temporary file containing font is properly >> deleted when JVM finishes. The check is based on counting of files in >> temporary dir - if temporary font file is not deleted, the number of >> files before and after running the test differs. >> >> BUT JVM also creates hsperfdata_* subdirectory so the check described >> above always fails (presence of this subdirectory add +1 to number of >> files). I've added simple filter to resolve this issue. Another option >> is to disable the hsperfdata_* creation at all. >> >> Webrev is available at: >> http://cr.openjdk.java.net/~ptisnovs/DeleteFont_correction/ >> >> PS: I'd also like to backport this correction to JDK6 if it is possible. >> >> Thank you in advance >> Pavel T. > From ahughes at redhat.com Thu Nov 11 06:56:33 2010 From: ahughes at redhat.com (ahughes at redhat.com) Date: Thu, 11 Nov 2010 14:56:33 +0000 Subject: hg: jdk6/jdk6/hotspot: 37 new changesets Message-ID: <20101111145746.B6758478E7@hg.openjdk.java.net> Changeset: d3b3540db4c3 Author: trims Date: 2010-09-24 00:52 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/d3b3540db4c3 6987149: Fix incorrect Oracle copyright header in make/templates files Summary: Minor fix to first line of template copyright files Reviewed-by: ohair ! make/templates/bsd-header ! make/templates/gpl-cp-header ! make/templates/gpl-header Changeset: d64a8c7aa9d5 Author: never Date: 2010-08-27 17:33 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/d64a8c7aa9d5 4809552: Optimize Arrays.fill(...) Reviewed-by: kvn ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/share/vm/includeDB_compiler2 ! src/share/vm/opto/addnode.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 51a669dbaa6a Author: kvn Date: 2010-08-26 11:05 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/51a669dbaa6a 6976400: "Meet Not Symmetric" Summary: Use NULL as klass for TypeAryPtr::RANGE. Add klass verification into TypeAryPtr ctor. Reviewed-by: never ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp Changeset: 22339bb3b2fd Author: kvn Date: 2010-08-30 11:02 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/22339bb3b2fd 6980978: assert(mt == t->xmeet(this)) failed: meet not commutative Summary: Fix code in TypeAryPtr::xmeet() for constant array. Reviewed-by: never ! src/share/vm/opto/type.cpp Changeset: be2b508a60cb Author: phh Date: 2010-10-08 11:07 -0400 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/be2b508a60cb 6981431: IdealKit should support I_O projections Summary: add I_O projections support into IdealKit Reviewed-by: never ! src/share/vm/includeDB_compiler2 ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/opto/library_call.cpp Changeset: 0652d205acda Author: never Date: 2010-08-30 17:27 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/0652d205acda 6969586: OptimizeStringConcat: SIGSEGV in LoadNode::Value() Reviewed-by: kvn ! src/share/vm/opto/memnode.cpp Changeset: 04323991c395 Author: kamg Date: 2010-08-27 15:05 -0400 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/04323991c395 6980262: Memory leak when exception is thrown in static initializer Summary: Use resource memory instead of c-heap for the exception message Reviewed-by: phh, jmasa ! src/share/vm/oops/instanceKlass.cpp Changeset: 5b0eb275c3d0 Author: never Date: 2010-09-02 11:40 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/5b0eb275c3d0 6981773: incorrect fill value with OptimizeFill Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/stubGenerator_sparc.cpp Changeset: 95a51e316d1c Author: kvn Date: 2010-08-23 09:09 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/95a51e316d1c 6896381: CTW fails share/vm/ci/bcEscapeAnalyzer.cpp:99, assert(_stack_height < _max_stack,"stack overflow") Summary: Check constant Tag type instead of calling get_constant(). Reviewed-by: never ! src/share/vm/ci/bcEscapeAnalyzer.cpp Changeset: 9b2e416eda7f Author: dholmes Date: 2010-09-03 01:28 -0400 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/9b2e416eda7f 6978641: Fix for 6929067 introduces additional overhead in thread creation/termination paths Summary: Disable stack bounds checks in product mode other than for the initial thread Reviewed-by: coleenp, jcoomes, aph ! src/os/linux/vm/os_linux.cpp Changeset: a8effb842215 Author: never Date: 2010-09-03 13:31 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/a8effb842215 6982370: SIGBUS in jbyte_fill Reviewed-by: kvn ! src/cpu/sparc/vm/stubGenerator_sparc.cpp + test/compiler/6982370/Test6982370.java Changeset: fa7695e418a1 Author: trims Date: 2010-09-03 18:43 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/fa7695e418a1 6982488: Bump the HS19 build number to 07 for 6Updates Summary: Update the HS19 build number to 07 Reviewed-by: jcoomes ! make/hotspot_version Changeset: b65b341bd9fa Author: never Date: 2010-09-07 11:31 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/b65b341bd9fa 6982533: Crash in ~StubRoutines::jbyte_fill with AggressiveOpts enabled Reviewed-by: kvn ! src/share/vm/opto/loopTransform.cpp Changeset: 17143f9aa19a Author: phh Date: 2010-10-08 11:13 -0400 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/17143f9aa19a Added tag hs19-b07 for changeset b65b341bd9fa ! .hgtags Changeset: 620cfdea5a3f Author: trims Date: 2010-09-07 18:27 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/620cfdea5a3f 6983013: Change the HS_MINOR version to 6 for the 6Update train Summary: Update the HS_MINOR_VER to 6 Reviewed-by: jcoomes ! make/hotspot_version Changeset: cff4ddf257b4 Author: kvn Date: 2010-09-13 16:45 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/cff4ddf257b4 6984346: Remove development code in type.hpp Summary: Remove code which use UseNewCode in type.hpp Reviewed-by: never ! src/share/vm/opto/type.hpp Changeset: 4cf84525dc4d Author: kvn Date: 2010-09-14 17:19 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/4cf84525dc4d 6984368: Large default heap size does not allow to use zero based compressed oops Summary: take into account HeapBaseMinAddress and round down MaxPermSize Reviewed-by: never ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/runtime/arguments.cpp Changeset: f6b107f3629a Author: acorn Date: 2010-09-10 13:40 -0400 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/f6b107f3629a 6942092: Loader-constraint test is failing Summary: Fix test string compare to match source update Reviewed-by: dcubed, phh ! test/runtime/6626217/Test6626217.sh Changeset: bdd14610f204 Author: never Date: 2010-09-15 20:25 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/bdd14610f204 6984979: OptimizeFill misses some cases with an odd memory graph Reviewed-by: kvn ! src/share/vm/opto/loopTransform.cpp Changeset: a367fee99714 Author: phh Date: 2010-10-08 11:26 -0400 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/a367fee99714 Added tag hs19-b07 for changeset bdd14610f204 ! .hgtags Changeset: 59244c77684a Author: kamg Date: 2010-09-21 14:41 -0400 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/59244c77684a 6975210: java.lang.VerifyError in some of JCK tests Summary: Naked oop in verificationType::is_reference_assignable_from() Reviewed-by: never, kvn, coleenp ! src/share/vm/classfile/verificationType.cpp Changeset: c437eeffbd7e Author: trims Date: 2010-09-22 13:37 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/c437eeffbd7e 6985396: Bump the HS19 build number to 08 Summary: Update the HS19 build number to 08 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 23f1a60e5e43 Author: trims Date: 2010-09-22 13:40 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/23f1a60e5e43 6982489: Update Hotspot 19 to use jdk6u21p as the default JPRT release target Summary: Change the HS19 default JPRT target to be jdk6perf Reviewed-by: ohair ! make/jprt.properties Changeset: 0c5c902506a0 Author: jcoomes Date: 2010-09-27 22:36 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/0c5c902506a0 6423256: GC stacks should use a better data structure 6942771: SEGV in ParScanThreadState::take_from_overflow_stack Reviewed-by: apetrusenko, ysr, pbk ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/includeDB_gc_concurrentMarkSweep ! src/share/vm/gc_implementation/includeDB_gc_parallelScavenge ! src/share/vm/gc_implementation/includeDB_gc_serial ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_implementation/shared/markSweep.inline.hpp ! src/share/vm/includeDB_core ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/defNewGeneration.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp + src/share/vm/utilities/stack.hpp + src/share/vm/utilities/stack.inline.hpp ! src/share/vm/utilities/taskqueue.hpp Changeset: e076c91fb9b6 Author: never Date: 2010-09-22 13:01 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/e076c91fb9b6 6982537: Crash in Node*step_through_mergemem Reviewed-by: kvn ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/memnode.cpp Changeset: bda2024ae52b Author: phh Date: 2010-10-08 11:40 -0400 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/bda2024ae52b 6986028: assert(_base == Int) failed: Not an Int in CmpINode::sub Reviewed-by: kvn, twisti ! src/share/vm/opto/stringopts.cpp Changeset: 9a19ee0490e0 Author: kvn Date: 2010-09-30 18:31 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/9a19ee0490e0 6916062: assert(_inserts <= _insert_limit,"hash table overflow") in NodeHash::hash_insert Summary: Missing check for not empty worklist when puting memory node back on worklist and expecting address type update. Reviewed-by: never ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/phaseX.cpp Changeset: 53adfc40121e Author: jcoomes Date: 2010-10-01 09:19 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/53adfc40121e 6988678: fatal error deadlock handling was unintentionally disabled Reviewed-by: ysr ! src/share/vm/runtime/thread.cpp Changeset: 243e95e6a37d Author: never Date: 2010-09-08 20:28 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/243e95e6a37d 6965815: OptimizeStringConcat: assert(!q->is_MergeMem()) failed with specjbb2000 Reviewed-by: kvn ! src/share/vm/opto/graphKit.cpp Changeset: c53baab9d988 Author: never Date: 2010-10-05 11:16 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/c53baab9d988 6988018: dtrace/hotspot/MethodInvocation/MethodInvocation002 crashes with client compiler Reviewed-by: iveresov, kvn, kamg ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: 61e2d45faa7f Author: minqi Date: 2010-10-07 13:49 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/61e2d45faa7f 6966589: hs16-b08 causes java.lang.StackOverflowError Reviewed-by: mchung, dholmes, chrisphi ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/classLoader.hpp Changeset: 2b2e90b406ca Author: minqi Date: 2010-10-07 13:51 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/2b2e90b406ca 6990124: supplemental fix for 6361589 Reviewed-by: coleenp, chrisphi ! src/share/vm/utilities/vmError.cpp Changeset: 3ea92ddc62ff Author: never Date: 2010-10-07 13:11 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/3ea92ddc62ff 6980792: Crash "exception happened outside interpreter, nmethods and vtable stubs (1)" Reviewed-by: kvn ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/runtime.cpp Changeset: 8da8d443833d Author: trims Date: 2010-10-08 15:20 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/8da8d443833d Added tag hs19-b08 for changeset 23f1a60e5e43 ! .hgtags Changeset: 13edc857b967 Author: trims Date: 2010-10-08 13:29 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/13edc857b967 6990756: Bump the HS19 build number to 09 Summary: Update the HS19 build number to 09 Reviewed-by: jcoomes ! make/hotspot_version Changeset: a299307a934e Author: trims Date: 2010-11-04 16:21 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/a299307a934e Added tag hs19-b09 for changeset 13edc857b967 ! .hgtags Changeset: 2ecd0d1194d2 Author: andrew Date: 2010-11-05 14:04 +0000 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/2ecd0d1194d2 Merge ! .hgtags ! make/hotspot_version ! make/jprt.properties ! make/templates/bsd-header ! make/templates/gpl-cp-header ! make/templates/gpl-header ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/os/linux/vm/os_linux.cpp ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/classLoader.hpp ! src/share/vm/classfile/verificationType.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/includeDB_gc_concurrentMarkSweep ! src/share/vm/gc_implementation/includeDB_gc_parallelScavenge ! src/share/vm/gc_implementation/includeDB_gc_serial ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_implementation/shared/markSweep.inline.hpp ! src/share/vm/includeDB_compiler2 ! src/share/vm/includeDB_core ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/defNewGeneration.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/opto/addnode.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/taskqueue.hpp ! src/share/vm/utilities/vmError.cpp From kevin.walls at oracle.com Tue Nov 16 07:26:51 2010 From: kevin.walls at oracle.com (Kevin Walls) Date: Tue, 16 Nov 2010 15:26:51 +0000 Subject: Please review correction of regression test gc/6581734/Test6581734.java In-Reply-To: <4CD94613.9080809@redhat.com> References: <4CD94613.9080809@redhat.com> Message-ID: <4CE2A2BB.8020706@oracle.com> Looks good! Thanks, Kevin On 09/11/2010 13:01, Pavel Tisnovsky wrote: > Hi, > > can anybody please review very simple correction of regression test > gc/6581734/Test6581734.java? > > This correction is based on changeset 1659 of OpenJDK7 as can be seen here: > http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/21c29458b334 > > Webrev for this change is available here: > http://cr.openjdk.java.net/~ptisnovs/Test6581734/ > > Thank you in advance > Pavel T. From ptisnovs at redhat.com Thu Nov 18 02:33:02 2010 From: ptisnovs at redhat.com (Pavel Tisnovsky) Date: Thu, 18 Nov 2010 11:33:02 +0100 Subject: Please review correction of regression test gc/6581734/Test6581734.java In-Reply-To: <4CE2A2BB.8020706@oracle.com> References: <4CD94613.9080809@redhat.com> <4CE2A2BB.8020706@oracle.com> Message-ID: <4CE500DE.8050601@redhat.com> Kevin Walls wrote: > > > Looks good! Hi Kevin, thanks for review. I presume that I need a bug ID and Joe Darcy's approval to push this change to JDK6, am I right? Pavel > > Thanks, > Kevin > > > On 09/11/2010 13:01, Pavel Tisnovsky wrote: >> Hi, >> >> can anybody please review very simple correction of regression test >> gc/6581734/Test6581734.java? >> >> This correction is based on changeset 1659 of OpenJDK7 as can be seen >> here: >> http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/21c29458b334 >> >> Webrev for this change is available here: >> http://cr.openjdk.java.net/~ptisnovs/Test6581734/ >> >> Thank you in advance >> Pavel T. > From kevin.walls at oracle.com Thu Nov 18 02:41:09 2010 From: kevin.walls at oracle.com (Kevin Walls) Date: Thu, 18 Nov 2010 10:41:09 +0000 Subject: Please review correction of regression test gc/6581734/Test6581734.java In-Reply-To: <4CE500DE.8050601@redhat.com> References: <4CD94613.9080809@redhat.com> <4CE2A2BB.8020706@oracle.com> <4CE500DE.8050601@redhat.com> Message-ID: <4CE502C5.7030908@oracle.com> Hi - This testcase fix is CR: 6980392 TEST_BUG: gc/6581734/Test6581734.java has typo I'd hope the nod of approval from Joe is a formality which will follow later. 8-) Many thanks Kevin On 18/11/2010 10:33, Pavel Tisnovsky wrote: > Kevin Walls wrote: >> >> Looks good! > Hi Kevin, > > thanks for review. I presume that I need a bug ID and Joe Darcy's > approval to push this change to JDK6, am I right? > > Pavel > >> Thanks, >> Kevin >> >> >> On 09/11/2010 13:01, Pavel Tisnovsky wrote: >>> Hi, >>> >>> can anybody please review very simple correction of regression test >>> gc/6581734/Test6581734.java? >>> >>> This correction is based on changeset 1659 of OpenJDK7 as can be seen >>> here: >>> http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/21c29458b334 >>> >>> Webrev for this change is available here: >>> http://cr.openjdk.java.net/~ptisnovs/Test6581734/ >>> >>> Thank you in advance >>> Pavel T. From ahughes at redhat.com Tue Nov 23 05:31:46 2010 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Tue, 23 Nov 2010 13:31:46 +0000 Subject: About time for b21? In-Reply-To: <20101102093637.GA3675@redhat.com> References: <4CB7A882.3080008@oracle.com> <20101027084357.GA3450@redhat.com> <4CCB6438.3040108@oracle.com> <20101102093637.GA3675@redhat.com> Message-ID: <20101123133146.GM19794@rivendell.middle-earth.co.uk> On 09:36 Tue 02 Nov , Gary Benson wrote: > Joe Darcy wrote: > > Gary Benson wrote: > > > Joe Darcy wrote: > > > > With Andrew's sync of HS19 into OpenJDK 6 and the recent batch > > > > of security fixes coming real soon now, I think it is about time > > > > to have b21. I'd hold b21 for the remaining bug fixes pushed to > > > > HS19 that are not quite promoted yet. > > > > > > > > Are there any other changes that should be in b21? > > > > > > Building HS19 with Zero on PowerPC requires a fix (6994130). > > > There's a webrev (for JDK7, but it's the same) here: > > > > > > http://cr.openjdk.java.net/~gbenson/zero-ppc-fix/ > > > > > > Would it be possible to backport this? > > > > Once 6994130 is approved and integrated into JDK 7, I approve it > > being backported to OpenJDK 6. > It's now in b119 so presumably it can be backported? Without it, the PPC build is broken which is a regression from b20. We're still waiting on: http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-October/002080.html http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-September/002008.html I'd also like to get: changeset: 2527:f1bafc4f249d user: peterz date: Tue Jun 29 14:42:30 2010 +0400 summary: 6963870: NPE in CompoundBorder.getInsets() http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/f1bafc4f249d in as mentioned in http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-August/001954.html As no solution for the hs19 bug has been forthcoming, I suggest we disable compressed oops as we have in IcedTea6: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-November/010877.html > Thanks Joe. > > Cheers, > Gary > > -- > http://gbenson.net/ Thanks, -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From kelly.ohair at oracle.com Tue Nov 23 09:48:03 2010 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Tue, 23 Nov 2010 17:48:03 +0000 Subject: hg: jdk6/jdk6/jaxws: 7002248: Update urls for jaxp and jaxws source downloads Message-ID: <20101123174804.0381547BEB@hg.openjdk.java.net> Changeset: 277471e0141f Author: ohair Date: 2010-11-23 09:47 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/jaxws/rev/277471e0141f 7002248: Update urls for jaxp and jaxws source downloads Reviewed-by: darcy ! jaxws.properties From kelly.ohair at oracle.com Tue Nov 23 09:48:49 2010 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Tue, 23 Nov 2010 17:48:49 +0000 Subject: hg: jdk6/jdk6/jaxp: 7002248: Update urls for jaxp and jaxws source downloads Message-ID: <20101123174849.390A747BED@hg.openjdk.java.net> Changeset: 15acc92260d5 Author: ohair Date: 2010-11-23 09:48 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/jaxp/rev/15acc92260d5 7002248: Update urls for jaxp and jaxws source downloads Reviewed-by: darcy ! jaxp.properties From roger at gilliar.de Tue Nov 23 13:59:14 2010 From: roger at gilliar.de (Roger Gilliar) Date: Tue, 23 Nov 2010 22:59:14 +0100 Subject: How to include JDK source in open source project Message-ID: <56D62722-E85D-4C0B-8CEB-AF845896E6CE@gilliar.de> Hi, I converted the DefaultTableCellRenderer from the OpenJDK source release to a JRuby class to use it in my own open source project. What is the appropiate way to do this ? Include the original java source ? Regards Roger -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20101123/f342794e/attachment.html From aph at redhat.com Wed Nov 24 02:59:16 2010 From: aph at redhat.com (Andrew Haley) Date: Wed, 24 Nov 2010 10:59:16 +0000 Subject: How to include JDK source in open source project In-Reply-To: <56D62722-E85D-4C0B-8CEB-AF845896E6CE@gilliar.de> References: <56D62722-E85D-4C0B-8CEB-AF845896E6CE@gilliar.de> Message-ID: <4CECF004.90301@redhat.com> On 11/23/2010 09:59 PM, Roger Gilliar wrote: > I converted the DefaultTableCellRenderer from the OpenJDK source release to a JRuby class to use it in my own open source project. What is the appropiate way to do this ? > Include the original java source ? Of course, it will help to provide a link to thte original. I think by "appropriate" you may be asking a legal question. Legal questions are always inappropriate here because we are not lawyers. However: Please read the licence. You will find that you are free to modify the code and distribute copies of your modified versions to others, AS LONG AS you retain the original licence and copyright notices. But this is not legal advice, and I am not a lawyer: please read the licence. Andrew. From roger at gilliar.de Wed Nov 24 03:12:10 2010 From: roger at gilliar.de (Roger Gilliar) Date: Wed, 24 Nov 2010 12:12:10 +0100 Subject: How to include JDK source in open source project In-Reply-To: <4CECF004.90301@redhat.com> References: <56D62722-E85D-4C0B-8CEB-AF845896E6CE@gilliar.de> <4CECF004.90301@redhat.com> Message-ID: <234749E6-6D8D-447C-8F7E-9E8708529FF6@gilliar.de> Hi, >>Please read the licence. You will find that you are free to modifythe code and distribute copies of your modified versions to others, AS LONG AS you retain the original licence and copyright notices.<< ------------------------------------------------------------------- I did that, but was not sure if this would apply for a total rewrite. I think I include the orignal java source, put a link in my ruby file to the orignal java source and copy the licence from the Java file into my ruby file. Thanks Roger From denisl at openscg.com Wed Nov 24 12:11:21 2010 From: denisl at openscg.com (Lussier, Denis) Date: Wed, 24 Nov 2010 15:11:21 -0500 Subject: How to include JDK source in open source project In-Reply-To: <234749E6-6D8D-447C-8F7E-9E8708529FF6@gilliar.de> References: <56D62722-E85D-4C0B-8CEB-AF845896E6CE@gilliar.de> <4CECF004.90301@redhat.com> <234749E6-6D8D-447C-8F7E-9E8708529FF6@gilliar.de> Message-ID: This is NOT legal advice, however... Below are the guidleines that I try to follow at my two open source companies, OpenSCG and EnterpriseDB. You need to understand the ins & outs of the open source license you are dealing with. It's really not all that complicated... There are GPL style licenses (LIBGPL, v2 & v3, etc) and BSD style licenses (Old, new, Apache, MIT, etc). If you follow the general guidlines that I outline below then you'll be more than OK (in most all cases) for these OSI licenses. - Publish your patche(s) on your website and make it very clear (via README inside your code file) how to apply this patch over the base project. If the project you modified is GPL v2, then your patches must be clearly labeled GPL v2. - Follow the same coding conventions in your patch as in the original project. - If you do not intend for your patch to ever be combined back into the original (without significant modifications) then keep your own Copyright notice at the top of the source files. - Publish a link for easily downloading the exact version of the base project your patch applies against. - Be proud of promoter and supporter of the project that you base your custom version on... You can do this in many ways depending on your technical and/or financial capabilities... --Denis Lussier Founder and Chief Architect http://openscg.org On Wed, Nov 24, 2010 at 6:12 AM, Roger Gilliar wrote: > Hi, > > >>Please read the licence. You will find that you are free to modifythe > code and distribute copies of your modified versions to others, > > AS LONG AS you retain the original licence and copyright notices.<< > ------------------------------------------------------------------- > I did that, but was not sure if this would apply for a total rewrite. I > think I include the orignal java source, put a link in my ruby file to the > orignal java source and copy the licence from the Java file into my ruby > file. > > Thanks > Roger -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20101124/67745e87/attachment.html From joe.darcy at oracle.com Mon Nov 29 20:15:50 2010 From: joe.darcy at oracle.com (Joe Darcy) Date: Mon, 29 Nov 2010 20:15:50 -0800 Subject: Please review correction of regression test gc/6581734/Test6581734.java In-Reply-To: <4CE502C5.7030908@oracle.com> References: <4CD94613.9080809@redhat.com> <4CE2A2BB.8020706@oracle.com> <4CE500DE.8050601@redhat.com> <4CE502C5.7030908@oracle.com> Message-ID: <4CF47A76.50208@oracle.com> On 11/18/2010 2:41 AM, Kevin Walls wrote: > Hi - > > This testcase fix is CR: > > 6980392 TEST_BUG: gc/6581734/Test6581734.java has typo > > I'd hope the nod of approval from Joe is a formality which will follow > later. 8-) Catching up on email, approved to push! -Joe > > Many thanks > Kevin > > > On 18/11/2010 10:33, Pavel Tisnovsky wrote: >> Kevin Walls wrote: >>> >>> Looks good! >> Hi Kevin, >> >> thanks for review. I presume that I need a bug ID and Joe Darcy's >> approval to push this change to JDK6, am I right? >> >> Pavel >> >>> Thanks, >>> Kevin >>> >>> >>> On 09/11/2010 13:01, Pavel Tisnovsky wrote: >>>> Hi, >>>> >>>> can anybody please review very simple correction of regression test >>>> gc/6581734/Test6581734.java? >>>> >>>> This correction is based on changeset 1659 of OpenJDK7 as can be seen >>>> here: >>>> http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/21c29458b334 >>>> >>>> Webrev for this change is available here: >>>> http://cr.openjdk.java.net/~ptisnovs/Test6581734/ >>>> >>>> Thank you in advance >>>> Pavel T. > From joe.darcy at oracle.com Mon Nov 29 20:26:33 2010 From: joe.darcy at oracle.com (Joe Darcy) Date: Mon, 29 Nov 2010 20:26:33 -0800 Subject: Reviewer needed - awt/FontClass/CreateFont/DeleteFont test correction In-Reply-To: <4CDBDB2C.1030600@redhat.com> References: <4CD96B64.8090708@redhat.com> <4CD99EFC.3080808@oracle.com> <4CDBDB2C.1030600@redhat.com> Message-ID: <4CF47CF9.1020005@oracle.com> On 11/11/2010 4:01 AM, Pavel Tisnovsky wrote: > Phil Race wrote: >> Pavel, >> >> The font implementation and tests are 2D. Not AWT. Don't get thrown by >> package names. > Ah sorry, you are right, of course. >> I was a bit curious about the real reason for this failure. >> I wrote this test a couple of years ago and its never failed before. >> I don't see it failing on any 6-open build. >> I see it failing only in JDK 7 from b90. That seems to be due to HS18b03 >> fix >> 6938627: Make temporary directory use property java.io.tmpdir when >> specified > It's failing on my side in OpenJDK 7 and in IcedTea6, because IT6 uses > some backports from OpenJDK 7 (from the log files I can only infer that > this bug first appeared in IcedTea6 when the hs19 were set as default > HotSpot on 2010-10-19). Is it still possible to push the test correction > to OpenJDK 6 too, or only to OpenJDK 7? > > Also I'll need a bug id please. > Sorry for the belated reply, please use 7003327 Correct test awt/FontClass/CreateFont/DeleteFont Approved for OpenJDK 6. -Joe