From adalbert.prokop at gmx.de Fri Apr 1 01:17:45 2011 From: adalbert.prokop at gmx.de (Adalbert Prokop) Date: Fri, 01 Apr 2011 10:17:45 +0200 Subject: Question about IcedTea6 1.9.7 + Webstart (NetX) + OSGI Message-ID: <4D958A29.4020605@gmx.de> Hello! I've got a problem (and possibly a bug to report) with IcedTea6 1.9.7 using Webstart (NetX) and OSGI. Basically, calling BasicService.getCodeBase() always returns null if a webstart application uses OSGI. Before I go into detail I'd like to know if this is the right mailing list for this question. If it's not, could you tell me where I can get ask it? -- Best wishes, Adalbert From dbhole at redhat.com Fri Apr 1 07:31:16 2011 From: dbhole at redhat.com (Deepak Bhole) Date: Fri, 1 Apr 2011 10:31:16 -0400 Subject: Question about IcedTea6 1.9.7 + Webstart (NetX) + OSGI In-Reply-To: <4D958A29.4020605@gmx.de> References: <4D958A29.4020605@gmx.de> Message-ID: <20110401143115.GA8142@redhat.com> * Adalbert Prokop [2011-04-01 04:20]: > Hello! > > I've got a problem (and possibly a bug to report) with IcedTea6 > 1.9.7 using Webstart (NetX) and OSGI. > Basically, calling BasicService.getCodeBase() always returns null if > a webstart application uses OSGI. > > Before I go into detail I'd like to know if this is the right > mailing list for this question. If it's not, could you tell me where > I can get ask it? > Hi Adalbert, No, this is not the right mailing list for it. NetX based WebStart is part of IcedTea. It used to be in the IcedTea tree and has now been split into a separate project named icedtea-web: http://icedtea.classpath.org/wiki/IcedTea-Web The correct mailing list for questions about it would be distro-pkg-dev at openjdk.java.net Cheers, Deepak > -- > Best wishes, > Adalbert From kelly.ohair at oracle.com Tue Apr 5 07:52:22 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Tue, 05 Apr 2011 14:52:22 +0000 Subject: hg: jdk6/jdk6/jdk: 7029905: demo applets missing some html files Message-ID: <20110405145248.CC18D477E2@hg.openjdk.java.net> Changeset: 722066eadfef Author: ohair Date: 2011-04-04 15:21 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/722066eadfef 7029905: demo applets missing some html files Reviewed-by: omajid, mchung, igor ! make/mkdemo/jfc/Font2DTest/Makefile ! make/mkdemo/jfc/SwingApplet/Makefile From Kelly.Ohair at Oracle.Com Tue Apr 5 15:43:25 2011 From: Kelly.Ohair at Oracle.Com (Kelly O'Hair) Date: Tue, 5 Apr 2011 15:43:25 -0700 Subject: Need reviewer: Copyright year updates Message-ID: <84C5D8E1-06BE-4AC1-AB55-58D165973647@Oracle.Com> Just updating copyright years, a few 2010, some 2011. http://cr.openjdk.java.net/~ohair/openjdk6/jdk6-copyright-year/webrev/ -kto From joe.darcy at oracle.com Tue Apr 5 16:30:30 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 05 Apr 2011 16:30:30 -0700 Subject: Need reviewer: Copyright year updates In-Reply-To: <84C5D8E1-06BE-4AC1-AB55-58D165973647@Oracle.Com> References: <84C5D8E1-06BE-4AC1-AB55-58D165973647@Oracle.Com> Message-ID: <4D9BA616.7050903@oracle.com> Looks good. -Joe On 4/5/2011 3:43 PM, Kelly O'Hair wrote: > Just updating copyright years, a few 2010, some 2011. > > http://cr.openjdk.java.net/~ohair/openjdk6/jdk6-copyright-year/webrev/ > > -kto > From kelly.ohair at oracle.com Tue Apr 5 16:50:50 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Tue, 05 Apr 2011 23:50:50 +0000 Subject: hg: jdk6/jdk6: 7033660: Update copyright year to 2011 on any files changed in 2011 Message-ID: <20110405235050.8581A47806@hg.openjdk.java.net> Changeset: 2077a63d319f Author: ohair Date: 2011-04-05 16:49 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/rev/2077a63d319f 7033660: Update copyright year to 2011 on any files changed in 2011 Reviewed-by: darcy ! Makefile ! get_source.sh ! make/scripts/hgforest.sh ! make/scripts/vsvars.sh ! test/Makefile From kelly.ohair at oracle.com Tue Apr 5 16:51:30 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Tue, 05 Apr 2011 23:51:30 +0000 Subject: hg: jdk6/jdk6/jdk: 7033660: Update copyright year to 2011 on any files changed in 2011 Message-ID: <20110405235139.A44FE47808@hg.openjdk.java.net> Changeset: e76e39bf0e83 Author: ohair Date: 2011-04-05 16:50 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/e76e39bf0e83 7033660: Update copyright year to 2011 on any files changed in 2011 Reviewed-by: darcy ! make/mkdemo/jfc/Font2DTest/Makefile ! make/mkdemo/jfc/SwingApplet/Makefile ! make/sun/net/FILES_java.gmk ! src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java ! src/share/classes/com/sun/imageio/plugins/png/PNGImageWriter.java ! src/share/classes/com/sun/imageio/plugins/png/PNGMetadata.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java ! src/share/classes/java/awt/AWTEvent.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/EventDispatchThread.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/java/awt/MenuComponent.java ! src/share/classes/java/awt/TrayIcon.java ! src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/share/classes/java/security/AccessControlContext.java ! src/share/classes/javax/swing/Timer.java ! src/share/classes/javax/swing/TransferHandler.java ! src/share/classes/sun/font/FileFont.java ! src/share/classes/sun/font/TrueTypeFont.java ! src/share/classes/sun/font/Type1Font.java ! src/share/classes/sun/misc/FloatingDecimal.java ! src/share/classes/sun/misc/SharedSecrets.java ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/share/classes/sun/nio/ch/Net.java ! src/share/classes/sun/security/validator/EndEntityChecker.java ! src/share/classes/sun/swing/table/DefaultTableCellHeaderRenderer.java ! src/solaris/bin/java_md.c ! test/Makefile ! test/ProblemList.txt ! test/java/awt/xembed/server/TestXEmbedServer.java ! test/java/lang/Double/ParseDouble.java ! test/javax/imageio/plugins/png/ITXtTest.java ! test/javax/imageio/plugins/png/ItxtUtf8Test.java ! test/sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnection/CriticalSubjectAltName.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/HttpsPost.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/IPAddressDNSIdentities.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/IPAddressIPIdentities.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/IPIdentities.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/Identities.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/Redirect.java From kelly.ohair at oracle.com Tue Apr 5 16:52:24 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Tue, 05 Apr 2011 23:52:24 +0000 Subject: hg: jdk6/jdk6/langtools: 7033660: Update copyright year to 2011 on any files changed in 2011 Message-ID: <20110405235225.AA6474780A@hg.openjdk.java.net> Changeset: e4adb4f86165 Author: ohair Date: 2011-04-05 16:49 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/langtools/rev/e4adb4f86165 7033660: Update copyright year to 2011 on any files changed in 2011 Reviewed-by: darcy ! make/netbeans/langtools/build.xml ! make/netbeans/langtools/nbproject/project.xml ! make/netbeans/langtools/nbproject/standard-context-menu-items.ent ! make/netbeans/langtools/nbproject/standard-ide-actions.ent ! make/tools/SelectTool/SelectToolTask.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! test/tools/javac/6889255/T6889255.java ! test/tools/javac/T6595666.java ! test/tools/javac/lib/JavacTestingAbstractProcessor.java ! test/tools/javac/processing/filer/TestInvalidRelativeNames.java ! test/tools/javac/processing/filer/TestValidRelativeNames.java From ahughes at redhat.com Tue Apr 19 07:29:37 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Tue, 19 Apr 2011 15:29:37 +0100 Subject: hs20 merge Message-ID: <20110419142937.GG29985@rivendell.middle-earth.co.uk> Hi Kelly, Here's the first real test of your OpenJDK6 reviewing powers :-D This webrev: http://cr.openjdk.java.net/~andrew/jdk6-hs20-merge/webrev.01/ updates OpenJDK6's HotSpot to hs20b11 from the hs20 stable repository: http://hg.openjdk.java.net/hsx/hsx20/master Ok to push? -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: F5862A37 (https://keys.indymedia.org/) Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37 From xerxes at zafena.se Wed Apr 20 07:00:22 2011 From: xerxes at zafena.se (=?ISO-8859-1?Q?Xerxes_R=E5nby?=) Date: Wed, 20 Apr 2011 16:00:22 +0200 Subject: Review Request: Regression Shark fails to JIT in hs20 Message-ID: <4DAEE6F6.7090704@zafena.se> Hi Shark JIT fails to work when using HotSpot 20. This webrev fix by backporting Shark fixes from OpenJDK bug 7032458. http://labb.zafena.se/openjdk/pr690-shark-jit-regression-hs20/ The webrev are made against hsx20 http://hg.openjdk.java.net/hsx/hsx20/master/ I don't have a bug id for this. Cheers Xerxes From xerxes at zafena.se Wed Apr 20 07:00:32 2011 From: xerxes at zafena.se (=?ISO-8859-1?Q?Xerxes_R=E5nby?=) Date: Wed, 20 Apr 2011 16:00:32 +0200 Subject: Review Request: Regression Zero fails to handle fast_aldc and fast_aldc_w in hs20 Message-ID: <4DAEE700.6010501@zafena.se> Hi hs20 uses two new internal instructions fast_aldc and fast_aldc_w. see: openjdk/hotspot/src/share/vm/interpreter/bytecodes.hpp This webrev fix by backporting Zero fixes from OpenJDK bug 7032458 and 7030207. http://labb.zafena.se/openjdk/pr696-zero-fast_aldc-and-fast_aldc_w-regression-hs20/ The webrev are made against hsx20 http://hg.openjdk.java.net/hsx/hsx20/master/ I don't have a bug id for this. Cheers Xerxes From ahughes at redhat.com Wed Apr 20 15:38:51 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Wed, 20 Apr 2011 23:38:51 +0100 Subject: Review Request: Regression Shark fails to JIT in hs20 In-Reply-To: <4DAEE6F6.7090704@zafena.se> References: <4DAEE6F6.7090704@zafena.se> Message-ID: <20110420223851.GU29985@rivendell.middle-earth.co.uk> On 16:00 Wed 20 Apr , Xerxes R?nby wrote: > Hi > > Shark JIT fails to work when using HotSpot 20. > > This webrev fix by backporting Shark fixes from OpenJDK bug 7032458. > http://labb.zafena.se/openjdk/pr690-shark-jit-regression-hs20/ > > The webrev are made against hsx20 > http://hg.openjdk.java.net/hsx/hsx20/master/ > > I don't have a bug id for this. > AIUI, commits to hs20 are only allowed by Oracle employees. At least, that's what I've been told in the past. So this will need to go into the OpenJDK6 HotSpot tree once hs20 is merged. If this is a backport of 7032458, why do you need a bug ID? As a side note, the server you are uploading the webrev to does not have mime types set up correctly. I couldn't view the patch without being asked to download it. It is viewable on cr.openjdk.java.net. Is there a reason you aren't using this? > Cheers > Xerxes -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: F5862A37 (https://keys.indymedia.org/) Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37 From ahughes at redhat.com Wed Apr 20 15:39:23 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Wed, 20 Apr 2011 23:39:23 +0100 Subject: Review Request: Regression Zero fails to handle fast_aldc and fast_aldc_w in hs20 In-Reply-To: <4DAEE700.6010501@zafena.se> References: <4DAEE700.6010501@zafena.se> Message-ID: <20110420223922.GV29985@rivendell.middle-earth.co.uk> On 16:00 Wed 20 Apr , Xerxes R?nby wrote: > Hi > > hs20 uses two new internal instructions fast_aldc and fast_aldc_w. > see: openjdk/hotspot/src/share/vm/interpreter/bytecodes.hpp > > This webrev fix by backporting Zero fixes from OpenJDK bug 7032458 and 7030207. > http://labb.zafena.se/openjdk/pr696-zero-fast_aldc-and-fast_aldc_w-regression-hs20/ > > The webrev are made against hsx20 > http://hg.openjdk.java.net/hsx/hsx20/master/ > > I don't have a bug id for this. > > Cheers > Xerxes Why are you merging together two different changesets? -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: F5862A37 (https://keys.indymedia.org/) Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37 From xerxes at zafena.se Wed Apr 20 16:43:04 2011 From: xerxes at zafena.se (=?ISO-8859-1?Q?Xerxes_R=E5nby?=) Date: Thu, 21 Apr 2011 01:43:04 +0200 Subject: Review Request: Regression Shark fails to JIT in hs20 In-Reply-To: <20110420223851.GU29985@rivendell.middle-earth.co.uk> References: <4DAEE6F6.7090704@zafena.se> <20110420223851.GU29985@rivendell.middle-earth.co.uk> Message-ID: <4DAF6F88.5040705@zafena.se> On 2011-04-21 00:38, Dr Andrew John Hughes wrote: > On 16:00 Wed 20 Apr , Xerxes R?nby wrote: >> Hi >> >> Shark JIT fails to work when using HotSpot 20. >> >> This webrev fix by backporting Shark fixes from OpenJDK bug 7032458. >> http://labb.zafena.se/openjdk/pr690-shark-jit-regression-hs20/ >> >> The webrev are made against hsx20 >> http://hg.openjdk.java.net/hsx/hsx20/master/ >> >> I don't have a bug id for this. >> > > AIUI, commits to hs20 are only allowed by Oracle employees. > At least, that's what I've been told in the past. So this > will need to go into the OpenJDK6 HotSpot tree once hs20 is > merged. I agree its not clear how to file patches for regressions to the hsXX branches. I got recommended by Chris Phillips on IRC to send in the patch for review with a long cc list. > > If this is a backport of 7032458, why do you need a bug ID? 7032458 contains more than one fix (one zero fix, this shark fix and one parts that do not belong in hs20 at all). Preferably i would like a bug ID that handles this Shark regression for the hs20 branch. > > As a side note, the server you are uploading the webrev to does > not have mime types set up correctly. I couldn't view the patch > without being asked to download it. odd, my server used the correct patch mime type of text/x-diff for diff and patch files. I have now changed my server to instead use text/plain for diff and patch files to ease review. It is viewable on cr.openjdk.java.net. > Is there a reason you aren't using this? I do not have an account on that server. Only users with push access to the OpenJDK mercurial server can use the cr.openjdk.java.net server: http://openjdk.java.net/guide/codeReview.html > >> Cheers >> Xerxes > From xerxes at zafena.se Wed Apr 20 17:07:01 2011 From: xerxes at zafena.se (=?ISO-8859-1?Q?Xerxes_R=E5nby?=) Date: Thu, 21 Apr 2011 02:07:01 +0200 Subject: Review Request: Regression Zero fails to handle fast_aldc and fast_aldc_w in hs20 In-Reply-To: <20110420223922.GV29985@rivendell.middle-earth.co.uk> References: <4DAEE700.6010501@zafena.se> <20110420223922.GV29985@rivendell.middle-earth.co.uk> Message-ID: <4DAF7525.4020509@zafena.se> On 2011-04-21 00:39, Dr Andrew John Hughes wrote: > On 16:00 Wed 20 Apr , Xerxes R?nby wrote: >> Hi >> >> hs20 uses two new internal instructions fast_aldc and fast_aldc_w. >> see: openjdk/hotspot/src/share/vm/interpreter/bytecodes.hpp >> >> This webrev fix by backporting Zero fixes from OpenJDK bug 7032458 and 7030207. >> http://labb.zafena.se/openjdk/pr696-zero-fast_aldc-and-fast_aldc_w-regression-hs20/ >> >> The webrev are made against hsx20 >> http://hg.openjdk.java.net/hsx/hsx20/master/ >> >> I don't have a bug id for this. > > Why are you merging together two different changesets? Because they both contain parts that are needed to properly fix this Zero regression on hs20 and prevent it from happening again. One part that fixes the regression by making the instruction table in sync again from 7032458, and another part from 7030207 that reveals the error if the table gets out of sync again. If I quote Gary: "It two new internal instructions, _fast_aldc and _fast_aldc_w, but it added them *before* _return_register_finalizer, which broke the instructions table in bytecodeInterpreter.cpp. It meant that when the C++ interpreter saw _return_register_finalizer it would execute opc_default, which should have thrown an error but for the piece of the ARM interpreter which hid the error by rewriting the instruction to a plain _return. I didn't see it before because I was doing debug builds, and the C++ interpreter only uses the instructions table for product builds." http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2011-March/005074.html Cheers Xerxes From ahughes at redhat.com Wed Apr 20 17:13:46 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Thu, 21 Apr 2011 01:13:46 +0100 Subject: Review Request: Regression Shark fails to JIT in hs20 In-Reply-To: <4DAF6F88.5040705@zafena.se> References: <4DAEE6F6.7090704@zafena.se> <20110420223851.GU29985@rivendell.middle-earth.co.uk> <4DAF6F88.5040705@zafena.se> Message-ID: <20110421001346.GF29985@rivendell.middle-earth.co.uk> On 01:43 Thu 21 Apr , Xerxes R?nby wrote: > On 2011-04-21 00:38, Dr Andrew John Hughes wrote: > > On 16:00 Wed 20 Apr , Xerxes R?nby wrote: > >> Hi > >> > >> Shark JIT fails to work when using HotSpot 20. > >> > >> This webrev fix by backporting Shark fixes from OpenJDK bug 7032458. > >> http://labb.zafena.se/openjdk/pr690-shark-jit-regression-hs20/ > >> > >> The webrev are made against hsx20 > >> http://hg.openjdk.java.net/hsx/hsx20/master/ > >> > >> I don't have a bug id for this. > >> > > > > AIUI, commits to hs20 are only allowed by Oracle employees. > > At least, that's what I've been told in the past. So this > > will need to go into the OpenJDK6 HotSpot tree once hs20 is > > merged. > I agree its not clear how to file patches for regressions to the hsXX > branches. > I got recommended by Chris Phillips on IRC to send in the patch for > review with a long cc list. > I'm just repeating what I was told when I wanted to do the same thing. I don't agree with it FWIW. > > > > If this is a backport of 7032458, why do you need a bug ID? > 7032458 contains more than one fix (one zero fix, this shark fix and one > parts that do not belong in hs20 at all). Preferably i would like a bug > ID that handles this Shark regression for the hs20 branch. > I agree with your reasoning. I complained about this patch at the time: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2011-March/005021.html > > > > As a side note, the server you are uploading the webrev to does > > not have mime types set up correctly. I couldn't view the patch > > without being asked to download it. > odd, my server used the correct patch mime type of > text/x-diff for diff and patch files. > I have now changed my server to instead use > text/plain for diff and patch files to ease review. > Thanks. It works now. text/x-diff is probably right but both Firefox and Chromium don't seem to think so. Or rather, they are too stupid to realise they can display it. > > It is viewable on cr.openjdk.java.net. > > Is there a reason you aren't using this? > I do not have an account on that server. Only users with push access to > the OpenJDK mercurial server can use the cr.openjdk.java.net server: > http://openjdk.java.net/guide/codeReview.html > I kinda assumed you had push access as you posted a patch for review... But I or someone else can easily push it for you once it is approved and has a bug ID. jdk6 patches have to be reviewed by Kelly for some reason, otherwise I could just be the reviewer on this one. And also, as I mentioned before, OpenJDK6 needs to have the merge approved first: http://mail.openjdk.java.net/pipermail/jdk6-dev/2011-April/002392.html > > > >> Cheers > >> Xerxes > > > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: F5862A37 (https://keys.indymedia.org/) Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37 From ahughes at redhat.com Wed Apr 20 17:15:49 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Thu, 21 Apr 2011 01:15:49 +0100 Subject: Review Request: Regression Zero fails to handle fast_aldc and fast_aldc_w in hs20 In-Reply-To: <4DAF7525.4020509@zafena.se> References: <4DAEE700.6010501@zafena.se> <20110420223922.GV29985@rivendell.middle-earth.co.uk> <4DAF7525.4020509@zafena.se> Message-ID: <20110421001549.GG29985@rivendell.middle-earth.co.uk> On 02:07 Thu 21 Apr , Xerxes R?nby wrote: > On 2011-04-21 00:39, Dr Andrew John Hughes wrote: > > On 16:00 Wed 20 Apr , Xerxes R?nby wrote: > >> Hi > >> > >> hs20 uses two new internal instructions fast_aldc and fast_aldc_w. > >> see: openjdk/hotspot/src/share/vm/interpreter/bytecodes.hpp > >> > >> This webrev fix by backporting Zero fixes from OpenJDK bug 7032458 and 7030207. > >> http://labb.zafena.se/openjdk/pr696-zero-fast_aldc-and-fast_aldc_w-regression-hs20/ > >> > >> The webrev are made against hsx20 > >> http://hg.openjdk.java.net/hsx/hsx20/master/ > >> > >> I don't have a bug id for this. > > > > Why are you merging together two different changesets? > > Because they both contain parts that are needed to properly fix this > Zero regression on hs20 and prevent it from happening again. > > One part that fixes the regression by making the instruction table in > sync again from 7032458, and another part from 7030207 that reveals the > error if the table gets out of sync again. > > If I quote Gary: > "It two new internal instructions, _fast_aldc and _fast_aldc_w, but > it added them *before* _return_register_finalizer, which broke the > instructions table in bytecodeInterpreter.cpp. It meant that when > the C++ interpreter saw _return_register_finalizer it would execute > opc_default, which should have thrown an error but for the piece of > the ARM interpreter which hid the error by rewriting the instruction > to a plain _return. I didn't see it before because I was doing > debug builds, and the C++ interpreter only uses the instructions > table for product builds." > http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2011-March/005074.html > Are there bits of each changeset being left out? It's just it's easier to track if there is a 1-to-1 correspondence. > Cheers > Xerxes -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: F5862A37 (https://keys.indymedia.org/) Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37 From xerxes at zafena.se Wed Apr 20 17:40:09 2011 From: xerxes at zafena.se (=?ISO-8859-1?Q?Xerxes_R=E5nby?=) Date: Thu, 21 Apr 2011 02:40:09 +0200 Subject: Review Request: Regression Zero fails to handle fast_aldc and fast_aldc_w in hs20 In-Reply-To: <20110421001549.GG29985@rivendell.middle-earth.co.uk> References: <4DAEE700.6010501@zafena.se> <20110420223922.GV29985@rivendell.middle-earth.co.uk> <4DAF7525.4020509@zafena.se> <20110421001549.GG29985@rivendell.middle-earth.co.uk> Message-ID: <4DAF7CE9.50209@zafena.se> On 2011-04-21 02:15, Dr Andrew John Hughes wrote: > On 02:07 Thu 21 Apr , Xerxes R?nby wrote: >> On 2011-04-21 00:39, Dr Andrew John Hughes wrote: >>> On 16:00 Wed 20 Apr , Xerxes R?nby wrote: >>>> Hi >>>> >>>> hs20 uses two new internal instructions fast_aldc and fast_aldc_w. >>>> see: openjdk/hotspot/src/share/vm/interpreter/bytecodes.hpp >>>> >>>> This webrev fix by backporting Zero fixes from OpenJDK bug 7032458 and 7030207. >>>> http://labb.zafena.se/openjdk/pr696-zero-fast_aldc-and-fast_aldc_w-regression-hs20/ >>>> >>>> The webrev are made against hsx20 >>>> http://hg.openjdk.java.net/hsx/hsx20/master/ >>>> >>>> I don't have a bug id for this. >>> >>> Why are you merging together two different changesets? >> >> Because they both contain parts that are needed to properly fix this >> Zero regression on hs20 and prevent it from happening again. >> >> One part that fixes the regression by making the instruction table in >> sync again from 7032458, and another part from 7030207 that reveals the >> error if the table gets out of sync again. >> >> If I quote Gary: >> "It two new internal instructions, _fast_aldc and _fast_aldc_w, but >> it added them *before* _return_register_finalizer, which broke the >> instructions table in bytecodeInterpreter.cpp. It meant that when >> the C++ interpreter saw _return_register_finalizer it would execute >> opc_default, which should have thrown an error but for the piece of >> the ARM interpreter which hid the error by rewriting the instruction >> to a plain _return. I didn't see it before because I was doing >> debug builds, and the C++ interpreter only uses the instructions >> table for product builds." >> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2011-March/005074.html >> > > Are there bits of each changeset being left out? It's just it's easier > to track if there is a 1-to-1 correspondence. Large parts of 7032458 are left out that are unrelated to this Zero regression in hs20 (some Shark fixes and non hs20 fixes). The changeset from 7030207 are intact and can be backported by 1-to-1 correspondence if preferable. Personally I would prefer to see this Zero hs20 regression to be tracked as a unit in a Bug ID of its own. > >> Cheers >> Xerxes > From kelly.ohair at oracle.com Thu Apr 21 10:39:04 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 21 Apr 2011 10:39:04 -0700 Subject: hs20 merge In-Reply-To: <20110419142937.GG29985@rivendell.middle-earth.co.uk> References: <20110419142937.GG29985@rivendell.middle-earth.co.uk> Message-ID: <96DCBAEC-1C32-4FAC-88D6-3224672C7538@oracle.com> Approved for push. Once it is in, we will need to verify all builds are ok, and have some bake time. -kto On Apr 19, 2011, at 7:29 AM, Dr Andrew John Hughes wrote: > Hi Kelly, > > Here's the first real test of your OpenJDK6 reviewing powers :-D > > This webrev: > > http://cr.openjdk.java.net/~andrew/jdk6-hs20-merge/webrev.01/ > > updates OpenJDK6's HotSpot to hs20b11 from the hs20 > stable repository: > > http://hg.openjdk.java.net/hsx/hsx20/master > > Ok to push? > -- > Andrew :) > > Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > Support Free Java! > Contribute to GNU Classpath and IcedTea > http://www.gnu.org/software/classpath > http://icedtea.classpath.org > PGP Key: F5862A37 (https://keys.indymedia.org/) > Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37 From kelly.ohair at oracle.com Thu Apr 21 10:47:00 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 21 Apr 2011 10:47:00 -0700 Subject: Review Request: Regression Shark fails to JIT in hs20 In-Reply-To: <20110421001346.GF29985@rivendell.middle-earth.co.uk> References: <4DAEE6F6.7090704@zafena.se> <20110420223851.GU29985@rivendell.middle-earth.co.uk> <4DAF6F88.5040705@zafena.se> <20110421001346.GF29985@rivendell.middle-earth.co.uk> Message-ID: I removed the hotspot alias... I am unable to follow this email exchange. Could someone resend a new email, with a good description of what the change is for, what the change is, and a webrev? And please, if this is for OpenJDK6, please only use the jdk6-dev alias, using multiple aliases just confuses matters. If you need help from the hotspot team, send email to just them, get that taken care of first, then ask for approval to go into OpenJDK6 is necessary. If a CR needs to be filed, I need more details as to what the CR is, a short description, and what java category/subcategory it would belong to. If the contributor is not on the OpenJDK commit list (http://db.openjdk.java.net/) I need evidence that the SCA or OCA has been signed, and someone will need to sponsor the change as a contribution. -kto On Apr 20, 2011, at 5:13 PM, Dr Andrew John Hughes wrote: > On 01:43 Thu 21 Apr , Xerxes R?nby wrote: >> On 2011-04-21 00:38, Dr Andrew John Hughes wrote: >>> On 16:00 Wed 20 Apr , Xerxes R?nby wrote: >>>> Hi >>>> >>>> Shark JIT fails to work when using HotSpot 20. >>>> >>>> This webrev fix by backporting Shark fixes from OpenJDK bug 7032458. >>>> http://labb.zafena.se/openjdk/pr690-shark-jit-regression-hs20/ >>>> >>>> The webrev are made against hsx20 >>>> http://hg.openjdk.java.net/hsx/hsx20/master/ >>>> >>>> I don't have a bug id for this. >>>> >>> >>> AIUI, commits to hs20 are only allowed by Oracle employees. >>> At least, that's what I've been told in the past. So this >>> will need to go into the OpenJDK6 HotSpot tree once hs20 is >>> merged. >> I agree its not clear how to file patches for regressions to the hsXX >> branches. >> I got recommended by Chris Phillips on IRC to send in the patch for >> review with a long cc list. >> > > I'm just repeating what I was told when I wanted to do the same thing. > I don't agree with it FWIW. > >>> >>> If this is a backport of 7032458, why do you need a bug ID? >> 7032458 contains more than one fix (one zero fix, this shark fix and one >> parts that do not belong in hs20 at all). Preferably i would like a bug >> ID that handles this Shark regression for the hs20 branch. >> > > I agree with your reasoning. I complained about this patch at the time: > > http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2011-March/005021.html > >>> >>> As a side note, the server you are uploading the webrev to does >>> not have mime types set up correctly. I couldn't view the patch >>> without being asked to download it. >> odd, my server used the correct patch mime type of >> text/x-diff for diff and patch files. >> I have now changed my server to instead use >> text/plain for diff and patch files to ease review. >> > > Thanks. It works now. > text/x-diff is probably right but both Firefox and Chromium don't seem to think so. > Or rather, they are too stupid to realise they can display it. > >> >> It is viewable on cr.openjdk.java.net. >>> Is there a reason you aren't using this? >> I do not have an account on that server. Only users with push access to >> the OpenJDK mercurial server can use the cr.openjdk.java.net server: >> http://openjdk.java.net/guide/codeReview.html >> > > I kinda assumed you had push access as you posted a patch for review... > But I or someone else can easily push it for you once it is approved > and has a bug ID. > > jdk6 patches have to be reviewed by Kelly for some reason, otherwise > I could just be the reviewer on this one. And also, as I mentioned before, > OpenJDK6 needs to have the merge approved first: > > http://mail.openjdk.java.net/pipermail/jdk6-dev/2011-April/002392.html > >>> >>>> Cheers >>>> Xerxes >>> >> > > -- > Andrew :) > > Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > Support Free Java! > Contribute to GNU Classpath and IcedTea > http://www.gnu.org/software/classpath > http://icedtea.classpath.org > PGP Key: F5862A37 (https://keys.indymedia.org/) > Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37 From omajid at redhat.com Fri Apr 22 13:04:44 2011 From: omajid at redhat.com (Omair Majid) Date: Fri, 22 Apr 2011 16:04:44 -0400 Subject: Request to backport 6944361: Missing CKR_ values in PKCS11Exception Message-ID: <4DB1DF5C.4000602@redhat.com> Hi, I would like to backport the following changeset to OpenJDK6: 6944361: Missing CKR_ values in PKCS11Exception http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c444651077d2 We have had this patch in IcedTea6 and OpenJDK7 for a while now; it would be nice to have this in OpenJDK6 too. Okay to backport? Cheers, Omair From kelly.ohair at oracle.com Fri Apr 22 13:19:52 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 22 Apr 2011 13:19:52 -0700 Subject: Request to backport 6944361: Missing CKR_ values in PKCS11Exception In-Reply-To: <4DB1DF5C.4000602@redhat.com> References: <4DB1DF5C.4000602@redhat.com> Message-ID: <8C35589B-6086-4A0F-815B-AC07C3C57B60@oracle.com> Approved. -kto On Apr 22, 2011, at 1:04 PM, Omair Majid wrote: > Hi, > > I would like to backport the following changeset to OpenJDK6: > > 6944361: Missing CKR_ values in PKCS11Exception > http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c444651077d2 > > We have had this patch in IcedTea6 and OpenJDK7 for a while now; it would be nice to have this in OpenJDK6 too. > > Okay to backport? > > Cheers, > Omair From omajid at redhat.com Fri Apr 22 14:51:58 2011 From: omajid at redhat.com (Omair Majid) Date: Fri, 22 Apr 2011 17:51:58 -0400 Subject: Request to backport 6944361: Missing CKR_ values in PKCS11Exception In-Reply-To: <8C35589B-6086-4A0F-815B-AC07C3C57B60@oracle.com> References: <4DB1DF5C.4000602@redhat.com> <8C35589B-6086-4A0F-815B-AC07C3C57B60@oracle.com> Message-ID: <4DB1F87E.9020508@redhat.com> On 04/22/2011 04:19 PM, Kelly O'Hair wrote: > Approved. > Sorry to have bothered you. I was working with out-of-date data. This changeset is, in fact, already in jdk6: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c3a035784a3a Again, sorry for the noise. Thanks, Omair From kelly.ohair at oracle.com Wed Apr 27 07:36:01 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 27 Apr 2011 07:36:01 -0700 Subject: Request to backport 7000693: java.sql.Timestamp compareTo() issues using low values In-Reply-To: <4D8A466D.6010404@redhat.com> References: <4D8A466D.6010404@redhat.com> Message-ID: Approved. -kto On Mar 23, 2011, at 12:13 PM, Omair Majid wrote: > Hi, > > I would like to backport the following changeset to jdk6: > > http://hg.openjdk.java.net/jdk7/tl/jdk/rev/befe813e24d2 > > changeset: 3385:befe813e24d2 > user: lancea > date: Tue Jan 11 12:36:43 2011 -0500 > summary: 7000693: java.sql.Timestamp compareTo() issues using low values > > Okay to push? > > Cheers, > Omair