From joe.darcy at oracle.com Tue Mar 1 00:01:52 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Tue, 01 Mar 2011 00:01:52 -0800 Subject: A changing of the guard for OpenJDK 6 release management Message-ID: <4D6CA7F0.2090506@oracle.com> The first public source drop of OpenJDK 6 went out just over three years ago. I've been the release manager for the project for all that time and for the preceding six months while the effort was incubating inside of Sun. Somewhat later than anticipated at the start, all initial goals for the project have long been met, with a public master code repository worked on by both the internal and external community members and a code base that can be used to build a fully compatible implementation of Java SE 6. Combined with the IcedTea 6 set of patches and additions, the code from OpenJDK 6 is used to build the JDK packaged with many Linux distributions. However, to have more time to spend on other projects, such as Project Coin, effective immediately I've turned over release management responsibilities for OpenJDK 6 to my colleague Kelly O'Hair. Kelly has considerable experience with JDK development in general and OpenJDK 6 in particular. Kelly has made major contributions to OpenJDK 6 throughout all phases of the project, starting from its inception, to the synthesis of its public Mercurial repositories with history information, to the recent purging of the despised binary plugs. While I have some sadness in relinquishing leadership of the project, I'm happy to be leaving OpenJDK 6 release management in Kelly's capable hands. -Joe From sean.coffey at oracle.com Tue Mar 1 02:47:42 2011 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Tue, 01 Mar 2011 10:47:42 +0000 Subject: hg: jdk6/jdk6/jdk: 6998583: NativeSeedGenerator is making 8192 byte read requests from entropy pool Message-ID: <20110301104813.E0D3547B6C@hg.openjdk.java.net> Changeset: 9e9b8306ea52 Author: coffeys Date: 2011-03-01 10:48 +0000 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/9e9b8306ea52 6998583: NativeSeedGenerator is making 8192 byte read requests from entropy pool Reviewed-by: wetmore, darcy ! src/share/classes/sun/security/provider/SeedGenerator.java ! src/windows/classes/sun/security/provider/NativeSeedGenerator.java + test/sun/security/provider/SeedGenerator/SeedGeneratorChoice.java From ahughes at redhat.com Tue Mar 1 02:51:23 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Tue, 1 Mar 2011 10:51:23 +0000 Subject: A changing of the guard for OpenJDK 6 release management In-Reply-To: <4D6CA7F0.2090506@oracle.com> References: <4D6CA7F0.2090506@oracle.com> Message-ID: <20110301105123.GB28140@rivendell.middle-earth.co.uk> On 00:01 Tue 01 Mar , Joe Darcy wrote: > The first public source drop of OpenJDK 6 went out just over three years > ago. I've been the release manager for the project for all that time and > for the preceding six months while the effort was incubating inside of > Sun. Somewhat later than anticipated at the start, all initial goals for > the project have long been met, with a public master code repository > worked on by both the internal and external community members and a code > base that can be used to build a fully compatible implementation of Java > SE 6. Combined with the IcedTea 6 set of patches and additions, the code > from OpenJDK 6 is used to build the JDK packaged with many Linux > distributions. > > However, to have more time to spend on other projects, such as Project > Coin, effective immediately I've turned over release management > responsibilities for OpenJDK 6 to my colleague Kelly O'Hair. Kelly has > considerable experience with JDK development in general and OpenJDK 6 in > particular. Kelly has made major contributions to OpenJDK 6 throughout > all phases of the project, starting from its inception, to the synthesis > of its public Mercurial repositories with history information, to the > recent purging of the despised binary plugs. > > While I have some sadness in relinquishing leadership of the project, > I'm happy to be leaving OpenJDK 6 release management in Kelly's capable > hands. > > -Joe Thanks for all your hard work, Joe. It's been much appreciated. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: F5862A37 (https://keys.indymedia.org/) Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37 From joe.darcy at oracle.com Tue Mar 1 18:25:37 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 01 Mar 2011 18:25:37 -0800 Subject: Two suggested langtools backports to OpenJDK 6 Message-ID: <4D6DAAA1.4090901@oracle.com> Hello. I suggest the following two langtools fixes be backported from JDK 7 to OpenJDK 6: 6507024 java/compiler: unchecked conversion between arrays fails after capture conversion http://hg.openjdk.java.net/jdk7/jdk7/langtools/rev/6e9a43815df7 6999460 java/compiler: Glassfish build with JDK 6 / 7 is 5x-10x slower on Windows than on Linux http://hg.openjdk.java.net/jdk7/jdk7/langtools/rev/a8d3eed8e247 Fixes for these two bugs are already in the proprietary 6 update train. -Joe From joe.darcy at oracle.com Wed Mar 2 12:08:53 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 02 Mar 2011 12:08:53 -0800 Subject: Two suggested langtools backports to OpenJDK 6 In-Reply-To: <4D6DAAA1.4090901@oracle.com> References: <4D6DAAA1.4090901@oracle.com> Message-ID: <4D6EA3D5.7010702@oracle.com> joe.darcy at oracle.com wrote: > Hello. > > I suggest the following two langtools fixes be backported from JDK 7 > to OpenJDK 6: > > 6507024 java/compiler: unchecked conversion between arrays fails > after capture conversion > http://hg.openjdk.java.net/jdk7/jdk7/langtools/rev/6e9a43815df7 A follow-up, this patch applies cleanly and all regression tests, old and new, pass with the change. Pending Kelly's approval, it is ready to push :-) > > 6999460 java/compiler: Glassfish build with JDK 6 / 7 is 5x-10x > slower on Windows than on Linux > http://hg.openjdk.java.net/jdk7/jdk7/langtools/rev/a8d3eed8e247 > > Fixes for these two bugs are already in the proprietary 6 update train. > On the other hand, some porting of the JDK 7 patch for 6999460 needs to be done before it can be applied to OpenJDK 6. -Joe From kelly.ohair at oracle.com Wed Mar 2 12:18:12 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 2 Mar 2011 12:18:12 -0800 Subject: Two suggested langtools backports to OpenJDK 6 In-Reply-To: <4D6DAAA1.4090901@oracle.com> References: <4D6DAAA1.4090901@oracle.com> Message-ID: <07F622CC-F7C7-4279-8C55-B1BCA42E4E30@oracle.com> Approved for openjdk6, "You may fire when ready, Gridley," -kto On Mar 1, 2011, at 6:25 PM, joe.darcy at oracle.com wrote: > Hello. > > I suggest the following two langtools fixes be backported from JDK 7 to OpenJDK 6: > > 6507024 java/compiler: unchecked conversion between arrays fails after capture conversion > http://hg.openjdk.java.net/jdk7/jdk7/langtools/rev/6e9a43815df7 > > 6999460 java/compiler: Glassfish build with JDK 6 / 7 is 5x-10x slower on Windows than on Linux > http://hg.openjdk.java.net/jdk7/jdk7/langtools/rev/a8d3eed8e247 > > Fixes for these two bugs are already in the proprietary 6 update train. > > -Joe > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20110302/f6244496/attachment.html From joe.darcy at oracle.com Wed Mar 2 16:25:14 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Thu, 03 Mar 2011 00:25:14 +0000 Subject: hg: jdk6/jdk6/langtools: 6507024: casting an array to a generic type results in a 'capture#69 of ?' type error Message-ID: <20110303002516.1636E47BEA@hg.openjdk.java.net> Changeset: 53c36ed62e32 Author: mcimadamore Date: 2008-05-30 10:42 +0100 URL: http://hg.openjdk.java.net/jdk6/jdk6/langtools/rev/53c36ed62e32 6507024: casting an array to a generic type results in a 'capture#69 of ?' type error Summary: Types.isSubtypeUnchecked() should handle type-variables subtyping properly Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/generics/T6507024.java From huizhe.wang at oracle.com Wed Mar 9 11:43:07 2011 From: huizhe.wang at oracle.com (Joe Wang) Date: Wed, 09 Mar 2011 11:43:07 -0800 Subject: request to patch jaxp in openjdk6 In-Reply-To: <4C7EB3A2.3030109@oracle.com> References: <4C7EA9C9.3080604@oracle.com> <4C7EB3A2.3030109@oracle.com> Message-ID: <4D77D84B.5040806@oracle.com> Hi, I'd like to ask for an approval to integrate a jaxp patch into OpenJDK6. The patch is in the form of jaxp144_02.zip, that is, 2nd patch for jaxp 1.4.4. The bundle fixed JCK 6b failures on OpenJDK 6 b21/b22. The fix was done through porting the patch for CR 6989150 JCK7: 3 deserialization tests for javax.xml classes fail since JDK7-b112, by setting serial version UID explicitly to match UIDs for previous JAXP version.: private static final long serialVersionUID = -2994412584589975744L; private static final long serialVersionUID = -6527718720676281516L; private static final long serialVersionUID = -827108682472263355L; to the following classes: src/javax/xml/stream/FactoryConfigurationError.java src/javax/xml/transform/TransformerFactoryConfigurationError.java src/javax/xml/parsers/FactoryConfigurationError.java Thanks, Joe From kelly.ohair at oracle.com Wed Mar 9 14:33:10 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 9 Mar 2011 14:33:10 -0800 Subject: request to patch jaxp in openjdk6 In-Reply-To: <4D77D84B.5040806@oracle.com> References: <4C7EA9C9.3080604@oracle.com> <4C7EB3A2.3030109@oracle.com> <4D77D84B.5040806@oracle.com> Message-ID: <9D66FAF1-F498-4CE6-A88D-F9DE1386DF20@oracle.com> Approved. -kto On Mar 9, 2011, at 11:43 AM, Joe Wang wrote: > Hi, > > I'd like to ask for an approval to integrate a jaxp patch into OpenJDK6. The patch is in the form of jaxp144_02.zip, that is, 2nd patch for jaxp 1.4.4. The bundle fixed JCK 6b failures on OpenJDK 6 b21/b22. The fix was done through porting the patch for CR 6989150 JCK7: 3 deserialization tests for javax.xml classes fail since JDK7-b112, by setting serial version UID explicitly to match UIDs for previous JAXP version.: > > private static final long serialVersionUID = -2994412584589975744L; > private static final long serialVersionUID = -6527718720676281516L; > private static final long serialVersionUID = -827108682472263355L; > > to the following classes: > > src/javax/xml/stream/FactoryConfigurationError.java > src/javax/xml/transform/TransformerFactoryConfigurationError.java > src/javax/xml/parsers/FactoryConfigurationError.java > > Thanks, > Joe From huizhe.wang at oracle.com Wed Mar 9 15:10:29 2011 From: huizhe.wang at oracle.com (Joe Wang) Date: Wed, 09 Mar 2011 15:10:29 -0800 Subject: request to patch jaxp in openjdk6 In-Reply-To: <9D66FAF1-F498-4CE6-A88D-F9DE1386DF20@oracle.com> References: <4C7EA9C9.3080604@oracle.com> <4C7EB3A2.3030109@oracle.com> <4D77D84B.5040806@oracle.com> <9D66FAF1-F498-4CE6-A88D-F9DE1386DF20@oracle.com> Message-ID: <4D7808E5.8090805@oracle.com> Thanks! I've uploaded the bundle to: http://download.java.net/jaxp/openjdk/jdk6/jaxp144_02.zip -Joe On 3/9/2011 2:33 PM, Kelly O'Hair wrote: > Approved. > > -kto > > On Mar 9, 2011, at 11:43 AM, Joe Wang wrote: > > >> Hi, >> >> I'd like to ask for an approval to integrate a jaxp patch into OpenJDK6. The patch is in the form of jaxp144_02.zip, that is, 2nd patch for jaxp 1.4.4. The bundle fixed JCK 6b failures on OpenJDK 6 b21/b22. The fix was done through porting the patch for CR 6989150 JCK7: 3 deserialization tests for javax.xml classes fail since JDK7-b112, by setting serial version UID explicitly to match UIDs for previous JAXP version.: >> >> private static final long serialVersionUID = -2994412584589975744L; >> private static final long serialVersionUID = -6527718720676281516L; >> private static final long serialVersionUID = -827108682472263355L; >> >> to the following classes: >> >> src/javax/xml/stream/FactoryConfigurationError.java >> src/javax/xml/transform/TransformerFactoryConfigurationError.java >> src/javax/xml/parsers/FactoryConfigurationError.java >> >> Thanks, >> Joe >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20110309/3a826aff/attachment.html From kelly.ohair at oracle.com Wed Mar 9 17:51:18 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 9 Mar 2011 17:51:18 -0800 Subject: request to patch jaxp in openjdk6 In-Reply-To: <4D7808E5.8090805@oracle.com> References: <4C7EA9C9.3080604@oracle.com> <4C7EB3A2.3030109@oracle.com> <4D77D84B.5040806@oracle.com> <9D66FAF1-F498-4CE6-A88D-F9DE1386DF20@oracle.com> <4D7808E5.8090805@oracle.com> Message-ID: Could you file a CR? Or provide a CR list in the one line each NNNNNNN: Synopsis format? So I can cut and paste that into the changeset comment. I'll try and get the bundle name changes in ready for review. -kto On Mar 9, 2011, at 3:10 PM, Joe Wang wrote: > Thanks! > > I've uploaded the bundle to: http://download.java.net/jaxp/openjdk/jdk6/jaxp144_02.zip > > -Joe > > On 3/9/2011 2:33 PM, Kelly O'Hair wrote: >> >> Approved. >> >> -kto >> >> On Mar 9, 2011, at 11:43 AM, Joe Wang wrote: >> >> >>> Hi, >>> >>> I'd like to ask for an approval to integrate a jaxp patch into OpenJDK6. The patch is in the form of jaxp144_02.zip, that is, 2nd patch for jaxp 1.4.4. The bundle fixed JCK 6b failures on OpenJDK 6 b21/b22. The fix was done through porting the patch for CR 6989150 JCK7: 3 deserialization tests for javax.xml classes fail since JDK7-b112, by setting serial version UID explicitly to match UIDs for previous JAXP version.: >>> >>> private static final long serialVersionUID = -2994412584589975744L; >>> private static final long serialVersionUID = -6527718720676281516L; >>> private static final long serialVersionUID = -827108682472263355L; >>> >>> to the following classes: >>> >>> src/javax/xml/stream/FactoryConfigurationError.java >>> src/javax/xml/transform/TransformerFactoryConfigurationError.java >>> src/javax/xml/parsers/FactoryConfigurationError.java >>> >>> Thanks, >>> Joe >>> >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20110309/02c724a7/attachment.html From huizhe.wang at oracle.com Wed Mar 9 18:42:52 2011 From: huizhe.wang at oracle.com (Joe Wang) Date: Wed, 09 Mar 2011 18:42:52 -0800 Subject: request to patch jaxp in openjdk6 In-Reply-To: References: <4C7EA9C9.3080604@oracle.com> <4C7EB3A2.3030109@oracle.com> <4D77D84B.5040806@oracle.com> <9D66FAF1-F498-4CE6-A88D-F9DE1386DF20@oracle.com> <4D7808E5.8090805@oracle.com> Message-ID: <4D783AAC.8020600@oracle.com> Kelly, The CR is in the request :) 6989150 : JCK7: 3 deserialization tests for javax.xml classes fail since JDK7-b112 This is a port from JDK7 to OpenJDK6. Thanks, Joe On 3/9/2011 5:51 PM, Kelly O'Hair wrote: > Could you file a CR? Or provide a CR list in the one line each > NNNNNNN: Synopsis > format? > So I can cut and paste that into the changeset comment. > > I'll try and get the bundle name changes in ready for review. > > -kto > > On Mar 9, 2011, at 3:10 PM, Joe Wang wrote: > >> Thanks! >> >> I've uploaded the bundle to: >> http://download.java.net/jaxp/openjdk/jdk6/jaxp144_02.zip >> >> -Joe >> >> On 3/9/2011 2:33 PM, Kelly O'Hair wrote: >>> Approved. >>> >>> -kto >>> >>> On Mar 9, 2011, at 11:43 AM, Joe Wang wrote: >>> >>> >>>> Hi, >>>> >>>> I'd like to ask for an approval to integrate a jaxp patch into OpenJDK6. The patch is in the form of jaxp144_02.zip, that is, 2nd patch for jaxp 1.4.4. The bundle fixed JCK 6b failures on OpenJDK 6 b21/b22. The fix was done through porting the patch for CR 6989150 JCK7: 3 deserialization tests for javax.xml classes fail since JDK7-b112, by setting serial version UID explicitly to match UIDs for previous JAXP version.: >>>> >>>> private static final long serialVersionUID = -2994412584589975744L; >>>> private static final long serialVersionUID = -6527718720676281516L; >>>> private static final long serialVersionUID = -827108682472263355L; >>>> >>>> to the following classes: >>>> >>>> src/javax/xml/stream/FactoryConfigurationError.java >>>> src/javax/xml/transform/TransformerFactoryConfigurationError.java >>>> src/javax/xml/parsers/FactoryConfigurationError.java >>>> >>>> Thanks, >>>> Joe >>>> >>> >>> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20110309/3f0a7a17/attachment.html From ptisnovs at redhat.com Fri Mar 11 08:11:23 2011 From: ptisnovs at redhat.com (Pavel Tisnovsky) Date: Fri, 11 Mar 2011 17:11:23 +0100 Subject: Reviewer needed: backport of change in SunToolkit.java Message-ID: <4D7A49AB.3000307@redhat.com> Hi all, I'd like to backport following change to OpenJDK6: --- openjdk/jdk/src/share/classes/sun/awt/SunToolkit.orig.java 2011-03-11 10:48:29.000000000 +0100 +++ openjdk/jdk/src/share/classes/sun/awt/SunToolkit.java 2011-03-11 11:24:33.000000000 +0100 @@ -65,8 +65,7 @@ /* Load debug settings for native code */ static { - String nativeDebug = System.getProperty("sun.awt.nativedebug"); - if ("true".equalsIgnoreCase(nativeDebug)) { + if (AccessController.doPrivileged(new GetBooleanAction("sun.awt.nativedebug"))) { DebugSettings.init(); } }; Webrev containing this change is available here: http://cr.openjdk.java.net/~ptisnovs/SunToolkit/ This patch fixes the exception which is thrown when Color class (more precisely java.awt.Color) is about to be opened in PropertyEditor. This change is based on OpenJDK7 sources, but I'm unable to determine in which push this changes was made. Does anyone know how to find out the original bug ID or push number to OpenJDK7 repository please? Thank you in advance Pavel T. From fweimer at bfk.de Fri Mar 11 08:33:35 2011 From: fweimer at bfk.de (Florian Weimer) Date: Fri, 11 Mar 2011 16:33:35 +0000 Subject: Reviewer needed: backport of change in SunToolkit.java In-Reply-To: <4D7A49AB.3000307@redhat.com> (Pavel Tisnovsky's message of "Fri\, 11 Mar 2011 17\:11\:23 +0100") References: <4D7A49AB.3000307@redhat.com> Message-ID: <82pqpxvcps.fsf@mid.bfk.de> * Pavel Tisnovsky: > Does anyone know how to find out the original bug ID or push number to > OpenJDK7 repository please? The fix was contained in the initial load, so a bug number may still exist, but not a push number. -- Florian Weimer BFK edv-consulting GmbH http://www.bfk.de/ Kriegsstra?e 100 tel: +49-721-96201-1 D-76133 Karlsruhe fax: +49-721-96201-99 From omajid at redhat.com Mon Mar 14 09:21:38 2011 From: omajid at redhat.com (Omair Majid) Date: Mon, 14 Mar 2011 12:21:38 -0400 Subject: Request to backport 6768387: REGRESSION: JTable no longer serializable Message-ID: <4D7E4092.40101@redhat.com> Hi, I would like to backport the following changeset to openjdk6: changeset: 2380:8d59b361635f user: alexp date: Tue May 25 20:39:52 2010 +0400 summary: 6768387: REGRESSION: JTable no longer serializable Thanks, Omair From kelly.ohair at oracle.com Mon Mar 14 10:55:18 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 14 Mar 2011 10:55:18 -0700 Subject: Request to backport 6768387: REGRESSION: JTable no longer serializable In-Reply-To: <4D7E4092.40101@redhat.com> References: <4D7E4092.40101@redhat.com> Message-ID: <0A3AB525-02AD-401A-B0DE-C858312EF9B8@oracle.com> Can I get a http reference to the changeset next time. I assume this is: http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/8d59b361635f I approve. -kto On Mar 14, 2011, at 9:21 AM, Omair Majid wrote: > Hi, > > I would like to backport the following changeset to openjdk6: > > changeset: 2380:8d59b361635f > user: alexp > date: Tue May 25 20:39:52 2010 +0400 > summary: 6768387: REGRESSION: JTable no longer serializable > > Thanks, > Omair From omajid at redhat.com Mon Mar 14 11:21:59 2011 From: omajid at redhat.com (omajid at redhat.com) Date: Mon, 14 Mar 2011 18:21:59 +0000 Subject: hg: jdk6/jdk6/jdk: 6768387: REGRESSION: JTable no longer serializable Message-ID: <20110314182207.3788D47145@hg.openjdk.java.net> Changeset: 4eed3d0d3293 Author: alexp Date: 2010-05-25 20:39 +0400 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/4eed3d0d3293 6768387: REGRESSION: JTable no longer serializable Reviewed-by: rupashka ! src/share/classes/sun/swing/table/DefaultTableCellHeaderRenderer.java + test/javax/swing/JTable/6768387/bug6768387.java From omajid at redhat.com Mon Mar 14 11:25:13 2011 From: omajid at redhat.com (Omair Majid) Date: Mon, 14 Mar 2011 14:25:13 -0400 Subject: Request to backport 6768387: REGRESSION: JTable no longer serializable In-Reply-To: <0A3AB525-02AD-401A-B0DE-C858312EF9B8@oracle.com> References: <4D7E4092.40101@redhat.com> <0A3AB525-02AD-401A-B0DE-C858312EF9B8@oracle.com> Message-ID: <4D7E5D89.3040500@redhat.com> On 03/14/2011 01:55 PM, Kelly O'Hair wrote: > Can I get a http reference to the changeset next time. > Sure. > I assume this is: > http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/8d59b361635f > Yes, it is this very changeset. > I approve. > Thanks! I have pushed it with the updated copyright headers (Oracle's instead of Sun's). Cheers, Omair > > On Mar 14, 2011, at 9:21 AM, Omair Majid wrote: > >> Hi, >> >> I would like to backport the following changeset to openjdk6: >> >> changeset: 2380:8d59b361635f >> user: alexp >> date: Tue May 25 20:39:52 2010 +0400 >> summary: 6768387: REGRESSION: JTable no longer serializable >> >> Thanks, >> Omair > From erik.trimble at oracle.com Tue Mar 15 22:40:00 2011 From: erik.trimble at oracle.com (Erik Trimble) Date: Tue, 15 Mar 2011 22:40:00 -0700 Subject: Hotspot 20 Build 11 has been promoted... Message-ID: <4D804D30.5030309@oracle.com> Build 11 of Hotspot 20 has completed PIT, and been pushed to the OpenJDK HS20 master repository. http://hg.openjdk.java.net/hsx/hsx20/master/rev/f46354849fb3 This build is intended for inclusion in Oracle JDK 6 Update 25 Build 04. --------- Component : VM Status : 0 major failures, 2 minor failures Date : 03/15/2011 at 08:53 Tested By : VM SQE andNicolay.Haustov at oracle.com Cost(total man-days): 1 Workspace : N/A Bundles : JPRT: 2011-03-10-211806.jcoomes.hs20-ci-7018056 Platforms : Others Tests :/net/sqenfs-1.sfbay/export1/comp/vm/testbase/ Browsers : NA Patches : NA Logs :http://sqeweb.us.oracle.com/nfs/results/vm/gtee/HSX/PIT/VM/hs20/b11/jdk6u25b04/ Number of Tests Executed : 272112 product tests, 0 unit tests, 0 tck tests Bug verification status: ====================================== Tested, Pass: 7018056: large pages not always enabled by default Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: Setup is not available: Build change only: 7026619: Bump the HS20 build number to 11 New bugs filed: Bugs in PIT build: 7027664: sync issue with dtonga in tmtools 7027737: nsk/regression/b4441517 and nsk/regression/b4445592 timeout on machines with big RAM with ParallelGC Bugs in earlier promoted build: Number of PIT requested: 1 Integration target J2SE build number: 6u25-b04 Issues and Notes: This is HS 20 b11 PIT for JDK 6u25 b04. ------------------------------- From VM SQE andNicolay.Haustov at oracle.com -- Erik Trimble Java System Support Mailstop: usca22-123 Phone: x17195 Santa Clara, CA -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20110315/ccd35f6e/attachment.html From kelly.ohair at oracle.com Mon Mar 21 19:49:29 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 21 Mar 2011 19:49:29 -0700 Subject: Need reviewer: readmes and make/script additions Message-ID: <4D4DCC4D-3306-45DB-9175-9E0C5CCF9D7E@oracle.com> Need reviewer for some README adjustments and additional make/scripts 6909331: Add vsvars.sh to the jdk repository (handy cygwin way to get vcvars32.bat run) 7023111: Add webrev script to make/scripts 7003845: README-builds document proper location of forest extension, provide alternatives 6896934: README: Document how the drop source bundles work for jaxp/jaxws 6896978: README: Updates to openjdk README-builds.html 6903517: README: OpenJDK additions needed - cygwin issues http://cr.openjdk.java.net/~ohair/openjdk6/jdk6-README/webrev/ -kto From kelly.ohair at oracle.com Tue Mar 22 19:28:35 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 22 Mar 2011 19:28:35 -0700 Subject: Fwd: Need reviewer: readmes and make/script additions References: <4D4DCC4D-3306-45DB-9175-9E0C5CCF9D7E@oracle.com> Message-ID: <0BFD7A52-F115-425D-A535-BAD71939190E@oracle.com> No volunteers on this review? :^( -kto Begin forwarded message: > From: "Kelly O'Hair" > Date: March 21, 2011 19:49:29 PM PDT > To: jdk6-dev > Subject: Need reviewer: readmes and make/script additions > > Need reviewer for some README adjustments and additional make/scripts > > 6909331: Add vsvars.sh to the jdk repository (handy cygwin way to get vcvars32.bat run) > 7023111: Add webrev script to make/scripts > 7003845: README-builds document proper location of forest extension, provide alternatives > 6896934: README: Document how the drop source bundles work for jaxp/jaxws > 6896978: README: Updates to openjdk README-builds.html > 6903517: README: OpenJDK additions needed - cygwin issues > > http://cr.openjdk.java.net/~ohair/openjdk6/jdk6-README/webrev/ > > -kto > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20110322/e499a8bf/attachment.html From denisl at openscg.com Tue Mar 22 20:08:00 2011 From: denisl at openscg.com (Lussier, Denis) Date: Tue, 22 Mar 2011 23:08:00 -0400 Subject: Need reviewer: readmes and make/script additions In-Reply-To: <0BFD7A52-F115-425D-A535-BAD71939190E@oracle.com> References: <4D4DCC4D-3306-45DB-9175-9E0C5CCF9D7E@oracle.com> <0BFD7A52-F115-425D-A535-BAD71939190E@oracle.com> Message-ID: I didn't check the scripts, but, I did look pretty closely at the diffs for the various README's. I can see that you added lots of useful information that certainly would have made my intro to building the OpenJDK smoother a couple years ago. --Luss http://openscg.org On Tuesday, March 22, 2011, Kelly O'Hair wrote: > > No volunteers on this review? :^( > -kto > > Begin forwarded message: > From: "Kelly O'Hair" > Date: March 21, 2011 19:49:29 PM PDT > To: jdk6-dev > Subject: Need reviewer: readmes and make/script additions > > Need reviewer for some README adjustments and additional make/scripts > > 6909331: Add vsvars.sh to the jdk repository (handy cygwin way to get vcvars32.bat run) > 7023111: Add webrev script to make/scripts > 7003845: README-builds document proper location of forest extension, provide alternatives > 6896934: README: Document how the drop source bundles work for jaxp/jaxws > 6896978: README: Updates to openjdk README-builds.html > 6903517: README: OpenJDK additions needed - cygwin issues > > http://cr.openjdk.java.net/~ohair/openjdk6/jdk6-README/webrev/ > > -kto > > > From omajid at redhat.com Wed Mar 23 12:13:49 2011 From: omajid at redhat.com (Omair Majid) Date: Wed, 23 Mar 2011 15:13:49 -0400 Subject: Request to backport 7000693: java.sql.Timestamp compareTo() issues using low values Message-ID: <4D8A466D.6010404@redhat.com> Hi, I would like to backport the following changeset to jdk6: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/befe813e24d2 changeset: 3385:befe813e24d2 user: lancea date: Tue Jan 11 12:36:43 2011 -0500 summary: 7000693: java.sql.Timestamp compareTo() issues using low values Okay to push? Cheers, Omair From joe.darcy at oracle.com Wed Mar 23 16:46:37 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 23 Mar 2011 16:46:37 -0700 Subject: Need reviewer: readmes and make/script additions In-Reply-To: <4D4DCC4D-3306-45DB-9175-9E0C5CCF9D7E@oracle.com> References: <4D4DCC4D-3306-45DB-9175-9E0C5CCF9D7E@oracle.com> Message-ID: <4D8A865D.7030305@oracle.com> Hi Kelly. Generally looks good; approved with a comment. In the Minimum build environment section of README-builds.html any known constraints on using an earlier OpenJDK 6 build as the boot JDK for a contemporary OpenJDK 6 build should also be given. -Joe On 3/21/2011 7:49 PM, Kelly O'Hair wrote: > Need reviewer for some README adjustments and additional make/scripts > > 6909331: Add vsvars.sh to the jdk repository (handy cygwin way to get vcvars32.bat run) > 7023111: Add webrev script to make/scripts > 7003845: README-builds document proper location of forest extension, provide alternatives > 6896934: README: Document how the drop source bundles work for jaxp/jaxws > 6896978: README: Updates to openjdk README-builds.html > 6903517: README: OpenJDK additions needed - cygwin issues > > http://cr.openjdk.java.net/~ohair/openjdk6/jdk6-README/webrev/ > > -kto > > From doko at ubuntu.com Thu Mar 24 06:20:57 2011 From: doko at ubuntu.com (Matthias Klose) Date: Thu, 24 Mar 2011 14:20:57 +0100 Subject: [rfc] Let the classloader search for system libraries, don't hard-code DEFAULT_LIBPATH Message-ID: <4D8B4539.6030707@ubuntu.com> Currently os_linux.cpp defines DEFAULT_LIBPATH hard-coded to "/lib:/usr/lib"; with the upcoming multiarch changes in Debian/Ubuntu, libraries will move to multiarch aware locations [1], where these libraries are not found anymore by the class loaders. In [2], a patch was proposed to have the ClassLoader make the lookup trusting dlopen() instead, and not setting the DEFAULT_LIBPATH. Is there a reason why this is not done in the first place? One thing I could imagine is that dlopen() searches locations like /usr/local/lib too, which it doesn't want. Matthias [1] http://wiki.debian.org/Multiarch [2] https://bugs.launchpad.net/ubuntu/+source/openjdk-6/+bug/737603/comments/7 the proposed patch (without the changes to DEFAULT_LIBPATH): Description: fall back to the built-in system library path If a native library that's been requested can't be found in any of the known paths, fall back to looking it up without a path - i.e., trust dlopen() to do the right thing. This addresses the problem with failing to load libraries when using multiarch. Author: Steve Langasek Bug-Ubuntu: https://bugs.launchpad.net/bugs/737603 Index: openjdk/jdk/src/share/classes/java/lang/ClassLoader.java =================================================================== --- openjdk.orig/jdk/src/share/classes/java/lang/ClassLoader.java +++ openjdk/jdk/src/share/classes/java/lang/ClassLoader.java @@ -1676,6 +1676,10 @@ return; } } + File libfile = new File(System.mapLibraryName(name)); + if (loadLibrary0(fromClass, libfile)) { + return; + } } // Oops, it failed throw new UnsatisfiedLinkError("no " + name + " in java.library.path"); From Alan.Bateman at oracle.com Thu Mar 24 07:09:17 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 24 Mar 2011 14:09:17 +0000 Subject: [rfc] Let the classloader search for system libraries, don't hard-code DEFAULT_LIBPATH In-Reply-To: <4D8B4539.6030707@ubuntu.com> References: <4D8B4539.6030707@ubuntu.com> Message-ID: <4D8B508D.9090803@oracle.com> Matthias Klose wrote: > Currently os_linux.cpp defines DEFAULT_LIBPATH hard-coded to "/lib:/usr/lib"; > with the upcoming multiarch changes in Debian/Ubuntu, libraries will move to > multiarch aware locations [1], where these libraries are not found anymore by > the class loaders. > So is the issue that java.library.path isn't going to be set correctly when libraries are migrated to this new layout? Just wondering if the setup of the search path (in os::init_system_properties_values would be better place to do consider this). A concern with changing System.loadLibrary is that it has a wider impact. -Alan. From doko at ubuntu.com Thu Mar 24 07:18:11 2011 From: doko at ubuntu.com (Matthias Klose) Date: Thu, 24 Mar 2011 15:18:11 +0100 Subject: [rfc] Let the classloader search for system libraries, don't hard-code DEFAULT_LIBPATH In-Reply-To: <4D8B508D.9090803@oracle.com> References: <4D8B4539.6030707@ubuntu.com> <4D8B508D.9090803@oracle.com> Message-ID: <4D8B52A3.5050408@ubuntu.com> On 24.03.2011 15:09, Alan Bateman wrote: > Matthias Klose wrote: >> Currently os_linux.cpp defines DEFAULT_LIBPATH hard-coded to "/lib:/usr/lib"; >> with the upcoming multiarch changes in Debian/Ubuntu, libraries will move to >> multiarch aware locations [1], where these libraries are not found anymore by >> the class loaders. >> > So is the issue that java.library.path isn't going to be set correctly when > libraries are migrated to this new layout? Yes. > Just wondering if the setup of the > search path (in os::init_system_properties_values would be better place to do > consider this). DEFAULT_LIBPATH is only used in os::init_system_properties_values. > A concern with changing System.loadLibrary is that it has a > wider impact. ok, thanks. Matthias From kelly.ohair at oracle.com Thu Mar 24 07:40:14 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 24 Mar 2011 07:40:14 -0700 Subject: Need reviewer: readmes and make/script additions In-Reply-To: <4D8A865D.7030305@oracle.com> References: <4D4DCC4D-3306-45DB-9175-9E0C5CCF9D7E@oracle.com> <4D8A865D.7030305@oracle.com> Message-ID: On Mar 23, 2011, at 4:46 PM, joe.darcy at oracle.com wrote: > Hi Kelly. > > Generally looks good; approved with a comment. In the Minimum build environment section of > > README-builds.html > > any known constraints on using an earlier OpenJDK 6 build as the boot JDK for a contemporary OpenJDK 6 build should also be given. A good idea, but I'm not sure I have that data, may take some time to unearth it. -kto > > -Joe > > > On 3/21/2011 7:49 PM, Kelly O'Hair wrote: >> Need reviewer for some README adjustments and additional make/scripts >> >> 6909331: Add vsvars.sh to the jdk repository (handy cygwin way to get vcvars32.bat run) >> 7023111: Add webrev script to make/scripts >> 7003845: README-builds document proper location of forest extension, provide alternatives >> 6896934: README: Document how the drop source bundles work for jaxp/jaxws >> 6896978: README: Updates to openjdk README-builds.html >> 6903517: README: OpenJDK additions needed - cygwin issues >> >> http://cr.openjdk.java.net/~ohair/openjdk6/jdk6-README/webrev/ >> >> -kto >> >> From Alan.Bateman at oracle.com Thu Mar 24 07:41:05 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 24 Mar 2011 14:41:05 +0000 Subject: [rfc] Let the classloader search for system libraries, don't hard-code DEFAULT_LIBPATH In-Reply-To: <4D8B52A3.5050408@ubuntu.com> References: <4D8B4539.6030707@ubuntu.com> <4D8B508D.9090803@oracle.com> <4D8B52A3.5050408@ubuntu.com> Message-ID: <4D8B5801.8080001@oracle.com> Matthias Klose wrote: > : > >> Just wondering if the setup of the >> search path (in os::init_system_properties_values would be better place to do >> consider this). >> > > DEFAULT_LIBPATH is only used in os::init_system_properties_values. > > Right, but it's where the search path is setup and the result becomes the value of java.library.path. I might not understand multiarch yet but wouldn't this be the place to include the x86_64 or i386 directories to be searched? -Alan. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20110324/06f91eae/attachment.html From aph at redhat.com Thu Mar 24 07:43:49 2011 From: aph at redhat.com (Andrew Haley) Date: Thu, 24 Mar 2011 14:43:49 +0000 Subject: [rfc] Let the classloader search for system libraries, don't hard-code DEFAULT_LIBPATH In-Reply-To: <4D8B52A3.5050408@ubuntu.com> References: <4D8B4539.6030707@ubuntu.com> <4D8B508D.9090803@oracle.com> <4D8B52A3.5050408@ubuntu.com> Message-ID: <4D8B58A5.50808@redhat.com> On 03/24/2011 02:18 PM, Matthias Klose wrote: > On 24.03.2011 15:09, Alan Bateman wrote: >> Matthias Klose wrote: >>> Currently os_linux.cpp defines DEFAULT_LIBPATH hard-coded to "/lib:/usr/lib"; >>> with the upcoming multiarch changes in Debian/Ubuntu, libraries will move to >>> multiarch aware locations [1], where these libraries are not found anymore by >>> the class loaders. >>> >> So is the issue that java.library.path isn't going to be set correctly when >> libraries are migrated to this new layout? > > Yes. > >> Just wondering if the setup of the >> search path (in os::init_system_properties_values would be better place to do >> consider this). > > DEFAULT_LIBPATH is only used in os::init_system_properties_values. I'm trying to understand the problem. Is it that the path to libraries is not fixed for a particular libjvm.so ? I can't quite understand how this would be: surely if libjvm.so is built for ARM hard-FP then the libraries to search will be "/lib/arm-hardfp:/usr/lib/arm-hardfp" . Or does the library path need to be dynamic? Andrew. From doko at ubuntu.com Thu Mar 24 07:51:29 2011 From: doko at ubuntu.com (Matthias Klose) Date: Thu, 24 Mar 2011 15:51:29 +0100 Subject: [rfc] Let the classloader search for system libraries, don't hard-code DEFAULT_LIBPATH In-Reply-To: <4D8B5801.8080001@oracle.com> References: <4D8B4539.6030707@ubuntu.com> <4D8B508D.9090803@oracle.com> <4D8B52A3.5050408@ubuntu.com> <4D8B5801.8080001@oracle.com> Message-ID: <4D8B5A71.6070209@ubuntu.com> On 24.03.2011 15:41, Alan Bateman wrote: > Matthias Klose wrote: >> : >> >>> Just wondering if the setup of the >>> search path (in os::init_system_properties_values would be better place to do >>> consider this). >>> >> >> DEFAULT_LIBPATH is only used in os::init_system_properties_values. >> >> > Right, but it's where the search path is setup and the result becomes the value > of java.library.path. I might not understand multiarch yet but wouldn't this be > the place to include the x86_64 or i386 directories to be searched? yes, if your goal is to limit the scope of this change. Here is what I'm currently testing (note that /usr/lib/jni is unrelated, required by Debian's Java Policy). Matthias -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: deb-multiarch-hs20.diff Url: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20110324/497be9ef/attachment-0001.ksh From doko at ubuntu.com Thu Mar 24 07:53:25 2011 From: doko at ubuntu.com (Matthias Klose) Date: Thu, 24 Mar 2011 15:53:25 +0100 Subject: [rfc] Let the classloader search for system libraries, don't hard-code DEFAULT_LIBPATH In-Reply-To: <4D8B58A5.50808@redhat.com> References: <4D8B4539.6030707@ubuntu.com> <4D8B508D.9090803@oracle.com> <4D8B52A3.5050408@ubuntu.com> <4D8B58A5.50808@redhat.com> Message-ID: <4D8B5AE5.60503@ubuntu.com> On 24.03.2011 15:43, Andrew Haley wrote: > On 03/24/2011 02:18 PM, Matthias Klose wrote: >> On 24.03.2011 15:09, Alan Bateman wrote: >>> Matthias Klose wrote: >>>> Currently os_linux.cpp defines DEFAULT_LIBPATH hard-coded to "/lib:/usr/lib"; >>>> with the upcoming multiarch changes in Debian/Ubuntu, libraries will move to >>>> multiarch aware locations [1], where these libraries are not found anymore by >>>> the class loaders. >>>> >>> So is the issue that java.library.path isn't going to be set correctly when >>> libraries are migrated to this new layout? >> >> Yes. >> >>> Just wondering if the setup of the >>> search path (in os::init_system_properties_values would be better place to do >>> consider this). >> >> DEFAULT_LIBPATH is only used in os::init_system_properties_values. > > I'm trying to understand the problem. Is it that the path to libraries is > not fixed for a particular libjvm.so ? I can't quite understand how this > would be: surely if libjvm.so is built for ARM hard-FP then the libraries to > search will be "/lib/arm-hardfp:/usr/lib/arm-hardfp" . Or does the library > path need to be dynamic? No, afaics it doesn't have to be dynamic. From kelly.ohair at oracle.com Thu Mar 24 07:54:26 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Thu, 24 Mar 2011 14:54:26 +0000 Subject: hg: jdk6/jdk6: 3 new changesets Message-ID: <20110324145427.07A9E47424@hg.openjdk.java.net> Changeset: 522aa6575ddd Author: ohair Date: 2011-03-24 07:42 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/rev/522aa6575ddd 7023111: Add webrev script to make/scripts Reviewed-by: darcy + make/scripts/webrev.ksh Changeset: 2a1d64e9772e Author: ohair Date: 2011-03-24 07:42 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/rev/2a1d64e9772e 6909331: Add vsvars.sh to the jdk repository (handy cygwin way to get vcvars32.bat run) Reviewed-by: darcy + make/scripts/vsvars.sh Changeset: f30a5896c305 Author: ohair Date: 2011-03-24 07:46 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/rev/f30a5896c305 6896934: README: Document how the drop source bundles work for jaxp/jaxws 6896978: README: Updates to openjdk README-builds.html 6903517: README: OpenJDK additions needed - cygwin issues 6903631: README: Build information on Redhat 3.0 builds 7003845: README-builds document proper location of forest extension, provide alternatives Reviewed-by: darcy ! README ! README-builds.html + get_source.sh + make/scripts/hgforest.sh From Kelly.Ohair at Oracle.Com Thu Mar 24 20:46:32 2011 From: Kelly.Ohair at Oracle.Com (Kelly O'Hair) Date: Thu, 24 Mar 2011 20:46:32 -0700 Subject: I propose to backport four langtools bug fixes from JDK 7 to OpenJDK 6 In-Reply-To: <4D8BEC16.9020403@oracle.com> References: <4D8BEC16.9020403@oracle.com> Message-ID: <8833C5FC-3D42-44A9-BEEF-1F1A3EC52A72@Oracle.Com> Approved. -kto On Mar 24, 2011, at 6:12 PM, Jim Holmlund wrote: > The webrevs are > > http://cr.openjdk.java.net/~jjh/6502392-openJDK6/ > http://cr.openjdk.java.net/~jjh/7003006-openJDK6/ > http://cr.openjdk.java.net/~jjh/6999460-openJDK6/ > http://cr.openjdk.java.net/~jjh/6999891-openJDK6/ > > The fix for 6999420 has already been approved- this is the bug about building Glassfish being very slow on Windows. > > The other three fixes are basically to the same file, JavacFileManager.java, and were 'easy' to backport. > I request that you approve them. > > Thanks. > - jjh > From james.holmlund at oracle.com Thu Mar 24 18:12:54 2011 From: james.holmlund at oracle.com (Jim Holmlund) Date: Thu, 24 Mar 2011 18:12:54 -0700 Subject: I propose to backport four langtools bug fixes from JDK 7 to OpenJDK 6 Message-ID: <4D8BEC16.9020403@oracle.com> The webrevs are http://cr.openjdk.java.net/~jjh/6502392-openJDK6/ http://cr.openjdk.java.net/~jjh/7003006-openJDK6/ http://cr.openjdk.java.net/~jjh/6999460-openJDK6/ http://cr.openjdk.java.net/~jjh/6999891-openJDK6/ The fix for 6999420 has already been approved- this is the bug about building Glassfish being very slow on Windows. The other three fixes are basically to the same file, JavacFileManager.java, and were 'easy' to backport. I request that you approve them. Thanks. - jjh From jim.holmlund at sun.com Sun Mar 27 09:33:42 2011 From: jim.holmlund at sun.com (jim.holmlund at sun.com) Date: Sun, 27 Mar 2011 16:33:42 +0000 Subject: hg: jdk6/jdk6/langtools: 4 new changesets Message-ID: <20110327163347.87AB347502@hg.openjdk.java.net> Changeset: f9cffe4fc4c6 Author: jjh Date: 2011-03-27 09:31 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/langtools/rev/f9cffe4fc4c6 6502392: Invalid relative names for Filer.createResource and Filer.getResource Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java + test/tools/javac/processing/filer/TestInvalidRelativeNames.java Changeset: e5b59e1e2b1e Author: jjh Date: 2011-03-27 09:31 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/langtools/rev/e5b59e1e2b1e 7003006: add option to list directory in deterministic order Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java Changeset: 8eb53e0c5dc9 Author: jjh Date: 2011-03-27 09:31 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/langtools/rev/8eb53e0c5dc9 6999460: Glassfish build with JDK 6 / 7 is 5x-10x slower on Windows than on Linux Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/Paths.java Changeset: f8c147836597 Author: jjh Date: 2011-03-27 09:31 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/langtools/rev/f8c147836597 6999891: DefaultFileManager incorrect Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java + test/tools/javac/lib/JavacTestingAbstractProcessor.java + test/tools/javac/processing/filer/TestValidRelativeNames.java From kelly.ohair at oracle.com Mon Mar 28 15:56:00 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 28 Mar 2011 15:56:00 -0700 Subject: Need reviewer: jaxp JCK Message-ID: 6989150: JCK7: 3 deserialization tests for javax.xml classes fail since JDK7-b112 http://cr.openjdk.java.net/~ohair/openjdk6/jdk6-jaxp-6989150/webrev/ New jaxp source drop bundle from: http://download.java.net/jaxp/openjdk/jdk6/jaxp144_02.zip See http://bugs.sun.com/view_bug.do?bug_id=6989150 -kto -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20110328/d038786e/attachment.html From joe.darcy at oracle.com Mon Mar 28 16:04:06 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Mon, 28 Mar 2011 16:04:06 -0700 Subject: Need reviewer: jaxp JCK In-Reply-To: References: Message-ID: <4D9113E6.1040502@oracle.com> Looks good; approved. -Joe Kelly O'Hair wrote: > > 6989150: JCK7: 3 deserialization tests for javax.xml classes fail > since JDK7-b112 > http://cr.openjdk.java.net/~ohair/openjdk6/jdk6-jaxp-6989150/webrev/ > > > New jaxp source drop bundle > from: http://download.java.net/jaxp/openjdk/jdk6/jaxp144_02.zip > > See http://bugs.sun.com/view_bug.do?bug_id=6989150 > > -kto > From kelly.ohair at oracle.com Tue Mar 29 10:16:29 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 29 Mar 2011 10:16:29 -0700 Subject: Running jdk tests Message-ID: <7AEFB15C-BB22-4BAC-ACDE-CECAC0CB3FA4@oracle.com> Running openjdk6 jdk regression tests, e.g. cd root && make && make test Getting some testcase failures. Haven't run tests on openjdk6 for a long time. Do any of these look at all familiar? jdk_lang failures: java/lang/management/MemoryMXBean/CollectionUsageThresholdConcMarkSweepGC.sh Error. Program `sh' interrupted! (timed out?) jdk_net failures: com/sun/net/httpserver/bugs/B6373555.java Failed. Execution failed: `main' threw exception: java.lang.InterruptedException java/net/CookieHandler/TestHttpCookie.java Failed. Execution failed: `main' threw exception: java.lang.AssertionError java/net/InetAddress/GetLocalHostWithSM.java Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: InetAddress.getLocalHost() test fails. localHost2 should be the real address instead of the loopback address.svc6/10.133.160.164 jdk_nio failures: java/nio/channels/Selector/ConnectWrite.java Failed. Execution failed: `main' threw exception: java.net.ConnectException: Connection refused jdk_security3 failures: sun/security/pkcs11/ec/ReadCertificates.java Failed. Execution failed: `main' threw exception: java.security.SignatureException: Signature does not match. sun/security/pkcs11/ec/ReadPKCS12.java Failed. Execution failed: `main' threw exception: java.lang.Exception: Signature does not verify sun/security/pkcs11/ec/TestCurves.java Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Could not parse key values sun/security/pkcs11/ec/TestECDSA.java Failed. Execution failed: `main' threw exception: java.lang.Exception: Result mismatch, actual: false sun/security/pkcs11/ec/TestECGenSpec.java Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Could not parse key values sun/security/pkcs11/ec/TestKeyFactory.java Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Could not parse key values sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnection/CriticalSubjectAltName.java Failed. Execution failed: `main' threw exception: java.net.SocketException: java.security.NoSuchAlgorithmException: Error constructing implementation (algorithm: Default, provider: SunJSSE, class: sun.security.ssl.DefaultSSLContextImpl) sun/security/validator/CertReplace.java Failed. Execution failed: `main' threw exception: sun.security.validator.ValidatorException: PKIX path validation failed: java.security.cert.CertPathValidatorException: timestamp check failed jdk_util: java/util/ResourceBundle/Test4300693.java Failed. Execution failed: `main' threw exception: java.lang.AssertionError -kto From joe.darcy at oracle.com Tue Mar 29 10:43:46 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Tue, 29 Mar 2011 10:43:46 -0700 Subject: Running jdk tests In-Reply-To: <7AEFB15C-BB22-4BAC-ACDE-CECAC0CB3FA4@oracle.com> References: <7AEFB15C-BB22-4BAC-ACDE-CECAC0CB3FA4@oracle.com> Message-ID: <4D921A52.7030506@oracle.com> Hi Kelly. I didn't run the tests quite that way [1], but I published the results I did get on my blog; e.g. for build 22 http://blogs.sun.com/darcy/resource/OpenJDK_6/b22-jdk-linux-summary.txt Extracting the failures I saw on b22 on the jdk repo's tests: com/sun/net/httpserver/bugs/B6361557.java com/sun/org/apache/xml/internal/ws/server/Test.jav java/awt/Graphics2D/DrawString/RotTransText.java java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.html java/awt/Window/GrabSequence/GrabSequence.java java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html java/awt/event/HierarchyEvent/AncestorResized/AncestorResized.java java/awt/font/Rotate/TranslatedOutlineTest.java java/awt/print/PrinterJob/ExceptionTest.java java/beans/XMLEncoder/javax_swing_tree_TreePath.java java/net/Authenticator/B4769350.java java/net/CookieHandler/TestHttpCookie.java java/net/InetAddress/IPv4Formats.java java/net/URL/OpenStream.java java/net/URLClassLoader/ClassLoad.java java/net/ipv6tests/TcpTest.java java/nio/channels/SocketChannel/AdaptSocket.java java/nio/channels/SocketChannel/LocalAddress.java java/nio/channels/SocketChannel/Shutdown.java java/nio/charset/Charset/NIOCharsetAvailabilityTest.java java/rmi/activation/ActivateFailedException/activateFails/ActivateFails.java java/util/Locale/Bug4184873Test.java java/util/ResourceBundle/Test4300693.java javax/management/remote/mandatory/connection/CloseFailedClientTest.java javax/management/remote/mandatory/connection/FailedConnectionTest.java javax/print/attribute/PSCopiesFlavorTest.java sun/java2d/cmm/ColorConvertOp/ColConvCCMTest.java sun/java2d/cmm/ColorConvertOp/ColConvDCMTest.java sun/java2d/cmm/ColorConvertOp/MTColConvTest.java sun/nio/cs/TestSJIS0213.java sun/rmi/transport/proxy/EagerHttpFallback.java sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnection/CriticalSubjectAltName.java sun/security/validator/CertReplace.java There is overlap between these failures and yours, but you seem to be seeing some new ones. -Joe [1] http://blogs.sun.com/darcy/entry/openjdk_6_b22_regression_test On 3/29/2011 10:16 AM, Kelly O'Hair wrote: > Running openjdk6 jdk regression tests, e.g. cd root&& make&& make test > > Getting some testcase failures. Haven't run tests on openjdk6 for a long time. > > Do any of these look at all familiar? > > jdk_lang failures: > > java/lang/management/MemoryMXBean/CollectionUsageThresholdConcMarkSweepGC.sh Error. Program `sh' interrupted! (timed out?) > > jdk_net failures: > > com/sun/net/httpserver/bugs/B6373555.java Failed. Execution failed: `main' threw exception: java.lang.InterruptedException > java/net/CookieHandler/TestHttpCookie.java Failed. Execution failed: `main' threw exception: java.lang.AssertionError > java/net/InetAddress/GetLocalHostWithSM.java Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: InetAddress.getLocalHost() test fails. localHost2 should be the real address instead of the loopback address.svc6/10.133.160.164 > > jdk_nio failures: > > java/nio/channels/Selector/ConnectWrite.java Failed. Execution failed: `main' threw exception: java.net.ConnectException: Connection refused > > jdk_security3 failures: > > sun/security/pkcs11/ec/ReadCertificates.java Failed. Execution failed: `main' threw exception: java.security.SignatureException: Signature does not match. > sun/security/pkcs11/ec/ReadPKCS12.java Failed. Execution failed: `main' threw exception: java.lang.Exception: Signature does not verify > sun/security/pkcs11/ec/TestCurves.java Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Could not parse key values > sun/security/pkcs11/ec/TestECDSA.java Failed. Execution failed: `main' threw exception: java.lang.Exception: Result mismatch, actual: false > sun/security/pkcs11/ec/TestECGenSpec.java Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Could not parse key values > sun/security/pkcs11/ec/TestKeyFactory.java Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Could not parse key values > sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnection/CriticalSubjectAltName.java Failed. Execution failed: `main' threw exception: java.net.SocketException: java.security.NoSuchAlgorithmException: Error constructing implementation (algorithm: Default, provider: SunJSSE, class: sun.security.ssl.DefaultSSLContextImpl) > sun/security/validator/CertReplace.java Failed. Execution failed: `main' threw exception: sun.security.validator.ValidatorException: PKIX path validation failed: java.security.cert.CertPathValidatorException: timestamp check failed > > jdk_util: > > java/util/ResourceBundle/Test4300693.java Failed. Execution failed: `main' threw exception: java.lang.AssertionError > > -kto > From mark at klomp.org Tue Mar 29 10:59:28 2011 From: mark at klomp.org (Mark Wielaard) Date: Tue, 29 Mar 2011 19:59:28 +0200 (CEST) Subject: Running jdk tests In-Reply-To: <7AEFB15C-BB22-4BAC-ACDE-CECAC0CB3FA4@oracle.com> References: <7AEFB15C-BB22-4BAC-ACDE-CECAC0CB3FA4@oracle.com> Message-ID: <43756.80.101.103.228.1301421568.squirrel@gnu.wildebeest.org> On Tue, March 29, 2011 19:16, Kelly O'Hair wrote: > > Running openjdk6 jdk regression tests, e.g. cd root && make && make > test > > Getting some testcase failures. Haven't run tests on openjdk6 for a long > time. > > Do any of these look at all familiar? Not completely the same, since they are based on the icedtea6 infrastructure, which comes with its own jtreg invocation (just click on the build to see the full configure logs), but the buildbot has some results (not all build slaves run the full jdk tests though - those marked -quick don't, you want one marked -full): http://builder.classpath.org/icedtea/buildbot/waterfall There is also a full jdk jtreg report for the latest icedtea6 build (debian lenny x86_64) here (regenerated every couple of hours after a new check-in): http://builder.classpath.org/icedtea/icedtea6/test/jdk/JTreport/html/ That one includes links to .jtr report files, which are sometimes handy. Cheers, Mark From kelly.ohair at oracle.com Tue Mar 29 16:50:37 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 29 Mar 2011 16:50:37 -0700 Subject: Running jdk tests In-Reply-To: <43756.80.101.103.228.1301421568.squirrel@gnu.wildebeest.org> References: <7AEFB15C-BB22-4BAC-ACDE-CECAC0CB3FA4@oracle.com> <43756.80.101.103.228.1301421568.squirrel@gnu.wildebeest.org> Message-ID: Need a reviewer on this. I'll push these changes with the jaxp update. I went through my failures, found current CRs on them failing, or filed CRs, then updated the problem list and made sure 'make && make test' works cleanly. 7032311: Correct top level 'make test' target and add known failures to problem list http://cr.openjdk.java.net/~ohair/openjdk6/jdk6-fix-testing/webrev/ The 'make test' now gives me: ################################################# TEST STATS: name=jdk_beans1 run=30 pass=30 fail=0 excluded=17 TEST STATS: name=jdk_beans2 run=83 pass=83 fail=0 excluded=3 TEST STATS: name=jdk_beans3 run=119 pass=119 fail=0 excluded=1 TEST STATS: name=jdk_io run=238 pass=238 fail=0 excluded=93 TEST STATS: name=jdk_lang run=259 pass=259 fail=0 excluded=49 TEST STATS: name=jdk_management1 run=143 pass=143 fail=0 excluded=49 TEST STATS: name=jdk_management2 run=29 pass=29 fail=0 excluded=8 TEST STATS: name=jdk_math run=23 pass=23 fail=0 excluded=2 TEST STATS: name=jdk_misc run=330 pass=330 fail=0 excluded=14 TEST STATS: name=jdk_net run=228 pass=228 fail=0 excluded=85 TEST STATS: name=jdk_nio run=187 pass=187 fail=0 excluded=33 TEST STATS: name=jdk_security1 run=78 pass=78 fail=0 excluded=14 TEST STATS: name=jdk_security2 run=88 pass=88 fail=0 excluded=4 TEST STATS: name=jdk_security3 run=290 pass=290 fail=0 excluded=29 TEST STATS: name=jdk_text run=6 pass=6 fail=0 excluded=0 TEST STATS: name=jdk_tools1 run=135 pass=135 fail=0 excluded=0 TEST STATS: name=jdk_tools2 run=64 pass=64 fail=0 excluded=23 TEST STATS: name=jdk_util run=286 pass=286 fail=0 excluded=25 ################################################# -kto From joe.darcy at oracle.com Tue Mar 29 16:58:01 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 29 Mar 2011 16:58:01 -0700 Subject: Running jdk tests In-Reply-To: References: <7AEFB15C-BB22-4BAC-ACDE-CECAC0CB3FA4@oracle.com> <43756.80.101.103.228.1301421568.squirrel@gnu.wildebeest.org> Message-ID: <4D927209.6050408@oracle.com> Looks good; approved. -Joe On 3/29/2011 4:50 PM, Kelly O'Hair wrote: > Need a reviewer on this. I'll push these changes with the jaxp update. > > I went through my failures, found current CRs on them failing, or filed CRs, > then updated the problem list and made sure 'make && make test' works cleanly. > > 7032311: Correct top level 'make test' target and add known failures to problem list > http://cr.openjdk.java.net/~ohair/openjdk6/jdk6-fix-testing/webrev/ > > The 'make test' now gives me: > > ################################################# > TEST STATS: name=jdk_beans1 run=30 pass=30 fail=0 excluded=17 > TEST STATS: name=jdk_beans2 run=83 pass=83 fail=0 excluded=3 > TEST STATS: name=jdk_beans3 run=119 pass=119 fail=0 excluded=1 > TEST STATS: name=jdk_io run=238 pass=238 fail=0 excluded=93 > TEST STATS: name=jdk_lang run=259 pass=259 fail=0 excluded=49 > TEST STATS: name=jdk_management1 run=143 pass=143 fail=0 excluded=49 > TEST STATS: name=jdk_management2 run=29 pass=29 fail=0 excluded=8 > TEST STATS: name=jdk_math run=23 pass=23 fail=0 excluded=2 > TEST STATS: name=jdk_misc run=330 pass=330 fail=0 excluded=14 > TEST STATS: name=jdk_net run=228 pass=228 fail=0 excluded=85 > TEST STATS: name=jdk_nio run=187 pass=187 fail=0 excluded=33 > TEST STATS: name=jdk_security1 run=78 pass=78 fail=0 excluded=14 > TEST STATS: name=jdk_security2 run=88 pass=88 fail=0 excluded=4 > TEST STATS: name=jdk_security3 run=290 pass=290 fail=0 excluded=29 > TEST STATS: name=jdk_text run=6 pass=6 fail=0 excluded=0 > TEST STATS: name=jdk_tools1 run=135 pass=135 fail=0 excluded=0 > TEST STATS: name=jdk_tools2 run=64 pass=64 fail=0 excluded=23 > TEST STATS: name=jdk_util run=286 pass=286 fail=0 excluded=25 > ################################################# > > -kto From kelly.ohair at oracle.com Tue Mar 29 17:19:50 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Wed, 30 Mar 2011 00:19:50 +0000 Subject: hg: jdk6/jdk6: 7032311: Correct top level 'make test' target and add known failures to problem list Message-ID: <20110330001950.37FD3475A0@hg.openjdk.java.net> Changeset: 68fddc52a231 Author: ohair Date: 2011-03-29 17:17 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/rev/68fddc52a231 7032311: Correct top level 'make test' target and add known failures to problem list Reviewed-by: darcy ! Makefile ! test/Makefile From kelly.ohair at oracle.com Tue Mar 29 17:20:18 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Wed, 30 Mar 2011 00:20:18 +0000 Subject: hg: jdk6/jdk6/jaxp: 6989150: JCK7: 3 deserialization tests for javax.xml classes fail since JDK7-b112 Message-ID: <20110330002018.A940F475A2@hg.openjdk.java.net> Changeset: 38e5e5b9561c Author: ohair Date: 2011-03-28 17:27 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/jaxp/rev/38e5e5b9561c 6989150: JCK7: 3 deserialization tests for javax.xml classes fail since JDK7-b112 Summary: New jaxp drop http://download.java.net/jaxp/openjdk/jdk6/jaxp144_02.zip Reviewed-by: darcy ! jaxp.properties From kelly.ohair at oracle.com Tue Mar 29 17:20:36 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Wed, 30 Mar 2011 00:20:36 +0000 Subject: hg: jdk6/jdk6/jdk: 7032311: Correct top level 'make test' target and add known failures to problem list Message-ID: <20110330002107.2318D475A4@hg.openjdk.java.net> Changeset: ba66ade54c26 Author: ohair Date: 2011-03-29 17:18 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/ba66ade54c26 7032311: Correct top level 'make test' target and add known failures to problem list Reviewed-by: darcy ! test/Makefile ! test/ProblemList.txt From ahughes at redhat.com Wed Mar 30 14:04:32 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Wed, 30 Mar 2011 22:04:32 +0100 Subject: b23 Message-ID: <20110330210432.GF6143@rivendell.middle-earth.co.uk> Hi all, I guess it's about time we started talking about b23. Here's a list of stuff I'd like to get in: * Top priority: hs20 from the stable branch * Possible javadoc regression in langtools (present in 7 and b21+); looking into this now. I presume it is called by that bloated file manager backport: http://hg.openjdk.java.net/jdk6/jdk6/langtools/rev/5c2858bccb3f The tool tries to read class files as source files when -classpath and -subpackages are specified. * Accompanying Shark build fix for hs20 already approved by Kelly for 7 (http://mail.openjdk.java.net/pipermail/build-dev/2011-March/004369.html) * Shark regression caused by security fix 6878713 (no. 2 on http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2011-March/005032.html) * Removal of Motif requirement. This helps with some of the changesets below which will otherwise have to have dummy implementations for some Motif methods. Alternatively, you could open the implementations of these methods that are in the proprietary JDK6 tree, assuming that still has Motif. IcedTea has ripped out Motif since the beginning. * The following JDK changes. Some may have gone in and I haven't noticed; the list is drawn from the 1.10 and HEAD NEWS backport lists in IcedTea. - S7023591, S7027667: Clipped antialiased rectangles are filled, not drawn. - S7019861: Last scanline skpped when doing AA. - S6768387, PR670: REGRESSION: JTable no longer serializable - Add missing privileged block around access to the sun.awt.nativedebug property. - S6800846, RH662230: Printing quality degraded with Java 6 compared to 5.0, index out of bounds exception. - S6642612: JFileChooser's approve buttons should be the same size (GTK) - S6984543: Test sun/java2d/DirectX/OnScreenRenderingResizeTest fails on GNOME - S6997495: correction of regression test compiler/6857159/Test6857159 - S6736649: test/closed/javax/swing/JMenuItem/6458123/ManualBug6458123.java fails on Linux - S6797139: JButton title is truncating for some strings irrespective of preferred size. - S6883341: SWAT: jdk7-b72 swat build(2009-09-17) threw exceptions when running Java2D demo by clicking Paint ta - S4493128: CubicCurve2D intersects method fails - S4724552: CubicCurve2D.contains(Rectangle2D) returns true when partially contained. - S4645692: CubicCurve2D.solveCubic does not return all solutions. - S4993545: NativeInLightFixer adds asynchronousity - S6637796: setBounds doesn't enlarge Component - S6607660: java.awt.Container.getMouseEventTargetImpl should be invoked while holding the TreeLock - S6607170: Focus not set by requestFocus - S6616323: consider benefits of replacing a component array with other collection from the awt.Container class - S6682046: Mixing code does not always recalculate shapes correctly when resizing components - S6797195: Forward-port enhancements for hw/lw mixing from 6u12 to 7 - S6725214: D3D: forward-port the new pipeline from 6u10 - S6633275: Need to support shaped/translucent windows - S7015232: missing copyright header in CheckZOrderChange.java - S7017581: missing copyright header in test/sun/java2d/pipe/RegionOps.java - S6896068: SunGraphics2D exposes a reference to itself while non fully initialised. - S6749060: LCD AA text rendered incorrectly when destination is non opaque (sw pipeline only) - S6728834: D3D/OGL: LCD AA text becomes bold and blurred when rendering to a non-opaque destination - S6693253: Security Warning appearance requires enhancements - S6779717: A Window does not show applet security warning icon on X platforms - S6785058: Parent don't get the focus after dialog is closed if security warning is applied - S6444769: java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.html fails - S6775317: Improve performance of non-AA transformed rectangles and single wide lines in software pipelines - S6766342: Improve performance of Ductus rasterizer - S7016856: fix dashing performance regression. Improve other rendering performance. - S6934977: MappedByteBuffer.load crashes with SIGBUS. Thoughts? -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: F5862A37 (https://keys.indymedia.org/) Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37