java2d/pipe/Region.java equals, hix vs hiy - Re: starting OpenJDK6 B25 promotion process
lana.steuck at oracle.com
Wed Apr 18 16:13:17 PDT 2012
I checked the latest OpenJdk6 source code (the hg jdk repo):
Looks like that the fix have not yet been applied.
r.hiy != this.hiy || r.hiy != this.hiy
still have the problem, both of the expressions are still the same.
> I failed to browse b25 candidate source codes
I wonder what happened, were you browsing
By the way, below is the page containing the most important OpenJdk6
links (links to hg repos, etc.):
On 04/18/2012 02:40 AM, leo.hippelainen at wippies.com wrote:
> Just wondering if the coding bug pointed out by below mailing list
> entry will be fixed in b25 release.
> I failed to browse b25 candidate source codes so that I could check if
> the obvious fix has already been included there.
> BR, Leo H.
> - - - - -
> Message: 2
> Date: Sun, 25 Mar 2012 10:36:36 -0700
> From: Phil Race <philip.race at oracle.com>
> Subject: Re: java2d/pipe/Region.java equals, hix vs hiy
> To: jdk6-dev at openjdk.java.net
> Message-ID: <4F6F57A4.8080601 at oracle.com>
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
> I think the bug was originally introduced in 6u10 for
> 6633275: Need to support shaped/translucent windows
> It was later fixed in 6u12 as
> 6777320: PIT : Canvas is not fully painted on the internal frame &
> internal frame
> All this was forwarded ported to 7.
> Offhand I'm not sure how the former work made it into 6open but not the
> bug fix, as 6-open split off from JDK 7 around 7 b23.
> On 3/25/12 3:30 AM, leo.hippelainen at wippies.com wrote:
> While comparing source modules between JDKs we noticed that in
> OpenJDK6 module jdk/src/share/classes/sun/java2d/pipe/Region.java,
> line 1209 contains:
> r.hiy != this.hiy || r.hiy != this.hiy
> Should it rather read like this:
> r.hix != this.hix || r.hiy != this.hiy
> I found out that this modification has been done to OpenJDK7 three
> years ago: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/f36e9200cb85
> My copy of the OpenJDK6 sources are extracted from
> Best regards,
> Leo H. (&Sampo)
More information about the jdk6-dev