From weijun.wang at oracle.com Fri Mar 2 02:07:52 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Fri, 02 Mar 2012 10:07:52 +0000 Subject: hg: jdk6/jdk6/jdk: 7149751: another krb5 test in openjdk6 without test infrastructure Message-ID: <20120302100808.9F83047789@hg.openjdk.java.net> Changeset: 7e03e302bd8a Author: weijun Date: 2012-03-02 18:06 +0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/7e03e302bd8a 7149751: another krb5 test in openjdk6 without test infrastructure Reviewed-by: ohair, robilad - test/sun/security/krb5/auto/IgnoreChannelBinding.java From david.buck at oracle.com Fri Mar 9 01:31:10 2012 From: david.buck at oracle.com (David Buck) Date: Fri, 09 Mar 2012 18:31:10 +0900 Subject: CR 7007299 request for code review and approval to push Message-ID: <4F59CDDE.9050307@oracle.com> Hi! I would like to have the following fix reviewed and approved for push into JDK6. http://cr.openjdk.java.net/~dbuck/7007229/webrev.00/ It is a backport of a fix from JDK7 that has been baking there for over a year. [ changeset 3159 b0f9760f3103 ] http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b0f9760f3103 The same fix has also already been backported to the closed JDK6 as of update 30. This issue easily reproduces on any recent build of OpenJDK 6 on Linux (see bug report for test case). Customers that have hit this issue report being impacted greatly by this problem. [ 7007299 FileFontStrike appears not to be threadsafe? ] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7007299 Cheers, -Buck From vikram.aroskar at oracle.com Fri Mar 9 01:54:17 2012 From: vikram.aroskar at oracle.com (Vikram Aroskar) Date: Fri, 09 Mar 2012 15:24:17 +0530 Subject: CR 7007299 request for code review and approval to push In-Reply-To: <4F59CDDE.9050307@oracle.com> References: <4F59CDDE.9050307@oracle.com> Message-ID: <4F59D349.1060409@oracle.com> code change looks good. -Vikram On 09-03-2012 15:01, David Buck wrote: > Hi! > > I would like to have the following fix reviewed and approved for push > into JDK6. > > http://cr.openjdk.java.net/~dbuck/7007229/webrev.00/ > > It is a backport of a fix from JDK7 that has been baking there for > over a year. > > [ changeset 3159 b0f9760f3103 ] > http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b0f9760f3103 > > The same fix has also already been backported to the closed JDK6 as of > update 30. > > This issue easily reproduces on any recent build of OpenJDK 6 on Linux > (see bug report for test case). Customers that have hit this issue > report being impacted greatly by this problem. > > [ 7007299 FileFontStrike appears not to be threadsafe? ] > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7007299 > > Cheers, > -Buck > From kelly.ohair at oracle.com Fri Mar 9 12:50:39 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 9 Mar 2012 12:50:39 -0800 Subject: CR 7007299 request for code review and approval to push In-Reply-To: <4F59CDDE.9050307@oracle.com> References: <4F59CDDE.9050307@oracle.com> Message-ID: <9231E592-A597-4AAA-BC54-A0AE00295D85@oracle.com> Approved. -kto On Mar 9, 2012, at 1:31 AM, David Buck wrote: > Hi! > > I would like to have the following fix reviewed and approved for push into JDK6. > > http://cr.openjdk.java.net/~dbuck/7007229/webrev.00/ > > It is a backport of a fix from JDK7 that has been baking there for over a year. > > [ changeset 3159 b0f9760f3103 ] > http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b0f9760f3103 > > The same fix has also already been backported to the closed JDK6 as of update 30. > > This issue easily reproduces on any recent build of OpenJDK 6 on Linux (see bug report for test case). Customers that have hit this issue report being impacted greatly by this problem. > > [ 7007299 FileFontStrike appears not to be threadsafe? ] > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7007299 > > Cheers, > -Buck > From vikram.aroskar at oracle.com Mon Mar 12 02:30:29 2012 From: vikram.aroskar at oracle.com (vikram.aroskar at oracle.com) Date: Mon, 12 Mar 2012 09:30:29 +0000 Subject: hg: jdk6/jdk6/jdk: 7007299: FileFontStrike appears not to be threadsafe Message-ID: <20120312093042.4A44247907@hg.openjdk.java.net> Changeset: 69fbcc78346e Author: vikram Date: 2012-03-12 02:28 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/69fbcc78346e 7007299: FileFontStrike appears not to be threadsafe Summary: Initialize graph reference arrays first and only then mark volatile flag (glyphCacheFormat) to indicate to other threads initialization is complete. Reviewed-by: vikram Contributed-by: David Buck ! src/share/classes/sun/font/FileFontStrike.java From leo.hippelainen at wippies.com Sun Mar 25 03:30:27 2012 From: leo.hippelainen at wippies.com (leo.hippelainen at wippies.com) Date: Sun, 25 Mar 2012 13:30:27 +0300 (EEST) Subject: java2d/pipe/Region.java equals, hix vs hiy Message-ID: <1930807511.9411332671427784.JavaMail.leo.hippelainen@wippies.com> Hi! While comparing source modules between JDKs we noticed that in OpenJDK6 module jdk/src/share/classes/sun/java2d/pipe/Region.java, line 1209 contains: r.hiy != this.hiy || r.hiy != this.hiy Should it rather read like this: r.hix != this.hix || r.hiy != this.hiy I found out that this modification has been done to OpenJDK7 three years ago: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/f36e9200cb85 My copy of the OpenJDK6 sources are extracted from openjdk-6-src-b24-14_nov_2011.tar.gz Best regards, Leo H. (&Sampo) -- Wippies-vallankumous on t??ll?! Varmista paikkasi vallankumouksen eturintamassa ja liity Wippiesiin heti! http://www.wippies.com/ From philip.race at oracle.com Sun Mar 25 10:36:36 2012 From: philip.race at oracle.com (Phil Race) Date: Sun, 25 Mar 2012 10:36:36 -0700 Subject: java2d/pipe/Region.java equals, hix vs hiy In-Reply-To: <1930807511.9411332671427784.JavaMail.leo.hippelainen@wippies.com> References: <1930807511.9411332671427784.JavaMail.leo.hippelainen@wippies.com> Message-ID: <4F6F57A4.8080601@oracle.com> I think the bug was originally introduced in 6u10 for 6633275: Need to support shaped/translucent windows It was later fixed in 6u12 as 6777320: PIT : Canvas is not fully painted on the internal frame & internal frame All this was forwarded ported to 7. Offhand I'm not sure how the former work made it into 6open but not the bug fix, as 6-open split off from JDK 7 around 7 b23. -phil. On 3/25/12 3:30 AM, leo.hippelainen at wippies.com wrote: > Hi! > > While comparing source modules between JDKs we noticed that in > OpenJDK6 module jdk/src/share/classes/sun/java2d/pipe/Region.java, > line 1209 contains: > > r.hiy != this.hiy || r.hiy != this.hiy > > Should it rather read like this: > > r.hix != this.hix || r.hiy != this.hiy > > I found out that this modification has been done to OpenJDK7 three > years ago: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/f36e9200cb85 > > My copy of the OpenJDK6 sources are extracted from > openjdk-6-src-b24-14_nov_2011.tar.gz > > Best regards, > Leo H. (&Sampo) > > From ptisnovs at redhat.com Mon Mar 26 07:32:08 2012 From: ptisnovs at redhat.com (Pavel Tisnovsky) Date: Mon, 26 Mar 2012 16:32:08 +0200 Subject: Code review request: backport of "6792400: Avoid loading of Normalizer resources, for simple uses" into OpenJDK6 Message-ID: <4F707DE8.4090002@redhat.com> Hi, I'd like to push following backport to IcedTea6 HEAD (and to OpenJDK6 too - will do parallel request): "6792400: Avoid loading of Normalizer resources, for simple uses". Webrev with this change is available here: http://cr.openjdk.java.net/~ptisnovs/6792400-Avoid_loading_of_Normalizer_resources/ Can anybody please review this change and create new bug# for push? Thank you in advance, Pavel PS: Just for info - this backport fixes following IcedTea6 bug: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=882