From ahughes at redhat.com Tue May 1 03:58:19 2012 From: ahughes at redhat.com (Andrew Hughes) Date: Tue, 01 May 2012 06:58:19 -0400 (EDT) Subject: JDK 7u4 is now GA In-Reply-To: <23138B91-882A-4876-8602-41DA00478265@oracle.com> Message-ID: <6226522e-044f-4520-9427-882502cd9795@zmail17.collab.prod.int.phx2.redhat.com> ----- Original Message ----- > Hi, > > I'd like to announce that JDK 7u4 is now generally available [1]. I > would like to thank all of you for the contributions you've made! > OpenJDK 7u4 source code is available on the Mercurial server [2] and > as usual we will also publish a source code archive soon. Once they > are available I will send out a link. > > If you're packaging this release, please let us know on this list, > and please consider contributing fixes back into 7u6 [3], which is > open for fixes. > > Cheers, > Edvard > > [1] > http://www.oracle.com/technetwork/java/javase/downloads/index.html > [2] http://hg.openjdk.java.net/jdk7u/jdk7u4/ > [3] http://openjdk.java.net/projects/jdk7u/ > > Where was this release date announced? The last discussion I see is: http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-February/002042.html which says there is "about a month or so left". Then a release appears about two months later. Am I missing something? -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From dalibor.topic at oracle.com Tue May 1 05:47:16 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Tue, 01 May 2012 14:47:16 +0200 Subject: JDK 7u4 is now GA In-Reply-To: <6226522e-044f-4520-9427-882502cd9795@zmail17.collab.prod.int.phx2.redhat.com> References: <6226522e-044f-4520-9427-882502cd9795@zmail17.collab.prod.int.phx2.redhat.com> Message-ID: <4F9FDB54.3040402@oracle.com> On 5/1/12 12:58 PM, Andrew Hughes wrote: > which says there is "about a month or so left". Then a release appears > about two months later. Am I missing something? Hard to say. I think that the JavaOne strategy keynotes in Moscow & Tokio in April narrowed that down to 'by the end of the month', which was pretty much when it was released. Historically, work on 7u2 in OpenJDK began in July, with a release in December, so it took about 6 months. Historically, work on 7u4 began with the 7u2 rampdown, i.e. in September, with a release in April, so it took about 8 months. But then 7u4 also brought in a new port for the first time in a long time. So you have historically 6-8 months as the time it took to deliver a JDK 7 Update release from the first changes making their way into the repos to the final source code tarball. Historically, rampdown on 7u2 began in September, with a release in December, so that phase took about 3 months. Historically, rampdown on 7u4 began in February, with a release in April, so that phase took about 2 months. So you have historically 2-3 months as the time it took to deliver a JDK 7 Update release from the start of the rampdown phase. The other aspect of release timing you can look at are CPU releases - their dates are publicly known well ahead of time. See http://www.oracle.com/technetwork/topics/security/alerts-086861.html for details. If you line the JDK 7 Updates releases so far, you get: 7u1: October '11 (CPU) 7u2: December '11 7u3: February '12 (CPU) 7u4: April '12 so it seems like we have had an approximately 2 month cadence over the past couple of releases. Obviously, I can't say whether that will continue in that same fashion, as I can't predict the future, but I hope this helps you get a rough idea about the timing of the previous releases. cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From ahughes at redhat.com Tue May 1 07:16:40 2012 From: ahughes at redhat.com (Andrew Hughes) Date: Tue, 01 May 2012 10:16:40 -0400 (EDT) Subject: JDK 7u4 is now GA In-Reply-To: <4F9FDB54.3040402@oracle.com> Message-ID: <4fe28e37-12e8-476e-9b2c-a035fd92b54a@zmail17.collab.prod.int.phx2.redhat.com> ----- Original Message ----- > On 5/1/12 12:58 PM, Andrew Hughes wrote: > > which says there is "about a month or so left". Then a release > > appears > > about two months later. Am I missing something? > > Hard to say. I think that the JavaOne strategy keynotes in Moscow & > Tokio in April > narrowed that down to 'by the end of the month', which was pretty > much when it was > released. > That's not that helpful to those who weren't at these keynotes. Why was a more recent update not given on this list? > Historically, work on 7u2 in OpenJDK began in July, with a release in > December, so > it took about 6 months. Historically, work on 7u4 began with the 7u2 > rampdown, i.e. in > September, with a release in April, so it took about 8 months. But > then 7u4 also brought > in a new port for the first time in a long time. So you have > historically 6-8 months > as the time it took to deliver a JDK 7 Update release from the first > changes making > their way into the repos to the final source code tarball. > > Historically, rampdown on 7u2 began in September, with a release in > December, so > that phase took about 3 months. Historically, rampdown on 7u4 began > in February, > with a release in April, so that phase took about 2 months. So you > have historically > 2-3 months as the time it took to deliver a JDK 7 Update release from > the start of > the rampdown phase. > > The other aspect of release timing you can look at are CPU releases - > their dates are > publicly known well ahead of time. See > http://www.oracle.com/technetwork/topics/security/alerts-086861.html > for details. > > If you line the JDK 7 Updates releases so far, you get: > > 7u1: October '11 (CPU) > 7u2: December '11 > 7u3: February '12 (CPU) > 7u4: April '12 > > so it seems like we have had an approximately 2 month cadence over > the past couple of releases. > > Obviously, I can't say whether that will continue in that same > fashion, as I can't predict > the future, but I hope this helps you get a rough idea about the > timing of the previous > releases. > Sure, I can make the same guesses and interpolations from the past. But I was assuming that Oracle would have some kind of release process in place and that it wasn't some kind of random event that I had to try and predict. Is this not the case? With IcedTea, we notify people on the mailing list about a week before a planned release date so they can get fixes in on time. Then we update further if that date needs to be changed. Is the same not possible for jdk7 updates? It makes it very hard to plan downstream packaging of OpenJDK if the release process is not transparent. Dates are provided for security updates and so we can work around them as appropriate. Why can this not be done for the other updates? > cheers, > dalibor topic > -- > Oracle > Dalibor Topic | Principal Product Manager > Phone: +494089091214 | Mobile: +491737185961 > > Oracle Java Platform Group > > ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg > > ORACLE Deutschland B.V. & Co. KG > Hauptverwaltung: Riesstr. 25, D-80992 M?nchen > Registergericht: Amtsgericht M?nchen, HRA 95603 > Gesch?ftsf?hrer: J?rgen Kunz > > Komplement?rin: ORACLE Deutschland Verwaltung B.V. > Hertogswetering 163/167, 3543 AS Utrecht, Niederlande > Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 > Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher > > Green Oracle Oracle is committed > to developing practices and products that help protect the > environment > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From alexander.zuev at oracle.com Wed May 2 09:36:00 2012 From: alexander.zuev at oracle.com (Alexander Zuev) Date: Wed, 02 May 2012 20:36:00 +0400 Subject: [7u6] Request for approval: 7148289: [macosx] Deadlock in sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame Message-ID: <4FA16270.6070308@oracle.com> Requesting approval to push fix for CR 7148289: [macosx] Deadlock in sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame into the 7u6 workspace. Bug description: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7148289 Proposed fix: http://cr.openjdk.java.net/~kizune/7148289/webrev.01 Fix were reviewed on public alias and approved by Anthony Petrov Technical review thread is here: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-April/004010.html With best regards, Alexander Zuev From alexlamsl at gmail.com Wed May 2 10:13:32 2012 From: alexlamsl at gmail.com (Alex Lam S.L.) Date: Wed, 2 May 2012 18:13:32 +0100 Subject: [7u4] .jar association broken on Windows Message-ID: Hi there, I have tried JDK 7u4 (32/64-bit) and JRE 7u4 (32-bit), on a Win7 (x64) box and a WinXP (32-bit) box, and after installation all .jar association has been removed. So now I cannot double-click any JAR files in Windows Explorer to run them. I previously had 7u2 on the Win7 box and 6u31 on the WinXP box, and they were working okay. This is of course rather annoying - I would like to know if this is just me or have I missed something important? Alex. From igor.nekrestyanov at oracle.com Wed May 2 10:33:48 2012 From: igor.nekrestyanov at oracle.com (Igor Nekrestyanov) Date: Wed, 02 May 2012 10:33:48 -0700 Subject: [7u4] .jar association broken on Windows In-Reply-To: References: Message-ID: <4FA16FFC.2020701@oracle.com> This sounds like the same issue reported in JavaFX context: http://javafx-jira.kenai.com/browse/RT-21194 At this point we are not clear how this can happen (except user creating manual association at some point) and we only seen few reports so far. Please follow troubleshooting steps there to provide us more information. In particular validate you do not have .jar association settings in the HKCU branch. Please add details to the same JIRA issue, -igor On 5/2/12 10:13 AM, Alex Lam S.L. wrote: > Hi there, > > I have tried JDK 7u4 (32/64-bit) and JRE 7u4 (32-bit), on a Win7 (x64) > box and a WinXP (32-bit) box, and after installation all .jar > association has been removed. > > So now I cannot double-click any JAR files in Windows Explorer to run > them. I previously had 7u2 on the Win7 box and 6u31 on the WinXP box, > and they were working okay. > > This is of course rather annoying - I would like to know if this is > just me or have I missed something important? > > > Alex. From alexlamsl at gmail.com Wed May 2 10:45:55 2012 From: alexlamsl at gmail.com (Alex Lam S.L.) Date: Wed, 2 May 2012 18:45:55 +0100 Subject: [7u4] .jar association broken on Windows In-Reply-To: <4FA16FFC.2020701@oracle.com> References: <4FA16FFC.2020701@oracle.com> Message-ID: As far as I can tell, there has not been any manual modifications of file associations on both Windows machines, i.e. only bulk-standard JDK / JRE (un)installations have ever been performed. Thanks for the pointers - I will have a look at the JIRA issue. Although I confirm that this has nothing to do with JavaFX? Alex. On Wed, May 2, 2012 at 6:33 PM, Igor Nekrestyanov wrote: > This sounds like the same issue reported in JavaFX context: > ? http://javafx-jira.kenai.com/browse/RT-21194 > > At this point we are not clear how this can happen (except user creating > manual association at some point) > and we only seen few reports so far. > > Please follow troubleshooting steps there to provide us more information. > In particular validate you do not have .jar association settings in the HKCU > branch. > > Please add details to the same JIRA issue, > > -igor > > > On 5/2/12 10:13 AM, Alex Lam S.L. wrote: >> >> Hi there, >> >> I have tried JDK 7u4 (32/64-bit) and JRE 7u4 (32-bit), on a Win7 (x64) >> box and a WinXP (32-bit) box, and after installation all .jar >> association has been removed. >> >> So now I cannot double-click any JAR files in Windows Explorer to run >> them. I previously had 7u2 on the Win7 box and 6u31 on the WinXP box, >> and they were working okay. >> >> This is of course rather annoying - I would like to know if this is >> just me or have I missed something important? >> >> >> Alex. > > From alexlamsl at gmail.com Wed May 2 10:47:36 2012 From: alexlamsl at gmail.com (Alex Lam S.L.) Date: Wed, 2 May 2012 18:47:36 +0100 Subject: [7u4] .jar association broken on Windows In-Reply-To: <4FA16FFC.2020701@oracle.com> References: <4FA16FFC.2020701@oracle.com> Message-ID: On Wed, May 2, 2012 at 6:33 PM, Igor Nekrestyanov wrote: > This sounds like the same issue reported in JavaFX context: > ? http://javafx-jira.kenai.com/browse/RT-21194 When I visit that URL, I get: Login Required You are not logged in. I tried with my java.net details, but can't get in either: Sorry, your username and password are incorrect - please try again. Alex. From igor.nekrestyanov at oracle.com Wed May 2 10:53:33 2012 From: igor.nekrestyanov at oracle.com (Igor Nekrestyanov) Date: Wed, 02 May 2012 10:53:33 -0700 Subject: [7u4] .jar association broken on Windows In-Reply-To: References: <4FA16FFC.2020701@oracle.com> Message-ID: <4FA1749D.10900@oracle.com> On 5/2/12 10:45 AM, Alex Lam S.L. wrote: > As far as I can tell, there has not been any manual modifications of > file associations on both Windows machines, i.e. only bulk-standard > JDK / JRE (un)installations have ever been performed. > > Thanks for the pointers - I will have a look at the JIRA issue. > Although I confirm that this has nothing to do with JavaFX? JavaFX installer does not do anything in respect to .jar associations. They are only updated by JRE installer. In that case user also installed 7u4 JREs. -igor > > > Alex. > > > > On Wed, May 2, 2012 at 6:33 PM, Igor Nekrestyanov > wrote: >> This sounds like the same issue reported in JavaFX context: >> http://javafx-jira.kenai.com/browse/RT-21194 >> >> At this point we are not clear how this can happen (except user creating >> manual association at some point) >> and we only seen few reports so far. >> >> Please follow troubleshooting steps there to provide us more information. >> In particular validate you do not have .jar association settings in the HKCU >> branch. >> >> Please add details to the same JIRA issue, >> >> -igor >> >> >> On 5/2/12 10:13 AM, Alex Lam S.L. wrote: >>> Hi there, >>> >>> I have tried JDK 7u4 (32/64-bit) and JRE 7u4 (32-bit), on a Win7 (x64) >>> box and a WinXP (32-bit) box, and after installation all .jar >>> association has been removed. >>> >>> So now I cannot double-click any JAR files in Windows Explorer to run >>> them. I previously had 7u2 on the Win7 box and 6u31 on the WinXP box, >>> and they were working okay. >>> >>> This is of course rather annoying - I would like to know if this is >>> just me or have I missed something important? >>> >>> >>> Alex. >> From igor.nekrestyanov at oracle.com Wed May 2 10:59:23 2012 From: igor.nekrestyanov at oracle.com (Igor Nekrestyanov) Date: Wed, 02 May 2012 10:59:23 -0700 Subject: [7u4] .jar association broken on Windows In-Reply-To: References: <4FA16FFC.2020701@oracle.com> Message-ID: <4FA175FB.9030801@oracle.com> On 5/2/12 10:47 AM, Alex Lam S.L. wrote: > On Wed, May 2, 2012 at 6:33 PM, Igor Nekrestyanov > wrote: >> This sounds like the same issue reported in JavaFX context: >> http://javafx-jira.kenai.com/browse/RT-21194 > When I visit that URL, I get: > > Login Required > > You are not logged in. > > I tried with my java.net details, but can't get in either: > > Sorry, your username and password are incorrect - please try again. You may need to sign up: http://javafx-jira.kenai.com/secure/Signup!default.jspa -igor > > > Alex. From kurchi.subhra.hazra at oracle.com Wed May 2 12:10:19 2012 From: kurchi.subhra.hazra at oracle.com (Kurchi Hazra) Date: Wed, 02 May 2012 12:10:19 -0700 Subject: [7u6] Request for approval: 7118100: (prefs) Inconsistency when using system and user preference on OSX Lion In-Reply-To: <4FA050A8.8040605@oracle.com> References: <4FA050A8.8040605@oracle.com> Message-ID: <4FA1869B.6020501@oracle.com> Requesting approval to commit fix for CR 7118100. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7118100 Webrev: http://cr.openjdk.java.net/~khazra/7118100/webrev.01/ This had been reviewed by Alan Bateman. [1] This fix has been pushed into jdk8 [2] Thanks, Kurchi [1] http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-February/003081.html [2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/108a02a57b75 From david.katleman at oracle.com Wed May 2 16:12:34 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 02 May 2012 23:12:34 +0000 Subject: hg: jdk7u/jdk7u: Added tag jdk7u6-b08 for changeset 09182be47ee9 Message-ID: <20120502231234.C5C8747103@hg.openjdk.java.net> Changeset: 01001f439af7 Author: katleman Date: 2012-05-02 14:13 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/rev/01001f439af7 Added tag jdk7u6-b08 for changeset 09182be47ee9 ! .hgtags From david.katleman at oracle.com Wed May 2 16:12:38 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 02 May 2012 23:12:38 +0000 Subject: hg: jdk7u/jdk7u/corba: Added tag jdk7u6-b08 for changeset 7df162b43e6e Message-ID: <20120502231239.53F8347104@hg.openjdk.java.net> Changeset: 13faa12cfdd6 Author: katleman Date: 2012-05-02 14:13 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/corba/rev/13faa12cfdd6 Added tag jdk7u6-b08 for changeset 7df162b43e6e ! .hgtags From david.katleman at oracle.com Wed May 2 16:13:04 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 02 May 2012 23:13:04 +0000 Subject: hg: jdk7u/jdk7u/hotspot: Added tag jdk7u6-b08 for changeset 6b668c1049a8 Message-ID: <20120502231308.3F3F147105@hg.openjdk.java.net> Changeset: 94d7a305da4d Author: katleman Date: 2012-05-02 14:13 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/94d7a305da4d Added tag jdk7u6-b08 for changeset 6b668c1049a8 ! .hgtags From david.katleman at oracle.com Wed May 2 16:14:05 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 02 May 2012 23:14:05 +0000 Subject: hg: jdk7u/jdk7u/jaxp: Added tag jdk7u6-b08 for changeset cf61740310b4 Message-ID: <20120502231407.BAFA747106@hg.openjdk.java.net> Changeset: 52d82754ec69 Author: katleman Date: 2012-05-02 14:14 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jaxp/rev/52d82754ec69 Added tag jdk7u6-b08 for changeset cf61740310b4 ! .hgtags From david.katleman at oracle.com Wed May 2 16:14:11 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 02 May 2012 23:14:11 +0000 Subject: hg: jdk7u/jdk7u/jaxws: Added tag jdk7u6-b08 for changeset 3915e1a50ea9 Message-ID: <20120502231411.9CEA547107@hg.openjdk.java.net> Changeset: 03a772c8b8fb Author: katleman Date: 2012-05-02 14:14 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jaxws/rev/03a772c8b8fb Added tag jdk7u6-b08 for changeset 3915e1a50ea9 ! .hgtags From david.katleman at oracle.com Wed May 2 16:14:18 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 02 May 2012 23:14:18 +0000 Subject: hg: jdk7u/jdk7u/jdk: Added tag jdk7u6-b08 for changeset a5949f7b8693 Message-ID: <20120502231437.E624147108@hg.openjdk.java.net> Changeset: 0cd518f8fea7 Author: katleman Date: 2012-05-02 14:14 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/0cd518f8fea7 Added tag jdk7u6-b08 for changeset a5949f7b8693 ! .hgtags From david.katleman at oracle.com Wed May 2 16:15:30 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 02 May 2012 23:15:30 +0000 Subject: hg: jdk7u/jdk7u/langtools: Added tag jdk7u6-b08 for changeset ed00f61a5de8 Message-ID: <20120502231532.867F947109@hg.openjdk.java.net> Changeset: 3e268ea565ef Author: katleman Date: 2012-05-02 14:14 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/3e268ea565ef Added tag jdk7u6-b08 for changeset ed00f61a5de8 ! .hgtags From edvard.wendelin at oracle.com Thu May 3 01:24:13 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Thu, 03 May 2012 10:24:13 +0200 Subject: [7u6] Request for approval: 7118100: (prefs) Inconsistency when using system and user preference on OSX Lion In-Reply-To: <4FA1869B.6020501@oracle.com> References: <4FA050A8.8040605@oracle.com> <4FA1869B.6020501@oracle.com> Message-ID: <4FA240AD.90002@oracle.com> Approved. On 05/02/2012 09:10 PM, Kurchi Hazra wrote: > > Requesting approval to commit fix for CR 7118100. > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7118100 > Webrev: http://cr.openjdk.java.net/~khazra/7118100/webrev.01/ > > This had been reviewed by Alan Bateman. [1] > > This fix has been pushed into jdk8 [2] > > Thanks, > Kurchi > > [1] > http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-February/003081.html > [2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/108a02a57b75 From edvard.wendelin at oracle.com Thu May 3 01:26:07 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Thu, 03 May 2012 10:26:07 +0200 Subject: [7u6] Request for approval: 7148289: [macosx] Deadlock in sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame In-Reply-To: <4FA16270.6070308@oracle.com> References: <4FA16270.6070308@oracle.com> Message-ID: <4FA2411F.3040305@oracle.com> I'll pre-approve this, but please push to JDK8 before taking it to 7u6. Cheers, Edvard On 05/02/2012 06:36 PM, Alexander Zuev wrote: > Requesting approval to push fix for CR 7148289: [macosx] Deadlock in > sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame > into the 7u6 workspace. > > Bug description: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7148289 > > Proposed fix: http://cr.openjdk.java.net/~kizune/7148289/webrev.01 > > Fix were reviewed on public alias and approved by Anthony Petrov > Technical review thread is here: > http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-April/004010.html > > > With best regards, > Alexander Zuev From dalibor.topic at oracle.com Thu May 3 10:50:40 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Thu, 03 May 2012 23:20:40 +0530 Subject: [7u4] .jar association broken on Windows In-Reply-To: References: Message-ID: <4FA2C570.9070101@oracle.com> On 5/2/12 10:43 PM, Alex Lam S.L. wrote: > Hi there, > > I have tried JDK 7u4 (32/64-bit) and JRE 7u4 (32-bit), on a Win7 (x64) > box and a WinXP (32-bit) box, and after installation all .jar > association has been removed. > > So now I cannot double-click any JAR files in Windows Explorer to run > them. I previously had 7u2 on the Win7 box and 6u31 on the WinXP box, > and they were working okay. > > This is of course rather annoying - I would like to know if this is > just me or have I missed something important? > Thanks for reporting this. Henrik posted the following regarding this issue on his blog: https://blogs.oracle.com/henrik/entry/moving_to_java_7_as "Update: After posting JRE 7 Update 4 on java.com we have received reports of an installer issue that impacts some Windows configurations. We have reverted back to JRE 6 while we wait for an analysis of this report to complete. We expect to be able to switch back to 7u4 shortly." cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From leonid.romanov at oracle.com Thu May 3 11:09:04 2012 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Thu, 3 May 2012 22:09:04 +0400 Subject: [7u6] Request for approval: 7124376: [macosx] Modal dialog lost focus Message-ID: <8C7BA8FB-3253-4DFA-976C-98848D922060@oracle.com> Hi, Requesting approval to push the fix for CR 7124376. This fix has already been pushed to JDK 8. For 7u6 it has been reviewed by Alexander Zuev. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124376 Webrev: http://cr.openjdk.java.net/~leonidr/7124376/webrev.02/ Review: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004067.html JDK 8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a420895ee2c3 Thanks, Leonid. From alexander.zuev at oracle.com Thu May 3 11:19:10 2012 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Thu, 03 May 2012 18:19:10 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7148289: [macosx] Deadlock in sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame Message-ID: <20120503181929.27F5647131@hg.openjdk.java.net> Changeset: ddb615988fbf Author: kizune Date: 2012-05-03 22:18 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/ddb615988fbf 7148289: [macosx] Deadlock in sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame Reviewed-by: anthony ! src/macosx/classes/sun/lwawt/macosx/CToolkitThreadBlockedHandler.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/LWCToolkit.m From alan.bateman at oracle.com Thu May 3 13:30:03 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 03 May 2012 20:30:03 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7118100: (prefs) Inconsistency when using system and user preference on OSX Lion Message-ID: <20120503203022.4532647134@hg.openjdk.java.net> Changeset: b4a447259412 Author: khazra Date: 2012-05-03 21:27 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/b4a447259412 7118100: (prefs) Inconsistency when using system and user preference on OSX Lion Summary: Enable user to read/write preferences to persistent storage Reviewed-by: alanb ! src/macosx/classes/java/util/prefs/MacOSXPreferences.java ! src/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java From alexlamsl at gmail.com Thu May 3 15:01:51 2012 From: alexlamsl at gmail.com (Alex Lam S.L.) Date: Thu, 3 May 2012 23:01:51 +0100 Subject: [7u4] .jar association broken on Windows In-Reply-To: <4FA2C570.9070101@oracle.com> References: <4FA2C570.9070101@oracle.com> Message-ID: Thanks for looking into it. Will wait for the fix before evaluating migration to JavaSE 7. Alex. On Thu, May 3, 2012 at 6:50 PM, Dalibor Topic wrote: > On 5/2/12 10:43 PM, Alex Lam S.L. wrote: >> Hi there, >> >> I have tried JDK 7u4 (32/64-bit) and JRE 7u4 (32-bit), on a Win7 (x64) >> box and a WinXP (32-bit) box, and after installation all .jar >> association has been removed. >> >> So now I cannot double-click any JAR files in Windows Explorer to run >> them. I previously had 7u2 on the Win7 box and 6u31 on the WinXP box, >> and they were working okay. >> >> This is of course rather annoying - I would like to know if this is >> just me or have I missed something important? >> > > Thanks for reporting this. Henrik posted the following regarding this issue > on his blog: > https://blogs.oracle.com/henrik/entry/moving_to_java_7_as > > "Update: After posting JRE 7 Update 4 on java.com we have received reports > of an installer issue that impacts some Windows configurations. We have > reverted back to JRE 6 while we wait for an analysis of this report to > complete. We expect to be able to switch back to 7u4 shortly." > > cheers, > dalibor topic > -- > Oracle > Dalibor Topic | Principal Product Manager > Phone: +494089091214 | Mobile: +491737185961 > Oracle Java Platform Group > > ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg > > ORACLE Deutschland B.V. & Co. KG > Hauptverwaltung: Riesstr. 25, D-80992 M?nchen > Registergericht: Amtsgericht M?nchen, HRA 95603 > Gesch?ftsf?hrer: J?rgen Kunz > > Komplement?rin: ORACLE Deutschland Verwaltung B.V. > Hertogswetering 163/167, 3543 AS Utrecht, Niederlande > Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 > Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher > > Green Oracle Oracle is committed to developing practices and products that help protect the environment From jeroen at sumatra.nl Thu May 3 23:31:44 2012 From: jeroen at sumatra.nl (Jeroen Frijters) Date: Fri, 4 May 2012 06:31:44 +0000 Subject: JDK 7u4 is now GA In-Reply-To: <4F9FDB54.3040402@oracle.com> References: <6226522e-044f-4520-9427-882502cd9795@zmail17.collab.prod.int.phx2.redhat.com> <4F9FDB54.3040402@oracle.com> Message-ID: Hi, Is there an ETA for the 7u4 bundle? I would like to integrate it into IKVM. Regards, Jeroen From martijnverburg at gmail.com Fri May 4 00:49:48 2012 From: martijnverburg at gmail.com (Martijn Verburg) Date: Fri, 4 May 2012 08:49:48 +0100 Subject: JDK 7u4 is now GA In-Reply-To: References: <6226522e-044f-4520-9427-882502cd9795@zmail17.collab.prod.int.phx2.redhat.com> <4F9FDB54.3040402@oracle.com> Message-ID: Hi Jereon, What do you mean by bundle? u4 was released last week (or thereabouts). Cheers, Martijn On 4 May 2012 07:31, Jeroen Frijters wrote: > Hi, > > Is there an ETA for the 7u4 bundle? I would like to integrate it into IKVM. > > Regards, > Jeroen > From jeroen at sumatra.nl Fri May 4 00:52:47 2012 From: jeroen at sumatra.nl (Jeroen Frijters) Date: Fri, 4 May 2012 07:52:47 +0000 Subject: JDK 7u4 is now GA In-Reply-To: References: <6226522e-044f-4520-9427-882502cd9795@zmail17.collab.prod.int.phx2.redhat.com> <4F9FDB54.3040402@oracle.com> Message-ID: Hi Martijn, This is what I mean: http://download.java.net/openjdk/jdk7u2/ Regards, Jeroen > -----Original Message----- > From: Martijn Verburg [mailto:martijnverburg at gmail.com] > Sent: Friday, May 04, 2012 09:50 > To: Jeroen Frijters > Cc: jdk7u-dev at openjdk.java.net > Subject: Re: JDK 7u4 is now GA > > Hi Jereon, > > What do you mean by bundle? u4 was released last week (or thereabouts). > > Cheers, > Martijn > > On 4 May 2012 07:31, Jeroen Frijters wrote: > > Hi, > > > > Is there an ETA for the 7u4 bundle? I would like to integrate it into > IKVM. > > > > Regards, > > Jeroen > > From martijnverburg at gmail.com Fri May 4 00:55:31 2012 From: martijnverburg at gmail.com (Martijn Verburg) Date: Fri, 4 May 2012 08:55:31 +0100 Subject: JDK 7u4 is now GA In-Reply-To: References: <6226522e-044f-4520-9427-882502cd9795@zmail17.collab.prod.int.phx2.redhat.com> <4F9FDB54.3040402@oracle.com> Message-ID: Hi Jeroen, If it's the source that you're looking for, is it not possible to get/build that from the mercurial repo itself (with tag 7u4)? Not 100% sure on that, perhaps someone else can chime in :-) Cheers, Martijn On 4 May 2012 08:52, Jeroen Frijters wrote: > Hi Martijn, > > This is what I mean: > http://download.java.net/openjdk/jdk7u2/ > > Regards, > Jeroen > >> -----Original Message----- >> From: Martijn Verburg [mailto:martijnverburg at gmail.com] >> Sent: Friday, May 04, 2012 09:50 >> To: Jeroen Frijters >> Cc: jdk7u-dev at openjdk.java.net >> Subject: Re: JDK 7u4 is now GA >> >> Hi Jereon, >> >> What do you mean by bundle? ?u4 was released last week (or thereabouts). >> >> Cheers, >> Martijn >> >> On 4 May 2012 07:31, Jeroen Frijters wrote: >> > Hi, >> > >> > Is there an ETA for the 7u4 bundle? I would like to integrate it into >> IKVM. >> > >> > Regards, >> > Jeroen >> > From edvard.wendelin at oracle.com Fri May 4 01:26:33 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Fri, 04 May 2012 10:26:33 +0200 Subject: JDK 7u4 is now GA In-Reply-To: References: <6226522e-044f-4520-9427-882502cd9795@zmail17.collab.prod.int.phx2.redhat.com> <4F9FDB54.3040402@oracle.com> Message-ID: <4FA392B9.80502@oracle.com> We are working on uploading the source bundles. I don't have an ETA for when that work is finished though. I will of course let you know as soon as it's available! In the meantime you can get the source from http://hg.openjdk.java.net/jdk7u/jdk7u4 Cheers, Edvard On 05/04/2012 09:55 AM, Martijn Verburg wrote: > Hi Jeroen, > > If it's the source that you're looking for, is it not possible to > get/build that from the mercurial repo itself (with tag 7u4)? Not > 100% sure on that, perhaps someone else can chime in :-) > > Cheers, > Martijn > > On 4 May 2012 08:52, Jeroen Frijters wrote: >> Hi Martijn, >> >> This is what I mean: >> http://download.java.net/openjdk/jdk7u2/ >> >> Regards, >> Jeroen >> >>> -----Original Message----- >>> From: Martijn Verburg [mailto:martijnverburg at gmail.com] >>> Sent: Friday, May 04, 2012 09:50 >>> To: Jeroen Frijters >>> Cc: jdk7u-dev at openjdk.java.net >>> Subject: Re: JDK 7u4 is now GA >>> >>> Hi Jereon, >>> >>> What do you mean by bundle? u4 was released last week (or thereabouts). >>> >>> Cheers, >>> Martijn >>> >>> On 4 May 2012 07:31, Jeroen Frijters wrote: >>>> Hi, >>>> >>>> Is there an ETA for the 7u4 bundle? I would like to integrate it into >>> IKVM. >>>> Regards, >>>> Jeroen >>>> From edvard.wendelin at oracle.com Fri May 4 01:27:03 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Fri, 04 May 2012 10:27:03 +0200 Subject: [7u6] Request for approval: 7124376: [macosx] Modal dialog lost focus In-Reply-To: <8C7BA8FB-3253-4DFA-976C-98848D922060@oracle.com> References: <8C7BA8FB-3253-4DFA-976C-98848D922060@oracle.com> Message-ID: <4FA392D7.2030503@oracle.com> Approved. On 05/03/2012 08:09 PM, Leonid Romanov wrote: > Hi, > Requesting approval to push the fix for CR 7124376. This fix has already been pushed to JDK 8. For 7u6 it has been reviewed by Alexander Zuev. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124376 > Webrev: http://cr.openjdk.java.net/~leonidr/7124376/webrev.02/ > Review: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004067.html > JDK 8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a420895ee2c3 > > Thanks, > Leonid. > > From edvard.wendelin at oracle.com Fri May 4 05:23:52 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Fri, 04 May 2012 14:23:52 +0200 Subject: [7u6] Request for approval: 7154130 : Update build readme to include OS X Lion instructions Message-ID: <4FA3CA58.4040309@oracle.com> Requesting approval to commit fix for CR 7154130. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154130 Webrev: http://cr.openjdk.java.net/~ewendeli/7154130/webrev.01/ This had been reviewed on the build mailinglist. [1] This fix has been pushed into jdk8 [2] Kind regards, Edvard Wendelin [1] http://mail.openjdk.java.net/pipermail/build-dev/2012-April/006044.html [2] http://hg.openjdk.java.net/jdk8/build/rev/2f06b15e2439 From dalibor.topic at oracle.com Fri May 4 07:29:56 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Fri, 04 May 2012 19:59:56 +0530 Subject: [7u6] Request for approval: 7154130 : Update build readme to include OS X Lion instructions In-Reply-To: <4FA3CA58.4040309@oracle.com> References: <4FA3CA58.4040309@oracle.com> Message-ID: <4FA3E7E4.9030209@oracle.com> Approved. I'll push the change for you. cheers, dalibor topic On 5/4/12 5:53 PM, Edvard Wendelin wrote: > > Requesting approval to commit fix for CR 7154130. > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154130 > Webrev: http://cr.openjdk.java.net/~ewendeli/7154130/webrev.01/ > > This had been reviewed on the build mailinglist. [1] > > This fix has been pushed into jdk8 [2] > > Kind regards, > Edvard Wendelin > > [1] http://mail.openjdk.java.net/pipermail/build-dev/2012-April/006044.html > [2] http://hg.openjdk.java.net/jdk8/build/rev/2f06b15e2439 -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From dmitry.cherepanov at oracle.com Fri May 4 08:21:07 2012 From: dmitry.cherepanov at oracle.com (Dmitry Cherepanov) Date: Fri, 04 May 2012 19:21:07 +0400 Subject: [7u6] Request for approval: 7154062: [macosx] Mouse cursor isn't updated in applets Message-ID: <4FA3F3E3.4000209@oracle.com> This is a request to back port a fix from jdk8 to 7u6: Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154062 Webrev: http://cr.openjdk.java.net/~dcherepanov/7154062/7u6/webrev.0/ Review: http://mail.openjdk.java.net/pipermail/awt-dev/2012-May/002693.html Changeset in jdk8: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bbbf4e63562b Thanks, Dmitry From edvard.wendelin at oracle.com Fri May 4 08:17:06 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Fri, 04 May 2012 17:17:06 +0200 Subject: [7u6] Request for approval: 7154062: [macosx] Mouse cursor isn't updated in applets In-Reply-To: <4FA3F3E3.4000209@oracle.com> References: <4FA3F3E3.4000209@oracle.com> Message-ID: <4FA3F2F2.1030408@oracle.com> Approved. On 05/04/2012 05:21 PM, Dmitry Cherepanov wrote: > This is a request to back port a fix from jdk8 to 7u6: > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154062 > Webrev: http://cr.openjdk.java.net/~dcherepanov/7154062/7u6/webrev.0/ > Review: > http://mail.openjdk.java.net/pipermail/awt-dev/2012-May/002693.html > Changeset in jdk8: > http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bbbf4e63562b > > Thanks, > Dmitry > From dmitry.cherepanov at oracle.com Fri May 4 08:30:36 2012 From: dmitry.cherepanov at oracle.com (dmitry.cherepanov at oracle.com) Date: Fri, 04 May 2012 15:30:36 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7154062: [macosx] Mouse cursor isn't updated in applets Message-ID: <20120504153047.56B0847155@hg.openjdk.java.net> Changeset: 8888021b9bae Author: dcherepanov Date: 2012-05-04 19:33 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/8888021b9bae 7154062: [macosx] Mouse cursor isn't updated in applets Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/macosx/CCursorManager.java ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java ! src/macosx/native/sun/awt/CCursorManager.m From dalibor.topic at oracle.com Fri May 4 11:39:51 2012 From: dalibor.topic at oracle.com (dalibor.topic at oracle.com) Date: Fri, 04 May 2012 18:39:51 +0000 Subject: hg: jdk7u/jdk7u-dev: 7154130: Add Mac OS X Instructions to README-builds.html Message-ID: <20120504183952.10C1A4715D@hg.openjdk.java.net> Changeset: 7ffd73535b8e Author: ewendeli Date: 2012-05-03 14:17 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/rev/7ffd73535b8e 7154130: Add Mac OS X Instructions to README-builds.html Reviewed-by: ohair Contributed-by: edvard.wendelin at oracle.com ! README-builds.html From xuelei.fan at oracle.com Fri May 4 18:17:12 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Sat, 05 May 2012 09:17:12 +0800 Subject: [7u6] request for approval, 7153184: NullPointerException when calling SSLEngineImpl.getSupportedCipherSuites Message-ID: <4FA47F98.6090106@oracle.com> Hi, This is a request to backport a JDK 8 fix into JDK 7u6: 7153184: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7153184 The fix has already been pushed to JDK 8: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41d3f7509e00 The code changes for jdk7u4 are identical to the ones in jdk8. We need to backport the fix to prevent multiple-thread-safe problems in some applications. I intend to push it to ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk Regards, Xuelei From leonid.romanov at oracle.com Sat May 5 03:19:01 2012 From: leonid.romanov at oracle.com (leonid.romanov at oracle.com) Date: Sat, 05 May 2012 10:19:01 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7124376: [macosx] Modal dialog lost focus Message-ID: <20120505101920.ABE724716E@hg.openjdk.java.net> Changeset: 6bf2990ade5d Author: leonidr Date: 2012-05-05 14:17 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/6bf2990ade5d 7124376: [macosx] Modal dialog lost focus Reviewed-by: kizune ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/PlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.h ! src/macosx/native/sun/awt/AWTWindow.m From chris.gruszka at oracle.com Sun May 6 18:38:59 2012 From: chris.gruszka at oracle.com (chris.gruszka at oracle.com) Date: Mon, 07 May 2012 01:38:59 +0000 Subject: hg: jdk7u/jdk7u/jdk: 16 new changesets Message-ID: <20120507014145.9CC4247184@hg.openjdk.java.net> Changeset: 44d1f9532dab Author: cgruszka Date: 2012-01-20 06:50 -0500 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/44d1f9532dab Merge Changeset: 87345cee010c Author: cgruszka Date: 2012-01-23 14:47 -0500 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/87345cee010c Merge Changeset: 793db974858e Author: cgruszka Date: 2012-01-27 15:15 -0500 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/793db974858e Merge Changeset: ff57973632ad Author: cgruszka Date: 2012-02-03 10:33 -0500 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/ff57973632ad Merge - test/java/io/File/BlockIsDirectory.java Changeset: 71ff554d45cd Author: cgruszka Date: 2012-02-10 04:07 -0500 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/71ff554d45cd Merge - src/solaris/bin/java_md.c Changeset: f11e2cb94154 Author: cgruszka Date: 2012-02-28 13:33 -0500 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/f11e2cb94154 Merge - src/macosx/bin/universal/jvm.cfg - src/share/classes/com/sun/management/DiagnosticCommandArgumentInfo.java - src/share/classes/com/sun/management/DiagnosticCommandInfo.java - test/com/sun/management/HotSpotDiagnosticMXBean/ExecuteDiagnosticCommand.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommandInfo.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommands.java Changeset: f9d88851f1fc Author: cgruszka Date: 2012-03-14 17:16 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/f9d88851f1fc Merge Changeset: 712ddd5cd31c Author: cgruszka Date: 2012-03-20 11:00 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/712ddd5cd31c Merge Changeset: c3a8fa474dab Author: cgruszka Date: 2012-03-28 10:24 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/c3a8fa474dab Merge - test/java/io/FileDescriptor/FileChannelFDTest.java Changeset: 42b162b2d764 Author: cgruszka Date: 2012-04-03 12:07 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/42b162b2d764 Merge Changeset: d1b9d039fb26 Author: cgruszka Date: 2012-04-06 10:54 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/d1b9d039fb26 Merge Changeset: a2f0e47299a7 Author: cgruszka Date: 2012-04-17 21:26 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/a2f0e47299a7 Merge Changeset: 791ad9acadef Author: cgruszka Date: 2012-04-18 23:54 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/791ad9acadef Merge Changeset: 3bf9fb6f6aba Author: skovatch Date: 2012-04-25 13:40 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/3bf9fb6f6aba 7128699: Change the bundle name so it won't be overwritten when installing a new version Reviewed-by: robilad ! make/common/Release-macosx.gmk Changeset: 224011dbdf1f Author: cgruszka Date: 2012-04-30 23:22 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/224011dbdf1f Merge ! make/common/Release-macosx.gmk Changeset: 9e4fcaae8175 Author: cgruszka Date: 2012-05-03 00:10 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/9e4fcaae8175 Merge From edvard.wendelin at oracle.com Mon May 7 00:50:00 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Mon, 07 May 2012 09:50:00 +0200 Subject: [7u6] request for approval, 7153184: NullPointerException when calling SSLEngineImpl.getSupportedCipherSuites In-Reply-To: <4FA47F98.6090106@oracle.com> References: <4FA47F98.6090106@oracle.com> Message-ID: <4FA77EA8.3010808@oracle.com> Approved. On 05/05/2012 03:17 AM, Xuelei Fan wrote: > Hi, > > This is a request to backport a JDK 8 fix into JDK 7u6: > 7153184: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7153184 > > The fix has already been pushed to JDK 8: > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41d3f7509e00 > > The code changes for jdk7u4 are identical to the ones in jdk8. > > We need to backport the fix to prevent multiple-thread-safe problems in > some applications. > > I intend to push it to > ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk > > Regards, > Xuelei From Alan.Bateman at oracle.com Mon May 7 01:03:39 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 07 May 2012 09:03:39 +0100 Subject: [7u6] request for approval, 7153184: NullPointerException when calling SSLEngineImpl.getSupportedCipherSuites In-Reply-To: <4FA77EA8.3010808@oracle.com> References: <4FA47F98.6090106@oracle.com> <4FA77EA8.3010808@oracle.com> Message-ID: <4FA781DB.9010403@oracle.com> Xuelei - can you hold off a day or two before pushing this to jdk7u-dev. I think that jdk8/tl picked up a problem last Friday, including one or two http server tests failing with an NPE in SSLSocketImpl.getEnabledCipherSuites. I think it would be good to track down these issues first, just in case they are a side effect of this fix. -Alan. On 07/05/2012 08:50, Edvard Wendelin wrote: > Approved. > > On 05/05/2012 03:17 AM, Xuelei Fan wrote: >> Hi, >> >> This is a request to backport a JDK 8 fix into JDK 7u6: >> 7153184: >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7153184 >> >> The fix has already been pushed to JDK 8: >> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41d3f7509e00 >> >> The code changes for jdk7u4 are identical to the ones in jdk8. >> >> We need to backport the fix to prevent multiple-thread-safe problems in >> some applications. >> >> I intend to push it to >> ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk >> >> Regards, >> Xuelei From chris.gruszka at oracle.com Mon May 7 07:00:51 2012 From: chris.gruszka at oracle.com (Chris Gruszka) Date: Mon, 07 May 2012 10:00:51 -0400 Subject: jdk7u6-b09: DS Message-ID: <4FA7D593.3010305@oracle.com> http://hg.openjdk.java.net/jdk7u/jdk7u/rev/01001f439af7 http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/3e268ea565ef http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/9e4fcaae8175 http://hg.openjdk.java.net/jdk7u/jdk7u/jaxws/rev/03a772c8b8fb http://hg.openjdk.java.net/jdk7u/jdk7u/jaxp/rev/52d82754ec69 http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/94d7a305da4d http://hg.openjdk.java.net/jdk7u/jdk7u/corba/rev/13faa12cfdd6 --- All the fixes will be tested during promotion (no PIT testing at this point): [jdk] 7128699: Change the bundle name so it won't be overwritten when installing a new version From david.katleman at oracle.com Mon May 7 13:02:27 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Mon, 07 May 2012 20:02:27 +0000 Subject: hg: jdk7u/jdk7u4: Added tag jdk7u4-b22 for changeset 3e92586871d9 Message-ID: <20120507200227.64B754719F@hg.openjdk.java.net> Changeset: 0faf04aa1dd4 Author: katleman Date: 2012-05-07 12:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/rev/0faf04aa1dd4 Added tag jdk7u4-b22 for changeset 3e92586871d9 ! .hgtags From david.katleman at oracle.com Mon May 7 13:02:31 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Mon, 07 May 2012 20:02:31 +0000 Subject: hg: jdk7u/jdk7u4/corba: Added tag jdk7u4-b22 for changeset 1b97d80df5c4 Message-ID: <20120507200231.ACC95471A0@hg.openjdk.java.net> Changeset: add54c4e4101 Author: katleman Date: 2012-05-07 12:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/corba/rev/add54c4e4101 Added tag jdk7u4-b22 for changeset 1b97d80df5c4 ! .hgtags From david.katleman at oracle.com Mon May 7 13:02:56 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Mon, 07 May 2012 20:02:56 +0000 Subject: hg: jdk7u/jdk7u4/hotspot: Added tag jdk7u4-b22 for changeset 1eb9f79307a8 Message-ID: <20120507200258.50821471A1@hg.openjdk.java.net> Changeset: aed9d0f0f050 Author: katleman Date: 2012-05-07 12:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/hotspot/rev/aed9d0f0f050 Added tag jdk7u4-b22 for changeset 1eb9f79307a8 ! .hgtags From david.katleman at oracle.com Mon May 7 13:03:59 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Mon, 07 May 2012 20:03:59 +0000 Subject: hg: jdk7u/jdk7u4/jaxp: Added tag jdk7u4-b22 for changeset 9de44cdaafe7 Message-ID: <20120507200401.BAC7A471A2@hg.openjdk.java.net> Changeset: 75ffe94cf0fb Author: katleman Date: 2012-05-07 12:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/jaxp/rev/75ffe94cf0fb Added tag jdk7u4-b22 for changeset 9de44cdaafe7 ! .hgtags From david.katleman at oracle.com Mon May 7 13:04:05 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Mon, 07 May 2012 20:04:05 +0000 Subject: hg: jdk7u/jdk7u4/jaxws: Added tag jdk7u4-b22 for changeset a404a5179e6a Message-ID: <20120507200405.DC941471A3@hg.openjdk.java.net> Changeset: 0d74be22a7c0 Author: katleman Date: 2012-05-07 12:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/jaxws/rev/0d74be22a7c0 Added tag jdk7u4-b22 for changeset a404a5179e6a ! .hgtags From david.katleman at oracle.com Mon May 7 13:04:13 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Mon, 07 May 2012 20:04:13 +0000 Subject: hg: jdk7u/jdk7u4/jdk: Added tag jdk7u4-b22 for changeset 42ca70fcb2ce Message-ID: <20120507200424.8EA3F471A4@hg.openjdk.java.net> Changeset: 3e2214ca5666 Author: katleman Date: 2012-05-07 12:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/jdk/rev/3e2214ca5666 Added tag jdk7u4-b22 for changeset 42ca70fcb2ce ! .hgtags From david.katleman at oracle.com Mon May 7 13:05:28 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Mon, 07 May 2012 20:05:28 +0000 Subject: hg: jdk7u/jdk7u4/langtools: Added tag jdk7u4-b22 for changeset 79cee842266b Message-ID: <20120507200530.6EEC6471A5@hg.openjdk.java.net> Changeset: 862c6e4b2652 Author: katleman Date: 2012-05-07 13:00 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/langtools/rev/862c6e4b2652 Added tag jdk7u4-b22 for changeset 79cee842266b ! .hgtags From dalibor.topic at oracle.com Tue May 8 01:20:00 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Tue, 08 May 2012 10:20:00 +0200 Subject: [7u4] .jar association broken on Windows In-Reply-To: References: <4FA2C570.9070101@oracle.com> Message-ID: <4FA8D730.9050502@oracle.com> On 5/4/12 12:01 AM, Alex Lam S.L. wrote: > Thanks for looking into it. Will wait for the fix before evaluating > migration to JavaSE 7. The bug[0] that caused this problem has been fixed, a new version of 7u4 (build 22) for Windows has been posted on OTN and on java.com. Thanks for reporting this issue. cheers, dalibor topic [0] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7165926 -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From dalibor.topic at oracle.com Tue May 8 02:03:35 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Tue, 08 May 2012 11:03:35 +0200 Subject: hg: jdk7u/jdk7u4: Added tag jdk7u4-b22 for changeset 3e92586871d9 In-Reply-To: <20120507200227.64B754719F@hg.openjdk.java.net> References: <20120507200227.64B754719F@hg.openjdk.java.net> Message-ID: <4FA8E167.6090700@oracle.com> On 5/7/12 10:02 PM, david.katleman at oracle.com wrote: > Changeset: 0faf04aa1dd4 > Author: katleman > Date: 2012-05-07 12:59 -0700 > URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/rev/0faf04aa1dd4 > > Added tag jdk7u4-b22 for changeset 3e92586871d9 > > ! .hgtags > In case that you're wondering why those tags appeared in 7u4 forests even though the 7u4 release is done [0], it's because of a bugfix & rebuild [1] of Oracle JDK/JRE 7u4 release - Alex Lam found a bug that manifests itself in the closed sources only, i.e. there was & is nothing to fix in OpenJDK. cheers, dalibor topic [0] http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-April/002818.html [1] http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-May/002893.html -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From david.katleman at oracle.com Tue May 8 10:02:43 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 08 May 2012 17:02:43 +0000 Subject: hg: jdk7u/jdk7u4: Added tag jdk7u4-b31 for changeset 0faf04aa1dd4 Message-ID: <20120508170243.5B585471BE@hg.openjdk.java.net> Changeset: 22e65a573ef9 Author: katleman Date: 2012-05-07 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/rev/22e65a573ef9 Added tag jdk7u4-b31 for changeset 0faf04aa1dd4 ! .hgtags From david.katleman at oracle.com Tue May 8 10:02:47 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 08 May 2012 17:02:47 +0000 Subject: hg: jdk7u/jdk7u4/corba: Added tag jdk7u4-b31 for changeset add54c4e4101 Message-ID: <20120508170249.13A33471BF@hg.openjdk.java.net> Changeset: 6546ee04b833 Author: katleman Date: 2012-05-07 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/corba/rev/6546ee04b833 Added tag jdk7u4-b31 for changeset add54c4e4101 ! .hgtags From david.katleman at oracle.com Tue May 8 10:03:21 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 08 May 2012 17:03:21 +0000 Subject: hg: jdk7u/jdk7u4/hotspot: Added tag jdk7u4-b31 for changeset aed9d0f0f050 Message-ID: <20120508170325.F0B07471C0@hg.openjdk.java.net> Changeset: f11f0f1db115 Author: katleman Date: 2012-05-07 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/hotspot/rev/f11f0f1db115 Added tag jdk7u4-b31 for changeset aed9d0f0f050 ! .hgtags From david.katleman at oracle.com Tue May 8 10:04:47 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 08 May 2012 17:04:47 +0000 Subject: hg: jdk7u/jdk7u4/jaxp: Added tag jdk7u4-b31 for changeset 75ffe94cf0fb Message-ID: <20120508170450.BEEE6471C1@hg.openjdk.java.net> Changeset: 88ec56907bb3 Author: katleman Date: 2012-05-07 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/jaxp/rev/88ec56907bb3 Added tag jdk7u4-b31 for changeset 75ffe94cf0fb ! .hgtags From david.katleman at oracle.com Tue May 8 10:04:55 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 08 May 2012 17:04:55 +0000 Subject: hg: jdk7u/jdk7u4/jaxws: Added tag jdk7u4-b31 for changeset 0d74be22a7c0 Message-ID: <20120508170455.5B9C5471C2@hg.openjdk.java.net> Changeset: 0f88c2a79698 Author: katleman Date: 2012-05-07 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/jaxws/rev/0f88c2a79698 Added tag jdk7u4-b31 for changeset 0d74be22a7c0 ! .hgtags From david.katleman at oracle.com Tue May 8 10:05:03 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 08 May 2012 17:05:03 +0000 Subject: hg: jdk7u/jdk7u4/jdk: Added tag jdk7u4-b31 for changeset 3e2214ca5666 Message-ID: <20120508170524.34C42471C3@hg.openjdk.java.net> Changeset: 7daf4a4dee76 Author: katleman Date: 2012-05-07 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/jdk/rev/7daf4a4dee76 Added tag jdk7u4-b31 for changeset 3e2214ca5666 ! .hgtags From david.katleman at oracle.com Tue May 8 10:06:35 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 08 May 2012 17:06:35 +0000 Subject: hg: jdk7u/jdk7u4/langtools: Added tag jdk7u4-b31 for changeset 862c6e4b2652 Message-ID: <20120508170640.0077D471C4@hg.openjdk.java.net> Changeset: 5c1d85a2ac57 Author: katleman Date: 2012-05-07 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/langtools/rev/5c1d85a2ac57 Added tag jdk7u4-b31 for changeset 862c6e4b2652 ! .hgtags From Abhi.Saha at Oracle.COM Tue May 8 13:15:58 2012 From: Abhi.Saha at Oracle.COM (Abhijit Saha) Date: Tue, 08 May 2012 13:15:58 -0700 Subject: hg: jdk7u/jdk7u4: Added tag jdk7u4-b31 for changeset 0faf04aa1dd4 In-Reply-To: <20120508170243.5B585471BE@hg.openjdk.java.net> References: <20120508170243.5B585471BE@hg.openjdk.java.net> Message-ID: <4FA97EFE.9060907@Oracle.COM> On 5/8/2012 10:02 AM, david.katleman at oracle.com wrote: > Changeset: 22e65a573ef9 > Author: katleman > Date: 2012-05-07 14:59 -0700 > URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/rev/22e65a573ef9 > > Added tag jdk7u4-b31 for changeset 0faf04aa1dd4 > > ! .hgtags In case that you're wondering why those tags appeared in 7u4 forests even though the 7u4 release is done [0], it's because of a bugfix& rebuild [1] of Oracle JDK/JRE 7u4 release for customers - Alex Lam found a bug that manifests itself in the closed sources only, i.e. there was& is nothing to fix in OpenJDK. Cheers, Abhijit Saha [0]http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-April/002818.html [1]http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-May/002893.html -- Release Lead, Java SE Updates Java Platform Group Oracle Corporation. (408)276-7564 From mike.duigou at oracle.com Tue May 8 15:38:15 2012 From: mike.duigou at oracle.com (Mike Duigou) Date: Tue, 8 May 2012 15:38:15 -0700 Subject: 7u6] request for approval, 7149320 : Move sun.misc.VM.booted() to end of System.initializeSystemClass() Message-ID: <1DF2822C-59A8-47FF-B49D-936BD1874A8E@oracle.com> Hi, This is a request to backport a JDK 8 fix into JDK 7u6: 7149320 : Move sun.misc.VM.booted() to end of System.initializeSystemClass() The fix has already been pushed to JDK 8: http://hg.openjdk.java.net/jdk8/tl-gate/jdk/rev/971a86421f51 The code changes for jdk7u6 are identical to the ones in jdk8. We need to backport this fix in anticipation of another fix which will be going in later. I intend to push it to ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk Mike From xuelei.fan at oracle.com Tue May 8 18:42:03 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 09 May 2012 09:42:03 +0800 Subject: [7u6] request for approval, 7166570: JSSE certificate validation has started to fail for certificate chains Message-ID: <4FA9CB6B.4000108@oracle.com> Hi, This is a request to backport a JDK 8 fix into JDK 7u6: 7166570: JSSE certificate validation has started to fail for certificate chains The fix has already been pushed to JDK 8: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f63f3390ac9 The code changes for jdk7u6 are identical to the ones in jdk8. We need to backport the fix so that the certificate validation works as expected. The impact of the bug is significant, some applications relies on the validation may not work without the fix. I intend to push it to ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk Regards, Xuelei From edvard.wendelin at oracle.com Wed May 9 03:35:39 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Wed, 09 May 2012 12:35:39 +0200 Subject: 7u6] request for approval, 7149320 : Move sun.misc.VM.booted() to end of System.initializeSystemClass() In-Reply-To: <1DF2822C-59A8-47FF-B49D-936BD1874A8E@oracle.com> References: <1DF2822C-59A8-47FF-B49D-936BD1874A8E@oracle.com> Message-ID: <4FAA487B.3060803@oracle.com> Approved. On 05/09/2012 12:38 AM, Mike Duigou wrote: > Hi, > > This is a request to backport a JDK 8 fix into JDK 7u6: > 7149320 : Move sun.misc.VM.booted() to end of System.initializeSystemClass() > > The fix has already been pushed to JDK 8: > http://hg.openjdk.java.net/jdk8/tl-gate/jdk/rev/971a86421f51 > > The code changes for jdk7u6 are identical to the ones in jdk8. > > We need to backport this fix in anticipation of another fix which will be going in later. > > I intend to push it to > ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk > > Mike From edvard.wendelin at oracle.com Wed May 9 03:36:01 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Wed, 09 May 2012 12:36:01 +0200 Subject: [7u6] request for approval, 7166570: JSSE certificate validation has started to fail for certificate chains In-Reply-To: <4FA9CB6B.4000108@oracle.com> References: <4FA9CB6B.4000108@oracle.com> Message-ID: <4FAA4891.1060508@oracle.com> Approved. On 05/09/2012 03:42 AM, Xuelei Fan wrote: > Hi, > > This is a request to backport a JDK 8 fix into JDK 7u6: > 7166570: JSSE certificate validation has started to fail for > certificate chains > > The fix has already been pushed to JDK 8: > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f63f3390ac9 > > The code changes for jdk7u6 are identical to the ones in jdk8. > > We need to backport the fix so that the certificate validation works as > expected. The impact of the bug is significant, some applications relies > on the validation may not work without the fix. > > I intend to push it to > ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk > > Regards, > Xuelei From wolfgang at skytide.com Wed May 9 02:15:24 2012 From: wolfgang at skytide.com (Wolfgang Hoschek) Date: Wed, 9 May 2012 02:15:24 -0700 Subject: regression: jdk1.7.0_04 java.net.InetAddress.getLocalHost().getHostName() return FQHN Message-ID: <3E0854C1-1CEE-4467-AA7C-036699E6AA42@skytide.com> [7u6] In jdk1.7.0_04 GA java.net.InetAddress.getLocalHost().getHostName() return the fully qualified host name (e.g. "ip-10-172-17-93.us-west-1.compute.internal") instead of returning the hostname without the domain (e.g. "ip-10-172-17-93"). This is a regression wrt. all prior versions of jdk 1.7 and jdk 1.6. This breaks applications that expect the old behavior. I have filed a bugzilla issue here: https://bugs.openjdk.java.net/show_bug.cgi?id=100253 Can anyone shade some light on how this came about? Thanks, Wolfgang From Alan.Bateman at oracle.com Wed May 9 05:02:53 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 09 May 2012 13:02:53 +0100 Subject: regression: jdk1.7.0_04 java.net.InetAddress.getLocalHost().getHostName() return FQHN In-Reply-To: <3E0854C1-1CEE-4467-AA7C-036699E6AA42@skytide.com> References: <3E0854C1-1CEE-4467-AA7C-036699E6AA42@skytide.com> Message-ID: <4FAA5CED.4000409@oracle.com> On 09/05/2012 10:15, Wolfgang Hoschek wrote: > [7u6] In jdk1.7.0_04 GA java.net.InetAddress.getLocalHost().getHostName() return the fully qualified host name (e.g. "ip-10-172-17-93.us-west-1.compute.internal") instead of returning the hostname without the domain (e.g. "ip-10-172-17-93"). This is a regression wrt. all prior versions of jdk 1.7 and jdk 1.6. This breaks applications that expect the old behavior. > This isn't really a bug, it's always been possible for getHostName to return the FQHN, it's just been very platform and configuration specific. However there was a behavior change on Linux and Mac in 7u4 and jdk8 that came via the addition of the Mac port. He has already been fixed in jdk8 as 7166687 [1] and I believe Rob intends to get it into jdk7u too. -Alan [1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b26c04717735 From wolfgang at skytide.com Wed May 9 10:21:50 2012 From: wolfgang at skytide.com (Wolfgang Hoschek) Date: Wed, 9 May 2012 10:21:50 -0700 Subject: regression: jdk1.7.0_04 java.net.InetAddress.getLocalHost().getHostName() return FQHN In-Reply-To: <4FAA5CED.4000409@oracle.com> References: <3E0854C1-1CEE-4467-AA7C-036699E6AA42@skytide.com> <4FAA5CED.4000409@oracle.com> Message-ID: Hi Alan, Thanks for letting me know. I strongly encourage you all to revert the behavioral change on Linux and Mac not just in jdk8 but also in jdk7u as well. This critical java regression prevents us from upgrading to jdk1.7.0_04. Best regards, Wolfgang. On May 9, 2012, at 5:02 AM, Alan Bateman wrote: > On 09/05/2012 10:15, Wolfgang Hoschek wrote: >> [7u6] In jdk1.7.0_04 GA java.net.InetAddress.getLocalHost().getHostName() return the fully qualified host name (e.g. "ip-10-172-17-93.us-west-1.compute.internal") instead of returning the hostname without the domain (e.g. "ip-10-172-17-93"). This is a regression wrt. all prior versions of jdk 1.7 and jdk 1.6. This breaks applications that expect the old behavior. >> > This isn't really a bug, it's always been possible for getHostName to return the FQHN, it's just been very platform and configuration specific. However there was a behavior change on Linux and Mac in 7u4 and jdk8 that came via the addition of the Mac port. He has already been fixed in jdk8 as 7166687 [1] and I believe Rob intends to get it into jdk7u too. > > -Alan > > [1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b26c04717735 From rob.mckenna at oracle.com Wed May 9 10:31:39 2012 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 09 May 2012 18:31:39 +0100 Subject: regression: jdk1.7.0_04 java.net.InetAddress.getLocalHost().getHostName() return FQHN In-Reply-To: References: <3E0854C1-1CEE-4467-AA7C-036699E6AA42@skytide.com> <4FAA5CED.4000409@oracle.com> Message-ID: <4FAAA9FB.1010203@oracle.com> Hi Wolfgang, I've pushed this into 7u5 which will GA on the 12th of next month. I'll push it into the current jdk7u repo once I get a (positive) response to the approval mail I'm about to send. -Rob On 09/05/12 18:21, Wolfgang Hoschek wrote: > Hi Alan, > > Thanks for letting me know. I strongly encourage you all to revert the behavioral change on Linux and Mac not just in jdk8 but also in jdk7u as well. This critical java regression prevents us from upgrading to jdk1.7.0_04. > > Best regards, > Wolfgang. > > On May 9, 2012, at 5:02 AM, Alan Bateman wrote: > >> On 09/05/2012 10:15, Wolfgang Hoschek wrote: >>> [7u6] In jdk1.7.0_04 GA java.net.InetAddress.getLocalHost().getHostName() return the fully qualified host name (e.g. "ip-10-172-17-93.us-west-1.compute.internal") instead of returning the hostname without the domain (e.g. "ip-10-172-17-93"). This is a regression wrt. all prior versions of jdk 1.7 and jdk 1.6. This breaks applications that expect the old behavior. >>> >> This isn't really a bug, it's always been possible for getHostName to return the FQHN, it's just been very platform and configuration specific. However there was a behavior change on Linux and Mac in 7u4 and jdk8 that came via the addition of the Mac port. He has already been fixed in jdk8 as 7166687 [1] and I believe Rob intends to get it into jdk7u too. >> >> -Alan >> >> [1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b26c04717735 From rob.mckenna at oracle.com Wed May 9 10:37:03 2012 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 09 May 2012 18:37:03 +0100 Subject: [7u6] request for approval, 7166687: InetAddress.getLocalHost().getHostName() returns FQDN In-Reply-To: <1DF2822C-59A8-47FF-B49D-936BD1874A8E@oracle.com> References: <1DF2822C-59A8-47FF-B49D-936BD1874A8E@oracle.com> Message-ID: <4FAAAB3F.8010304@oracle.com> Hi, I'd like to request approval to push 7166687 into 7u6. Its a trivial change that fixes a regression caused by the MacOS work. It has already been pushed to jdk7u5& jdk8 (and is identical to that change) but I'd like to get it into open repo as soon as possible: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b26c04717735 -Rob From Alan.Bateman at oracle.com Wed May 9 11:01:11 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 09 May 2012 19:01:11 +0100 Subject: regression: jdk1.7.0_04 java.net.InetAddress.getLocalHost().getHostName() return FQHN In-Reply-To: References: <3E0854C1-1CEE-4467-AA7C-036699E6AA42@skytide.com> <4FAA5CED.4000409@oracle.com> Message-ID: <4FAAB0E7.8080303@oracle.com> On 09/05/2012 18:21, Wolfgang Hoschek wrote: > Hi Alan, > > Thanks for letting me know. I strongly encourage you all to revert the behavioral change on Linux and Mac not just in jdk8 but also in jdk7u as well. This critical java regression prevents us from upgrading to jdk1.7.0_04. > I'm sure Rob will reply you on this. In the mean-time you can workaround this by running with IPv6 disabled (-Djava.net.preferIPv4Stack=true). I would also encourage you to examine the code in question as it will likely not work on other platforms and configurations where the host name has a domain name. -Alan. From wolfgang at skytide.com Wed May 9 14:23:15 2012 From: wolfgang at skytide.com (Wolfgang Hoschek) Date: Wed, 9 May 2012 14:23:15 -0700 Subject: regression: jdk1.7.0_04 java.net.InetAddress.getLocalHost().getHostName() return FQHN In-Reply-To: <4FAAA9FB.1010203@oracle.com> References: <3E0854C1-1CEE-4467-AA7C-036699E6AA42@skytide.com> <4FAA5CED.4000409@oracle.com> <4FAAA9FB.1010203@oracle.com> Message-ID: <7DC83076-7A40-4FEA-B5A6-5830EA0C015C@skytide.com> Awesome! Thanks! Wolfgang. On May 9, 2012, at 10:31 AM, Rob McKenna wrote: > Hi Wolfgang, > > I've pushed this into 7u5 which will GA on the 12th of next month. I'll push it into the current jdk7u repo once I get a (positive) response to the approval mail I'm about to send. > > -Rob > > On 09/05/12 18:21, Wolfgang Hoschek wrote: >> Hi Alan, >> >> Thanks for letting me know. I strongly encourage you all to revert the behavioral change on Linux and Mac not just in jdk8 but also in jdk7u as well. This critical java regression prevents us from upgrading to jdk1.7.0_04. >> >> Best regards, >> Wolfgang. >> >> On May 9, 2012, at 5:02 AM, Alan Bateman wrote: >> >>> On 09/05/2012 10:15, Wolfgang Hoschek wrote: >>>> [7u6] In jdk1.7.0_04 GA java.net.InetAddress.getLocalHost().getHostName() return the fully qualified host name (e.g. "ip-10-172-17-93.us-west-1.compute.internal") instead of returning the hostname without the domain (e.g. "ip-10-172-17-93"). This is a regression wrt. all prior versions of jdk 1.7 and jdk 1.6. This breaks applications that expect the old behavior. >>>> >>> This isn't really a bug, it's always been possible for getHostName to return the FQHN, it's just been very platform and configuration specific. However there was a behavior change on Linux and Mac in 7u4 and jdk8 that came via the addition of the Mac port. He has already been fixed in jdk8 as 7166687 [1] and I believe Rob intends to get it into jdk7u too. >>> >>> -Alan >>> >>> [1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b26c04717735 From xuelei.fan at oracle.com Wed May 9 19:11:18 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Thu, 10 May 2012 02:11:18 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7153184: NullPointerException when calling SSLEngineImpl.getSupportedCipherSuites Message-ID: <20120510021128.A68BA47214@hg.openjdk.java.net> Changeset: 996fd01472ee Author: xuelei Date: 2012-05-08 19:44 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/996fd01472ee 7153184: NullPointerException when calling SSLEngineImpl.getSupportedCipherSuites Reviewed-by: weijun, dholmes ! src/share/classes/sun/security/ssl/SSLContextImpl.java From edvard.wendelin at oracle.com Wed May 9 22:21:50 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Thu, 10 May 2012 07:21:50 +0200 Subject: [7u6] request for approval, 7166687: InetAddress.getLocalHost().getHostName() returns FQDN In-Reply-To: <4FAAAB3F.8010304@oracle.com> References: <1DF2822C-59A8-47FF-B49D-936BD1874A8E@oracle.com> <4FAAAB3F.8010304@oracle.com> Message-ID: Approved. On May 9, 2012, at 7:37 PM, Rob McKenna wrote: > Hi, > > I'd like to request approval to push 7166687 into 7u6. Its a trivial change that fixes a regression caused by the MacOS work. It has already been pushed to jdk7u5& jdk8 (and is identical to that change) but I'd like to get it into open repo as soon as possible: > > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b26c04717735 > > > -Rob > From david.holmes at oracle.com Wed May 9 22:29:03 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 10 May 2012 15:29:03 +1000 Subject: [7u6] request for approval, 7166687: InetAddress.getLocalHost().getHostName() returns FQDN In-Reply-To: References: <1DF2822C-59A8-47FF-B49D-936BD1874A8E@oracle.com> <4FAAAB3F.8010304@oracle.com> Message-ID: <4FAB521F.7090103@oracle.com> Is this going to be a push of the exact same changeset as 7u5, or a new changeset with the same content? David On 10/05/2012 3:21 PM, Edvard Wendelin wrote: > Approved. > > On May 9, 2012, at 7:37 PM, Rob McKenna wrote: > >> Hi, >> >> I'd like to request approval to push 7166687 into 7u6. Its a trivial change that fixes a regression caused by the MacOS work. It has already been pushed to jdk7u5& jdk8 (and is identical to that change) but I'd like to get it into open repo as soon as possible: >> >> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b26c04717735 >> >> >> -Rob >> > From henri.gomez at gmail.com Thu May 10 00:09:25 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Thu, 10 May 2012 09:09:25 +0200 Subject: Review OSX universal mode patch Message-ID: Hi to all Could someone review my patches to bring back universal mode (32/64bits) to OSX for OpenJDK 7 (u branch) http://openjdk-osx-build.googlecode.com/svn/trunk/patches-jdk7u-osx/universal-build.patch Now os.arch is reported as i386 if data.model is 32 and as x86_64 is data.model is 64bits. It should fix problem with JRuby : https://github.com/jruby/jruby/commit/9e05b5f1791917cdc3487b3ddfd78956c4bb92c0#commitcomment-1306674 Cheers From chris.hegarty at oracle.com Thu May 10 01:13:42 2012 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 10 May 2012 09:13:42 +0100 Subject: [7u6] request for approval, 7166687: InetAddress.getLocalHost().getHostName() returns FQDN In-Reply-To: <4FAB521F.7090103@oracle.com> References: <1DF2822C-59A8-47FF-B49D-936BD1874A8E@oracle.com> <4FAAAB3F.8010304@oracle.com> <4FAB521F.7090103@oracle.com> Message-ID: <4FAB78B6.8020203@oracle.com> On 10/05/2012 06:29, David Holmes wrote: > Is this going to be a push of the exact same changeset as 7u5, or a new > changeset with the same content? I'd like to see the '--exact' same changeset being imported into 7u6. We've done this before between 7u-dev and 7ux(stabilization) repositories and it worked well. Less work for integrators. -Chris. > > David > > On 10/05/2012 3:21 PM, Edvard Wendelin wrote: >> Approved. >> >> On May 9, 2012, at 7:37 PM, Rob McKenna wrote: >> >>> Hi, >>> >>> I'd like to request approval to push 7166687 into 7u6. Its a trivial >>> change that fixes a regression caused by the MacOS work. It has >>> already been pushed to jdk7u5& jdk8 (and is identical to that change) >>> but I'd like to get it into open repo as soon as possible: >>> >>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b26c04717735 >>> >>> >>> -Rob >>> >> From david.holmes at oracle.com Thu May 10 01:16:44 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 10 May 2012 18:16:44 +1000 Subject: Review OSX universal mode patch In-Reply-To: References: Message-ID: <4FAB796C.9050600@oracle.com> Hi Henri, On 10/05/2012 5:09 PM, Henri Gomez wrote: > Could someone review my patches to bring back universal mode > (32/64bits) to OSX for OpenJDK 7 (u branch) > > http://openjdk-osx-build.googlecode.com/svn/trunk/patches-jdk7u-osx/universal-build.patch > > Now os.arch is reported as i386 if data.model is 32 and as x86_64 is > data.model is 64bits. The setting of the os.arch property in src/solaris/native/java/lang/java_props_md.c should be handled by setting ARCHPROP appropriately in jdk/make/common/Platform.gmk, not by ifdefs in the C file. Can't comment on anything else as I don't grok this "universal" build business. David > It should fix problem with JRuby : > > https://github.com/jruby/jruby/commit/9e05b5f1791917cdc3487b3ddfd78956c4bb92c0#commitcomment-1306674 > > Cheers From henri.gomez at gmail.com Thu May 10 01:34:05 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Thu, 10 May 2012 10:34:05 +0200 Subject: Review OSX universal mode patch In-Reply-To: <4FAB796C.9050600@oracle.com> References: <4FAB796C.9050600@oracle.com> Message-ID: > Hi Henri, Hello David > The setting of the os.arch property in > src/solaris/native/java/lang/java_props_md.c should be handled by setting > ARCHPROP appropriately in jdk/make/common/Platform.gmk, not by ifdefs in the > C file. yes, but ARCHPROP is set to universal so 32 and 64 builds are performed. So there is really 2 copy of src/solaris/native/java/lang/java_props_md.c in binary, one for 32bits and one for 64bits. Note, it was the way macosx-port did it before all universal support was removed in jdk7 branch ;( > Can't comment on anything else as I don't grok this "universal" build > business. May be Mike or Scott, OSX experts, may take a look. This feature is highly awaited by OSX users, they used to have a dual mode VM. Simple question, did there is any interest here to support universal VM on OSX ? If not, I'll continue to maintain this patch and produce packages in such mode, but I think we all agree that It won't be good for OpenJDK for OSX to have various distributions with different behaviors and functionalities. From david.holmes at oracle.com Thu May 10 01:42:04 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 10 May 2012 18:42:04 +1000 Subject: Review OSX universal mode patch In-Reply-To: References: <4FAB796C.9050600@oracle.com> Message-ID: <4FAB7F5C.6050702@oracle.com> On 10/05/2012 6:34 PM, Henri Gomez wrote: >> The setting of the os.arch property in >> src/solaris/native/java/lang/java_props_md.c should be handled by setting >> ARCHPROP appropriately in jdk/make/common/Platform.gmk, not by ifdefs in the >> C file. > > yes, but ARCHPROP is set to universal so 32 and 64 builds are performed. > So there is really 2 copy of > src/solaris/native/java/lang/java_props_md.c in binary, one for 32bits > and one for 64bits. I don't really understand the above. java_props_md.c must be compiled separately for a 32-bit and 64-bit build. So in the 32-bit build ARCHPROP should be set to i386, and in a 64-bit build it should be set to x86_64. LIBARCH might be "universal" in both cases (is it?) but ARCHPROP should reflect the actual value you want os.arch to report. Sorry if I'm misunderstanding the nuances of universal builds. > Note, it was the way macosx-port did it before all universal support > was removed in jdk7 branch ;( Yes, well the macosx port did a lot of things in ways that were less than desirable. A little got fixed for 7, a little more for 8. David ----- >> Can't comment on anything else as I don't grok this "universal" build >> business. > > May be Mike or Scott, OSX experts, may take a look. > > This feature is highly awaited by OSX users, they used to have a dual mode VM. > > Simple question, did there is any interest here to support universal VM on OSX ? > > If not, I'll continue to maintain this patch and produce packages in > such mode, but I think we all agree that It won't be good for OpenJDK > for OSX to have various distributions with different behaviors and > functionalities. From henri.gomez at gmail.com Thu May 10 01:59:20 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Thu, 10 May 2012 10:59:20 +0200 Subject: Review OSX universal mode patch In-Reply-To: <4FAB7F5C.6050702@oracle.com> References: <4FAB796C.9050600@oracle.com> <4FAB7F5C.6050702@oracle.com> Message-ID: > I don't really understand the above. java_props_md.c must be compiled > separately for a 32-bit and 64-bit build. So in the 32-bit build ARCHPROP > should be set to i386, and in a 64-bit build it should be set to x86_64. > LIBARCH might be "universal" in both cases (is it?) but ARCHPROP should > reflect the actual value you want os.arch to report. ARCHPROP set to universal activate dual build mode . ... /Applications/Xcode.app/Contents/Developer/usr/bin/llvm-gcc -Os -x objective-c -fno-strict-aliasing -fPIC -W -Wall -Wno-unused -Wno-parentheses -arch i386 -arch x86_64 -D_LITTLE_ENDIAN -F/System/Library/Frameworks/JavaVM.framework/Frameworks -F/System/Library/Frameworks/ApplicationServices.framework/Frameworks -DJDK_MAJOR_VERSION='"1"' -DJDK_MINOR_VERSION='"7"' -DJDK_MICRO_VERSION='"0"' -DJDK_BUILD_NUMBER='"20120509"' -DNDEBUG -DARCH='"universal"' -Duniversal -D_ALLBSD_SOURCE -DRELEASE='"1.7.0-jdk7u6-b08"' -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -D_REENTRANT -DMACOSX -I. -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/build/macosx-universal/tmp/java/java.lang/java/CClassHeaders -I../../../src/solaris/javavm/export -I../../../src/share/javavm/export -I../../../src/share/native/java/lang/fdlibm/include -I../../../src/share/native/java/io -I../../../src/solaris/native/java/io -I../../../src/solaris/native/java/util -I../../../src/share/native/common -I../../../src/solaris/native/common -I../../../src/share/native/java/lang -I../../../src/solaris/native/java/lang -DRELEASE='"1.7.0-jdk7u6-b08"' -DARCHPROPNAME='"universal"' -DALT_CODESET_KEY=_NL_CTYPE_CODESET_NAME -c -o /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/build/macosx-universal/tmp/java/java.lang/java/obj/java_props_md.o ../../../src/solaris/native/java/lang/java_props_md.c Dual build mode > Sorry if I'm misunderstanding the nuances of universal builds. 32 and 64bits build mode. See http://ngmarley.com/blog/osx-universal-binary/ (except PPC not related here). -arch x86_64 and -arch i386 added to compile / link time allow this dual build mode. >> Note, it was the way macosx-port did it before all universal support >> was removed in jdk7 branch ;( > > Yes, well the macosx port did a lot of things in ways that were less than > desirable. A little got fixed for 7, a little more for 8. Question remains, could we expect a 32/64 bits JVM from OpenJDK for OSX ? From david.holmes at oracle.com Thu May 10 02:24:53 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 10 May 2012 19:24:53 +1000 Subject: Review OSX universal mode patch In-Reply-To: References: <4FAB796C.9050600@oracle.com> <4FAB7F5C.6050702@oracle.com> Message-ID: <4FAB8965.8020408@oracle.com> On 10/05/2012 6:59 PM, Henri Gomez wrote: >> I don't really understand the above. java_props_md.c must be compiled >> separately for a 32-bit and 64-bit build. So in the 32-bit build ARCHPROP >> should be set to i386, and in a 64-bit build it should be set to x86_64. >> LIBARCH might be "universal" in both cases (is it?) but ARCHPROP should >> reflect the actual value you want os.arch to report. > > ARCHPROP set to universal activate dual build mode . That seems wrong in itself. ARCHPROP is only supposed to hold the value to use for the property os.arch. Anything that actually controls the build "architecture" should be using one of the (many) other "arch" flags. > ... > > Dual build mode > >> Sorry if I'm misunderstanding the nuances of universal builds. > > 32 and 64bits build mode. > > See http://ngmarley.com/blog/osx-universal-binary/ (except PPC not > related here). > > -arch x86_64 and -arch i386 added to compile / link time allow this > dual build mode. I see. The reference above states: "First, the code must be compiled for each architecture (i386, ppc and x86_64). Each compilation will result in a separate executable (binary) file. Then use lipo to merge them into a universal binary." If it were truly separate compilation then there would not be a problem. So I assume that objective-c's dual build mode actual does two distinct compilations using a single invocation. That is both somewhat clever and truly horrible. :( Can you actually build hotspot using this dual mode? I would expect we have a lot of build flags where the value changes depending on whether 32-bit or 64-bit. >>> Note, it was the way macosx-port did it before all universal support >>> was removed in jdk7 branch ;( >> >> Yes, well the macosx port did a lot of things in ways that were less than >> desirable. A little got fixed for 7, a little more for 8. > > Question remains, could we expect a 32/64 bits JVM from OpenJDK for OSX ? Not a question I have any input on - sorry. David ----- From henri.gomez at gmail.com Thu May 10 02:47:02 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Thu, 10 May 2012 11:47:02 +0200 Subject: Review OSX universal mode patch In-Reply-To: <4FAB8965.8020408@oracle.com> References: <4FAB796C.9050600@oracle.com> <4FAB7F5C.6050702@oracle.com> <4FAB8965.8020408@oracle.com> Message-ID: > That seems wrong in itself. ARCHPROP is only supposed to hold the value to > use for the property os.arch. Anything that actually controls the build > "architecture" should be using one of the (many) other "arch" flags. When settings ARCHPROP to x86_64, -d32 flag is no more available. java -d32 Error: This Java instance does not support a 32-bit JVM. Please install the desired version. It was a feature on Apple JVM and for many applications, there is just no need for a 64bits JVM. > I see. The reference above states: > > "First, the code must be compiled for each architecture (i386, ppc and > x86_64). Each compilation will result in a separate executable (binary) > file. > Then use lipo to merge them into a universal binary." > > If it were truly separate compilation then there would not be a problem. So > I assume that objective-c's dual build mode actual does two distinct > compilations using a single invocation. That is both somewhat clever and > truly horrible. :( Can you actually build hotspot using this dual mode? I > would expect we have a lot of build flags where the value changes depending > on whether 32-bit or 64-bit. I know, but there was a somewhat large effort on macosx-port to support that and my patches mainly reintroduce them. >> Question remains, could we expect a 32/64 bits JVM from OpenJDK for OSX ? > > Not a question I have any input on - sorry. Who could answer to such question ? From dalibor.topic at oracle.com Thu May 10 03:02:54 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Thu, 10 May 2012 12:02:54 +0200 Subject: Review OSX universal mode patch In-Reply-To: References: <4FAB796C.9050600@oracle.com> Message-ID: <4FAB924E.8070104@oracle.com> On 5/10/12 10:34 AM, Henri Gomez wrote: > Simple question, did there is any interest here to support universal VM on OSX ? I haven't seen anyone here sign up to maintain a universal/32 bit 7u on Mac OS X so far. Without a plausible commitment to do that work, I don't think that it makes sense to add a new platform to this Project. cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From david.holmes at oracle.com Thu May 10 03:07:12 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 10 May 2012 20:07:12 +1000 Subject: Review OSX universal mode patch In-Reply-To: References: <4FAB796C.9050600@oracle.com> <4FAB7F5C.6050702@oracle.com> <4FAB8965.8020408@oracle.com> Message-ID: <4FAB9350.3020401@oracle.com> On 10/05/2012 7:47 PM, Henri Gomez wrote: >> That seems wrong in itself. ARCHPROP is only supposed to hold the value to >> use for the property os.arch. Anything that actually controls the build >> "architecture" should be using one of the (many) other "arch" flags. > > When settings ARCHPROP to x86_64, -d32 flag is no more available. > > java -d32 > Error: This Java instance does not support a 32-bit JVM. > Please install the desired version. > > It was a feature on Apple JVM and for many applications, there is just > no need for a 64bits JVM. This kind of launch duality is normally handled by the launcher (and was only supported on Solaris previously). I don't know how the osx launcher was "modified" to try and work with this. >> I see. The reference above states: >> >> "First, the code must be compiled for each architecture (i386, ppc and >> x86_64). Each compilation will result in a separate executable (binary) >> file. >> Then use lipo to merge them into a universal binary." >> >> If it were truly separate compilation then there would not be a problem. So >> I assume that objective-c's dual build mode actual does two distinct >> compilations using a single invocation. That is both somewhat clever and >> truly horrible. :( Can you actually build hotspot using this dual mode? I >> would expect we have a lot of build flags where the value changes depending >> on whether 32-bit or 64-bit. > > I know, but there was a somewhat large effort on macosx-port to > support that and my patches mainly reintroduce them. > >>> Question remains, could we expect a 32/64 bits JVM from OpenJDK for OSX ? >> >> Not a question I have any input on - sorry. > > Who could answer to such question ? I'm not sure in what sense you are asking it - expect of whom? Henrik Stahl already made a statement on this: https://blogs.oracle.com/henrik/entry/oracle_jdk_and_javafx_sdk "What if I want a 32-bit JVM, or support for older PPC-based Macs? There are community efforts based on OpenJDK to build JDK 7 for other configurations, easily found using your favorite search engine. We applaud these efforts! :-)" Cheers, David From henri.gomez at gmail.com Thu May 10 04:46:09 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Thu, 10 May 2012 13:46:09 +0200 Subject: Review OSX universal mode patch In-Reply-To: <4FAB9350.3020401@oracle.com> References: <4FAB796C.9050600@oracle.com> <4FAB7F5C.6050702@oracle.com> <4FAB8965.8020408@oracle.com> <4FAB9350.3020401@oracle.com> Message-ID: > I'm not sure in what sense you are asking it - expect of whom? Henrik Stahl > already made a statement on this: > > https://blogs.oracle.com/henrik/entry/oracle_jdk_and_javafx_sdk > > "What if I want a 32-bit JVM, or support for older PPC-based Macs? > There are community efforts based on OpenJDK to build JDK 7 for other > configurations, easily found using your favorite search engine. We applaud > these efforts! :-)" For PPC support, on older OSX, for now zero vm should be used. For 32bits support I just tried to build OSX in 32bits mode, providing ARCH=i386 and DATA_MODEL=32 and build fail : chmod +x test_gamma touch bsd_amd64_compiler2/profiled cd bsd_amd64_compiler2/product && make " LP64=1 " cd /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/build/macosx-i386/hotspot/outputdir/bsd_amd64_compiler2/product/../generated; cp /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/make/bsd/platform_amd64 /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/build/macosx-i386/hotspot/outputdir/bsd_amd64_compiler2/product/../generated/platform.current make[8]: *** No rule to make target `/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/src/cpu/i386/vm/x86_64.ad', needed by `../generated/adfiles/bsd_x86_64.ad'. Stop. make[8]: *** Waiting for unfinished jobs.... make[7]: *** [ad_stuff] Error 2 make[6]: *** [product] Error 2 make[5]: *** [generic_build2] Error 2 make[4]: *** [product] Error 2 make[3]: *** [all_product_universal] Error 2 make[2]: *** [universal_product] Error 2 make[1]: *** [hotspot-build] Error 2 make: *** [build_product_image] Error 2 Windows, Linux and Solaris came with 32 and 64bits JVM (at least from Oracle Java 7) but not OSX. If universal 32/64bits single build couldn't be done (and it was in macosx-port time), we should at least have a fun to build 32 and 64 bits JVM and provide 2 packages. I spent some time digging in build process to bring back universal mode and will eventually try to fix 32bits build failure for OSX but I don't want to waste more time if these patches are not reviewed, commented and applied if valid. Cheers From david.holmes at oracle.com Thu May 10 05:05:19 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 10 May 2012 22:05:19 +1000 Subject: Review OSX universal mode patch In-Reply-To: References: <4FAB796C.9050600@oracle.com> <4FAB7F5C.6050702@oracle.com> <4FAB8965.8020408@oracle.com> <4FAB9350.3020401@oracle.com> Message-ID: <4FABAEFF.4010301@oracle.com> On 10/05/2012 9:46 PM, Henri Gomez wrote: > I just tried to build OSX in 32bits mode, providing ARCH=i386 and > DATA_MODEL=32 and build fail : > > chmod +x test_gamma > touch bsd_amd64_compiler2/profiled > cd bsd_amd64_compiler2/product&& make " LP64=1 " LP64=1 shows this is not actually a 32-bit build; as does the fact it is using amd64. ARCH=i386 is generally not the correct value for 32-bit x86 builds. LIBARCH ends up as i386 but ARCH should be i586 (or i686) if I recall correctly for hotspot. Trying to force a 32-bit build when the host platform is 64-bit is a form of cross-compilation that doesn't presently work for any OpenJDK architecture (the JDK requires different settings to Hotspot). David ----- > cd /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/build/macosx-i386/hotspot/outputdir/bsd_amd64_compiler2/product/../generated; > cp /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/make/bsd/platform_amd64 > /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/build/macosx-i386/hotspot/outputdir/bsd_amd64_compiler2/product/../generated/platform.current > make[8]: *** No rule to make target > `/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/src/cpu/i386/vm/x86_64.ad', > needed by `../generated/adfiles/bsd_x86_64.ad'. Stop. > make[8]: *** Waiting for unfinished jobs.... > make[7]: *** [ad_stuff] Error 2 > make[6]: *** [product] Error 2 > make[5]: *** [generic_build2] Error 2 > make[4]: *** [product] Error 2 > make[3]: *** [all_product_universal] Error 2 > make[2]: *** [universal_product] Error 2 > make[1]: *** [hotspot-build] Error 2 > make: *** [build_product_image] Error 2 > > Windows, Linux and Solaris came with 32 and 64bits JVM (at least from > Oracle Java 7) but not OSX. > > If universal 32/64bits single build couldn't be done (and it was in > macosx-port time), we should at least have a fun to build 32 and 64 > bits JVM and provide 2 packages. > > I spent some time digging in build process to bring back universal > mode and will eventually try to fix 32bits build failure for OSX but I > don't want to waste more time if these patches are not reviewed, > commented and applied if valid. > > Cheers From Alan.Bateman at oracle.com Thu May 10 05:16:00 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 10 May 2012 13:16:00 +0100 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra Message-ID: <4FABB180.9020507@oracle.com> I hereby nominate Kurchi Subhra Hazra to jdk7u Committer. Kurchi has committer role in the jdk8 project but only author role on jdk7u. The following queries match most of her recent activity: http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=khazra http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=kurchi.subhra.hazra at oracle.com http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/log?rev=khazra http://hg.openjdk.java.net/jdk7u/jdk7u-osx/jdk/log?rev=khazra Votes are due by May 24, 2012, 09:00 PDT. Only current jdk7u Committers [1] are eligible to vote on this nomination. For Lazy Consensus voting instructions, see [2]. -Alan. [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote From henri.gomez at gmail.com Thu May 10 05:20:17 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Thu, 10 May 2012 14:20:17 +0200 Subject: Review OSX universal mode patch In-Reply-To: <4FABAEFF.4010301@oracle.com> References: <4FAB796C.9050600@oracle.com> <4FAB7F5C.6050702@oracle.com> <4FAB8965.8020408@oracle.com> <4FAB9350.3020401@oracle.com> <4FABAEFF.4010301@oracle.com> Message-ID: > LP64=1 shows this is not actually a 32-bit build; as does the fact it is > using amd64. > > ARCH=i386 is generally not the correct value for 32-bit x86 builds. LIBARCH > ends up as i386 but ARCH should be i586 (or i686) if I recall correctly for > hotspot. Trying to force a 32-bit build when the host platform is 64-bit is > a form of cross-compilation that doesn't presently work for any OpenJDK > architecture (the JDK requires different settings to Hotspot). providing ARCH=i586 produce same error : echo " DYLD_LIBRARY_PATH=.:${DYLD_LIBRARY_PATH:+$DYLD_LIBRARY_PATH:}\${JAVA_HOME}/jre/lib/native_threads:\${JAVA_HOME}/jre/lib:${DYLD_LIBRARY_PATH:+$DYLD_LIBRARY_PATH:}\${JAVA_HOME}/jre/lib/amd64/native_threads:\${JAVA_HOME}/jre/lib/amd64:"; \ echo " export DYLD_LIBRARY_PATH"; \ echo "fi"; \ echo ""; \ echo "# Use the gamma launcher and JAVA_HOME to run the test"; \ echo ""; \ echo "./\${GAMMA_PROG} -Xbatch -showversion Queens < /dev/null"; \ ) > test_gamma chmod +x test_gamma touch bsd_amd64_compiler2/profiled cd bsd_amd64_compiler2/product && make " LP64=1 " cd /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/build/macosx-i586/hotspot/outputdir/bsd_amd64_compiler2/product/../generated; cp /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/make/bsd/platform_amd64 /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/build/macosx-i586/hotspot/outputdir/bsd_amd64_compiler2/product/../generated/platform.current make[8]: *** No rule to make target `/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/src/cpu/i586/vm/x86_64.ad', needed by `../generated/adfiles/bsd_x86_64.ad'. Stop. make[8]: *** Waiting for unfinished jobs.... make[7]: *** [ad_stuff] Error 2 make[6]: *** [product] Error 2 make[5]: *** [generic_build2] Error 2 make[4]: *** [product] Error 2 make[3]: *** [all_product_universal] Error 2 make[2]: *** [universal_product] Error 2 make[1]: *** [hotspot-build] Error 2 make: *** [build_product_image] Error 2 LP64 is set even if 32bits mode is defined. chmod +x test_gamma touch bsd_amd64_compiler2/optimized [ -d bsd_amd64_compiler2/product ] || { mkdir -p bsd_amd64_compiler2/product; } cd bsd_amd64_compiler2/product && make -f /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/make/bsd/makefiles/buildtree.make Makefile flags.make flags_vm.make vm.make adlc.make jvmti.make sa.make dtrace.make env.sh env.csh jdkpath.sh .dbxrc test_gamma GAMMADIR=/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot OS_FAMILY=bsd SRCARCH=x86 BUILDARCH=amd64 LIBARCH=amd64 VARIANT=tiered HOTSPOT_RELEASE_VERSION=23.0-b21 HOTSPOT_BUILD_VERSION= JRE_RELEASE_VERSION=1.7.0-jdk7u6-b08-20120510 TARGET=product Creating Makefile ... ( \ echo "# Generated by /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/make/bsd/makefiles/buildtree.make"; \ echo; \ echo include flags.make; \ echo; \ echo "include \$(GAMMADIR)/make/bsd/makefiles/top.make"; \ ) > Makefile Creating flags.make ... ( \ echo "# Generated by /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/make/bsd/makefiles/buildtree.make"; \ echo; \ echo "Platform_file = /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/make/bsd/platform_amd64" | sed 's|/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot|$(GAMMADIR)|'; \ sed -n '/=/s/^ */Platform_/p' < /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/make/bsd/platform_amd64; \ echo; \ echo "GAMMADIR = /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot"; \ echo "SYSDEFS = \$(Platform_sysdefs)"; \ echo "SRCARCH = x86"; \ echo "BUILDARCH = amd64"; \ echo "LIBARCH = amd64"; \ echo "TARGET = product"; \ echo "HS_BUILD_VER = 23.0-b21"; \ echo "JRE_RELEASE_VER = 1.7.0-jdk7u6-b08-20120510"; \ echo "SA_BUILD_VERSION = 23.0-b21"; \ echo "HOTSPOT_BUILD_USER = henri"; \ From rob.mckenna at oracle.com Thu May 10 05:24:46 2012 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 10 May 2012 13:24:46 +0100 Subject: [7u6] request for approval, 7166687: InetAddress.getLocalHost().getHostName() returns FQDN In-Reply-To: <4FAB521F.7090103@oracle.com> References: <1DF2822C-59A8-47FF-B49D-936BD1874A8E@oracle.com> <4FAAAB3F.8010304@oracle.com> <4FAB521F.7090103@oracle.com> Message-ID: <4FABB38E.3010709@oracle.com> Likely the latter, but I'll talk to the integrator to see which is preferable. -Rob On 10/05/12 06:29, David Holmes wrote: > Is this going to be a push of the exact same changeset as 7u5, or a > new changeset with the same content? > > David > > On 10/05/2012 3:21 PM, Edvard Wendelin wrote: >> Approved. >> >> On May 9, 2012, at 7:37 PM, Rob McKenna wrote: >> >>> Hi, >>> >>> I'd like to request approval to push 7166687 into 7u6. Its a trivial >>> change that fixes a regression caused by the MacOS work. It has >>> already been pushed to jdk7u5& jdk8 (and is identical to that >>> change) but I'd like to get it into open repo as soon as possible: >>> >>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b26c04717735 >>> >>> >>> -Rob >>> >> From rob.mckenna at oracle.com Thu May 10 05:26:18 2012 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 10 May 2012 13:26:18 +0100 Subject: [7u6] request for approval, 7166687: InetAddress.getLocalHost().getHostName() returns FQDN In-Reply-To: <4FAB78B6.8020203@oracle.com> References: <1DF2822C-59A8-47FF-B49D-936BD1874A8E@oracle.com> <4FAAAB3F.8010304@oracle.com> <4FAB521F.7090103@oracle.com> <4FAB78B6.8020203@oracle.com> Message-ID: <4FABB3EA.40501@oracle.com> Ah, missed this. Great. I'll work it out. -Rob On 10/05/12 09:13, Chris Hegarty wrote: > On 10/05/2012 06:29, David Holmes wrote: >> Is this going to be a push of the exact same changeset as 7u5, or a new >> changeset with the same content? > > I'd like to see the '--exact' same changeset being imported into 7u6. > We've done this before between 7u-dev and 7ux(stabilization) > repositories and it worked well. Less work for integrators. > > -Chris. > >> >> David >> >> On 10/05/2012 3:21 PM, Edvard Wendelin wrote: >>> Approved. >>> >>> On May 9, 2012, at 7:37 PM, Rob McKenna wrote: >>> >>>> Hi, >>>> >>>> I'd like to request approval to push 7166687 into 7u6. Its a trivial >>>> change that fixes a regression caused by the MacOS work. It has >>>> already been pushed to jdk7u5& jdk8 (and is identical to that change) >>>> but I'd like to get it into open repo as soon as possible: >>>> >>>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b26c04717735 >>>> >>>> >>>> -Rob >>>> >>> From chris.hegarty at oracle.com Thu May 10 07:06:45 2012 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 10 May 2012 15:06:45 +0100 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABB180.9020507@oracle.com> References: <4FABB180.9020507@oracle.com> Message-ID: <4FABCB75.9090805@oracle.com> Vote: yes. -Chris. From henri.gomez at gmail.com Thu May 10 07:21:37 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Thu, 10 May 2012 16:21:37 +0200 Subject: Review OSX universal mode patch In-Reply-To: <4FAB924E.8070104@oracle.com> References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> Message-ID: > I haven't seen anyone here sign up to maintain a universal/32 bit 7u on Mac OS X so far. > Without a plausible commitment to do that work, I don't think that it makes sense to add a > new platform to this Project. To me it's an unilateral decision. Did someone ever ask to OSX users if they need have 32bits JVM, next to 64bits ? Or even if they want an universal 32/64bits VM like they used to have with Apple JVM 1.6 ? It's not the way an OpenSource project should deal with its community, users community and not the way I understand OSS. From alexander.zuev at oracle.com Thu May 10 07:24:40 2012 From: alexander.zuev at oracle.com (Alexander Zuev) Date: Thu, 10 May 2012 18:24:40 +0400 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABB180.9020507@oracle.com> References: <4FABB180.9020507@oracle.com> Message-ID: <7E6F0087-AD7B-448C-A346-BA727259D348@oracle.com> Vote: yes With best regards, Alexander Zuev 10.05.2012, ? 16:16, Alan Bateman ???????(?): > > I hereby nominate Kurchi Subhra Hazra to jdk7u Committer. > > Kurchi has committer role in the jdk8 project but only author role on jdk7u. > > The following queries match most of her recent activity: > > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=kurchi.subhra.hazra at oracle.com > http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk7u/jdk7u-osx/jdk/log?rev=khazra > > Votes are due by May 24, 2012, 09:00 PDT. > > Only current jdk7u Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > -Alan. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From daniel.daugherty at oracle.com Thu May 10 07:50:34 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 10 May 2012 08:50:34 -0600 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABB180.9020507@oracle.com> References: <4FABB180.9020507@oracle.com> Message-ID: <4FABD5BA.4060108@oracle.com> Vote: yes Dan On 5/10/12 6:16 AM, Alan Bateman wrote: > > I hereby nominate Kurchi Subhra Hazra to jdk7u Committer. > > Kurchi has committer role in the jdk8 project but only author role on > jdk7u. > > The following queries match most of her recent activity: > > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=kurchi.subhra.hazra at oracle.com > > http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk7u/jdk7u-osx/jdk/log?rev=khazra > > Votes are due by May 24, 2012, 09:00 PDT. > > Only current jdk7u Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > -Alan. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From joe.darcy at oracle.com Thu May 10 07:59:29 2012 From: joe.darcy at oracle.com (Joe Darcy) Date: Thu, 10 May 2012 07:59:29 -0700 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABB180.9020507@oracle.com> References: <4FABB180.9020507@oracle.com> Message-ID: <4FABD7D1.2040801@oracle.com> Vote: yes -Joe Alan Bateman wrote: > > I hereby nominate Kurchi Subhra Hazra to jdk7u Committer. > > Kurchi has committer role in the jdk8 project but only author role on > jdk7u. > > The following queries match most of her recent activity: > > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=kurchi.subhra.hazra at oracle.com > > http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk7u/jdk7u-osx/jdk/log?rev=khazra > > Votes are due by May 24, 2012, 09:00 PDT. > > Only current jdk7u Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > -Alan. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From Abhi.Saha at Oracle.COM Thu May 10 08:06:12 2012 From: Abhi.Saha at Oracle.COM (Abhijit Saha) Date: Thu, 10 May 2012 08:06:12 -0700 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABB180.9020507@oracle.com> References: <4FABB180.9020507@oracle.com> Message-ID: <4FABD964.3050208@Oracle.COM> Vote: yes On 5/10/2012 5:16 AM, Alan Bateman wrote: > > I hereby nominate Kurchi Subhra Hazra to jdk7u Committer. > > Kurchi has committer role in the jdk8 project but only author role on > jdk7u. > > The following queries match most of her recent activity: > > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=kurchi.subhra.hazra at oracle.com > > http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk7u/jdk7u-osx/jdk/log?rev=khazra > > Votes are due by May 24, 2012, 09:00 PDT. > > Only current jdk7u Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > -Alan. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote -- Release Lead, Java SE Updates Java Platform Group Oracle Corporation. (408)276-7564 From Lance.Andersen at oracle.com Thu May 10 08:05:03 2012 From: Lance.Andersen at oracle.com (Lance Andersen - Oracle) Date: Thu, 10 May 2012 11:05:03 -0400 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABB180.9020507@oracle.com> References: <4FABB180.9020507@oracle.com> Message-ID: <6275A79F-AE18-4D95-A2A1-5CCC620BCD50@oracle.com> Vote: yes Best lance On May 10, 2012, at 8:16 AM, Alan Bateman wrote: > > I hereby nominate Kurchi Subhra Hazra to jdk7u Committer. > > Kurchi has committer role in the jdk8 project but only author role on jdk7u. > > The following queries match most of her recent activity: > > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=kurchi.subhra.hazra at oracle.com > http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk7u/jdk7u-osx/jdk/log?rev=khazra > > Votes are due by May 24, 2012, 09:00 PDT. > > Only current jdk7u Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > -Alan. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com From swingler at apple.com Thu May 10 08:21:48 2012 From: swingler at apple.com (Mike Swingler) Date: Thu, 10 May 2012 08:21:48 -0700 Subject: Review OSX universal mode patch In-Reply-To: References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> Message-ID: <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> On May 10, 2012, at 7:21 AM, Henri Gomez wrote: >> I haven't seen anyone here sign up to maintain a universal/32 bit 7u on Mac OS X so far. >> Without a plausible commitment to do that work, I don't think that it makes sense to add a >> new platform to this Project. > > To me it's an unilateral decision. > > Did someone ever ask to OSX users if they need have 32bits JVM, next to 64bits ? > Or even if they want an universal 32/64bits VM like they used to have > with Apple JVM 1.6 ? > > It's not the way an OpenSource project should deal with its community, > users community and not the way I understand OSS. Frankly, an Open Source project is not run by it's users - it's run by it's developers. If no developers come forward to actively support 32-bit, then the only possible outcome is for it to be dropped. If this is unacceptable to the users, they may choose to become developers and either contribute their expertise, or fork the project. Apple provide a 32/64 Universal implementation, but Oracle has only committed to shipping a 64-bit only implementation for their proprietary product. The OpenJDK product should be build-able for 32 or 32/64 Universal by anyone else, and should accept contributions to it's maintenance, but if nobody is signing up to keep forward-porting the changes - they don't have a future. Am I missing something here? Mike Swingler Apple Inc. From dalibor.topic at oracle.com Thu May 10 08:23:30 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Thu, 10 May 2012 17:23:30 +0200 Subject: Review OSX universal mode patch In-Reply-To: References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> Message-ID: <4FABDD72.1000303@oracle.com> On 5/10/12 4:21 PM, Henri Gomez wrote: >> I haven't seen anyone here sign up to maintain a universal/32 bit 7u on Mac OS X so far. >> Without a plausible commitment to do that work, I don't think that it makes sense to add a >> new platform to this Project. > > To me it's an unilateral decision. Before you start posting more patches for review to this Project, I'm simply wondering if anyone has signed up to do the actual maintenance work on such a platform, assuming your port is complete, passes the corresponding compatibility tests, etc. Which leads me to the next question: Is your port complete and passes the corresponding compatibility tests? Obviously, if you're just starting out with a port, that's great, too, but in that case, this particular Project may not the right place for it, and you may find the bsd-port Project to be a much better place for more experimental porting efforts, for example. cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From headius at headius.com Thu May 10 08:33:37 2012 From: headius at headius.com (Charles Oliver Nutter) Date: Thu, 10 May 2012 10:33:37 -0500 Subject: Review OSX universal mode patch In-Reply-To: <4FAB8965.8020408@oracle.com> References: <4FAB796C.9050600@oracle.com> <4FAB7F5C.6050702@oracle.com> <4FAB8965.8020408@oracle.com> Message-ID: On Thu, May 10, 2012 at 4:24 AM, David Holmes wrote: >> ARCHPROP set to universal activate dual build mode . > > > That seems wrong in itself. ARCHPROP is only supposed to hold the value to > use for the property os.arch. Anything that actually controls the build > "architecture" should be using one of the (many) other "arch" flags. Thought I'd jump in to clarify why having "universal" in os.arch is undesirable, since I think I triggered this bug fix and discussion with a bug report from JRuby... In JRuby, we use the value of os.arch to know whether to load a 32 or 64-bit version of our libffi JNI wrapper, along with 32 or 64-bit versions of other libraries loaded by the user. When the universal build started reporting "universal", we had no way to know whether we were running in 32 or 64-bit mode without looking at sun.arch.data.model, a nonstandard property. I patched JRuby to use that when os.arch == "universal", but it's an ugly hack. I believe os.arch should reflect the data model the JVM is currently *running*, not the models (like universal) it was built for. Reporting universal is useful only if every library loaded is a universal binary, where reporting x86/i386/x86_64/amd64 will work for both loading appropriate non-universal libraries and for loading universal libraries (which won't care). FWIW, the Apple JDK5/6 builds all report actual CPU/data model they're running, even though they're all universal binaries. - Charlie From artem.ananiev at oracle.com Thu May 10 08:39:09 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Thu, 10 May 2012 19:39:09 +0400 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABB180.9020507@oracle.com> References: <4FABB180.9020507@oracle.com> Message-ID: <4FABE11D.1070201@oracle.com> Vote: yes. On 5/10/2012 4:16 PM, Alan Bateman wrote: > > I hereby nominate Kurchi Subhra Hazra to jdk7u Committer. > > Kurchi has committer role in the jdk8 project but only author role on > jdk7u. > > The following queries match most of her recent activity: > > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=kurchi.subhra.hazra at oracle.com > > http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk7u/jdk7u-osx/jdk/log?rev=khazra > > Votes are due by May 24, 2012, 09:00 PDT. > > Only current jdk7u Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > -Alan. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From henri.gomez at gmail.com Thu May 10 08:38:25 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Thu, 10 May 2012 17:38:25 +0200 Subject: Review OSX universal mode patch In-Reply-To: <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> Message-ID: > Frankly, an Open Source project is not run by it's users - it's run by it's developers. If no developers come forward to actively support 32-bit, then the only possible outcome is for it to be dropped. If this is unacceptable to the users, they may choose to become developers and either contribute their expertise, or fork the project. OpenSource project destination is not developers but users. Developers didn't code to please themselves but to provide a value and products to end users. And when you users are also Developers, Java developers, you could be confident they know what they want > Apple provide a 32/64 Universal implementation, but Oracle has only committed to shipping a 64-bit only implementation for their proprietary product. The OpenJDK product should be build-able for 32 or 32/64 Universal by anyone else, and should accept contributions to it's maintenance, but if nobody is signing up to keep forward-porting the changes - they don't have a future. All platforms supported by Oracle for Java 7 have both 32 and 64 JVM except OSX. There was a miss for OSX users community between Apple to Oracle transition., 32/64 bits support was available, they lost it, too bad. > Am I missing something here? Nothing, this question about 32/64 bits has been raised longtime ago, at time where OpenJDK 7 for OSX moved from macosx-port to jdk7u. I spend some time to see how to bring universal 32/64 bits support back, there is no interest here, end of game. I won't comment anymore this thread, I already asked Dalibor to drop my OCA and wait how I should resign officially from OpenJDK project. Cheers and long life OSS From michael.x.mcmahon at oracle.com Thu May 10 08:42:43 2012 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Thu, 10 May 2012 16:42:43 +0100 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABB180.9020507@oracle.com> References: <4FABB180.9020507@oracle.com> Message-ID: <4FABE1F3.2030905@oracle.com> Vote: yes From kumar.x.srinivasan at oracle.COM Thu May 10 08:48:37 2012 From: kumar.x.srinivasan at oracle.COM (Kumar Srinivasan) Date: Thu, 10 May 2012 08:48:37 -0700 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABB180.9020507@oracle.com> References: <4FABB180.9020507@oracle.com> Message-ID: <4FABE355.6050709@oracle.COM> Vote: yes > > I hereby nominate Kurchi Subhra Hazra to jdk7u Committer. > > Kurchi has committer role in the jdk8 project but only author role on > jdk7u. > > The following queries match most of her recent activity: > > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=kurchi.subhra.hazra at oracle.com > > http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk7u/jdk7u-osx/jdk/log?rev=khazra > > Votes are due by May 24, 2012, 09:00 PDT. > > Only current jdk7u Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > -Alan. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From dalibor.topic at oracle.com Thu May 10 08:51:49 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Thu, 10 May 2012 17:51:49 +0200 Subject: Review OSX universal mode patch In-Reply-To: <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> Message-ID: <4FABE415.8010801@oracle.com> On 5/10/12 5:21 PM, Mike Swingler wrote: >The OpenJDK product should be build-able for 32 or 32/64 Universal by anyone else, and should accept contributions to it's maintenance, but if nobody is signing up to keep forward-porting the changes - they don't have a future. > > Am I missing something here? That's why I'm asking the questions. I want to know what to expect - a single patch for some or other build issue, a full porting effort, or something else entirely. I'm a bit puzzled by the excitement, fwiw. ;) cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From dalibor.topic at oracle.com Thu May 10 08:56:00 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Thu, 10 May 2012 17:56:00 +0200 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABB180.9020507@oracle.com> References: <4FABB180.9020507@oracle.com> Message-ID: <4FABE510.701@oracle.com> Vote: Yes! cheers, dalibor topic On 5/10/12 2:16 PM, Alan Bateman wrote: > > I hereby nominate Kurchi Subhra Hazra to jdk7u Committer. > > Kurchi has committer role in the jdk8 project but only author role on jdk7u. > > The following queries match most of her recent activity: > > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=kurchi.subhra.hazra at oracle.com > http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk7u/jdk7u-osx/jdk/log?rev=khazra > > Votes are due by May 24, 2012, 09:00 PDT. > > Only current jdk7u Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > -Alan. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From headius at headius.com Thu May 10 09:05:18 2012 From: headius at headius.com (Charles Oliver Nutter) Date: Thu, 10 May 2012 11:05:18 -0500 Subject: Review OSX universal mode patch In-Reply-To: <4FABE415.8010801@oracle.com> References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> Message-ID: On Thu, May 10, 2012 at 10:51 AM, Dalibor Topic wrote: > On 5/10/12 5:21 PM, Mike Swingler wrote: >>The OpenJDK product should be build-able for 32 or 32/64 Universal by anyone else, and should accept contributions to it's maintenance, but if nobody is signing up to keep forward-porting the changes - they don't have a future. >> >> Am I missing something here? > > That's why I'm asking the questions. I want to know what to expect - > a single patch for some or other build issue, a full porting effort, > or something else entirely. Isn't that was OSS is about? You get what you can? :) Frankly, it seems a little silly to me to expect that anyone would even be capable of maintaining 32/universal OpenJDK builds for OS X unless you make the first step of making it *possible* to build 32/universal OpenJDK for OS X. Making them buildable seems like a first step, eh? For my part, I don't care much about universal builds, but since JRuby runs on platforms where users will be running 32-bit it is much more convenient for me to be able to confirm 32-bit behavior if there's a build for it. Universal is a simple way for me to have both in one install on OS X, so I can at least do most of my 32 vs 64-bit testing without booting into Linux or Windows. > I'm a bit puzzled by the excitement, fwiw. ;) Perhaps there's just a communication problem here... * Is there community interest in having 32/universal build support in OpenJDK on OS X? I think the answer is obviously yes. * Has anyone stepped up to provide patches to make 32/universal builds possible on OS X? The answer is also yes. * Does OpenJDK work in 32-bit or universal modes on OS X? "Works" is hard to answer definitively, without running the TCK, but *none* of Henri's builds (which you praised openly at FOSDEM, Dalibor) have run TCK either, right? So it "works" as well as any build of OpenJDK that hasn't run TCK, which is very likely *all* community builds in the wild. openjdk-osx-build is a valuable resource for any of us working on OS X, and it would be a terrible shame to lose it. - Charlie From xueming.shen at oracle.com Thu May 10 09:17:27 2012 From: xueming.shen at oracle.com (Xueming Shen) Date: Thu, 10 May 2012 09:17:27 -0700 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABB180.9020507@oracle.com> References: <4FABB180.9020507@oracle.com> Message-ID: <4FABEA17.7090007@oracle.com> Vote: yes On 05/10/2012 05:16 AM, Alan Bateman wrote: > > I hereby nominate Kurchi Subhra Hazra to jdk7u Committer. > > Kurchi has committer role in the jdk8 project but only author role on > jdk7u. > > The following queries match most of her recent activity: > > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=kurchi.subhra.hazra at oracle.com > > http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk7u/jdk7u-osx/jdk/log?rev=khazra > > Votes are due by May 24, 2012, 09:00 PDT. > > Only current jdk7u Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > -Alan. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From sean.coffey at oracle.com Thu May 10 09:18:21 2012 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Thu, 10 May 2012 17:18:21 +0100 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABB180.9020507@oracle.com> References: <4FABB180.9020507@oracle.com> Message-ID: <4FABEA4D.2010002@oracle.com> Vote: yes On 10/05/2012 13:16, Alan Bateman wrote: > > I hereby nominate Kurchi Subhra Hazra to jdk7u Committer. > > Kurchi has committer role in the jdk8 project but only author role on > jdk7u. > > The following queries match most of her recent activity: > > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=kurchi.subhra.hazra at oracle.com > > http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk7u/jdk7u-osx/jdk/log?rev=khazra > > Votes are due by May 24, 2012, 09:00 PDT. > > Only current jdk7u Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > -Alan. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From julien.ponge at gmail.com Thu May 10 09:20:32 2012 From: julien.ponge at gmail.com (Julien Ponge) Date: Thu, 10 May 2012 18:20:32 +0200 Subject: Review OSX universal mode patch In-Reply-To: References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> Message-ID: <0D1B60F9E36D431580DA26BDB22EA404@gmail.com> > Frankly, it seems a little silly to me to expect that anyone would > even be capable of maintaining 32/universal OpenJDK builds for OS X > unless you make the first step of making it *possible* to build > 32/universal OpenJDK for OS X. Making them buildable seems like a > first step, eh? > > +1 > * Is there community interest in having 32/universal build support in > OpenJDK on OS X? I think the answer is obviously yes. > * Has anyone stepped up to provide patches to make 32/universal builds > possible on OS X? The answer is also yes. > > Henri has done a fantastic job by making it possible to use Java 7 on the Mac, way before we could get any "official" pre-release of any sort. > * Does OpenJDK work in 32-bit or universal modes on OS X? "Works" is > hard to answer definitively, without running the TCK, but *none* of > Henri's builds (which you praised openly at FOSDEM, Dalibor) have run > TCK either, right? So it "works" as well as any build of OpenJDK that > hasn't run TCK, which is very likely *all* community builds in the > wild. > > Yes, I think most of us do not care about the build passing the TCK or not. We use such builds for development, hence "fresh" is better than "blessed". > openjdk-osx-build is a valuable resource for any of us working on OS > X, and it would be a terrible shame to lose it. > > Unfortunately it seems like it has already been lost... Cheers From mandy.chung at oracle.com Thu May 10 09:22:52 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 10 May 2012 09:22:52 -0700 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABB180.9020507@oracle.com> References: <4FABB180.9020507@oracle.com> Message-ID: <4FABEB5C.7090506@oracle.com> Vote: yes Mandy From swingler at apple.com Thu May 10 09:26:52 2012 From: swingler at apple.com (Mike Swingler) Date: Thu, 10 May 2012 09:26:52 -0700 Subject: Review OSX universal mode patch In-Reply-To: <0D1B60F9E36D431580DA26BDB22EA404@gmail.com> References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> <0D1B60F9E36D431580DA26BDB22EA404@gmail.com> Message-ID: <7BBF0CDA-03C3-496D-A72A-DF86A7C0A2F7@apple.com> On May 10, 2012, at 9:20 AM, Julien Ponge wrote: >> Frankly, it seems a little silly to me to expect that anyone would >> even be capable of maintaining 32/universal OpenJDK builds for OS X >> unless you make the first step of making it *possible* to build >> 32/universal OpenJDK for OS X. Making them buildable seems like a >> first step, eh? > > +1 >> * Is there community interest in having 32/universal build support in >> OpenJDK on OS X? I think the answer is obviously yes. >> * Has anyone stepped up to provide patches to make 32/universal builds >> possible on OS X? The answer is also yes. > > Henri has done a fantastic job by making it possible to use Java 7 on the Mac, way before we could get any "official" pre-release of any sort. >> * Does OpenJDK work in 32-bit or universal modes on OS X? "Works" is >> hard to answer definitively, without running the TCK, but *none* of >> Henri's builds (which you praised openly at FOSDEM, Dalibor) have run >> TCK either, right? So it "works" as well as any build of OpenJDK that >> hasn't run TCK, which is very likely *all* community builds in the >> wild. > > Yes, I think most of us do not care about the build passing the TCK or not. We use such builds for development, hence "fresh" is better than "blessed". >> openjdk-osx-build is a valuable resource for any of us working on OS >> X, and it would be a terrible shame to lose it. > > Unfortunately it seems like it has already been lost... Let's be clear here. Nothing is lost unless it's unmaintained. If someone with the necessary skills is willing to commit here and now to supporting 32-bit into the future, I'd support that. But without that commitment, there is no point to re-introducing 32-bit support, only to let it rot. So, any takers? Mike Swingler Apple Inc. From rob.mckenna at oracle.com Thu May 10 09:30:19 2012 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 10 May 2012 17:30:19 +0100 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABEB5C.7090506@oracle.com> References: <4FABB180.9020507@oracle.com> <4FABEB5C.7090506@oracle.com> Message-ID: <4FABED1B.30603@oracle.com> Vote: yes -Rob From julien.ponge at gmail.com Thu May 10 10:17:47 2012 From: julien.ponge at gmail.com (Julien Ponge) Date: Thu, 10 May 2012 19:17:47 +0200 Subject: Review OSX universal mode patch In-Reply-To: <7BBF0CDA-03C3-496D-A72A-DF86A7C0A2F7@apple.com> References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> <0D1B60F9E36D431580DA26BDB22EA404@gmail.com> <7BBF0CDA-03C3-496D-A72A-DF86A7C0A2F7@apple.com> Message-ID: <6A78CED9A3DD431A853FACC48BAA3964@gmail.com> Ok, so on pure technical grounds how about the patch that Henri initially offered for review? We are talking here about the "first" step that Charles mentionned. Cheers On jeudi 10 mai 2012 at 18:26, Mike Swingler wrote: > On May 10, 2012, at 9:20 AM, Julien Ponge wrote: > > > > Frankly, it seems a little silly to me to expect that anyone would > > > even be capable of maintaining 32/universal OpenJDK builds for OS X > > > unless you make the first step of making it *possible* to build > > > 32/universal OpenJDK for OS X. Making them buildable seems like a > > > first step, eh? > > > > > > > > > +1 > > > * Is there community interest in having 32/universal build support in > > > OpenJDK on OS X? I think the answer is obviously yes. > > > * Has anyone stepped up to provide patches to make 32/universal builds > > > possible on OS X? The answer is also yes. > > > > > > > > > Henri has done a fantastic job by making it possible to use Java 7 on the Mac, way before we could get any "official" pre-release of any sort. > > > * Does OpenJDK work in 32-bit or universal modes on OS X? "Works" is > > > hard to answer definitively, without running the TCK, but *none* of > > > Henri's builds (which you praised openly at FOSDEM, Dalibor) have run > > > TCK either, right? So it "works" as well as any build of OpenJDK that > > > hasn't run TCK, which is very likely *all* community builds in the > > > wild. > > > > > > > > > Yes, I think most of us do not care about the build passing the TCK or not. We use such builds for development, hence "fresh" is better than "blessed". > > > openjdk-osx-build is a valuable resource for any of us working on OS > > > X, and it would be a terrible shame to lose it. > > > > > > > > > Unfortunately it seems like it has already been lost... > > Let's be clear here. Nothing is lost unless it's unmaintained. > > If someone with the necessary skills is willing to commit here and now to supporting 32-bit into the future, I'd support that. But without that commitment, there is no point to re-introducing 32-bit support, only to let it rot. > > So, any takers? > > Mike Swingler > Apple Inc. > > From swingler at apple.com Thu May 10 10:31:44 2012 From: swingler at apple.com (Mike Swingler) Date: Thu, 10 May 2012 10:31:44 -0700 Subject: Review OSX universal mode patch In-Reply-To: <6A78CED9A3DD431A853FACC48BAA3964@gmail.com> References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> <0D1B60F9E36D431580DA26BDB22EA404@gmail.com> <7BBF0CDA-03C3-496D-A72A-DF86A7C0A2F7@apple.com> <6A78CED9A3DD431A853FACC48BAA3964@gmail.com> Message-ID: The patch looks fine to me. The value of "universal" is required to let the build infrastructure pass both architectures to the compiler, and let the compiler do the work of running twice, and then combining the results. The #ifdef is done so that in the separate runs of the compiler, one value is hardcoded, and the other is not. At runtime, the expected values are output, and there is a single Mach-o executable on disk, with two architecture slices inside of it. Perhaps David was unfamiliar with the Universal build process, but this is the exact sort of impedance mis-match that comes from the mainline developers not eating, breathing, and living on the configuration in question. The individual who signs up to support 32/64 Universal, is essentially signing up to defend changes like this, and whomp the mainline developers over the head when they break the unsupported configuration. Not an easy task. Regards, Mike Swingler Apple Inc. On May 10, 2012, at 10:17 AM, Julien Ponge wrote: > Ok, so on pure technical grounds how about the patch that Henri initially offered for review? > > We are talking here about the "first" step that Charles mentionned. > > Cheers > On jeudi 10 mai 2012 at 18:26, Mike Swingler wrote: > >> On May 10, 2012, at 9:20 AM, Julien Ponge wrote: >> >>>> Frankly, it seems a little silly to me to expect that anyone would >>>> even be capable of maintaining 32/universal OpenJDK builds for OS X >>>> unless you make the first step of making it *possible* to build >>>> 32/universal OpenJDK for OS X. Making them buildable seems like a >>>> first step, eh? >>> >>> +1 >>>> * Is there community interest in having 32/universal build support in >>>> OpenJDK on OS X? I think the answer is obviously yes. >>>> * Has anyone stepped up to provide patches to make 32/universal builds >>>> possible on OS X? The answer is also yes. >>> >>> Henri has done a fantastic job by making it possible to use Java 7 on the Mac, way before we could get any "official" pre-release of any sort. >>>> * Does OpenJDK work in 32-bit or universal modes on OS X? "Works" is >>>> hard to answer definitively, without running the TCK, but *none* of >>>> Henri's builds (which you praised openly at FOSDEM, Dalibor) have run >>>> TCK either, right? So it "works" as well as any build of OpenJDK that >>>> hasn't run TCK, which is very likely *all* community builds in the >>>> wild. >>> >>> Yes, I think most of us do not care about the build passing the TCK or not. We use such builds for development, hence "fresh" is better than "blessed". >>>> openjdk-osx-build is a valuable resource for any of us working on OS >>>> X, and it would be a terrible shame to lose it. >>> >>> Unfortunately it seems like it has already been lost... >> >> Let's be clear here. Nothing is lost unless it's unmaintained. >> >> If someone with the necessary skills is willing to commit here and now to supporting 32-bit into the future, I'd support that. But without that commitment, there is no point to re-introducing 32-bit support, only to let it rot. >> >> So, any takers? >> >> Mike Swingler >> Apple Inc. > From scott.kovatch at oracle.com Thu May 10 10:35:30 2012 From: scott.kovatch at oracle.com (Scott Kovatch) Date: Thu, 10 May 2012 10:35:30 -0700 Subject: Review OSX universal mode patch In-Reply-To: <4FABE415.8010801@oracle.com> References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> Message-ID: <232B162D-DAE5-45FA-9F1F-3780887D6B54@oracle.com> On May 10, 2012, at 8:51 AM, Dalibor Topic wrote: > On 5/10/12 5:21 PM, Mike Swingler wrote: >> The OpenJDK product should be build-able for 32 or 32/64 Universal by anyone else, and should accept contributions to it's maintenance, but if nobody is signing up to keep forward-porting the changes - they don't have a future. >> >> Am I missing something here? > > That's why I'm asking the questions. I want to know what to expect - > a single patch for some or other build issue, a full porting effort, > or something else entirely. Maybe what would help here is for someone to write a specification of what we want to have happen. I don't want to put words in Henri's mouth, but I feel he is assuming that everyone in the OpenJDK community is fully aware of what Apple did with the JDK, and in my time here it's clear that this is not the case. Being able to run a 32-bit JVM was a useful feature. If someone wants to continue to do that, Oracle should not make it impossible because we don't want to support it. This should be nothing more than a build issue. If someone wants to build x86_64 or a 'universal' build, we shouldn't block that. Let's make it clear once and for all what is desired. I can put this into a bug if it will help. -- A straight 'make' of OpenJDK on Mac OS X is 64-bit only. '-d32' and '-d64' are ignored. -- 'make all_xxx_universal' produces a universal build. (Some clarification on the make target would be helpful) -- All versions of Mac OS X that support 64-bit Intel allow you to run binaries of either architecture. If the build is universal, passing '-d32' or '-d64' on the command line chooses the architecture to be run. -- When -d32 is used, System.getProperty("os.arch") = "i386". Any native libraries loaded must be i386. -- When -d64 is used, System.getProperty("os.arch") = "x86_64". Any native libraries loaded must be x86_64. -- We will not support an i386-only build. If someone wants to fork or add a post-processing step that lipo's away all of the x86_64 parts, they can do that. As far as maintenance goes: -- No patch that compiles with only one architecture is allowed. -- By extension, no linking against a framework or library that is 32-bit or 64-bit only. -- At some well-defined time in the future we will drop i386 entirely, but not before OS X is completely 32-bit-free. (Yes, this is strict. If you want to do something that is i386-only, fork the project.) Are there any points I'm missing here? Henri, does your patch satisfy all of these requirements? I think it does, based on the conversation I saw between you and David Holmes, but I'm not clear on the make targets. -- Scott K. ---------------------------------------- Scott Kovatch scott.kovatch at oracle.com Santa Clara/Pleasanton, CA From bradford.wetmore at oracle.com Thu May 10 10:41:53 2012 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Thu, 10 May 2012 10:41:53 -0700 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABB180.9020507@oracle.com> References: <4FABB180.9020507@oracle.com> Message-ID: <4FABFDE1.607@oracle.com> Vote: Yes On 5/10/2012 5:16 AM, Alan Bateman wrote: > > I hereby nominate Kurchi Subhra Hazra to jdk7u Committer. > > Kurchi has committer role in the jdk8 project but only author role on > jdk7u. > > The following queries match most of her recent activity: > > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=kurchi.subhra.hazra at oracle.com > > http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk7u/jdk7u-osx/jdk/log?rev=khazra > > Votes are due by May 24, 2012, 09:00 PDT. > > Only current jdk7u Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > -Alan. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From michael.x.mcmahon at oracle.com Thu May 10 11:19:13 2012 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Thu, 10 May 2012 19:19:13 +0100 Subject: Review OSX universal mode patch In-Reply-To: <232B162D-DAE5-45FA-9F1F-3780887D6B54@oracle.com> References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> <232B162D-DAE5-45FA-9F1F-3780887D6B54@oracle.com> Message-ID: <4FAC06A1.5080108@oracle.com> On 10/05/12 18:35, Scott Kovatch wrote: > On May 10, 2012, at 8:51 AM, Dalibor Topic wrote: > >> On 5/10/12 5:21 PM, Mike Swingler wrote: >>> The OpenJDK product should be build-able for 32 or 32/64 Universal by anyone else, and should accept contributions to it's maintenance, but if nobody is signing up to keep forward-porting the changes - they don't have a future. >>> >>> Am I missing something here? >> That's why I'm asking the questions. I want to know what to expect - >> a single patch for some or other build issue, a full porting effort, >> or something else entirely. > Maybe what would help here is for someone to write a specification of what we want to have happen. I don't want to put words in Henri's mouth, but I feel he is assuming that everyone in the OpenJDK community is fully aware of what Apple did with the JDK, and in my time here it's clear that this is not the case. Being able to run a 32-bit JVM was a useful feature. If someone wants to continue to do that, Oracle should not make it impossible because we don't want to support it. This should be nothing more than a build issue. If someone wants to build x86_64 or a 'universal' build, we shouldn't block that. > > Let's make it clear once and for all what is desired. I can put this into a bug if it will help. > > -- A straight 'make' of OpenJDK on Mac OS X is 64-bit only. '-d32' and '-d64' are ignored. > -- 'make all_xxx_universal' produces a universal build. (Some clarification on the make target would be helpful) > -- All versions of Mac OS X that support 64-bit Intel allow you to run binaries of either architecture. If the build is universal, passing '-d32' or '-d64' on the command line chooses the architecture to be run. > -- When -d32 is used, System.getProperty("os.arch") = "i386". Any native libraries loaded must be i386. > -- When -d64 is used, System.getProperty("os.arch") = "x86_64". Any native libraries loaded must be x86_64. > -- We will not support an i386-only build. If someone wants to fork or add a post-processing step that lipo's away all of the x86_64 parts, they can do that. > > As far as maintenance goes: > > -- No patch that compiles with only one architecture is allowed. > -- By extension, no linking against a framework or library that is 32-bit or 64-bit only. > -- At some well-defined time in the future we will drop i386 entirely, but not before OS X is completely 32-bit-free. (Yes, this is strict. If you want to do something that is i386-only, fork the project.) > > Are there any points I'm missing here? Henri, does your patch satisfy all of these requirements? I think it does, based on the conversation I saw between you and David Holmes, but I'm not clear on the make targets. I'd agree with the above, though it would be nice if some existing build variable like ARCH_DATA_MODEL could be used to signify the universal build, rather than introducing a new make target. Also, should this be done first in jdk8 and then back-ported? - Michael. > -- Scott K. > > ---------------------------------------- > Scott Kovatch > scott.kovatch at oracle.com > Santa Clara/Pleasanton, CA From scott.kovatch at oracle.com Thu May 10 11:29:55 2012 From: scott.kovatch at oracle.com (Scott Kovatch) Date: Thu, 10 May 2012 11:29:55 -0700 Subject: Review OSX universal mode patch In-Reply-To: <4FAC06A1.5080108@oracle.com> References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> <232B162D-DAE5-45FA-9F1F-3780887D6B54@oracle.com> <4FAC06A1.5080108@oracle.com> Message-ID: On May 10, 2012, at 11:19 AM, Michael McMahon wrote: > On 10/05/12 18:35, Scott Kovatch wrote: >> On May 10, 2012, at 8:51 AM, Dalibor Topic wrote: >> >>> On 5/10/12 5:21 PM, Mike Swingler wrote: >>>> The OpenJDK product should be build-able for 32 or 32/64 Universal by anyone else, and should accept contributions to it's maintenance, but if nobody is signing up to keep forward-porting the changes - they don't have a future. >>>> >>>> Am I missing something here? >>> That's why I'm asking the questions. I want to know what to expect - >>> a single patch for some or other build issue, a full porting effort, >>> or something else entirely. >> Maybe what would help here is for someone to write a specification of what we want to have happen. I don't want to put words in Henri's mouth, but I feel he is assuming that everyone in the OpenJDK community is fully aware of what Apple did with the JDK, and in my time here it's clear that this is not the case. Being able to run a 32-bit JVM was a useful feature. If someone wants to continue to do that, Oracle should not make it impossible because we don't want to support it. This should be nothing more than a build issue. If someone wants to build x86_64 or a 'universal' build, we shouldn't block that. >> >> Let's make it clear once and for all what is desired. I can put this into a bug if it will help. >> >> -- A straight 'make' of OpenJDK on Mac OS X is 64-bit only. '-d32' and '-d64' are ignored. >> -- 'make all_xxx_universal' produces a universal build. (Some clarification on the make target would be helpful) >> -- All versions of Mac OS X that support 64-bit Intel allow you to run binaries of either architecture. If the build is universal, passing '-d32' or '-d64' on the command line chooses the architecture to be run. >> -- When -d32 is used, System.getProperty("os.arch") = "i386". Any native libraries loaded must be i386. >> -- When -d64 is used, System.getProperty("os.arch") = "x86_64". Any native libraries loaded must be x86_64. >> -- We will not support an i386-only build. If someone wants to fork or add a post-processing step that lipo's away all of the x86_64 parts, they can do that. >> >> As far as maintenance goes: >> >> -- No patch that compiles with only one architecture is allowed. >> -- By extension, no linking against a framework or library that is 32-bit or 64-bit only. >> -- At some well-defined time in the future we will drop i386 entirely, but not before OS X is completely 32-bit-free. (Yes, this is strict. If you want to do something that is i386-only, fork the project.) >> >> Are there any points I'm missing here? Henri, does your patch satisfy all of these requirements? I think it does, based on the conversation I saw between you and David Holmes, but I'm not clear on the make targets. > I'd agree with the above, though it would be nice if some existing build variable > like ARCH_DATA_MODEL could be used to signify the universal build, rather than introducing > a new make target. I thought we already had universal make targets, based on Henri's patch? but now I see that's in hotspot only. Henri, how are you triggering a universal JDK build? With ARCH_DATA_MODEL ? > Also, should this be done first in jdk8 and then back-ported? Yes, absolutely. I forgot about that part. I believe JDK 8 is successfully building on OS X and has everything from 7u6 so it shouldn't be that bad. -- Scott K. From henri.gomez at gmail.com Thu May 10 13:06:23 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Thu, 10 May 2012 22:06:23 +0200 Subject: Review OSX universal mode patch In-Reply-To: References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> <232B162D-DAE5-45FA-9F1F-3780887D6B54@oracle.com> <4FAC06A1.5080108@oracle.com> Message-ID: <11418A7F-EF9B-4DAC-A79C-AA94FF3F05B3@gmail.com> Happy to see subject back to technical. If you take a closer look to patch, you'll see universal is enforced as ARCH. More on this tomorrow. Le 10 mai 2012 ? 20:29, Scott Kovatch a ?crit : > > On May 10, 2012, at 11:19 AM, Michael McMahon wrote: > >> On 10/05/12 18:35, Scott Kovatch wrote: >>> On May 10, 2012, at 8:51 AM, Dalibor Topic wrote: >>> >>>> On 5/10/12 5:21 PM, Mike Swingler wrote: >>>>> The OpenJDK product should be build-able for 32 or 32/64 Universal by anyone else, and should accept contributions to it's maintenance, but if nobody is signing up to keep forward-porting the changes - they don't have a future. >>>>> >>>>> Am I missing something here? >>>> That's why I'm asking the questions. I want to know what to expect - >>>> a single patch for some or other build issue, a full porting effort, >>>> or something else entirely. >>> Maybe what would help here is for someone to write a specification of what we want to have happen. I don't want to put words in Henri's mouth, but I feel he is assuming that everyone in the OpenJDK community is fully aware of what Apple did with the JDK, and in my time here it's clear that this is not the case. Being able to run a 32-bit JVM was a useful feature. If someone wants to continue to do that, Oracle should not make it impossible because we don't want to support it. This should be nothing more than a build issue. If someone wants to build x86_64 or a 'universal' build, we shouldn't block that. >>> >>> Let's make it clear once and for all what is desired. I can put this into a bug if it will help. >>> >>> -- A straight 'make' of OpenJDK on Mac OS X is 64-bit only. '-d32' and '-d64' are ignored. >>> -- 'make all_xxx_universal' produces a universal build. (Some clarification on the make target would be helpful) >>> -- All versions of Mac OS X that support 64-bit Intel allow you to run binaries of either architecture. If the build is universal, passing '-d32' or '-d64' on the command line chooses the architecture to be run. >>> -- When -d32 is used, System.getProperty("os.arch") = "i386". Any native libraries loaded must be i386. >>> -- When -d64 is used, System.getProperty("os.arch") = "x86_64". Any native libraries loaded must be x86_64. >>> -- We will not support an i386-only build. If someone wants to fork or add a post-processing step that lipo's away all of the x86_64 parts, they can do that. >>> >>> As far as maintenance goes: >>> >>> -- No patch that compiles with only one architecture is allowed. >>> -- By extension, no linking against a framework or library that is 32-bit or 64-bit only. >>> -- At some well-defined time in the future we will drop i386 entirely, but not before OS X is completely 32-bit-free. (Yes, this is strict. If you want to do something that is i386-only, fork the project.) >>> >>> Are there any points I'm missing here? Henri, does your patch satisfy all of these requirements? I think it does, based on the conversation I saw between you and David Holmes, but I'm not clear on the make targets. >> I'd agree with the above, though it would be nice if some existing build variable >> like ARCH_DATA_MODEL could be used to signify the universal build, rather than introducing >> a new make target. > > I thought we already had universal make targets, based on Henri's patch? but now I see that's in hotspot only. > > Henri, how are you triggering a universal JDK build? With ARCH_DATA_MODEL ? > >> Also, should this be done first in jdk8 and then back-ported? > > Yes, absolutely. I forgot about that part. I believe JDK 8 is successfully building on OS X and has everything from 7u6 so it shouldn't be that bad. > > -- Scott K. > > From david.katleman at oracle.com Thu May 10 14:37:11 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 10 May 2012 21:37:11 +0000 Subject: hg: jdk7u/jdk7u: Added tag jdk7u6-b09 for changeset 01001f439af7 Message-ID: <20120510213711.47C8247246@hg.openjdk.java.net> Changeset: 1816f0ef00b4 Author: katleman Date: 2012-05-10 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/rev/1816f0ef00b4 Added tag jdk7u6-b09 for changeset 01001f439af7 ! .hgtags From david.katleman at oracle.com Thu May 10 14:37:15 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 10 May 2012 21:37:15 +0000 Subject: hg: jdk7u/jdk7u/corba: Added tag jdk7u6-b09 for changeset 13faa12cfdd6 Message-ID: <20120510213715.9991347247@hg.openjdk.java.net> Changeset: c9f6750370c9 Author: katleman Date: 2012-05-10 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/corba/rev/c9f6750370c9 Added tag jdk7u6-b09 for changeset 13faa12cfdd6 ! .hgtags From david.katleman at oracle.com Thu May 10 14:38:14 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 10 May 2012 21:38:14 +0000 Subject: hg: jdk7u/jdk7u/hotspot: Added tag jdk7u6-b09 for changeset 94d7a305da4d Message-ID: <20120510213816.4912247248@hg.openjdk.java.net> Changeset: 103fc6756e1e Author: katleman Date: 2012-05-10 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/103fc6756e1e Added tag jdk7u6-b09 for changeset 94d7a305da4d ! .hgtags From david.katleman at oracle.com Thu May 10 14:39:25 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 10 May 2012 21:39:25 +0000 Subject: hg: jdk7u/jdk7u/jaxp: Added tag jdk7u6-b09 for changeset 52d82754ec69 Message-ID: <20120510213927.0104647249@hg.openjdk.java.net> Changeset: f4e80156296e Author: katleman Date: 2012-05-10 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jaxp/rev/f4e80156296e Added tag jdk7u6-b09 for changeset 52d82754ec69 ! .hgtags From david.katleman at oracle.com Thu May 10 14:39:31 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 10 May 2012 21:39:31 +0000 Subject: hg: jdk7u/jdk7u/jaxws: Added tag jdk7u6-b09 for changeset 03a772c8b8fb Message-ID: <20120510213931.0A0B64724A@hg.openjdk.java.net> Changeset: c08f88f5ae98 Author: katleman Date: 2012-05-10 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jaxws/rev/c08f88f5ae98 Added tag jdk7u6-b09 for changeset 03a772c8b8fb ! .hgtags From david.katleman at oracle.com Thu May 10 14:39:37 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 10 May 2012 21:39:37 +0000 Subject: hg: jdk7u/jdk7u/jdk: Added tag jdk7u6-b09 for changeset 9e4fcaae8175 Message-ID: <20120510213948.29CEE4724B@hg.openjdk.java.net> Changeset: fb31ae59ff22 Author: katleman Date: 2012-05-10 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/fb31ae59ff22 Added tag jdk7u6-b09 for changeset 9e4fcaae8175 ! .hgtags From david.katleman at oracle.com Thu May 10 14:40:50 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 10 May 2012 21:40:50 +0000 Subject: hg: jdk7u/jdk7u/langtools: Added tag jdk7u6-b09 for changeset 3e268ea565ef Message-ID: <20120510214052.7B2E04724C@hg.openjdk.java.net> Changeset: 21d2313dfeac Author: katleman Date: 2012-05-10 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/21d2313dfeac Added tag jdk7u6-b09 for changeset 3e268ea565ef ! .hgtags From david.holmes at oracle.com Thu May 10 17:20:29 2012 From: david.holmes at oracle.com (David Holmes) Date: Fri, 11 May 2012 10:20:29 +1000 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABB180.9020507@oracle.com> References: <4FABB180.9020507@oracle.com> Message-ID: <4FAC5B4D.9060904@oracle.com> Vote: YES David On 10/05/2012 10:16 PM, Alan Bateman wrote: > > I hereby nominate Kurchi Subhra Hazra to jdk7u Committer. > > Kurchi has committer role in the jdk8 project but only author role on > jdk7u. > > The following queries match most of her recent activity: > > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=kurchi.subhra.hazra at oracle.com > > http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk7u/jdk7u-osx/jdk/log?rev=khazra > > Votes are due by May 24, 2012, 09:00 PDT. > > Only current jdk7u Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > -Alan. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From david.holmes at oracle.com Thu May 10 17:34:07 2012 From: david.holmes at oracle.com (David Holmes) Date: Fri, 11 May 2012 10:34:07 +1000 Subject: Review OSX universal mode patch In-Reply-To: <11418A7F-EF9B-4DAC-A79C-AA94FF3F05B3@gmail.com> References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> <232B162D-DAE5-45FA-9F1F-3780887D6B54@oracle.com> <4FAC06A1.5080108@oracle.com> <11418A7F-EF9B-4DAC-A79C-AA94FF3F05B3@gmail.com> Message-ID: <4FAC5E7F.8010803@oracle.com> On 11/05/2012 6:06 AM, Henri Gomez wrote: > Happy to see subject back to technical. > > If you take a closer look to patch, you'll see universal is enforced as ARCH. My concerns with the patch is the necessity of introducing these platform specific ifdefs into what is notionally shared code - yes there are already ifdefs in there but I still dislike seeing this. And I think the various "arch" variables are being misused in ways that ultimately lead to confusion - the OSX build shouldn't require a completely different understanding of the build system. I was not familiar with the Universal build and to be honest it seems to be more of a hindrance than a help. If the build was done as two passes: 32-bit then 64-bit with a stage at the end to produce the universal binary, then bit-specific make variables could continue to work as they were intended - is that possible? I also think this should be taken to JDK8 first. David ----- > More on this tomorrow. > > Le 10 mai 2012 ? 20:29, Scott Kovatch a ?crit : > >> >> On May 10, 2012, at 11:19 AM, Michael McMahon wrote: >> >>> On 10/05/12 18:35, Scott Kovatch wrote: >>>> On May 10, 2012, at 8:51 AM, Dalibor Topic wrote: >>>> >>>>> On 5/10/12 5:21 PM, Mike Swingler wrote: >>>>>> The OpenJDK product should be build-able for 32 or 32/64 Universal by anyone else, and should accept contributions to it's maintenance, but if nobody is signing up to keep forward-porting the changes - they don't have a future. >>>>>> >>>>>> Am I missing something here? >>>>> That's why I'm asking the questions. I want to know what to expect - >>>>> a single patch for some or other build issue, a full porting effort, >>>>> or something else entirely. >>>> Maybe what would help here is for someone to write a specification of what we want to have happen. I don't want to put words in Henri's mouth, but I feel he is assuming that everyone in the OpenJDK community is fully aware of what Apple did with the JDK, and in my time here it's clear that this is not the case. Being able to run a 32-bit JVM was a useful feature. If someone wants to continue to do that, Oracle should not make it impossible because we don't want to support it. This should be nothing more than a build issue. If someone wants to build x86_64 or a 'universal' build, we shouldn't block that. >>>> >>>> Let's make it clear once and for all what is desired. I can put this into a bug if it will help. >>>> >>>> -- A straight 'make' of OpenJDK on Mac OS X is 64-bit only. '-d32' and '-d64' are ignored. >>>> -- 'make all_xxx_universal' produces a universal build. (Some clarification on the make target would be helpful) >>>> -- All versions of Mac OS X that support 64-bit Intel allow you to run binaries of either architecture. If the build is universal, passing '-d32' or '-d64' on the command line chooses the architecture to be run. >>>> -- When -d32 is used, System.getProperty("os.arch") = "i386". Any native libraries loaded must be i386. >>>> -- When -d64 is used, System.getProperty("os.arch") = "x86_64". Any native libraries loaded must be x86_64. >>>> -- We will not support an i386-only build. If someone wants to fork or add a post-processing step that lipo's away all of the x86_64 parts, they can do that. >>>> >>>> As far as maintenance goes: >>>> >>>> -- No patch that compiles with only one architecture is allowed. >>>> -- By extension, no linking against a framework or library that is 32-bit or 64-bit only. >>>> -- At some well-defined time in the future we will drop i386 entirely, but not before OS X is completely 32-bit-free. (Yes, this is strict. If you want to do something that is i386-only, fork the project.) >>>> >>>> Are there any points I'm missing here? Henri, does your patch satisfy all of these requirements? I think it does, based on the conversation I saw between you and David Holmes, but I'm not clear on the make targets. >>> I'd agree with the above, though it would be nice if some existing build variable >>> like ARCH_DATA_MODEL could be used to signify the universal build, rather than introducing >>> a new make target. >> >> I thought we already had universal make targets, based on Henri's patch? but now I see that's in hotspot only. >> >> Henri, how are you triggering a universal JDK build? With ARCH_DATA_MODEL ? >> >>> Also, should this be done first in jdk8 and then back-ported? >> >> Yes, absolutely. I forgot about that part. I believe JDK 8 is successfully building on OS X and has everything from 7u6 so it shouldn't be that bad. >> >> -- Scott K. >> >> From weijun.wang at oracle.com Thu May 10 17:36:55 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 11 May 2012 08:36:55 +0800 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABB180.9020507@oracle.com> References: <4FABB180.9020507@oracle.com> Message-ID: <4FAC5F27.4060505@oracle.com> Vote: yes -weijun From xuelei.fan at oracle.com Thu May 10 17:56:43 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 11 May 2012 00:56:43 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7166570: JSSE certificate validation has started to fail for certificate chains Message-ID: <20120511005653.88CB34724F@hg.openjdk.java.net> Changeset: 997176fc0a83 Author: xuelei Date: 2012-05-10 17:53 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/997176fc0a83 7166570: JSSE certificate validation has started to fail for certificate chains Reviewed-by: wetmore ! src/share/classes/sun/security/validator/SimpleValidator.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/BasicConstraints.java From xuelei.fan at oracle.com Thu May 10 18:05:13 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 11 May 2012 09:05:13 +0800 Subject: CFV: New jdk7u Committer: Kurchi Subhra Hazra In-Reply-To: <4FABB180.9020507@oracle.com> References: <4FABB180.9020507@oracle.com> Message-ID: <4FAC65C9.2040600@oracle.com> Vote: Yes Xuelei On 5/10/2012 8:16 PM, Alan Bateman wrote: > > I hereby nominate Kurchi Subhra Hazra to jdk7u Committer. > > Kurchi has committer role in the jdk8 project but only author role on > jdk7u. > > The following queries match most of her recent activity: > > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=kurchi.subhra.hazra at oracle.com > > http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/log?rev=khazra > http://hg.openjdk.java.net/jdk7u/jdk7u-osx/jdk/log?rev=khazra > > Votes are due by May 24, 2012, 09:00 PDT. > > Only current jdk7u Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > -Alan. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From gary.collins at oracle.com Thu May 10 21:14:19 2012 From: gary.collins at oracle.com (Gary Collins) Date: Thu, 10 May 2012 21:14:19 -0700 Subject: Request for Review: 7168098 Adjustments for SE-Embedded build process Message-ID: Simple change to the SE-Embedded build rules that should not affect any other OpenJDK users. Webrev http://cr.openjdk.java.net/~collins/7168098/webrev/ 7168098 Adjustments for SE-Embedded build process I would also like to request a sponsor Thanks Gary From gary.collins at oracle.com Thu May 10 21:37:26 2012 From: gary.collins at oracle.com (Gary Collins) Date: Thu, 10 May 2012 21:37:26 -0700 Subject: Request for Review: 7168098 Adjustments for SE-Embedded build process Message-ID: <869C62AA-F6D8-4826-8B07-6446AF4CDBED@oracle.com> Simple change to the SE-Embedded build rules that should not affect any other OpenJDK users. Webrev http://cr.openjdk.java.net/~collins/7167625/webrev/ 7167625 Adjustments for SE-Embedded build process Thanks Gary From david.holmes at oracle.com Thu May 10 21:41:14 2012 From: david.holmes at oracle.com (David Holmes) Date: Fri, 11 May 2012 14:41:14 +1000 Subject: Request for Review: 7168098 Adjustments for SE-Embedded build process In-Reply-To: References: Message-ID: <4FAC986A.9070103@oracle.com> Hi Gary, On 11/05/2012 2:14 PM, Gary Collins wrote: > Simple change to the SE-Embedded build rules that should not affect any other OpenJDK users. > Webrev > http://cr.openjdk.java.net/~collins/7168098/webrev/ > > 7168098 Adjustments for SE-Embedded build process > I would also like to request a sponsor Reviewed and sponsored. Please submit approval request. Thanks, David From gary.collins at oracle.com Thu May 10 21:51:11 2012 From: gary.collins at oracle.com (Gary Collins) Date: Thu, 10 May 2012 21:51:11 -0700 Subject: Request for Review: 7168098 Adjustments for SE-Embedded build process In-Reply-To: <869C62AA-F6D8-4826-8B07-6446AF4CDBED@oracle.com> References: <869C62AA-F6D8-4826-8B07-6446AF4CDBED@oracle.com> Message-ID: <49C3FD7D-9128-4E23-AF83-14241589F2BA@oracle.com> please ignore - sent whilst editing Gary On May 10, 2012, at 9:37 PM, Gary Collins wrote: > Simple change to the SE-Embedded build rules that should not affect any other OpenJDK users. > Webrev > http://cr.openjdk.java.net/~collins/7167625/webrev/ > > 7167625 Adjustments for SE-Embedded build process > > Thanks > Gary From gary.collins at oracle.com Thu May 10 22:10:20 2012 From: gary.collins at oracle.com (Gary Collins) Date: Thu, 10 May 2012 22:10:20 -0700 Subject: [7u6] Request for approval for CR 7168098 - Adjustments for SE-Embedded build process Message-ID: <8F51EB68-849C-43DD-91A6-0D8795B7DA86@oracle.com> These changes are only relevant to the 7u product train. Whilst similar functionality will eventually appear in the JDK8 product train, the form will be quite different due to the integration with Jigsaw and the new build process. In the not too distant future we hope to move these build rules out of the OpenJDK repository so we don't need to bother the community when we need to update them. Bug: ( The bug may take a few days to appear on the web ) http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168098 Webrev: http://cr.openjdk.java.net/~collins/7168098/webrev/ Review: http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-May/002977.html Thanks Gary From edvard.wendelin at oracle.com Thu May 10 22:59:43 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Fri, 11 May 2012 07:59:43 +0200 Subject: [7u6] Request for approval for CR 7168098 - Adjustments for SE-Embedded build process In-Reply-To: <8F51EB68-849C-43DD-91A6-0D8795B7DA86@oracle.com> References: <8F51EB68-849C-43DD-91A6-0D8795B7DA86@oracle.com> Message-ID: Approved. On May 11, 2012, at 7:10 AM, Gary Collins wrote: > These changes are only relevant to the 7u product train. Whilst similar functionality will eventually appear in the JDK8 product train, > the form will be quite different due to the integration with Jigsaw and the new build process. > > In the not too distant future we hope to move these build rules out of the OpenJDK repository so we don't need to bother the > community when we need to update them. > > Bug: ( The bug may take a few days to appear on the web ) > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168098 > Webrev: > http://cr.openjdk.java.net/~collins/7168098/webrev/ > Review: > http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-May/002977.html > > Thanks > Gary From henri.gomez at gmail.com Thu May 10 23:56:14 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Fri, 11 May 2012 08:56:14 +0200 Subject: Review OSX universal mode patch In-Reply-To: <4FAC5E7F.8010803@oracle.com> References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> <232B162D-DAE5-45FA-9F1F-3780887D6B54@oracle.com> <4FAC06A1.5080108@oracle.com> <11418A7F-EF9B-4DAC-A79C-AA94FF3F05B3@gmail.com> <4FAC5E7F.8010803@oracle.com> Message-ID: > My concerns with the patch is the necessity of introducing these platform > specific ifdefs into what is notionally shared code - yes there are already > ifdefs in there but I still dislike seeing this. And I think the various > "arch" variables are being misused in ways that ultimately lead to confusion > - the OSX build shouldn't require a completely different understanding of > the build system. As Scott mentioned there is 2 binaries build and assembled, one in 32 bits and another in 64 bits. This is a great strength of OSX avoiding to provide 2 differents binaries and so 2 differents packages. > I was not familiar with the Universal build and to be honest it seems to be > more of a hindrance than a help. If the build was done as two passes: 32-bit > then 64-bit with a stage at the end to produce the universal binary, then > bit-specific make variables could continue to work as they were intended - > is that possible? To me its not an hindrance but a great feature. There is some OSX gurus around, Mike and Scott to name a few and they could give more technicals informations. > I also think this should be taken to JDK8 first. No problem to get this ported to JDK8 first then backported to JDK7u. From henri.gomez at gmail.com Fri May 11 01:04:25 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Fri, 11 May 2012 10:04:25 +0200 Subject: Review OSX universal mode patch In-Reply-To: <232B162D-DAE5-45FA-9F1F-3780887D6B54@oracle.com> References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> <232B162D-DAE5-45FA-9F1F-3780887D6B54@oracle.com> Message-ID: > Let's make it clear once and for all what is desired. I can put this into a bug if it will help. > > -- A straight 'make' of OpenJDK on Mac OS X is 64-bit only. '-d32' and '-d64' are ignored. > -- 'make all_xxx_universal' produces a universal build. (Some clarification on the make target would be helpful) > -- All versions of Mac OS X that support 64-bit Intel allow you to run binaries of either architecture. If the build is universal, passing ?'-d32' or '-d64' on the command line chooses the architecture to be run. > -- When -d32 is used, System.getProperty("os.arch") = "i386". Any native libraries loaded must be i386. ok > -- When -d64 is used, System.getProperty("os.arch") = "x86_64". Any native libraries loaded must be x86_64. ok > -- We will not support an i386-only build. If someone wants to fork or add a post-processing step that lipo's away all of the x86_64 parts, they can do that. ok, a single universal 32/64 package was the way OSX users worked with Apple JVM. > As far as maintenance goes: > > -- No patch that compiles with only one architecture is allowed. make sense > -- By extension, no linking against a framework or library that is 32-bit or 64-bit only. of course > -- At some well-defined time in the future we will drop i386 entirely, but not before OS X is completely 32-bit-free. (Yes, this is strict. If you want to do something that is i386-only, fork the project.) Dropping 32bits support in the future ? Near or long term future ? There is still SnowLeopard around and many may remains in the future, we should try to preserve them, at least for the community supported version. You mention fork, does it means that OpenJDK 7 and 8 could/should be forked to other locations if community want to still support 32bits ? GitHub or BitBucket are valid solutions for such fork ? > Are there any points I'm missing here? Henri, does your patch satisfy all of these requirements? I think it does, based on the conversation I saw between you and David Holmes, but I'm not clear on the make targets. No missing points, this is a good coverage. From henri.gomez at gmail.com Fri May 11 01:41:54 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Fri, 11 May 2012 10:41:54 +0200 Subject: Review OSX universal mode patch In-Reply-To: References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> <0D1B60F9E36D431580DA26BDB22EA404@gmail.com> <7BBF0CDA-03C3-496D-A72A-DF86A7C0A2F7@apple.com> <6A78CED9A3DD431A853FACC48BAA3964@gmail.com> Message-ID: > The patch looks fine to me. The value of "universal" is required to let the build infrastructure pass both architectures to the compiler, and let the compiler do the work of running twice, and then combining the results. Good news, in fact patches are back port of settings available in macosx-port. > The #ifdef is done so that in the separate runs of the compiler, one value is hardcoded, and the other is not. At runtime, the expected values are output, and there is a single Mach-o executable on disk, with two architecture slices inside of it. A nice feature of OSX. > Perhaps David was unfamiliar with the Universal build process, but this is the exact sort of impedance mis-match that comes from the mainline developers not eating, breathing, and living on the configuration in question. The individual who signs up to support 32/64 Universal, is essentially signing up to defend changes like this, and whomp the mainline developers over the head when they break the unsupported configuration. Not an easy task. It's not an easy task for an individual contributor especially when it's not its daily job. But could be supported by a team of contributors. Who could be interested in joining such effort ? From dalibor.topic at oracle.com Fri May 11 02:43:16 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Fri, 11 May 2012 11:43:16 +0200 Subject: Review OSX universal mode patch In-Reply-To: References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> <232B162D-DAE5-45FA-9F1F-3780887D6B54@oracle.com> Message-ID: <4FACDF34.1060101@oracle.com> On 5/11/12 10:04 AM, Henri Gomez wrote: > Dropping 32bits support in the future ? Near or long term future ? > > There is still SnowLeopard around and many may remains in the future, > we should try to preserve them, at least for the community supported > version. > > You mention fork, does it means that OpenJDK 7 and 8 could/should be > forked to other locations if community want to still support 32bits ? > GitHub or BitBucket are valid solutions for such fork ? For experimental support of non-mainstream BSD-ish platforms the bsd porting project in OpenJDK would be my first choice. cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From sean.coffey at oracle.com Fri May 11 03:46:53 2012 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Fri, 11 May 2012 11:46:53 +0100 Subject: [7u6] Request for approval for CR 7167359 (tz) SEGV on solaris if TZ variable not set Message-ID: <4FACEE1D.40708@oracle.com> Looking to port this simple fix from 8 to 7u. Fix is identical to jdk 8 one. review thread : http://mail.openjdk.java.net/pipermail/i18n-dev/2012-May/000615.html jdk 8 changeset : http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e83229a3779 regards, Sean. From edvard.wendelin at oracle.com Fri May 11 03:47:40 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Fri, 11 May 2012 12:47:40 +0200 Subject: [7u6] Request for approval for CR 7167359 (tz) SEGV on solaris if TZ variable not set In-Reply-To: <4FACEE1D.40708@oracle.com> References: <4FACEE1D.40708@oracle.com> Message-ID: <4FACEE4C.30305@oracle.com> Approved. On 05/11/2012 12:46 PM, Se?n Coffey wrote: > Looking to port this simple fix from 8 to 7u. Fix is identical to jdk > 8 one. > > review thread : > http://mail.openjdk.java.net/pipermail/i18n-dev/2012-May/000615.html > jdk 8 changeset : http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e83229a3779 > > regards, > Sean. From sean.coffey at oracle.com Fri May 11 03:50:29 2012 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Fri, 11 May 2012 10:50:29 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7167359: (tz) SEGV on solaris if TZ variable not set Message-ID: <20120511105047.3C9414727A@hg.openjdk.java.net> Changeset: 96bbb23bbaca Author: coffeys Date: 2012-05-11 11:52 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/96bbb23bbaca 7167359: (tz) SEGV on solaris if TZ variable not set Reviewed-by: okutsu ! src/solaris/native/java/util/TimeZone_md.c From henri.gomez at gmail.com Fri May 11 04:49:38 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Fri, 11 May 2012 13:49:38 +0200 Subject: Review OSX universal mode patch In-Reply-To: <4FACDF34.1060101@oracle.com> References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> <232B162D-DAE5-45FA-9F1F-3780887D6B54@oracle.com> <4FACDF34.1060101@oracle.com> Message-ID: > For experimental support of non-mainstream BSD-ish platforms the bsd > porting project in OpenJDK would be my first choice. Why moving to BSD something which is purely OSX related ? Patches could be made safe enough to avoid conflicts with current mode, aka x86_64 arch. From swingler at apple.com Fri May 11 11:17:56 2012 From: swingler at apple.com (Mike Swingler) Date: Fri, 11 May 2012 11:17:56 -0700 Subject: Review OSX universal mode patch In-Reply-To: <4FAC5E7F.8010803@oracle.com> References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> <232B162D-DAE5-45FA-9F1F-3780887D6B54@oracle.com> <4FAC06A1.5080108@oracle.com> <11418A7F-EF9B-4DAC-A79C-AA94FF3F05B3@gmail.com> <4FAC5E7F.8010803@oracle.com> Message-ID: On May 10, 2012, at 5:34 PM, David Holmes wrote: > On 11/05/2012 6:06 AM, Henri Gomez wrote: >> Happy to see subject back to technical. >> >> If you take a closer look to patch, you'll see universal is enforced as ARCH. > > My concerns with the patch is the necessity of introducing these platform specific ifdefs into what is notionally shared code - yes there are already ifdefs in there but I still dislike seeing this. And I think the various "arch" variables are being misused in ways that ultimately lead to confusion - the OSX build shouldn't require a completely different understanding of the build system. But the OS X build system builds for multiple architectures fundamentally differently than any other toolchain on any other OS. By doing multiple passes on the same file at the same time, the disk cache is most effectively utilized. By simply tacking on additional architecture flags to the CFLAGS, more architectures can be trivially introduced into legacy Makefile projects without wide sweeping changes across the whole project to build into different directories. This is why we introduced concept of the "universal" architecture for the directory names, which could mean "i386", "x64_64", or "i386+x86_64", depending on how you were building. > I was not familiar with the Universal build and to be honest it seems to be more of a hindrance than a help. If the build was done as two passes: 32-bit then 64-bit with a stage at the end to produce the universal binary, then bit-specific make variables could continue to work as they were intended - is that possible? It's possible, but not easy. Given that we have a solution that works in the here and now, an #ifdef is a small price to pay until the next major build system refactoring occurs. > I also think this should be taken to JDK8 first. Of course. Regards, Mike Swingler Apple Inc. From mike.duigou at oracle.com Fri May 11 11:39:26 2012 From: mike.duigou at oracle.com (Mike Duigou) Date: Fri, 11 May 2012 11:39:26 -0700 Subject: [7u6] request for approval, 7071826: Avoid benign race condition in initialization of UUID Message-ID: <9959617A-78C2-4627-A67F-833848D875AE@oracle.com> Hi, This is a request to backport a JDK 8 fix into JDK 7u6: 7071826: Avoid benign race condition in initialization of UUID The fix has already been pushed to JDK 8: http://hg.openjdk.java.net/jdk8/tl-gate/jdk/rev/944676ef3c58 The code changes for jdk7u6 are identical to the ones in jdk8. I intend to push it to ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk Thanks! Mike From henri.gomez at gmail.com Fri May 11 11:54:27 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Fri, 11 May 2012 20:54:27 +0200 Subject: Review OSX universal mode patch In-Reply-To: References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> <232B162D-DAE5-45FA-9F1F-3780887D6B54@oracle.com> <4FAC06A1.5080108@oracle.com> <11418A7F-EF9B-4DAC-A79C-AA94FF3F05B3@gmail.com> <4FAC5E7F.8010803@oracle.com> Message-ID: > But the OS X build system builds for multiple architectures fundamentally differently than any other toolchain on any other OS. Yes and clearly it rocks ! > By doing multiple passes on the same file at the same time, the disk cache is most effectively utilized. By simply tacking on additional architecture flags to the CFLAGS, more architectures can be trivially introduced into legacy Makefile projects without wide sweeping changes across the whole project to build into different directories. This is why we introduced concept of the "universal" architecture for the directory names, which could mean "i386", "x64_64", or "i386+x86_64", depending on how you were building. i386+x86_64+ppc+arm, a dream :) > It's possible, but not easy. Given that we have a solution that works in the here and now, an #ifdef is a small price to pay until the next major build system refactoring occurs. +100 >> I also think this should be taken to JDK8 first. > > Of course. I could propose adapted patches for JDK8. These patches will activate universal mode only if ARCH=universal so it won't break current defaults, aka x86_64. WDYM ? From dalibor.topic at oracle.com Fri May 11 13:55:16 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Fri, 11 May 2012 22:55:16 +0200 Subject: New jdk7u maintainer : Sean Coffey Message-ID: <4FAD7CB4.3080406@oracle.com> I'm delegating the maintainer authority for jdk7u to Sean Coffey. That means that we now have four jdk7u forest maintainers again, as listed on the project page. Welcome, Sean! cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From mike.duigou at oracle.com Fri May 11 14:28:24 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Fri, 11 May 2012 21:28:24 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7149320: Move sun.misc.VM.booted() to the end of System.initializeSystemClass() Message-ID: <20120511212843.8D8DD472AB@hg.openjdk.java.net> Changeset: 8004f3dd5c54 Author: mduigou Date: 2012-05-11 10:46 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/8004f3dd5c54 7149320: Move sun.misc.VM.booted() to the end of System.initializeSystemClass() Summary: Ensure that sun.misc.VM.booted() is the last action in System.initSystemClass() Reviewed-by: dholmes, alanb ! src/share/classes/java/lang/System.java From edvard.wendelin at oracle.com Fri May 11 14:48:30 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Fri, 11 May 2012 23:48:30 +0200 Subject: JDK 7u4 is now GA In-Reply-To: <23138B91-882A-4876-8602-41DA00478265@oracle.com> References: <23138B91-882A-4876-8602-41DA00478265@oracle.com> Message-ID: <8830F634-1635-4722-8940-0B1C9F18841F@oracle.com> Hi, Source bundle is now available here: http://jdk7.java.net/source.html /Edvard On Apr 27, 2012, at 9:52 AM, Edvard Wendelin wrote: > Hi, > > I'd like to announce that JDK 7u4 is now generally available [1]. I would like to thank all of you for the contributions you've made! OpenJDK 7u4 source code is available on the Mercurial server [2] and as usual we will also publish a source code archive soon. Once they are available I will send out a link. > > If you're packaging this release, please let us know on this list, and please consider contributing fixes back into 7u6 [3], which is open for fixes. > > Cheers, > Edvard > > [1] http://www.oracle.com/technetwork/java/javase/downloads/index.html > [2] http://hg.openjdk.java.net/jdk7u/jdk7u4/ > [3] http://openjdk.java.net/projects/jdk7u/ > From alejandro.murillo at oracle.com Fri May 11 17:39:03 2012 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Fri, 11 May 2012 18:39:03 -0600 Subject: [7u6] Request for approval for bulk integration of hs23.2-b01 Message-ID: <4FADB127.8070009@oracle.com> Requesting approval to integrate hs23.2-b01 into jdk7u6-b10. A webrev is available at: http://cr.openjdk.java.net/~amurillo/7u6/hs23.2-b01-jdk7u6-b10.webrev/ Pre-integration testing is in progress; the integration will proceed only after SQE has analyzed the results and approved. The fixes in the proposed integration are below. All have undergone nightly testing and are already in a jdk8 repository. 7102323: RFE: enable Full Debug Symbols Phase 1 on Solaris 7132070: Use a mach_port_t as the OSThread thread_id rather than pthread_t on BSD/OSX 7152800: All tests using the attach API fail with "well-known file is not secure" on Mac OS X 7158067: FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect product builds 7163117: Agent can't connect to process on Mac OSX 7164344: enabling ZIP_DEBUGINFO_FILES causes unexpected test failures on Solaris and Windows 7167028: new hotspot build - hs23.2-b01 7167266: missing copyright notes in 3rd party code 7167406: (Zero) Fix for InvokeDynamic needed -- Alejandro E Murillo, Java Performance Phone: (303) 955-2584. Timezone: US/Mountain (UTC-0700) From kelly.ohair at oracle.com Fri May 11 17:07:35 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 11 May 2012 17:07:35 -0700 Subject: Need reviewer and approval Message-ID: <2A9DB745-C8B8-4884-93A3-50F861B9F56A@oracle.com> I'm trying to help the JAX-WS team integrate a new JAX-WS 2.2.4 source drop. 7168374: Upgrade of XML components to JAXB 2.2.4-2, SAAJ 1.3.16, JAXWS 2.2.4-1 http://cr.openjdk.java.net/~ohair/openjdk7u/jaxws224/webrev/ I plan on pushing it into http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxws The JAX-WS team does not have OpenJDK usernames yet, so I need someone with an OpenJDK username for the reviewer. -kto From tim.bell at oracle.com Fri May 11 18:24:39 2012 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 11 May 2012 18:24:39 -0700 Subject: Need reviewer and approval In-Reply-To: <2A9DB745-C8B8-4884-93A3-50F861B9F56A@oracle.com> References: <2A9DB745-C8B8-4884-93A3-50F861B9F56A@oracle.com> Message-ID: <4FADBBD7.9030202@oracle.com> Hi Kelly: > 7168374: Upgrade of XML components to JAXB 2.2.4-2, SAAJ 1.3.16, JAXWS 2.2.4-1 > http://cr.openjdk.java.net/~ohair/openjdk7u/jaxws224/webrev/ > > I plan on pushing it into http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxws > > The JAX-WS team does not have OpenJDK usernames yet, so I need someone with an OpenJDK > username for the reviewer. Looks good to me. Approved. Tim From kelly.ohair at oracle.com Fri May 11 18:49:58 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Sat, 12 May 2012 01:49:58 +0000 Subject: hg: jdk7u/jdk7u-dev/jaxws: 7168374: Upgrade of XML components to JAXB 2.2.4-2, SAAJ 1.3.16, JAXWS 2.2.4-1 Message-ID: <20120512014958.3B911472B3@hg.openjdk.java.net> Changeset: 376cbfcbf785 Author: ohair Date: 2012-05-11 18:48 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxws/rev/376cbfcbf785 7168374: Upgrade of XML components to JAXB 2.2.4-2, SAAJ 1.3.16, JAXWS 2.2.4-1 Summary: JAX-WS review by Martin Grebac Reviewed-by: tbell Contributed-by: Miroslav Kos ! jaxws.properties From kelly.ohair at oracle.com Fri May 11 22:08:24 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 11 May 2012 22:08:24 -0700 Subject: Need reviewer and approval - jaxws drop bundle removal Message-ID: This webrev folds the 2 source drops for jaxws back into the jdk7-dev/jaxws repository: http://cr.openjdk.java.net/~ohair/openjdk7u/jaxws-no-drop/webrev/ I've left out the final steps on pulling in the sources, makes too big of a webrev: sh ./make/scripts/update_src.sh hg add src I verified that the dist/ files created match exactly what it did before this change. -kto From tim.bell at oracle.com Fri May 11 22:26:53 2012 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 11 May 2012 22:26:53 -0700 Subject: Need reviewer and approval - jaxws drop bundle removal In-Reply-To: References: Message-ID: <4FADF49D.5090307@oracle.com> Hi Kelly > This webrev folds the 2 source drops for jaxws back into the jdk7-dev/jaxws repository: > > http://cr.openjdk.java.net/~ohair/openjdk7u/jaxws-no-drop/webrev/ > > I've left out the final steps on pulling in the sources, makes too big of a webrev: > sh ./make/scripts/update_src.sh > hg add src > > I verified that the dist/ files created match exactly what it did before this change. Looks good to me - Approved. Tim From edvard.wendelin at oracle.com Sat May 12 01:14:57 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Sat, 12 May 2012 10:14:57 +0200 Subject: [7u6] request for approval, 7071826: Avoid benign race condition in initialization of UUID In-Reply-To: <9959617A-78C2-4627-A67F-833848D875AE@oracle.com> References: <9959617A-78C2-4627-A67F-833848D875AE@oracle.com> Message-ID: <67A3913A-10E3-40C1-802E-B24E5736CEF9@oracle.com> Approved. On May 11, 2012, at 8:39 PM, Mike Duigou wrote: > Hi, > > This is a request to backport a JDK 8 fix into JDK 7u6: > 7071826: Avoid benign race condition in initialization of UUID > > The fix has already been pushed to JDK 8: > http://hg.openjdk.java.net/jdk8/tl-gate/jdk/rev/944676ef3c58 > > The code changes for jdk7u6 are identical to the ones in jdk8. > > I intend to push it to > ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk > > Thanks! > > Mike From edvard.wendelin at oracle.com Sat May 12 01:15:54 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Sat, 12 May 2012 10:15:54 +0200 Subject: [7u6] Request for approval for bulk integration of hs23.2-b01 In-Reply-To: <4FADB127.8070009@oracle.com> References: <4FADB127.8070009@oracle.com> Message-ID: Approved. On May 12, 2012, at 2:39 AM, Alejandro E Murillo wrote: > Requesting approval to integrate hs23.2-b01 into jdk7u6-b10. > > A webrev is available at: > > http://cr.openjdk.java.net/~amurillo/7u6/hs23.2-b01-jdk7u6-b10.webrev/ > > Pre-integration testing is in progress; the integration will proceed > only after SQE has analyzed the results and approved. > > The fixes in the proposed integration are below. All have undergone > nightly testing and are already in a jdk8 repository. > > 7102323: RFE: enable Full Debug Symbols Phase 1 on Solaris > 7132070: Use a mach_port_t as the OSThread thread_id rather than pthread_t on BSD/OSX > 7152800: All tests using the attach API fail with "well-known file is not secure" on Mac OS X > 7158067: FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect product builds > 7163117: Agent can't connect to process on Mac OSX > 7164344: enabling ZIP_DEBUGINFO_FILES causes unexpected test failures on Solaris and Windows > 7167028: new hotspot build - hs23.2-b01 > 7167266: missing copyright notes in 3rd party code > 7167406: (Zero) Fix for InvokeDynamic needed > > -- > Alejandro E Murillo, Java Performance > Phone: (303) 955-2584. > Timezone: US/Mountain (UTC-0700) > From alexandr.scherbatiy at oracle.com Sat May 12 03:45:52 2012 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Sat, 12 May 2012 14:45:52 +0400 Subject: [7u6] Request for approval for CR 7093156 - NLS: Please change the mnemonic assignment system to avoid translation issue (Swing files) Message-ID: <4FAE3F60.6060400@oracle.com> Hello, This is a request from the NLS team to backport a JDK 8 fix into JDK 7u6. bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7093156 webrev: http://cr.openjdk.java.net/~alexsch/7093156/webrev7.01 review: http://mail.openjdk.java.net/pipermail/swing-dev/2012-May/002049.html JDK 8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cbf39e7a7535 The original JDK 8 patch is rejected when it is applied to JDK 8 because the property files are slightly different between JDK 7 and JDK 8 (for example the JDK 8 basic.properties file has 2 extra properties and the metal.properties file has some extra mnemonics). The properties from the following folders are updated: src/share/classes/com/sun/java/swing/plaf/gtk src/share/classes/com/sun/swing/internal/plaf According to the request from the NLS team the properties, mnemonics and mnemonic indexes are unified from the xxxText, xxxMnemonic and xxxMnemonicIndex to xxx.titleAndMnemonic (different patterns with the different suffixes are checked). The TextAndMnemonicHashMap class is added to the UIDefaults class that now parse requested keys and returns values from the unified properties. The fix is tested by the test that loads all old properties and check that UIManager.get() methods returns the same values as before: http://cr.openjdk.java.net/~alexsch/7093156/test/02/SwingResourcesTest.java Thanks, Alexandr. From edvard.wendelin at oracle.com Sat May 12 04:29:40 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Sat, 12 May 2012 13:29:40 +0200 Subject: JDK 7u6 - Release timeline Message-ID: <4DE10775-2321-444B-9471-961518636BEE@oracle.com> Hi, Since 7u4 is now generally available and the focus has shifted to 7u6, I'd like to outline the timeline for Oracle JDK 7u6. As always, I'd like to remind you that this is just a plan and that it can and probably will change before the release is done. Feature work should be completed by mid May and after that the focus shifts to stabilizing the release. Up until mid June, the release is open for general bug fixes, but after that you should work on P1-P3 bugs only. In the beginning of July the inflow of bug fixes is restricted even further and all changes going in will require critical fix approval. I described how the critical fix approval process works back in February [1]. The same process will be used for 7u6. This means that the number of open bugs targeted to the release will gradually decrease and by the end of July there should be none left. All bugs should now either have been fixed or deferred out to another release. Finally I would also like to encourage you to either test the Oracle JDK 7u6 early access builds posted on java.net or your own OpenJDK build and report issues to http://bugs.sun.com for the former or to the jdk7u-dev mailing list for the latter - if you run into any! Cheers, Edvard [1] http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-February/001900.html From edvard.wendelin at oracle.com Sat May 12 04:31:06 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Sat, 12 May 2012 13:31:06 +0200 Subject: [7u6] Request for approval for CR 7093156 - NLS: Please change the mnemonic assignment system to avoid translation issue (Swing files) In-Reply-To: <4FAE3F60.6060400@oracle.com> References: <4FAE3F60.6060400@oracle.com> Message-ID: Looks good! Approved. On May 12, 2012, at 12:45 PM, Alexander Scherbatiy wrote: > Hello, > > This is a request from the NLS team to backport a JDK 8 fix into JDK 7u6. > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7093156 > webrev: http://cr.openjdk.java.net/~alexsch/7093156/webrev7.01 > review: http://mail.openjdk.java.net/pipermail/swing-dev/2012-May/002049.html > > JDK 8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cbf39e7a7535 > > > The original JDK 8 patch is rejected when it is applied to JDK 8 because the property files are slightly different between JDK 7 and JDK 8 > (for example the JDK 8 basic.properties file has 2 extra properties and the metal.properties file has some extra mnemonics). > > The properties from the following folders are updated: > src/share/classes/com/sun/java/swing/plaf/gtk > src/share/classes/com/sun/swing/internal/plaf > > According to the request from the NLS team the properties, mnemonics and mnemonic indexes are unified from the > xxxText, xxxMnemonic and xxxMnemonicIndex to xxx.titleAndMnemonic (different patterns with the different suffixes are checked). > > The TextAndMnemonicHashMap class is added to the UIDefaults class that now parse requested keys and returns values from the unified properties. > > The fix is tested by the test that loads all old properties and check that UIManager.get() methods returns the same values as before: > http://cr.openjdk.java.net/~alexsch/7093156/test/02/SwingResourcesTest.java > > Thanks, > Alexandr. > > From markus.gronlund at oracle.com Sat May 12 04:34:56 2012 From: markus.gronlund at oracle.com (=?iso-8859-1?B?TWFya3VzIEdy9m5sdW5k?=) Date: Sat, 12 May 2012 04:34:56 -0700 (PDT) Subject: [7u6] Request for approval for CR7154809: JDI: update JDI/JDB debugee commandline option parsing Message-ID: <2a87390d-db5e-4b07-b910-9d756682fece@default> Hi, ? I would like to request for approval for backporting a JDK8 changeset into JDK 7u6. ? Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154809 ? Changeset in JDK8: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/fb52e8bd3718 ? Reviews on JDK8: http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-April/005715.html ? The codebase in JDK7 for this area is identical to JDK8, applying patch gives results equal to already putback changeset in JDK8. ? I would also like to ask for some kindhearted soul which is in possession of the required capabilities/rights to sponsor this putback to JDK7 line since I do not have committer rights. ? Thank you Markus From edvard.wendelin at oracle.com Sat May 12 04:41:31 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Sat, 12 May 2012 13:41:31 +0200 Subject: [7u6] Request for approval for CR7154809: JDI: update JDI/JDB debugee commandline option parsing In-Reply-To: <2a87390d-db5e-4b07-b910-9d756682fece@default> References: <2a87390d-db5e-4b07-b910-9d756682fece@default> Message-ID: <77DF1358-AD7C-4D6C-BDA7-4CE042C21CDB@oracle.com> Approved. Let me know if you don't find a committer and I'll see if I can help out. Cheers, Edvard On May 12, 2012, at 1:34 PM, Markus Gr?nlund wrote: > Hi, > > > > I would like to request for approval for backporting a JDK8 changeset into JDK 7u6. > > > > Bug: > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154809 > > > > Changeset in JDK8: > > http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/fb52e8bd3718 > > > > Reviews on JDK8: > > http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-April/005715.html > > > > The codebase in JDK7 for this area is identical to JDK8, applying patch gives results equal to already putback changeset in JDK8. > > > > I would also like to ask for some kindhearted soul which is in possession of the required capabilities/rights to sponsor this putback to JDK7 line since I do not have committer rights. > > > > Thank you > > Markus From dalibor.topic at oracle.com Sat May 12 04:59:23 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Sat, 12 May 2012 13:59:23 +0200 Subject: JDK 7u6 - Release timeline In-Reply-To: <4DE10775-2321-444B-9471-961518636BEE@oracle.com> References: <4DE10775-2321-444B-9471-961518636BEE@oracle.com> Message-ID: <4FAE509B.7050007@oracle.com> On 5/12/12 1:29 PM, Edvard Wendelin wrote: > Finally I would also like to encourage you to either test the Oracle JDK 7u6 early access builds posted on java.net Here's the direct link to those downloads: http://jdk7.java.net/download.html cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From anthony.petrov at oracle.com Sat May 12 05:13:20 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Sat, 12 May 2012 16:13:20 +0400 Subject: [7u6] Request for approval for CR 7166437: [macosx] Support for Window.Type.UTILITY on the Mac Message-ID: <4FAE53E0.7020901@oracle.com> Bug: http://bugs.sun.com/view_bug.do?bug_id=7166437 Webrev: http://cr.openjdk.java.net/~anthony/7u6-8-UTILITY-7166437.0/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004135.html Reviewers: Sergey Bylokhov, Alexander Zuev -- best regards, Anthony From david.holmes at oracle.com Sat May 12 05:36:53 2012 From: david.holmes at oracle.com (David Holmes) Date: Sat, 12 May 2012 22:36:53 +1000 Subject: Review OSX universal mode patch In-Reply-To: References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> <232B162D-DAE5-45FA-9F1F-3780887D6B54@oracle.com> <4FAC06A1.5080108@oracle.com> <11418A7F-EF9B-4DAC-A79C-AA94FF3F05B3@gmail.com> <4FAC5E7F.8010803@oracle.com> Message-ID: <4FAE5965.9080504@oracle.com> On 12/05/2012 4:17 AM, Mike Swingler wrote: > On May 10, 2012, at 5:34 PM, David Holmes wrote: > >> On 11/05/2012 6:06 AM, Henri Gomez wrote: >>> Happy to see subject back to technical. >>> >>> If you take a closer look to patch, you'll see universal is enforced as ARCH. >> >> My concerns with the patch is the necessity of introducing these platform specific ifdefs into what is notionally shared code - yes there are already ifdefs in there but I still dislike seeing this. And I think the various "arch" variables are being misused in ways that ultimately lead to confusion - the OSX build shouldn't require a completely different understanding of the build system. > > But the OS X build system builds for multiple architectures fundamentally differently than any other toolchain on any other OS. That's basically the problem. If you were defining the build for OSX alone it would likely have a completely different structure. As it is the existing single-architecture based build is not compatible with the notion of "universal" build. > By doing multiple passes on the same file at the same time, the disk cache is most effectively utilized. By simply tacking on additional architecture flags to the CFLAGS, more architectures can be trivially introduced into legacy Makefile projects without wide sweeping changes across the whole project to build into different directories. This is why we introduced concept of the "universal" architecture for the directory names, which could mean "i386", "x64_64", or "i386+x86_64", depending on how you were building. > >> I was not familiar with the Universal build and to be honest it seems to be more of a hindrance than a help. If the build was done as two passes: 32-bit then 64-bit with a stage at the end to produce the universal binary, then bit-specific make variables could continue to work as they were intended - is that possible? > > It's possible, but not easy. Given that we have a solution that works in the here and now, an #ifdef is a small price to pay until the next major build system refactoring occurs. This seems like a hack and I'm surprised there aren't other parts of the build that require similar hacks. We reach a point where the pretense that a file contains (mostly) platform independent code no longer holds and we should refactor into platform specific files. Or we try to find mechanisms for expressing things in a way that don't require platform-specific code. YMMV. This is only my opinion. David ----- >> I also think this should be taken to JDK8 first. > > Of course. > > Regards, > Mike Swingler > Apple Inc. > From kelly.ohair at oracle.com Sat May 12 10:55:19 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Sat, 12 May 2012 10:55:19 -0700 Subject: Need reviewer and approval - jaxws drop bundle removal In-Reply-To: <4FADF49D.5090307@oracle.com> References: <4FADF49D.5090307@oracle.com> Message-ID: <4298B45D-F024-4DE6-8E0B-D8B9D48C9443@oracle.com> On May 11, 2012, at 10:26 PM, Tim Bell wrote: > Hi Kelly > >> This webrev folds the 2 source drops for jaxws back into the jdk7-dev/jaxws repository: >> >> http://cr.openjdk.java.net/~ohair/openjdk7u/jaxws-no-drop/webrev/ >> >> I've left out the final steps on pulling in the sources, makes too big of a webrev: >> sh ./make/scripts/update_src.sh >> hg add src >> >> I verified that the dist/ files created match exactly what it did before this change. > > Looks good to me - Approved. I'll put you down as a reviewer. But I think Edvard or Dalibor would need to approve it for 7updates. ;^) -kto > > Tim > From kelly.ohair at oracle.com Sat May 12 11:10:11 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Sat, 12 May 2012 11:10:11 -0700 Subject: 7u6 Request for approval for CR 7168374: Upgrade of XML components to JAXB 2.2.4-2, SAAJ 1.3.16, JAXWS 2.2.4-1 Message-ID: New CR, may be visible for a few days: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168374 7168374: Upgrade of XML components to JAXB 2.2.4-2, SAAJ 1.3.16, JAXWS 2.2.4-1 http://cr.openjdk.java.net/~ohair/openjdk7u/jaxws224/webrev/ Reviewed-by: tbell -kto From kelly.ohair at oracle.com Sat May 12 11:10:17 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Sat, 12 May 2012 11:10:17 -0700 Subject: 7u6 Request for approval for CR 7150322: Stop using drop source bundles in jaxws Message-ID: <0B37ABF4-A4A7-4CCF-8B46-8A2453C8CD40@oracle.com> Subject: 7u6 Request for approval for CR 7150322: Stop using drop source bundles in jaxws http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7150322 http://cr.openjdk.java.net/~ohair/openjdk7u/jaxws-no-drop/webrev/ http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/f50545b5e2f1 Reviewers: tbell -kto From henri.gomez at gmail.com Sat May 12 11:20:18 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Sat, 12 May 2012 20:20:18 +0200 Subject: Review OSX universal mode patch In-Reply-To: <4FAE5965.9080504@oracle.com> References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> <232B162D-DAE5-45FA-9F1F-3780887D6B54@oracle.com> <4FAC06A1.5080108@oracle.com> <11418A7F-EF9B-4DAC-A79C-AA94FF3F05B3@gmail.com> <4FAC5E7F.8010803@oracle.com> <4FAE5965.9080504@oracle.com> Message-ID: > Or we try to find mechanisms for expressing things in a way that don't > require platform-specific code. > > YMMV. This is only my opinion. And what about my proposal to provide a patch for JDK8 ? If so, will it be included in main branch ? From edvard.wendelin at oracle.com Sun May 13 02:05:15 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Sun, 13 May 2012 11:05:15 +0200 Subject: 7u6 Request for approval for CR 7150322: Stop using drop source bundles in jaxws In-Reply-To: <0B37ABF4-A4A7-4CCF-8B46-8A2453C8CD40@oracle.com> References: <0B37ABF4-A4A7-4CCF-8B46-8A2453C8CD40@oracle.com> Message-ID: Approved! On May 12, 2012, at 8:10 PM, Kelly O'Hair wrote: > Subject: 7u6 Request for approval for CR 7150322: Stop using drop source bundles in jaxws > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7150322 > > http://cr.openjdk.java.net/~ohair/openjdk7u/jaxws-no-drop/webrev/ > > http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/f50545b5e2f1 > > Reviewers: tbell > -kto From edvard.wendelin at oracle.com Sun May 13 02:05:20 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Sun, 13 May 2012 11:05:20 +0200 Subject: 7u6 Request for approval for CR 7168374: Upgrade of XML components to JAXB 2.2.4-2, SAAJ 1.3.16, JAXWS 2.2.4-1 In-Reply-To: References: Message-ID: <064785D2-8808-483C-8A25-DD54E6E8FBB1@oracle.com> Approved :) On May 12, 2012, at 8:10 PM, Kelly O'Hair wrote: > > New CR, may be visible for a few days: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168374 > > 7168374: Upgrade of XML components to JAXB 2.2.4-2, SAAJ 1.3.16, JAXWS 2.2.4-1 > http://cr.openjdk.java.net/~ohair/openjdk7u/jaxws224/webrev/ > > Reviewed-by: tbell > > -kto > > From dalibor.topic at oracle.com Sun May 13 02:27:47 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Sun, 13 May 2012 11:27:47 +0200 Subject: 7u6 Request for approval for CR 7168374: Upgrade of XML components to JAXB 2.2.4-2, SAAJ 1.3.16, JAXWS 2.2.4-1 In-Reply-To: References: Message-ID: <4FAF7E93.8090906@oracle.com> On 5/12/12 8:10 PM, Kelly O'Hair wrote: > > New CR, may be visible for a few days: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168374 As long as we are stuck with the 'sometimes invisible' bug tracker, and the new JIRA isn't in place, please post the description of the CR to this list as part of the request for approval if, as in this case, the description isn't visible. cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From dalibor.topic at oracle.com Sun May 13 04:16:20 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Sun, 13 May 2012 13:16:20 +0200 Subject: Need reviewer and approval - jaxws drop bundle removal In-Reply-To: <4298B45D-F024-4DE6-8E0B-D8B9D48C9443@oracle.com> References: <4FADF49D.5090307@oracle.com> <4298B45D-F024-4DE6-8E0B-D8B9D48C9443@oracle.com> Message-ID: <4FAF9804.7030704@oracle.com> On 5/12/12 7:55 PM, Kelly O'Hair wrote: > But I think Edvard or Dalibor would need to approve it for 7updates. ;^) s/Dalibor/Dalibor or Artem or Sean/ ;) cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From david.holmes at oracle.com Sun May 13 14:51:38 2012 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Sun, 13 May 2012 21:51:38 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7168098: Adjustments for SE-Embedded build process Message-ID: <20120513215148.7DF35472D5@hg.openjdk.java.net> Changeset: 0128a8d8c0b4 Author: dholmes Date: 2012-05-10 23:56 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/0128a8d8c0b4 7168098: Adjustments for SE-Embedded build process Reviewed-by: dholmes Contributed-by: Gary Collins ! make/com/oracle/Makefile ! make/common/Defs-embedded.gmk From david.holmes at oracle.com Sun May 13 21:48:44 2012 From: david.holmes at oracle.com (David Holmes) Date: Mon, 14 May 2012 14:48:44 +1000 Subject: Review OSX universal mode patch In-Reply-To: References: <4FAB796C.9050600@oracle.com> <4FAB924E.8070104@oracle.com> <8FE24D69-9390-483C-B4D6-0B025D28DB04@apple.com> <4FABE415.8010801@oracle.com> <232B162D-DAE5-45FA-9F1F-3780887D6B54@oracle.com> <4FAC06A1.5080108@oracle.com> <11418A7F-EF9B-4DAC-A79C-AA94FF3F05B3@gmail.com> <4FAC5E7F.8010803@oracle.com> <4FAE5965.9080504@oracle.com> Message-ID: <4FB08EAC.5070004@oracle.com> On 13/05/2012 4:20 AM, Henri Gomez wrote: >> Or we try to find mechanisms for expressing things in a way that don't >> require platform-specific code. >> >> YMMV. This is only my opinion. > > And what about my proposal to provide a patch for JDK8 ? > If so, will it be included in main branch ? That's a non-technical question. I can't answer it. David From alexandr.scherbatiy at oracle.com Mon May 14 07:20:55 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Mon, 14 May 2012 14:20:55 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7093156: NLS Please change the mnemonic assignment system to avoid translation issue (Swing files) Message-ID: <20120514142112.D19DF472E9@hg.openjdk.java.net> Changeset: ab8bb05a32c7 Author: alexsch Date: 2012-05-14 18:17 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/ab8bb05a32c7 7093156: NLS Please change the mnemonic assignment system to avoid translation issue (Swing files) Reviewed-by: rupashka, alexp ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_de.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_es.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_fr.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_it.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_ja.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_ko.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_sv.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_de.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_es.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_it.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_de.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_es.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_it.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_TW.properties ! src/share/classes/javax/swing/UIDefaults.java From alexandr.scherbatiy at oracle.com Mon May 14 07:38:28 2012 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Mon, 14 May 2012 18:38:28 +0400 Subject: [7u6] Request for approval for CR 7024963 - Notepad demo: remove non-translatable resources from Notepad.properties file Message-ID: <4FB118E4.3080601@oracle.com> Hello, This is a request from the NLS team to backport a JDK 8 fix into JDK 7u6: 7024963 - Notepad demo: remove non-translatable resources from Notepad.properties file http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7024963 The fix has already been pushed to JDK 8, as: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a714e2e2b257 The code changes for jdk7u4 are identical to the ones in jdk8. Thank you, Alexandr. From alexandr.scherbatiy at oracle.com Mon May 14 07:43:30 2012 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Mon, 14 May 2012 18:43:30 +0400 Subject: [7u6] Request for approval for CR 7024965 - Stylepad demo: remove non-translatable resources from Stylepad.properties file Message-ID: <4FB11A12.5040604@oracle.com> Hello, This is a request from the NLS team to backport a JDK 8 fix into JDK 7u6: 7024965 - Stylepad demo: remove non-translatable resources from Stylepad.properties file http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7024965 The fix has already been pushed to JDK 8, as: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3b8635e357e9 The code changes for jdk7u6 are identical to the ones in jdk8. Thank you, Alexandr. From edvard.wendelin at oracle.com Mon May 14 13:40:50 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Mon, 14 May 2012 22:40:50 +0200 Subject: [7u6] Request for approval for CR 7166437: [macosx] Support for Window.Type.UTILITY on the Mac In-Reply-To: <4FAE53E0.7020901@oracle.com> References: <4FAE53E0.7020901@oracle.com> Message-ID: <6ED17FAA-8BF3-406F-9F6C-18C71B405720@oracle.com> Approved. On May 12, 2012, at 2:13 PM, Anthony Petrov wrote: > Bug: http://bugs.sun.com/view_bug.do?bug_id=7166437 > Webrev: http://cr.openjdk.java.net/~anthony/7u6-8-UTILITY-7166437.0/ > Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004135.html > Reviewers: Sergey Bylokhov, Alexander Zuev > > -- > best regards, > Anthony > > From edvard.wendelin at oracle.com Mon May 14 13:41:01 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Mon, 14 May 2012 22:41:01 +0200 Subject: [7u6] Request for approval for CR 7024963 - Notepad demo: remove non-translatable resources from Notepad.properties file In-Reply-To: <4FB118E4.3080601@oracle.com> References: <4FB118E4.3080601@oracle.com> Message-ID: Approved. On May 14, 2012, at 4:38 PM, Alexander Scherbatiy wrote: > > Hello, > > This is a request from the NLS team to backport a JDK 8 fix into JDK 7u6: > > 7024963 - Notepad demo: remove non-translatable resources from Notepad.properties file > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7024963 > > The fix has already been pushed to JDK 8, as: > http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a714e2e2b257 > > The code changes for jdk7u4 are identical to the ones in jdk8. > > Thank you, > Alexandr. > From edvard.wendelin at oracle.com Mon May 14 13:41:06 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Mon, 14 May 2012 22:41:06 +0200 Subject: [7u6] Request for approval for CR 7024965 - Stylepad demo: remove non-translatable resources from Stylepad.properties file In-Reply-To: <4FB11A12.5040604@oracle.com> References: <4FB11A12.5040604@oracle.com> Message-ID: <0319A89E-0EE8-47AF-B413-48C35F4B8BAD@oracle.com> Approved. On May 14, 2012, at 4:43 PM, Alexander Scherbatiy wrote: > Hello, > > This is a request from the NLS team to backport a JDK 8 fix into JDK 7u6: > > 7024965 - Stylepad demo: remove non-translatable resources from Stylepad.properties file > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7024965 > > The fix has already been pushed to JDK 8, as: > http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3b8635e357e9 > > > The code changes for jdk7u6 are identical to the ones in jdk8. > > Thank you, > Alexandr. > From lana.steuck at oracle.com Mon May 14 17:22:08 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 15 May 2012 00:22:08 +0000 Subject: hg: jdk7u/jdk7u: 3 new changesets Message-ID: <20120515002208.3220247301@hg.openjdk.java.net> Changeset: 7ffd73535b8e Author: ewendeli Date: 2012-05-03 14:17 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/rev/7ffd73535b8e 7154130: Add Mac OS X Instructions to README-builds.html Reviewed-by: ohair Contributed-by: edvard.wendelin at oracle.com ! README-builds.html Changeset: f66a691daa1d Author: lana Date: 2012-05-09 17:52 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/rev/f66a691daa1d Merge Changeset: 5f3645aa920d Author: lana Date: 2012-05-14 16:43 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/rev/5f3645aa920d Merge From lana.steuck at oracle.com Mon May 14 17:22:18 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 15 May 2012 00:22:18 +0000 Subject: hg: jdk7u/jdk7u/jdk: 14 new changesets Message-ID: <20120515002444.244F847302@hg.openjdk.java.net> Changeset: a841553a32a1 Author: jgodinez Date: 2012-04-25 14:40 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/a841553a32a1 7157659: [macosx] Landscape Printing orientation doesn't work Reviewed-by: bae, prr ! src/macosx/native/sun/awt/PrinterView.m Changeset: 577d848527e4 Author: jgodinez Date: 2012-04-26 13:54 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/577d848527e4 7013850: Please change the mnemonic assignment system to avoid translation issue Reviewed-by: prr, mfang ! src/share/classes/sun/print/ServiceDialog.java ! src/share/classes/sun/print/resources/serviceui.properties ! src/share/classes/sun/print/resources/serviceui_de.properties ! src/share/classes/sun/print/resources/serviceui_es.properties ! src/share/classes/sun/print/resources/serviceui_fr.properties ! src/share/classes/sun/print/resources/serviceui_it.properties ! src/share/classes/sun/print/resources/serviceui_ja.properties ! src/share/classes/sun/print/resources/serviceui_ko.properties ! src/share/classes/sun/print/resources/serviceui_pt_BR.properties ! src/share/classes/sun/print/resources/serviceui_sv.properties ! src/share/classes/sun/print/resources/serviceui_zh_CN.properties ! src/share/classes/sun/print/resources/serviceui_zh_TW.properties Changeset: ad07d945ee92 Author: amenkov Date: 2012-04-27 10:58 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/ad07d945ee92 7100140: [macosx] Test closed/javax/sound/sampled/DirectAudio/bug6400879.java is invalid Reviewed-by: prr + test/javax/sound/sampled/DirectAudio/bug6400879.java Changeset: 57bc0bd2677e Author: sla Date: 2012-04-23 16:34 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/57bc0bd2677e 7163524: Add SecTaskAccess attribute to jstack [macosx] Reviewed-by: dholmes ! make/launchers/Makefile.launcher Changeset: 61906002d2a2 Author: alexp Date: 2012-04-27 18:27 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/61906002d2a2 7124328: [macosx] javax.swing.JDesktopPane.getAllFramesInLayer returns unexpected value Reviewed-by: anthony ! src/share/classes/javax/swing/JDesktopPane.java Changeset: 9fb41ec54d94 Author: alexp Date: 2012-04-27 18:39 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/9fb41ec54d94 7124210: [macosx] Replacing text in a TextField does generate an extra TextEvent Reviewed-by: serb ! src/macosx/classes/sun/lwawt/LWTextAreaPeer.java ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java Changeset: f7e9f377bb5e Author: michaelm Date: 2012-04-27 15:27 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/f7e9f377bb5e 7162043: Add headless mode tests to problem list [macosx] Reviewed-by: alanb ! test/ProblemList.txt - test/java/io/File/isDirectory/Applet.java Changeset: 1e3829d2447c Author: lana Date: 2012-04-30 21:02 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/1e3829d2447c Merge Changeset: ddb615988fbf Author: kizune Date: 2012-05-03 22:18 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/ddb615988fbf 7148289: [macosx] Deadlock in sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame Reviewed-by: anthony ! src/macosx/classes/sun/lwawt/macosx/CToolkitThreadBlockedHandler.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/LWCToolkit.m Changeset: b4a447259412 Author: khazra Date: 2012-05-03 21:27 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/b4a447259412 7118100: (prefs) Inconsistency when using system and user preference on OSX Lion Summary: Enable user to read/write preferences to persistent storage Reviewed-by: alanb ! src/macosx/classes/java/util/prefs/MacOSXPreferences.java ! src/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java Changeset: 8888021b9bae Author: dcherepanov Date: 2012-05-04 19:33 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/8888021b9bae 7154062: [macosx] Mouse cursor isn't updated in applets Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/macosx/CCursorManager.java ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java ! src/macosx/native/sun/awt/CCursorManager.m Changeset: 6bf2990ade5d Author: leonidr Date: 2012-05-05 14:17 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/6bf2990ade5d 7124376: [macosx] Modal dialog lost focus Reviewed-by: kizune ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/PlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.h ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 42162f9c522b Author: lana Date: 2012-05-09 17:52 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/42162f9c522b Merge - test/java/io/File/isDirectory/Applet.java Changeset: a2bd61800667 Author: lana Date: 2012-05-14 16:44 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/a2bd61800667 Merge From lana.steuck at oracle.com Mon May 14 17:29:40 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 14 May 2012 17:29:40 -0700 (PDT) Subject: jdk7u-b10: jdk7u-dev Message-ID: <201205150029.q4F0Tevo010420@jano-app.us.oracle.com> http://hg.openjdk.java.net/jdk7u/jdk7u/rev/5f3645aa920d http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/21d2313dfeac http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/a2bd61800667 http://hg.openjdk.java.net/jdk7u/jdk7u/jaxws/rev/c08f88f5ae98 http://hg.openjdk.java.net/jdk7u/jdk7u/jaxp/rev/f4e80156296e http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/103fc6756e1e http://hg.openjdk.java.net/jdk7u/jdk7u/corba/rev/c9f6750370c9 --- All the fixes will be tested during promotion (no PIT testing at this point): 7154130 java build Update build readme to include OS X Lion instructions 7013850 java classes_2d Please change the mnemonic assignment system to avoid transl 7157659 java classes_2d [macosx] Landscape Printing orientation doesn't work 7124210 java classes_awt [macosx] Replacing text in a TextField does generate an extr 7124376 java classes_awt [macosx] Modal dialog lost focus 7148289 java classes_awt [macosx] Deadlock in sun.lwawt.macosx.CWrapper$NSScreen.visi 7154062 java classes_awt [macosx] Mouse cursor isn't updated in applets 7100140 java classes_sound [macosx] Test closed/javax/sound/sampled/DirectAudio/bug6400 7124328 java classes_swing [macosx] javax.swing.JDesktopPane.getAllFramesInLayer return 7118100 java classes_util (prefs) Inconsistency when using system and user preference 7146792 java classes_util_i18 closed/java/util/TimeZone/CheckTzdataVersion.sh failing on W 7162043 java other Add headless mode tests to problem list [macosx] 7163524 java serviceability Add SecTaskAccess attribute to jstack [macosx] From alexandr.scherbatiy at oracle.com Tue May 15 00:39:15 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Tue, 15 May 2012 07:39:15 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7024963: Notepad demo: remove non-translatable resources from Notepad.properties file Message-ID: <20120515073940.3786C4730E@hg.openjdk.java.net> Changeset: e4c3092a3a0e Author: alexsch Date: 2012-05-15 11:38 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/e4c3092a3a0e 7024963: Notepad demo: remove non-translatable resources from Notepad.properties file Reviewed-by: rupashka ! src/share/demo/jfc/Notepad/Notepad.java ! src/share/demo/jfc/Notepad/resources/Notepad.properties + src/share/demo/jfc/Notepad/resources/system.properties From alexandr.scherbatiy at oracle.com Tue May 15 00:46:48 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Tue, 15 May 2012 07:46:48 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7024965: Stylepad demo: remove non-translatable resources from Stylepad.properties file Message-ID: <20120515074659.0649C4730F@hg.openjdk.java.net> Changeset: eb7b250d92e6 Author: alexsch Date: 2012-05-15 11:45 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/eb7b250d92e6 7024965: Stylepad demo: remove non-translatable resources from Stylepad.properties file Reviewed-by: alexp ! src/share/demo/jfc/Notepad/Notepad.java + src/share/demo/jfc/Notepad/resources/NotepadSystem.properties - src/share/demo/jfc/Notepad/resources/system.properties From anthony.petrov at oracle.com Tue May 15 04:25:17 2012 From: anthony.petrov at oracle.com (anthony.petrov at oracle.com) Date: Tue, 15 May 2012 11:25:17 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7166437: [macosx] Support for Window.Type.UTILITY on the Mac Message-ID: <20120515112547.D4A0947317@hg.openjdk.java.net> Changeset: fa84dc221972 Author: anthony Date: 2012-05-15 15:24 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/fa84dc221972 7166437: [macosx] Support for Window.Type.UTILITY on the Mac Summary: Apply the native UTILITY style to Java UTILITY windows Reviewed-by: kizune, serb ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java From anthony.petrov at oracle.com Tue May 15 05:56:55 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 15 May 2012 16:56:55 +0400 Subject: [7u6] Request for approval for CR 7149062: [macosx] dock menu don't show available frames Message-ID: <4FB25297.8020302@oracle.com> This is a back port of the same fix from JDK 8. Bug: http://bugs.sun.com/view_bug.do?bug_id=7149062 Webrev: http://cr.openjdk.java.net/~anthony/7u6-9-windowListInDockMenu-7149062.0/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004140.html Reviewers: Mike Swingler -- best regards, Anthony From edvard.wendelin at oracle.com Tue May 15 06:17:15 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Tue, 15 May 2012 15:17:15 +0200 Subject: [7u6] Request for approval for CR 7149062: [macosx] dock menu don't show available frames In-Reply-To: <4FB25297.8020302@oracle.com> References: <4FB25297.8020302@oracle.com> Message-ID: <4FB2575B.6010308@oracle.com> Approved. On 05/15/2012 02:56 PM, Anthony Petrov wrote: > This is a back port of the same fix from JDK 8. > > Bug: http://bugs.sun.com/view_bug.do?bug_id=7149062 > Webrev: > http://cr.openjdk.java.net/~anthony/7u6-9-windowListInDockMenu-7149062.0/ > Review thread: > http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004140.html > Reviewers: Mike Swingler > > -- > best regards, > Anthony > > > From anthony.petrov at oracle.com Tue May 15 06:29:56 2012 From: anthony.petrov at oracle.com (anthony.petrov at oracle.com) Date: Tue, 15 May 2012 13:29:56 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7149062: [macosx] dock menu don't show available frames Message-ID: <20120515133015.D9BBB4731C@hg.openjdk.java.net> Changeset: b5b68b7b6aa6 Author: anthony Date: 2012-05-15 17:29 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/b5b68b7b6aa6 7149062: [macosx] dock menu don't show available frames Summary: Use either NSWindow or NSPanel as an ancestor for Java windows. NSWindow-based windows will be added to the dock icon menu. Reviewed-by: swingler ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.h ! src/macosx/native/sun/awt/AWTWindow.m From Sergey.Bylokhov at oracle.com Tue May 15 07:42:27 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 15 May 2012 18:42:27 +0400 Subject: [7u6] Request for approval: 7160623 [macosx] Editable TextArea/TextField are blocking GUI applications from exit Message-ID: <4FB26B53.3040305@oracle.com> Hi Everyone, This is a back port from jdk 8 to jdk 7u6. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7160623 jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c31eeeda3ed1 Webrev can be found at: http://cr.openjdk.java.net/~serb/7160623/webrev.00 Technical review: http://mail.openjdk.java.net/pipermail/awt-dev/2012-May/002709.html Reviewers: Anthony Petrov , Alexander Zuev -- Best regards, Sergey. From michael.fang at oracle.com Tue May 15 11:36:06 2012 From: michael.fang at oracle.com (Michael Fang) Date: Tue, 15 May 2012 11:36:06 -0700 Subject: [7u6] Request for approval for CR 7157855: jvisualvm.1 not included in binaries In-Reply-To: <4FB25297.8020302@oracle.com> References: <4FB25297.8020302@oracle.com> Message-ID: <4FB2A216.5050805@oracle.com> This fix is also addressed in jdk8 at the same time. Bug: http://bugs.sun.com/view_bug.do?bug_id=7157855 Webrev: http://cr.openjdk.java.net/~mfang/7157855/ Reviewers: katleman, thurka thanks, -michael From rob.mckenna at oracle.com Tue May 15 13:34:50 2012 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Tue, 15 May 2012 20:34:50 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7166687: InetAddress.getLocalHost().getHostName() returns FQDN Message-ID: <20120515203502.0CA134732A@hg.openjdk.java.net> Changeset: 9bf4105ce716 Author: robm Date: 2012-05-15 21:35 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/9bf4105ce716 7166687: InetAddress.getLocalHost().getHostName() returns FQDN Reviewed-by: chegar ! src/solaris/native/java/net/Inet6AddressImpl.c From kurchi.subhra.hazra at oracle.com Tue May 15 14:41:06 2012 From: kurchi.subhra.hazra at oracle.com (Kurchi Hazra) Date: Tue, 15 May 2012 14:41:06 -0700 Subject: [7u6] Request for approval: 7096436: (sc) SocketChannel.connect fails on Windows 8 when channel configured non-blocking Message-ID: <4FB2CD72.8040300@oracle.com> Requesting approval to commit fix for CR 7096436. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7096436 Webrev: http://cr.openjdk.java.net/~khazra/7096436/7u6/webrev.00/ This had been reviewed by Alan Bateman. [1] This fix has been pushed into jdk8 [2] Thanks, Kurchi [1] http://mail.openjdk.java.net/pipermail/nio-dev/2012-May/001653.html [2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5152c832745a From john.coomes at oracle.com Tue May 15 15:08:07 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Tue, 15 May 2012 22:08:07 +0000 Subject: hg: jdk7u/jdk7u-dev/hotspot: 14 new changesets Message-ID: <20120515220835.43F0D4732E@hg.openjdk.java.net> Changeset: 94d7a305da4d Author: katleman Date: 2012-05-02 14:13 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/94d7a305da4d Added tag jdk7u6-b08 for changeset 6b668c1049a8 ! .hgtags Changeset: 103fc6756e1e Author: katleman Date: 2012-05-10 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/103fc6756e1e Added tag jdk7u6-b09 for changeset 94d7a305da4d ! .hgtags Changeset: c1d1c84a2124 Author: amurillo Date: 2012-05-07 14:54 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/c1d1c84a2124 7167028: new hotspot build - hs23.2-b01 Reviewed-by: jcoomes ! make/hotspot_version Changeset: adaa2f10c81b Author: sla Date: 2012-02-19 13:11 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/adaa2f10c81b 7132070: Use a mach_port_t as the OSThread thread_id rather than pthread_t on BSD/OSX Summary: Change OSThread to use mach thread_t Reviewed-by: phh, dcubed ! src/cpu/x86/vm/vm_version_x86.cpp ! src/os/bsd/vm/osThread_bsd.cpp ! src/os/bsd/vm/osThread_bsd.hpp ! src/os/bsd/vm/os_bsd.cpp ! src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp ! src/share/vm/utilities/globalDefinitions_gcc.hpp Changeset: 8bf0501658ef Author: sla Date: 2012-03-19 20:13 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/8bf0501658ef 7152800: All tests using the attach API fail with "well-known file is not secure" on Mac OS X Summary: Create well-known file with effective group of the current process Reviewed-by: kamg, dcubed ! src/os/bsd/vm/attachListener_bsd.cpp Changeset: d652a62d6e03 Author: dcubed Date: 2012-03-23 11:50 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/d652a62d6e03 7102323: RFE: enable Full Debug Symbols Phase 1 on Solaris Summary: Add support for ENABLE_FULL_DEBUG_SYMBOLS and ZIP_DEBUGINFO_FILES build flags. Add support for .diz files. Reviewed-by: dholmes, ohair, sspitsyn ! make/Makefile ! make/linux/Makefile ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/jsig.make ! make/linux/makefiles/saproc.make ! make/linux/makefiles/vm.make ! make/solaris/Makefile ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/jsig.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/vm.make ! make/windows/build.make ! make/windows/makefiles/compile.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/defs.make ! make/windows/makefiles/fastdebug.make ! make/windows/makefiles/product.make ! make/windows/makefiles/sa.make Changeset: 744728c16316 Author: dcubed Date: 2012-04-03 09:48 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/744728c16316 7158067: FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect product builds Summary: Build option FULL_DEBUG_SYMBOLS=0 only affects product builds. Reviewed-by: ohair, jmelvin, sspitsyn ! make/Makefile ! make/linux/Makefile ! make/linux/makefiles/defs.make ! make/solaris/Makefile ! make/solaris/makefiles/defs.make ! make/windows/makefiles/defs.make Changeset: 0653bc115ff5 Author: dcubed Date: 2012-05-08 11:37 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/0653bc115ff5 Merge Changeset: 690f89a699b1 Author: dcubed Date: 2012-05-08 11:40 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/690f89a699b1 7164344: enabling ZIP_DEBUGINFO_FILES causes unexpected test failures on Solaris and Windows Summary: Disable FDS by default on Solaris; disable ZIP_DEBUGINFO_FILES by default on Windows. Reviewed-by: acorn, sspitsyn ! make/solaris/makefiles/defs.make ! make/windows/makefiles/defs.make Changeset: 28392714005e Author: kvn Date: 2012-05-08 15:47 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/28392714005e 7167266: missing copyright notes in 3rd party code Summary: add missing copyright notes to the regression test file. Reviewed-by: twisti, johnc ! test/compiler/7070134/Stemmer.java Changeset: 1a9c601a5395 Author: dholmes Date: 2012-05-09 00:28 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/1a9c601a5395 7167406: (Zero) Fix for InvokeDynamic needed Reviewed-by: chrisphi, dholmes Contributed-by: Andrew Dinn ! src/cpu/zero/vm/cppInterpreter_zero.cpp Changeset: 1fcba869fe4a Author: nloodin Date: 2012-05-09 16:24 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/1fcba869fe4a 7163117: Agent can't connect to process on Mac OSX Reviewed-by: dholmes, coleenp, sla, minqi, kvn ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdCDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThreadContextFactory.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerClient.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java Changeset: b65719ad597b Author: amurillo Date: 2012-05-11 11:19 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/b65719ad597b Added tag hs23.2-b01 for changeset 1fcba869fe4a ! .hgtags Changeset: 702b62a5e1a5 Author: amurillo Date: 2012-05-11 11:52 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/702b62a5e1a5 Merge ! .hgtags ! make/hotspot_version ! src/cpu/x86/vm/vm_version_x86.cpp From john.coomes at oracle.com Tue May 15 15:16:58 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Tue, 15 May 2012 22:16:58 +0000 Subject: hg: jdk7u/jdk7u/hotspot: 12 new changesets Message-ID: <20120515221725.068944732F@hg.openjdk.java.net> Changeset: c1d1c84a2124 Author: amurillo Date: 2012-05-07 14:54 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/c1d1c84a2124 7167028: new hotspot build - hs23.2-b01 Reviewed-by: jcoomes ! make/hotspot_version Changeset: adaa2f10c81b Author: sla Date: 2012-02-19 13:11 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/adaa2f10c81b 7132070: Use a mach_port_t as the OSThread thread_id rather than pthread_t on BSD/OSX Summary: Change OSThread to use mach thread_t Reviewed-by: phh, dcubed ! src/cpu/x86/vm/vm_version_x86.cpp ! src/os/bsd/vm/osThread_bsd.cpp ! src/os/bsd/vm/osThread_bsd.hpp ! src/os/bsd/vm/os_bsd.cpp ! src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp ! src/share/vm/utilities/globalDefinitions_gcc.hpp Changeset: 8bf0501658ef Author: sla Date: 2012-03-19 20:13 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/8bf0501658ef 7152800: All tests using the attach API fail with "well-known file is not secure" on Mac OS X Summary: Create well-known file with effective group of the current process Reviewed-by: kamg, dcubed ! src/os/bsd/vm/attachListener_bsd.cpp Changeset: d652a62d6e03 Author: dcubed Date: 2012-03-23 11:50 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/d652a62d6e03 7102323: RFE: enable Full Debug Symbols Phase 1 on Solaris Summary: Add support for ENABLE_FULL_DEBUG_SYMBOLS and ZIP_DEBUGINFO_FILES build flags. Add support for .diz files. Reviewed-by: dholmes, ohair, sspitsyn ! make/Makefile ! make/linux/Makefile ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/jsig.make ! make/linux/makefiles/saproc.make ! make/linux/makefiles/vm.make ! make/solaris/Makefile ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/jsig.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/vm.make ! make/windows/build.make ! make/windows/makefiles/compile.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/defs.make ! make/windows/makefiles/fastdebug.make ! make/windows/makefiles/product.make ! make/windows/makefiles/sa.make Changeset: 744728c16316 Author: dcubed Date: 2012-04-03 09:48 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/744728c16316 7158067: FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect product builds Summary: Build option FULL_DEBUG_SYMBOLS=0 only affects product builds. Reviewed-by: ohair, jmelvin, sspitsyn ! make/Makefile ! make/linux/Makefile ! make/linux/makefiles/defs.make ! make/solaris/Makefile ! make/solaris/makefiles/defs.make ! make/windows/makefiles/defs.make Changeset: 0653bc115ff5 Author: dcubed Date: 2012-05-08 11:37 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/0653bc115ff5 Merge Changeset: 690f89a699b1 Author: dcubed Date: 2012-05-08 11:40 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/690f89a699b1 7164344: enabling ZIP_DEBUGINFO_FILES causes unexpected test failures on Solaris and Windows Summary: Disable FDS by default on Solaris; disable ZIP_DEBUGINFO_FILES by default on Windows. Reviewed-by: acorn, sspitsyn ! make/solaris/makefiles/defs.make ! make/windows/makefiles/defs.make Changeset: 28392714005e Author: kvn Date: 2012-05-08 15:47 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/28392714005e 7167266: missing copyright notes in 3rd party code Summary: add missing copyright notes to the regression test file. Reviewed-by: twisti, johnc ! test/compiler/7070134/Stemmer.java Changeset: 1a9c601a5395 Author: dholmes Date: 2012-05-09 00:28 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/1a9c601a5395 7167406: (Zero) Fix for InvokeDynamic needed Reviewed-by: chrisphi, dholmes Contributed-by: Andrew Dinn ! src/cpu/zero/vm/cppInterpreter_zero.cpp Changeset: 1fcba869fe4a Author: nloodin Date: 2012-05-09 16:24 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/1fcba869fe4a 7163117: Agent can't connect to process on Mac OSX Reviewed-by: dholmes, coleenp, sla, minqi, kvn ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdCDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThreadContextFactory.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerClient.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java Changeset: b65719ad597b Author: amurillo Date: 2012-05-11 11:19 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/b65719ad597b Added tag hs23.2-b01 for changeset 1fcba869fe4a ! .hgtags Changeset: 702b62a5e1a5 Author: amurillo Date: 2012-05-11 11:52 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/702b62a5e1a5 Merge ! .hgtags ! make/hotspot_version ! src/cpu/x86/vm/vm_version_x86.cpp From alejandro.murillo at oracle.com Tue May 15 15:29:04 2012 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Tue, 15 May 2012 16:29:04 -0600 Subject: jdk7u6-b10: HotSpot Message-ID: <4FB2D8B0.4090305@oracle.com> hs23.2-b01 has been integrated into jdk7u6-b10. http://hg.openjdk.java.net/jdk7u/jdk7u/rev/5f3645aa920d http://hg.openjdk.java.net/jdk7u/jdk7u/corba/rev/c9f6750370c9 http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/702b62a5e1a5 http://hg.openjdk.java.net/jdk7u/jdk7u/jaxp/rev/f4e80156296e http://hg.openjdk.java.net/jdk7u/jdk7u/jaxws/rev/c08f88f5ae98 http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/a2bd61800667 http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/21d2313dfeac Component : VM Status : 0 major failures, 0 minor failures Date : 15/06/2012 at 12:30 Tested By : VM SQE& kirill.zhaldybin at oracle.com Cost(total man-days): 5 Workspace : 2012-05-11-182559.amurillo.hs23-2-b01-snapshot Bundles : 2012-05-11-182559.amurillo.hs23-2-b01-snapshot Platforms : Others Tests :/net/sqenfs-1.sfbay/export1/comp/vm/testbase/ Browsers : NA Patches : NA Logs :http://vmsqe-app.russia.sun.com/surl/JY Number of Tests Executed : 40000 product tests, 0 unit tests, 0 tck tests Bug verification status: ====================================== Tested, Pass: 7163117: Agent can't connect to process on Mac OSX 7158067: FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect product builds 7167028: new hotspot build - hs23.2-b01 7167266: missing copyright notes in 3rd party code Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: Setup is not available: Build change only: 7132070: Use a mach_port_t as the OSThread thread_id rather than pthread_t on BSD/OSX 7152800: All tests using the attach API fail with "well-known file is not secure" on Mac OS X 7102323: RFE: enable Full Debug Symbols Phase 1 on Solaris 7164344: enabling ZIP_DEBUGINFO_FILES causes unexpected test failures on Solaris and Windows 7167406: (Zero) Fix for InvokeDynamic needed New bugs filed: Bugs in PIT build: 7168903: Crash in PSPromotionManager::claim_or_forward_internal_depth Bugs in earlier promoted build: Number of PIT requested: 1 Integration target J2SE build number: 1.7.0_06-b10 Issues and Notes: This PIT for HS23.2 b01 for JDK7u6 b10 ------------------------------- From VM SQE& kirill.zhaldybin at oracle.com -- Alejandro E Murillo, Java Performance Phone: (303) 955-2584. Timezone: US/Mountain (UTC-0700) From jonathan.gibbons at oracle.com Tue May 15 17:47:33 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 16 May 2012 00:47:33 +0000 Subject: hg: jdk7u/jdk7u-dev/langtools: 7112427: The doclet needs to be able to generate JavaFX documentation. Message-ID: <20120516004735.E717747334@hg.openjdk.java.net> Changeset: b020b7a017cc Author: jjg Date: 2012-05-15 17:47 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/b020b7a017cc 7112427: The doclet needs to be able to generate JavaFX documentation. Reviewed-by: jjg Contributed-by: jan.valenta at oracle.com ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java + src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlConstants.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/PropertyWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/WriterFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/BuilderFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PropertyBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties + src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BasePropertyTaglet.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/PropertyGetterTaglet.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/PropertySetterTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/IndexBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java + test/com/sun/javadoc/testJavaFX/C.java + test/com/sun/javadoc/testJavaFX/D.java + test/com/sun/javadoc/testJavaFX/TestJavaFX.java From edvard.wendelin at oracle.com Wed May 16 00:21:57 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Wed, 16 May 2012 09:21:57 +0200 Subject: [7u6] Request for approval: 7160623 [macosx] Editable TextArea/TextField are blocking GUI applications from exit In-Reply-To: <4FB26B53.3040305@oracle.com> References: <4FB26B53.3040305@oracle.com> Message-ID: <85CF92BA-BD2E-4622-AECC-BF8F92F2FFC5@oracle.com> Approved. On May 15, 2012, at 4:42 PM, Sergey Bylokhov wrote: > Hi Everyone, > This is a back port from jdk 8 to jdk 7u6. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7160623 > jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c31eeeda3ed1 > Webrev can be found at: http://cr.openjdk.java.net/~serb/7160623/webrev.00 > Technical review: http://mail.openjdk.java.net/pipermail/awt-dev/2012-May/002709.html > Reviewers: Anthony Petrov , Alexander Zuev > > -- > Best regards, Sergey. > From edvard.wendelin at oracle.com Wed May 16 00:22:19 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Wed, 16 May 2012 09:22:19 +0200 Subject: [7u6] Request for approval: 7096436: (sc) SocketChannel.connect fails on Windows 8 when channel configured non-blocking In-Reply-To: <4FB2CD72.8040300@oracle.com> References: <4FB2CD72.8040300@oracle.com> Message-ID: <454D294C-3E1B-434B-96FE-A27E95552147@oracle.com> Approved. On May 15, 2012, at 11:41 PM, Kurchi Hazra wrote: > > Requesting approval to commit fix for CR 7096436. > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7096436 > Webrev: http://cr.openjdk.java.net/~khazra/7096436/7u6/webrev.00/ > > This had been reviewed by Alan Bateman. [1] > > This fix has been pushed into jdk8 [2] > > Thanks, > Kurchi > > [1] http://mail.openjdk.java.net/pipermail/nio-dev/2012-May/001653.html > [2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5152c832745a > From alexandr.scherbatiy at oracle.com Wed May 16 06:28:45 2012 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Wed, 16 May 2012 17:28:45 +0400 Subject: [7u6] Request for approval for CR 7169226 - NLS: Please change the mnemonic assignment system for windows and motif properties Message-ID: <4FB3AB8D.8020700@oracle.com> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7169226 webrev: http://cr.openjdk.java.net/~alexsch/7169226/webrev7.00/ review: http://mail.openjdk.java.net/pipermail/swing-dev/2012-May/002054.html JDK 8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3c819d638e36 This is a request from the NLS team to backport the issue 7169226 to JDK 7. The original JDK 8 patch is rejected when it is applied to JDK 8 because the JDK 8 windows and motif properties contain mnemonics however the JDK 7 version not. The properties from the following folders are updated: src/share/classes/com/sun/java/swing/plaf/windows/resources/ src/share/classes/com/sun/java/swing/plaf/motif/resources According to the request from the NLS team the properties, mnemonics and mnemonic indexes are unified from the xxxText, xxxMnemonic and xxxMnemonicIndex to xxx.titleAndMnemonic (different patterns with the different suffixes are checked). The fix is tested by the test that loads all old properties and check that UIManager.get() methods returns the same values as before: http://cr.openjdk.java.net/~alexsch/7093156/test/02/SwingResourcesTest.java Thanks, Alexandr. From edvard.wendelin at oracle.com Wed May 16 06:33:47 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Wed, 16 May 2012 15:33:47 +0200 Subject: [7u6] Request for approval for CR 7169226 - NLS: Please change the mnemonic assignment system for windows and motif properties In-Reply-To: <4FB3AB8D.8020700@oracle.com> References: <4FB3AB8D.8020700@oracle.com> Message-ID: Approved. On May 16, 2012, at 3:28 PM, Alexander Scherbatiy wrote: > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7169226 > webrev: http://cr.openjdk.java.net/~alexsch/7169226/webrev7.00/ > review: http://mail.openjdk.java.net/pipermail/swing-dev/2012-May/002054.html > > JDK 8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3c819d638e36 > > This is a request from the NLS team to backport the issue 7169226 to JDK 7. > The original JDK 8 patch is rejected when it is applied to JDK 8 because the JDK 8 windows and motif properties contain mnemonics however the JDK 7 version not. > > The properties from the following folders are updated: > src/share/classes/com/sun/java/swing/plaf/windows/resources/ > src/share/classes/com/sun/java/swing/plaf/motif/resources > > According to the request from the NLS team the properties, mnemonics and mnemonic indexes are unified from the > xxxText, xxxMnemonic and xxxMnemonicIndex to xxx.titleAndMnemonic (different patterns with the different suffixes are checked). > > The fix is tested by the test that loads all old properties and check that UIManager.get() methods returns the same values as before: > http://cr.openjdk.java.net/~alexsch/7093156/test/02/SwingResourcesTest.java > > Thanks, > Alexandr. > > From alexandr.scherbatiy at oracle.com Wed May 16 07:24:39 2012 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Wed, 16 May 2012 18:24:39 +0400 Subject: [7u6] Request for approval for CR 7158928 - [macosx] NLS: Please change the mnemonic assignment system Message-ID: <4FB3B8A7.3080205@oracle.com> Hello, This is a request from the NLS team to backport a JDK 8 fix into JDK 7u6: 7158928 - [macosx] NLS: Please change the mnemonic assignment system http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7158928 The fix has already been pushed to JDK 8, as: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/19edcc438203 The code changes for jdk7u6 are identical to the ones in jdk8. Thank you, Alexandr. From alexandr.scherbatiy at oracle.com Wed May 16 07:57:27 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Wed, 16 May 2012 14:57:27 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7169226: NLS: Please change the mnemonic assignment system for windows and motif properties Message-ID: <20120516145809.48CDD47351@hg.openjdk.java.net> Changeset: 20171c9ae8eb Author: alexsch Date: 2012-05-16 18:56 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/20171c9ae8eb 7169226: NLS: Please change the mnemonic assignment system for windows and motif properties Reviewed-by: rupashka ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_de.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_es.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_fr.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_it.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ja.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ko.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_sv.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_TW.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_de.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_es.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_fr.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_it.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ja.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ko.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_sv.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_TW.properties From edvard.wendelin at oracle.com Wed May 16 11:07:54 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Wed, 16 May 2012 20:07:54 +0200 Subject: [7u6] Request for approval for CR 7157855: jvisualvm.1 not included in binaries In-Reply-To: <4FB2A216.5050805@oracle.com> References: <4FB25297.8020302@oracle.com> <4FB2A216.5050805@oracle.com> Message-ID: Sorry for the delay. Approved. On May 15, 2012, at 8:36 PM, Michael Fang wrote: > This fix is also addressed in jdk8 at the same time. > > Bug: http://bugs.sun.com/view_bug.do?bug_id=7157855 > Webrev: http://cr.openjdk.java.net/~mfang/7157855/ > Reviewers: katleman, thurka > > thanks, > > -michael From edvard.wendelin at oracle.com Wed May 16 11:47:52 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Wed, 16 May 2012 20:47:52 +0200 Subject: [7u6] Request for approval for CR 7158928 - [macosx] NLS: Please change the mnemonic assignment system In-Reply-To: <4FB3B8A7.3080205@oracle.com> References: <4FB3B8A7.3080205@oracle.com> Message-ID: <17AB9259-07F3-4FD6-A881-651303922E57@oracle.com> Approved. On May 16, 2012, at 4:24 PM, Alexander Scherbatiy wrote: > > Hello, > > This is a request from the NLS team to backport a JDK 8 fix into JDK 7u6: > > 7158928 - [macosx] NLS: Please change the mnemonic assignment system > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7158928 > > The fix has already been pushed to JDK 8, as: > http://hg.openjdk.java.net/jdk8/awt/jdk/rev/19edcc438203 > > > The code changes for jdk7u6 are identical to the ones in jdk8. > > Thank you, > Alexandr. > From michael.fang at oracle.com Wed May 16 12:19:59 2012 From: michael.fang at oracle.com (michael.fang at oracle.com) Date: Wed, 16 May 2012 19:19:59 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 2 new changesets Message-ID: <20120516192029.1FA1147363@hg.openjdk.java.net> Changeset: c743f3d53835 Author: mfang Date: 2012-05-16 12:01 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/c743f3d53835 7157855: jvisualvm.1 not included in binaries Reviewed-by: katleman, thurka ! make/common/Release.gmk Changeset: 7f2d38ddd4e8 Author: mfang Date: 2012-05-16 12:06 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/7f2d38ddd4e8 Merge From Abhi.Saha at Oracle.COM Wed May 16 14:10:00 2012 From: Abhi.Saha at Oracle.COM (Abhijit Saha) Date: Wed, 16 May 2012 14:10:00 -0700 Subject: [7u6] Request for approval for CR 7156842 - test/java/util/zip/ZipFile/vmcrash.zip triggers McAffe virus warning Message-ID: <4FB417A8.7020301@Oracle.COM> This is a request to remove testcases. AntiVirus software systems flagged a zip file checked in to the ZipFile test directory as being infected. Testcase was rewritten and moved to jdk/close/test forest. webrev: http://cr.openjdk.java.net/~asaha/7156842/ Thanks Abhijit -- Release Lead, Java SE Updates Java Platform Group Oracle Corporation. (408)276-7564 From kelly.ohair at oracle.com Wed May 16 17:08:34 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 16 May 2012 17:08:34 -0700 Subject: [7u6] Request for approval for CR 7156842 - test/java/util/zip/ZipFile/vmcrash.zip triggers McAffe virus warning In-Reply-To: <4FB417A8.7020301@Oracle.COM> References: <4FB417A8.7020301@Oracle.COM> Message-ID: <6325A015-778F-4DFB-8CD5-1B652DE03357@oracle.com> Just curious..... Will we be making these kind of changes whenever a Anti-Virus program mis-identifies a file as being a virus or malware? Seems like a workaround fix, which we seem to accept for occasional OS or compiler bugs, do we now include anti-virus software workarounds? -kto On May 16, 2012, at 2:10 PM, Abhijit Saha wrote: > This is a request to remove testcases. AntiVirus software systems flagged a zip file checked in to the ZipFile test directory as being infected. > Testcase was rewritten and moved to jdk/close/test forest. > > webrev: http://cr.openjdk.java.net/~asaha/7156842/ > > > Thanks > Abhijit > > -- > Release Lead, Java SE Updates > Java Platform Group > Oracle Corporation. > (408)276-7564 > From alexandr.scherbatiy at oracle.com Thu May 17 03:13:40 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Thu, 17 May 2012 10:13:40 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7158928: [macosx] NLS: Please change the mnemonic assignment system Message-ID: <20120517101407.67E924737F@hg.openjdk.java.net> Changeset: b92ca4e51f9a Author: alexsch Date: 2012-05-17 14:15 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/b92ca4e51f9a 7158928: [macosx] NLS: Please change the mnemonic assignment system Reviewed-by: rupashka, serb ! make/com/apple/osxui/Makefile ! make/common/internal/Resources.gmk ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java ! src/macosx/classes/com/apple/laf/resources/aqua.properties From alan.bateman at oracle.com Thu May 17 04:12:46 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 17 May 2012 11:12:46 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7096436: (sc) SocketChannel.connect fails on Windows 8 when channel configured non-blocking Message-ID: <20120517111258.58D9547381@hg.openjdk.java.net> Changeset: 064518e6c298 Author: khazra Date: 2012-05-17 12:12 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/064518e6c298 7096436: (sc) SocketChannel.connect fails on Windows 8 when channel configured non-blocking Reviewed-by: alanb ! src/share/classes/sun/nio/ch/SocketChannelImpl.java From sean.coffey at oracle.com Thu May 17 04:54:11 2012 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Thu, 17 May 2012 12:54:11 +0100 Subject: [7u6] Request for approval for CR 7143744: (se) Stabilize KQueue SelectorProvider and make default on MacOSX Message-ID: <4FB4E6E3.4040409@oracle.com> I'd like to backport the recent work on the mac OS KQueue SelectorProvider from jdk8 to 7u6. Identical code changes. JDK 8 changeset : http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0f34986d1c5 Bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7143744 Regards, Sean. From sean.coffey at oracle.com Thu May 17 04:56:47 2012 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Thu, 17 May 2012 12:56:47 +0100 Subject: [7u6] Request for approval for CR 7127235: (fs) NPE in Files.walkFileTree if cached attributes are GC'ed Message-ID: <4FB4E77F.8020705@oracle.com> I'd like to backport this recent fix from jdk8 to 7u. bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127235 JDK 8 changeset : http://hg.openjdk.java.net/jdk8/tl/jdk/rev/400cc379adb5 regards, Sean. From sean.coffey at oracle.com Thu May 17 05:31:00 2012 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Thu, 17 May 2012 13:31:00 +0100 Subject: [7u6] Request for approval for CR 7103889: (fs) Reduce String concatenation when iterating over directory Message-ID: <4FB4EF84.5070700@oracle.com> Makes sense to backport some recent work done in JDK 8 to 7u. identical changes. JDK 8 changeset : http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb2b9a8b6e77 bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7103889 regards, Sean. From daniel.daugherty at oracle.com Thu May 17 08:05:35 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 17 May 2012 09:05:35 -0600 Subject: [7u6] Request for approval for CR 7168520 No jdk8 TL Nightly linux builds due to broken link in b39-2012-05-13_231 Message-ID: <4FB513BF.7050008@oracle.com> Greetings, This is a request to backport a JDK 8 fix into JDK 7u6: 7168520 1/3 No jdk8 TL Nightly linux builds due to broken link in b39-2012-05-13_231 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168520 The fix has recently been pushed to JDK 8, as: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce165aa48dcb and will be included in the JDK8-B42 PIT snapshot. I've requested a respin of the JDK8-B40 PIT snapshot, but I haven't gotten confirmation yet. This fix has been reviewed on build-dev at openjdk.java.net: http://mail.openjdk.java.net/pipermail/build-dev/2012-May/006158.html and hotspot-runtime-dev at openjdk.java.net: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2012-May/003708.html and serviceability-dev at openjdk.java.net: http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-May/006065.html The three review threads are currently identical. The JDK7u6 and JDK8 jdk repo patch files are identical. Dan From edvard.wendelin at oracle.com Thu May 17 12:06:18 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Thu, 17 May 2012 21:06:18 +0200 Subject: [7u6] Request for approval for CR 7156842 - test/java/util/zip/ZipFile/vmcrash.zip triggers McAffe virus warning In-Reply-To: <4FB417A8.7020301@Oracle.COM> References: <4FB417A8.7020301@Oracle.COM> Message-ID: <140CB4FE-FBCF-44DF-8BD6-2712B1921BDF@oracle.com> Hi, Has this change been reviewed by an OpenJDK reviewer? I don't have reviewer status, so you will need that before I can approve it. Cheers, Edvard On May 16, 2012, at 11:10 PM, Abhijit Saha wrote: > This is a request to remove testcases. AntiVirus software systems flagged a zip file checked in to the ZipFile test directory as being infected. > Testcase was rewritten and moved to jdk/close/test forest. > > webrev: http://cr.openjdk.java.net/~asaha/7156842/ > > > Thanks > Abhijit > > -- > Release Lead, Java SE Updates > Java Platform Group > Oracle Corporation. > (408)276-7564 > From edvard.wendelin at oracle.com Thu May 17 12:06:57 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Thu, 17 May 2012 21:06:57 +0200 Subject: [7u6] Request for approval for CR 7168520 No jdk8 TL Nightly linux builds due to broken link in b39-2012-05-13_231 In-Reply-To: <4FB513BF.7050008@oracle.com> References: <4FB513BF.7050008@oracle.com> Message-ID: <28858820-6E09-423D-9678-017A86A47E21@oracle.com> Approved. On May 17, 2012, at 5:05 PM, Daniel D. Daugherty wrote: > Greetings, > > This is a request to backport a JDK 8 fix into JDK 7u6: > > 7168520 1/3 No jdk8 TL Nightly linux builds due to broken link in > b39-2012-05-13_231 > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168520 > > The fix has recently been pushed to JDK 8, as: > > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce165aa48dcb > > and will be included in the JDK8-B42 PIT snapshot. I've requested > a respin of the JDK8-B40 PIT snapshot, but I haven't gotten > confirmation yet. > > This fix has been reviewed on build-dev at openjdk.java.net: > > http://mail.openjdk.java.net/pipermail/build-dev/2012-May/006158.html > > and hotspot-runtime-dev at openjdk.java.net: > > http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2012-May/003708.html > > and serviceability-dev at openjdk.java.net: > > http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-May/006065.html > > The three review threads are currently identical. > > The JDK7u6 and JDK8 jdk repo patch files are identical. > > Dan From edvard.wendelin at oracle.com Thu May 17 12:07:52 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Thu, 17 May 2012 21:07:52 +0200 Subject: [7u6] Request for approval for CR 7143744: (se) Stabilize KQueue SelectorProvider and make default on MacOSX In-Reply-To: <4FB4E6E3.4040409@oracle.com> References: <4FB4E6E3.4040409@oracle.com> Message-ID: <9DC3F7A1-3318-4FB2-8354-DEB6CE389EA0@oracle.com> Approved. On May 17, 2012, at 1:54 PM, Se?n Coffey wrote: > I'd like to backport the recent work on the mac OS KQueue SelectorProvider from jdk8 to 7u6. > > Identical code changes. > > JDK 8 changeset : http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0f34986d1c5 > Bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7143744 > > Regards, > Sean. From edvard.wendelin at oracle.com Thu May 17 12:08:12 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Thu, 17 May 2012 21:08:12 +0200 Subject: [7u6] Request for approval for CR 7127235: (fs) NPE in Files.walkFileTree if cached attributes are GC'ed In-Reply-To: <4FB4E77F.8020705@oracle.com> References: <4FB4E77F.8020705@oracle.com> Message-ID: <6B28269D-F695-4375-8000-D758D73D042D@oracle.com> Approved. On May 17, 2012, at 1:56 PM, Se?n Coffey wrote: > I'd like to backport this recent fix from jdk8 to 7u. > > bug report : > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127235 > JDK 8 changeset : > > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/400cc379adb5 > > regards, > Sean. > From Abhi.Saha at Oracle.COM Thu May 17 12:12:49 2012 From: Abhi.Saha at Oracle.COM (Abhijit Saha) Date: Thu, 17 May 2012 12:12:49 -0700 Subject: [7u6] Request for approval for CR 7156842 - test/java/util/zip/ZipFile/vmcrash.zip triggers McAffe virus warning In-Reply-To: <140CB4FE-FBCF-44DF-8BD6-2712B1921BDF@oracle.com> References: <4FB417A8.7020301@Oracle.COM> <140CB4FE-FBCF-44DF-8BD6-2712B1921BDF@oracle.com> Message-ID: <4FB54DB1.2010403@Oracle.COM> On 5/17/2012 12:06 PM, Edvard Wendelin wrote: > Hi, > > Has this change been reviewed by an OpenJDK reviewer? I don't have reviewer status, so you will need that before I can approve it. Reviewed by : sherman Thanks Abhijit > > Cheers, > Edvard > > On May 16, 2012, at 11:10 PM, Abhijit Saha wrote: > >> This is a request to remove testcases. AntiVirus software systems flagged a zip file checked in to the ZipFile test directory as being infected. >> Testcase was rewritten and moved to jdk/close/test forest. >> >> webrev: http://cr.openjdk.java.net/~asaha/7156842/ >> >> >> Thanks >> Abhijit >> >> -- >> Release Lead, Java SE Updates >> Java Platform Group >> Oracle Corporation. >> (408)276-7564 >> -- Release Lead, Java SE Updates Java Platform Group Oracle Corporation. (408)276-7564 From edvard.wendelin at oracle.com Thu May 17 12:09:37 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Thu, 17 May 2012 21:09:37 +0200 Subject: [7u6] Request for approval for CR 7103889: (fs) Reduce String concatenation when iterating over directory In-Reply-To: <4FB4EF84.5070700@oracle.com> References: <4FB4EF84.5070700@oracle.com> Message-ID: <24F99EE5-630D-4756-B9A1-FD46728035D3@oracle.com> Approved. On May 17, 2012, at 2:31 PM, Se?n Coffey wrote: > Makes sense to backport some recent work done in JDK 8 to 7u. > > identical changes. JDK 8 changeset : http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb2b9a8b6e77 > bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7103889 > > regards, > Sean. From edvard.wendelin at oracle.com Thu May 17 12:20:18 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Thu, 17 May 2012 21:20:18 +0200 Subject: [7u6] Request for approval for CR 7156842 - test/java/util/zip/ZipFile/vmcrash.zip triggers McAffe virus warning In-Reply-To: <4FB54DB1.2010403@Oracle.COM> References: <4FB417A8.7020301@Oracle.COM> <140CB4FE-FBCF-44DF-8BD6-2712B1921BDF@oracle.com> <4FB54DB1.2010403@Oracle.COM> Message-ID: <640803AE-26C3-497D-8DD7-7949DC0C27A1@oracle.com> Good to go! If it's applicable to 8, please make sure the fix gets pushed there as well! Cheers, Edvard On May 17, 2012, at 9:12 PM, Abhijit Saha wrote: > On 5/17/2012 12:06 PM, Edvard Wendelin wrote: >> Hi, >> >> Has this change been reviewed by an OpenJDK reviewer? I don't have reviewer status, so you will need that before I can approve it. > Reviewed by : sherman > > Thanks > Abhijit >> >> Cheers, >> Edvard >> >> On May 16, 2012, at 11:10 PM, Abhijit Saha wrote: >> >>> This is a request to remove testcases. AntiVirus software systems flagged a zip file checked in to the ZipFile test directory as being infected. >>> Testcase was rewritten and moved to jdk/close/test forest. >>> >>> webrev: http://cr.openjdk.java.net/~asaha/7156842/ >>> >>> >>> Thanks >>> Abhijit >>> >>> -- >>> Release Lead, Java SE Updates >>> Java Platform Group >>> Oracle Corporation. >>> (408)276-7564 >>> > > -- > Release Lead, Java SE Updates > Java Platform Group > Oracle Corporation. > (408)276-7564 > From abhi.saha at oracle.com Thu May 17 12:38:29 2012 From: abhi.saha at oracle.com (abhi.saha at oracle.com) Date: Thu, 17 May 2012 19:38:29 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7156842: test/java/util/zip/ZipFile/vmcrash.zip triggers McAffe virus warning Message-ID: <20120517193850.EA1DE47394@hg.openjdk.java.net> Changeset: 90588888a082 Author: asaha Date: 2012-05-17 12:35 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/90588888a082 7156842: test/java/util/zip/ZipFile/vmcrash.zip triggers McAffe virus warning Reviewed-by: sherman - test/java/util/zip/ZipFile/VmCrash.java - test/java/util/zip/ZipFile/vmcrash.zip From dalibor.topic at oracle.com Thu May 17 12:39:10 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Thu, 17 May 2012 21:39:10 +0200 Subject: [7u6] Request for approval for CR 7156842 - test/java/util/zip/ZipFile/vmcrash.zip triggers McAffe virus warning In-Reply-To: <4FB417A8.7020301@Oracle.COM> References: <4FB417A8.7020301@Oracle.COM> Message-ID: <4FB553DE.7020101@oracle.com> On 5/16/12 11:10 PM, Abhijit Saha wrote: > This is a request to remove testcases. AntiVirus software systems flagged a zip file checked in to the ZipFile test directory as being infected. > Testcase was rewritten and moved to jdk/close/test forest. > Why didn't the test case stay in the open? cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From xueming.shen at oracle.com Thu May 17 13:03:43 2012 From: xueming.shen at oracle.com (Xueming Shen) Date: Thu, 17 May 2012 13:03:43 -0700 Subject: [7u6] Request for approval for CR 7156842 - test/java/util/zip/ZipFile/vmcrash.zip triggers McAffe virus warning In-Reply-To: <140CB4FE-FBCF-44DF-8BD6-2712B1921BDF@oracle.com> References: <4FB417A8.7020301@Oracle.COM> <140CB4FE-FBCF-44DF-8BD6-2712B1921BDF@oracle.com> Message-ID: <4FB5599F.9070505@oracle.com> I have reviewed the change, please put my name as the reviewer. -Sherman On 05/17/2012 12:06 PM, Edvard Wendelin wrote: > Hi, > > Has this change been reviewed by an OpenJDK reviewer? I don't have reviewer status, so you will need that before I can approve it. > > Cheers, > Edvard > > On May 16, 2012, at 11:10 PM, Abhijit Saha wrote: > >> This is a request to remove testcases. AntiVirus software systems flagged a zip file checked in to the ZipFile test directory as being infected. >> Testcase was rewritten and moved to jdk/close/test forest. >> >> webrev: http://cr.openjdk.java.net/~asaha/7156842/ >> >> >> Thanks >> Abhijit >> >> -- >> Release Lead, Java SE Updates >> Java Platform Group >> Oracle Corporation. >> (408)276-7564 >> From xueming.shen at oracle.com Thu May 17 13:40:57 2012 From: xueming.shen at oracle.com (Xueming Shen) Date: Thu, 17 May 2012 13:40:57 -0700 Subject: [7u6] Request for approval for CR 7156842 - test/java/util/zip/ZipFile/vmcrash.zip triggers McAffe virus warning In-Reply-To: <4FB553DE.7020101@oracle.com> References: <4FB417A8.7020301@Oracle.COM> <4FB553DE.7020101@oracle.com> Message-ID: <4FB56259.5010109@oracle.com> The test was mistakenly pushed into jdk7u forest back to 7u3. -Sherman On 05/17/2012 12:39 PM, Dalibor Topic wrote: > On 5/16/12 11:10 PM, Abhijit Saha wrote: >> This is a request to remove testcases. AntiVirus software systems flagged a zip file checked in to the ZipFile test directory as being infected. >> Testcase was rewritten and moved to jdk/close/test forest. >> > Why didn't the test case stay in the open? > > cheers, > dalibor topic > > From daniel.daugherty at oracle.com Thu May 17 14:30:14 2012 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Thu, 17 May 2012 21:30:14 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7168520: No jdk8 TL Nightly linux builds due to broken link in b39-2012-05-13_231 Message-ID: <20120517213026.62AC34739E@hg.openjdk.java.net> Changeset: a9cf66e39b38 Author: dcubed Date: 2012-05-17 12:41 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/a9cf66e39b38 7168520: No jdk8 TL Nightly linux builds due to broken link in b39-2012-05-13_231 Summary: ZIP libjsig.debuginfo links into libjsig.diz files since aurora doesn't like dangling symlinks Reviewed-by: katleman, acorn ! make/java/redist/Makefile From rob.mckenna at oracle.com Thu May 17 14:45:58 2012 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 17 May 2012 22:45:58 +0100 Subject: request for approval, 7168110: Misleading jstack error message Message-ID: <4FB57196.8050106@oracle.com> Hi, I'd like to request approval to push 7168110 into 7u. Its a trivial change that fixes cleans up a cryptic error message. It has already been pushed to jdk8 (and is identical to that change): http://cr.openjdk.java.net/~robm/7168110/webrev.01/ -Rob From david.katleman at oracle.com Thu May 17 15:05:38 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 May 2012 22:05:38 +0000 Subject: hg: jdk7u/jdk7u: Added tag jdk7u6-b10 for changeset 5f3645aa920d Message-ID: <20120517220538.1D649473A1@hg.openjdk.java.net> Changeset: cd64596c2dd7 Author: katleman Date: 2012-05-17 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/rev/cd64596c2dd7 Added tag jdk7u6-b10 for changeset 5f3645aa920d ! .hgtags From david.katleman at oracle.com Thu May 17 15:05:43 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 May 2012 22:05:43 +0000 Subject: hg: jdk7u/jdk7u/corba: Added tag jdk7u6-b10 for changeset c9f6750370c9 Message-ID: <20120517220543.A5118473A2@hg.openjdk.java.net> Changeset: a2089d3bf5a0 Author: katleman Date: 2012-05-17 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/corba/rev/a2089d3bf5a0 Added tag jdk7u6-b10 for changeset c9f6750370c9 ! .hgtags From david.katleman at oracle.com Thu May 17 15:06:22 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 May 2012 22:06:22 +0000 Subject: hg: jdk7u/jdk7u/hotspot: Added tag jdk7u6-b10 for changeset 702b62a5e1a5 Message-ID: <20120517220624.38CD9473A3@hg.openjdk.java.net> Changeset: 3be0dd52ccda Author: katleman Date: 2012-05-17 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/3be0dd52ccda Added tag jdk7u6-b10 for changeset 702b62a5e1a5 ! .hgtags From david.katleman at oracle.com Thu May 17 15:07:49 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 May 2012 22:07:49 +0000 Subject: hg: jdk7u/jdk7u/jaxp: Added tag jdk7u6-b10 for changeset f4e80156296e Message-ID: <20120517220751.51825473A4@hg.openjdk.java.net> Changeset: 5078a73b3448 Author: katleman Date: 2012-05-17 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jaxp/rev/5078a73b3448 Added tag jdk7u6-b10 for changeset f4e80156296e ! .hgtags From david.katleman at oracle.com Thu May 17 15:07:57 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 May 2012 22:07:57 +0000 Subject: hg: jdk7u/jdk7u/jaxws: Added tag jdk7u6-b10 for changeset c08f88f5ae98 Message-ID: <20120517220757.687D5473A5@hg.openjdk.java.net> Changeset: a37ad8f90c7b Author: katleman Date: 2012-05-17 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jaxws/rev/a37ad8f90c7b Added tag jdk7u6-b10 for changeset c08f88f5ae98 ! .hgtags From david.katleman at oracle.com Thu May 17 15:08:05 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 May 2012 22:08:05 +0000 Subject: hg: jdk7u/jdk7u/jdk: Added tag jdk7u6-b10 for changeset a2bd61800667 Message-ID: <20120517220815.EDA97473A6@hg.openjdk.java.net> Changeset: 18a1b4f0681a Author: katleman Date: 2012-05-17 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/18a1b4f0681a Added tag jdk7u6-b10 for changeset a2bd61800667 ! .hgtags From david.katleman at oracle.com Thu May 17 15:09:31 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 May 2012 22:09:31 +0000 Subject: hg: jdk7u/jdk7u/langtools: Added tag jdk7u6-b10 for changeset 21d2313dfeac Message-ID: <20120517220933.D512B473A7@hg.openjdk.java.net> Changeset: 13d3c6242916 Author: katleman Date: 2012-05-17 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/13d3c6242916 Added tag jdk7u6-b10 for changeset 21d2313dfeac ! .hgtags From mike.duigou at oracle.com Thu May 17 15:32:26 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 17 May 2012 22:32:26 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7071826: Avoid benign race condition in initialization of UUID Message-ID: <20120517223236.F04E9473A9@hg.openjdk.java.net> Changeset: 6f9e7feeac32 Author: mduigou Date: 2012-05-11 11:31 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/6f9e7feeac32 7071826: Avoid benign race condition in initialization of UUID Summary: Avoids mostly benign but sometimes expensive race condition on initialization of UUID.numberGenerator which is used by UUID.randomUUID() Reviewed-by: alanb, chegar ! src/share/classes/java/util/UUID.java ! test/java/util/UUID/UUIDTest.java From edvard.wendelin at oracle.com Thu May 17 22:31:43 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Fri, 18 May 2012 07:31:43 +0200 Subject: request for approval, 7168110: Misleading jstack error message In-Reply-To: <4FB57196.8050106@oracle.com> References: <4FB57196.8050106@oracle.com> Message-ID: <8D0E54EA-0B07-44D8-B770-3290636207F4@oracle.com> Approved. On May 17, 2012, at 11:45 PM, Rob McKenna wrote: > Hi, > > I'd like to request approval to push 7168110 into 7u. Its a trivial change that fixes cleans up a cryptic error message. It has already been pushed to jdk8 (and is identical to that change): > > http://cr.openjdk.java.net/~robm/7168110/webrev.01/ > > -Rob From sean.coffey at oracle.com Fri May 18 02:49:48 2012 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Fri, 18 May 2012 09:49:48 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 3 new changesets Message-ID: <20120518095135.BC40E473D3@hg.openjdk.java.net> Changeset: e7e8ca3601e7 Author: alanb Date: 2012-05-18 10:47 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/e7e8ca3601e7 7143744: (se) Stabilize KQueue SelectorProvider and make default on MacOSX Reviewed-by: michaelm, chegar ! src/macosx/classes/sun/nio/ch/DefaultSelectorProvider.java ! src/macosx/classes/sun/nio/ch/KQueueArrayWrapper.java ! src/macosx/classes/sun/nio/ch/KQueueSelectorImpl.java ! src/macosx/classes/sun/nio/ch/KQueueSelectorProvider.java ! src/macosx/native/sun/nio/ch/KQueueArrayWrapper.c ! test/java/nio/channels/Selector/OpRead.java ! test/sun/nio/ch/SelProvider.java Changeset: d0673deb4510 Author: alanb Date: 2012-05-18 10:48 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/d0673deb4510 7127235: (fs) NPE in Files.walkFileTree if cached attributes are GC'ed Reviewed-by: forax, chegar ! src/share/classes/java/nio/file/FileTreeWalker.java Changeset: ae1beadd3870 Author: coffeys Date: 2012-05-18 10:50 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/ae1beadd3870 7103889: (fs) Reduce String concatenation when iterating over directory Reviewed-by: alanb Contributed-by: mike.skells at talk21.com ! src/share/classes/java/nio/file/Files.java ! src/windows/classes/sun/nio/fs/WindowsDirectoryStream.java ! src/windows/classes/sun/nio/fs/WindowsPathParser.java From anthony.petrov at oracle.com Fri May 18 07:16:58 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 18 May 2012 18:16:58 +0400 Subject: [7u6] Request for approval for CR 7144542: [macosx] Crash in liblwawt.dylib setBusy() when exiting an FX app run with j2d pipeline Message-ID: <4FB659DA.20008@oracle.com> Bug: http://bugs.sun.com/view_bug.do?bug_id=7144542 Webrev: http://cr.openjdk.java.net/~anthony/7u6-6-crashInSetBusy-7144542.1/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004192.html Reviewers: Artem Ananiev -- best regards, Anthony From edvard.wendelin at oracle.com Fri May 18 10:01:54 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Fri, 18 May 2012 19:01:54 +0200 Subject: [7u6] Request for approval for CR 7144542: [macosx] Crash in liblwawt.dylib setBusy() when exiting an FX app run with j2d pipeline In-Reply-To: <4FB659DA.20008@oracle.com> References: <4FB659DA.20008@oracle.com> Message-ID: <66C9F9B6-0E46-4F11-8D8C-C8AF026D8085@oracle.com> Approved. Please push to JDK 8 first, if you haven't done so already. /Edvard On May 18, 2012, at 4:16 PM, Anthony Petrov wrote: > Bug: http://bugs.sun.com/view_bug.do?bug_id=7144542 > Webrev: http://cr.openjdk.java.net/~anthony/7u6-6-crashInSetBusy-7144542.1/ > Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004192.html > Reviewers: Artem Ananiev > > -- > best regards, > Anthony > > > > From kelly.ohair at oracle.com Fri May 18 14:24:16 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Fri, 18 May 2012 21:24:16 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7166956: Integrate the Java Access Bridge with Java Runtime Message-ID: <20120518212432.599F2473F0@hg.openjdk.java.net> Changeset: e15839c985d1 Author: raginip Date: 2012-05-18 14:22 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/e15839c985d1 7166956: Integrate the Java Access Bridge with Java Runtime Reviewed-by: ohair, ptbrunet ! make/Makefile + make/bridge/AccessBridgeJava/Makefile + make/bridge/JAWTAccessBridge/Files_cpp.gmk + make/bridge/JAWTAccessBridge/Makefile + make/bridge/Jabswitch/Makefile + make/bridge/Jaccess/Makefile + make/bridge/JavaAccessBridge/Files_cpp.gmk + make/bridge/JavaAccessBridge/Makefile + make/bridge/Makefile + make/bridge/WindowsAccessBridge/Files_cpp.gmk + make/bridge/WindowsAccessBridge/Makefile From alejandro.murillo at oracle.com Fri May 18 15:32:48 2012 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Fri, 18 May 2012 16:32:48 -0600 Subject: [7u6] Request for approval for bulk integration of hs23.2-b02 Message-ID: <4FB6CE10.1010405@oracle.com> Requesting approval to integrate hs23.2-b02 into jdk7u6-b11. A webrev is available at: http://cr.openjdk.java.net/~amurillo/7u6/hs23.2-b02-jdk7u6-b11.webrev/ Pre-integration testing is in progress; the integration will proceed only after SQE has analyzed the results and approved. The fixes in the proposed integration are below. All have undergone nightly testing and are already in a jdk8 repository. 7167625: Adjustments for SE-Embedded build process 7168249: new hotspot build - hs23.2-b02 -- Alejandro E Murillo, Java Performance Phone: (303) 955-2584. Timezone: US/Mountain (UTC-0700) From lana.steuck at oracle.com Fri May 18 15:34:46 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 May 2012 22:34:46 +0000 Subject: hg: jdk7u/jdk7u-dev: 5 new changesets Message-ID: <20120518223446.437CA473F3@hg.openjdk.java.net> Changeset: 01001f439af7 Author: katleman Date: 2012-05-02 14:13 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/rev/01001f439af7 Added tag jdk7u6-b08 for changeset 09182be47ee9 ! .hgtags Changeset: 1816f0ef00b4 Author: katleman Date: 2012-05-10 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/rev/1816f0ef00b4 Added tag jdk7u6-b09 for changeset 01001f439af7 ! .hgtags Changeset: f66a691daa1d Author: lana Date: 2012-05-09 17:52 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/rev/f66a691daa1d Merge Changeset: 5f3645aa920d Author: lana Date: 2012-05-14 16:43 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/rev/5f3645aa920d Merge Changeset: cd64596c2dd7 Author: katleman Date: 2012-05-17 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/rev/cd64596c2dd7 Added tag jdk7u6-b10 for changeset 5f3645aa920d ! .hgtags From lana.steuck at oracle.com Fri May 18 15:34:46 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 May 2012 22:34:46 +0000 Subject: hg: jdk7u/jdk7u-dev/corba: 3 new changesets Message-ID: <20120518223450.596E4473F4@hg.openjdk.java.net> Changeset: 13faa12cfdd6 Author: katleman Date: 2012-05-02 14:13 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/corba/rev/13faa12cfdd6 Added tag jdk7u6-b08 for changeset 7df162b43e6e ! .hgtags Changeset: c9f6750370c9 Author: katleman Date: 2012-05-10 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/corba/rev/c9f6750370c9 Added tag jdk7u6-b09 for changeset 13faa12cfdd6 ! .hgtags Changeset: a2089d3bf5a0 Author: katleman Date: 2012-05-17 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/corba/rev/a2089d3bf5a0 Added tag jdk7u6-b10 for changeset c9f6750370c9 ! .hgtags From lana.steuck at oracle.com Fri May 18 15:34:46 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 May 2012 22:34:46 +0000 Subject: hg: jdk7u/jdk7u-dev/hotspot: Added tag jdk7u6-b10 for changeset 702b62a5e1a5 Message-ID: <20120518223450.99126473F5@hg.openjdk.java.net> Changeset: 3be0dd52ccda Author: katleman Date: 2012-05-17 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/3be0dd52ccda Added tag jdk7u6-b10 for changeset 702b62a5e1a5 ! .hgtags From lana.steuck at oracle.com Fri May 18 15:34:50 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 May 2012 22:34:50 +0000 Subject: hg: jdk7u/jdk7u-dev/jaxp: 3 new changesets Message-ID: <20120518223456.32BE5473F6@hg.openjdk.java.net> Changeset: 52d82754ec69 Author: katleman Date: 2012-05-02 14:14 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/52d82754ec69 Added tag jdk7u6-b08 for changeset cf61740310b4 ! .hgtags Changeset: f4e80156296e Author: katleman Date: 2012-05-10 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/f4e80156296e Added tag jdk7u6-b09 for changeset 52d82754ec69 ! .hgtags Changeset: 5078a73b3448 Author: katleman Date: 2012-05-17 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/5078a73b3448 Added tag jdk7u6-b10 for changeset f4e80156296e ! .hgtags From lana.steuck at oracle.com Fri May 18 15:34:54 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 May 2012 22:34:54 +0000 Subject: hg: jdk7u/jdk7u-dev/jaxws: 4 new changesets Message-ID: <20120518223456.E8241473F7@hg.openjdk.java.net> Changeset: 03a772c8b8fb Author: katleman Date: 2012-05-02 14:14 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxws/rev/03a772c8b8fb Added tag jdk7u6-b08 for changeset 3915e1a50ea9 ! .hgtags Changeset: c08f88f5ae98 Author: katleman Date: 2012-05-10 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxws/rev/c08f88f5ae98 Added tag jdk7u6-b09 for changeset 03a772c8b8fb ! .hgtags Changeset: a37ad8f90c7b Author: katleman Date: 2012-05-17 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxws/rev/a37ad8f90c7b Added tag jdk7u6-b10 for changeset c08f88f5ae98 ! .hgtags Changeset: 1f5bc20ebc90 Author: lana Date: 2012-05-18 15:09 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxws/rev/1f5bc20ebc90 Merge From lana.steuck at oracle.com Fri May 18 15:34:49 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 May 2012 22:34:49 +0000 Subject: hg: jdk7u/jdk7u-dev/langtools: 4 new changesets Message-ID: <20120518223459.99D66473F8@hg.openjdk.java.net> Changeset: 3e268ea565ef Author: katleman Date: 2012-05-02 14:14 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/3e268ea565ef Added tag jdk7u6-b08 for changeset ed00f61a5de8 ! .hgtags Changeset: 21d2313dfeac Author: katleman Date: 2012-05-10 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/21d2313dfeac Added tag jdk7u6-b09 for changeset 3e268ea565ef ! .hgtags Changeset: 13d3c6242916 Author: katleman Date: 2012-05-17 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/13d3c6242916 Added tag jdk7u6-b10 for changeset 21d2313dfeac ! .hgtags Changeset: 6ff4a476201e Author: lana Date: 2012-05-18 15:16 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/6ff4a476201e Merge From lana.steuck at oracle.com Fri May 18 15:37:24 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 May 2012 22:37:24 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 22 new changesets Message-ID: <20120518224111.0AF88473F9@hg.openjdk.java.net> Changeset: 0cd518f8fea7 Author: katleman Date: 2012-05-02 14:14 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/0cd518f8fea7 Added tag jdk7u6-b08 for changeset a5949f7b8693 ! .hgtags Changeset: 44d1f9532dab Author: cgruszka Date: 2012-01-20 06:50 -0500 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/44d1f9532dab Merge Changeset: 87345cee010c Author: cgruszka Date: 2012-01-23 14:47 -0500 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/87345cee010c Merge Changeset: 793db974858e Author: cgruszka Date: 2012-01-27 15:15 -0500 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/793db974858e Merge Changeset: ff57973632ad Author: cgruszka Date: 2012-02-03 10:33 -0500 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/ff57973632ad Merge - test/java/io/File/BlockIsDirectory.java Changeset: 71ff554d45cd Author: cgruszka Date: 2012-02-10 04:07 -0500 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/71ff554d45cd Merge - src/solaris/bin/java_md.c Changeset: f11e2cb94154 Author: cgruszka Date: 2012-02-28 13:33 -0500 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/f11e2cb94154 Merge - src/macosx/bin/universal/jvm.cfg - src/share/classes/com/sun/management/DiagnosticCommandArgumentInfo.java - src/share/classes/com/sun/management/DiagnosticCommandInfo.java - test/com/sun/management/HotSpotDiagnosticMXBean/ExecuteDiagnosticCommand.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommandInfo.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommands.java Changeset: f9d88851f1fc Author: cgruszka Date: 2012-03-14 17:16 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/f9d88851f1fc Merge Changeset: 712ddd5cd31c Author: cgruszka Date: 2012-03-20 11:00 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/712ddd5cd31c Merge Changeset: c3a8fa474dab Author: cgruszka Date: 2012-03-28 10:24 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/c3a8fa474dab Merge - test/java/io/FileDescriptor/FileChannelFDTest.java Changeset: 42b162b2d764 Author: cgruszka Date: 2012-04-03 12:07 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/42b162b2d764 Merge Changeset: d1b9d039fb26 Author: cgruszka Date: 2012-04-06 10:54 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/d1b9d039fb26 Merge Changeset: a2f0e47299a7 Author: cgruszka Date: 2012-04-17 21:26 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/a2f0e47299a7 Merge Changeset: 791ad9acadef Author: cgruszka Date: 2012-04-18 23:54 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/791ad9acadef Merge Changeset: 3bf9fb6f6aba Author: skovatch Date: 2012-04-25 13:40 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/3bf9fb6f6aba 7128699: Change the bundle name so it won't be overwritten when installing a new version Reviewed-by: robilad ! make/common/Release-macosx.gmk Changeset: 224011dbdf1f Author: cgruszka Date: 2012-04-30 23:22 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/224011dbdf1f Merge ! make/common/Release-macosx.gmk Changeset: 9e4fcaae8175 Author: cgruszka Date: 2012-05-03 00:10 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/9e4fcaae8175 Merge Changeset: fb31ae59ff22 Author: katleman Date: 2012-05-10 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/fb31ae59ff22 Added tag jdk7u6-b09 for changeset 9e4fcaae8175 ! .hgtags Changeset: 42162f9c522b Author: lana Date: 2012-05-09 17:52 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/42162f9c522b Merge - test/java/io/File/isDirectory/Applet.java Changeset: a2bd61800667 Author: lana Date: 2012-05-14 16:44 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/a2bd61800667 Merge Changeset: 18a1b4f0681a Author: katleman Date: 2012-05-17 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/18a1b4f0681a Added tag jdk7u6-b10 for changeset a2bd61800667 ! .hgtags Changeset: e3478500d252 Author: lana Date: 2012-05-18 15:15 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/e3478500d252 Merge From edvard.wendelin at oracle.com Fri May 18 23:38:38 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Sat, 19 May 2012 08:38:38 +0200 Subject: [7u6] Request for approval for bulk integration of hs23.2-b02 In-Reply-To: <4FB6CE10.1010405@oracle.com> References: <4FB6CE10.1010405@oracle.com> Message-ID: <9E2F35EF-F79A-4310-9227-2E713AD09197@oracle.com> Looks good. Approved. On May 19, 2012, at 12:32 AM, Alejandro E Murillo wrote: > Requesting approval to integrate hs23.2-b02 into jdk7u6-b11. > > A webrev is available at: > > http://cr.openjdk.java.net/~amurillo/7u6/hs23.2-b02-jdk7u6-b11.webrev/ > > Pre-integration testing is in progress; the integration will proceed > only after SQE has analyzed the results and approved. > > The fixes in the proposed integration are below. All have undergone > nightly testing and are already in a jdk8 repository. > > 7167625: Adjustments for SE-Embedded build process > 7168249: new hotspot build - hs23.2-b02 > > -- > Alejandro E Murillo, Java Performance > Phone: (303) 955-2584. > Timezone: US/Mountain (UTC-0700) > From anthony.petrov at oracle.com Mon May 21 07:30:51 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Mon, 21 May 2012 18:30:51 +0400 Subject: [7u6] Request for approval for CR 7144542: [macosx] Crash in liblwawt.dylib setBusy() when exiting an FX app run with j2d pipeline In-Reply-To: <66C9F9B6-0E46-4F11-8D8C-C8AF026D8085@oracle.com> References: <4FB659DA.20008@oracle.com> <66C9F9B6-0E46-4F11-8D8C-C8AF026D8085@oracle.com> Message-ID: <4FBA519B.40609@oracle.com> Thanks for the approval. There's no a fix for JDK 8 (the SubCR is closed as Not an Issue). -- best regards, Anthony On 05/18/12 21:01, Edvard Wendelin wrote: > Approved. Please push to JDK 8 first, if you haven't done so already. > > /Edvard > > On May 18, 2012, at 4:16 PM, Anthony Petrov wrote: > >> Bug: http://bugs.sun.com/view_bug.do?bug_id=7144542 >> Webrev: http://cr.openjdk.java.net/~anthony/7u6-6-crashInSetBusy-7144542.1/ >> Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004192.html >> Reviewers: Artem Ananiev >> >> -- >> best regards, >> Anthony >> >> >> >> > From anthony.petrov at oracle.com Mon May 21 07:35:57 2012 From: anthony.petrov at oracle.com (anthony.petrov at oracle.com) Date: Mon, 21 May 2012 14:35:57 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7144542: [macosx] Crash in liblwawt.dylib setBusy() when exiting an FX app Message-ID: <20120521143613.CB0134743E@hg.openjdk.java.net> Changeset: d75496a7c71b Author: anthony Date: 2012-05-21 18:35 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/d75496a7c71b 7144542: [macosx] Crash in liblwawt.dylib setBusy() when exiting an FX app Summary: Use XToolkit instead of CToolkit in headless mode Reviewed-by: art ! src/solaris/native/sun/awt/awt_LoadLibrary.c From Dmitry.Degrave at oracle.com Mon May 21 09:28:58 2012 From: Dmitry.Degrave at oracle.com (Dmeetry Degrave) Date: Mon, 21 May 2012 20:28:58 +0400 Subject: [7u6] Request for approval: 7148556: Implementing a generic interface causes a public clone() to become inaccessible Message-ID: <4FBA6D4A.50707@oracle.com> Hi, Requesting approval to commit fix for 7148556 into 7u6. The fix has already been pushed to jdk8, the code changes for 7u6 are identical. 7148556 "Implementing a generic interface causes a public clone() to become inaccessible" bug:http://bugs.sun.com/view_bug.do?bug_id=7148556 fix: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/eaae5cf911be Reviewed by Maurizio Cimadamore. thanks, dmeetry From dalibor.topic at oracle.com Mon May 21 10:58:03 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Mon, 21 May 2012 19:58:03 +0200 Subject: [7u6] Request for approval: 7148556: Implementing a generic interface causes a public clone() to become inaccessible In-Reply-To: <4FBA6D4A.50707@oracle.com> References: <4FBA6D4A.50707@oracle.com> Message-ID: <4FBA822B.8080100@oracle.com> On 5/21/12 6:28 PM, Dmeetry Degrave wrote: > Hi, > > Requesting approval to commit fix for 7148556 into 7u6. > > The fix has already been pushed to jdk8, the code changes for 7u6 are identical. > > 7148556 "Implementing a generic interface causes a public clone() to become inaccessible" > bug:http://bugs.sun.com/view_bug.do?bug_id=7148556 > fix: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/eaae5cf911be > > Reviewed by Maurizio Cimadamore. Looks good, approved. cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From dalibor.topic at oracle.com Mon May 21 14:05:31 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Mon, 21 May 2012 23:05:31 +0200 Subject: [7u4] Request for approval for 7117167: Misc warnings in java.lang.invoke and sun.invoke.* In-Reply-To: <4F5A307F.70603@oracle.com> References: <175E3DEB-CEF5-4A88-9BD9-D52BDB27DA04@oracle.com> <4F1EA629.7050304@oracle.com> <4F5A307F.70603@oracle.com> Message-ID: <4FBAAE1B.8000904@oracle.com> On 3/9/12 5:31 PM, Dalibor Topic wrote: > This changeset doesn't seem to have made it into the 7u forests yet. Still not there, afaict. John, do you intend to push this into 7u6? cheers, dalibor topic > > On 1/24/12 1:38 PM, Edvard Wendelin wrote: >> Approved. >> >> On 01/24/2012 04:21 AM, John Rose wrote: >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7117167 >>> >>> The change will be in JDK 8 with the next integration from HSX, where it presently resides: >>> >>> http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/db189e2f3cdb >>> >>> This is a low-priority bug. It was part of the 12/2011 warnings cleanup push. I'm requesting approval to simplify batch integration of JSR 292 related changes from Hotspot Express. (This is the only remaining JSR 292 bug unapproved for 7u4.) >>> >>> Technical discussion is on jdk8-dev, for example: >>> http://mail.openjdk.java.net/pipermail/jdk8-dev/2011-December/000405.html >>> http://mail.openjdk.java.net/pipermail/jdk8-dev/2011-December/000408.html >>> >>> Thanks, >>> >>> -- John > > -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From dalibor.topic at oracle.com Mon May 21 14:19:56 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Mon, 21 May 2012 23:19:56 +0200 Subject: Approval request for CR 7147456 In-Reply-To: <4F5A2030.7060808@oracle.com> References: <0D5D0D12-CBFD-4448-B153-206FAFB2D30A@oracle.com> <4F46C2C8.70706@oracle.com> <4F5A2030.7060808@oracle.com> Message-ID: <4FBAB17C.4080407@oracle.com> Greg, do you intend to push this one into 7u6? cheers, dalibor topic On 3/9/12 4:22 PM, Dalibor Topic wrote: > This one doesn't seem to have been pushed yet into any 7u forest. > > cheers, > dalibor topic > > On 2/23/12 11:50 PM, Paul Hohensee wrote: >> Approved. >> >> Paul >> >> On 2/23/12 2:39 PM, Greg Brown wrote: >>> Requesting approval to commit fix for CR 7147456. Reviewed by Mike Swingler and Scott Kovatch: >>> >>> http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-February/001987.html >>> http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-February/002007.html >>> >>> On Feb 21, 2012, at 11:57 AM, Greg Brown wrote: >>> >>>> Based on feedback on macosx-port-dev, this change flattens the key structure used in the plist for JavaAppLauncher. It also renames the generated "JavaVM" to "Java" to clarify the folder's intent (the folder does not contain a Java VM but rather resources related to execution of the Java part of the launcher app): >>>> >>>> http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-February/003239.html >>>> >>>> Webrev: >>>> http://cr.openjdk.java.net/~gkbrown/7147456/webrev.00/ >>>> > > -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From kelly.ohair at oracle.com Mon May 21 14:32:59 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 21 May 2012 14:32:59 -0700 Subject: Missing code review email on 7166956: Integrate the Java Access Bridge with Java Runtime Message-ID: <894D6354-5F2A-4766-B2E7-B6B94B08D92F@oracle.com> We missed doing an open review of these makefiles for the Java Access Bridge addition. 7166956: Integrate the Java Access Bridge with Java Runtime http://cr.openjdk.java.net/~ohair/openjdk7u/accessbridge1/ The change has already been pushed in: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/e15839c985d1 My apologies for not doing this as an open review. Since the change does not impact OpenJDK at all I made the mistake of not even communicating the change. Sorry about this. For the time being, this is not OpenJDK functionality, and you could ask when it might be open, but I cannot answer that question. I wish I could, sorry for that too. :^( -kto From ragini.prasad at oracle.com Mon May 21 14:43:12 2012 From: ragini.prasad at oracle.com (Ragini Prasad) Date: Mon, 21 May 2012 14:43:12 -0700 Subject: [7u6] Request for approval for CR 7166956: Integrate the Java Access Bridge with Java Runtime Message-ID: <4FBAB6F0.9050809@oracle.com> Requesting for approval for changes to Makefiles for Integrating Java Access Bridge. Please note it is setup to build for Closed repo only. 7166956: Integrate the Java Access Bridge with Java Runtime Webrev: http://cr.openjdk.java.net/~ohair/openjdk7u/accessbridge1/ Reviewed by: Kelly OHair Peter Brunet Thanks, Ragini. From staffan.larsen at oracle.com Tue May 22 01:36:44 2012 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 22 May 2012 08:36:44 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7154809: JDI: update JDI/JDB debugee commandline option parsing Message-ID: <20120522083704.EB4214745E@hg.openjdk.java.net> Changeset: 7498514309e3 Author: mgronlun Date: 2012-04-10 10:32 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/7498514309e3 7154809: JDI: update JDI/JDB debugee commandline option parsing Summary: update debugee commandline parsing Reviewed-by: dcubed, dsamersoff, sla ! src/share/classes/com/sun/tools/example/debug/tty/VMConnection.java From staffan.larsen at oracle.com Tue May 22 01:57:04 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 22 May 2012 10:57:04 +0200 Subject: [7u6] Request for approval for CR 7167157: jcmd command file parsing does not respect the "stop" command Message-ID: <2E558A4E-0C46-46BA-A57E-909E04425444@oracle.com> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7167157 Review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-May/006024.html JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a1ef7e07e01 Thanks, /Staffan From edvard.wendelin at oracle.com Tue May 22 02:18:33 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Tue, 22 May 2012 11:18:33 +0200 Subject: [7u6] Request for approval for CR 7167157: jcmd command file parsing does not respect the "stop" command In-Reply-To: <2E558A4E-0C46-46BA-A57E-909E04425444@oracle.com> References: <2E558A4E-0C46-46BA-A57E-909E04425444@oracle.com> Message-ID: <4FBB59E9.4090809@oracle.com> Approved. On 05/22/2012 10:57 AM, Staffan Larsen wrote: > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7167157 > Review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-May/006024.html > JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a1ef7e07e01 > > Thanks, > /Staffan From edvard.wendelin at oracle.com Tue May 22 02:22:14 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Tue, 22 May 2012 11:22:14 +0200 Subject: [7u6] Request for approval for CR 7166956: Integrate the Java Access Bridge with Java Runtime In-Reply-To: <4FBAB6F0.9050809@oracle.com> References: <4FBAB6F0.9050809@oracle.com> Message-ID: <4FBB5AC6.8050106@oracle.com> Approved. On 05/21/2012 11:43 PM, Ragini Prasad wrote: > Requesting for approval for changes to Makefiles for Integrating Java > Access Bridge. > Please note it is setup to build for Closed repo only. > > 7166956: Integrate the Java Access Bridge with Java Runtime > > Webrev: > http://cr.openjdk.java.net/~ohair/openjdk7u/accessbridge1/ > > Reviewed by: > Kelly OHair > Peter Brunet > > Thanks, > Ragini. From staffan.larsen at oracle.com Tue May 22 04:02:53 2012 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 22 May 2012 11:02:53 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7167157: jcmd command file parsing does not respect the "stop" command Message-ID: <20120522110330.F131F47465@hg.openjdk.java.net> Changeset: 05c4a1c2ce25 Author: sla Date: 2012-05-21 19:28 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/05c4a1c2ce25 7167157: jcmd command file parsing does not respect the "stop" command Reviewed-by: alanb, dsamersoff, nloodin ! src/share/classes/sun/tools/jcmd/JCmd.java From dalibor.topic at oracle.com Tue May 22 07:44:57 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Tue, 22 May 2012 16:44:57 +0200 Subject: Missing code review email on 7166956: Integrate the Java Access Bridge with Java Runtime In-Reply-To: <894D6354-5F2A-4766-B2E7-B6B94B08D92F@oracle.com> References: <894D6354-5F2A-4766-B2E7-B6B94B08D92F@oracle.com> Message-ID: <4FBBA669.20901@oracle.com> On 5/21/12 11:32 PM, Kelly O'Hair wrote: > > We missed doing an open review of these makefiles for the Java Access Bridge addition. > > 7166956: Integrate the Java Access Bridge with Java Runtime > http://cr.openjdk.java.net/~ohair/openjdk7u/accessbridge1/ thanks, Kelly - the changes look OK. I ran a test build to check if anything breaks in OpenJDK anyway, and it all looks fine. cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From dmitry.degrave at oracle.com Tue May 22 09:19:50 2012 From: dmitry.degrave at oracle.com (dmitry.degrave at oracle.com) Date: Tue, 22 May 2012 16:19:50 +0000 Subject: hg: jdk7u/jdk7u-dev/langtools: 7148556: Implementing a generic interface causes a public clone() to become inaccessible Message-ID: <20120522161955.514694746B@hg.openjdk.java.net> Changeset: 63327fd6e6d3 Author: dmeetry Date: 2012-05-22 20:19 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/63327fd6e6d3 7148556: Implementing a generic interface causes a public clone() to become inaccessible Summary: Implementation of Resolve.isOverriddenIn() should distinguish between classes/interfaces Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symbol.java + test/tools/javac/generics/rawOverride/T7148556.java From sean.coffey at oracle.com Tue May 22 09:36:13 2012 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Tue, 22 May 2012 17:36:13 +0100 Subject: [7u6] Request for approval for CR 6346658: (se) Selector briefly spins when asynchronously closing a registered channel [win] Message-ID: <4FBBC07D.6040706@oracle.com> I'd like to backport this from JDK 8 to 7u6. Identical changes compared to those of JDK 8. JDK 8 changeset : http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7326971f09af Bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6346658 7u6 webrev : http://cr.openjdk.java.net/~coffeys/webrev.6346658.7u6/ regards, Sean. From dalibor.topic at oracle.com Tue May 22 09:44:14 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Tue, 22 May 2012 18:44:14 +0200 Subject: [7u6] Request for approval for CR 6346658: (se) Selector briefly spins when asynchronously closing a registered channel [win] In-Reply-To: <4FBBC07D.6040706@oracle.com> References: <4FBBC07D.6040706@oracle.com> Message-ID: <4FBBC25E.8010004@oracle.com> Looks fine. Approved. On 5/22/12 6:36 PM, Se?n Coffey wrote: > I'd like to backport this from JDK 8 to 7u6. > > Identical changes compared to those of JDK 8. > > JDK 8 changeset : http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7326971f09af > Bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6346658 > 7u6 webrev : http://cr.openjdk.java.net/~coffeys/webrev.6346658.7u6/ > > regards, > Sean. -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From sean.coffey at oracle.com Tue May 22 09:52:59 2012 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Tue, 22 May 2012 16:52:59 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 6346658: (se) Selector briefly spins when asynchronously closing a registered channel [win] Message-ID: <20120522165317.B54B24746E@hg.openjdk.java.net> Changeset: f35dfb4114e7 Author: alanb Date: 2012-05-22 17:54 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/f35dfb4114e7 6346658: (se) Selector briefly spins when asynchronously closing a registered channel [win] Reviewed-by: chegar, coffeys ! src/share/classes/sun/nio/ch/NativeThreadSet.java ! src/windows/classes/sun/nio/ch/NativeThread.java ! src/windows/classes/sun/nio/ch/SocketDispatcher.java ! src/windows/native/sun/nio/ch/SocketDispatcher.c From cdennis at terracottatech.com Tue May 22 14:28:58 2012 From: cdennis at terracottatech.com (Chris Dennis) Date: Tue, 22 May 2012 17:28:58 -0400 Subject: 32/64 bit type issues on Windows Message-ID: Hi All, I believe that when the Mac OS X support was merged in to the jdk7u-dev forest that a mistake was made regarding Visual Studio's lack of inttypes.h. The symptom of this bug can be seen in the following output: $ java -showversion -d64 -XX:MaxDirectMemorySize=4g OffHeapAllocationTest java version "1.7.0_04" Java(TM) SE Runtime Environment (build 1.7.0_04-b20) Java HotSpot(TM) 64-Bit Server VM (build 23.0-b21, mixed mode) Command Line: [-XX:MaxDirectMemorySize=4g] sun.misc.VM.maxDirectMemory() = 0 java.nio.Bits.maxMemory = 0 Experimenting with different MaxDirectMemorySize values clearly shows this to be a 32-bit wrap-around issue. When Mac OS X support was merged in, the INTX_FORMAT which is used to write the MaxDirectMemorySize global in to the system properties was modified to use PRIdPTR from inttypes.h. As Visual Studio lacks inttypes.h, definitions for this (and the other associated format specifiers) were added to globalDefinitions_visCPP.hpp. However the definitions added are only correct for a 32-bit system. I believe the following changeset corrects that error (no Windows access prevents me from verifying this fix however). If you need me to file a formal bug report for this then let me know. Regards, Chris Dennis ================================================================================ diff -r bca9e76ea254 src/share/vm/utilities/globalDefinitions_visCPP.hpp --- a/src/share/vm/utilities/globalDefinitions_visCPP.hpp Tue Mar 20 10:17:41 2012 -0700 +++ b/src/share/vm/utilities/globalDefinitions_visCPP.hpp Tue May 22 17:24:57 2012 -0400 @@ -220,9 +220,15 @@ #define PRIu64 "I64u" #define PRIx64 "I64x" +#ifdef _LP64 +#define PRIdPTR "I64d" +#define PRIuPTR "I64u" +#define PRIxPTR "I64x" +#else #define PRIdPTR "d" #define PRIuPTR "u" #define PRIxPTR "x" +#endif #define offset_of(klass,field) offsetof(klass,field) From john.coomes at oracle.com Tue May 22 14:30:31 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Tue, 22 May 2012 21:30:31 +0000 Subject: hg: jdk7u/jdk7u-dev/hotspot: 4 new changesets Message-ID: <20120522213042.BF02847477@hg.openjdk.java.net> Changeset: e0b69099f2cf Author: amurillo Date: 2012-05-11 11:53 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/e0b69099f2cf 7168249: new hotspot build - hs23.2-b02 Reviewed-by: jcoomes ! make/hotspot_version Changeset: b7ae1ee1d2e4 Author: collins Date: 2012-05-11 11:30 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/b7ae1ee1d2e4 7167625: Adjustments for SE-Embedded build process Summary: Simple change to the SE-Embedded build rules that should not affect any other OpenJDK users. Reviewed-by: kvn, dholmes ! make/linux/makefiles/vm.make ! src/share/vm/runtime/arguments.cpp Changeset: 7eeb0ec83cd7 Author: amurillo Date: 2012-05-18 11:17 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/7eeb0ec83cd7 Added tag hs23.2-b02 for changeset b7ae1ee1d2e4 ! .hgtags Changeset: 5921bdc6ce5c Author: amurillo Date: 2012-05-18 11:35 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/5921bdc6ce5c Merge ! .hgtags ! make/hotspot_version From john.coomes at oracle.com Tue May 22 14:34:40 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Tue, 22 May 2012 21:34:40 +0000 Subject: hg: jdk7u/jdk7u/hotspot: 4 new changesets Message-ID: <20120522213450.CDA8147479@hg.openjdk.java.net> Changeset: e0b69099f2cf Author: amurillo Date: 2012-05-11 11:53 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/e0b69099f2cf 7168249: new hotspot build - hs23.2-b02 Reviewed-by: jcoomes ! make/hotspot_version Changeset: b7ae1ee1d2e4 Author: collins Date: 2012-05-11 11:30 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/b7ae1ee1d2e4 7167625: Adjustments for SE-Embedded build process Summary: Simple change to the SE-Embedded build rules that should not affect any other OpenJDK users. Reviewed-by: kvn, dholmes ! make/linux/makefiles/vm.make ! src/share/vm/runtime/arguments.cpp Changeset: 7eeb0ec83cd7 Author: amurillo Date: 2012-05-18 11:17 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/7eeb0ec83cd7 Added tag hs23.2-b02 for changeset b7ae1ee1d2e4 ! .hgtags Changeset: 5921bdc6ce5c Author: amurillo Date: 2012-05-18 11:35 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/5921bdc6ce5c Merge ! .hgtags ! make/hotspot_version From alejandro.murillo at oracle.com Tue May 22 14:51:24 2012 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Tue, 22 May 2012 15:51:24 -0600 Subject: jdk7u6-b11: HotSpot Message-ID: <4FBC0A5C.6000402@oracle.com> hs23.2-b02 has been integrated into jdk7u6-b11. http://hg.openjdk.java.net/jdk7u/jdk7u/rev/cd64596c2dd7 http://hg.openjdk.java.net/jdk7u/jdk7u/corba/rev/a2089d3bf5a0 http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/5921bdc6ce5c http://hg.openjdk.java.net/jdk7u/jdk7u/jaxp/rev/5078a73b3448 http://hg.openjdk.java.net/jdk7u/jdk7u/jaxws/rev/a37ad8f90c7b http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/18a1b4f0681a http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/13d3c6242916 Component : VM Status : 0 major failures, 0 minor failures Date : 05/22/2012 at 10:04 Tested By : VM SQE& leonid.mesnik at oracle.com Cost(total man-days): 1 Workspace : 2012-05-18-182005.amurillo.hs23-2-b02-snapshot Bundles : 2012-05-18-182005.amurillo.hs23-2-b02-snapshot Platforms : Others Tests :/net/sqenfs-1.sfbay/export1/comp/vm/testbase/ Browsers : NA Patches : NA Logs :http://vmsqe-app.ru.oracle.com/surl/J6 Number of Tests Executed : 0 product tests, 0 unit tests, 0 tck tests Bug verification status: ====================================== Tested, Pass: Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: Setup is not available: Build change only: 7167625: Adjustments for SE-Embedded build process 7168249: new hotspot build - hs23.2-b02 New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: Number of PIT requested: 1 Integration target J2SE build number: 7u6-b11 Issues and Notes: This is a PIT for HS23.2 b02 for JDK 7u6 b11. Failure analysis is not complete. There are no showstoppers. ------------------------------- From VM SQE& leonid.mesnik at oracle.com -- Alejandro E Murillo, Java Performance Phone: (303) 955-2584. Timezone: US/Mountain (UTC-0700) From mike.duigou at oracle.com Tue May 22 22:16:18 2012 From: mike.duigou at oracle.com (Mike Duigou) Date: Tue, 22 May 2012 22:16:18 -0700 Subject: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps Message-ID: <7AF40196-1CEA-4BFC-82C7-8AF9C4535D03@oracle.com> Dear OpenJDK CoreLibs community, A significant enhancement to the Java SE hashing-based Map implementations in planned for inclusion in Java SE 7u6. All of the hashing based Map implementations: HashMap, Hashtable, LinkedHashMap, WeakHashMap and ConcurrentHashMap will now use an enhanced hashing algorithm for string keys when the capacity of the hash table has ever grown beyond 512 entries. The enhanced hashing implementation uses the murmur3 hashing algorithm[1] along with random hash seeds and index masks. These enhancements mitigate cases where colliding String hash values could result in a performance bottleneck. In order to provide the greatest opportunity for developers to test compatibility with their applications this change will be incorporated into JDK7u6 build 12 and JDK8 build 39. Both builds are planned for release next week. ***For 7u6 build 12 only, the alternative hashing will be unconditionally enabled (always on).*** The threshold default will be reset to the intended release default (512) for 7u6 build 13. The quick promotion of this change into builds with limited opportunity for public review and the special behaviour for build 12 is intended to make it easier for developers to test their application compatibility. Feedback on the approach, implementation, compatibility and performance is eagerly sought and encouraged both before *and after* this change is incorporated into the OpenJDK repositories. A new system property, jdk.map.althashing.threshold, allows adjustment of the threshold for enabling the enhanced hashing algorithm. If changed from the default value of 512, the enhanced hashing will be invoked any time after map capacity exceeds the value of jdk.map.althashing.threshold. To completely disable the enhanced hashing (not recommended), set jdk.map.althashing.threshold to -1 or a very large number such as 2^31 -1 (Integer.MAX_VALUE). The iteration order of keys, values and entries for hash-based maps where the new algorithm has been invoked will vary for each HashMap instance. While the Java SE Map documentation makes no promises that iteration order of items returned from Maps will be consistent, developers should check if their applications have incorrectly created a dependency on the iteration order of Map entries, keys or values. Webrevs for the Java 7u6 and 8 changes are available for download at [2] and [3] for your review. There are some important differences between the Java 7 and 8 implementations of this enhancement. Most specifically in the Java 8 implementation alternative string hashing is always enabled--no threshold is used for enablement and alternative hashing cannot be disabled. (The Java 8 implementation completely ignores the jdk.map.althashing.threshold system property). The Java 8 implementation is also subject to additional refinement as Java 8 develops. If you have any questions or concerns with this planned enhancement, please use the corelibs development mailing list, , or you may also respond privately to me if you prefer. Thanks, Mike [1] Murmur3 : https://code.google.com/p/smhasher/wiki/MurmurHash3 [2] althashing "7" webrev : http://cr.openjdk.java.net/~mduigou/althashing7/8/webrev/ [3] althashing "8" webrev : http://cr.openjdk.java.net/~mduigou/althashing8/8/webrev/ From ahughes at redhat.com Wed May 23 03:55:26 2012 From: ahughes at redhat.com (Andrew Hughes) Date: Wed, 23 May 2012 06:55:26 -0400 (EDT) Subject: [7u6] Request for approval for CR 7150392: Linux build breaks with GCC 4.7 due to unrecognized option In-Reply-To: Message-ID: This patch is needed so that OpenJDK7 builds on GCC 4.7 on GNU/Linux. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7150392 Changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/fb3a2cafc230 Ok for OpenJDK7u6? Thanks, -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From edvard.wendelin at oracle.com Wed May 23 04:10:03 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Wed, 23 May 2012 13:10:03 +0200 Subject: [7u6] Request for approval for CR 7150392: Linux build breaks with GCC 4.7 due to unrecognized option In-Reply-To: References: Message-ID: <4FBCC58B.50504@oracle.com> Looks good. Approved. On 05/23/2012 12:55 PM, Andrew Hughes wrote: > This patch is needed so that OpenJDK7 builds on GCC 4.7 on GNU/Linux. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7150392 > Changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/fb3a2cafc230 > > Ok for OpenJDK7u6? > > Thanks, From ahughes at redhat.com Wed May 23 05:38:14 2012 From: ahughes at redhat.com (ahughes at redhat.com) Date: Wed, 23 May 2012 12:38:14 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7150392: Linux build breaks with GCC 4.7 due to unrecognized option Message-ID: <20120523123834.E7BFD47495@hg.openjdk.java.net> Changeset: 5bf0eb7c560c Author: andrew Date: 2012-03-08 14:04 +0000 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/5bf0eb7c560c 7150392: Linux build breaks with GCC 4.7 due to unrecognized option Summary: Remove -mimpure-text option. Reviewed-by: ohair, dholmes, phh, andrew Contributed-by: Deepak Bhole ! make/common/shared/Compiler-gcc.gmk ! src/share/demo/jvmti/compiledMethodLoad/sample.makefile.txt ! src/share/demo/jvmti/gctest/sample.makefile.txt ! src/share/demo/jvmti/heapTracker/sample.makefile.txt ! src/share/demo/jvmti/heapViewer/sample.makefile.txt ! src/share/demo/jvmti/hprof/sample.makefile.txt ! src/share/demo/jvmti/index.html ! src/share/demo/jvmti/java_crw_demo/sample.makefile.txt ! src/share/demo/jvmti/minst/sample.makefile.txt ! src/share/demo/jvmti/mtrace/sample.makefile.txt ! src/share/demo/jvmti/versionCheck/sample.makefile.txt ! src/share/demo/jvmti/waiters/sample.makefile.txt From dl at cs.oswego.edu Wed May 23 17:09:47 2012 From: dl at cs.oswego.edu (Doug Lea) Date: Wed, 23 May 2012 20:09:47 -0400 Subject: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps In-Reply-To: <7AF40196-1CEA-4BFC-82C7-8AF9C4535D03@oracle.com> References: <7AF40196-1CEA-4BFC-82C7-8AF9C4535D03@oracle.com> Message-ID: <4FBD7C4B.9010805@cs.oswego.edu> Note that ConcurrentHashMap has been overhauled for JDK8. The preliminary version, partially waiting for stability on lambda-related stuff, has been out a while as jsr166e.ConcurrenthashMapV8 (see http://gee.cs.oswego.edu/dl/concurrency-interest/index.html) It is easy to add seeded murmur hash code to this, which I plan to do. One question: Given the JDK8 conventions in your mail, it seems that field hashMask can never be zero, so doesn't need to be checked, but is in your JDK8 diffs: int h = hashMask; if ((0 != h) && (k instanceof String)) { return ((String) k).hash32() ^ h; ... and further simplifying a bit from there. (Also "hashMask" seems like an odd name for this. "hashSeed"?) -Doug From mike.duigou at oracle.com Wed May 23 17:29:22 2012 From: mike.duigou at oracle.com (Mike Duigou) Date: Wed, 23 May 2012 17:29:22 -0700 Subject: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps In-Reply-To: <4FBD7C4B.9010805@cs.oswego.edu> References: <7AF40196-1CEA-4BFC-82C7-8AF9C4535D03@oracle.com> <4FBD7C4B.9010805@cs.oswego.edu> Message-ID: On May 23 2012, at 17:09 , Doug Lea wrote: > > Note that ConcurrentHashMap has been overhauled for JDK8. > The preliminary version, partially waiting for stability > on lambda-related stuff, has been out a while as > jsr166e.ConcurrenthashMapV8 (see > http://gee.cs.oswego.edu/dl/concurrency-interest/index.html) For the short term it will probably be a little annoying to keep this in sync between the workspaces. Sorry in advance. > It is easy to add seeded murmur hash code to this, > which I plan to do. One question: > > Given the JDK8 conventions in your mail, > it seems that field hashMask can never be zero, > so doesn't need to be checked, but is in your JDK8 diffs: > int h = hashMask; > if ((0 != h) && (k instanceof String)) { > return ((String) k).hash32() ^ h; > > ... and further simplifying a bit from there. After Remi's feedback I looked more closely and the h != 0 check isn't needed in the JDK 8 implementation. I had been trying to keep the JDK 7 and 8 differences to a minimum and missed this. I will have this fixed in the next webrev. > (Also "hashMask" seems like an odd name for this. "hashSeed"?) Thinking about it more I prefer hashSeed as well. I will make this change before the next webrev. Thanks Doug! Mike From edvard.wendelin at oracle.com Thu May 24 02:37:55 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Thu, 24 May 2012 11:37:55 +0200 Subject: 32/64 bit type issues on Windows In-Reply-To: References: Message-ID: <4FBE0173.3060106@oracle.com> Thanks for the report Chris! I'll file a bug so that we don't loose track of this. Cheers, Edvard On 05/22/2012 11:28 PM, Chris Dennis wrote: > Hi All, > > I believe that when the Mac OS X support was merged in to the jdk7u-dev forest that a mistake was made regarding Visual Studio's lack of inttypes.h. The symptom of this bug can be seen in the following output: > > $ java -showversion -d64 -XX:MaxDirectMemorySize=4g OffHeapAllocationTest > java version "1.7.0_04" > Java(TM) SE Runtime Environment (build 1.7.0_04-b20) > Java HotSpot(TM) 64-Bit Server VM (build 23.0-b21, mixed mode) > > Command Line: [-XX:MaxDirectMemorySize=4g] > sun.misc.VM.maxDirectMemory() = 0 > java.nio.Bits.maxMemory = 0 > > Experimenting with different MaxDirectMemorySize values clearly shows this to be a 32-bit wrap-around issue. When Mac OS X support was merged in, the INTX_FORMAT which is used to write the MaxDirectMemorySize global in to the system properties was modified to use PRIdPTR from inttypes.h. As Visual Studio lacks inttypes.h, definitions for this (and the other associated format specifiers) were added to globalDefinitions_visCPP.hpp. However the definitions added are only correct for a 32-bit system. I believe the following changeset corrects that error (no Windows access prevents me from verifying this fix however). > > If you need me to file a formal bug report for this then let me know. > > Regards, > > Chris Dennis > > ================================================================================ > diff -r bca9e76ea254 src/share/vm/utilities/globalDefinitions_visCPP.hpp > --- a/src/share/vm/utilities/globalDefinitions_visCPP.hpp Tue Mar 20 10:17:41 2012 -0700 > +++ b/src/share/vm/utilities/globalDefinitions_visCPP.hpp Tue May 22 17:24:57 2012 -0400 > @@ -220,9 +220,15 @@ > #define PRIu64 "I64u" > #define PRIx64 "I64x" > > +#ifdef _LP64 > +#define PRIdPTR "I64d" > +#define PRIuPTR "I64u" > +#define PRIxPTR "I64x" > +#else > #define PRIdPTR "d" > #define PRIuPTR "u" > #define PRIxPTR "x" > +#endif > > #define offset_of(klass,field) offsetof(klass,field) > > From dl at cs.oswego.edu Thu May 24 04:22:31 2012 From: dl at cs.oswego.edu (Doug Lea) Date: Thu, 24 May 2012 07:22:31 -0400 Subject: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps In-Reply-To: References: <7AF40196-1CEA-4BFC-82C7-8AF9C4535D03@oracle.com> <4FBD7C4B.9010805@cs.oswego.edu> Message-ID: <4FBE19F7.3040007@cs.oswego.edu> On 05/23/12 20:29, Mike Duigou wrote: >> Note that ConcurrentHashMap has been overhauled for JDK8. >> The preliminary version, partially waiting for stability >> on lambda-related stuff, has been out a while as >> jsr166e.ConcurrenthashMapV8 (see >> http://gee.cs.oswego.edu/dl/concurrency-interest/index.html) > > For the short term it will probably be a little annoying to keep this in sync between the workspaces. Sorry in advance. > We will soon have this issue across our own workspaces anyway (jdk7- vs jdk8- compilable) so it's not an added problem. To get better preliminary testing for CHM, sometime next week, I'll try adding jdk7-compilable version of alt-hash to our jsr166e.ConcurrenthashMapV8. This will sometimes be slower than jdk8 version because String.hash32 emulation cannot cache the result in the String object, but is probably still worthwhile for collecting some feedback -- we seem to have at least dozens of heavy users of CHMV8. -Doug From sergey.bylokhov at oracle.com Thu May 24 06:25:09 2012 From: sergey.bylokhov at oracle.com (sergey.bylokhov at oracle.com) Date: Thu, 24 May 2012 13:25:09 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7160623: [macosx] Editable TextArea/TextField are blocking GUI applications from exit Message-ID: <20120524132519.9B545474C2@hg.openjdk.java.net> Changeset: 7647f9201e31 Author: serb Date: 2012-05-24 17:17 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/7647f9201e31 7160623: [macosx] Editable TextArea/TextField are blocking GUI applications from exit Reviewed-by: anthony, kizune ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java From leonid.romanov at oracle.com Thu May 24 06:35:18 2012 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Thu, 24 May 2012 17:35:18 +0400 Subject: [7u6] Request for approval: 7124411: [macosx] There's no KEY_TYPED for VK_ESCAPE Message-ID: Hi, Requesting approval to push the fix for CR 712441. This fix has already been pushed to JDK 8. For 7u6 it has been reviewed by Anthony Petrov. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=712441 Webrev: http://cr.openjdk.java.net/~leonidr/7124411/webrev.00/ JDK 8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/49d2a5eb48b1 Thanks, Leonid. From edvard.wendelin at oracle.com Thu May 24 09:19:27 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Thu, 24 May 2012 18:19:27 +0200 Subject: [7u6] Request for approval: 7124411: [macosx] There's no KEY_TYPED for VK_ESCAPE In-Reply-To: References: Message-ID: Approved. On May 24, 2012, at 3:35 PM, Leonid Romanov wrote: > Hi, > Requesting approval to push the fix for CR 712441. This fix has already been pushed to JDK 8. For 7u6 it has been reviewed by Anthony Petrov. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=712441 > Webrev: http://cr.openjdk.java.net/~leonidr/7124411/webrev.00/ > JDK 8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/49d2a5eb48b1 > > Thanks, > Leonid. > From alexander.zuev at oracle.com Thu May 24 09:40:44 2012 From: alexander.zuev at oracle.com (Alexander Zuev) Date: Thu, 24 May 2012 20:40:44 +0400 Subject: [7u6] Request for approval for 7171163: [macosx] Shortcomings in the design of the secondary native event loop made JavaFX DnD deadlock Message-ID: <4FBE648C.9080102@oracle.com> Hello, requesting approval to push into the 7u6 workspace fix for 7171163: [macosx] Shortcomings in the design of the secondary native event loop made JavaFX DnD deadlock Fix were reviewed on macosx-port-dev public alias and were approved by Artem Ananiev The fix for jdk8 will be slightly different so i'm going to update it and it will be reviewed and pushed a bit later. Bug description can be found here: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171163 Technical review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004239.html Webrev can be found here: http://cr.openjdk.java.net/~kizune/7171163/webrev.03 From edvard.wendelin at oracle.com Thu May 24 10:29:59 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Thu, 24 May 2012 19:29:59 +0200 Subject: [7u6] Request for approval for 7171163: [macosx] Shortcomings in the design of the secondary native event loop made JavaFX DnD deadlock In-Reply-To: <4FBE648C.9080102@oracle.com> References: <4FBE648C.9080102@oracle.com> Message-ID: Looks good! Approved On May 24, 2012, at 6:40 PM, Alexander Zuev wrote: > Hello, > > requesting approval to push into the 7u6 workspace fix for > > 7171163: [macosx] Shortcomings in the design of the secondary native event loop made JavaFX DnD deadlock > > Fix were reviewed on macosx-port-dev public alias and were approved by Artem Ananiev > The fix for jdk8 will be slightly different so i'm going to update it and it will be reviewed and pushed a bit later. > > Bug description can be found here: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171163 > Technical review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004239.html > Webrev can be found here: http://cr.openjdk.java.net/~kizune/7171163/webrev.03 From mike.duigou at oracle.com Thu May 24 12:41:23 2012 From: mike.duigou at oracle.com (Mike Duigou) Date: Thu, 24 May 2012 12:41:23 -0700 Subject: [7u6] Request for Approval 7118743 : Alternative Hashing for String with Hash-based Maps Message-ID: <7EB5F6F2-E8C0-4FB5-807C-A0DCDA0CCEB1@oracle.com> Hi, This is a request to include an enhancement into JDK 7u6: 7118743: Alternative Hashing for String with Hash-based Maps The enhancement is currently under review on corelibs-dev (and was cross-posted here) : http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-May/010238.html The latest webrev is at: http://cr.openjdk.java.net/~mduigou/althashing7/9/webrev/ I hope to push in time for the b12 build to: ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk Note that a second commit will be pushed before b13 to change a critical configuration default. b12 is being intentionally built with the default set to a non-standard value for easier testing. Thanks! Mike From mike.duigou at oracle.com Thu May 24 13:45:09 2012 From: mike.duigou at oracle.com (Mike Duigou) Date: Thu, 24 May 2012 13:45:09 -0700 Subject: Request for Review : CR#6924259: Remove String.count/String.offset Message-ID: <1D5C5BC1-C6E8-4807-9D5B-2530CDEAD479@oracle.com> Hello all; For a long time preparations and planing have been underway to remove the offset and count fields from java.lang.String. These two fields enable multiple String instances to share the same backing character buffer. Shared character buffers were an important optimization for old benchmarks but with current real world code and benchmarks it's actually better to not share backing buffers. Shared char array backing buffers only "win" with very heavy use of String.substring. The negatively impacted situations can include parsers and compilers however current testing shows that overall this change is beneficial. The current plan is to commit this change to jdk8 before build 40 followed by jdk7u6. Removing offset/count is a complicated process because HotSpot has special case code for String that depends upon the two fields. Vladimir Kozlov has committed the required HotSpot changes already (http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/8f972594effc). A patch of the changes to java.lang.String for JDK 8 are at . The changes for JDK 7 have only superficial differences (line offsets in the patch). Comments are welcome. Mike From Alan.Bateman at oracle.com Thu May 24 13:48:36 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 24 May 2012 21:48:36 +0100 Subject: Result: New jdk7u Committer: Kurchi Subhra Hazra Message-ID: <4FBE9EA4.4050900@oracle.com> Voting for Kurchi Subhra Hazra [1] is now closed. Yes: 18 No: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. [1] http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-May/002929.html From edvard.wendelin at oracle.com Thu May 24 14:16:04 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Thu, 24 May 2012 23:16:04 +0200 Subject: [7u6] Request for Approval 7118743 : Alternative Hashing for String with Hash-based Maps In-Reply-To: <7EB5F6F2-E8C0-4FB5-807C-A0DCDA0CCEB1@oracle.com> References: <7EB5F6F2-E8C0-4FB5-807C-A0DCDA0CCEB1@oracle.com> Message-ID: Approved! Feel free to push once you feel you have the necessary reviews! :) Cheers, Edvard On May 24, 2012, at 9:41 PM, Mike Duigou wrote: > Hi, > > This is a request to include an enhancement into JDK 7u6: > 7118743: Alternative Hashing for String with Hash-based Maps > > The enhancement is currently under review on corelibs-dev (and was cross-posted here) : > http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-May/010238.html > > The latest webrev is at: > http://cr.openjdk.java.net/~mduigou/althashing7/9/webrev/ > > I hope to push in time for the b12 build to: > ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk > > Note that a second commit will be pushed before b13 to change a critical configuration default. b12 is being intentionally built with the default set to a non-standard value for easier testing. > > Thanks! > > Mike From david.katleman at oracle.com Thu May 24 15:30:57 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 24 May 2012 22:30:57 +0000 Subject: hg: jdk7u/jdk7u: Added tag jdk7u6-b11 for changeset cd64596c2dd7 Message-ID: <20120524223057.46E45474D3@hg.openjdk.java.net> Changeset: 61cfcee1d00c Author: katleman Date: 2012-05-24 15:27 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/rev/61cfcee1d00c Added tag jdk7u6-b11 for changeset cd64596c2dd7 ! .hgtags From david.katleman at oracle.com Thu May 24 15:31:03 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 24 May 2012 22:31:03 +0000 Subject: hg: jdk7u/jdk7u/corba: Added tag jdk7u6-b11 for changeset a2089d3bf5a0 Message-ID: <20120524223104.27616474D4@hg.openjdk.java.net> Changeset: 34354c623c45 Author: katleman Date: 2012-05-24 15:27 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/corba/rev/34354c623c45 Added tag jdk7u6-b11 for changeset a2089d3bf5a0 ! .hgtags From david.katleman at oracle.com Thu May 24 15:31:41 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 24 May 2012 22:31:41 +0000 Subject: hg: jdk7u/jdk7u/hotspot: Added tag jdk7u6-b11 for changeset 5921bdc6ce5c Message-ID: <20120524223143.DA0B1474D5@hg.openjdk.java.net> Changeset: 897d453d26ac Author: katleman Date: 2012-05-24 15:27 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/897d453d26ac Added tag jdk7u6-b11 for changeset 5921bdc6ce5c ! .hgtags From david.katleman at oracle.com Thu May 24 15:33:07 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 24 May 2012 22:33:07 +0000 Subject: hg: jdk7u/jdk7u/jaxp: Added tag jdk7u6-b11 for changeset 5078a73b3448 Message-ID: <20120524223308.C41FB474D6@hg.openjdk.java.net> Changeset: c378e596fb5b Author: katleman Date: 2012-05-24 15:27 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jaxp/rev/c378e596fb5b Added tag jdk7u6-b11 for changeset 5078a73b3448 ! .hgtags From david.katleman at oracle.com Thu May 24 15:33:15 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 24 May 2012 22:33:15 +0000 Subject: hg: jdk7u/jdk7u/jaxws: Added tag jdk7u6-b11 for changeset a37ad8f90c7b Message-ID: <20120524223315.8E031474D7@hg.openjdk.java.net> Changeset: 1915eabccdda Author: katleman Date: 2012-05-24 15:27 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jaxws/rev/1915eabccdda Added tag jdk7u6-b11 for changeset a37ad8f90c7b ! .hgtags From david.katleman at oracle.com Thu May 24 15:33:26 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 24 May 2012 22:33:26 +0000 Subject: hg: jdk7u/jdk7u/jdk: Added tag jdk7u6-b11 for changeset 18a1b4f0681a Message-ID: <20120524223336.DE363474D8@hg.openjdk.java.net> Changeset: 9c67d83bbec7 Author: katleman Date: 2012-05-24 15:27 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/9c67d83bbec7 Added tag jdk7u6-b11 for changeset 18a1b4f0681a ! .hgtags From david.katleman at oracle.com Thu May 24 15:34:52 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 24 May 2012 22:34:52 +0000 Subject: hg: jdk7u/jdk7u/langtools: Added tag jdk7u6-b11 for changeset 13d3c6242916 Message-ID: <20120524223454.1B190474D9@hg.openjdk.java.net> Changeset: 46354fe19bb6 Author: katleman Date: 2012-05-24 15:27 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/46354fe19bb6 Added tag jdk7u6-b11 for changeset 13d3c6242916 ! .hgtags From mike.duigou at oracle.com Thu May 24 16:11:40 2012 From: mike.duigou at oracle.com (Mike Duigou) Date: Thu, 24 May 2012 16:11:40 -0700 Subject: Request for Review : CR#6924259: Remove String.count/String.offset In-Reply-To: <4FBEBC85.4050104@gmx.de> References: <1D5C5BC1-C6E8-4807-9D5B-2530CDEAD479@oracle.com> <4FBEBC85.4050104@gmx.de> Message-ID: On May 24 2012, at 15:56 , Ulf Zibis wrote: > Am 24.05.2012 22:45, schrieb Mike Duigou: >> A patch of the changes to java.lang.String for JDK 8 are at. The changes for JDK 7 have only superficial differences (line offsets in the patch). > Correct Copyright date. > > 157 public String(String original) { > 158 this.value = (original.value.length> 0) > 159 ? original.value > 160 : EMPTY_STRING_VALUE; 145 > 161 } > > Does the last case ever occur?, if you have: It can occur in cases where original is - a deserialized string - a string from a class file constant pool - the string constant "" - (new StringBuilder()).toString() and other empty string generators. From Ulf.Zibis at gmx.de Thu May 24 15:56:05 2012 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Fri, 25 May 2012 00:56:05 +0200 Subject: Request for Review : CR#6924259: Remove String.count/String.offset In-Reply-To: <1D5C5BC1-C6E8-4807-9D5B-2530CDEAD479@oracle.com> References: <1D5C5BC1-C6E8-4807-9D5B-2530CDEAD479@oracle.com> Message-ID: <4FBEBC85.4050104@gmx.de> Am 24.05.2012 22:45, schrieb Mike Duigou: > A patch of the changes to java.lang.String for JDK 8 are at. The changes for JDK 7 have only superficial differences (line offsets in the patch). Correct Copyright date. 157 public String(String original) { 158 this.value = (original.value.length> 0) 159 ? original.value 160 : EMPTY_STRING_VALUE; 145 161 } Does the last case ever occur?, if you have: 143 public String() { 144 this.value = EMPTY_STRING_VALUE; 145 } -Ulf From Ulf.Zibis at gmx.de Fri May 25 02:57:07 2012 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Fri, 25 May 2012 11:57:07 +0200 Subject: Request for Review : CR#6924259: Remove String.count/String.offset In-Reply-To: References: <1D5C5BC1-C6E8-4807-9D5B-2530CDEAD479@oracle.com> <4FBEBC85.4050104@gmx.de> Message-ID: <4FBF5773.8030000@gmx.de> Am 25.05.2012 01:11, schrieb Mike Duigou: > On May 24 2012, at 15:56 , Ulf Zibis wrote: > >> Am 24.05.2012 22:45, schrieb Mike Duigou: >>> A patch of the changes to java.lang.String for JDK 8 are at. The changes for JDK 7 have only superficial differences (line offsets in the patch). >> Correct Copyright date. >> >> 157 public String(String original) { >> 158 this.value = (original.value.length> 0) >> 159 ? original.value >> 160 : EMPTY_STRING_VALUE; >> 161 } >> >> Does the last case ever occur?, if you have: > It can occur in cases where original is > - a deserialized string If not interned yes. But stop, see argumentation for StringBuilder below... > - a string from a class file constant pool I think, they become interned, so all should be identical. > - the string constant "" same > - (new StringBuilder()).toString() and other empty string generators. Hm, StringBuilder uses one of the constructors from String, so if we guarantee by all String constructors to refer to interned EMPTY_STRING_VALUE, then this should not occur -Ulf From nils.loodin at oracle.com Fri May 25 04:04:08 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Fri, 25 May 2012 13:04:08 +0200 Subject: [7u6] Request for approval for CR7143353: -Xrunhprof fails in Java 7 due to bad switch Message-ID: <524DC882-CECB-4DFD-B9FA-F7420ECB858D@oracle.com> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7143353 Review thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2012-May/003742.html JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ec5588c733d From edvard.wendelin at oracle.com Fri May 25 04:27:36 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Fri, 25 May 2012 13:27:36 +0200 Subject: [7u6] Request for approval for CR7143353: -Xrunhprof fails in Java 7 due to bad switch In-Reply-To: <524DC882-CECB-4DFD-B9FA-F7420ECB858D@oracle.com> References: <524DC882-CECB-4DFD-B9FA-F7420ECB858D@oracle.com> Message-ID: <4FBF6CA8.3080101@oracle.com> Approved. On 05/25/2012 01:04 PM, Nils Loodin wrote: > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7143353 > Review thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2012-May/003742.html > JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ec5588c733d From alexander.zuev at oracle.com Fri May 25 05:08:18 2012 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Fri, 25 May 2012 12:08:18 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7171163: [macosx] Shortcomings in the design of the secondary native event loop made JavaFX DnD deadlock Message-ID: <20120525120828.7B13D4750E@hg.openjdk.java.net> Changeset: 665d7e1e7252 Author: kizune Date: 2012-05-25 16:06 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/665d7e1e7252 7171163: [macosx] Shortcomings in the design of the secondary native event loop made JavaFX DnD deadlock Reviewed-by: art, anthony ! src/macosx/classes/sun/lwawt/macosx/CToolkitThreadBlockedHandler.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/LWCToolkit.m ! src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java From Dmitry.Degrave at oracle.com Fri May 25 05:08:27 2012 From: Dmitry.Degrave at oracle.com (Dmeetry Degrave) Date: Fri, 25 May 2012 16:08:27 +0400 Subject: [7u6] Request for approval: 7151070: NullPointerException in Resolve.isAccessible Message-ID: <4FBF763B.1010001@oracle.com> Hi, Requesting approval to commit fix for 7151070 into 7u6. The fix has already been pushed to jdk8, the code changes for 7u6 are identical. 7151070 "NullPointerException in Resolve.isAccessible" bug: http://bugs.sun.com/view_bug.do?bug_id=7151070 fix: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c2234816495f Reviewed by Maurizio Cimadamore. thanks, dmeetry From edvard.wendelin at oracle.com Fri May 25 05:42:38 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Fri, 25 May 2012 14:42:38 +0200 Subject: [7u6] Request for approval: 7151070: NullPointerException in Resolve.isAccessible In-Reply-To: <4FBF763B.1010001@oracle.com> References: <4FBF763B.1010001@oracle.com> Message-ID: <4FBF7E3E.5040402@oracle.com> Looks good! Approved On 05/25/2012 02:08 PM, Dmeetry Degrave wrote: > Hi, > > Requesting approval to commit fix for 7151070 into 7u6. > > The fix has already been pushed to jdk8, the code changes for 7u6 are > identical. > > 7151070 "NullPointerException in Resolve.isAccessible" > bug: http://bugs.sun.com/view_bug.do?bug_id=7151070 > fix: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c2234816495f > > Reviewed by Maurizio Cimadamore. > > thanks, > dmeetry From dmitry.degrave at oracle.com Fri May 25 05:48:28 2012 From: dmitry.degrave at oracle.com (dmitry.degrave at oracle.com) Date: Fri, 25 May 2012 12:48:28 +0000 Subject: hg: jdk7u/jdk7u-dev/langtools: 7151070: NullPointerException in Resolve.isAccessible Message-ID: <20120525124832.B61EB47512@hg.openjdk.java.net> Changeset: 1936504ce917 Author: dmeetry Date: 2012-05-25 16:47 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/1936504ce917 7151070: NullPointerException in Resolve.isAccessible Summary: Spurious accessibility check in TransTypes Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java + test/tools/javac/generics/7151070/T7151070.java + test/tools/javac/generics/7151070/T7151070.out From andrew.brygin at oracle.com Fri May 25 07:29:09 2012 From: andrew.brygin at oracle.com (Andrew Brygin) Date: Fri, 25 May 2012 18:29:09 +0400 Subject: [7u6] Request for approval: 7124400: [macosx] CGraphicsDevice.getConfigurations() returns reference to member (does not copy configs) Message-ID: <4FBF9735.8020102@oracle.com> Hello, Requesting approval to commit fix for 7124400 into 7u6. The fix has already been pushed to jdk8, the code changes for 7u6 are identical. Bug: http://bugs.sun.com/view_bug.do?bug_id=7124400 Jdk8 changeset: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7c4eed4b6c19 Webrev: http://cr.openjdk.java.net/~bae/7124400/7u6/webrev.00/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004260.html Reviewed by: Artem Ananiev, Anthony Petrov. Thanks, Andrew From andrew.brygin at oracle.com Fri May 25 07:32:07 2012 From: andrew.brygin at oracle.com (Andrew Brygin) Date: Fri, 25 May 2012 18:32:07 +0400 Subject: [7u6] Request for approval: 7154088: [macosx] Regression: Component.createImage do not inherits component attributes Message-ID: <4FBF97E7.80308@oracle.com> Hello, Requesting approval to commit fix for 7154088 into 7u6. The fix has already been pushed to jdk8, the code changes for 7u6 are identical. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154088 jdk8 changeset: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/416b3a498e71 Webrev: http://cr.openjdk.java.net/~bae/7154088/7u6/webrev.00/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004253.html Reviewed by: Anthony Petrov. Thanks, Andrew From nils.loodin at oracle.com Fri May 25 07:52:07 2012 From: nils.loodin at oracle.com (nils.loodin at oracle.com) Date: Fri, 25 May 2012 14:52:07 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 2 new changesets Message-ID: <20120525145238.C2A464751B@hg.openjdk.java.net> Changeset: 61517f1fe79e Author: nloodin Date: 2012-05-24 09:32 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/61517f1fe79e 7143353: -Xrunhprof fails in Java 7 due to bad switch Reviewed-by: jrose, sspitsyn ! src/share/demo/jvmti/java_crw_demo/java_crw_demo.c ! src/share/javavm/export/classfile_constants.h Changeset: 39db51e1aa62 Author: nloodin Date: 2012-05-25 06:01 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/39db51e1aa62 Merge From daniel.daugherty at oracle.com Fri May 25 10:53:40 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Fri, 25 May 2012 11:53:40 -0600 Subject: [7u6] Request for approval for CR 7170449 Management is completely broken at least on Solaris 11 X86 Message-ID: <4FBFC724.7030007@oracle.com> Greetings, This is a request to backport a JDK 8 fix into JDK 7u6: 7170449 2/2 Management is completely broken at least on Solaris 11 X86 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170449 The fix has recently been pushed to JDK 8, as: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82134992123c and will be included in the JDK8-B42 PIT snapshot. This fix has been reviewed on build-dev at openjdk.java.net: http://mail.openjdk.java.net/pipermail/build-dev/2012-May/006186.html and hotspot-runtime-dev at openjdk.java.net: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2012-May/003737.html and serviceability-dev at openjdk.java.net: http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-May/006146.html The three review threads are currently identical. The JDK7u6 and JDK8 jdk repo patch files are identical except for line numbers and context diff anchor text. Dan From alejandro.murillo at oracle.com Fri May 25 17:22:26 2012 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Fri, 25 May 2012 18:22:26 -0600 Subject: [7u6] Request for approval for bulk integration of hs23.2-b03 Message-ID: <4FC02242.7080003@oracle.com> Requesting approval to integrate hs23.2-b03 into jdk7u6-b12. A webrev is available at: http://cr.openjdk.java.net/~amurillo/7u6/hs23.2-b03-jdk7u6-b12.webrev/ Pre-integration testing is in progress; the integration will proceed only after SQE has analyzed the results and approved. The fixes in the proposed integration are below. All have undergone nightly testing and are already in a jdk8 repository. 6924259: Remove String.count/String.offset 7157141: crash in 64 bit with corrupted oops 7158457: division by zero in adaptiveweightedaverage 7160539: JDeveloper crashes on 64-bit Windows 7165755: OS Information much longer on linux than other platforms 7167254: Crash on OSX in Enumerator.nextElement() with compressed oops 7170009: new hotspot build - hs23.2-b03 7170197: Update JPRT default build targets to support embedded builds -- Alejandro E Murillo, Java Performance Phone: (303) 955-2584. Timezone: US/Mountain (UTC-0700) From edvard.wendelin at oracle.com Sat May 26 02:03:44 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Sat, 26 May 2012 11:03:44 +0200 Subject: [7u6] Request for approval: 7124400: [macosx] CGraphicsDevice.getConfigurations() returns reference to member (does not copy configs) In-Reply-To: <4FBF9735.8020102@oracle.com> References: <4FBF9735.8020102@oracle.com> Message-ID: <0625A35E-3302-4E0F-8FAE-E6A3E4DFC820@oracle.com> Approved. On May 25, 2012, at 4:29 PM, Andrew Brygin wrote: > Hello, > > Requesting approval to commit fix for 7124400 into 7u6. > > The fix has already been pushed to jdk8, the code changes for 7u6 are identical. > > Bug: http://bugs.sun.com/view_bug.do?bug_id=7124400 > Jdk8 changeset: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7c4eed4b6c19 > Webrev: http://cr.openjdk.java.net/~bae/7124400/7u6/webrev.00/ > Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004260.html > Reviewed by: Artem Ananiev, Anthony Petrov. > > Thanks, > Andrew From edvard.wendelin at oracle.com Sat May 26 02:03:51 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Sat, 26 May 2012 11:03:51 +0200 Subject: [7u6] Request for approval: 7154088: [macosx] Regression: Component.createImage do not inherits component attributes In-Reply-To: <4FBF97E7.80308@oracle.com> References: <4FBF97E7.80308@oracle.com> Message-ID: <2D285D16-0EF6-435C-8164-9243F6B3EDA2@oracle.com> Approved! On May 25, 2012, at 4:32 PM, Andrew Brygin wrote: > Hello, > > Requesting approval to commit fix for 7154088 into 7u6. > > The fix has already been pushed to jdk8, the code changes for 7u6 are identical. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154088 > jdk8 changeset: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/416b3a498e71 > Webrev: http://cr.openjdk.java.net/~bae/7154088/7u6/webrev.00/ > Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004253.html > Reviewed by: Anthony Petrov. > > Thanks, > Andrew From edvard.wendelin at oracle.com Sat May 26 02:04:18 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Sat, 26 May 2012 11:04:18 +0200 Subject: [7u6] Request for approval for CR 7170449 Management is completely broken at least on Solaris 11 X86 In-Reply-To: <4FBFC724.7030007@oracle.com> References: <4FBFC724.7030007@oracle.com> Message-ID: Looks good! Approved On May 25, 2012, at 7:53 PM, Daniel D. Daugherty wrote: > Greetings, > > This is a request to backport a JDK 8 fix into JDK 7u6: > > 7170449 2/2 Management is completely broken at least on Solaris 11 X86 > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170449 > > The fix has recently been pushed to JDK 8, as: > > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82134992123c > > and will be included in the JDK8-B42 PIT snapshot. > > This fix has been reviewed on build-dev at openjdk.java.net: > > http://mail.openjdk.java.net/pipermail/build-dev/2012-May/006186.html > > and hotspot-runtime-dev at openjdk.java.net: > > http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2012-May/003737.html > > and serviceability-dev at openjdk.java.net: > > http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-May/006146.html > > The three review threads are currently identical. > > The JDK7u6 and JDK8 jdk repo patch files are identical except > for line numbers and context diff anchor text. > > Dan From edvard.wendelin at oracle.com Sat May 26 02:04:32 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Sat, 26 May 2012 11:04:32 +0200 Subject: [7u6] Request for approval for bulk integration of hs23.2-b03 In-Reply-To: <4FC02242.7080003@oracle.com> References: <4FC02242.7080003@oracle.com> Message-ID: <76947373-190F-40D1-8CB0-2201EC5AED7D@oracle.com> Pre-approved pending PIT results On May 26, 2012, at 2:22 AM, Alejandro E Murillo wrote: > Requesting approval to integrate hs23.2-b03 into jdk7u6-b12. > > A webrev is available at: > > http://cr.openjdk.java.net/~amurillo/7u6/hs23.2-b03-jdk7u6-b12.webrev/ > > Pre-integration testing is in progress; the integration will proceed > only after SQE has analyzed the results and approved. > > The fixes in the proposed integration are below. All have undergone > nightly testing and are already in a jdk8 repository. > > 6924259: Remove String.count/String.offset > 7157141: crash in 64 bit with corrupted oops > 7158457: division by zero in adaptiveweightedaverage > 7160539: JDeveloper crashes on 64-bit Windows > 7165755: OS Information much longer on linux than other platforms > 7167254: Crash on OSX in Enumerator.nextElement() with compressed oops > 7170009: new hotspot build - hs23.2-b03 > 7170197: Update JPRT default build targets to support embedded builds > > -- > Alejandro E Murillo, Java Performance > Phone: (303) 955-2584. > Timezone: US/Mountain (UTC-0700) > From daniel.daugherty at oracle.com Sat May 26 09:51:40 2012 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Sat, 26 May 2012 16:51:40 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7170449: Management is completely broken at least on Solaris 11 X86 Message-ID: <20120526165203.CAB8F47551@hg.openjdk.java.net> Changeset: 6432464ffec2 Author: dcubed Date: 2012-05-26 08:01 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/6432464ffec2 7170449: Management is completely broken at least on Solaris 11 X86 Summary: Work around 'gobjcopy' failures on Solaris by adding temporary tools to add the '.gnu_debuglink' section and remove the SHF_ALLOC flag from "empty" section headers. Reviewed-by: sspitsyn, acorn ! make/common/Defs-solaris.gmk ! make/common/Defs.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! make/tools/Makefile + make/tools/add_gnu_debuglink/Makefile + make/tools/add_gnu_debuglink/add_gnu_debuglink.c + make/tools/fix_empty_sec_hdr_flags/Makefile + make/tools/fix_empty_sec_hdr_flags/fix_empty_sec_hdr_flags.c From andrew.brygin at oracle.com Mon May 28 01:07:35 2012 From: andrew.brygin at oracle.com (Andrew Brygin) Date: Mon, 28 May 2012 12:07:35 +0400 Subject: [7u6] Request for approval: 7146550: [macosx] DnD test failure in createCompatibleWritableRaster() Message-ID: <4FC33247.2020604@oracle.com> Hello, Requesting approval to commit fix for 7146550 into 7u6. The fix has already been pushed to jdk8, the code changes for 7u6 are identical. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7146550 jdk8 changeset: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a2d12ca36eb3 Webrev: http://cr.openjdk.java.net/~bae/7146550/7u6/webrev.00/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004262.html Reviewed by: Artem Ananiev, Sergey Bylokhov Thanks, Andrew From edvard.wendelin at oracle.com Mon May 28 01:26:51 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Mon, 28 May 2012 10:26:51 +0200 Subject: [7u6] Request for approval: 7146550: [macosx] DnD test failure in createCompatibleWritableRaster() In-Reply-To: <4FC33247.2020604@oracle.com> References: <4FC33247.2020604@oracle.com> Message-ID: <4FC336CB.2060702@oracle.com> Looks good! Approved. On 05/28/2012 10:07 AM, Andrew Brygin wrote: > Hello, > > Requesting approval to commit fix for 7146550 into 7u6. > > The fix has already been pushed to jdk8, the code changes for 7u6 are > identical. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7146550 > jdk8 changeset: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a2d12ca36eb3 > Webrev: http://cr.openjdk.java.net/~bae/7146550/7u6/webrev.00/ > Review thread: > http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004262.html > Reviewed by: Artem Ananiev, Sergey Bylokhov > > Thanks, > Andrew From dmitry.cherepanov at oracle.com Mon May 28 01:58:56 2012 From: dmitry.cherepanov at oracle.com (Dmitry Cherepanov) Date: Mon, 28 May 2012 12:58:56 +0400 Subject: [7u6] Request for approval for 7168550: [macosx] duplicate OGL context state changes related to vertex cache Message-ID: <4FC33E50.7050505@oracle.com> This is a request to push the following fix: Bug: http://bugs.sun.com/view_bug.do?bug_id=7168550 Webrev: http://cr.openjdk.java.net/~dcherepanov/7168550/7u6/webrev.0/ Technical review: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004264.html Thanks, Dmitry From dmitry.cherepanov at oracle.com Mon May 28 02:02:47 2012 From: dmitry.cherepanov at oracle.com (Dmitry Cherepanov) Date: Mon, 28 May 2012 13:02:47 +0400 Subject: [7u6] Request for approval for 7160293: [macosx] FileDialog appears on secondary display Message-ID: <4FC33F37.5010204@oracle.com> This is a request to push the following fix: Bug: http://bugs.sun.com/view_bug.do?bug_id=7160293 Webrev: http://cr.openjdk.java.net/~dcherepanov/7160293/7u6/webrev.0/ Technical review: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004265.html Thanks, Dmitry From edvard.wendelin at oracle.com Mon May 28 02:02:12 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Mon, 28 May 2012 11:02:12 +0200 Subject: [7u6] Request for approval for 7168550: [macosx] duplicate OGL context state changes related to vertex cache In-Reply-To: <4FC33E50.7050505@oracle.com> References: <4FC33E50.7050505@oracle.com> Message-ID: <4FC33F14.2090903@oracle.com> Approved. On 05/28/2012 10:58 AM, Dmitry Cherepanov wrote: > This is a request to push the following fix: > > Bug: http://bugs.sun.com/view_bug.do?bug_id=7168550 > > Webrev: http://cr.openjdk.java.net/~dcherepanov/7168550/7u6/webrev.0/ > > Technical review: > http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004264.html > > Thanks, > Dmitry > From edvard.wendelin at oracle.com Mon May 28 02:02:19 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Mon, 28 May 2012 11:02:19 +0200 Subject: [7u6] Request for approval for 7160293: [macosx] FileDialog appears on secondary display In-Reply-To: <4FC33F37.5010204@oracle.com> References: <4FC33F37.5010204@oracle.com> Message-ID: <4FC33F1B.1010801@oracle.com> Approved. On 05/28/2012 11:02 AM, Dmitry Cherepanov wrote: > This is a request to push the following fix: > > Bug: http://bugs.sun.com/view_bug.do?bug_id=7160293 > > Webrev: http://cr.openjdk.java.net/~dcherepanov/7160293/7u6/webrev.0/ > > Technical review: > http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004265.html > > Thanks, > Dmitry > From andrew.brygin at oracle.com Mon May 28 02:16:23 2012 From: andrew.brygin at oracle.com (andrew.brygin at oracle.com) Date: Mon, 28 May 2012 09:16:23 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7146550: [macosx] DnD test failure in createCompatibleWritableRaster() Message-ID: <20120528091651.30CC847567@hg.openjdk.java.net> Changeset: e9014eaf0e03 Author: bae Date: 2012-05-28 13:19 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/e9014eaf0e03 7146550: [macosx] DnD test failure in createCompatibleWritableRaster() Reviewed-by: art, serb ! src/macosx/classes/sun/lwawt/macosx/CDragSourceContextPeer.java ! src/macosx/classes/sun/lwawt/macosx/CImage.java ! src/macosx/native/sun/awt/CDragSource.h ! src/macosx/native/sun/awt/CDragSource.m ! src/macosx/native/sun/awt/CDragSourceContextPeer.m ! test/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.java From andrew.brygin at oracle.com Mon May 28 02:25:03 2012 From: andrew.brygin at oracle.com (andrew.brygin at oracle.com) Date: Mon, 28 May 2012 09:25:03 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7124400: [macosx] CGraphicsDevice.getConfigurations() returns reference to member (does not copy configs) Message-ID: <20120528092557.6BBD647568@hg.openjdk.java.net> Changeset: 7f0e6be7f7ea Author: bae Date: 2012-05-28 13:29 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/7f0e6be7f7ea 7124400: [macosx] CGraphicsDevice.getConfigurations() returns reference to member (does not copy configs) Reviewed-by: art, anthony ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! test/java/awt/GraphicsDevice/CloneConfigsTest.java From andrew.brygin at oracle.com Mon May 28 02:31:47 2012 From: andrew.brygin at oracle.com (andrew.brygin at oracle.com) Date: Mon, 28 May 2012 09:31:47 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7154088: [macosx] Regression: Component.createImage do not inherits component attributes Message-ID: <20120528093200.201E247569@hg.openjdk.java.net> Changeset: 9fa6e878fcdb Author: bae Date: 2012-05-28 13:36 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/9fa6e878fcdb 7154088: [macosx] Regression: Component.createImage do not inherits component attributes Reviewed-by: anthony ! src/macosx/classes/sun/lwawt/LWComponentPeer.java From dmitry.cherepanov at oracle.com Mon May 28 02:41:57 2012 From: dmitry.cherepanov at oracle.com (dmitry.cherepanov at oracle.com) Date: Mon, 28 May 2012 09:41:57 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7168550: [macosx] duplicate OGL context state changes related to vertex cache Message-ID: <20120528094209.C6B7A4756A@hg.openjdk.java.net> Changeset: 533eb1663b90 Author: dcherepanov Date: 2012-05-28 13:46 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/533eb1663b90 7168550: [macosx] duplicate OGL context state changes related to vertex cache Reviewed-by: bae ! src/macosx/native/sun/java2d/opengl/CGLGraphicsConfig.m ! src/macosx/native/sun/java2d/opengl/CGLSurfaceData.m ! src/share/native/sun/java2d/opengl/OGLContext.h ! src/share/native/sun/java2d/opengl/OGLTextRenderer.c ! src/share/native/sun/java2d/opengl/OGLVertexCache.c ! src/share/native/sun/java2d/opengl/OGLVertexCache.h From dmitry.cherepanov at oracle.com Mon May 28 02:48:50 2012 From: dmitry.cherepanov at oracle.com (dmitry.cherepanov at oracle.com) Date: Mon, 28 May 2012 09:48:50 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7160293: [macosx] FileDialog appears on secondary display Message-ID: <20120528094902.AA3BD4756B@hg.openjdk.java.net> Changeset: 36a5fa410439 Author: dcherepanov Date: 2012-05-28 13:52 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/36a5fa410439 7160293: [macosx] FileDialog appears on secondary display Reviewed-by: anthony, kizune ! src/macosx/classes/sun/awt/CGraphicsEnvironment.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/PlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m From leonid.romanov at oracle.com Mon May 28 08:06:45 2012 From: leonid.romanov at oracle.com (leonid.romanov at oracle.com) Date: Mon, 28 May 2012 15:06:45 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7124411: [macosx] There's no KEY_TYPED for VK_ESCAPE Message-ID: <20120528150655.B006F4756C@hg.openjdk.java.net> Changeset: 7e2de40cb062 Author: leonidr Date: 2012-05-28 19:06 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/7e2de40cb062 7124411: [macosx] There's no KEY_TYPED for VK_ESCAPE Reviewed-by: anthony ! src/macosx/native/sun/awt/AWTEvent.m From Ulf.Zibis at gmx.de Fri May 25 18:43:40 2012 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Sat, 26 May 2012 03:43:40 +0200 Subject: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps In-Reply-To: <7AF40196-1CEA-4BFC-82C7-8AF9C4535D03@oracle.com> References: <7AF40196-1CEA-4BFC-82C7-8AF9C4535D03@oracle.com> Message-ID: <4FC0354C.4010207@gmx.de> Am 23.05.2012 07:16, schrieb Mike Duigou: > Webrevs for the Java 7u6 and 8 changes are available for download at [2] and [3] for your review. There are some important differences between the Java 7 and 8 implementations of this enhancement. Most specifically in the Java 8 implementation alternative string hashing is always enabled--no threshold is used for enablement and alternative hashing cannot be disabled. (The Java 8 implementation completely ignores the jdk.map.althashing.threshold system property). The Java 8 implementation is also subject to additional refinement as Java 8 develops. To me it seems, that computing the murmur hash is more expensive, especially on short strings, than the old hash algorithm. So I think, a developer should have an influence on the hash algorithm to be used by a hash map, especially for strings, see http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6812862. So I propose a public accessible field in String: public int customHash; Then the HashMap should have an overrideable hash method: protected int hash(K key) { h = key.hashCode(); h ^= (h >>> 20) ^ (h >>> 12); return h ^ (h >>> 7) ^ (h >>> 4); } Then we should have a new class: public class MurmurHashMap extends HashMap { protected final int hash(String key) { int h = key.customHash; if (h == 0) { // harmless data race on customHash here. h = Hashing.murmur3_32(HASHING_SEED, key); // ensure result is not zero to avoid recalculating h = (h != 0) ? h : 1; key.customHash = h; } return hashMask ^ h; } In class Hashing we need: public static int murmur3_32(int seed, String key) { int h1 = seed; int count = key.length(); // body for (int off = 0; count >= 2;) { int k1 = (key.charAt(off++) & 0xFFFF) | key.charAt(off++) << 16); // alternative: for (int off = 0; count >= 4;) { int k1 = (key.charAt(off) & 0x0FF) | (key.charAt(off + 1) & 0x0FF) << 8 | (key.charAt(off + 2) & 0x0FF) << 16 | key.charAt(off + 3) << 24; ... } ... } For other use cases see: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6812862 -Ulf From dl at cs.oswego.edu Mon May 28 12:34:22 2012 From: dl at cs.oswego.edu (Doug Lea) Date: Mon, 28 May 2012 15:34:22 -0400 Subject: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps In-Reply-To: <4FC0354C.4010207@gmx.de> References: <7AF40196-1CEA-4BFC-82C7-8AF9C4535D03@oracle.com> <4FC0354C.4010207@gmx.de> Message-ID: <4FC3D33E.3060407@cs.oswego.edu> On 05/25/12 21:43, Ulf Zibis wrote: > To me it seems, that computing the murmur hash is more expensive, especially on > short strings, than the old hash algorithm. It is definitely slower, but also definitely has better statistical properties (fewer collisions when used in hash tables). In its original (C) context, Murmur hash is often about as fast as other string hashes, because it operates on 4byte words rather than 1-byte elements at a time. So even though the per-element cost is much higher, it takes 1/4 the steps. When done on Java char[]'s though, it can only process 2 chars at a time. (Plus, we cannot necessarily read 32bitsat a time because of possible byteswapping.) So it is a struggle to make it only twice as slow. This means that any application that hashes strings only once will be slower than using (old) hashCode. but any application that uses the (cached) hashes more than a few times will tend to run faster than old hashCode version because of higher quality hash codes. A few tests so far confirm this. Because performance is so sensitive to this re-use factor, it is hard to test expected performance impact without other JVM/JDK changes. To get a better handle on this, I put together an emulation (using Unsafe) that stashes murmur3 hash in current String.hash field. This is not exactly correct for String objects that might be concurrently hashed by different threads (one via the hash32 emulation, one via plain hashCode), but might be useful for people to try in contexts where this can't happen. See code at http://gee.cs.oswego.edu/dl/wwwtmp/Althash.java > So I think, a developer should have an influence on the hash algorithm to be > used by a hash map, I've had to make a lot of internal adjustments in hash tables to counteract crummy user hashCode() algorithms over the years, so I think that the less control, the better :-) -Doug From rob.mckenna at oracle.com Mon May 28 15:02:10 2012 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Mon, 28 May 2012 22:02:10 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7168110: Misleading jstack error message Message-ID: <20120528220221.534FC47571@hg.openjdk.java.net> Changeset: c528acec8bba Author: robm Date: 2012-05-17 22:42 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/c528acec8bba 7168110: Misleading jstack error message Reviewed-by: alanb, dsamersoff ! src/windows/native/sun/tools/attach/WindowsVirtualMachine.c From lana.steuck at oracle.com Mon May 28 16:08:32 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 28 May 2012 23:08:32 +0000 Subject: hg: jdk7u/jdk7u/langtools: 4 new changesets Message-ID: <20120528230840.EFD3D47572@hg.openjdk.java.net> Changeset: b020b7a017cc Author: jjg Date: 2012-05-15 17:47 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/b020b7a017cc 7112427: The doclet needs to be able to generate JavaFX documentation. Reviewed-by: jjg Contributed-by: jan.valenta at oracle.com ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java + src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlConstants.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/PropertyWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/WriterFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/BuilderFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PropertyBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties + src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BasePropertyTaglet.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/PropertyGetterTaglet.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/PropertySetterTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/IndexBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java + test/com/sun/javadoc/testJavaFX/C.java + test/com/sun/javadoc/testJavaFX/D.java + test/com/sun/javadoc/testJavaFX/TestJavaFX.java Changeset: 6ff4a476201e Author: lana Date: 2012-05-18 15:16 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/6ff4a476201e Merge Changeset: 63327fd6e6d3 Author: dmeetry Date: 2012-05-22 20:19 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/63327fd6e6d3 7148556: Implementing a generic interface causes a public clone() to become inaccessible Summary: Implementation of Resolve.isOverriddenIn() should distinguish between classes/interfaces Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symbol.java + test/tools/javac/generics/rawOverride/T7148556.java Changeset: f0be10a26af0 Author: lana Date: 2012-05-25 12:37 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/f0be10a26af0 Merge From lana.steuck at oracle.com Mon May 28 16:08:46 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 28 May 2012 23:08:46 +0000 Subject: hg: jdk7u/jdk7u/jdk: 30 new changesets Message-ID: <20120528231401.8E8A647574@hg.openjdk.java.net> Changeset: 996fd01472ee Author: xuelei Date: 2012-05-08 19:44 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/996fd01472ee 7153184: NullPointerException when calling SSLEngineImpl.getSupportedCipherSuites Reviewed-by: weijun, dholmes ! src/share/classes/sun/security/ssl/SSLContextImpl.java Changeset: 997176fc0a83 Author: xuelei Date: 2012-05-10 17:53 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/997176fc0a83 7166570: JSSE certificate validation has started to fail for certificate chains Reviewed-by: wetmore ! src/share/classes/sun/security/validator/SimpleValidator.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/BasicConstraints.java Changeset: 96bbb23bbaca Author: coffeys Date: 2012-05-11 11:52 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/96bbb23bbaca 7167359: (tz) SEGV on solaris if TZ variable not set Reviewed-by: okutsu ! src/solaris/native/java/util/TimeZone_md.c Changeset: 8004f3dd5c54 Author: mduigou Date: 2012-05-11 10:46 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/8004f3dd5c54 7149320: Move sun.misc.VM.booted() to the end of System.initializeSystemClass() Summary: Ensure that sun.misc.VM.booted() is the last action in System.initSystemClass() Reviewed-by: dholmes, alanb ! src/share/classes/java/lang/System.java Changeset: 0128a8d8c0b4 Author: dholmes Date: 2012-05-10 23:56 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/0128a8d8c0b4 7168098: Adjustments for SE-Embedded build process Reviewed-by: dholmes Contributed-by: Gary Collins ! make/com/oracle/Makefile ! make/common/Defs-embedded.gmk Changeset: ab8bb05a32c7 Author: alexsch Date: 2012-05-14 18:17 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/ab8bb05a32c7 7093156: NLS Please change the mnemonic assignment system to avoid translation issue (Swing files) Reviewed-by: rupashka, alexp ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_de.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_es.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_fr.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_it.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_ja.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_ko.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_sv.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_de.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_es.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_it.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_de.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_es.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_it.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_TW.properties ! src/share/classes/javax/swing/UIDefaults.java Changeset: e4c3092a3a0e Author: alexsch Date: 2012-05-15 11:38 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/e4c3092a3a0e 7024963: Notepad demo: remove non-translatable resources from Notepad.properties file Reviewed-by: rupashka ! src/share/demo/jfc/Notepad/Notepad.java ! src/share/demo/jfc/Notepad/resources/Notepad.properties + src/share/demo/jfc/Notepad/resources/system.properties Changeset: eb7b250d92e6 Author: alexsch Date: 2012-05-15 11:45 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/eb7b250d92e6 7024965: Stylepad demo: remove non-translatable resources from Stylepad.properties file Reviewed-by: alexp ! src/share/demo/jfc/Notepad/Notepad.java + src/share/demo/jfc/Notepad/resources/NotepadSystem.properties - src/share/demo/jfc/Notepad/resources/system.properties Changeset: fa84dc221972 Author: anthony Date: 2012-05-15 15:24 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/fa84dc221972 7166437: [macosx] Support for Window.Type.UTILITY on the Mac Summary: Apply the native UTILITY style to Java UTILITY windows Reviewed-by: kizune, serb ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Changeset: b5b68b7b6aa6 Author: anthony Date: 2012-05-15 17:29 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/b5b68b7b6aa6 7149062: [macosx] dock menu don't show available frames Summary: Use either NSWindow or NSPanel as an ancestor for Java windows. NSWindow-based windows will be added to the dock icon menu. Reviewed-by: swingler ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.h ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 9bf4105ce716 Author: robm Date: 2012-05-15 21:35 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/9bf4105ce716 7166687: InetAddress.getLocalHost().getHostName() returns FQDN Reviewed-by: chegar ! src/solaris/native/java/net/Inet6AddressImpl.c Changeset: 20171c9ae8eb Author: alexsch Date: 2012-05-16 18:56 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/20171c9ae8eb 7169226: NLS: Please change the mnemonic assignment system for windows and motif properties Reviewed-by: rupashka ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_de.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_es.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_fr.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_it.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ja.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ko.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_sv.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_TW.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_de.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_es.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_fr.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_it.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ja.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ko.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_sv.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_TW.properties Changeset: c743f3d53835 Author: mfang Date: 2012-05-16 12:01 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/c743f3d53835 7157855: jvisualvm.1 not included in binaries Reviewed-by: katleman, thurka ! make/common/Release.gmk Changeset: 7f2d38ddd4e8 Author: mfang Date: 2012-05-16 12:06 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/7f2d38ddd4e8 Merge Changeset: b92ca4e51f9a Author: alexsch Date: 2012-05-17 14:15 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/b92ca4e51f9a 7158928: [macosx] NLS: Please change the mnemonic assignment system Reviewed-by: rupashka, serb ! make/com/apple/osxui/Makefile ! make/common/internal/Resources.gmk ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java ! src/macosx/classes/com/apple/laf/resources/aqua.properties Changeset: 064518e6c298 Author: khazra Date: 2012-05-17 12:12 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/064518e6c298 7096436: (sc) SocketChannel.connect fails on Windows 8 when channel configured non-blocking Reviewed-by: alanb ! src/share/classes/sun/nio/ch/SocketChannelImpl.java Changeset: 90588888a082 Author: asaha Date: 2012-05-17 12:35 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/90588888a082 7156842: test/java/util/zip/ZipFile/vmcrash.zip triggers McAffe virus warning Reviewed-by: sherman - test/java/util/zip/ZipFile/VmCrash.java - test/java/util/zip/ZipFile/vmcrash.zip Changeset: a9cf66e39b38 Author: dcubed Date: 2012-05-17 12:41 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/a9cf66e39b38 7168520: No jdk8 TL Nightly linux builds due to broken link in b39-2012-05-13_231 Summary: ZIP libjsig.debuginfo links into libjsig.diz files since aurora doesn't like dangling symlinks Reviewed-by: katleman, acorn ! make/java/redist/Makefile Changeset: 6f9e7feeac32 Author: mduigou Date: 2012-05-11 11:31 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/6f9e7feeac32 7071826: Avoid benign race condition in initialization of UUID Summary: Avoids mostly benign but sometimes expensive race condition on initialization of UUID.numberGenerator which is used by UUID.randomUUID() Reviewed-by: alanb, chegar ! src/share/classes/java/util/UUID.java ! test/java/util/UUID/UUIDTest.java Changeset: e7e8ca3601e7 Author: alanb Date: 2012-05-18 10:47 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/e7e8ca3601e7 7143744: (se) Stabilize KQueue SelectorProvider and make default on MacOSX Reviewed-by: michaelm, chegar ! src/macosx/classes/sun/nio/ch/DefaultSelectorProvider.java ! src/macosx/classes/sun/nio/ch/KQueueArrayWrapper.java ! src/macosx/classes/sun/nio/ch/KQueueSelectorImpl.java ! src/macosx/classes/sun/nio/ch/KQueueSelectorProvider.java ! src/macosx/native/sun/nio/ch/KQueueArrayWrapper.c ! test/java/nio/channels/Selector/OpRead.java ! test/sun/nio/ch/SelProvider.java Changeset: d0673deb4510 Author: alanb Date: 2012-05-18 10:48 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/d0673deb4510 7127235: (fs) NPE in Files.walkFileTree if cached attributes are GC'ed Reviewed-by: forax, chegar ! src/share/classes/java/nio/file/FileTreeWalker.java Changeset: ae1beadd3870 Author: coffeys Date: 2012-05-18 10:50 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/ae1beadd3870 7103889: (fs) Reduce String concatenation when iterating over directory Reviewed-by: alanb Contributed-by: mike.skells at talk21.com ! src/share/classes/java/nio/file/Files.java ! src/windows/classes/sun/nio/fs/WindowsDirectoryStream.java ! src/windows/classes/sun/nio/fs/WindowsPathParser.java Changeset: e15839c985d1 Author: raginip Date: 2012-05-18 14:22 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/e15839c985d1 7166956: Integrate the Java Access Bridge with Java Runtime Reviewed-by: ohair, ptbrunet ! make/Makefile + make/bridge/AccessBridgeJava/Makefile + make/bridge/JAWTAccessBridge/Files_cpp.gmk + make/bridge/JAWTAccessBridge/Makefile + make/bridge/Jabswitch/Makefile + make/bridge/Jaccess/Makefile + make/bridge/JavaAccessBridge/Files_cpp.gmk + make/bridge/JavaAccessBridge/Makefile + make/bridge/Makefile + make/bridge/WindowsAccessBridge/Files_cpp.gmk + make/bridge/WindowsAccessBridge/Makefile Changeset: e3478500d252 Author: lana Date: 2012-05-18 15:15 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/e3478500d252 Merge Changeset: d75496a7c71b Author: anthony Date: 2012-05-21 18:35 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/d75496a7c71b 7144542: [macosx] Crash in liblwawt.dylib setBusy() when exiting an FX app Summary: Use XToolkit instead of CToolkit in headless mode Reviewed-by: art ! src/solaris/native/sun/awt/awt_LoadLibrary.c Changeset: 7498514309e3 Author: mgronlun Date: 2012-04-10 10:32 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/7498514309e3 7154809: JDI: update JDI/JDB debugee commandline option parsing Summary: update debugee commandline parsing Reviewed-by: dcubed, dsamersoff, sla ! src/share/classes/com/sun/tools/example/debug/tty/VMConnection.java Changeset: 05c4a1c2ce25 Author: sla Date: 2012-05-21 19:28 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/05c4a1c2ce25 7167157: jcmd command file parsing does not respect the "stop" command Reviewed-by: alanb, dsamersoff, nloodin ! src/share/classes/sun/tools/jcmd/JCmd.java Changeset: f35dfb4114e7 Author: alanb Date: 2012-05-22 17:54 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/f35dfb4114e7 6346658: (se) Selector briefly spins when asynchronously closing a registered channel [win] Reviewed-by: chegar, coffeys ! src/share/classes/sun/nio/ch/NativeThreadSet.java ! src/windows/classes/sun/nio/ch/NativeThread.java ! src/windows/classes/sun/nio/ch/SocketDispatcher.java ! src/windows/native/sun/nio/ch/SocketDispatcher.c Changeset: 5bf0eb7c560c Author: andrew Date: 2012-03-08 14:04 +0000 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/5bf0eb7c560c 7150392: Linux build breaks with GCC 4.7 due to unrecognized option Summary: Remove -mimpure-text option. Reviewed-by: ohair, dholmes, phh, andrew Contributed-by: Deepak Bhole ! make/common/shared/Compiler-gcc.gmk ! src/share/demo/jvmti/compiledMethodLoad/sample.makefile.txt ! src/share/demo/jvmti/gctest/sample.makefile.txt ! src/share/demo/jvmti/heapTracker/sample.makefile.txt ! src/share/demo/jvmti/heapViewer/sample.makefile.txt ! src/share/demo/jvmti/hprof/sample.makefile.txt ! src/share/demo/jvmti/index.html ! src/share/demo/jvmti/java_crw_demo/sample.makefile.txt ! src/share/demo/jvmti/minst/sample.makefile.txt ! src/share/demo/jvmti/mtrace/sample.makefile.txt ! src/share/demo/jvmti/versionCheck/sample.makefile.txt ! src/share/demo/jvmti/waiters/sample.makefile.txt Changeset: 76306dce8710 Author: lana Date: 2012-05-25 12:37 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/76306dce8710 Merge From lana.steuck at oracle.com Mon May 28 16:20:27 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 28 May 2012 16:20:27 -0700 (PDT) Subject: jdk7u-b12: jdk7u-dev Message-ID: <201205282320.q4SNKRX7011687@jano-app.us.oracle.com> http://hg.openjdk.java.net/jdk7u/jdk7u/rev/61cfcee1d00c http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/f0be10a26af0 http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/76306dce8710 http://hg.openjdk.java.net/jdk7u/jdk7u/jaxws/rev/95a96a879b8c http://hg.openjdk.java.net/jdk7u/jdk7u/jaxp/rev/c378e596fb5b http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/897d453d26ac http://hg.openjdk.java.net/jdk7u/jdk7u/corba/rev/34354c623c45 --- All the fixes will be tested during promotion (no PIT testing at this point): 7112427 docl stddoclet The doclet needs to be able to generate JavaFX documentation 7166956 java accessibility Integrate the Java Access Bridge with Java Runtime 7150322 java build Stop using drop source bundles in jaxws 7150392 java build Linux build breaks with GCC 4.7 due to unrecognized option 7168374 java build Upgrade of XML components to JAXB 2.2.4-2, SAAJ 1.3.16, JAXW 7168520 java build No jdk8 TL Nightly linux builds due to broken link in b39-20 7144542 java classes_awt [macosx] Crash in liblwawt.dylib setBusy() when exiting an F 7149062 java classes_awt [macosx] dock menu don't show available frames 7166437 java classes_awt [macosx] Support for Window.Type.UTILITY on the Mac 7149320 java classes_lang Move sun.misc.VM.booted() to end of System.initializeSystemC 7166687 java classes_net InetAddress.getLocalHost().getHostName() returns FQDN 6346658 java classes_nio (se) Selector briefly spins when asynchronously closing a re 7096436 java classes_nio (sc) SocketChannel.connect fails on Windows 8 when channel c 7103889 java classes_nio (fs) Reduce String concatenation when iterating over directo 7127235 java classes_nio (fs) NPE in Files.walkFileTree if cached attributes are GC'e 7143744 java classes_nio (se) Stabilize KQueue SelectorProvider and make default on M 7093156 java classes_swing NLS: Please change the mnemonic assignment system to avoid t 7158926 java classes_swing NLS: Please change the mnemonic assignment system in swing d 7158928 java classes_swing [macosx] NLS: Please change the mnemonic assignment system 7169226 java classes_swing NLS: Please change the mnemonic assignment system for window 7071826 java classes_util UUID.randomUUID() race condition 7167359 java classes_util_i18 (tz) SEGV on solaris if TZ variable not set 7156842 java classes_util_jar test/java/util/zip/ZipFile/vmcrash.zip triggers McAffe virus 7148556 java compiler Implementing a generic interface causes a public clone() to 7154809 java debugger JDI: update JDI/JDB debugee commandline option parsing 7024963 java demo Notepad demo: remove non-translatable resources from Notepad 7024965 java demo Stylepad demo: remove non-translatable resources from Stylep 7168098 java embedded Adjustments for SE-Embedded build process 7167824 java jfr JFR: add jfr-disabled.jar JFR stubs for WLS 7171093 java jfr Missing synchronization in oracle.jrockit.jfr.Settings 7157855 java localization jvisualvm.1 not included in binaries 7167157 java serviceability jcmd command file parsing does not respect the "stop" comman 7153184 jsse runtime NullPointerException when calling SSLEngineImpl.getSupported 7166570 jsse runtime JSSE certificate validation has started to fail for certific From david.holmes at oracle.com Mon May 28 17:15:49 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 29 May 2012 10:15:49 +1000 Subject: CR Management Message-ID: <4FC41535.1010407@oracle.com> Just a heads up for all the non-Oracle Commiters. If you push something to 7u-dev please liaise with whomever assisted with the 8 push to ensure that a sub-CR has been created for the appropriate 7uX release. Thanks, David Holmes From henri.gomez at gmail.com Tue May 29 01:01:54 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Tue, 29 May 2012 10:01:54 +0200 Subject: OSX universal build broken in latest jdk7u Message-ID: I get the following error when building latest jdk7u : dk7u/workspace/jdk/src/macosx//native/sun/font -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/solaris//native/sun/font -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/share//native/sun/font -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/macosx//native/sun/java2d -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/solaris//native/sun/java2d -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/share//native/sun/java2d -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/macosx//native/sun/java2d/opengl -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/solaris//native/sun/java2d/opengl -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/share//native/sun/java2d/opengl -c -o /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/build/macosx-universal/tmp/sun/sun.lwawt/lwawt/obj/AWTEvent.o /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/macosx/native/sun/awt/AWTEvent.m /Applications/Xcode.app/Contents/Developer/usr/bin/llvm-gcc -Os -fno-strict-aliasing -fPIC -W -Wall -Wno-unused -Wno-parentheses -arch i386 -arch x86_64 -D_LITTLE_ENDIAN -F/System/Library/Frameworks/JavaVM.framework/Frameworks -F/System/Library/Frameworks/ApplicationServices.framework/Frameworks -DNDEBUG -DARCH='"universal"' -Duniversal -D_ALLBSD_SOURCE -DRELEASE='"1.7.0-jdk7u6-b11"' -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -D_REENTRANT -DMACOSX -I. -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/build/macosx-universal/tmp/sun/sun.lwawt/lwawt/CClassHeaders -I../../../src/solaris/javavm/export -I../../../src/share/javavm/export -I../../../src/share/native/common -I../../../src/solaris/native/common -I../../../src/share/native/sun/lwawt -I../../../src/solaris/native/sun/lwawt -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/build/macosx-universal/tmp/sun/sun.lwawt/lwawt/CClassHeaders -I../../../src/share/native/sun/awt/debug -I../../../src/share/native/sun/awt/image/cvutils -I../../../src/share/native/sun/java2d -I../../../src/share/native/sun/java2d/loops -I../../../src/share/native/sun/awt/image/cvutils -I../../../src/share/native/sun/awt/image -I../../../src/share/native/sun/font -I../../../src/share/native/sun/java2d/pipe -I../../../src/share/native/sun/java2d/opengl -I../../../src/share/native/sun/dc/path -I../../../src/share/native/sun/dc/doe -I../../../src/share/native/sun/awt/alphacomposite -I../../../src/share/native/sun/awt/medialib -I../../../src/share/native/sun/awt -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/macosx//native/sun/awt -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/solaris//native/sun/awt -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/share//native/sun/awt -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/macosx//native/sun/osxapp -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/solaris//native/sun/osxapp -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/share//native/sun/osxapp -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/macosx//native/sun/font -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/solaris//native/sun/font -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/share//native/sun/font -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/macosx//native/sun/java2d -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/solaris//native/sun/java2d -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/share//native/sun/java2d -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/macosx//native/sun/java2d/opengl -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/solaris//native/sun/java2d/opengl -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/share//native/sun/java2d/opengl -c -o /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/build/macosx-universal/tmp/sun/sun.lwawt/lwawt/obj/AWTView.o /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/macosx/native/sun/awt/AWTView.m /Applications/Xcode.app/Contents/Developer/usr/bin/llvm-gcc -Os -fno-strict-aliasing -fPIC -W -Wall -Wno-unused -Wno-parentheses -arch i386 -arch x86_64 -D_LITTLE_ENDIAN -F/System/Library/Frameworks/JavaVM.framework/Frameworks -F/System/Library/Frameworks/ApplicationServices.framework/Frameworks -DNDEBUG -DARCH='"universal"' -Duniversal -D_ALLBSD_SOURCE -DRELEASE='"1.7.0-jdk7u6-b11"' -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -D_REENTRANT -DMACOSX -I. -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/build/macosx-universal/tmp/sun/sun.lwawt/lwawt/CClassHeaders -I../../../src/solaris/javavm/export -I../../../src/share/javavm/export -I../../../src/share/native/common -I../../../src/solaris/native/common -I../../../src/share/native/sun/lwawt -I../../../src/solaris/native/sun/lwawt -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/build/macosx-universal/tmp/sun/sun.lwawt/lwawt/CClassHeaders -I../../../src/share/native/sun/awt/debug -I../../../src/share/native/sun/awt/image/cvutils -I../../../src/share/native/sun/java2d -I../../../src/share/native/sun/java2d/loops -I../../../src/share/native/sun/awt/image/cvutils -I../../../src/share/native/sun/awt/image -I../../../src/share/native/sun/font -I../../../src/share/native/sun/java2d/pipe -I../../../src/share/native/sun/java2d/opengl -I../../../src/share/native/sun/dc/path -I../../../src/share/native/sun/dc/doe -I../../../src/share/native/sun/awt/alphacomposite -I../../../src/share/native/sun/awt/medialib -I../../../src/share/native/sun/awt -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/macosx//native/sun/awt -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/solaris//native/sun/awt -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/share//native/sun/awt -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/macosx//native/sun/osxapp -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/solaris//native/sun/osxapp -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/share//native/sun/osxapp -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/macosx//native/sun/font -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/solaris//native/sun/font -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/share//native/sun/font -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/macosx//native/sun/java2d -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/solaris//native/sun/java2d -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/share//native/sun/java2d -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/macosx//native/sun/java2d/opengl -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/solaris//native/sun/java2d/opengl -I/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/share//native/sun/java2d/opengl -c -o /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/build/macosx-universal/tmp/sun/sun.lwawt/lwawt/obj/AWTWindow.o /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/macosx/native/sun/awt/AWTWindow.m /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/jdk/src/macosx/native/sun/awt/AWTWindow.m:127: error: synthesized property 'nsWindow' must either be named the same as a compatible ivar or must explicitly name an ivar >From http://www.cocoabuilder.com/archive/cocoa/311087-about-ivars-declaration-and-property.html, it seems ivar is not declared as 32bits compatible and as such it broke universal build. Is it an expected feature ? From kurchi.subhra.hazra at oracle.com Tue May 29 13:35:57 2012 From: kurchi.subhra.hazra at oracle.com (Kurchi Hazra) Date: Tue, 29 May 2012 13:35:57 -0700 Subject: [7u6] Request for approval: 7170169: (props) System.getProperty("os.name") should return "Windows 8" when run on Windows Message-ID: <4FC5332D.5020506@oracle.com> Requesting approval to commit fix for CR 7170169. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170169 Webrev: http://cr.openjdk.java.net/~khazra/7170169/7u6/webrev.00/ This had been reviewed by darcy, dholmes, alanb, chegar. [1] This fix has been pushed into jdk8 [2] Thanks, Kurchi [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-May/010233.html [2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c3d9050c918 From john.coomes at oracle.com Tue May 29 14:51:34 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Tue, 29 May 2012 21:51:34 +0000 Subject: hg: jdk7u/jdk7u-dev/hotspot: Added tag jdk7u6-b11 for changeset 5921bdc6ce5c Message-ID: <20120529215136.EADCE4759F@hg.openjdk.java.net> Changeset: 897d453d26ac Author: katleman Date: 2012-05-24 15:27 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/897d453d26ac Added tag jdk7u6-b11 for changeset 5921bdc6ce5c ! .hgtags From john.coomes at oracle.com Tue May 29 15:02:15 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Tue, 29 May 2012 22:02:15 +0000 Subject: hg: jdk7u/jdk7u-dev/hotspot: 11 new changesets Message-ID: <20120529220237.C796E475A0@hg.openjdk.java.net> Changeset: c7a2af36ee59 Author: amurillo Date: 2012-05-18 12:23 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/c7a2af36ee59 7170009: new hotspot build - hs23.2-b03 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 8a074526ffca Author: nloodin Date: 2012-05-10 15:44 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/8a074526ffca 7165755: OS Information much longer on linux than other platforms Reviewed-by: sla, dholmes ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp ! src/os/posix/vm/os_posix.cpp + src/os/posix/vm/os_posix.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.hpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.hpp ! src/share/vm/runtime/os.hpp Changeset: 3b1b50b3ad62 Author: never Date: 2012-04-02 16:05 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/3b1b50b3ad62 7157141: crash in 64 bit with corrupted oops Reviewed-by: kvn, iveresov ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/memory/barrierSet.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp ! src/share/vm/utilities/vmError.cpp Changeset: acd6a3802609 Author: iveresov Date: 2012-04-11 19:15 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/acd6a3802609 7160539: JDeveloper crashes on 64-bit Windows Summary: x64 C1 needs to zero upper 32bits when doing l2i conversion Reviewed-by: never, kvn ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: ea3152ff2a49 Author: roland Date: 2012-05-18 15:50 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/ea3152ff2a49 7167254: Crash on OSX in Enumerator.nextElement() with compressed oops Summary: null checks in "compressed oops with base" mode may trigger a SIGBUS rather than a SIGSEGV. Reviewed-by: dsamersoff, dcubed, rbackman, kvn ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp Changeset: 3facbb14e873 Author: kvn Date: 2012-05-14 09:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/3facbb14e873 6924259: Remove String.count/String.offset Summary: Allow a version of String class that doesn't have count and offset fields. Reviewed-by: never, coleenp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/memory/dump.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/opto/stringopts.hpp Changeset: c4b58f8eeeaf Author: mikael Date: 2012-05-15 00:56 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/c4b58f8eeeaf 7158457: division by zero in adaptiveweightedaverage Summary: Add ceiling to AdaptiveWeightedAverage Reviewed-by: ysr, iveresov ! src/share/vm/gc_implementation/shared/gcUtil.cpp ! src/share/vm/gc_implementation/shared/gcUtil.hpp Changeset: 3f1e457eda51 Author: dholmes Date: 2012-05-23 20:09 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/3f1e457eda51 7170197: Update JPRT default build targets to support embedded builds Reviewed-by: jcoomes, kvn ! make/jprt.properties Changeset: e974e1594565 Author: dholmes Date: 2012-05-25 05:12 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/e974e1594565 Merge Changeset: 365d216f0666 Author: amurillo Date: 2012-05-25 13:40 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/365d216f0666 Added tag hs23.2-b03 for changeset e974e1594565 ! .hgtags Changeset: f08a3a0e60c3 Author: amurillo Date: 2012-05-25 13:52 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/f08a3a0e60c3 Merge ! .hgtags ! make/hotspot_version ! src/os/windows/vm/os_windows.cpp From john.coomes at oracle.com Tue May 29 15:07:59 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Tue, 29 May 2012 22:07:59 +0000 Subject: hg: jdk7u/jdk7u/hotspot: 11 new changesets Message-ID: <20120529220823.44944475A1@hg.openjdk.java.net> Changeset: c7a2af36ee59 Author: amurillo Date: 2012-05-18 12:23 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/c7a2af36ee59 7170009: new hotspot build - hs23.2-b03 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 8a074526ffca Author: nloodin Date: 2012-05-10 15:44 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/8a074526ffca 7165755: OS Information much longer on linux than other platforms Reviewed-by: sla, dholmes ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp ! src/os/posix/vm/os_posix.cpp + src/os/posix/vm/os_posix.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.hpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.hpp ! src/share/vm/runtime/os.hpp Changeset: 3b1b50b3ad62 Author: never Date: 2012-04-02 16:05 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/3b1b50b3ad62 7157141: crash in 64 bit with corrupted oops Reviewed-by: kvn, iveresov ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/memory/barrierSet.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp ! src/share/vm/utilities/vmError.cpp Changeset: acd6a3802609 Author: iveresov Date: 2012-04-11 19:15 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/acd6a3802609 7160539: JDeveloper crashes on 64-bit Windows Summary: x64 C1 needs to zero upper 32bits when doing l2i conversion Reviewed-by: never, kvn ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: ea3152ff2a49 Author: roland Date: 2012-05-18 15:50 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/ea3152ff2a49 7167254: Crash on OSX in Enumerator.nextElement() with compressed oops Summary: null checks in "compressed oops with base" mode may trigger a SIGBUS rather than a SIGSEGV. Reviewed-by: dsamersoff, dcubed, rbackman, kvn ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp Changeset: 3facbb14e873 Author: kvn Date: 2012-05-14 09:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/3facbb14e873 6924259: Remove String.count/String.offset Summary: Allow a version of String class that doesn't have count and offset fields. Reviewed-by: never, coleenp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/memory/dump.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/opto/stringopts.hpp Changeset: c4b58f8eeeaf Author: mikael Date: 2012-05-15 00:56 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/c4b58f8eeeaf 7158457: division by zero in adaptiveweightedaverage Summary: Add ceiling to AdaptiveWeightedAverage Reviewed-by: ysr, iveresov ! src/share/vm/gc_implementation/shared/gcUtil.cpp ! src/share/vm/gc_implementation/shared/gcUtil.hpp Changeset: 3f1e457eda51 Author: dholmes Date: 2012-05-23 20:09 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/3f1e457eda51 7170197: Update JPRT default build targets to support embedded builds Reviewed-by: jcoomes, kvn ! make/jprt.properties Changeset: e974e1594565 Author: dholmes Date: 2012-05-25 05:12 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/e974e1594565 Merge Changeset: 365d216f0666 Author: amurillo Date: 2012-05-25 13:40 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/365d216f0666 Added tag hs23.2-b03 for changeset e974e1594565 ! .hgtags Changeset: f08a3a0e60c3 Author: amurillo Date: 2012-05-25 13:52 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/f08a3a0e60c3 Merge ! .hgtags ! make/hotspot_version ! src/os/windows/vm/os_windows.cpp From alejandro.murillo at oracle.com Tue May 29 15:27:28 2012 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Tue, 29 May 2012 16:27:28 -0600 Subject: jdk7u6-b12: HotSpot Message-ID: <4FC54D50.8020306@oracle.com> hs23.2-b03 has been integrated into jdk7u6-b12. http://hg.openjdk.java.net/jdk7u/jdk7u/rev/61cfcee1d00c http://hg.openjdk.java.net/jdk7u/jdk7u/corba/rev/34354c623c45 http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/f08a3a0e60c3 http://hg.openjdk.java.net/jdk7u/jdk7u/jaxp/rev/c378e596fb5b http://hg.openjdk.java.net/jdk7u/jdk7u/jaxws/rev/95a96a879b8c http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/76306dce8710 http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/f0be10a26af0 Component : VM Status : 0 major failures, 0 minor failures Date : 05/29/2012 at 11:17 Tested By : VM SQE& leonid.mesnik at oracle.com Cost(total man-days): 1 Workspace : 2012-05-25-204305.amurillo.hs23-2-b03-snapshot Bundles : 2012-05-25-204305.amurillo.hs23-2-b03-snapshot Platforms : Others Tests :/net/sqenfs-1.sfbay/export1/comp/vm/testbase/ Browsers : NA Patches : NA Logs :http://vmsqe-app.russia.sun.com/surl/Ja Number of Tests Executed : 450000 product tests, 0 unit tests, 0 tck tests Bug verification status: ====================================== Tested, Pass: 7165755: OS Information much longer for linux than other platforms Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: Setup is not available: 6924259: Remove String.count/String.offset/String.hashcode 7157141: crash in 64 bit with corrupted oops 7158457: stress: jdk7 u4 core dumps during megacart stress test run 7160539: JDeveloper crashes on 64-bit Windows 7167254: Crash on OSX in Enumerator.nextElement() with compressed oops Build change only: 7170009: new hotspot build - hs23.2-b03 7170197: Update JPRT default build targets to support embedded builds New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: Number of PIT requested: 1 Integration target J2SE build number: 7u6-b12 Issues and Notes: This is PIT for HS23.2 b03 for JDK7u6 b12. ------------------------------- From VM SQE& leonid.mesnik at oracle.com -- Alejandro E Murillo, Java Performance Phone: (303) 955-2584. Timezone: US/Mountain (UTC-0700) From edvard.wendelin at oracle.com Wed May 30 00:27:51 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Wed, 30 May 2012 09:27:51 +0200 Subject: [7u6] Request for approval: 7170169: (props) System.getProperty("os.name") should return "Windows 8" when run on Windows In-Reply-To: <4FC5332D.5020506@oracle.com> References: <4FC5332D.5020506@oracle.com> Message-ID: <4380B2E6-6E81-4E1C-B825-4E11831BA86B@oracle.com> Approved! On May 29, 2012, at 10:35 PM, Kurchi Hazra wrote: > > Requesting approval to commit fix for CR 7170169. > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170169 > Webrev: http://cr.openjdk.java.net/~khazra/7170169/7u6/webrev.00/ > > This had been reviewed by darcy, dholmes, alanb, chegar. [1] > > This fix has been pushed into jdk8 [2] > > Thanks, > Kurchi > > [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-May/010233.html > [2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c3d9050c918 > > From henri.gomez at gmail.com Wed May 30 01:48:40 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Wed, 30 May 2012 10:48:40 +0200 Subject: OSX universal build broken in latest jdk7u In-Reply-To: References: Message-ID: > From http://www.cocoabuilder.com/archive/cocoa/311087-about-ivars-declaration-and-property.html, > it seems ivar is not declared as 32bits compatible and as such it > broke universal build. > > Is it an expected feature ? I get some feedbacks from ObjC / Cocoa guys. Universal require some special care. I'm trying this patch right now : http://openjdk-osx-build.googlecode.com/svn/trunk/patches-jdk7u-osx/universal-awt.patch So far, so good, I'll open a bug and will attach the patch From dalibor.topic at oracle.com Wed May 30 02:56:24 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Wed, 30 May 2012 11:56:24 +0200 Subject: [7u6] Request for approval: 7170169: (props) System.getProperty("os.name") should return "Windows 8" when run on Windows In-Reply-To: <4FC5332D.5020506@oracle.com> References: <4FC5332D.5020506@oracle.com> Message-ID: <4FC5EEC8.8010100@oracle.com> Looks fine to me, approved. cheers, dalibor topic On 5/29/12 10:35 PM, Kurchi Hazra wrote: > > Requesting approval to commit fix for CR 7170169. > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170169 > Webrev: http://cr.openjdk.java.net/~khazra/7170169/7u6/webrev.00/ > > This had been reviewed by darcy, dholmes, alanb, chegar. [1] > > This fix has been pushed into jdk8 [2] > > Thanks, > Kurchi > > [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-May/010233.html > [2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c3d9050c918 > > -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From henri.gomez at gmail.com Wed May 30 03:03:46 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Wed, 30 May 2012 12:03:46 +0200 Subject: Bug reporting for jdk7u Message-ID: Hi to all I see a problem with latest jdk7u who broke OSX universal build. I have a patch available to fix it, should I use : https://bugs.openjdk.java.net/ or http://bugreport.sun.com/bugreport/ Cheers From anthony.petrov at oracle.com Wed May 30 03:15:16 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 30 May 2012 14:15:16 +0400 Subject: Bug reporting for jdk7u In-Reply-To: References: Message-ID: <4FC5F334.5030403@oracle.com> Hi Henri, On 5/30/2012 2:03 PM, Henri Gomez wrote: > I see a problem with latest jdk7u who broke OSX universal build. > > I have a patch available to fix it, should I use : > > https://bugs.openjdk.java.net/ Nobody uses it. > or > > http://bugreport.sun.com/bugreport/ This one is the correct place. Please send me the bug id once it is filed. -- best regards, Anthony From henri.gomez at gmail.com Wed May 30 03:25:06 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Wed, 30 May 2012 12:25:06 +0200 Subject: Bug reporting for jdk7u In-Reply-To: <4FC5F334.5030403@oracle.com> References: <4FC5F334.5030403@oracle.com> Message-ID: Just opened it, didn't get back ticket for now. Latest changes in jdk7u broke universal build. Patch available : http://openjdk-osx-build.googlecode.com/svn/trunk/patches-jdk7u-osx/universal-awt.patch Build up to date OpenJDK 7 for OSX with this patch and produced JDK/JRE : http://openjdk-osx-build.googlecode.com/files/OpenJDK-OSX-1.7-universal-u-jdk-jdk7u6-b11-20120530.dmg http://openjdk-osx-build.googlecode.com/files/OpenJDK-OSX-1.7-universal-u-jre-jdk7u6-b11-20120530.dmg Cheers 2012/5/30 Anthony Petrov : > Hi Henri, > > > On 5/30/2012 2:03 PM, Henri Gomez wrote: >> >> I see a problem with latest jdk7u who broke OSX universal build. >> >> I have a patch available to fix it, should I use : >> >> https://bugs.openjdk.java.net/ > > > Nobody uses it. > >> or >> >> http://bugreport.sun.com/bugreport/ > > > This one is the correct place. Please send me the bug id once it is filed. > > -- > best regards, > Anthony From kurchi.subhra.hazra at oracle.com Wed May 30 10:57:08 2012 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Wed, 30 May 2012 17:57:08 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7170169: (props) System.getProperty("os.name") should return "Windows 8" when run on Windows 8 Message-ID: <20120530175718.4E096475C7@hg.openjdk.java.net> Changeset: 3562fc7500a4 Author: khazra Date: 2012-05-30 10:55 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/3562fc7500a4 7170169: (props) System.getProperty("os.name") should return "Windows 8" when run on Windows 8 Summary: Enable Windows Version 6.2 to be recognized as Windows 8 Reviewed-by: darcy, dholmes, alanb, chegar ! src/windows/native/java/lang/java_props_md.c From peter.brunet at oracle.com Wed May 30 13:33:34 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Wed, 30 May 2012 15:33:34 -0500 Subject: [7u6] Request for approval for CR 7172552 - jabswitch utility should not request elevated privilege on the system Message-ID: <4FC6841E.8090005@oracle.com> See http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7172552 Description: - Makefile modified to include version information from resource file for closed source. - This is 7u specific. The webrev is here: http://cr.openjdk.java.net/~asaha/7172552/ This has been reviewed by Pete Brunet ptbrunet and Ragini Prasad raginip and the change looks fine. From dalibor.topic at oracle.com Wed May 30 14:13:08 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Wed, 30 May 2012 23:13:08 +0200 Subject: [7u6] Request for approval for CR 7172552 - jabswitch utility should not request elevated privilege on the system In-Reply-To: <4FC6841E.8090005@oracle.com> References: <4FC6841E.8090005@oracle.com> Message-ID: <4FC68D64.1060106@oracle.com> On 5/30/12 10:33 PM, Pete Brunet wrote: > See http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7172552 > > Description: > - Makefile modified to include version information from resource file > for closed source. > - This is 7u specific. > > The webrev is here: http://cr.openjdk.java.net/~asaha/7172552/ > > This has been reviewed by Pete Brunet ptbrunet and Ragini Prasad raginip > and the change looks fine. > Thanks Pete - I took a look at the webrev as well, and it looks fine to me, too. Approved. cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From kelly.ohair at oracle.com Wed May 30 14:30:57 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Wed, 30 May 2012 21:30:57 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 2 new changesets Message-ID: <20120530213128.115E347625@hg.openjdk.java.net> Changeset: bb8d00b9c06e Author: raginip Date: 2012-05-30 14:02 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/bb8d00b9c06e 7172552: jabswitch utility should not request elevated privilege on the system Reviewed-by: ptbrunet ! make/bridge/Jabswitch/Makefile Changeset: bd2b4dbc3134 Author: ohair Date: 2012-05-30 14:30 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/bd2b4dbc3134 Merge From ahughes at redhat.com Wed May 30 17:19:38 2012 From: ahughes at redhat.com (Andrew Hughes) Date: Wed, 30 May 2012 20:19:38 -0400 (EDT) Subject: hg: jdk7u/jdk7u4: Added tag jdk7u4-b31 for changeset 0faf04aa1dd4 In-Reply-To: <4FA97EFE.9060907@Oracle.COM> Message-ID: <02cebda8-7918-407b-ad79-8b041cb0e8c1@zmail17.collab.prod.int.phx2.redhat.com> ----- Original Message ----- > On 5/8/2012 10:02 AM, david.katleman at oracle.com wrote: > > Changeset: 22e65a573ef9 > > Author: katleman > > Date: 2012-05-07 14:59 -0700 > > URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/rev/22e65a573ef9 > > > > Added tag jdk7u4-b31 for changeset 0faf04aa1dd4 > > > > ! .hgtags > In case that you're wondering why those tags appeared in 7u4 forests > even though the > 7u4 release is done [0], it's because of a bugfix& rebuild [1] of > Oracle JDK/JRE 7u4 > release for customers - Alex Lam found a bug that manifests itself in > the closed sources > only, i.e. there was& is nothing to fix in OpenJDK. > I'm more confused as to why there is a jump from b22 to b31. > > Cheers, > Abhijit Saha > > [0]http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-April/002818.html > [1]http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-May/002893.html > > > -- > Release Lead, Java SE Updates > Java Platform Group > Oracle Corporation. > (408)276-7564 > > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From Abhi.Saha at Oracle.Com Wed May 30 18:06:17 2012 From: Abhi.Saha at Oracle.Com (Abhijit Saha (Oracle)) Date: Wed, 30 May 2012 18:06:17 -0700 Subject: hg: jdk7u/jdk7u4: Added tag jdk7u4-b31 for changeset 0faf04aa1dd4 In-Reply-To: <02cebda8-7918-407b-ad79-8b041cb0e8c1@zmail17.collab.prod.int.phx2.redhat.com> References: <02cebda8-7918-407b-ad79-8b041cb0e8c1@zmail17.collab.prod.int.phx2.redhat.com> Message-ID: <4FC6C409.8010205@Oracle.Com> Hi Andrew, Build # greater than b30 is to address Oracle customer issues and those builds are meant only for our customers. Saying so, 7u4-b31 and up is to resolve customer issues and those fixes will be included into the future 7ux releases depending upon the build schedule. Thanks Abhijit On 5/30/12 5:19 PM, Andrew Hughes wrote: > ----- Original Message ----- >> On 5/8/2012 10:02 AM, david.katleman at oracle.com wrote: >>> Changeset: 22e65a573ef9 >>> Author: katleman >>> Date: 2012-05-07 14:59 -0700 >>> URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/rev/22e65a573ef9 >>> >>> Added tag jdk7u4-b31 for changeset 0faf04aa1dd4 >>> >>> ! .hgtags >> In case that you're wondering why those tags appeared in 7u4 forests >> even though the >> 7u4 release is done [0], it's because of a bugfix& rebuild [1] of >> Oracle JDK/JRE 7u4 >> release for customers - Alex Lam found a bug that manifests itself in >> the closed sources >> only, i.e. there was& is nothing to fix in OpenJDK. >> > I'm more confused as to why there is a jump from b22 to b31. > >> Cheers, >> Abhijit Saha >> >> [0]http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-April/002818.html >> [1]http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-May/002893.html >> >> >> -- >> Release Lead, Java SE Updates >> Java Platform Group >> Oracle Corporation. >> (408)276-7564 >> >> -- Release Lead, Java SE Oracle Corporation 408-276-7564 From david.holmes at oracle.com Wed May 30 18:19:08 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 31 May 2012 11:19:08 +1000 Subject: [7u6] Approval request: 7171653 32-bit cross-compile on 64-bit build host generates 64-bit data for awt/X11 leading to crash Message-ID: <4FC6C70C.6060304@oracle.com> This fix makes a minor change to the build instructions when cross-compiling for 32-bit on a 64-bit host. The JDK 8 changeset is here: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8b4dd321b8a2 Review email threads: http://mail.openjdk.java.net/pipermail/build-dev/2012-May/006206.html JDK 8 webrev: http://cr.openjdk.java.net/~dholmes/7171653/webrev/ The 7u webrev is simplified as the build-infra makefiles fix is not needed: http://cr.openjdk.java.net/~dholmes/7171653/webrev.7u/ Thanks, David From mike.duigou at oracle.com Wed May 30 18:24:31 2012 From: mike.duigou at oracle.com (Mike Duigou) Date: Wed, 30 May 2012 18:24:31 -0700 Subject: [7u6] Request for Approval : 6924259: Remove String.count/String.offset Message-ID: <8C1E350E-718F-4B19-B13C-D49CA12C048B@oracle.com> Hi, This is a request to include an enhancement into JDK 7u6: 6924259: Remove String.count/String.offset Vladimir Kozlov has committed the required HotSpot changes already (http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/8f972594effc). The changes were imported into the jdk7u-dev workspace as part of Alejandro's bulk push. This change has been reviewed on corelibs-dev and has also had considerable internal review as it changed hands during development. The latest webrev for this change is at: http://cr.openjdk.java.net/~mduigou/6924259/1/webrev/ I hope to push in time for the b13 build to: ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk Thanks! Mike From edvard.wendelin at oracle.com Thu May 31 00:10:05 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Thu, 31 May 2012 09:10:05 +0200 Subject: [7u6] Approval request: 7171653 32-bit cross-compile on 64-bit build host generates 64-bit data for awt/X11 leading to crash In-Reply-To: <4FC6C70C.6060304@oracle.com> References: <4FC6C70C.6060304@oracle.com> Message-ID: <4FC7194D.2050400@oracle.com> Looks good David! Approved. Cheers, Edvard On 05/31/2012 03:19 AM, David Holmes wrote: > This fix makes a minor change to the build instructions when > cross-compiling for 32-bit on a 64-bit host. > > The JDK 8 changeset is here: > > http://hg.openjdk.java.net/jdk8/build/jdk/rev/8b4dd321b8a2 > > Review email threads: > > http://mail.openjdk.java.net/pipermail/build-dev/2012-May/006206.html > > JDK 8 webrev: > > http://cr.openjdk.java.net/~dholmes/7171653/webrev/ > > The 7u webrev is simplified as the build-infra makefiles fix is not > needed: > > http://cr.openjdk.java.net/~dholmes/7171653/webrev.7u/ > > Thanks, > David From mike.duigou at oracle.com Thu May 31 00:10:58 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 31 May 2012 07:10:58 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7126277: Alternative String hashing implementation Message-ID: <20120531071119.3ED9B47643@hg.openjdk.java.net> Changeset: 11987e85555f Author: mduigou Date: 2012-05-30 23:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/11987e85555f 7126277: Alternative String hashing implementation Summary: All of the hashing based Map implementations: HashMap, Hashtable, LinkedHashMap, WeakHashMap and ConcurrentHashMap are modified to use an enhanced hashing algorithm for string keys when the capacity of the hash table has ever grown beyond 512 entries. The enhanced hashing implementation uses the murmur3 hashing algorithm along with random hash seeds and index masks. These enhancements mitigate cases where colliding String hash values could result in a performance bottleneck. Reviewed-by: alanb, forax, dl ! make/java/java/FILES_java.gmk ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/LinkedHashMap.java ! src/share/classes/java/util/WeakHashMap.java ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java + src/share/classes/sun/misc/Hashing.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/util/PreHashedMap.java ! test/java/util/Collection/BiggernYours.java ! test/java/util/Hashtable/HashCode.java ! test/java/util/Hashtable/SimpleSerialization.java + test/java/util/Map/Collisions.java ! test/java/util/Map/Get.java + test/sun/misc/Hashing.java From david.holmes at oracle.com Thu May 31 01:59:47 2012 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Thu, 31 May 2012 08:59:47 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7171653: 32-bit cross-compile on 64-bit build host generates 64-bit data for awt/X11 leading to crash Message-ID: <20120531090001.12B2947647@hg.openjdk.java.net> Changeset: 3fc3d4ae7e47 Author: dholmes Date: 2012-05-31 04:58 -0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/3fc3d4ae7e47 7171653: 32-bit cross-compile on 64-bit build host generates 64-bit data for awt/X11 leading to crash Reviewed-by: ohair, anthony ! make/sun/xawt/Makefile From artem.ananiev at oracle.com Thu May 31 02:55:38 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Thu, 31 May 2012 13:55:38 +0400 Subject: [7u6] Request for approval for CR 7172552 - jabswitch utility should not request elevated privilege on the system In-Reply-To: <4FC6841E.8090005@oracle.com> References: <4FC6841E.8090005@oracle.com> Message-ID: <4FC7401A.7090001@oracle.com> Hi, Pete, could you push the fix to JDK8 first, then backport it to 7u6, please? This is a general rule we follow for all the fixes. Thanks, Artem On 5/31/2012 12:33 AM, Pete Brunet wrote: > See http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7172552 > > Description: > - Makefile modified to include version information from resource file > for closed source. > - This is 7u specific. > > The webrev is here: http://cr.openjdk.java.net/~asaha/7172552/ > > This has been reviewed by Pete Brunet ptbrunet and Ragini Prasad raginip > and the change looks fine. > From Dmitry.Degrave at oracle.com Thu May 31 03:11:10 2012 From: Dmitry.Degrave at oracle.com (Dmeetry Degrave) Date: Thu, 31 May 2012 14:11:10 +0400 Subject: [7u6] Request for approval: 7148242: Regression: valid code rejected during generic type well-formedness check Message-ID: <4FC743BE.7030704@oracle.com> Requesting approval to commit fix for 7148242 into 7u6. The fix has already been pushed to jdk8, the code changes for 7u6 are identical. 7148242 "Regression: valid code rejected during generic type well-formedness check" bug: http://bugs.sun.com/view_bug.do?bug_id=7148242 fix: http://cr.openjdk.java.net/~dmeetry/7148242/webrev/ Reviewed by Maurizio Cimadamore. thanks, dmeetry From edvard.wendelin at oracle.com Thu May 31 03:48:03 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Thu, 31 May 2012 12:48:03 +0200 Subject: [7u6] Request for approval: 7148242: Regression: valid code rejected during generic type well-formedness check In-Reply-To: <4FC743BE.7030704@oracle.com> References: <4FC743BE.7030704@oracle.com> Message-ID: <4FC74C63.50300@oracle.com> Approved! Cheers, Edvard On 05/31/2012 12:11 PM, Dmeetry Degrave wrote: > > Requesting approval to commit fix for 7148242 into 7u6. > > The fix has already been pushed to jdk8, the code changes for 7u6 are > identical. > > 7148242 "Regression: valid code rejected during generic type > well-formedness check" > bug: http://bugs.sun.com/view_bug.do?bug_id=7148242 > fix: http://cr.openjdk.java.net/~dmeetry/7148242/webrev/ > > Reviewed by Maurizio Cimadamore. > > thanks, > dmeetry > From edvard.wendelin at oracle.com Thu May 31 03:53:39 2012 From: edvard.wendelin at oracle.com (Edvard Wendelin) Date: Thu, 31 May 2012 12:53:39 +0200 Subject: [7u6] Request for Approval : 6924259: Remove String.count/String.offset In-Reply-To: <8C1E350E-718F-4B19-B13C-D49CA12C048B@oracle.com> References: <8C1E350E-718F-4B19-B13C-D49CA12C048B@oracle.com> Message-ID: <4FC74DB3.5020803@oracle.com> Looks good. On 05/31/2012 03:24 AM, Mike Duigou wrote: > Hi, > > This is a request to include an enhancement into JDK 7u6: > 6924259: Remove String.count/String.offset > > Vladimir Kozlov has committed the required HotSpot changes already (http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/8f972594effc). The changes were imported into the jdk7u-dev workspace as part of Alejandro's bulk push. > > This change has been reviewed on corelibs-dev and has also had considerable internal review as it changed hands during development. The latest webrev for this change is at: > http://cr.openjdk.java.net/~mduigou/6924259/1/webrev/ > > I hope to push in time for the b13 build to: > ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk > > Thanks! > > Mike From dmitry.degrave at oracle.com Thu May 31 04:50:20 2012 From: dmitry.degrave at oracle.com (dmitry.degrave at oracle.com) Date: Thu, 31 May 2012 11:50:20 +0000 Subject: hg: jdk7u/jdk7u-dev/langtools: 7148242: Regression: valid code rejected during generic type well-formedness check Message-ID: <20120531115025.BA26747648@hg.openjdk.java.net> Changeset: c2668fc629cc Author: dmeetry Date: 2012-05-31 15:49 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/c2668fc629cc 7148242: Regression: valid code rejected during generic type well-formedness check Summary: Redundant type-var substitution makes generic-type well-formedness check to fail Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/typevars/T7148242.java From peter.brunet at oracle.com Thu May 31 05:25:12 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Thu, 31 May 2012 07:25:12 -0500 Subject: [7u6] Request for approval for CR 7172552 - jabswitch utility should not request elevated privilege on the system In-Reply-To: <4FC7401A.7090001@oracle.com> References: <4FC6841E.8090005@oracle.com> <4FC7401A.7090001@oracle.com> Message-ID: <4FC76328.4040500@oracle.com> Hi Artem, This is not meant for 8. We might have a better solution by then. -Pete On 5/31/12 4:55 AM, Artem Ananiev wrote: > Hi, Pete, > > could you push the fix to JDK8 first, then backport it to 7u6, please? > This is a general rule we follow for all the fixes. > > Thanks, > > Artem > > On 5/31/2012 12:33 AM, Pete Brunet wrote: >> See http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7172552 >> >> Description: >> - Makefile modified to include version information from resource file >> for closed source. >> - This is 7u specific. >> >> The webrev is here: http://cr.openjdk.java.net/~asaha/7172552/ >> >> This has been reviewed by Pete Brunet ptbrunet and Ragini Prasad raginip >> and the change looks fine. >> From henri.gomez at gmail.com Thu May 31 05:49:17 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Thu, 31 May 2012 14:49:17 +0200 Subject: cacerts and OSX Message-ID: Hi to all, It seems cacerts (JAVA_BASE/Contents/Home/jre/lib/security/cacerts) are no more correct for stock OpenJDK 7 built on OSX. Should we use ALT_CACERTS_FILE var to make use of CACerts provided by Apple JDK instead (/System/Library/Java/Support/CoreDeploy.bundle/Contents/Home/lib/security/cacerts) ? And could we bundle and so provide such cacerts ? From dalibor.topic at oracle.com Thu May 31 06:22:32 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Thu, 31 May 2012 15:22:32 +0200 Subject: cacerts and OSX In-Reply-To: References: Message-ID: <4FC77098.3080000@oracle.com> On 5/31/12 2:49 PM, Henri Gomez wrote: > Hi to all, > > It seems cacerts (JAVA_BASE/Contents/Home/jre/lib/security/cacerts) > are no more correct for stock OpenJDK 7 built on OSX. CA certs aren't part of OpenJDK sources. See http://hg.openjdk.java.net/jdk7/build/raw-file/tip/README-builds.html#cacerts for details, in particular: "The source contain a cacerts file without CA root certificates. Formal JDK builders will need to secure permission from each public CA and include the certificates into their own custom cacerts file." cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From artem.ananiev at oracle.com Thu May 31 06:26:53 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Thu, 31 May 2012 17:26:53 +0400 Subject: [7u6] Request for approval for CR 7172552 - jabswitch utility should not request elevated privilege on the system In-Reply-To: <4FC76328.4040500@oracle.com> References: <4FC6841E.8090005@oracle.com> <4FC7401A.7090001@oracle.com> <4FC76328.4040500@oracle.com> Message-ID: <4FC7719D.1060900@oracle.com> On 5/31/2012 4:25 PM, Pete Brunet wrote: > Hi Artem, This is not meant for 8. We might have a better solution by > then. -Pete OK, got it. Could you file a new SubCR against JDK8 for 7172552 then, so this information is not lost, please? Thanks, Artem > On 5/31/12 4:55 AM, Artem Ananiev wrote: >> Hi, Pete, >> >> could you push the fix to JDK8 first, then backport it to 7u6, please? >> This is a general rule we follow for all the fixes. >> >> Thanks, >> >> Artem >> >> On 5/31/2012 12:33 AM, Pete Brunet wrote: >>> See http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7172552 >>> >>> Description: >>> - Makefile modified to include version information from resource file >>> for closed source. >>> - This is 7u specific. >>> >>> The webrev is here: http://cr.openjdk.java.net/~asaha/7172552/ >>> >>> This has been reviewed by Pete Brunet ptbrunet and Ragini Prasad raginip >>> and the change looks fine. >>> From henri.gomez at gmail.com Thu May 31 06:32:40 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Thu, 31 May 2012 15:32:40 +0200 Subject: cacerts and OSX In-Reply-To: <4FC77098.3080000@oracle.com> References: <4FC77098.3080000@oracle.com> Message-ID: So we should 2012/5/31 Dalibor Topic : > On 5/31/12 2:49 PM, Henri Gomez wrote: >> Hi to all, >> >> It seems cacerts (JAVA_BASE/Contents/Home/jre/lib/security/cacerts) >> are no more correct for stock OpenJDK 7 built on OSX. > > CA certs aren't part of OpenJDK sources. > See http://hg.openjdk.java.net/jdk7/build/raw-file/tip/README-builds.html#cacerts > for details, in particular: > > "The source contain a cacerts file without CA root certificates. Formal JDK builders > will need to secure permission from each public CA and include the certificates into > their own custom cacerts file." That's why I'm wondering if we could embed (for OSX packages) cacerts available in Apple JDK or rebuild full bunch of cacerts from Mozilla for example (ie: http://mxr.mozilla.org/mozilla/source/security/nss/lib/ckfw/builtins/certdata.txt) From dalibor.topic at oracle.com Thu May 31 06:57:46 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Thu, 31 May 2012 15:57:46 +0200 Subject: cacerts and OSX In-Reply-To: References: <4FC77098.3080000@oracle.com> Message-ID: <4FC778DA.6020101@oracle.com> On 5/31/12 3:32 PM, Henri Gomez wrote: > That's why I'm wondering if we could embed CA certificate management is non-trivial matter. Right now it's pretty much orthogonal to OpenJDK development, and it's something for downstream distributors to handle. Personally, I'd like to keep it that way for OpenJDK 7 updates as I don't see the need for doing it in this Project, given that OpenJDK 7u distributors as well as organizations building their own JDKs based on OpenJDK 7u typically have their own ways of managing CA certificates in place specific to their needs. cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From henri.gomez at gmail.com Thu May 31 07:39:22 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Thu, 31 May 2012 16:39:22 +0200 Subject: cacerts and OSX In-Reply-To: <4FC778DA.6020101@oracle.com> References: <4FC77098.3080000@oracle.com> <4FC778DA.6020101@oracle.com> Message-ID: > CA certificate management is non-trivial matter. Right now it's > pretty much orthogonal to OpenJDK development, and it's something > for downstream distributors to handle. > > Personally, I'd like to keep it that way for OpenJDK 7 updates as > I don't see the need for doing it in this Project, given that OpenJDK > 7u distributors as well as organizations building their own JDKs > based on OpenJDK 7u typically have their own ways of managing CA > certificates in place specific to their needs. My question wasn't clear. cacerts inclusion for OSX was at packaging level, ie like those I didn't on openjdk-osx-build, so after stock OpenJDK build process. From mike.duigou at oracle.com Thu May 31 07:43:10 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 31 May 2012 14:43:10 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 6924259: Remove offset and count fields from java.lang.String Message-ID: <20120531144338.DE8E64764A@hg.openjdk.java.net> Changeset: e1c679a00712 Author: mduigou Date: 2012-05-17 10:06 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/e1c679a00712 6924259: Remove offset and count fields from java.lang.String Summary: Removes the use of shared character array buffers by String along with the two fields needed to support the use of shared buffers. Reviewed-by: mduigou, forax Contributed-by: brian.doherty at oracle.com ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/StringCoding.java From scott.kovatch at oracle.com Thu May 31 08:29:10 2012 From: scott.kovatch at oracle.com (Scott Kovatch) Date: Thu, 31 May 2012 08:29:10 -0700 Subject: cacerts and OSX In-Reply-To: References: <4FC77098.3080000@oracle.com> <4FC778DA.6020101@oracle.com> Message-ID: On May 31, 2012, at 7:39 AM, Henri Gomez wrote: >> CA certificate management is non-trivial matter. Right now it's >> pretty much orthogonal to OpenJDK development, and it's something >> for downstream distributors to handle. >> >> Personally, I'd like to keep it that way for OpenJDK 7 updates as >> I don't see the need for doing it in this Project, given that OpenJDK >> 7u distributors as well as organizations building their own JDKs >> based on OpenJDK 7u typically have their own ways of managing CA >> certificates in place specific to their needs. > > My question wasn't clear. > cacerts inclusion for OSX was at packaging level, ie like those I > didn't on openjdk-osx-build, so after stock OpenJDK build process. Henri, I think this is something you would have to bring up with Apple. The cacerts file in Apple's JDK was generated from the certificates in the 'System Roots' keychain (or, it was the last time I was responsible for doing it), so you may not have the legal right to redistribute it. As usual, there are no lawyers here. As Dalibor says, each JDK distributor or licensee is responsible for obtaining their own root certificates, and in Apple's case, they are already distributed via the OS, so the JDK was covered by those licenses. -- Scott K. ---------------------------------------- Scott Kovatch scott.kovatch at oracle.com Santa Clara/Pleasanton, CA From henri.gomez at gmail.com Thu May 31 09:00:19 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Thu, 31 May 2012 18:00:19 +0200 Subject: cacerts and OSX In-Reply-To: References: <4FC77098.3080000@oracle.com> <4FC778DA.6020101@oracle.com> Message-ID: > Henri, I think this is something you would have to bring up with Apple. The cacerts file in Apple's JDK was generated from the certificates in the 'System Roots' keychain (or, it was the last time I was responsible for doing it), so you may not have the legal right to redistribute it. As usual, there are no lawyers here. > > As Dalibor says, each JDK distributor or licensee is responsible for obtaining their own root certificates, and in Apple's case, they are already distributed via the OS, so the JDK was covered by those licenses. Ok, so I'll have to mimic OpenJDKs packaging performed on Linux distribution, using Mozilla provided CA certs. Thanks From peter.brunet at oracle.com Thu May 31 09:26:19 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Thu, 31 May 2012 11:26:19 -0500 Subject: [7u6] Request for approval for CR 7172552 - jabswitch utility should not request elevated privilege on the system In-Reply-To: <4FC7719D.1060900@oracle.com> References: <4FC6841E.8090005@oracle.com> <4FC7401A.7090001@oracle.com> <4FC76328.4040500@oracle.com> <4FC7719D.1060900@oracle.com> Message-ID: <4FC79BAB.9050109@oracle.com> Thanks for the advice Artem. Just did that. On 5/31/12 8:26 AM, Artem Ananiev wrote: > > On 5/31/2012 4:25 PM, Pete Brunet wrote: >> Hi Artem, This is not meant for 8. We might have a better solution by >> then. -Pete > > OK, got it. Could you file a new SubCR against JDK8 for 7172552 then, > so this information is not lost, please? > > Thanks, > > Artem > >> On 5/31/12 4:55 AM, Artem Ananiev wrote: >>> Hi, Pete, >>> >>> could you push the fix to JDK8 first, then backport it to 7u6, please? >>> This is a general rule we follow for all the fixes. >>> >>> Thanks, >>> >>> Artem >>> >>> On 5/31/2012 12:33 AM, Pete Brunet wrote: >>>> See http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7172552 >>>> >>>> Description: >>>> - Makefile modified to include version information from resource file >>>> for closed source. >>>> - This is 7u specific. >>>> >>>> The webrev is here: http://cr.openjdk.java.net/~asaha/7172552/ >>>> >>>> This has been reviewed by Pete Brunet ptbrunet and Ragini Prasad >>>> raginip >>>> and the change looks fine. >>>> From bradford.wetmore at oracle.com Thu May 31 09:44:10 2012 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Thu, 31 May 2012 09:44:10 -0700 Subject: cacerts and OSX In-Reply-To: References: <4FC77098.3080000@oracle.com> <4FC778DA.6020101@oracle.com> Message-ID: <4FC79FDA.5020804@oracle.com> Taking 2 responses in reverse order, Henri wrote: > Ok, so I'll have to mimic OpenJDKs packaging performed on Linux > distribution, using Mozilla provided CA certs. I felt the need to respond to this thread after seeing this statement. You need to check with Mozilla and your lawyers as to whether you can just use theirs for an OpenJDK-based build. CA certs are not something to just grab just so your impl works. There are legal issues involved here, which is the reason we (Oracle) had to include an empty CA file in the first place. It is your responsibility as an OpenJDK builder to resolve the legal issues. Please don't take this lightly. On 5/31/2012 8:29 AM, Scott Kovatch wrote: > On May 31, 2012, at 7:39 AM, Henri Gomez wrote: > >>> CA certificate management is non-trivial matter. Right now it's >>> pretty much orthogonal to OpenJDK development, and it's something >>> for downstream distributors to handle. >>> >>> Personally, I'd like to keep it that way for OpenJDK 7 updates as >>> I don't see the need for doing it in this Project, given that OpenJDK >>> 7u distributors as well as organizations building their own JDKs >>> based on OpenJDK 7u typically have their own ways of managing CA >>> certificates in place specific to their needs. >> >> My question wasn't clear. >> cacerts inclusion for OSX was at packaging level, ie like those I >> didn't on openjdk-osx-build, so after stock OpenJDK build process. > > Henri, I think this is something you would have to bring up with Apple. The cacerts file in Apple's JDK was generated from the certificates in the 'System Roots' keychain (or, it was the last time I was responsible for doing it), so you may not have the legal right to redistribute it. As usual, there are no lawyers here. > > As Dalibor says, each JDK distributor or licensee is responsible for obtaining their own root certificates, and in Apple's case, they are already distributed via the OS, so the JDK was covered by those licenses. This is probably moot now, but if I squinted, tilted my head to a certain angle, and created some ambiguity in pronouns :) , I could potentially misread what I think Scott was trying to say here. What might be clearer: ... and in Apple's case, the CA certs are already distributed via the *Apple OS*, so *Apple's* JDK was covered by those licenses. Your *OpenJDK*-based build likely is not covered by those Apple licenses, and thus you need to check with Apple if you could use theirs. Hope this helps, I didn't want you to think "since I didn't hear anything further, my approach must be ok." Brad From henri.gomez at gmail.com Thu May 31 12:39:42 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Thu, 31 May 2012 21:39:42 +0200 Subject: cacerts and OSX In-Reply-To: <4FC79FDA.5020804@oracle.com> References: <4FC77098.3080000@oracle.com> <4FC778DA.6020101@oracle.com> <4FC79FDA.5020804@oracle.com> Message-ID: 2012/5/31 Bradford Wetmore : > Taking 2 responses in reverse order, Henri wrote: > >> Ok, so I'll have to mimic OpenJDKs packaging performed on Linux >> distribution, using Mozilla provided CA certs. > > I felt the need to respond to this thread after seeing this statement. > > You need to check with Mozilla and your lawyers as to whether you can just > use theirs for an OpenJDK-based build. ?CA certs are not something to just > grab just so your impl works. ?There are legal issues involved here, which > is the reason we (Oracle) had to include an empty CA file in the first > place. > > It is your responsibility as an OpenJDK builder to resolve the legal issues. > ?Please don't take this lightly. > > > On 5/31/2012 8:29 AM, Scott Kovatch wrote: >> >> On May 31, 2012, at 7:39 AM, Henri Gomez ?wrote: >> >>>> CA certificate management is non-trivial matter. Right now it's >>>> pretty much orthogonal to OpenJDK development, and it's something >>>> for downstream distributors to handle. >>>> >>>> Personally, I'd like to keep it that way for OpenJDK 7 updates as >>>> I don't see the need for doing it in this Project, given that OpenJDK >>>> 7u distributors as well as organizations building their own JDKs >>>> based on OpenJDK 7u typically have their own ways of managing CA >>>> certificates in place specific to their needs. >>> >>> >>> My question wasn't clear. >>> cacerts inclusion for OSX was at packaging level, ie like those I >>> didn't on openjdk-osx-build, so after stock OpenJDK build process. >> >> >> Henri, I think this is something you would have to bring up with Apple. >> The cacerts file in Apple's JDK was generated from the certificates in the >> 'System Roots' keychain (or, it was the last time I was responsible for >> doing it), so you may not have the legal right to redistribute it. As usual, >> there are no lawyers here. >> >> As Dalibor says, each JDK distributor or licensee is responsible for >> obtaining their own root certificates, and in Apple's case, they are already >> distributed via the OS, so the JDK was covered by those licenses. > > > This is probably moot now, but if I squinted, tilted my head to a certain > angle, and created some ambiguity in pronouns :) , I could potentially > misread what I think Scott was trying to say here. ?What might be clearer: > > ? ?... and in Apple's case, the CA certs are already distributed via > ? ?the *Apple OS*, so *Apple's* JDK was covered by those licenses. > > Your *OpenJDK*-based build likely is not covered by those Apple licenses, > and thus you need to check with Apple if you could use theirs. > > Hope this helps, I didn't want you to think "since I didn't hear anything > further, my approach must be ok." May be a symlink could fix this issue. Using Apple OSX certs and don't providing it by myself :) From dalibor.topic at oracle.com Thu May 31 13:14:44 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Thu, 31 May 2012 22:14:44 +0200 Subject: cacerts and OSX In-Reply-To: References: <4FC77098.3080000@oracle.com> <4FC778DA.6020101@oracle.com> <4FC79FDA.5020804@oracle.com> Message-ID: <4FC7D134.3030404@oracle.com> On 5/31/12 9:39 PM, Henri Gomez wrote: > May be a symlink could fix this issue. To quote from the OpenJDK FAQ: [0] "Can I expect to get specific legal advice or answers to my legal questions on OpenJDK mailing lists? In general, no. The OpenJDK mailing lists serve for technical work around development of specific OpenJDK projects." I think we've exhausted this topic as far as it concerns this Project. cheers, dalibor topic [0] http://openjdk.java.net/faq/ -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From henri.gomez at gmail.com Thu May 31 13:20:06 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Thu, 31 May 2012 22:20:06 +0200 Subject: cacerts and OSX In-Reply-To: <4FC7D134.3030404@oracle.com> References: <4FC77098.3080000@oracle.com> <4FC778DA.6020101@oracle.com> <4FC79FDA.5020804@oracle.com> <4FC7D134.3030404@oracle.com> Message-ID: > To quote from the OpenJDK FAQ: [0] > > "Can I expect to get specific legal advice or answers to my legal questions on OpenJDK mailing lists? > > In general, no. The OpenJDK mailing lists serve for technical work around development of specific OpenJDK projects." > > I think we've exhausted this topic as far as it concerns this Project. Yes, there is no issue directly, I should see how packagers did for Linux (Redhat/Suse/Canonical) in their enterprise and community version. If they provide an OpenJDK 7, it should came with cacerts so they may have sorted out legals issues (especially community versions). From mike.duigou at oracle.com Thu May 31 13:30:09 2012 From: mike.duigou at oracle.com (Mike Duigou) Date: Thu, 31 May 2012 13:30:09 -0700 Subject: ?Re: hg: jdk7u/jdk7u-dev/jdk: 6924259: Remove offset and count fields from java.lang.String In-Reply-To: <4FC7D023.8090006@oracle.com> References: <20120531144338.DE8E64764A@hg.openjdk.java.net> <4FC7D023.8090006@oracle.com> Message-ID: <42D248B2-1D56-444D-909A-55A923DA7812@oracle.com> In preparing the patches for 6924259 and 7118743 I made a mistake or assumption at at some point regarding the ordering the patches would be applied. My second commit last night broke the JDK7u-dev build. The fix is very straightforward and is correctly applied in the Java 8 workspace. I will create a P1 issue and commit the fix without waiting for explicit commit approval. Sorry for this inconvenience. Mike On May 31 2012, at 13:10 , Se?n Coffey wrote: > Mike, > > Maybe I'm missing something here - but should the murmur3_32 call in String be the same as jdk8 call now ? > > It's still referencing offset, count fields > JDK 8 : > >> h = sun.misc.Hashing.murmur3_32(HASHING_SEED, value, 0, value.length); > >> # Running javac: >> /suspool/home/jdk/jdk1.7.0_04/bin/javac -J-XX:ThreadStackSize=768 -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-client -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -source 7 -target 7 -encoding ascii -Xbootclasspath:../../../build/solaris-sparc/classes -sourcepath ../../../src/closed/solaris/classes:../../../src/closed/share/classes:../../../build/solaris-sparc/gensrc:../../../src/solaris/classes:../../../src/share/classes -d ../../../build/solaris-sparc/classes @../../../build/solaris-sparc/tmp/java/java.lang/java/.classes.list.filtered >> ../../../src/share/classes/java/lang/String.java:3092: error: cannot find symbol >> h = sun.misc.Hashing.murmur3_32(HASHING_SEED, value, offset, count); >> ^ >> symbol: variable offset >> location: class String >> ../../../src/share/classes/java/lang/String.java:3092: error: cannot find symbol >> h = sun.misc.Hashing.murmur3_32(HASHING_SEED, value, offset, count); >> ^ >> symbol: variable count >> location: class String > > > regards, > Sean. > > > On 31/05/2012 15:43, mike.duigou at oracle.com wrote: >> Changeset: e1c679a00712 >> Author: mduigou >> Date: 2012-05-17 10:06 -0700 >> URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/e1c679a00712 >> >> 6924259: Remove offset and count fields from java.lang.String >> Summary: Removes the use of shared character array buffers by String along with the two fields needed to support the use of shared buffers. >> Reviewed-by: mduigou, forax >> Contributed-by: brian.doherty at oracle.com >> >> ! src/share/classes/java/lang/Integer.java >> ! src/share/classes/java/lang/Long.java >> ! src/share/classes/java/lang/String.java >> ! src/share/classes/java/lang/StringCoding.java >> From david.katleman at oracle.com Thu May 31 14:10:42 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 31 May 2012 21:10:42 +0000 Subject: hg: jdk7u/jdk7u: Added tag jdk7u6-b12 for changeset 61cfcee1d00c Message-ID: <20120531211042.3FC1747657@hg.openjdk.java.net> Changeset: 9b9a6d318e8a Author: katleman Date: 2012-05-31 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/rev/9b9a6d318e8a Added tag jdk7u6-b12 for changeset 61cfcee1d00c ! .hgtags From david.katleman at oracle.com Thu May 31 14:10:47 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 31 May 2012 21:10:47 +0000 Subject: hg: jdk7u/jdk7u/corba: Added tag jdk7u6-b12 for changeset 34354c623c45 Message-ID: <20120531211048.56CB447658@hg.openjdk.java.net> Changeset: 76bee3576f61 Author: katleman Date: 2012-05-31 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/corba/rev/76bee3576f61 Added tag jdk7u6-b12 for changeset 34354c623c45 ! .hgtags From david.katleman at oracle.com Thu May 31 14:11:39 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 31 May 2012 21:11:39 +0000 Subject: hg: jdk7u/jdk7u/hotspot: Added tag jdk7u6-b12 for changeset f08a3a0e60c3 Message-ID: <20120531211144.BCC244765A@hg.openjdk.java.net> Changeset: 36f64ab3c9ca Author: katleman Date: 2012-05-31 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/36f64ab3c9ca Added tag jdk7u6-b12 for changeset f08a3a0e60c3 ! .hgtags From mike.duigou at oracle.com Thu May 31 14:11:27 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 31 May 2012 21:11:27 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7173329: Fix build broken by 7126277 to jdk7u-dev Message-ID: <20120531211156.EE99C4765B@hg.openjdk.java.net> Changeset: 6069fe8ffead Author: mduigou Date: 2012-05-31 14:09 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/6069fe8ffead 7173329: Fix build broken by 7126277 to jdk7u-dev Reviewed-by: ahgross ! src/share/classes/java/lang/String.java From david.katleman at oracle.com Thu May 31 14:13:09 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 31 May 2012 21:13:09 +0000 Subject: hg: jdk7u/jdk7u/jaxp: Added tag jdk7u6-b12 for changeset c378e596fb5b Message-ID: <20120531211311.664EB4765C@hg.openjdk.java.net> Changeset: 15b71daf5e69 Author: katleman Date: 2012-05-31 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jaxp/rev/15b71daf5e69 Added tag jdk7u6-b12 for changeset c378e596fb5b ! .hgtags From david.katleman at oracle.com Thu May 31 14:13:16 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 31 May 2012 21:13:16 +0000 Subject: hg: jdk7u/jdk7u/jaxws: Added tag jdk7u6-b12 for changeset 95a96a879b8c Message-ID: <20120531211320.4CB4B4765D@hg.openjdk.java.net> Changeset: e0a71584b8d8 Author: katleman Date: 2012-05-31 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jaxws/rev/e0a71584b8d8 Added tag jdk7u6-b12 for changeset 95a96a879b8c ! .hgtags From david.katleman at oracle.com Thu May 31 14:13:30 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 31 May 2012 21:13:30 +0000 Subject: hg: jdk7u/jdk7u/jdk: Added tag jdk7u6-b12 for changeset 76306dce8710 Message-ID: <20120531211348.BE81F4766A@hg.openjdk.java.net> Changeset: 41d19a05e821 Author: katleman Date: 2012-05-31 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/41d19a05e821 Added tag jdk7u6-b12 for changeset 76306dce8710 ! .hgtags From david.katleman at oracle.com Thu May 31 14:15:09 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 31 May 2012 21:15:09 +0000 Subject: hg: jdk7u/jdk7u/langtools: Added tag jdk7u6-b12 for changeset f0be10a26af0 Message-ID: <20120531211511.8079E4766B@hg.openjdk.java.net> Changeset: e8cd64c324b6 Author: katleman Date: 2012-05-31 14:07 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/e8cd64c324b6 Added tag jdk7u6-b12 for changeset f0be10a26af0 ! .hgtags From mike.duigou at oracle.com Thu May 31 14:20:26 2012 From: mike.duigou at oracle.com (Mike Duigou) Date: Thu, 31 May 2012 14:20:26 -0700 Subject: ?Re: hg: jdk7u/jdk7u-dev/jdk: 6924259: Remove offset and count fields from java.lang.String In-Reply-To: <42D248B2-1D56-444D-909A-55A923DA7812@oracle.com> References: <20120531144338.DE8E64764A@hg.openjdk.java.net> <4FC7D023.8090006@oracle.com> <42D248B2-1D56-444D-909A-55A923DA7812@oracle.com> Message-ID: <2B4D78ED-3224-4EC5-9E42-337BA5A96619@oracle.com> I've fixed the broken build. The CR for the fix is 7173329 and the fix was reviewed by Andrew Gross. Sorry for the inconvenience, Mike On May 31 2012, at 13:30 , Mike Duigou wrote: > In preparing the patches for 6924259 and 7118743 I made a mistake or assumption at at some point regarding the ordering the patches would be applied. My second commit last night broke the JDK7u-dev build. The fix is very straightforward and is correctly applied in the Java 8 workspace. I will create a P1 issue and commit the fix without waiting for explicit commit approval. > > Sorry for this inconvenience. > > Mike > > On May 31 2012, at 13:10 , Se?n Coffey wrote: > >> Mike, >> >> Maybe I'm missing something here - but should the murmur3_32 call in String be the same as jdk8 call now ? >> >> It's still referencing offset, count fields >> JDK 8 : >> >>> h = sun.misc.Hashing.murmur3_32(HASHING_SEED, value, 0, value.length); >> >>> # Running javac: >>> /suspool/home/jdk/jdk1.7.0_04/bin/javac -J-XX:ThreadStackSize=768 -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-client -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -source 7 -target 7 -encoding ascii -Xbootclasspath:../../../build/solaris-sparc/classes -sourcepath ../../../src/closed/solaris/classes:../../../src/closed/share/classes:../../../build/solaris-sparc/gensrc:../../../src/solaris/classes:../../../src/share/classes -d ../../../build/solaris-sparc/classes @../../../build/solaris-sparc/tmp/java/java.lang/java/.classes.list.filtered >>> ../../../src/share/classes/java/lang/String.java:3092: error: cannot find symbol >>> h = sun.misc.Hashing.murmur3_32(HASHING_SEED, value, offset, count); >>> ^ >>> symbol: variable offset >>> location: class String >>> ../../../src/share/classes/java/lang/String.java:3092: error: cannot find symbol >>> h = sun.misc.Hashing.murmur3_32(HASHING_SEED, value, offset, count); >>> ^ >>> symbol: variable count >>> location: class String >> >> >> regards, >> Sean. >> >> >> On 31/05/2012 15:43, mike.duigou at oracle.com wrote: >>> Changeset: e1c679a00712 >>> Author: mduigou >>> Date: 2012-05-17 10:06 -0700 >>> URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/e1c679a00712 >>> >>> 6924259: Remove offset and count fields from java.lang.String >>> Summary: Removes the use of shared character array buffers by String along with the two fields needed to support the use of shared buffers. >>> Reviewed-by: mduigou, forax >>> Contributed-by: brian.doherty at oracle.com >>> >>> ! src/share/classes/java/lang/Integer.java >>> ! src/share/classes/java/lang/Long.java >>> ! src/share/classes/java/lang/String.java >>> ! src/share/classes/java/lang/StringCoding.java >>> > From mike.duigou at oracle.com Thu May 31 22:47:26 2012 From: mike.duigou at oracle.com (Mike Duigou) Date: Thu, 31 May 2012 22:47:26 -0700 Subject: [7u6] Request for Approval : 7173432: Remove String.count/String.offset Message-ID: Hi, This is a request to include a bug fix into JDK 7u6: 6924259: Handle insertion of null key at HashMap resize This is a bug fix for the recently integrated CR#7126277 which fixes a bug uncovered during integration testing. There is a webrev of the fix plus a regression test open for review. I still need a reviewer in addition to approval before I can commit. http://cr.openjdk.java.net/~mduigou/7173422/0/webrev/ This fix blocks the b13 build. When ready I will push to: ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk Thanks! Mike From dalibor.topic at oracle.com Thu May 31 23:10:19 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Fri, 01 Jun 2012 08:10:19 +0200 Subject: [7u6] Request for Approval : 7173432: Remove String.count/String.offset In-Reply-To: References: Message-ID: <4FC85CCB.5090007@oracle.com> On 6/1/12 7:47 AM, Mike Duigou wrote: > Hi, > > This is a request to include a bug fix into JDK 7u6: > 6924259: Handle insertion of null key at HashMap resize > > This is a bug fix for the recently integrated CR#7126277 which fixes a bug uncovered during integration testing. > > There is a webrev of the fix plus a regression test open for review. I still need a reviewer in addition to approval before I can commit. > > http://cr.openjdk.java.net/~mduigou/7173422/0/webrev/ > > This fix blocks the b13 build. When ready I will push to: > ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk > > Thanks! > Looks fine. Approved! cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From andrew.brygin at oracle.com Thu May 31 23:55:21 2012 From: andrew.brygin at oracle.com (Andrew Brygin) Date: Fri, 01 Jun 2012 10:55:21 +0400 Subject: [7u6] Request for approval: 7120895: FontConfiguration should not use thread contextClassLoader Message-ID: <4FC86759.9030304@oracle.com> Hello, Requesting approval to commit fix for 7120895 into 7u6. The fix has already been pushed to jdk8, the code change for 7u6 is identical. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7120895 jdk8 changeset: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d988ed9d40bc Webrev: http://cr.openjdk.java.net/~bae/7120895/7u6/webrev.00/ Review thread: http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002551.html Reviewed by: Igor Nekrestyanov Thanks, Andrew