[8u40] Request for approval for 8065132 and 8029012
jonathan.gibbons at oracle.com
Tue Nov 25 03:38:07 UTC 2014
The webrev looks like it has some problems, such as "duplicate" copies
of test files (perhaps by bad composition of the two underlying patches)
and the webrev shows strange inconsistencies of some test files having
Patch entries and some having Raw entries, and some having both.
On 11/24/2014 02:21 PM, Seán Coffey wrote:
> Since it's not a clean patch application, can you obtain a code review
> first before pushing ?
> Approved but subject to above request.
> On 24/11/2014 21:25, Eric McCorkle wrote:
>> Please approve the backport for these two fixes, which cause javac to
>> generate Runtime[In]Visible[Type,Parameter]Annotations attributes that
>> correctly account for synthetic parameters.
>> Note that the patches did not apply cleanly. In the case of 8029012,
>> langtools SQE staff have added cases to the
>> referenceinfos/Constructor.java test that are not present in 8u. For
>> 8065132, diamondification made a behavior-invariant change to the source
>> in ClassWriter.java
>> After these changes, all tests pass.
>> The JBS issues are here:
>> A webrev containing both changesets is here:
More information about the jdk8u-dev