RfR and RfA: Backport of JDK-8055831 Open Source Java Access Bridge

Seán Coffey sean.coffey at oracle.com
Mon Mar 30 19:05:20 UTC 2015


I'm not a reviewer for this but I notice that some files have the 
incorrect copyright header (PROPRIETARY/CONFIDENTIAL) - Please correct 
that before any push. I think it's also safer if you run both an OpenJDK 
build and a closed/open src build through JPRT. It'll handle both.


On 30/03/2015 19:39, Pete Brunet wrote:
> p.s. The 7 JPRT builds ran OK: 2 win, 2 linux, 2 solaris, 1 mac
> On 3/30/15 11:10 AM, Pete Brunet wrote:
>> Erik, I made the changes that you pointed out.  Builds worked OK for
>> local closed and open.  I also started a JPRT build for all
>> platforms.  That's 7 targets and since that will take a while I wanted
>> to publish the new patch before you left for the day:
>> http://cr.openjdk.java.net/~ptbrunet/JDK-8076182/webrev.01/
>> Pete
>> On 3/30/15 2:43 AM, Erik Joelsson wrote:
>>> Hello,
>>> In jdk/make/CompileJavaClasses.gmk:
>>> You removed
>>> $(JDK_TOPDIR)/src/closed/$(OPENJDK_TARGET_OS_API_DIR)/classes, but
>>> for linux and solaris, that source dir is still needed. Is it giving
>>> you an error when the directory doesn't exist? In that case you will
>>> need to make it conditional on platform.
>>> jdk/make/CompileLaunchers.gmk:
>>> If jabswitch is open source, then it shouldn't be built under the
>>> condition "ifndef OPENJDK".
>>> jdk/make/CopyFiles.gmk:
>>> ifndef OPENJDK
>>> jdk/make/gensrc/GensrcMisc.gmk:
>>> ifndef OPENJDK
>>> jdk/make/lib/PlatformLibraries.gmk:
>>> ifndef OPENJDK
>>> I would recommend getting an open only forest, apply your patch and
>>> verify that you get everything built properly.
>>> /Erik
>>> On 2015-03-28 01:30, Pete Brunet wrote:
>>>> Please review and approve a backport of JDK-8055831 to open source the
>>>> Java Access Bridge.  The original patch has been pushed to 9 and the
>>>> backport now needs to be pushed to 8u.
>>>> Due to the significant directory structure changes in 9 due to
>>>> modularization I could not simply apply the patch.  However the effect
>>>> is functionally the same.  Here are the changes:
>>>> - moved the JAB files from closed to open
>>>> - change the copyright headers to open style
>>>> - adjust the make files accordingly
>>>> - create javadoc for com.sun.java.accessibility.util; creates it in
>>>> docs/jre/api/accessibility/jaccess/spec
>>>> - removed extraneous unused files; these are tools inadvertently picked
>>>> up in 7u6 when the JAB was first integrated and which will be added later
>>>> - removed some dead code
>>>> - cleaned up comments/documentation
>>>> - cleaned up some code indentation issues
>>>> - in package-private EventQueueMonitor.addTopLevelWindow the return
>>>> value was not used so I changed the return from boolean to void
>>>> The open part of the patch is here:
>>>> http://cr.openjdk.java.net/~ptbrunet/JDK-8076182/webrev.00/
>>>> (I see I have five copyright dates to fix in jdk/make.)
>>>> There is a closed part but it's just the removal of the source files
>>>> from the closed repository.
>>>> The patch has been through a successful 32/64 bit JPRT build and
>>>> subsequent testing on my machine
>>>> This patch needs to be pushed by Tuesday so I'll appreciate your review.
>>>> Thanks, Pete

More information about the jdk8u-dev mailing list