[8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing

Erik Joelsson erik.joelsson at oracle.com
Mon Oct 5 09:38:09 UTC 2015

Another friendly bump for an 8u (R)eviewer for this.


On 2015-10-01 15:16, Erik Joelsson wrote:
> Still looking for an official review from 8u reviewer for this. 
> Ideally someone from Hotspot.
> /Erik
> On 2015-09-30 14:43, Erik Joelsson wrote:
>> Hello,
>> Please approve and review this fix for 8u.
>> My last fix for this issue, JDK-8136691, was not enough. I made a 
>> mistake while verifying the fix and the problem is still there.
>> There are more discrepancies between Solaris and the other platform 
>> makefiles. The excludeSrc.gmk file is not included anywhere when 
>> building on Solaris. The variable Src_Files_EXCLUDE is overwritten in 
>> vm.make instead of appended to, so even when including 
>> excludeSrc.gmk, it wasn't enough. The other platform specific 
>> buildtree.make files also set INCLUDE_TRACE in the generated makefile.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8136980
>> Webrev: http://cr.openjdk.java.net/~erikj/8136980/webrev.hotspot.01/
>> /Erik

More information about the jdk8u-dev mailing list