[8u76] Request for approval for CR8146566: OpenJDK build can't handle commas in LDFLAGS

Andrew Hughes gnu.andrew at redhat.com
Wed Jan 6 19:10:09 UTC 2016

Bug: https://bugs.openjdk.java.net/browse/JDK-8146566
Webrev: http://cr.openjdk.java.net/~andrew/8u/8146566/webrev.01/

If additional LDFLAGS containing commas are passed to the build e.g.

--with-extra-ldflags="-Wl,--as-needed -Wl,-O1 -Wl,--hash-style=gnu -Wl,--sort-common"

(which are the default flags on Fedora), then the build will fail as the call to
SetupNativeCompilation expands LDFLAGS_JDKLIB early and the commas are interpreted
to denote separate arguments to this macro.

On current 8u, this only affects the demo code (BUILD_DEMO_JVMTI_$1). It did
affect both the demo code and the main JDK build on 9, and I was planning
to submit a similar fix there. However, 8142907 was added which fixed both cases
there, as well as introducing a number of other changes.

For 8u, I'd like to backport the relevant part of 8142907 under this bug, 8146566.
Without this fix, the build fails with the above option. With it,
it successfully completes. 8142907 in full contains other changes, many specific
to Mac OS, which would introduce unnecessary changes into the 8u build.

Ok to push this?
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07

More information about the jdk8u-dev mailing list