[8u-dev] Request for approval: 8147857: RMIConnector logs attribute names incorrectly
sean.coffey at oracle.com
Mon Jan 25 10:31:42 UTC 2016
Approved. I can push this change for you. I'll push it through out
testing framework (JPRT) first.
On 25/01/16 09:43, Severin Gehwolf wrote:
> On Mon, 2016-01-25 at 09:41 +0100, Jaroslav Bachorik wrote:
>> On 22.1.2016 17:49, Seán Coffey wrote:
>>> On 22/01/16 15:58, Andrew Hughes wrote:
>>>>>> Yes - please fix this issue in JDK 9 first as per rule 1:
>>>>>> In a nutshell, produce a JDK 9 webrev, send it to
>>>>>> serviceability-dev at openjdk.java.net for review and once reviewed, push
>>>>>> to jdk9/dev forest. Once done, you can then submit a JDK 8u integration
>>>>>> approval request.
>>>> I've applied Severin's patch to 9 and it applies as-is, once shuffled.
>>>> Are the existing reviews sufficient? Jaroslav, Daniel & I have all OKed
>>>> it already.
>>>> I do think the copyright notice should read 'Red Hat' and I've raised
>>>> this with Severin.
>>> I'm not sure. Everyone reviews and fixes in JDK 9 first and then
>>> backports where necessary. Since this was also reviewed on
>>> serviceability-dev, I think you might not need another round of reviews.
>> The changeset targeted by this fix was only in JDK 9 CPU until very
>> recently. Therefore it was not really possible for an external
>> contributor to develop a patch against JDK 9. JDK 8 CPU changes, on the
>> other hand, have already been upsynced to JDK 8 Dev.
> Since this has been pushed to 9 now, OK to to go to JDK 8u as well? The
> change is the same as for 9 after unshuffling.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8147857
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8147857/webrev.02/
> Since I'd need a sponsor for pushing this, I'm attaching the hg-
> exported changeset as well.
More information about the jdk8u-dev