[8u] Request for enhancement backport approval for 8059038: Create new launcher for SA tools
kevin.walls at oracle.com
Wed Dec 12 11:24:06 UTC 2018
Yes, jhsdb has a doc page that's new in 9. In jdk8, jstack, jmap, ...
have man pages, but CLHSDB remained hidden so has never had one.
Yes, I was keen not to backport a variant of the SALauncher that knew
these two tools alone, creating individual launchers for tools has been
the way it was done in 8.
But what to call them? The SA Tool JStack becomes "jstack" as a
standalone executable. Although most things have that "j" prefix, the
SA Tools CLHSDB and HSDB have never had it, they've never been known as
jclhsdb or jhsdb, e.g. in jdk8u-dev/hotspot/agent/doc/clhsdb.html they
never had a "J" prefix when they were invoked by a script/.bat.
If we're going with creating new launchers in jdk8u-dev/jdk/make, like
jstack etc, then I would suggest calling them to just "clhsdb" and
"hsdb", that's what I'd expect as a user (and as a historian 8-) ).
On 12/12/2018 10:37, Severin Gehwolf wrote:
> On Wed, 2018-12-12 at 10:29 +0000, Andrew Haley wrote:
>> On 12/12/18 10:27 AM, Severin Gehwolf wrote:
>>> On Wed, 2018-12-12 at 10:15 +0000, Andrew Haley wrote:
>>>> On 11/28/18 2:14 PM, Kevin Walls wrote:
>>>>> Sure I completely support the intent to have launchers for CLHSDB and
>>>>> HSDB in there. Yes I would advise to not create a new but different
>>>>> version of the jhsdb command in 8, as it would look like later JDKs and
>>>>> not function the same way. I'm happy that you're happy to do it that way.
>>>>> Clearly needs a maintainer comment regarding enhancement approval.
>>>> I support this, but I still can't tell what you've decided to do.
>>> The enhancement got the approval (from Andrew Hughes) and my plan was
>>> to get to a decision as to the *how* on the 8u review thread. Right now
>>> there are two options:
>>> A) Mimic JDK 9+
>>> CLI launch => $ jhsdb clhsdb
>>> GUI launch => $ jhsdb hsdb
>>> That's what the current webrev does.
>>> B) Create separate launchers for CLI/GUI. Perhaps this?
>>> CLI launch => $ jclhsdb
>>> GUI launch => $ jhsdb
>>> B) is Kevin's proposal.
>>> Any opinions?
>> A small preference for B, but I'm content either way.
> OK, thanks.
>> Are there any changes
>> to documentation?
> AFAIK this doesn't exist in JDK 8 yet. JDK 9 has. So perhaps.
> As to the where and the how I'm not sure. Will there be (separate)
> documentation for OpenJDK 8 post oracle's maintainership?
>  https://docs.oracle.com/javase/9/tools/jhsdb.htm#JSWOR-GUID-0345CAEB-71CE-4D71-97FE-AA53A4AB028E
More information about the jdk8u-dev