Review for a fix in the launcher setting the bootclasspath for legacy mode
Alan.Bateman at Sun.COM
Mon Feb 8 11:41:24 PST 2010
Mandy Chung wrote:
> I fixed a bug in the launcher that allocates the buffer of an
> incorrect length for holding the bootclasspath VM option and also
> clean up the wildcardModuleDirList function to use stack variables (vs
> using wildcardConcat whose return value should be freed).
This looks okay to me. Minor comment is that in SetModulesBootClassPath
you could store the length of vmoption to avoid calling JLI_Strlen
twice.. Also should basename be declared const in wldcardModuleDirList?
More information about the jigsaw-dev