jonathan.gibbons at oracle.com
Tue Jun 1 08:41:29 PDT 2010
On 05/28/2010 02:21 PM, Dalibor Topic wrote:
> Here's a small patch for review:
> * jpkg sets resources parameter to module path if no resources path is
> explicitly given.
> But of course, that's not enough, so we have to make sure that we only
> start writing a resource section if there are actually resources to be
> stuffed into a jmod file - i.e. the check whether the resource path is
> empty is not sufficient in that case, as the modulepath could be chock
> full of class files, with no other file in sight. So ...
> * module file format gets a utility method to check if a path contains
> files that are not class files.
> And to make that a bit easier
> * Files gets a few small helper methods to tell if a file name is a
> class name.
> Notable differences: this means that *.properties files that were
> up until now not necessarily picked up as a resource, if they were only
> in the classes/ dirs and not in the resources/ dirs, will now get a
> place in the resources section of a jmod file.
> I hope this fits what Jon had in mind, I'd appreciate a review while I
> go hack on the tests.
> dalibor topic
I haven't reviewed the code, but the functionality seems like what I had
More information about the jigsaw-dev