Review of platform modules & class analyzer change
Alan.Bateman at oracle.com
Thu Jun 3 09:40:35 PDT 2010
mark.reinhold at oracle.com wrote:
>> Date: Tue, 18 May 2010 22:37:05 -0700
>> From: mandy.chung at oracle.com
> The module-definition changes look good.
> I haven't reviewed the class-analyzer changes in detail; Alan, could you
> please take a closer look?
Mandy - I went through the module changes when you sent this out
originally and they also look good to me.
I've now gone through the class analyzer changes. One small concern is
that the names of the aggregator modules has slipped into Platform.java
so it's yet another place that needs to maintained if/when we make
changes. The usage of the Platform methods (such as in ClassAnalyzer
when printing the module lists for example) also means there are other
places that know about the aggregation. Otherwise the changes are fine.
At some point it would be good to do a clean-up pass over the class
analyzer as it has grown and has been modified many times. Low priority
compared to other tasks of course.
More information about the jigsaw-dev