Add modules target in the forest's topdir Makefile
Mandy.Chung at Sun.COM
Fri Mar 5 12:04:59 PST 2010
Kelly O'Hair wrote:
> I'm not sure you need the
> ifdef HAVE_JPRT_SAVE_MODULES
Yes. I would always want to bundle the modules up. I'll replace it with
Some time in the future, I would want some way to specify what modules
to build and install on top of the base-image and perform the
appropriate testing. jdk-module-image won't need to be bundled at that
Thanks for the review.
> I suspect you can just use ifdef BUILD_MODULES, assuming if
> modules were built, you would always want them bundled up and
> returned back, but it's up to you.
> Otherwise, looks fine.
> On 3/5/10 10:15 AM, Mandy Chung wrote:
>> I'm adding a "modules" target in the topdir's Makefile that will pass
>> the modules target to the jdk build. This provides a convenience way to
>> build the jdk module images. In addition, the jprt build will archive
>> the jdk-module-image and use it for testing.
>> Can you please review this change?
More information about the jigsaw-dev