Code review request for SecurityManager changes
sean.mullan at oracle.com
Mon May 10 12:46:30 PDT 2010
On 5/10/10 1:40 PM, Mandy Chung wrote:
> Hi Sean,
> The fix looks okay to me.
> line 94: nit: probably better to replace the test "".equals(s) with
> Can you add further comment in the @summary tag to describe what the
> test does?
This also includes a fix for the first of Roger's comments. I need more time to
think about the second comment; will look at it later.
> Are you planning to look at the jigsaw APIs and add the proper @throws
> SecurityException (and the required security permission) in the spec at
> some point in time?
Yes, I will look at that later this week.
> Sean Mullan wrote:
>> for an initial set of changes to allow modules to be run with a
>> ModuleClassLoader now extends SecureClassLoader.
>> There is no CodeSigner support yet. That will be coming later after we
>> integrate signed modules.
More information about the jigsaw-dev