Code Review Request: running signed modules with SecurityManager
mandy.chung at oracle.com
Thu May 27 11:42:23 PDT 2010
On 05/26/10 15:02, Sean Mullan wrote:
> Please review the webrev below which contains code changes that add support for
> running signed modules with a SecurityManager.
Some minor comments:
Should the defineModule method take a CodeSource parameter?
line 355: I wonder if the returned type should prefer Set<CodeSigner>
to an array while the existing methods such as JarEntry.getCodeSigners
line 196: Are we going to create a CodeSource object with a non-null
URL some time?
line 540: When CNFE is thrown, I think AssertionError or InternalError
is more appropriate.
line 237, 242 - you can use Files.delete(() that will throw IOException
if it fails to delete the file.
More information about the jigsaw-dev