Modular JAR file support
mandy.chung at oracle.com
Wed Apr 6 11:31:15 PDT 2011
On 4/6/11 11:08 AM, Alan Bateman wrote:
> Mandy Chung wrote:
>> Webrev at:
> I went through the webrev and the changes mostly look good to me, easy
> to follow. A general comment is that the install is open to races with
> other concurrent access to the module library but that's a bigger
> problem, not a big concern for this.
Right, this is a bigger problem that we need to get to that at some
point. Looks like the concurrent access is not mentioned in the TODO
comment; I'll add that.
> I read the mail from David Schlosnagle on the missing close and a
> related suggestion for using try-with-resources is that
> ModuleFileFormat.Reader could implement Closeable which would allow a
> bit of clean-up in SimpleLibrary.install.
I think you meant AutoCloseable? Sounds a good idea.
> Minor nit, the copyright year on the test in 2009.
More information about the jigsaw-dev