Code Review request for new "jsign" tool
sean.mullan at oracle.com
Fri Jul 1 13:41:56 PDT 2011
On 7/1/11 1:22 PM, Mandy Chung wrote:
>>> L630-637: I believe if noExtract is true, destination will be null;
>>> destination is non-null. Looks like you don't need the noExtract flag
>>> perhaps replaced with needExtract method? Just a thought.
>> I have not done this. Since there are several public methods that are
>> affected by this flag, I think it is better (and the code is easier to
>> understand) to use a flag to denote this behavior.
> It's fine to keep the flag. There are a couple places of the double
> negative check "if (!noExtract)"? Would it be better to change the flag
> to "extract" rather than "noExtract"?
Yep. Sounds good.
Thanks for the comments,
More information about the jigsaw-dev