Patch for jigsaw tests to run on all platforms
kelly.ohair at oracle.com
Mon Mar 14 13:43:50 PDT 2011
On Mar 14, 2011, at 12:07 PM, Mandy Chung wrote:
> On 3/14/11 11:47 AM, Alan Bateman wrote:
>> Mandy Chung wrote:
>>> This patch fixes the jigsaw tests to run on all platforms and also
>>> replace calls to the java.io.File.renameTo method with
>>> java.nio.file.Files.move method since on windows File.renameTo
>>> fails if the target file exists.
>>> Webrev at:
>> I went through the change and looks okay to me.
>> I'm not sure what to say about test/org/openjdk/jigsaw/hello-native.sh as we can't assume a C compiler on the test machine and checking in pre-build shared libraries is frowned upon.
> Yeah... I know... probably we have to rely on SQE tests to cover the testing for native libraries. Right now all jprt machines have the C compilers installed and we can temporarily leave with this dependency until such functionality is covered in other test harness.
Technically, the Windows and Linux systems have C compilers installed because they are part of the
system software, but on Solaris and the Sun Studio compilers, the compilers are installed for build
targets only, and a particular one is installed. So test targets cannot be guaranteed that a compiler
is on the system for Solaris. However, there should be a gcc compiler installed as part of the base
Solaris system install. I kind of expect Solaris systems to have all the "Solaris" developer tools
to be part of the system, but that does not include the Sun Studio compilers which are separate products.
This was was a recent change, partially for the Embedded team, but to also trim down the overhead
needed to get a test target started and minimize what a test system needs installed.
The Embedded systems they want to test have limited capacity.... Yeah I know, JPRT running on an
embedded arm device... seems strange... but they still want to see if it can work. ;^)
>> I'll leave the JPRT updates to Kelly but I think you should be able to run the Jigsaw tests already with -otests '.*jdk_jigsaw.*'
> There was some issue with -otests option some time ago that didn't exclude the default test targets.
> We had to use -etests as a workaround at that time. I just tried dry run with the -otests option and looks like Kelly fixed that. I will take out the jprt.properties change.
Keep in mind that the default lists change with "-testset NAME", so if you want the full list of available
test targets, then only run select ones, the recommendation is "-testset all -otests '.*jigsaw.*'" or something like that.
More information about the jigsaw-dev