Allow remote repository to be located via non-http URI
chris.hegarty at oracle.com
Mon Feb 13 05:52:11 PST 2012
This looks fine to me.
Trivially, can the Files.move (RR.java L166 of new file) be moved into
the first try-catch? I just can't see that the separate try-catch is
On 13/02/2012 13:10, Alan Bateman wrote:
> On 07/02/2012 11:30, Alan Bateman wrote:
>> On 07/02/2012 11:05, Chris Hegarty wrote:
>>> The error handling in SimpleLibrary$RepoList.add could be more robust
>>> to handle this by removing the repoDir ( and its contents ) and
>>> possibly decrementing the count?
>> I agree the error handling should be more robust and it should
>> rollback the changes but this is an existing problem. I'd prefer to
>> separate it from this patch. I also think there is a lot more than
>> could be done with the repository support, it's very much a prototype
>> implementation at present.
> Just to follow up this discussion. The issue with not cleaning up after
> a failed attempt to add a remote repository is annoying so I've put a
> patch to fix it here:
> I'll add tests to cover this and other scenarios where expanding the
> tests for this area (as per the discussion with Mandy).
More information about the jigsaw-dev