RFR: Some intermittent org/openjdk/jigsaw test failures.
chris.hegarty at oracle.com
Thu Feb 23 02:53:49 PST 2012
I updated the webrev as per review comments and also fixed two more
failing tests ( and one was a "real" bug ;-) )
- Thread.sleep increased from 1 sec to 2 secs
- org/openjdk/jigsaw/cli/timestamp-test.sh fails on windows
SimpleLibrary.reIndex was not closing the handle to the modules
classes archive, therefore the test could not do its necessary
cleanup. I also removed some unnecessary args to jpkg in the test
and added a warning for easier diagnosability (arguably this could
keystorePasswordURL did not contain the protocol scheme
On 22/02/2012 16:11, Alan Bateman wrote:
> On 22/02/2012 16:04, Chris Hegarty wrote:
>> On 22/02/2012 15:43, Alan Bateman wrote:
>>> Thanks for sorting these out, it was annoying for these tests not to be
>>> pass on all platforms.
>>> In _RemoteRepository. testRemove the sleep is 1s but this may not be
>>> sufficient to ensure a new time stamp (legacy FAT32 has a granularity of
>>> 2s for example).
>> Yes, I think 2 or 3 seconds would be better.
>>> I'm curious about _RemoteRepositoryList.local as I would have thought
>>> that we have many tests (in the networking area at least) that would
>>> also fail if once could connect to the host name.
>> This test was failing at L145 "assert rr.location().equals(u1);".
>> RemoteRepository stores it's location() as a URI with a canonical host
>> name ( where possible ). Since URI.equals does a string comparison,
>> equalIgnoringCase, then the hosts need to be the same.
> Okay, I didn't know which assert was failing. In that case it make sense.
More information about the jigsaw-dev