RFR: jmod remove
Alan.Bateman at oracle.com
Thu May 10 08:36:25 PDT 2012
On 09/05/2012 15:31, Chris Hegarty wrote:
> I finally got back to this. Comments inline...
> Updated webrev:
We've gone several rounds on this and I think I'm mostly mostly happy.
Mandy - do you plan to do another review? I'm happy to push this for
Chris once it is final.
A couple of small points:
Files.deleteTreeUnchecked - the code is still catching the "useful"
IOException and throwing a less useful IOException. I would suggest just
replacing each one with execs.add(x).
In SimpleLibrary.moduleTrashDir it uses SecureRandom but I think that is
overkill. A sequence number of java.util.Random should be fine.
More information about the jigsaw-dev