RFR: jmod remove
chris.hegarty at oracle.com
Thu May 10 14:18:11 PDT 2012
On 10/05/12 16:36, Alan Bateman wrote:
> We've gone several rounds on this and I think I'm mostly mostly happy.
> Mandy - do you plan to do another review? I'm happy to push this for
> Chris once it is final.
> A couple of small points:
> Files.deleteTreeUnchecked - the code is still catching the "useful"
> IOException and throwing a less useful IOException. I would suggest just
> replacing each one with execs.add(x).
Done. At one point I thought it may be cleaner for tools when reporting
an issue, but you're right.
> In SimpleLibrary.moduleTrashDir it uses SecureRandom but I think that is
> overkill. A sequence number of java.util.Random should be fine.
More information about the jigsaw-dev