JDK support for VM to read classes from modules in a module library
Alan.Bateman at oracle.com
Wed May 16 10:42:10 PDT 2012
On 05/05/2012 07:38, Mandy Chung wrote:
> You can also look at all changes together in this webrev:
I've gone through the changes in the combined webrev, except for
jigsaw.c where I only skimmed it because it's tied to the current
configuration and so will change.
I think the native interface looks fine, the only minor comment is that
I'd probably use typedef struct module.
Of the Class.forName usages that have changed then one that didn't look
right is Properties where the workaround is to use the loader for the
base module to load XMLUtils. Given that XMLUtil is currently in the
jaxp module (and I know this isn't quite right either as JAXP is a
standalone technology etc.) then I would think that the Properties code
will need to do a Class.forName on an exported javax.xml type and use
that loader (or alternative use jdk.jaxp).
In ServiceLoader you've changed the comment at L515 to "caller's class
loader" but it should be "the caller's caller's class loader".
I didn't quite get why src/share/native/java/lang/System.c was changed,
was this for debugging?
Otherwise I look forward to see this in, along with Karen's patch.
More information about the jigsaw-dev